From patchwork Tue Jan 18 05:31:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Herbert Xu X-Patchwork-Id: 533322 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FFC5C433EF for ; Tue, 18 Jan 2022 05:31:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229510AbiARFbr (ORCPT ); Tue, 18 Jan 2022 00:31:47 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:59636 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235752AbiARFbq (ORCPT ); Tue, 18 Jan 2022 00:31:46 -0500 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1n9h5d-0006et-EJ; Tue, 18 Jan 2022 16:31:30 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Tue, 18 Jan 2022 16:31:29 +1100 Date: Tue, 18 Jan 2022 16:31:29 +1100 From: Herbert Xu To: kernel test robot Cc: Stephan =?iso-8859-1?q?M=FCller?= , Mat Martineau , LKML , lkp@lists.01.org, lkp@intel.com, Linux Crypto Mailing List Subject: [PATCH] crypto: kdf - Select hmac in addition to sha256 Message-ID: References: <20220118015649.GA12486@xsang-OptiPlex-9020> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220118015649.GA12486@xsang-OptiPlex-9020> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Jan 18, 2022 at 09:56:49AM +0800, kernel test robot wrote: > > [ 42.753085][ T1] WARNING: CPU: 1 PID: 1 at crypto/kdf_sp800108.c:138 crypto_kdf108_init (crypto/kdf_sp800108.c:136) > [ 42.754665][ T1] Modules linked in: > [ 42.755366][ T1] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 5.16.0-rc1-00049-gd3b04a4398fe #2 > [ 42.756752][ T1] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014 > [ 42.758199][ T1] RIP: 0010:crypto_kdf108_init (crypto/kdf_sp800108.c:136) > > CONFIG_CRYPTO_HMAC=m > CONFIG_CRYPTO_KDF800108_CTR=y ---8<--- In addition to sha256 we must also enable hmac for the kdf self-test to work. Reported-by: kernel test robot Fixes: 304b4acee2f0 ("crypto: kdf - select SHA-256 required...") Fixes: 026a733e6659 ("crypto: kdf - add SP800-108 counter key...") Signed-off-by: Herbert Xu diff --git a/crypto/Kconfig b/crypto/Kconfig index 3ba2f532d79c..2b0456731603 100644 --- a/crypto/Kconfig +++ b/crypto/Kconfig @@ -1850,6 +1850,7 @@ config CRYPTO_JITTERENTROPY config CRYPTO_KDF800108_CTR tristate + select CRYPTO_HMAC select CRYPTO_SHA256 config CRYPTO_USER_API