From patchwork Tue Jan 18 12:28:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 532868 Delivered-To: patch@linaro.org Received: by 2002:ad5:544f:0:0:0:0:0 with SMTP id a15csp3664205imp; Tue, 18 Jan 2022 05:32:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJyHrCxhl8CtnjGTbnFGymy+Pc/uRhxXEGWU7v8g3Qu9QWF6MAilugX6W3OFEU/QWWJ1y5Wj X-Received: by 2002:a05:6638:3009:: with SMTP id r9mr11267285jak.262.1642512721104; Tue, 18 Jan 2022 05:32:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642512721; cv=none; d=google.com; s=arc-20160816; b=aoGavOKtxc5dqhY2fzL9L/RWTx4uHaMokhEVVaJqoIXrPf0qltqOyZYYHr7kGfi6JA k61OtAnh0pEvL35zqHcBX2CS0EC8O3RFvBMHJlM9SIMjuIXEJUczT3qqaVmBldMFI43I yeA/nSX4apynE0cwoFCxnVCyAEcx37toXxImMGtnvobztUr/kuYQ64+Ts+mQ99cupVdS KeqwPACD4bXgew6D4dDE1l7ndCC9eOAM1xlU+Yp141K8LM/BobiOk/zoDt6Iu1VwSEfE +YwAqd/7lBadCl78ZyCIjtfK9RSaBVx7S5K4RSNjXbYQY1QqNewzBJroh34AimbDqQBh iBrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from; bh=8oGAbge3EBtzWxwrh7WvrMR4h5OIKd1OIzv+n7sJZZM=; b=YO9Rjww1e3YyrL1fG4ZD1DmEgmAYB1GN8lS1eLR/J8l9FGF2OQqylFt3tvTRZXE9ZB 1pYAapiZerhEHRFA1UweTICpgpCsNsF9HZK0cMQaSLey3iBHZ9Fr9zAcsKPfi0jzEqLD evakohDkNicbhHVChBtJmCKMKDtPdBmXDZ7x2iUMwtnayLilIw0T5yMhHtZa+VIJiI6t 3neIIUQpneOuWRKSPe22ASckb8jAOKQjRpKRYVNDXJTkwEMFXmQAIeT3dlshxdxTylCU U3eVD+mEjO/94LnIdI52DvkKv/gYpHe+w/ESLXlwyS4sLy28d0JQmjTI+ACJv1/OTIRc XcoA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id u14si2515879jad.128.2022.01.18.05.32.01 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Jan 2022 05:32:01 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1]:45836 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n9oad-0007gP-K4 for patch@linaro.org; Tue, 18 Jan 2022 08:31:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55562) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9nbb-0004YO-53; Tue, 18 Jan 2022 07:28:56 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:40733) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9nbZ-0001uL-GS; Tue, 18 Jan 2022 07:28:54 -0500 Received: from quad ([82.142.13.186]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MSI6i-1mldzW3q6y-00ScLp; Tue, 18 Jan 2022 13:28:51 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 3/9] qdev-core.h: Fix wrongly named reference to TYPE_SPLIT_IRQ Date: Tue, 18 Jan 2022 13:28:41 +0100 Message-Id: <20220118122847.636461-4-laurent@vivier.eu> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220118122847.636461-1-laurent@vivier.eu> References: <20220118122847.636461-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:MQnKmRB8npa5YEAAaH3uoiCps7zArtRaxuKPOlKKbmIA/OPMg7g l0sS2p8Jep5tk45dGPh90u96Z2/IiMd1440xdqsy5pIhaeCYoxKZPYnsd06y4ykn3W82Lji ouxjgs4/KOPB4IsIbWXVkyZX5W08zmF7bO1o7t7WYQPAxoo78Y0aex2mJ72XZmxneVB5g/k ycbKAgCDuCpr+lprrdbcQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:dJGRwbSZHh4=:o1UcgT2c3RTll2I26kqHwZ sYWwpM6JbB2CrMl0gOwABAmXrPpkxGPli+yJk72MXYFZdswj7dFDist9kBYSsDZOPLxFMqTuZ iCqlEIjyayn1pqA3oq5iH3s3n2FvQAo38ETZzh/cblN2AXaRQg/ZRvutd9Lq3GF2w6oFjYo4k X36LDHEdxxbBrQKGZJELmF6mcS1LIw9vtUkJpN4okVfeqm/spNGYBRSqh6hgJmhnwl64NdAxN Up5bHlgKVI+eLjxcV0skrGRwGvrRxUW9O3EQiUSM1tUsACQ/txsB3la8U845ohBnlS+PmY6RO t5wgDbxc0GjyISM8BNhYm1kQwxK4B7KI9FcmofGaU5Xe2LX0hqIziy3LVBDtCnrlfcH3OMz6c /O1zWovhtFd6qnU1DE4N16uOQOdKaFzcpW9LdPPY9r1Uyy4o73Opypr6Sx48hGgT1w/ToORIV dgNTiJzHAP8nPfqaj3n32CRqhq85NbnUA+JYMhmWJ5Vdr7ZaMaV8HOwFMyK7Jg78sKcouIuTc 9UnzZPOCyjyA0II1REA8gyVDdQgj3YCmfHCTueZmwcW1ggV84SFrqTDIjvzJSolo4xyJkfwrf SO9EXrMWEGk9oTpQQ4U7b1P9DcuUyoEk92onviD7ddzRlN1eiZzg1Pa/uQIHcGNzH6fX0KLzp q2bCfRpmn7+zOtp1lqBCKgp/Zzo2+VRWRYD8CTD1dNJg5A1MM1H/d20pfWjkMrIHLuJY= Received-SPF: none client-ip=212.227.126.135; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Peter Maydell , Laurent Vivier Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Peter Maydell Fix a comment in qdev-core.h where we incorrectly referred to TYPE_IRQ_SPLIT when we meant TYPE_SPLIT_IRQ. Signed-off-by: Peter Maydell Message-Id: <20220111172655.3546766-1-peter.maydell@linaro.org> Signed-off-by: Laurent Vivier --- include/hw/qdev-core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h index d19c94175203..92c3d6520866 100644 --- a/include/hw/qdev-core.h +++ b/include/hw/qdev-core.h @@ -493,7 +493,7 @@ qemu_irq qdev_get_gpio_in_named(DeviceState *dev, const char *name, int n); * qemu_irqs at once, or to connect multiple outbound GPIOs to the * same qemu_irq. (Warning: there is no assertion or other guard to * catch this error: the model will just not do the right thing.) - * Instead, for fan-out you can use the TYPE_IRQ_SPLIT device: connect + * Instead, for fan-out you can use the TYPE_SPLIT_IRQ device: connect * a device's outbound GPIO to the splitter's input, and connect each * of the splitter's outputs to a different device. For fan-in you * can use the TYPE_OR_IRQ device, which is a model of a logical OR From patchwork Tue Jan 18 12:28:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 532869 Delivered-To: patch@linaro.org Received: by 2002:ad5:544f:0:0:0:0:0 with SMTP id a15csp3668303imp; Tue, 18 Jan 2022 05:36:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJxbvuWo5GcKJdasdJJdbuLzKxV4qSY3LJKuSz310bGEF4e6Hq4VAo3dYshPUnoSKEMi4sNn X-Received: by 2002:a25:dd46:: with SMTP id u67mr33360152ybg.729.1642513005451; Tue, 18 Jan 2022 05:36:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642513005; cv=none; d=google.com; s=arc-20160816; b=DfUDztUGlp2qlonFO2uXwfwMBXy2Efnd9lBjJize0e762SWNPsI4vD0zQN7oxWMOeJ f+2lSKnXvqWtoLzXWk7Ui+4HcP0BUOGCx649gv8NDNYQl6EKiBDJZVnMK/L69HjwplIv qSI3s67NOFKkfpu1x8kOXCO4JzFfRHitwPlhi7q1QddMsXZ45ZlRacLa74lPmqRh3oSx Tkp+lc6hp95T+O19ghdbFr28LSCB5fjuVn6n6NtqgOUeYxYAZPAc+jz0F+71Ipd1bnIM se0suOpE9j/opy2tK137DMDCPJHLM6SFsacmV0dLf4yNaP/xiIhi3JX02zr4fNxSa4vG 4nVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from; bh=JWYC80k5CYwJ53pCPub1M+w3BOFBMeBiSKUGX5oVBMg=; b=ERr5bjmjzTbr2zclEIsRW9NKgnWc06CTrPhTiT7ITkv2alQjChjXawUv1GNVkZeUhw +nwoY0P0e9BnM/HYOB2JpK5dbBMDAEMF/TQ2FmXjyAqXzWH85AV/GR2rr4A6XjYYdK8d BWuSLyA8ViZEn2jq0MPJTxe38WJDnRTmyDGEuNjsseRW2fp5viEqxx/1/DjE801q/yeL PRM7Xau05a+X+82OXchpLKWAI032at4KOiGiRDuNdS2xlkhW+ORdMaJ6ckW4zNuhaTDM KvwwHRbltxF3J5F1WwtXDJYYFs4hnlk9pYIdQYt+13vsnOBuByBID1YTBNJEmW+Luhd9 7BHw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id k128si13077538ybc.249.2022.01.18.05.36.45 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Jan 2022 05:36:45 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1]:52596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n9ofE-0004UX-Th for patch@linaro.org; Tue, 18 Jan 2022 08:36:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55628) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9nbe-0004aa-Pd; Tue, 18 Jan 2022 07:28:58 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:33739) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9nbc-0001uy-Pz; Tue, 18 Jan 2022 07:28:58 -0500 Received: from quad ([82.142.13.186]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MFJfN-1n7pgC49wf-00FkCe; Tue, 18 Jan 2022 13:28:54 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 6/9] linux-user: Fix comment typo in arm cpu_loop code Date: Tue, 18 Jan 2022 13:28:44 +0100 Message-Id: <20220118122847.636461-7-laurent@vivier.eu> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220118122847.636461-1-laurent@vivier.eu> References: <20220118122847.636461-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:9Sc1dsPggki8oCQV/stELrG0WWdFAZR6OrITScov03rS0sg+LB1 3DVM2jASnUM4HSVNclCIQOzWU042+FWraeGPlhpftGBHYLgba9Je2Yp59hWkSNibEIZQdi4 oG0mozj/xeCh+MXy0Jl6j/9+tbbGLQm1MAd7RiyvDvyojS0A0SSJVlvT0ZUOdzSHklG7qET DLf8WoGXOgklSmd/kjttg== X-UI-Out-Filterresults: notjunk:1;V03:K0:cj7vib6NnAA=:UKcKDejVukRreBu+SWx8fb Nw0OsbCY4vNXbjefyCRWbI9IsUH14yf+xB/1TqRmQHPsVsGigs/WooayH03HYn9zOiapn2wqs /HErHrDGMPMascDp+pM/9B5/sYmF7lGerLZITdkLMOTp4IK1T1HIjKD6upksxpt7Ht93rxgL8 aHkocoWTUEGLJqr8IsEtrXiEgLcNlVvcdmqcRbe0GZ3Bv2xNzzUc4tcARIFIK7YBJ7sd0fmyY FCPP/tjizar5XESl2ZVFLx10sgV3RDuK2CSZbPBryHk//lLjuPRgWyfb7KrE4nscR7NeACdOP 4f9t+pZjPvLcT8gUB3pjIgsUsOglhaMKqx4ODHvMRSbOMzUIBajHgJ/UoJrc34dSSjUa6MHaJ eT1wcV8ZjFReFmWytt9dSep6SajPmMENd3BrQjzr28QDEiPtCflNzi/XGyK5dF27OkBga8/1S AZMsA8qhRAQ/GobKR6gsxI1wXb6KK5DfpmTDXH2w4l2xk21bIaVFDsJycAtGXZe3D6IWra2PH baO9qLu8XpDolnZSRdztvCQ6tQ/D2LOM25c2ZWv6e8NgTk1C7NKzHy9nN9Iv/HW7O1A7FNkxT RMxYhM1Y/S8W8d9vWI+qkWSpZOt40CVhip9uDPQksmkrgwOSfBbIC3UTYGpwbFMMEQP0nNHNj d1aRJHC39trpx3jHhRiDtyuz2pG/hylQogDNVob9BL+Bjy6wS0FUXdOXL0/iJR5HE1iQ= Received-SPF: none client-ip=212.227.126.130; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Peter Maydell , Laurent Vivier , Warner Losh Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Peter Maydell Fix a typo in a comment in the arm cpu_loop code. Signed-off-by: Peter Maydell Reviewed-by: Warner Losh Message-Id: <20220114182535.3804783-1-peter.maydell@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/arm/cpu_loop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/arm/cpu_loop.c b/linux-user/arm/cpu_loop.c index f153ab503a8a..032e1ffddfbd 100644 --- a/linux-user/arm/cpu_loop.c +++ b/linux-user/arm/cpu_loop.c @@ -434,8 +434,8 @@ void cpu_loop(CPUARMState *env) case 0x6: /* Access flag fault, level 2 */ case 0x9: /* Domain fault, level 1 */ case 0xb: /* Domain fault, level 2 */ - case 0xd: /* Permision fault, level 1 */ - case 0xf: /* Permision fault, level 2 */ + case 0xd: /* Permission fault, level 1 */ + case 0xf: /* Permission fault, level 2 */ si_signo = TARGET_SIGSEGV; si_code = TARGET_SEGV_ACCERR; break; From patchwork Tue Jan 18 12:28:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 532867 Delivered-To: patch@linaro.org Received: by 2002:ad5:544f:0:0:0:0:0 with SMTP id a15csp3646049imp; Tue, 18 Jan 2022 05:11:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJzTmdcyH4egHlZyNENM79ZvluBZZgkWSfdkqqShH173N2p3tmgdwW1AaXctU5J/jFwTgrUR X-Received: by 2002:a25:145:: with SMTP id 66mr17759852ybb.234.1642511461194; Tue, 18 Jan 2022 05:11:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642511461; cv=none; d=google.com; s=arc-20160816; b=dGkbi2WI6HX/KLX0K4+qzz0kxpsvwhYSHW/Ro51nre9kiUTHwcaz7mCj/PcecXXKpW WGuMtD+IM5mEUrh5ZwSN/e6+6vGl7D4CylF7pcTNVvydNDPxC7nN2FhjOenEJdEdMbtr VkKw6V4hGARIp3gG3iIPiTtAfvdtrNAXCkO1Cu8NsGLgYjjnk3uCwXC6hPu9BM9IzrS6 hgJLQ0ng1P7nXU4gkgjf9EWiMl4m8m6znuJTTJRmaJ3GU19bWsJjRHwK+DTRvD7IgBEz NZttYQVmA0Uyq89nq17j9PjwDcllKDZYPbwfGOQhVNP+v0ogDwpdX5z5/gaUz3O0emP2 tM3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from; bh=AqUVPvhbNgFpvU6jFCFzUpoNRhrChIl7U1IwN+8gFto=; b=JKlVq4OsJ+BxZkBD/uxPDQKKjAz0gsDl7wk1Gv18SlYpPgeU+lDB1JMj4fHVAyEOC5 YT+er2N+2swCHvGKAd7QuMbvpZfMtpRJkrbwSpVIBQdl1quZQhrUGt6KSdoAVlXUBmIs qV0zIJCIhwgvWyDIyBKBk2jn+YEX6j8AwuNIDvZVjOjx21sJIthFREMpf75/MsNZUp4N l3skfSOMymEZTIPlLDZvIlrA1F5q338iHEirkaM6VfEeVzd9aP8NEepDRLXWtwKfDxqZ gEGGtyv/VGQYn4ARKtl6Ed8ZF3TXgDUBq6KDUdWq7P6+B1czY747z+TxScQSCXvKl8Jv MKSA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id w14si2664545ybi.3.2022.01.18.05.11.01 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Jan 2022 05:11:01 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1]:47038 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n9oGK-0005VN-KO for patch@linaro.org; Tue, 18 Jan 2022 08:11:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55642) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9nbg-0004dK-AM; Tue, 18 Jan 2022 07:29:00 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:43741) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9nbe-0001vF-HW; Tue, 18 Jan 2022 07:28:59 -0500 Received: from quad ([82.142.13.186]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MN67J-1mrRwJ27sb-00J2Vw; Tue, 18 Jan 2022 13:28:54 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 7/9] linux-user: Rename user_force_sig tracepoint to match function name Date: Tue, 18 Jan 2022 13:28:45 +0100 Message-Id: <20220118122847.636461-8-laurent@vivier.eu> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220118122847.636461-1-laurent@vivier.eu> References: <20220118122847.636461-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:Tsl2Q16fvXB8FNfFf/v1PpOY2UMUt9fOCM4ty45DVnz1nkd6cae YlNfvO/fFe5BP9rIkJrs8qcFP2dJ9g6pNtXrccv7ZFyYNlH8QmTd3gcw31E9jLrL2KgIyv4 WA45vBcI/8o743Ommt3fiPVy5qglfZmppucjymAeul0JJsf4dLgU3IIanKrp1D+vTMWfjXx XDatr/NxQa19zro6IZIHg== X-UI-Out-Filterresults: notjunk:1;V03:K0:Thhiw20/mDc=:NwpC8qjD6mZxjPKDsN93Vm DkUBSd06aswz96tV0Fhf5kVaLhRA04DGe6SSFOx0FNmOSgXPlpC+L4vGK6oMH7+y9WsaSSAHG wYc23djdC6TKUmuvT8tBJKEPX3XqqEwllLAR2QROizuAOssRkXK1//qyCr945iORSdG28okc0 QG+akhWqVsYNMkbi4G/zOX+x1T7rk7MvfwOvCZcimWzd8zyizT2z4pw69zcvQId0GRkbjUzjA Suceq2X6c3Am9dmcaES/NMAfbp6ksgGuSSOYIF1P1hs5mVpWQnIH0YV/UKeepgX2EJa4+5kxn vJIfNUUjGWPFSF5wERH3rMiYMFHNMG0PmF/CQIwBGK/ngAjFqGC7dshxukJUfKY13z5ostCUf O+w7E296X2+3t9QQ7YJXGHWXCNyDz6j3lMNm63FQmHZGPf3Rx3hGygOA/X7FhsB5xAOEgzRuG tdWUGC/wZhG4GkeIQSoc/0Z5eOimCVQv1KNp/66I4YNYmYm7XeKvGzScNJazyvU+XLxDGm3QB EnovDAjsDH8W0MhqdGeCtGYh02xpsGzq3uxRstvSxFD+jcle28vnLGeKlbrDwmEtik49L3mB8 k72P5vXUnjDo9TyOzlKfbKAOCVYWiXmlwISLSQalQyw2bTf47g0NY2lS1+5lQkF3NuCZjhNr9 aCZOokwaYQvrJROzayiUL5/7tCqqiv6c4fATDkLK29CASQGgVHflifkAZBTW8kgzv24E= Received-SPF: none client-ip=212.227.126.135; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Peter Maydell , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Laurent Vivier Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Peter Maydell In commit c599d4d6d6e9bfdb64 in 2016 we renamed the old force_sig() function to dump_core_and_abort(), but we forgot to rename the associated tracepoint. Rename the tracepoint to to match the function it's called from. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20220114153732.3767229-3-peter.maydell@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/signal.c | 2 +- linux-user/trace-events | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index f813b4f18e44..bfbbeab9ad2e 100644 --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -734,7 +734,7 @@ static void QEMU_NORETURN dump_core_and_abort(int target_sig) struct sigaction act; host_sig = target_to_host_signal(target_sig); - trace_user_force_sig(env, target_sig, host_sig); + trace_user_dump_core_and_abort(env, target_sig, host_sig); gdb_signalled(env, target_sig); /* dump core if supported by target binary format */ diff --git a/linux-user/trace-events b/linux-user/trace-events index e7d2f54e9401..f33717f248af 100644 --- a/linux-user/trace-events +++ b/linux-user/trace-events @@ -9,7 +9,7 @@ user_setup_frame(void *env, uint64_t frame_addr) "env=%p frame_addr=0x%"PRIx64 user_setup_rt_frame(void *env, uint64_t frame_addr) "env=%p frame_addr=0x%"PRIx64 user_do_rt_sigreturn(void *env, uint64_t frame_addr) "env=%p frame_addr=0x%"PRIx64 user_do_sigreturn(void *env, uint64_t frame_addr) "env=%p frame_addr=0x%"PRIx64 -user_force_sig(void *env, int target_sig, int host_sig) "env=%p signal %d (host %d)" +user_dump_core_and_abort(void *env, int target_sig, int host_sig) "env=%p signal %d (host %d)" user_handle_signal(void *env, int target_sig) "env=%p signal %d" user_host_signal(void *env, int host_sig, int target_sig) "env=%p signal %d (target %d)" user_queue_signal(void *env, int target_sig) "env=%p signal %d" From patchwork Tue Jan 18 12:28:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 532870 Delivered-To: patch@linaro.org Received: by 2002:ad5:544f:0:0:0:0:0 with SMTP id a15csp3682049imp; Tue, 18 Jan 2022 05:54:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJyFmlP9/UZr4iFRrm9NMx46RYTlP/FvLHJ8RWmy3LHw0suv+BL9ghCkRZGB8aWPOerqkQIO X-Received: by 2002:a25:b852:: with SMTP id b18mr37014002ybm.651.1642514056177; Tue, 18 Jan 2022 05:54:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642514056; cv=none; d=google.com; s=arc-20160816; b=QFaKoVYLHyCxLv+evt1FMxTprJuJLlUtdZJW3JWBlIEAKBJ16l4/RvVQcpInzppqir smbqt/IDZoAGaRknxnD+SdP1hTdwXdj4BJBGTjSHW2XYgerGet2TMK1QLjhJRznJWY6L prJqKeMtRZDbgiZUc+fYhnl4AqGxEHLhPr9pbeIqWfNxtyL7sWs3ZwG35pKO0xEKx3Pj AWEd1XmzWf/3Ks0Gq9kAH3xKR3ranAmeP0cJWUQ4t+h11o/VFVLfFKFO4BqvfNt+3dJM OjNSAAqje77gzBB+k4vEGoIDQcJVgAwAeuAjdMaU07i95EGb2PiAwDS7fJ5B1QVe9pnj u4vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from; bh=m7FHZU2dkiV6bO1nYF9MerG7XC+377pQQbLubno9v5c=; b=gwR6krHe1BcVU7n19Dv1egwsndIDpAK2ysfAM3kNgwSKTm2ImtGgra6+p587zg8BoQ eAS7vZh+GH8Hq1Ph2BAP/EDgg17Dzdy1qJCnBJWL4hTOsUIZ1GwcgbOa4gXoQQwoqYqD 5xFZvxZG3M7o4VKO+ydboAzaSKa9jO5oToMycfhbHuFvo/IRZBYRr7RmRk5SwNY9jllL I9RaV/3+eolcP0Ee9lQSq4DZP1pB0crBuUs2yAZ8FUNaaVcF9a9KFVc0UEzW9VJKeNpe aec/kwFY3vEzfEUFaKWOaTeGk2Flv5LYmpeQFLYgSttzyjGtcSXsuyVSinM5WqVOWeto kYhw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id q19si5499984ybg.179.2022.01.18.05.54.16 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Jan 2022 05:54:16 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1]:46210 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n9ow5-0003n9-ET for patch@linaro.org; Tue, 18 Jan 2022 08:54:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55734) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9nby-0004oo-6u; Tue, 18 Jan 2022 07:29:18 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:41033) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9nbm-0001wV-Ml; Tue, 18 Jan 2022 07:29:17 -0500 Received: from quad ([82.142.13.186]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1Mcpz0-1mZuYX0CQ6-00a107; Tue, 18 Jan 2022 13:28:55 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 8/9] linux-user: Return void from queue_signal() Date: Tue, 18 Jan 2022 13:28:46 +0100 Message-Id: <20220118122847.636461-9-laurent@vivier.eu> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220118122847.636461-1-laurent@vivier.eu> References: <20220118122847.636461-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:QeG1eFTRE/Urk2aR/twAVOiLDrXveYNtkX83aKc3lzNNpiVafgg vGTzMGI9AacC43fObbFJ4wtX5zBTFgF3sfALPvye9CRBB1ohZocvr1/a/xdDreApwMWEJbx zb3kP11EF/tzb8iaSmernm7qfD7lGX/YNjs8JWdSli/DB3tHR05Wkoq3XgwHTQV8afRECSk biTHv/IuBM8VDDKZi6cSA== X-UI-Out-Filterresults: notjunk:1;V03:K0:3LWQsXjGBMs=:eH32QqGWHM/h+loKzlHWmj BnqsRjyvIX3xHiEQObpSPI0uAcaOaqo7hHQR3GshWJlnbU9oVe4qbwU5Po8qzBKJAbucoD4rR VCm/KM1xr7xrNRNWKK/UYiQewTrZgsUB6YscM0/m2b+UNaEgKp7OEqa2/bj7sa8rYWGPvNAlI GnWBTFamP0DB2waLJVJIP+Xwimy/yZ3LIZZTgaPVMbn5ylPf0JJ2bheXqO0gNTCFJYoFzU2AA dCtxnMiYk8wVLTOKRNUcFCLAqflAh9EAYszN6ifJQnih0lPgxHCYtd2xyuFQDs6o7XTBFGm7Y m2T7K8XIHJMR3fUayWpoUZoZdMecdsyGIeAEOPT0KL3zKiD1GNvJ7358hzd1ks71xD9vsxd7z EkfLFlVKQ58zjdyguzIDmpdD0fo9VEpeSblVZne3qdq45JmGa2/5LdQG8ZGzHaYub4Rt6ywph 1ZJSbhQp7i0T55cIMbCUXOO8Nlf2L0Qye5/shiJn75bjlhwsuXp+3SsG7SwH69eJVAdoyWu2W vlx9E8n4ww4Z5oUsIx4zbW4NhSxezYTgD5B+GLdmFw1Tjz3xpKIiswsfZQlNjU8P40VJASxs1 Gd2ZbBnZ1sNM90Wz5j53dzNNWhDlsYBgwCLte+zwJtMVSvEObFcGM/Tw3WsHf9URYD/DDtOza t4GsL5r9TwT1FlkS15I6MrZU2xolR/d6Gy61fFamxyKtwWsVEv4TxZFwkZ2j/mc0tWF4= Received-SPF: none client-ip=212.227.126.187; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Peter Maydell , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Laurent Vivier Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Peter Maydell The linux-user queue_signal() function always returns 1, and none of its callers check the return value. Give it a void return type instead. The return value is a leftover from the old pre-2016 linux-user signal handling code, which really did have a queue of signals and so might return a failure indication if too many signals were queued at once. The current design avoids having to ever have more than one signal queued via queue_signal() at once, so it can never fail. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20220114153732.3767229-4-peter.maydell@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/signal-common.h | 4 ++-- linux-user/signal.c | 5 ++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/linux-user/signal-common.h b/linux-user/signal-common.h index 42aa479080b8..2113165a7583 100644 --- a/linux-user/signal-common.h +++ b/linux-user/signal-common.h @@ -59,8 +59,8 @@ void setup_rt_frame(int sig, struct target_sigaction *ka, void process_pending_signals(CPUArchState *cpu_env); void signal_init(void); -int queue_signal(CPUArchState *env, int sig, int si_type, - target_siginfo_t *info); +void queue_signal(CPUArchState *env, int sig, int si_type, + target_siginfo_t *info); void host_to_target_siginfo(target_siginfo_t *tinfo, const siginfo_t *info); void target_to_host_siginfo(siginfo_t *info, const target_siginfo_t *tinfo); int target_to_host_signal(int sig); diff --git a/linux-user/signal.c b/linux-user/signal.c index bfbbeab9ad2e..32854bb3752d 100644 --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -780,8 +780,8 @@ static void QEMU_NORETURN dump_core_and_abort(int target_sig) /* queue a signal so that it will be send to the virtual CPU as soon as possible */ -int queue_signal(CPUArchState *env, int sig, int si_type, - target_siginfo_t *info) +void queue_signal(CPUArchState *env, int sig, int si_type, + target_siginfo_t *info) { CPUState *cpu = env_cpu(env); TaskState *ts = cpu->opaque; @@ -794,7 +794,6 @@ int queue_signal(CPUArchState *env, int sig, int si_type, ts->sync_signal.pending = sig; /* signal that a new signal is pending */ qatomic_set(&ts->signal_pending, 1); - return 1; /* indicates that the signal was queued */ }