From patchwork Wed Jan 5 13:03:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Dirk_M=C3=BCller?= X-Patchwork-Id: 530289 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C25C5C433F5 for ; Wed, 5 Jan 2022 13:03:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236734AbiAENDp (ORCPT ); Wed, 5 Jan 2022 08:03:45 -0500 Received: from smtp-out1.suse.de ([195.135.220.28]:35076 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236072AbiAENDn (ORCPT ); Wed, 5 Jan 2022 08:03:43 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8267D210FE; Wed, 5 Jan 2022 13:03:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1641387822; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wcCd8soW8YUI2USGRy0PwEKRq3k0dLxX0CR7sVs0Otc=; b=VjXbd0NHfsK+jxGFDEyAZyga6cMXVzhtrmZnX+4XQQqpBswiz3/R9QpE0RYkw173nZAkom EdYfmW6ouuXT2fbbbpbdokq1Ua5GWCMvhNQporPJqQqnJgO8G/RD9cxsj87lUOXe+hA/kC w/VrRsT2biHJcy63VR73gDZxaTOqCRQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1641387822; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wcCd8soW8YUI2USGRy0PwEKRq3k0dLxX0CR7sVs0Otc=; b=2ivFEjBG5iorrpE7lu5XUdUApmpHTvNXuGgZArrEhDENgx4i1TDTbn/b7bKW0nmP/9+kG5 XcoL58+bZJ0ZPuCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6B50513BD9; Wed, 5 Jan 2022 13:03:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id +LI3GS6X1WHKJwAAMHmgww (envelope-from ); Wed, 05 Jan 2022 13:03:42 +0000 From: =?utf-8?q?Dirk_M=C3=BCller?= To: linux-scsi@vger.kernel.org Cc: =?utf-8?q?Dirk_M=C3=BCller?= Subject: [PATCH] qla2xxx: fix error status checking in qla24xx_modify_vp_config() Date: Wed, 5 Jan 2022 14:03:37 +0100 Message-Id: <20220105130337.31758-1-dmueller@suse.de> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org The function was checking vpmod->comp_status and reported it as error status, which is however already checked a few lines below. Guessing from other occurrences it was supposed to check entry_status instead. Fixes: 2c3dfe3f6ad8 ("[SCSI] qla2xxx: add support for NPIV") Signed-off-by: Dirk Müller --- drivers/scsi/qla2xxx/qla_mbx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c index 10d2655ef676..e0dce38b65cf 100644 --- a/drivers/scsi/qla2xxx/qla_mbx.c +++ b/drivers/scsi/qla2xxx/qla_mbx.c @@ -4253,7 +4253,7 @@ qla24xx_modify_vp_config(scsi_qla_host_t *vha) if (rval != QLA_SUCCESS) { ql_dbg(ql_dbg_mbx, vha, 0x10bd, "Failed to issue VP config IOCB (%x).\n", rval); - } else if (vpmod->comp_status != 0) { + } else if (vpmod->entry_status != 0) { ql_dbg(ql_dbg_mbx, vha, 0x10be, "Failed to complete IOCB -- error status (%x).\n", vpmod->comp_status);