From patchwork Thu Dec 30 19:53:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 529067 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAE1DC433EF for ; Thu, 30 Dec 2021 19:53:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240601AbhL3Txh (ORCPT ); Thu, 30 Dec 2021 14:53:37 -0500 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:33608 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240414AbhL3Txh (ORCPT ); Thu, 30 Dec 2021 14:53:37 -0500 Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id F00093F1A4 for ; Thu, 30 Dec 2021 19:53:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1640894015; bh=IkNBdPvO0WBW1RMTehOrcXz9DKxSm9w/tT6yjAM5hts=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=qb8e71SBcKeZl93uper2QUNJThRhb5KKYK0TVTY1ZcQOLJB7iONzoi26ehctJU8o/ KT2WlhPPpSs0odvGDf+ld1C1pTqqbanGVr/zAQKNfJbd/0CtTF8aY8ybtYRWIYGFDT oXGIo4KEmLgmFRuXU3AxMNU5DBCclpYMlMnvXzXiA3abxVBFM8Ho7c1hT1WwYNQag7 P+lSgq4cD6w8RHdeNRK+oE5XAiU8SP8LsoKLWEExqULigAgz++jbeToObrB1SsLZVW gQ+4SeCAXOZQ/NAeXJcC7tL/YbXKdqVa5KZzM+4gnXtE0PgCjVdUOtw6W4fcZ8KZG3 tvK02tCRNmk8g== Received: by mail-lj1-f199.google.com with SMTP id k20-20020a2e9214000000b0022d6b13bc8aso8488756ljg.13 for ; Thu, 30 Dec 2021 11:53:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=IkNBdPvO0WBW1RMTehOrcXz9DKxSm9w/tT6yjAM5hts=; b=xjz1SZs772EveK9zAsyYdLsftk+tmnOGkkCVnqcpm4xHEQ4m71bwHidrYTlzizPk26 3qfiVgyRe6SmQtuD8n/7cDw+sCwDJnAG53wleFafkK9iUpYkifx6hGLU/53FLPdWKRvw f4l2VB71UWZBsy2hGgrOIzYz+EHl/5fpNR7J8RXy3K9nW1DMK/m5kxSC14abz241UHAN 3yXWnsQlRugwKJzKoZuk2KKjMtpWJkCovSrwaZGphWlShxCpc4DhvBECnx/4bQEzvok1 WP9S+OkAwgVLR9Ujf/MtPAfnafeX6FT3rgC2X3chOxJIsvTbTVHV+7C38escXsQlRPvB BOmQ== X-Gm-Message-State: AOAM531XhRIC9a4DPYkGmRKxbiGP/ObLqHj2sxMSp0VjaPPdhtLXVX5S /LHkaHYXFamUKlImv1sMQmbAnw7YF8dfF4lUzT/pxech+1w2oM/4l0XhD4cbGzcR0GXkruXAy6S T7xqDNkonlLa5ZGLNV+mCGg/O68Uxar01G48cR6GS1TLV2qLv X-Received: by 2002:a2e:b818:: with SMTP id u24mr20156780ljo.426.1640894015357; Thu, 30 Dec 2021 11:53:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJzCxn9v+74EYdO2VRQPTiHMdXaG/xqPgeB6RVZO0ch93m20tllLyIOYqIKVcNZ6kp/IBgkQ1w== X-Received: by 2002:a2e:b818:: with SMTP id u24mr20156769ljo.426.1640894015212; Thu, 30 Dec 2021 11:53:35 -0800 (PST) Received: from krzk-bin.lan (89-77-68-124.dynamic.chello.pl. [89.77.68.124]) by smtp.gmail.com with ESMTPSA id v9sm2454505lja.109.2021.12.30.11.53.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Dec 2021 11:53:34 -0800 (PST) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , Marek Szyprowski , Jaehoon Chung , Chanho Park , Sam Protsenko , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Sylwester Nawrocki , stable@vger.kernel.org Subject: [RFT][PATCH 1/3] ARM: dts: exynos: fix UART3 pins configuration in Exynos5250 Date: Thu, 30 Dec 2021 20:53:23 +0100 Message-Id: <20211230195325.328220-1-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org The gpa1-4 pin was put twice in UART3 pin configuration of Exynos5250, instead of proper pin gpa1-5. Fixes: f8bfe2b050f3 ("ARM: dts: add pin state information in client nodes for Exynos5 platforms") Cc: Signed-off-by: Krzysztof Kozlowski Reviewed-by: Alim Akhtar Tested-by: Marek Szyprowski --- arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi index d31a68672bfa..d7d756614edd 100644 --- a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi +++ b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi @@ -260,7 +260,7 @@ i2c3_hs_bus: i2c3-hs-bus { }; uart3_data: uart3-data { - samsung,pins = "gpa1-4", "gpa1-4"; + samsung,pins = "gpa1-4", "gpa1-5"; samsung,pin-function = ; samsung,pin-pud = ; samsung,pin-drv = ; From patchwork Thu Dec 30 19:53:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 529723 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03C4AC433FE for ; Thu, 30 Dec 2021 19:53:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240534AbhL3Txj (ORCPT ); Thu, 30 Dec 2021 14:53:39 -0500 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:33634 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241818AbhL3Txi (ORCPT ); Thu, 30 Dec 2021 14:53:38 -0500 Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 3BF144000E for ; Thu, 30 Dec 2021 19:53:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1640894017; bh=QNADCpp7Mlh0tiTM/IZxnSD9jEJmVsO7Ez+VZPkoolk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FZLpCDxlQfhIZFka20t/7kQ05zL58oiE1XaQ5937izdJuHuNYZuNpECW51K5MwYIG j8oowMzlW2h6U0JuLxA0SeIkxq5XRylH2u/rUCFYQzkjaOvh72yE4IIG7BVSA8agF/ upIVb+ADPdFhY2HngydEb3B9s0yiAjK81W6h0lfZB/ZjNyGwDSIP0ziD4erP8yS5GU LxyLCmVHvjRmUo6RpbOgQ7zpMypVKCdHwFN+2ZIRMhOFn4wDai2uqaNqlN/+cqT4wm DPD6vyDdnLSweKH0/d3ul8rOwtXLxjHodAYb0fmmUabEl7ZZLAUyKEBxz6BIzyb6k+ miuCPeeaTd5eA== Received: by mail-lf1-f70.google.com with SMTP id g2-20020a19e042000000b00425cfac0e67so5128972lfj.10 for ; Thu, 30 Dec 2021 11:53:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QNADCpp7Mlh0tiTM/IZxnSD9jEJmVsO7Ez+VZPkoolk=; b=HHoZwFGddCNLTVPf5/FPT5SL032rb8KN248YQwbe9PtIFhz1EF0uyAjrGuOCIF1Lji q9x0reLqRrn+EvSGWf1m7k4QYerBsIPW1d41noW87p8mEpED+erW9gjDnCl+7L6B7IDu amCErrrGgvjuJwtq2ap5JPTvHlIl5Knre8UE52IbYIHMJyFazovZzGvEeSmkV0gxiLLU gfq/udbg4SK369c1O2skMSrhKNlFBe55efc9qhO58N/49hSQn23UQew5HfDABIAy5WTU HSuOoO5sXo6GrY0AdKfdRC0B+KCAu+7ZVBxLAaRv2XRcaKYLyH1qSkANL9DlYMxkeEr3 Qx4Q== X-Gm-Message-State: AOAM53392iJVToUYltk9+n4qtt1xxCYqq4hi7g+KyghuWPMen0+jfFNT ncY1luBEwdgVAP/YUX0MsRsPs+m50LMYxLenXrD+1cuRwnfBoVwgfR3JKT/aWelyRu8RcpD0wm0 Ba1JvaaGn4s4NPRQ1C46e/6275UMRXqUIQiG6FM8S6n6EVsMo X-Received: by 2002:ac2:4e0f:: with SMTP id e15mr28637090lfr.352.1640894016663; Thu, 30 Dec 2021 11:53:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJx7O09tl2Ts7mTIWiy2LfEGqGyrflqLZ61fdbAegNO9XsZTDpgxdoRm8WI5V2+TWOtiW3DmOw== X-Received: by 2002:ac2:4e0f:: with SMTP id e15mr28637080lfr.352.1640894016500; Thu, 30 Dec 2021 11:53:36 -0800 (PST) Received: from krzk-bin.lan (89-77-68-124.dynamic.chello.pl. [89.77.68.124]) by smtp.gmail.com with ESMTPSA id v9sm2454505lja.109.2021.12.30.11.53.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Dec 2021 11:53:36 -0800 (PST) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , Marek Szyprowski , Jaehoon Chung , Chanho Park , Sam Protsenko , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Sylwester Nawrocki , stable@vger.kernel.org Subject: [RFT][PATCH 2/3] arm64: dts: exynos: fix WLAN pin configuration in TM2 Date: Thu, 30 Dec 2021 20:53:24 +0100 Message-Id: <20211230195325.328220-2-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20211230195325.328220-1-krzysztof.kozlowski@canonical.com> References: <20211230195325.328220-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Each pin configuration in pin controller should be a node with "samsung,pins" and other similar properties. However the macro PIN() (used for initial/sleep states) defines entire node, so PCIe WLAN pin configuration node was ignored. Fixes: 98c03b6eef3f ("arm64: dts: exynos: add the WiFi/PCIe support to TM2(e) boards") Cc: Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi index cbcc01a66aab..c5054c7a9c03 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi @@ -1104,8 +1104,11 @@ &pinctrl_ese { pinctrl-names = "default"; pinctrl-0 = <&initial_ese>; - pcie_wlanen: pcie-wlanen { - PIN(INPUT, gpj2-0, UP, FAST_SR4); + pcie_wlanen: pcie-wlanen-pins { + samsung,pins = "gpj2-0"; + samsung,pin-function = ; + samsung,pin-pud = ; + samsung,pin-drv = ; }; initial_ese: initial-state { From patchwork Thu Dec 30 19:53:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 529066 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D5BAC433F5 for ; Thu, 30 Dec 2021 19:53:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241812AbhL3Txl (ORCPT ); Thu, 30 Dec 2021 14:53:41 -0500 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:33658 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242029AbhL3Txj (ORCPT ); Thu, 30 Dec 2021 14:53:39 -0500 Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id B21573F1A4 for ; Thu, 30 Dec 2021 19:53:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1640894018; bh=8uEPws7WapP8rUIPMK6UFetuvdb1C3w9FuCMI36coi0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=MmvXfGOxbyaGvtXJH+Sm/7l6oHMOp9Nm421qB0UqutaS4GlO7Ci3kqa/NGfzEJMom tmsjDD/WeN2wdMmcs7jXeBUsay14cA9Ce7QyGoEH1RHMGxKW1gbtcnXUdHZreZ2iZn AdloX+fMtQqTDVW6lIqQACRSHun8Sxb490csBkNUBbbIdJ3a3pvJoJYww3AccrLBka UCemlxD675XkbQ1U7O9fklIA+cxWRO8y51KrbOJdB1cgLCjgVGHHUb7v0dl5DdkRvG zw5x3mhdAE9avfITYKjrS8kjtnhJKEM44r0As1YeCsHyvD6sfa3NFIRUUEhh0V29Sd 7tihllKzX1OvQ== Received: by mail-lj1-f198.google.com with SMTP id b20-20020a2e9894000000b0022dc5a5f841so5470434ljj.2 for ; Thu, 30 Dec 2021 11:53:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8uEPws7WapP8rUIPMK6UFetuvdb1C3w9FuCMI36coi0=; b=V/oJK1hASac+xmvq+C0qFLOi+cbxozJ/EAZoc00LR92BUxhRqp83aN/E4gNPoKALOy nt8EOSOr3CMEDnxAAlTszY/Jhstfu8YxQjXbeR9ajOqcpwADIFgrv8x13dwa+8mFSMI7 hUDAx3T3Plh5A/56H/5dk3aJjiDMWvKDwktFFiqngjc1K6q8Vg+UBlciI7FUGr8PzdBy FoNJIRvoWMeiwHH8fAKA+37Ye6ar7bZpFtZIWyvw/8hh+ez/TG8jIKklLvQmYZaqo5kR qSTg+2X1f692TCrvn0pGCB65kUMYG8S9AJOl+k42zni9n+08pLRqfsXQOSsQT0FLbmOh 27jg== X-Gm-Message-State: AOAM532w46Bq/yfPdekniMmDAKMIE1gcL2vPE06Lov+ZJcPTkKBNGg4y TeWnhe3ebCPFduEDAJL2r5U4oiMP7r31xQirDeUXQvk868cztLpIyPCJwIyu00SJ4oP0OeCFx9R gUainfrGZvykC7WP7v1W5EyMi3fV0wO+zxFjisKclNIj6nEx6 X-Received: by 2002:a2e:a288:: with SMTP id k8mr14085915lja.204.1640894017918; Thu, 30 Dec 2021 11:53:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJyNHCKwtJ5UoHGrJtzXyOc5ie5RkA53X5zCoUxVYllNPxSfugxzeS6pBP++ALCmFSmUMlifTA== X-Received: by 2002:a2e:a288:: with SMTP id k8mr14085902lja.204.1640894017764; Thu, 30 Dec 2021 11:53:37 -0800 (PST) Received: from krzk-bin.lan (89-77-68-124.dynamic.chello.pl. [89.77.68.124]) by smtp.gmail.com with ESMTPSA id v9sm2454505lja.109.2021.12.30.11.53.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Dec 2021 11:53:37 -0800 (PST) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , Marek Szyprowski , Jaehoon Chung , Chanho Park , Sam Protsenko , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Sylwester Nawrocki Subject: [RFT][PATCH 3/3] arm64: dts: exynos: drop incorrectly placed wakeup interrupts in Exynos850 Date: Thu, 30 Dec 2021 20:53:25 +0100 Message-Id: <20211230195325.328220-3-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20211230195325.328220-1-krzysztof.kozlowski@canonical.com> References: <20211230195325.328220-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org The pin controller device node is expected to have one (optional) interrupt. Its pin banks capable of external interrupts, should define interrupts for each pin, unless a muxed interrupt is used. Exynos850 defined the second part - interrupt for each pin in wake-up pin controller - but also added these interrupts in main device node, which is not correct. Fixes: e3493220fd3e ("arm64: dts: exynos: Add initial Exynos850 SoC support") Signed-off-by: Krzysztof Kozlowski Tested-by: Sam Protsenko Reviewed-by: Sam Protsenko --- arch/arm64/boot/dts/exynos/exynos850.dtsi | 40 ----------------------- 1 file changed, 40 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/exynos850.dtsi b/arch/arm64/boot/dts/exynos/exynos850.dtsi index 2abbb972b610..4f0a40de5e67 100644 --- a/arch/arm64/boot/dts/exynos/exynos850.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos850.dtsi @@ -344,38 +344,6 @@ cmu_hsi: clock-controller@13400000 { pinctrl_alive: pinctrl@11850000 { compatible = "samsung,exynos850-pinctrl"; reg = <0x11850000 0x1000>; - interrupts = , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - , - ; wakeup-interrupt-controller { compatible = "samsung,exynos7-wakeup-eint"; @@ -385,14 +353,6 @@ wakeup-interrupt-controller { pinctrl_cmgp: pinctrl@11c30000 { compatible = "samsung,exynos850-pinctrl"; reg = <0x11c30000 0x1000>; - interrupts = , - , - , - , - , - , - , - ; wakeup-interrupt-controller { compatible = "samsung,exynos7-wakeup-eint";