From patchwork Tue Nov 13 18:29:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 150996 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4739459ljp; Tue, 13 Nov 2018 10:29:23 -0800 (PST) X-Google-Smtp-Source: AJdET5drtO0U66EPtcVMuu6cBRx2fCTlbOpo938CAaigFp5veA6P4ojSAmmL1ie6LaznXDs1iuZf X-Received: by 2002:adf:f5d1:: with SMTP id k17mr3905114wrp.59.1542133763846; Tue, 13 Nov 2018 10:29:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542133763; cv=none; d=google.com; s=arc-20160816; b=HzevTRJJi/KnHFINtru6EjKGBmZuesWhB7u8ZOc3Db/mgKtDncoQusqKARafeo0l/v ijgt7kxkc7NgaZSb6rRsQBKKWi540DoF3gQfWvpxOcOubfvRoH/WZJBWeVrBAPpR43k3 /SbSgr0G9s6OVLSrzmtTshvGjb5rjZ7Un/29uL//jbymugvqLSbeBwmRAX9QPrl4GY54 se1mJdV1Pd9g2A5XEKYNmVir29KlNChoVdKjsTLKsQXDuFykvfmI8GLTQVCDkxzLCWbf klRm7MVV6OxupGDZH5VN7B/sLi4T48vwGOejRl3hhkRzXRHUprfO1HmCdwLVC27mzta0 mRvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to; bh=BjoVliTJGT6LEMGf+bcT7HJRl8+IORq+Veq8rii0QA0=; b=xaJTI9kEFdv+fUPfeCqAtzDR/IAuCXH9DrqXBx8vIFRz0oTCG5fazcKPKDP5ILFV83 WpCtEzpK3ljj8uJOo0JXKApFOAIRrvrayWUR+xfSLByz4E6OHFUZh8T9FLCnrXywgbt/ N0aRBmLhQkggtnfjc09A4kuNg2ZyyYu3zPDVjEaLDzf8jN6gsTJMxc9Ga19xBuepAZqk /NGg9ZZ8o6RuU3SyK+KtjbLSfcQ3aaUsO1b01pb5wd28aGrzGml2R38f0g20UpDkx9s9 xb692EuPhk8MCLhol5inOaV+NF5ZrTKvNjkU3Y8tVGZuklvn2oeNQeIdTI2hlyIuOedA 8EyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=O8oGrK2W; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id m135-v6si11666482wmb.23.2018.11.13.10.29.23; Tue, 13 Nov 2018 10:29:23 -0800 (PST) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=O8oGrK2W; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 833A626786A; Tue, 13 Nov 2018 19:29:22 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id D4272267AB1; Tue, 13 Nov 2018 19:29:20 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id DFCFE2677E4 for ; Tue, 13 Nov 2018 19:29:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=hrdpgtYUYyeYgqDjp0JxWxkCNGy7GadO7otyGdtN87Q=; b=O8oGrK2W0U6k gX8+DHvIOnnkrXa9egcjNZCbfa/aTFYTF4eYsBsuXFcn2LOKSuQ39YrCHaHmnxf/oh+T678tquBwV rHJm9YvV149ha+BAdRjmWOcusu3LGEWORlFmNB4OlIGI8OkZNhyk0DEQyxT8u+0hX/1YW8sI79ti4 qeMJs=; Received: from [64.114.255.97] (helo=finisterre.ee.mobilebroadband) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1gMdR7-0002OI-Q4; Tue, 13 Nov 2018 18:29:18 +0000 Received: by finisterre.ee.mobilebroadband (Postfix, from userid 1000) id CAA59440078; Tue, 13 Nov 2018 18:29:11 +0000 (GMT) From: Mark Brown To: Peter Ujfalusi In-Reply-To: Message-Id: <20181113182911.CAA59440078@finisterre.ee.mobilebroadband> Date: Tue, 13 Nov 2018 18:29:11 +0000 (GMT) Cc: alsa-devel@alsa-project.org, Mark Brown , Jarkko Nikula Subject: [alsa-devel] Applied "ASoC: omap-mcbsp: No need to initialize max_xx_thres when it is not used" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: omap-mcbsp: No need to initialize max_xx_thres when it is not used has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From f15c19af929d380d0acb2a8d8277d688351bd5de Mon Sep 17 00:00:00 2001 From: Peter Ujfalusi Date: Thu, 8 Nov 2018 09:30:00 +0200 Subject: [PATCH] ASoC: omap-mcbsp: No need to initialize max_xx_thres when it is not used Initializing to -EINVAL is not correct as the variables are unsigned and if buffer_size is 0 then they are not used anyway. Signed-off-by: Peter Ujfalusi Acked-by: Jarkko Nikula Tested-by: Jarkko Nikula Signed-off-by: Mark Brown --- sound/soc/omap/omap-mcbsp.c | 3 --- 1 file changed, 3 deletions(-) -- 2.19.1 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/omap/omap-mcbsp.c b/sound/soc/omap/omap-mcbsp.c index 8cab1151d3bb..e0ef4774c710 100644 --- a/sound/soc/omap/omap-mcbsp.c +++ b/sound/soc/omap/omap-mcbsp.c @@ -727,9 +727,6 @@ static int omap_mcbsp_init(struct platform_device *pdev) "Unable to create additional controls\n"); goto err_thres; } - } else { - mcbsp->max_tx_thres = -EINVAL; - mcbsp->max_rx_thres = -EINVAL; } ret = omap_mcbsp_st_init(pdev);