From patchwork Mon Nov 29 14:09:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 519708 Delivered-To: patch@linaro.org Received: by 2002:ac0:c605:0:0:0:0:0 with SMTP id p5csp6140801imj; Mon, 29 Nov 2021 06:18:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJxk9jPX/QZa0J52KPS5Kf9fD0ChCvlJb5FynKjgxp6yBt8/UdBTvAxf8uy5m+fJ8ky4hux7 X-Received: by 2002:a5d:6e82:: with SMTP id k2mr33888032wrz.147.1638195513989; Mon, 29 Nov 2021 06:18:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1638195513; cv=none; d=google.com; s=arc-20160816; b=enXkcEV19qTTQB69eLIlC9JNJruggDU6EH33bw7ZF//AJNXY024VUgtPu4YEI3EGbg 5tBTaN6OTJVi5PIyIfTI20VX8dk+lvl2FjhXRoHUhx5L7B/3JttDQOPt1wn4J2ufF7ok cBr4QBfZ3lvmaP/grWWhq1hv+fSpgKV6OS9P/3yRcLS4tQJ6J93cyaKvdG2kGoKAH4+3 nBmuuvZ4DnE127+vQbUl4AB9CKvegJ4/gggs/WQrrTiI8Flx77Ke7v+68yqOg1ATfkRC 0M9RvI2N5WwdVOahUXeraoMA/xNB/B1RHv1yeVsUcdN/gig6JSUu+gQzw2rYmc1r+7ef +Ziw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=1TZ8swcyv0OX5mGYSW/yBjqG9DvFKB22CAAKdZIQEUc=; b=Qvt0Smip4bj2J7E8XFezGzS3u4kUsCuup0IIkO1KIufIYuFrEUcabku9/TsFk4Wz4R z63JrA2j+Lk4ZY0mC+ujeY2PNwvw+p3tPOAXWmVelIXXH2kr3kmW+Iy6YPPD22nVb92l nM4/h2FYSj+fR9IqxyyKHodcqC10GZznZEL1Sx+aFuNCeqCooP74R4jl7Z8v98QZnLy7 OKEelc8u/9lGRdwMFAcPvDvKLa480mMYME7G2g/qzKJQaYlk3OEk8pAxoKhfoTvF0fAX PNAnCXyRktGBziFJNvnjihwcKroj0LXh2JH1fDgPfBPiEBX9x3jDLrl6YbgKQXOt6zKq OP5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=XzTav9bF; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id i2si19870796wrp.902.2021.11.29.06.18.33 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Nov 2021 06:18:33 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=XzTav9bF; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:57066 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mrhUH-0004vG-2p for patch@linaro.org; Mon, 29 Nov 2021 09:18:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56362) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrhLk-0001Fz-3a for qemu-devel@nongnu.org; Mon, 29 Nov 2021 09:09:44 -0500 Received: from [2a00:1450:4864:20::32d] (port=37612 helo=mail-wm1-x32d.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mrhLd-0006Tx-3C for qemu-devel@nongnu.org; Mon, 29 Nov 2021 09:09:43 -0500 Received: by mail-wm1-x32d.google.com with SMTP id k37-20020a05600c1ca500b00330cb84834fso16939732wms.2 for ; Mon, 29 Nov 2021 06:09:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1TZ8swcyv0OX5mGYSW/yBjqG9DvFKB22CAAKdZIQEUc=; b=XzTav9bFvkmOT9bE9OZXiGyVLDbkGEJGdCpu9RVRwVcuUqoaxF+zCQoeemiXnPLNrx 2P9gTsTEuxj3wnMkmjp9oNT7rBx4xt5ta/Hf4+9zB3XjmM2vUckTSwI+R7aHdN8EmgSG eseAL95sZbsciQkKAJRZRaircLMNK/2u7TwK37aBdV/EoejgIcGxmRIzNwMJMR34YsrU bQZZlNfffMMshRsMglo2/HiKbhxabRmPvqcZ5p3+ubMlV0J+yiR/uP5/6UjfWnaAUyRA hOmfmBYsAAOwLzAO2d0ilSKYO11KALHO3WqLlXIbmyvSfFm+Vk/S9zj3ASp7GE2jdCQj Pdcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1TZ8swcyv0OX5mGYSW/yBjqG9DvFKB22CAAKdZIQEUc=; b=gILoIgYTbnVRJghHGNMD2ShbnPgTUMMaOytBt5urXLxC1lgZqMeZD2x3TL22JB8wmR lQmMAqUL4WOYn9KdLD3OkBQzEiivHtva73Q34ng817tWdzT2HNtDOCAKKC0ARPlN08Ju pi/Hrq0NuXNR7kQ5kt3OXp660EpDl01ZlWZaqA5VoW9gMYbc8ec5uTrZF4kEKljf4k/G S156GyOSOacwgCJJDFk/PvoNc0aYhOsaqS94LFSDlN0YkUWhJje85s1zWyR4VGwXrHLb STTUBS0ke4NBq4E7zbN+wudKcLSEt6oxlQI3NFBOqwdQ0IWReuGEtZyq+o0mfujItSqe LMkA== X-Gm-Message-State: AOAM5321OUfyYZwN+ozoRNt8UAYovEPCYs9UOAmqwHbNVVI1KKEBsVVK SIZLo5A0JRn7l4gwrL2sSkgqGQ== X-Received: by 2002:a05:600c:24d:: with SMTP id 13mr36711515wmj.156.1638194975097; Mon, 29 Nov 2021 06:09:35 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id e18sm14076042wrs.48.2021.11.29.06.09.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Nov 2021 06:09:34 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 07FB91FF98; Mon, 29 Nov 2021 14:09:33 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v3 1/8] accel/tcg: introduce CF_NOIRQ Date: Mon, 29 Nov 2021 14:09:25 +0000 Message-Id: <20211129140932.4115115-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211129140932.4115115-1-alex.bennee@linaro.org> References: <20211129140932.4115115-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::32d (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, berrange@redhat.com, Richard Henderson , f4bug@amsat.org, stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com, =?utf-8?q?Alex_?= =?utf-8?q?Benn=C3=A9e?= , aurelien@aurel32.net Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Here we introduce a new compiler flag to disable the checking of exit request (icount_decr.u32). This is useful when we want to ensure the next block cannot be preempted by an asynchronous event. Suggested-by: Richard Henderson Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v2 - split from larger patch - reword the check in cpu_handle_interrupt and scope to CF_NOIRQ only --- include/exec/exec-all.h | 1 + include/exec/gen-icount.h | 21 +++++++++++++++++---- 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h index 6bb2a0f7ec..35d8e93976 100644 --- a/include/exec/exec-all.h +++ b/include/exec/exec-all.h @@ -503,6 +503,7 @@ struct TranslationBlock { #define CF_USE_ICOUNT 0x00020000 #define CF_INVALID 0x00040000 /* TB is stale. Set with @jmp_lock held */ #define CF_PARALLEL 0x00080000 /* Generate code for a parallel context */ +#define CF_NOIRQ 0x00100000 /* Generate an uninterruptible TB */ #define CF_CLUSTER_MASK 0xff000000 /* Top 8 bits are cluster ID */ #define CF_CLUSTER_SHIFT 24 diff --git a/include/exec/gen-icount.h b/include/exec/gen-icount.h index 610cba58fe..c57204ddad 100644 --- a/include/exec/gen-icount.h +++ b/include/exec/gen-icount.h @@ -21,7 +21,6 @@ static inline void gen_tb_start(const TranslationBlock *tb) { TCGv_i32 count; - tcg_ctx->exitreq_label = gen_new_label(); if (tb_cflags(tb) & CF_USE_ICOUNT) { count = tcg_temp_local_new_i32(); } else { @@ -42,7 +41,19 @@ static inline void gen_tb_start(const TranslationBlock *tb) icount_start_insn = tcg_last_op(); } - tcg_gen_brcondi_i32(TCG_COND_LT, count, 0, tcg_ctx->exitreq_label); + /* + * Emit the check against icount_decr.u32 to see if we should exit + * unless we suppress the check with CF_NOIRQ. If we are using + * icount and have suppressed interruption the higher level code + * should have ensured we don't run more instructions than the + * budget. + */ + if (tb_cflags(tb) & CF_NOIRQ) { + tcg_ctx->exitreq_label = NULL; + } else { + tcg_ctx->exitreq_label = gen_new_label(); + tcg_gen_brcondi_i32(TCG_COND_LT, count, 0, tcg_ctx->exitreq_label); + } if (tb_cflags(tb) & CF_USE_ICOUNT) { tcg_gen_st16_i32(count, cpu_env, @@ -74,8 +85,10 @@ static inline void gen_tb_end(const TranslationBlock *tb, int num_insns) tcgv_i32_arg(tcg_constant_i32(num_insns))); } - gen_set_label(tcg_ctx->exitreq_label); - tcg_gen_exit_tb(tb, TB_EXIT_REQUESTED); + if (tcg_ctx->exitreq_label) { + gen_set_label(tcg_ctx->exitreq_label); + tcg_gen_exit_tb(tb, TB_EXIT_REQUESTED); + } } #endif From patchwork Mon Nov 29 14:09:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 519713 Delivered-To: patch@linaro.org Received: by 2002:ac0:c605:0:0:0:0:0 with SMTP id p5csp6152594imj; Mon, 29 Nov 2021 06:27:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJz32Xti5vGIcWolWiqgLgod0iihetKSwTyuQKm8cCuYDj3Av7MA6FTeKJGkNXBjqmZFgvdd X-Received: by 2002:ab0:3359:: with SMTP id h25mr48939515uap.59.1638196019880; Mon, 29 Nov 2021 06:26:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1638196019; cv=none; d=google.com; s=arc-20160816; b=ZVjJwDLZnStY9nTKzepwTJIPBm9qZDiKrCpzx38O+EQqDNk3gZGYM/LTJgFiT+Cb96 glZIA9g8sB2WOf/aRLhN1TNe+HdnGjbRaZa3r+7ZGmYc46DDnqPWup2zqLLLlo/1L/kx 3edKLnlaNtWGW4M9KGCnGyCz+RmgEOXjfdNPTTixvaz851533FYsH+r1JDCOedI1lMsB cxFGHXfdEbohYqhr+07LdFikiZ2+erPlyj61ZZrXvZswQZ5eKZCglG/KHqfo8K9p9WIS JGED6ZdUc5gzBP3ug6XzCNiBQvlUsvnbq4l2uigmvXhPgJOh59Zv1ux7RHgu27Kszy42 nYLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=LlhZwpKu414qJjgz6hLLraIgHgqCtfsJisAg9+N5jK4=; b=UGBO5NAovdAX3Kkctt9+mlgFzWS7V4WI3MqWyr97hLjUlSgvXyT9UBY0533I7tuxoa USo6cHIwE8XCVCQVYM1LUgQXbZYZOkT8RI+4quGPpY+MFmQc5tE0/UKjPfHK5n67x/I4 FT5Nx08oZr5WyjJovW8whGkBvZPhOtvs8eTJj9si9uTyoExGg+4NxpoTso/lbC+MkRta R/eJBZPnGJ7NV8o7shbVGiIpIWcXJR0brJx2k6TfoX0Oxe6QDOSKznZM5mePMTL8nILq 8mI3aLx0YZprvwI4tEXjp536Xw5oPT88WNVNcCMshK3G+oDVkpGIkQioGgmdH9u7sYoJ r9uw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=OLwx4sjA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d24si125975vsj.469.2021.11.29.06.26.59 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Nov 2021 06:26:59 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=OLwx4sjA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:47336 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mrhcR-0000vX-6O for patch@linaro.org; Mon, 29 Nov 2021 09:26:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56364) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrhLk-0001GV-EY for qemu-devel@nongnu.org; Mon, 29 Nov 2021 09:09:44 -0500 Received: from [2a00:1450:4864:20::330] (port=54026 helo=mail-wm1-x330.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mrhLg-0006UH-Ut for qemu-devel@nongnu.org; Mon, 29 Nov 2021 09:09:43 -0500 Received: by mail-wm1-x330.google.com with SMTP id y196so14717240wmc.3 for ; Mon, 29 Nov 2021 06:09:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LlhZwpKu414qJjgz6hLLraIgHgqCtfsJisAg9+N5jK4=; b=OLwx4sjA/j7DFPqmSLfmbswiuHGD7oRD2oFnlk84GP0iKlCif3nKCnUpCQ2LJUyEaU +btb+Jam5gGNPZTT8FENuNPKlPedGMBe5VYEKAfKcUcPCB6UNIw8zqFx1vYePcfXAlwS kMiC4D2h8gV9oYi2FczCsstL7NyY14IbffYIYUymf3LpSWBF96cjkuOTaylXgzl/dqlN pZAY2wEycWrUxi77uMbB5a9JpTQ9X2ng6U/NH2ILUsqL+HbKwTPFtpnr+htqB+zBVeNt dlE3sjJUmDqz1obuTUqb8/JgtCV07d/bTvVtjh2FGOu+JRIvZshkkNagHZhV7ci98yOE q27g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LlhZwpKu414qJjgz6hLLraIgHgqCtfsJisAg9+N5jK4=; b=EA9m+6yXC8IePo1wmDAXTZF6+WiqTqD/H3KK7cMXjy7O7bgPVmUcBSY0wzwY5Bdc8V MYqo4bK8BwWsmUDctpq7IroF05g7nqYfYvBM99GAbi0Rn+GaW8Uv8un1HkjWhW4pJTFB zJPJLDFyDgUwKa0tytOHRAUoTfoPe36a9UMn+tWkr41Y+5Ww7N7m/DqzKSuMNN3vh4H9 IL7RqfeNl3NYlwPKuPmcJDkzgEx2ULUnfNcLTiGEDhUImVDjaPFo1Mkm7FQsQHWhcXJl CnwND2obfR0ZVRjMJIUteOICvQfH00PqUzRhUrHvFNILg0DXEDkAwln9WN+Rzy8vOoXG 7cwQ== X-Gm-Message-State: AOAM530sqzqtZVdZFEEsLuWTfKOnYZFJv3jt/BSEAP5XZLqz6xuvlvfB QzFNg+5Erq1wlS+cgJ2S6LrUCw== X-Received: by 2002:a1c:4d15:: with SMTP id o21mr36414545wmh.171.1638194977979; Mon, 29 Nov 2021 06:09:37 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id 38sm14401536wrc.1.2021.11.29.06.09.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Nov 2021 06:09:34 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 190571FF99; Mon, 29 Nov 2021 14:09:33 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v3 2/8] accel/tcg: suppress IRQ check for special TBs Date: Mon, 29 Nov 2021 14:09:26 +0000 Message-Id: <20211129140932.4115115-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211129140932.4115115-1-alex.bennee@linaro.org> References: <20211129140932.4115115-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::330 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, berrange@redhat.com, David Hildenbrand , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Richard Henderson , f4bug@amsat.org, Peter Xu , stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com, Pavel Dovgalyuk , =?utf-8?q?Alex_Benn=C3=A9e?= , aurelien@aurel32.net Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" When we set cpu->cflags_next_tb it is because we want to carefully control the execution of the next TB. Currently there is a race that causes the second stage of watchpoint handling to get ignored if an IRQ is processed before we finish executing the instruction that triggers the watchpoint. Use the new CF_NOIRQ facility to avoid the race. We also suppress IRQs when handling precise self modifying code to avoid unnecessary bouncing. Signed-off-by: Alex Bennée Cc: Pavel Dovgalyuk Fixes: https://gitlab.com/qemu-project/qemu/-/issues/245 Reviewed-by: Richard Henderson --- v2 - split the CF_NOIRQ implementation - only apply CF_NOIRQ for watchpoints/SMC handling - minor reword of commit v3 - add additional two cases of | CF_NOIRQ --- accel/tcg/cpu-exec.c | 9 +++++++++ accel/tcg/translate-all.c | 4 ++-- softmmu/physmem.c | 4 ++-- 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 2d14d02f6c..409ec8c38c 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -721,6 +721,15 @@ static inline bool need_replay_interrupt(int interrupt_request) static inline bool cpu_handle_interrupt(CPUState *cpu, TranslationBlock **last_tb) { + /* + * If we have requested custom cflags with CF_NOIRQ we should + * skip checking here. Any pending interrupts will get picked up + * by the next TB we execute under normal cflags. + */ + if (cpu->cflags_next_tb != -1 && cpu->cflags_next_tb & CF_NOIRQ) { + return false; + } + /* Clear the interrupt flag now since we're processing * cpu->interrupt_request and cpu->exit_request. * Ensure zeroing happens before reading cpu->exit_request or diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index bd0bb81d08..bd71db59a9 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -1738,7 +1738,7 @@ tb_invalidate_phys_page_range__locked(struct page_collection *pages, if (current_tb_modified) { page_collection_unlock(pages); /* Force execution of one insn next time. */ - cpu->cflags_next_tb = 1 | curr_cflags(cpu); + cpu->cflags_next_tb = 1 | CF_NOIRQ | curr_cflags(cpu); mmap_unlock(); cpu_loop_exit_noexc(cpu); } @@ -1906,7 +1906,7 @@ static bool tb_invalidate_phys_page(tb_page_addr_t addr, uintptr_t pc) #ifdef TARGET_HAS_PRECISE_SMC if (current_tb_modified) { /* Force execution of one insn next time. */ - cpu->cflags_next_tb = 1 | curr_cflags(cpu); + cpu->cflags_next_tb = 1 | CF_NOIRQ | curr_cflags(cpu); return true; } #endif diff --git a/softmmu/physmem.c b/softmmu/physmem.c index 314f8b439c..3524c04c2a 100644 --- a/softmmu/physmem.c +++ b/softmmu/physmem.c @@ -912,7 +912,7 @@ void cpu_check_watchpoint(CPUState *cpu, vaddr addr, vaddr len, */ if (!cpu->can_do_io) { /* Force execution of one insn next time. */ - cpu->cflags_next_tb = 1 | CF_LAST_IO | curr_cflags(cpu); + cpu->cflags_next_tb = 1 | CF_LAST_IO | CF_NOIRQ | curr_cflags(cpu); cpu_loop_exit_restore(cpu, ra); } /* @@ -946,7 +946,7 @@ void cpu_check_watchpoint(CPUState *cpu, vaddr addr, vaddr len, cpu_loop_exit(cpu); } else { /* Force execution of one insn next time. */ - cpu->cflags_next_tb = 1 | CF_LAST_IO | curr_cflags(cpu); + cpu->cflags_next_tb = 1 | CF_LAST_IO | CF_NOIRQ | curr_cflags(cpu); mmap_unlock(); cpu_loop_exit_noexc(cpu); } From patchwork Mon Nov 29 14:09:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 519711 Delivered-To: patch@linaro.org Received: by 2002:ac0:c605:0:0:0:0:0 with SMTP id p5csp6146988imj; Mon, 29 Nov 2021 06:23:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJwiEDfdZqQK2ZIXskBfAfAkbdY5irzDVzygrwJqVMGBNykYX732KWJVuFF6hGH7UWqDUzwr X-Received: by 2002:a05:6830:90a:: with SMTP id v10mr45334277ott.223.1638195779936; Mon, 29 Nov 2021 06:22:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1638195779; cv=none; d=google.com; s=arc-20160816; b=cANjZZ5tS5rY9zvg++XbIWRwshBJ2q8nW2Fz5osJU4E4FF5Y9XjR0x1dxfZqdA0RqV EQ8cfsvZCiGTy0+HHk+jHbeOXWkzJIZchsRo8EeyKimLfYeWwike+jN6XnIGhiPlsx8d d/XaRE1haRSsYoTjWF8jrJ/3m2HghvLLnDOZ6jhVONTkVaiu5IC+mWjwXoWYd3yewfi1 1qgKKYIUFVCJsPqGXIj2SQdUJkJIayd9oih5ywcNNGe5xxSsS+WZhE6FbJ7Y+rRdwXbJ SmcoNvG2Xjm/KQ2nF8qkhjFTOIGBbAon4L7/Uwo0BKPEMxGrZCg8+BGeLgFNc/giCAVn ACfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=ouEp36joxnPAP6ToPpz7+NhGlX24uSLIBMD0iYKDcl0=; b=a69hOu7g3tdFnFrcciXbTmmcqUot11UU4yLL6EAKo4j7cbxVwk6D+jhiEWI0r7UuhL IeTXjCVv/pXRsdiYB1vyHaXe3WXjWlRn//eCtrvvUM+j7t5VWOXx0zkunNtItTL1ldAt HlMetw+Cpxl2w8eGkYsGYsomncPM8fJBV+kf3vb2IY/AkOEpxLTz9/YouI5fxoDUVhSf PB3nviZ4a4UxRNsVe/NhsGjRopjgwR2jOjjypXlU6rimVCoKtKlo1XwChx5rY9Cr3bS/ eiQeoyGtTR8Fa8gK5TTorlXVtOUbn8NLhZ9Y/St6Q46XigAoJxN38UnmwGMpRcRzaIhV romA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=kYQG87QH; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id k13si15081416vkr.270.2021.11.29.06.22.59 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Nov 2021 06:22:59 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=kYQG87QH; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:36806 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mrhYZ-0001vX-Bw for patch@linaro.org; Mon, 29 Nov 2021 09:22:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56370) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrhLk-0001Hc-Fi for qemu-devel@nongnu.org; Mon, 29 Nov 2021 09:09:44 -0500 Received: from [2a00:1450:4864:20::32c] (port=38840 helo=mail-wm1-x32c.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mrhLh-0006UV-2a for qemu-devel@nongnu.org; Mon, 29 Nov 2021 09:09:44 -0500 Received: by mail-wm1-x32c.google.com with SMTP id p3-20020a05600c1d8300b003334fab53afso16924038wms.3 for ; Mon, 29 Nov 2021 06:09:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ouEp36joxnPAP6ToPpz7+NhGlX24uSLIBMD0iYKDcl0=; b=kYQG87QHMlgrKeUfuE59nUCz0/d/vQyrkkFElPWhW1yUCLwtnGwjHKVprUpZKQWqp1 dUmCd48nyt7P0lERtCw9MP07OKxJLeT9NToKjLr1XkGIhzcn0fTW6ra1OWfUhByT5jtI 1cYEOaqEzA/czAgGHTAPrjcije0y8sqfoQhc84E3ZqWj5SLkglcyPROyFXjqmUCGsG8V w35rc7h2ChfnZbpUt5OmIDzhDIZIDFnq/XrgmivGFESJlPVeZKFH/BWrIxQXnBQ/fbBx SqAH3t+dc8J5lHi9ijGDXg2KYnu754iLXDccm4bwKu+hvN0LnDcl8z6puFYcXysI4roB dcvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ouEp36joxnPAP6ToPpz7+NhGlX24uSLIBMD0iYKDcl0=; b=nEX3SoppvmLi5ggm08PqUMz8j/vw8YgBKoZNYH8HrDBeUGx/adT7o5dA0QTfOx5X82 9OMjRltKLS6lSXHKt3kv399T0yFUiYPJRtnzTmWPFGEvAwMzmW+f8/Nk27PRtg8NH2MH Z/Qt7VkpbJ86RFy4T+A7eSOVyC0w2S+wBrgO6MGbiTAkYAxlVTgfTN/BxvpVCsBGw4Df XmTIPQ8HoVW9zH3CcrY8nPqzaT+Dme9DXrBmY/mpQgBwaWMS3TP4BEQZRK9EvEVaVnxT aaplZxY4St1neyX6ra9OxoK+fWU1mal0qQeE8pB7eU5ygu0olDKaw7BMcIm/eqTKYqus o1pQ== X-Gm-Message-State: AOAM532d6J012i42DimmfqABjemPSfmvzOV7TLpOtNM15zRN7Zv4+vZ8 svcP9WUY2DOchAX1+PEfWFr5Gg== X-Received: by 2002:a1c:770e:: with SMTP id t14mr35829986wmi.173.1638194979787; Mon, 29 Nov 2021 06:09:39 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id m20sm22730587wmq.11.2021.11.29.06.09.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Nov 2021 06:09:34 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 32BF01FF9A; Mon, 29 Nov 2021 14:09:33 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v3 3/8] tests/avocado: fix tcg_plugin mem access count test Date: Mon, 29 Nov 2021 14:09:27 +0000 Message-Id: <20211129140932.4115115-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211129140932.4115115-1-alex.bennee@linaro.org> References: <20211129140932.4115115-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::32c (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, berrange@redhat.com, Beraldo Leal , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Richard Henderson , f4bug@amsat.org, Wainer dos Santos Moschetta , stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com, Mahmoud Mandour , Alexandre Iooss , =?utf-8?q?Alex_Benn=C3=A9e?= , aurelien@aurel32.net Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" When we cleaned up argument handling the test was missed. Fixes: 5ae589faad ("tests/plugins/mem: introduce "track" arg and make args not positional") Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20211123205729.2205806-4-alex.bennee@linaro.org> --- tests/avocado/tcg_plugins.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/avocado/tcg_plugins.py b/tests/avocado/tcg_plugins.py index 9ca1515c3b..642d2e49e3 100644 --- a/tests/avocado/tcg_plugins.py +++ b/tests/avocado/tcg_plugins.py @@ -131,7 +131,7 @@ def test_aarch64_virt_mem_icount(self): suffix=".log") self.run_vm(kernel_path, kernel_command_line, - "tests/plugin/libmem.so,arg=both", plugin_log.name, + "tests/plugin/libmem.so,inline=true,callback=true", plugin_log.name, console_pattern, args=('-icount', 'shift=1')) From patchwork Mon Nov 29 14:09:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 519707 Delivered-To: patch@linaro.org Received: by 2002:ac0:c605:0:0:0:0:0 with SMTP id p5csp6138824imj; Mon, 29 Nov 2021 06:17:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJy4CM2PKlnGfsp9GkWuKmqYD6uMIwlbSXCYy6/XMmm/Q/iIJ24w0X5I6aPt0cLl2+xNCmbx X-Received: by 2002:adf:f5ce:: with SMTP id k14mr33967992wrp.100.1638195440604; Mon, 29 Nov 2021 06:17:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1638195440; cv=none; d=google.com; s=arc-20160816; b=1BUjaFnOtXpwwXiETTWjb6KZ2MaBlV1bGHg405+7EJHlQ2aEbnHm6Q6xtuDe7juRE0 EWn9akYRlEKdMSgEL5baI5IIhS9NN7xSYJT0YkvVTQl/hmeE9BbYPItc8H2iBZ6xwajQ cq0xcuUaaYBqdMMNGG9JXpiPJp/M169N0/f7Zo6US+tu+sPwQ19EzKNsLuP4Zvl0xFAn 6sMOWG4sp8hVnndQNqFE/qBZukKcx5cpU+z7bju/V9pczEA6C6Ju5fCgk7YbkYcosp0S Fzlc+f8AQoAP/htUHGkLy8rUeweAQCrck2td6Wdul+GmKZTKVeWslmZubpoCiEmtq1Vj dUlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=IBnkomQJkxbzzpqUI0StuDJRpi3gzRMQ5u3DHeZjNiQ=; b=yjgLyTFAQe8tcBK54PUPDsM/+yNB6/kJ3+Tlxarb8xOdk9NEFgvt4coLMk/3AqsMii 5oTF51ZqCIwGOnGJXL9pmFmRNJG9RmMpD+uqn7qCPqUqQeFwAePe/LYIV9NztfkNaBK7 Q0jg5Gwns6EhL6mPWqzzCT5AiONDdaRNXkPBaJTMzZ1o15/VplK5AvSMAx7y6RMnDUJw N977cFDrSha0eoqbHV9Yj2vIOU6sZf7A27hNFE2qHv1EWZLbsqi9gcezxeaGibE1KRU/ 10M4OIR3rmqw17/5cUVIQJtsDmHjHhmRLH5g5hliSOZn4UgHms1UQwGgNeKgJZkE177k GX6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=nxyGWxtk; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id e12si31314004wrg.172.2021.11.29.06.17.20 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Nov 2021 06:17:20 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=nxyGWxtk; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:53850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mrhT5-0002hv-It for patch@linaro.org; Mon, 29 Nov 2021 09:17:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56318) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrhLi-0001BW-QH for qemu-devel@nongnu.org; Mon, 29 Nov 2021 09:09:42 -0500 Received: from [2a00:1450:4864:20::42f] (port=40936 helo=mail-wr1-x42f.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mrhLd-0006Ty-31 for qemu-devel@nongnu.org; Mon, 29 Nov 2021 09:09:42 -0500 Received: by mail-wr1-x42f.google.com with SMTP id t9so20122477wrx.7 for ; Mon, 29 Nov 2021 06:09:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IBnkomQJkxbzzpqUI0StuDJRpi3gzRMQ5u3DHeZjNiQ=; b=nxyGWxtk/O1klH5UIHZvtFe9ZKeXj+mHD+0nrRvVgeyWhJELmQNnnuZVDwyhXid3MD Vuch5psX6dmXOyoD/PeEZPySI86MI1Gvr0Dajx0LEdOHNm54FUl08+i+JDkIORHxx5Bs Y8+bTl8UF6xTC2gaY965Z17QUezOxCv4n72O9TU8RhkZdYnogq1aKrUm4Qmkkb69Psko 8OiDp08xjBrMxkSlOyPto1j2yeVjtWZ6Ew8TFrlB6Thy9/PTwGOEJJMpBI9R+rMlr6NL xxVREAr3kmMn9UNSj9McTNH+f2df2s6nHKwlYIN+p+Ck22JHuiU6icPW3DAyDvAlIV7i Ybnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IBnkomQJkxbzzpqUI0StuDJRpi3gzRMQ5u3DHeZjNiQ=; b=W0gtoEKXyGmYW2qsWKGk2NwCza+JkK3OqeVaWVl5cm1jhKOw5Okc41OBJLfxRyAkO4 w8UEqsvnQS+yIRfvUcCDqM49z9w7pOIx/tYB8SiyAAd/z/Ald+64Bn+x3KkLOTOVYI8n WHXS3JKZT7ez5l2kKpAKjVxvEKcnQwup+Mcm4C3gEiX+EEcpWcnM72RIEEDMA670QcY/ T40/6ogDrSDlrgxj3RkobZ05MV7d7TCL+S3gfUTMfi54qsCQPQdmEMLLgRDsDSHGDNTQ Uo5zYnLrx6XYTes8TYO59zif97TpEP/dL2/zpe5qZ48EkXGrXax1HHfB0VTjhjnR1SgL plGQ== X-Gm-Message-State: AOAM5302yGqzjaBWa4flY6P2ALzF2tvEknLT0l+iqeWIP9pDm8f1EW/5 ccJZoF19/+dFD8tZdADI+nfMhw== X-Received: by 2002:a5d:52c2:: with SMTP id r2mr34699012wrv.548.1638194975597; Mon, 29 Nov 2021 06:09:35 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id y7sm13646852wrw.55.2021.11.29.06.09.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Nov 2021 06:09:34 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 4AF141FF9B; Mon, 29 Nov 2021 14:09:33 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v3 4/8] plugins/meson.build: fix linker issue with weird paths Date: Mon, 29 Nov 2021 14:09:28 +0000 Message-Id: <20211129140932.4115115-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211129140932.4115115-1-alex.bennee@linaro.org> References: <20211129140932.4115115-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::42f (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, berrange@redhat.com, Stefan Weil , f4bug@amsat.org, stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com, Mahmoud Mandour , Alexandre Iooss , =?utf-8?q?Alex_Benn=C3=A9e?= , aurelien@aurel32.net Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Alex Bennée Tested-by: Stefan Weil Fixes: https://gitlab.com/qemu-project/qemu/-/issues/712 Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20211123205729.2205806-5-alex.bennee@linaro.org> --- plugins/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/meson.build b/plugins/meson.build index aeb386ebae..b3de57853b 100644 --- a/plugins/meson.build +++ b/plugins/meson.build @@ -2,9 +2,9 @@ plugin_ldflags = [] # Modules need more symbols than just those in plugins/qemu-plugins.symbols if not enable_modules if 'CONFIG_HAS_LD_DYNAMIC_LIST' in config_host - plugin_ldflags = ['-Wl,--dynamic-list=' + (meson.project_build_root() / 'qemu-plugins-ld.symbols')] + plugin_ldflags = ['-Wl,--dynamic-list=qemu-plugins-ld.symbols'] elif 'CONFIG_HAS_LD_EXPORTED_SYMBOLS_LIST' in config_host - plugin_ldflags = ['-Wl,-exported_symbols_list,' + (meson.project_build_root() / 'qemu-plugins-ld64.symbols')] + plugin_ldflags = ['-Wl,-exported_symbols_list,qemu-plugins-ld64.symbols'] endif endif From patchwork Mon Nov 29 14:09:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 519709 Delivered-To: patch@linaro.org Received: by 2002:ac0:c605:0:0:0:0:0 with SMTP id p5csp6141469imj; Mon, 29 Nov 2021 06:19:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJzn3HHhsASmu85Bbo7UDqIQN2V61s7m2sFoBbaEJDiBF/ZWUp7OoRqKfS/OKGvYl0wu37SX X-Received: by 2002:a05:600c:4f44:: with SMTP id m4mr37643429wmq.95.1638195540768; Mon, 29 Nov 2021 06:19:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1638195540; cv=none; d=google.com; s=arc-20160816; b=lpqdoUsLJBqfREqsQyOlbVRAI78mONtb325dy7yIKK16n9zFFepRBQTOpmE20DlIsR 68arbBmYpLN235FB/2ib/Poax5JRXls2HLMTR8QBqXhpmLZUYqny5x+Y/FSZdM1TPrIw DLrEX2a1go/IDi7EUbclWvbGYQIGDaTHXf7Kk9cBRFFz2kcvlZsqPMhrk06KOHwf++jy TJFxDSzp5/L2xVYFrd+sS5XkFXWYmZyMiPAY2M1+i6nhrd7zTXbxYrQpKzkenx6vz7lf wF2oUgs/L0Vene+I9uOLFmwUkKz201i9Dilj9g3kSg53zMD2C3I99Z0C+AWiPYhtWWJQ edOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=bUO0SB+BMTWj4cM859jVLA0edAg0vIZYqctggby2tKg=; b=I9IAluNS25t9KongnZcWDFO3Fe2vaC7ITaSmHb8ZseYopGJ74MxGdDLrP8tRUMmk0o Ei88lA5NZUH2fvvYC2bMKQc4CCD0lsVXVuQKsjSgHXqpxjuuz/wWewKQ6czo703NZQNM pURd/9rDREIghGiwFM7pU6r7Xy5nr7KKYqMkv+PJL0zJ6OSA2pO4VmEY1XrheiM2mTKw w1/MAZl9+aCuvg83ebTedi+KsNmq9LyrQdVe0rzDiUHC2/v9SEIp4jw/dvFTLdtTu3PL ZW8aGUCwiHfxBVx9/lhqrViAjlPxGWitjSModG0VJfBWz11TEDKANMuedQxvFgeSMfdu Juww== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=vBCptxwG; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id f10si31058893wmg.131.2021.11.29.06.19.00 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Nov 2021 06:19:00 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=vBCptxwG; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:57990 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mrhUh-0005aH-TK for patch@linaro.org; Mon, 29 Nov 2021 09:18:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56444) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrhLo-0001Vh-TD for qemu-devel@nongnu.org; Mon, 29 Nov 2021 09:09:48 -0500 Received: from [2a00:1450:4864:20::42e] (port=39855 helo=mail-wr1-x42e.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mrhLm-0006Wh-R1 for qemu-devel@nongnu.org; Mon, 29 Nov 2021 09:09:48 -0500 Received: by mail-wr1-x42e.google.com with SMTP id a18so37122846wrn.6 for ; Mon, 29 Nov 2021 06:09:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bUO0SB+BMTWj4cM859jVLA0edAg0vIZYqctggby2tKg=; b=vBCptxwGyZhz+7Y8v8Q0Z2bHKlAj7rmBwo+/nSQALIhXMZakiGhxHXs8e5PLgeY/CD fcBzwfA/ySpJEx3QFx/B+d6EiQ/JuKwDV+mIeKGzeFwrkFsPeNs77bA9E6m01c08c4zA eA1xDfiGzHPOpyNhEdBc95Drx+h4hJpvkqGJAl2MgSfHf9GkaSy/m+iCgP5jIAI5RnQ3 YIrgunHiIdbpEb+i/BmNAYySHkWg8C2ApS8Q6GwgNVcdgBwKkEibV9Y/F724jTHJ+Xmb OAqcZRzBqiLrqDUcHzZyRrpRdg6iHiDRj4qp9If/zkckERTTgWS6kviNyYjjFdBUoTij YnWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bUO0SB+BMTWj4cM859jVLA0edAg0vIZYqctggby2tKg=; b=aVC6kgG0fIHEHfVmp4CG/JO8qfyXqzne0BQXW6FpWVlYddgy2y6wZHo5k8zk61E7YZ /UPUR30cR2OerBaIZzd6qYYJSCXXhPAQnAURMrGdjx0mnAiPUsSOaoduCaX8kDFJ9gTP YkuO5TWvSlcsqopBevZWjWvRxzvmVKL3UXmc4rZQ0Jg+zXpm06PPTjfS0P9iSqxDyrCF XnrkcVsR1dZ2jbN2MVlNkhXoAqU5H6aM9HnhN8nibs2C2lUepKJyFFAoTuOQgqJ7M+4+ BNOMcOe98li9xiyUAKS07I56lllGaYqQhmIJtH+uQX+PRbdpBIZQOihCPWR0ZOuTEgTV 8Kcg== X-Gm-Message-State: AOAM531y+18jPq5IPzPBkffa196YHFnVvQsXcV15z8Q3ZjBLxAw1Jrm5 TS+KZpadgx9MFynxhvVnaXR7Kg== X-Received: by 2002:adf:ef52:: with SMTP id c18mr34807909wrp.162.1638194985251; Mon, 29 Nov 2021 06:09:45 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id z6sm19448585wmp.9.2021.11.29.06.09.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Nov 2021 06:09:39 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 5770B1FF9C; Mon, 29 Nov 2021 14:09:33 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v3 5/8] gdbstub: handle a potentially racing TaskState Date: Mon, 29 Nov 2021 14:09:29 +0000 Message-Id: <20211129140932.4115115-6-alex.bennee@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211129140932.4115115-1-alex.bennee@linaro.org> References: <20211129140932.4115115-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::42e (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, berrange@redhat.com, =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , Richard Henderson , f4bug@amsat.org, stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com, =?utf-8?q?Alex_?= =?utf-8?q?Benn=C3=A9e?= , aurelien@aurel32.net Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" When dealing with multi-threaded userspace programs there is a race condition with the addition of cpu->opaque (aka TaskState). This is due to cpu_copy calling cpu_create which updates the global vCPU list. However the task state isn't set until later. This shouldn't be a problem because the new thread can't have executed anything yet but the gdbstub code does liberally iterate through the CPU list in various places. This sticking plaster ensure the not yet fully realized vCPU is given an pid of -1 which should be enough to ensure it doesn't show up anywhere else. In the longer term I think the code that manages the association between vCPUs and attached GDB processes could do with a clean-up and re-factor. Signed-off-by: Alex Bennée Tested-by: Richard Henderson Reviewed-by: Richard Henderson Cc: Richard Henderson Resolves: https://gitlab.com/qemu-project/qemu/-/issues/730 Message-Id: <20211123205729.2205806-6-alex.bennee@linaro.org> --- gdbstub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdbstub.c b/gdbstub.c index 23baaef40e..141d7bc4ec 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -94,7 +94,7 @@ static inline int cpu_gdb_index(CPUState *cpu) { #if defined(CONFIG_USER_ONLY) TaskState *ts = (TaskState *) cpu->opaque; - return ts->ts_tid; + return ts ? ts->ts_tid : -1; #else return cpu->cpu_index + 1; #endif From patchwork Mon Nov 29 14:09:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 519712 Delivered-To: patch@linaro.org Received: by 2002:ac0:c605:0:0:0:0:0 with SMTP id p5csp6150219imj; Mon, 29 Nov 2021 06:25:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJxD7amFd41RoG78igS4kJ2ZGY3qwWrVjDMdwk5rMaYrc5pM9ltYO57MI9SC19WW8nyL09J2 X-Received: by 2002:ad4:5dc9:: with SMTP id m9mr30422252qvh.113.1638195911813; Mon, 29 Nov 2021 06:25:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1638195911; cv=none; d=google.com; s=arc-20160816; b=VVcOqriCVoCHP5wurehAYFRDy9A6GwHRYwcxvkv7Z787rphr5MSQWH4Zw0O60WYZKQ f5IKSaEdU1//WTuF6S5ASuNDlhdkUfBsJscS1B6P7msJs7k6UmgUEHchle8+UFXLPZtQ oUSvGP7k64x4Mub5s1xz4tywQHQX0NqyL+D/Q1MAQge6xBV4hvDYXGIwR582aebNAAPp b3f2G+xfywku8un2iji+RR3TOL+M+VLCm/SSld1NJKXDdvfbAye3y1JAOsQnYFfXxBZt gG5xHk2iyiaIv7aKOHq/CYOvc2pYtYKQkbOuBF8tCROI6c110jxjSQKjAOw3JWk2bNsC h42g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=/izHlYo1eDjiSDXKoXYRwJfwLHOfDK99Sn/yTJcOteo=; b=zfb4ZO7LxqKZmuTfW+PeZLA4ZGv0ykM5TbKcG8jejTPnr5RgXLJTO8dYQjiZ2ubBUk grPX4GNlSwRP6KbI8/P+oEzu5IbNVM6tX89jwXnYVcWrsB4t8CUyyVyxL7uI/yZ4/G4U ri7wov9bTXVy0wqkCc8TJaRWnkUqc/Rj3jvkbSSidfxQg64mEwvVYvw39Lo1D/pNt9P7 l8gfpUzv/b7E/sq3SQQkDLnqlvq3g90hZObikdPrJnEDDh0Q1FTu0jT02OFILZELk0a8 Ia/UhHBC78clS5Ar0ltL3pmWYMi4WN56Q39kiYk6DboUbz/rAyaFpcKWzFwALERpFwpR EsOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=hyknblUA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id t24si4086856vkl.29.2021.11.29.06.25.11 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Nov 2021 06:25:11 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=hyknblUA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:41390 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mrhah-000596-7v for patch@linaro.org; Mon, 29 Nov 2021 09:25:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56454) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrhLp-0001Yv-Lf for qemu-devel@nongnu.org; Mon, 29 Nov 2021 09:09:53 -0500 Received: from [2a00:1450:4864:20::42a] (port=33725 helo=mail-wr1-x42a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mrhLj-0006Vi-E4 for qemu-devel@nongnu.org; Mon, 29 Nov 2021 09:09:49 -0500 Received: by mail-wr1-x42a.google.com with SMTP id d24so37159562wra.0 for ; Mon, 29 Nov 2021 06:09:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/izHlYo1eDjiSDXKoXYRwJfwLHOfDK99Sn/yTJcOteo=; b=hyknblUAE5zpHyqPYon6KtwVJxni6A1aDV5KaSx92becnD0Sh4ugKRu8lD2SPjzJC0 1NhPXvUqVK4eB41/smwqdnDjMgTFwk5do1NnYjGW8eM3+qqBEjCUlseNs1RZS564mgQZ Bi1xevqc77l81w/UNo3VGAJ+UHIjZ/K0bvdNQkj8lDzY4msjgEhupqDFnhga9K+cROSe w23LJ5MBu8y9oTBoouBXCcbCmV8+DvgkDxxaUS+pmy60oWQdLbbGCTAvDHUwoikx9HfD tZDN1ObMdIFH6EouXDMF0631f2+me0tX3V763AlLtD6zL9gwp8izPoLgZ7Nkupc5BY8+ IY0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/izHlYo1eDjiSDXKoXYRwJfwLHOfDK99Sn/yTJcOteo=; b=uGFgDu8td9AdG/DRz1IS41WXzh6cmgChk5S3nWWE6kghj3wLgdppF/8EFkKucvBAiM si1AYay6OkmpVDkDkG573/sCRYiwPBrNymz6p+TF5dpw0Jxsqaq9JJQElNmNGm0Bglug lW1kAbIGjBPuMDZef70fUvAwiqzp0ajiKVcGdJhwkxnqEB7WmS8vm2PYLE2UyvzD++Jn 1DaCZeLR6gNxGDB5kLYR9VAZ9c1PWJSLOa5Q4frYzRZ7RThkHWyZVKKvRxwnXW651tbl LqPKqGWiiIb4Em//jWlbSl8ubwORJ+YyG270QTLG6kddT8bHfU+j68stkoF72HKotQR7 J83w== X-Gm-Message-State: AOAM532/sTF4qvR6740b8WwAaj5ATZ4Lo3+wjqd0JbeBbngISVRYd4gM W1p/TCtb+S4nJnjtIgZAg+3Slg== X-Received: by 2002:adf:b355:: with SMTP id k21mr33101423wrd.451.1638194981510; Mon, 29 Nov 2021 06:09:41 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id b13sm10506295wrh.32.2021.11.29.06.09.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Nov 2021 06:09:39 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 6D7E71FF9D; Mon, 29 Nov 2021 14:09:33 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v3 6/8] MAINTAINERS: Remove me as a reviewer for the build and test/avocado Date: Mon, 29 Nov 2021 14:09:30 +0000 Message-Id: <20211129140932.4115115-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211129140932.4115115-1-alex.bennee@linaro.org> References: <20211129140932.4115115-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::42a (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, berrange@redhat.com, Beraldo Leal , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , f4bug@amsat.org, Willian Rampazzo , stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com, =?utf-8?q?Alex_Benn=C3=A9e?= , aurelien@aurel32.net Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Willian Rampazzo Remove me as a reviewer for the Build and test automation and the Integration Testing with the Avocado Framework and add Beraldo Leal. Signed-off-by: Willian Rampazzo Reviewed-by: Beraldo Leal Message-Id: <20211122191124.31620-1-willianr@redhat.com> Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20211123205729.2205806-7-alex.bennee@linaro.org> --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index d3879aa3c1..8f5156bfa7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3469,7 +3469,7 @@ M: Alex Bennée M: Philippe Mathieu-Daudé M: Thomas Huth R: Wainer dos Santos Moschetta -R: Willian Rampazzo +R: Beraldo Leal S: Maintained F: .github/lockdown.yml F: .gitlab-ci.yml @@ -3507,7 +3507,7 @@ W: https://trello.com/b/6Qi1pxVn/avocado-qemu R: Cleber Rosa R: Philippe Mathieu-Daudé R: Wainer dos Santos Moschetta -R: Willian Rampazzo +R: Beraldo Leal S: Odd Fixes F: tests/avocado/ From patchwork Mon Nov 29 14:09:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 519710 Delivered-To: patch@linaro.org Received: by 2002:ac0:c605:0:0:0:0:0 with SMTP id p5csp6144249imj; Mon, 29 Nov 2021 06:20:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJzEvonX4uRgdgTV453Xf8k9Ug3f+AjEEuugiXTRyjNDR4YxisKgiDSvHaNGXXwk/emVdWRO X-Received: by 2002:a1c:4c06:: with SMTP id z6mr37060402wmf.185.1638195658080; Mon, 29 Nov 2021 06:20:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1638195658; cv=none; d=google.com; s=arc-20160816; b=A8bPYxQLgzdr/WolLE9sbd4va33hMEkWbiFHe149z5Q7U4hIGAlfeKXt90EHuvMDQ7 r7pDBZ8h22o2uY235tNuBgH1IEbP5NfpmV53Qws/YzUv9yfRMD2FAHuwD/eHaWl7maB1 AX2SB88ZwEr4Fy0ApzlHjcsmLPmPVMNrIjHm8GLV6AbdsSKebaPvZMA0lsJ2QGgnpeu9 CibJMu/v4gGE05qAouHkgc7L8+E9BOPD54e8l2sj58vLXP0YpJ5DoQFNC+AVywdbrCMi fXGglQUCbtfUWwCEHBJK5n82q43x8kH0hLEQ/Fv04rqb1ci04sAhgRl1omui5so4P1e6 tq+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=RyIHG7rbgW4Ax4rztavLtHw3c5eLl5GAByR6z8d2y5A=; b=BSWcpyNlF0Pel67Wlyf5+n+u8g6hPkSafUwriSxbp+7xfW0rP2KqXnhS5/4s4qrUKA kCzRCmyjS06aApaAJ1Ci5gAiNy/1dXAHX6JEVBlvqAqx8tEGhMw9T9Y0GXRgeuYeevBb /4vqZc1Di7UqHRDFkqK66R50q3YZC5Iss5qtll2/mO4Nek+7lv3z1NjoOBhYdCPxGByu 3lEjoZlsJHFBk521CPs8L4EiGVs5me8b0GzNaPABPKHE7PF25KqGCRJeMJAy4VT/oIG1 YcepgRjxQmd+Q2eE4kyVBhaVNLC5uMzZTluX+FMmRE9xs1btpVjiaiXBuYZCNMjx74il SpZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=PlfctvyA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id i67si26009914wri.533.2021.11.29.06.20.57 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Nov 2021 06:20:58 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=PlfctvyA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:33916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mrhWT-0008Qn-Iy for patch@linaro.org; Mon, 29 Nov 2021 09:20:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrhLl-0001MN-QU for qemu-devel@nongnu.org; Mon, 29 Nov 2021 09:09:45 -0500 Received: from [2a00:1450:4864:20::42b] (port=43808 helo=mail-wr1-x42b.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mrhLj-0006W2-LV for qemu-devel@nongnu.org; Mon, 29 Nov 2021 09:09:45 -0500 Received: by mail-wr1-x42b.google.com with SMTP id v11so37084200wrw.10 for ; Mon, 29 Nov 2021 06:09:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RyIHG7rbgW4Ax4rztavLtHw3c5eLl5GAByR6z8d2y5A=; b=PlfctvyAuSm/NmQ03mobkKCoMnJVg+7DfPA0Pp6KIEaM8hsDBm0x3+81xh2X6SRq/W yfZMWjbba04U2X3C+UdB5KycwWaMjdUhL2aTSlsR0fHAAC0eD4oWiKe2ZPp7pr49aDQ6 8NZtWsmsdZOX0wX088spbq+lWnexhZeUTP1gFfl9Wu2SuEL2A/ZEtFvWI2CWpk1IXR+L jUTv1Ohiaux7M5ojo1B+FbnrJdxRSLcTWSBW0Tl1z8MSPNfyCEh6cdQ30f+qdZjJ/0J2 jysTsPuQyAD1ojaq/33wSDv8qXq177KS7t9PwsjhSeOc53gspC21sPtOxFrdR3LDLX8a XDhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RyIHG7rbgW4Ax4rztavLtHw3c5eLl5GAByR6z8d2y5A=; b=olqlWWG+DbVhfBjmROSR/AtQi29Ijv8QrTis2GqwcqkvtQcud26MQR808ArsTFYDI7 Y5PS8+cUMaaZ4lwmn+kD66+y1h27iZoLd5S2lLlCyiym6DU4lUxVYVdz5X/hA2ko04fA tSRZm1liWeWu/EvvHUuwOm7YcdrpiS90/KJhmwV/W5IvSQhIXpqE8jMC2BY9oLeQZaGS N6te1uRvcztHFhOXETHawnoRaAXVzxNsOgZJ9fmpuIOBeNTwHUmJbY7y2N6GI89/2WcK L3XhOZTR7FliXdRkcp+er2rtNzaTpjFvNXd9gpLCxvHkbsOWQ2wBuLRT86exZazwx05v JmBw== X-Gm-Message-State: AOAM532sP7PJjz/RWutCpimBLDPXT2LdX28GyjlxO/3QjnI2CHjQBxwP Q+7XjNQ2dd5vhzImzL68ex+dfQ== X-Received: by 2002:a5d:658c:: with SMTP id q12mr34347340wru.34.1638194982055; Mon, 29 Nov 2021 06:09:42 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id b13sm10506316wrh.32.2021.11.29.06.09.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Nov 2021 06:09:39 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 84A701FF9E; Mon, 29 Nov 2021 14:09:33 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v3 7/8] MAINTAINERS: Add section for Aarch64 GitLab custom runner Date: Mon, 29 Nov 2021 14:09:31 +0000 Message-Id: <20211129140932.4115115-8-alex.bennee@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211129140932.4115115-1-alex.bennee@linaro.org> References: <20211129140932.4115115-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::42b (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, Thomas Huth , berrange@redhat.com, f4bug@amsat.org, stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com, =?utf-8?q?Alex_Benn=C3=A9e?= , aurelien@aurel32.net Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé Add a MAINTAINERS section to cover the GitLab YAML config file containing the jobs run on the custom runner sponsored by the Works On Arm project [*]. [*] https://developer.arm.com/solutions/infrastructure/works-on-arm Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-Id: <20211116163226.2719320-1-f4bug@amsat.org> Message-Id: <20211123205729.2205806-8-alex.bennee@linaro.org> --- MAINTAINERS | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8f5156bfa7..006a2293ba 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3511,6 +3511,12 @@ R: Beraldo Leal S: Odd Fixes F: tests/avocado/ +GitLab custom runner (Works On Arm Sponsored) +M: Alex Bennée +M: Philippe Mathieu-Daudé +S: Maintained +F: .gitlab-ci.d/custom-runners/ubuntu-20.04-aarch64.yml + Documentation ------------- Build system architecture From patchwork Mon Nov 29 14:09:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 519714 Delivered-To: patch@linaro.org Received: by 2002:ac0:c605:0:0:0:0:0 with SMTP id p5csp6156335imj; Mon, 29 Nov 2021 06:29:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJzfzMxphHkIdyt5G8cI93upAg2SF1UGYIgPgCVfFRv4ONpRV7QjEEQBAWnVivE0uZv+2RXt X-Received: by 2002:a05:600c:4e02:: with SMTP id b2mr36831514wmq.105.1638196194149; Mon, 29 Nov 2021 06:29:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1638196194; cv=none; d=google.com; s=arc-20160816; b=VzgDtoT9zhi4oMMlOZrnE76g5e/W2PM5QDimvg8OF+7l4gZqKzOBj6YBUU6WCQfZsX zHf4YYIML4tLMmGabvZ0dV75e3sNGCtH5/KiKUyJYeXpz9KBXPc7SAL+XQtssZEPHhYD K2C0K0kxIbpAvAIMEoMKGXWfGG3vQ+SWnMWXgdYG3nxp/I8wPGRtEWk8pswts94IMret j9UNkGYDYr+LOfCgz8wDmH95ovA4KWKDYJ52L+8e9oORRAA55thEz3RjDdEuTQ2yN2/f gWhpRxRpzGFgC4KW9hKXwLhSXsQOyiUlUPuardHvqcfCsocj8pOujzWiM2WYqKaBoOm5 e3sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=bE1boPVSofZsVRYk/2tnKXg+GDOQQWyCjSc44kFDB+A=; b=TXyIZ0p9AYRb2h+8cogmG8ZjaWZtBt9vkrRVz+yTf+GzilwpaEkOyNHNBcFbaoujxc 9UMYY6xZHzN+YyI9AwkM1qNgQRYoLkDc0fHvJPv/AnBOB8+E/B6/ppUS3C9qrfq7O7Lh YPb0uBII7IBQJEDRjY2EoKaEWPnwXI3S3J+n/dWnB77E8KVDnLnnIkqCMzkKWJc6Ad3v xkOOUtmJCw4ZBXVQEAFySkP9kba8vk5dfByFmdnRW+riYDdZTfIt/MHH80Y2I9jyVfT1 VGYbvUXZbuV1212a7ry7XbZrwHfaShlj/VXEmxGnd/OI+xgnlKtEDaj0jvkXQAPuxOTC VfgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=HZWYqXh8; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id v7si22186761wri.432.2021.11.29.06.29.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Nov 2021 06:29:54 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=HZWYqXh8; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:55506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mrhfF-0006Zt-90 for patch@linaro.org; Mon, 29 Nov 2021 09:29:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56416) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrhLn-0001Ob-4b for qemu-devel@nongnu.org; Mon, 29 Nov 2021 09:09:47 -0500 Received: from [2a00:1450:4864:20::433] (port=40941 helo=mail-wr1-x433.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mrhLk-0006WE-Gn for qemu-devel@nongnu.org; Mon, 29 Nov 2021 09:09:46 -0500 Received: by mail-wr1-x433.google.com with SMTP id t9so20123351wrx.7 for ; Mon, 29 Nov 2021 06:09:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bE1boPVSofZsVRYk/2tnKXg+GDOQQWyCjSc44kFDB+A=; b=HZWYqXh8i9QQU+OkMcfBc7J52UYZqVbXSj4nI2M5iaw1x3oz9UfzAx0nEUT5Iskt79 NJ779y0QLEjB4PtzWSYqn8hvarUFisVDRR7aD84UnwzzPhlFE5r+MDcQQ8uXr+jJ8VTD uP6ngFRTq7YmuIMJOFCHvfKhoYSpo+OFgXcgl+SAvJf+NwKgWYC38P9Y67C5PeFMbYcj shs4UQ73p4MNSDLxwE3gfZkLoTaVl8fiMjD7ACmjfNGM72Lk7iLzmTAHok+gVqQd6p1J iEHWifRXgCB1TAuviMmWwBBN7DtXl9ZVndBfUKWG41A4HYt/FEmjg9BCI+eCDdzG7bCa 76CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bE1boPVSofZsVRYk/2tnKXg+GDOQQWyCjSc44kFDB+A=; b=FLKn15qgbxwuf3vrZoJV16rsnSUtnP6yPzFLfpP98hcnDXE3cOo9Kw8l7MJM1Rgmxn jff9M67IlWWdWcKRprt2qRNimmHaTp8bQSe1i+D8KwVoLuM/QGg1sW/qccXmvPKpGVQ3 JmzBda6h4yxZNkianb7xunoVfDydEuLJcJ38rSORGrN09j8swDQTsIr/wHhK/37VSFeQ K0yfrQmlTmGgIVp5f16ZXItZ/9eklC6ayRLlZcpcPmgVlmjMPVDusqcmjChyTrb+shgW qSGO9QA+ebu4kdzjtBomkj53QNNiXXxC5VEvY8JxnttB53efEWqbC+KjRlHYqenLpWZG d/XQ== X-Gm-Message-State: AOAM533EZsBS+Qe/ZUYrMl3CiZVn//DMEMVnCl2V5y6oXLBAi2DcX9a5 ApaVhaduG8Dc+EUHgRSPoQEFNQ== X-Received: by 2002:a05:6000:18a3:: with SMTP id b3mr34450461wri.343.1638194983187; Mon, 29 Nov 2021 06:09:43 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id 138sm19954070wma.17.2021.11.29.06.09.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Nov 2021 06:09:39 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 913041FF9F; Mon, 29 Nov 2021 14:09:33 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v3 8/8] tests/plugin/syscall.c: fix compiler warnings Date: Mon, 29 Nov 2021 14:09:32 +0000 Message-Id: <20211129140932.4115115-9-alex.bennee@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211129140932.4115115-1-alex.bennee@linaro.org> References: <20211129140932.4115115-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::433 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x433.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, berrange@redhat.com, Juro Bystricky , f4bug@amsat.org, stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com, Mahmoud Mandour , Alexandre Iooss , =?utf-8?q?Alex_Benn=C3=A9e?= , aurelien@aurel32.net Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Juro Bystricky Fix compiler warnings. The warnings can result in a broken build. This patch fixes warnings such as: In file included from /usr/include/glib-2.0/glib.h:111, from ../tests/plugin/syscall.c:13: ../tests/plugin/syscall.c: In function ‘print_entry’: /usr/include/glib-2.0/glib/glib-autocleanups.h:28:3: error: ‘out’ may be used uninitialized in this function [-Werror=maybe-uninitialized] g_free (*pp); ^~~~~~~~~~~~ ../tests/plugin/syscall.c:82:23: note: ‘out’ was declared here g_autofree gchar *out; ^~~ In file included from /usr/include/glib-2.0/glib.h:111, from ../tests/plugin/syscall.c:13: ../tests/plugin/syscall.c: In function ‘vcpu_syscall_ret’: /usr/include/glib-2.0/glib/glib-autocleanups.h:28:3: error: ‘out’ may be used uninitialized in this function [-Werror=maybe-uninitialized] g_free (*pp); ^~~~~~~~~~~~ ../tests/plugin/syscall.c:73:27: note: ‘out’ was declared here g_autofree gchar *out; ^~~ cc1: all warnings being treated as errors Signed-off-by: Juro Bystricky Signed-off-by: Alex Bennée Message-Id: <20211128011551.2115468-1-juro.bystricky@intel.com> Reviewed-by: Richard Henderson --- tests/plugin/syscall.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tests/plugin/syscall.c b/tests/plugin/syscall.c index 484b48de49..96040c578f 100644 --- a/tests/plugin/syscall.c +++ b/tests/plugin/syscall.c @@ -70,19 +70,17 @@ static void vcpu_syscall_ret(qemu_plugin_id_t id, unsigned int vcpu_idx, } g_mutex_unlock(&lock); } else { - g_autofree gchar *out; - out = g_strdup_printf("syscall #%" PRIi64 " returned -> %" PRIi64 "\n", - num, ret); + g_autofree gchar *out = g_strdup_printf( + "syscall #%" PRIi64 " returned -> %" PRIi64 "\n", num, ret); qemu_plugin_outs(out); } } static void print_entry(gpointer val, gpointer user_data) { - g_autofree gchar *out; SyscallStats *entry = (SyscallStats *) val; int64_t syscall_num = entry->num; - out = g_strdup_printf( + g_autofree gchar *out = g_strdup_printf( "%-13" PRIi64 "%-6" PRIi64 " %" PRIi64 "\n", syscall_num, entry->calls, entry->errors); qemu_plugin_outs(out);