From patchwork Tue Nov 6 18:09:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 150328 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp4204528ljp; Tue, 6 Nov 2018 10:09:20 -0800 (PST) X-Google-Smtp-Source: AJdET5fvrQLyBcV5OWMGjj6Y/jBzmaywK51GMbH5dCMNEAqHca0+q2M8GfD42dHQv8gxFjMkiv9Y X-Received: by 2002:a1c:91cd:: with SMTP id t196-v6mr2727685wmd.63.1541527760909; Tue, 06 Nov 2018 10:09:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541527760; cv=none; d=google.com; s=arc-20160816; b=EKe4okxGMtzypftgkrdFOxIJd5LnQElesuZQ25YuPW7mY1CJDhjGvGzndW14Xn5GYW 8gwhE9wIuPSwREKiG3nZ/+W75Aex/3RTvb6/YqGEl8fljCHnJJDCRvXEjyGoHELQHI7k hTCCkfPlGwM7dqcwBskJzUiZBkEDlMOW1eHcBpckVWNr6A4MrU4lc3k7kl77G9oaWMPO ZkwrBjuGEROl1/8KjqZ+9c3KOo/fwNmlehrD1es8rtViiOQOIKDXWEVDNvgX27OY9HNS pZFPg6XNrbntnIvysctCSRZBC7GZFblYoj0yfVLJYXxXQAx4t3slTRv4nF3Wvl2QXRYt p57Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to; bh=T5d5BTVs3etNbgrzUrgMNpLaBea+ir7hFqwFyL+pSzM=; b=RcvlmM/q1mwf5fxnj8QHDeyCXKZkQNJGSC8QTsDPHJdJ4VqBslT+N0vcfZuK8BDnbT 2kH4QyoqZ91S60tSEUzuWfyIcbaMw7Hkre7FfMiUZ95d9kInp8WHceOdZu7gU1t9un4y OAWCog59P52YPT5KiXXSauOVSmuF6zv4UN6Tv6xzvq5qipoIJCzYna3GP2eOCveURADq /zIjX7NQSXdn2EexUNHWPonNNeJEPIjqOX37ulcvtx4OKy5KyHO0MATta3JOwuRk7vMQ 8m3QaE3zBie3kvo1J9b8sAi2Q+1bFBik93e9ONoM73vID2HTPuD2ThAfm132cBIwC85C Prow== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=Vl54RnQC; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id k187-v6si2138581wme.103.2018.11.06.10.09.20; Tue, 06 Nov 2018 10:09:20 -0800 (PST) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=Vl54RnQC; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 20D2C267AD1; Tue, 6 Nov 2018 19:09:19 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id C60E1267AD5; Tue, 6 Nov 2018 19:09:15 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id 16AE6267AA5 for ; Tue, 6 Nov 2018 19:09:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=MkJtIUlUcrJORFm8mEYofOuymb6JwDpTYEnob2BpJrs=; b=Vl54RnQCjX9m LsnEr1p9s43N7zAGzgiGz9zv0vqdygUUU5nCrD97a3doVU3KheM67Jju5xxHV0gsyKSlMzE8Wp4bY dRuTVlmS/uEGCjwdgNo1KQdO55InXkVsXUTRJ0JTSbT0CdsABQVXXJHBpFRSFy/Y2nvQl/9qNwHIt 3O+R8=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1gK5mr-0002u8-IB; Tue, 06 Nov 2018 18:09:13 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id 48E00112266B; Tue, 6 Nov 2018 18:09:13 +0000 (GMT) From: Mark Brown To: Kuninori Morimoto In-Reply-To: Message-Id: <20181106180913.48E00112266B@debutante.sirena.org.uk> Date: Tue, 6 Nov 2018 18:09:13 +0000 (GMT) Cc: alsa-devel@alsa-project.org, Mark Brown Subject: [alsa-devel] Applied "ASoC: pcm3168a: remove read-only status register from snd_kcontrol_new" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: pcm3168a: remove read-only status register from snd_kcontrol_new has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 223bc10b84970fd772c105b550beeef3ac3502be Mon Sep 17 00:00:00 2001 From: Kuninori Morimoto Date: Tue, 6 Nov 2018 04:33:02 +0000 Subject: [PATCH] ASoC: pcm3168a: remove read-only status register from snd_kcontrol_new "DACn Zero Flag" and "ADCn Overflow Flag" are read-only status register. These information are needed for driver not for user. Let's remove these from snd_kcontrol_new. There is no detail explanation for these register on datasheet, but, judging from its behavior, it seems these register needs clock to read. Otherwise, I2C returns error. Therefor, amixer command will be failed under non working timing. Without this patch, user often fail amixer command. This patch is tested on R-Car H3 ulcb-kf board, SSI3/4 TDM sound. Signed-off-by: Kuninori Morimoto Signed-off-by: Mark Brown --- sound/soc/codecs/pcm3168a.c | 7 ------- 1 file changed, 7 deletions(-) -- 2.19.0.rc2 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/codecs/pcm3168a.c b/sound/soc/codecs/pcm3168a.c index 5f4327f5b725..115f21658222 100644 --- a/sound/soc/codecs/pcm3168a.c +++ b/sound/soc/codecs/pcm3168a.c @@ -133,10 +133,6 @@ static const struct snd_kcontrol_new pcm3168a_snd_controls[] = { SOC_DOUBLE("DAC2 Invert Switch", PCM3168A_DAC_INV, 2, 3, 1, 0), SOC_DOUBLE("DAC3 Invert Switch", PCM3168A_DAC_INV, 4, 5, 1, 0), SOC_DOUBLE("DAC4 Invert Switch", PCM3168A_DAC_INV, 6, 7, 1, 0), - SOC_DOUBLE_STS("DAC1 Zero Flag", PCM3168A_DAC_ZERO, 0, 1, 1, 0), - SOC_DOUBLE_STS("DAC2 Zero Flag", PCM3168A_DAC_ZERO, 2, 3, 1, 0), - SOC_DOUBLE_STS("DAC3 Zero Flag", PCM3168A_DAC_ZERO, 4, 5, 1, 0), - SOC_DOUBLE_STS("DAC4 Zero Flag", PCM3168A_DAC_ZERO, 6, 7, 1, 0), SOC_ENUM("DAC Volume Control Type", pcm3168a_dac_volume_type), SOC_ENUM("DAC Volume Rate Multiplier", pcm3168a_dac_att_mult), SOC_ENUM("DAC De-Emphasis", pcm3168a_dac_demp), @@ -176,9 +172,6 @@ static const struct snd_kcontrol_new pcm3168a_snd_controls[] = { SOC_DOUBLE("ADC1 Mute Switch", PCM3168A_ADC_MUTE, 0, 1, 1, 0), SOC_DOUBLE("ADC2 Mute Switch", PCM3168A_ADC_MUTE, 2, 3, 1, 0), SOC_DOUBLE("ADC3 Mute Switch", PCM3168A_ADC_MUTE, 4, 5, 1, 0), - SOC_DOUBLE_STS("ADC1 Overflow Flag", PCM3168A_ADC_OV, 0, 1, 1, 0), - SOC_DOUBLE_STS("ADC2 Overflow Flag", PCM3168A_ADC_OV, 2, 3, 1, 0), - SOC_DOUBLE_STS("ADC3 Overflow Flag", PCM3168A_ADC_OV, 4, 5, 1, 0), SOC_ENUM("ADC Volume Control Type", pcm3168a_adc_volume_type), SOC_ENUM("ADC Volume Rate Multiplier", pcm3168a_adc_att_mult), SOC_ENUM("ADC Overflow Flag Polarity", pcm3168a_adc_ov_pol),