From patchwork Thu Nov 11 11:06:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 519121 Delivered-To: patch@linaro.org Received: by 2002:ac0:c605:0:0:0:0:0 with SMTP id p5csp114830imj; Thu, 11 Nov 2021 03:11:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJy0gFTXvqGqCoBmbnyEc9EiF4kwhNWgyhX/GeUfkQa6K/LMrn1zX8l/VaXGsRHwp1CPNEVo X-Received: by 2002:a05:6102:38d4:: with SMTP id k20mr9352973vst.42.1636629096501; Thu, 11 Nov 2021 03:11:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1636629096; cv=none; d=google.com; s=arc-20160816; b=TMDHOEL9GSL574lZ1Yo0gM8rktGSyod16u9JWD/FYkyauCqrbCJJL61Eworfd09FrG C2VQvX618KwgVE8d1rIVlq7PkzMNJIP7Z06JpzndgaLFaQSO6yyT2NbDoGGeAvenWj7e 6onzGKavZW6uctGDzSxY5cTJzrlB3mUWt9lVt4IWuSR7ucFgHJe/3Q9aeq208Mz7Pr5d KEWqn57gBvxB2pGxZuVBclHGuV6YWmPaWfUliZmSXfro4jGSUis8mgamciPcz9Z24NKK IMK08GUxtijo5TpI7773Va4Sjpz3/6AjSLvik6m1rK/G2Ri5kn30BekJrx8hvP2elYYg EXyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=6nPNWSGH2oqme4L/mgDeHjYH64JjrZN0FOeCC5e7HFA=; b=U9QclJCyP7+l+kX2P0YpXQb4V1//R4aSG5TYahGTc5nQErnuMTKL/OwOfhMjMYE6Dh MFlIkpN+ymy3ac3yM0VtvWjZwqXnt96HGzOv+OplmGXxy+dLHNm1YHtsBUKhS93kLCJe BEGSRi8FfN19fxPzDv33u2xuYxXWWZ3oZzy7ingq0nCsg01fe3uIHqqAEr1feXrcoE0a 2hKlLym0ckC/xJrkPQ1+dck+wbEf3o+kQNGebux2k4gnCHBHSUrSB3/6Vt9Bg6tQX0YI v8jrD6j9ZqhUPFgHXHqhUiC/Sb9b6fgRjn4ipXDSSyRL28VvNw9wyfOmmBLY/19ctK7L xo9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=do1ddRpk; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id h3si5920607vsj.98.2021.11.11.03.11.36 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 11 Nov 2021 03:11:36 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=do1ddRpk; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:35782 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ml7zT-0002gS-Tj for patch@linaro.org; Thu, 11 Nov 2021 06:11:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51504) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ml7v4-0004wx-W2 for qemu-devel@nongnu.org; Thu, 11 Nov 2021 06:07:03 -0500 Received: from [2a00:1450:4864:20::432] (port=36485 helo=mail-wr1-x432.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ml7v3-0001j6-G3 for qemu-devel@nongnu.org; Thu, 11 Nov 2021 06:07:02 -0500 Received: by mail-wr1-x432.google.com with SMTP id s13so9160673wrb.3 for ; Thu, 11 Nov 2021 03:07:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6nPNWSGH2oqme4L/mgDeHjYH64JjrZN0FOeCC5e7HFA=; b=do1ddRpkX0XK/VOEX1YBEKqcqbV0HY4uh+BTQOpOftkmNe7oUAOHCKErBH0RlR4XRX OYumYosDubqx1jOwTOc0Ucw6cZoepqVHphEYSNhi9PeS9R016Kb728lPsTnJjq+4zewH Z1RnnO9ZuuvFN0MyGxBru8QMU7S4W9VNqlljEBRHHYS0jTPH/p3dUxq0Fwgfd+oDR8pU +UHJH+2kLyohbACHJA1TeKPRPK152HxqRzGTAozi8XRRRLY6Cpy4Vaw8vm/rOLxkv3zq MzMFT5sMnz4LAPVhB63tf2A7O9JnaBtOTsKCKv8avJPHQhbwxHeg8EPCNJjwJiPDON15 8FRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6nPNWSGH2oqme4L/mgDeHjYH64JjrZN0FOeCC5e7HFA=; b=6zvSYernAWA98NhQHWr7CDRMs4Rw9jyZ2P9HqQ4uKNAHcUIIoxR3kyTHRGVroGS5zy Nsf6t2Zx21vJJYcO/PpyXhTqtyA7xumDcAMh6zlZVQDwubaOdGupW8FyVadWTzaTRaIk JSU1pCWikDG+hAONhGrMQ5nnIZF7YYBalmjnHyQd3cwjdbv9tSDJeGYlBW/Siwl3nBE8 FxoJkNN1mYm2SnQmgrP98Iwn73Wxc11Bc4h757csannEq018Uf1qFwRfq4FE6zHiQjJC eKtNq0kWj+MZ4F3djToH/mNjKlT/y272MoFO12gUJkV9xLHKAKcwfyCr3VJF0mzmmxR/ JLoQ== X-Gm-Message-State: AOAM531CRoyxuRqZBlWUelcHZjPaSgvadyFSsTvW+KHb0TMaGNwOiOaO fiWH5UKe+uSWaOPgFlASw4HqniNMz64wvkVrz0c= X-Received: by 2002:a5d:64c4:: with SMTP id f4mr7969627wri.6.1636628820110; Thu, 11 Nov 2021 03:07:00 -0800 (PST) Received: from localhost.localdomain (10.red-95-125-227.dynamicip.rima-tde.net. [95.125.227.10]) by smtp.gmail.com with ESMTPSA id j8sm2536684wrh.16.2021.11.11.03.06.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Nov 2021 03:06:59 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 1/4] tcg/optimize: Add an extra cast to fold_extract2 Date: Thu, 11 Nov 2021 12:06:53 +0100 Message-Id: <20211111110656.237727-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211111110656.237727-1-richard.henderson@linaro.org> References: <20211111110656.237727-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::432 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=richard.henderson@linaro.org; helo=mail-wr1-x432.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" There is no bug, but silence a warning about computation in int32_t being assigned to a uint64_t. Reported-by: Coverity CID 1465220 Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- tcg/optimize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index dbb2d46e88..2397f2cf93 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1365,7 +1365,7 @@ static bool fold_extract2(OptContext *ctx, TCGOp *op) v2 <<= 64 - shr; } else { v1 = (uint32_t)v1 >> shr; - v2 = (int32_t)v2 << (32 - shr); + v2 = (uint64_t)((int32_t)v2 << (32 - shr)); } return tcg_opt_gen_movi(ctx, op, op->args[0], v1 | v2); } From patchwork Thu Nov 11 11:06:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 519124 Delivered-To: patch@linaro.org Received: by 2002:ac0:c605:0:0:0:0:0 with SMTP id p5csp119241imj; Thu, 11 Nov 2021 03:16:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJy3IFHfmflQu/gF8+2+bLKxwUaLrnnx0rTPnMQEWxlLvN7YLXGsyIs81QsjSNG53QMuuifz X-Received: by 2002:a05:6102:dcb:: with SMTP id e11mr9513589vst.8.1636629367386; Thu, 11 Nov 2021 03:16:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1636629367; cv=none; d=google.com; s=arc-20160816; b=XXDvlIeez4pQKYm70yaF4mCdvUHSBYx77miFcmspe2LWdb2spH1jeT8bDQsKIYXKlB tytx1IE4boqJypAuU7zePK3AFZXRuljqtsmooX5e/IYp+M3tIu184E6/jqU9fSANytYt R2TyfhDANcs9VyEuf22OdfX/MV1BI8cDNAuzSebAaQUN8Jcm8Lg4y5/ucFLbOyfwfXjY 2Pzdrl50PCL/EhtPKSxMhe49oCOGwqlTG4FnV+2rd+dsh2DsHWEi9SVnO0rOvRPHsvHe HqfdKT1jtCe/WvvlIJj7fPXuI4d36XDBqdx0U6Fy2Bj4PnYTlOWj1Hm+67gQRsuzPJB2 ChcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=bh9kIk+bt83GJ1fKJT1mekYlH7elEbiEfE8/vcn0SLk=; b=lqH/WWVN037CGV4MpyPrd0jJ/Kd4TGhIoW451f6Ur3EDdSf3tOt5X9oKenw86+RH+e +ta/u4RDMrhU/H3MWVitqJyjSAVLYBrWwYOIkdRAthmr/EeribvmEE212h4hU/XDAu/B 9kE9bTaRqUw32WJFSjWZESyoOtwrttfdNr2qbHFYQV/EcBRCTN6DALvGbePxxgtwWXuQ EahRcRqHA+5TZhYzlOWKtK9q/yUPGYPzSHW7EkJDwpLpimxfmxMqgiExe4HWCwiGfWR/ vJ8GQiEOV72G0JWXdQ+Fcw0heVM9R9DyR/BKYRQLvh+bmcVlPHJs6Ls2L6K6JI0xqN+Z bPQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=haHowDRp; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id o2si5677389vsh.170.2021.11.11.03.16.07 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 11 Nov 2021 03:16:07 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=haHowDRp; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:47502 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ml83q-0002LH-PG for patch@linaro.org; Thu, 11 Nov 2021 06:16:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51528) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ml7v6-00050w-Dv for qemu-devel@nongnu.org; Thu, 11 Nov 2021 06:07:04 -0500 Received: from [2a00:1450:4864:20::430] (port=35536 helo=mail-wr1-x430.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ml7v4-0001jU-Rf for qemu-devel@nongnu.org; Thu, 11 Nov 2021 06:07:04 -0500 Received: by mail-wr1-x430.google.com with SMTP id i5so9184246wrb.2 for ; Thu, 11 Nov 2021 03:07:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bh9kIk+bt83GJ1fKJT1mekYlH7elEbiEfE8/vcn0SLk=; b=haHowDRp7jRrau8od0cTGi7Zxo9JjrtoQyrGAhKr0lKsHF9Gw2vcheNXuJJ5p0cixU PFL2qywGltAlQtt+OLBY+Cb+I26RIH9KwluwLKMyvzir0AkminSeNPDjl9Iw9CQCLHfa JYpEx/zIjM6g9Dd+6slJooyqrgYVN3LeQ5NMO0nGr244rAy6ntk55Ik8M9FN5y1ZCmJg oTCiUiY9HTedrGFnOU+b8z9nII/PTyQ1nbMuOGabrz15aC2LfKlUJiCJ+hVEa2gqFLHg QQQYrF3WEd6ygfu5j9S1rw2+2fW2+iYGim4OVGtdSRaXFv7ZzYktXlirCgE3Dwqo6kOC uHXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bh9kIk+bt83GJ1fKJT1mekYlH7elEbiEfE8/vcn0SLk=; b=DTdgk5e8OF8qfWd6KmNBnaSaLyDSkfEra4ybM7Gcq1/f3cYmPquYXZaaNkXRdHLkCt u7fsc9AUnfRXcaJ5OXVh1A/MRD7m1arWMcgPayyuGiBzDjFoQzZFlRlX7F7N1FQVmOfr qwWxGhZfWmGamI6HlK94RZ06uyAdVTeyAodFa0r9+sSBmb+AD46q4rqd/JsItoNGVW61 yOrcppq+7He107FIFUsvsQ9Ql3mibBk3BojmvKdnvFcS21a0NVuUZk51kSp+DbxJyPux 3PkyzsIppaqy0UZeVfbYMKspX0/pVCKA9/MH7sIQ/DSNEaeyiMUEze5ASJu4PNZsjzqD Kipg== X-Gm-Message-State: AOAM533qWZ1vhVH5Baj0XHG1IZVVI2zoaCEHMkMNGZYKfuWKE85ZsVbK KXhI8Z90I3pMEDsUlny5jAU6cnPb/hML0Pew9pc= X-Received: by 2002:adf:ee04:: with SMTP id y4mr7732908wrn.0.1636628821389; Thu, 11 Nov 2021 03:07:01 -0800 (PST) Received: from localhost.localdomain (10.red-95-125-227.dynamicip.rima-tde.net. [95.125.227.10]) by smtp.gmail.com with ESMTPSA id j8sm2536684wrh.16.2021.11.11.03.07.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Nov 2021 03:07:00 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 2/4] tcg: Remove TCI experimental status Date: Thu, 11 Nov 2021 12:06:54 +0100 Message-Id: <20211111110656.237727-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211111110656.237727-1-richard.henderson@linaro.org> References: <20211111110656.237727-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::430 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=richard.henderson@linaro.org; helo=mail-wr1-x430.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé The following commits (released in v6.0.0) made raised the quality of the TCI backend to the other TCG architectures, thus is is not considerated experimental anymore: - c6fbea47664..2f74f45e32b - dc09f047edd..9e9acb7b348 - b6139eb0578..2fc6f16ca5e - dbcbda2cd84..5e8892db93f Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211106111457.517546-1-f4bug@amsat.org> Signed-off-by: Richard Henderson --- docs/about/build-platforms.rst | 10 ++++++---- meson.build | 4 ++-- meson_options.txt | 2 +- scripts/meson-buildoptions.sh | 3 +-- 4 files changed, 10 insertions(+), 9 deletions(-) diff --git a/docs/about/build-platforms.rst b/docs/about/build-platforms.rst index bcb1549721..c29a4b8fe6 100644 --- a/docs/about/build-platforms.rst +++ b/docs/about/build-platforms.rst @@ -54,10 +54,12 @@ Those hosts are officially supported, with various accelerators: * - x86 - hax, hvf (64 bit only), kvm, nvmm, tcg, whpx (64 bit only), xen -Other host architectures are not supported. It is possible to build QEMU on an -unsupported host architecture using the configure ``--enable-tcg-interpreter`` -option to enable the experimental TCI support, but note that this is very slow -and is not recommended. +Other host architectures are not supported. It is possible to build QEMU system +emulation on an unsupported host architecture using the configure +``--enable-tcg-interpreter`` option to enable the TCI support, but note that +this is very slow and is not recommended for normal use. QEMU user emulation +requires host-specific support for signal handling, therefore TCI won't help +on unsupported host architectures. Non-supported architectures may be removed in the future following the :ref:`deprecation process`. diff --git a/meson.build b/meson.build index 9702fdce6d..2ece4fe088 100644 --- a/meson.build +++ b/meson.build @@ -335,7 +335,7 @@ tcg_arch = config_host['ARCH'] if not get_option('tcg').disabled() if cpu not in supported_cpus if get_option('tcg_interpreter') - warning('Unsupported CPU @0@, will use TCG with TCI (experimental and slow)'.format(cpu)) + warning('Unsupported CPU @0@, will use TCG with TCI (slow)'.format(cpu)) else error('Unsupported CPU @0@, try --enable-tcg-interpreter'.format(cpu)) endif @@ -3290,7 +3290,7 @@ endif summary_info += {'TCG support': config_all.has_key('CONFIG_TCG')} if config_all.has_key('CONFIG_TCG') if get_option('tcg_interpreter') - summary_info += {'TCG backend': 'TCI (TCG with bytecode interpreter, experimental and slow)'} + summary_info += {'TCG backend': 'TCI (TCG with bytecode interpreter, slow)'} else summary_info += {'TCG backend': 'native (@0@)'.format(cpu)} endif diff --git a/meson_options.txt b/meson_options.txt index e740dce2a5..411952bc91 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -59,7 +59,7 @@ option('xen_pci_passthrough', type: 'feature', value: 'auto', option('tcg', type: 'feature', value: 'auto', description: 'TCG support') option('tcg_interpreter', type: 'boolean', value: false, - description: 'TCG with bytecode interpreter (experimental and slow)') + description: 'TCG with bytecode interpreter (slow)') option('cfi', type: 'boolean', value: 'false', description: 'Control-Flow Integrity (CFI)') option('cfi_debug', type: 'boolean', value: 'false', diff --git a/scripts/meson-buildoptions.sh b/scripts/meson-buildoptions.sh index 55b8a78560..45e1f2e20d 100644 --- a/scripts/meson-buildoptions.sh +++ b/scripts/meson-buildoptions.sh @@ -13,8 +13,7 @@ meson_options_help() { printf "%s\n" ' jemalloc/system/tcmalloc)' printf "%s\n" ' --enable-slirp[=CHOICE] Whether and how to find the slirp library' printf "%s\n" ' (choices: auto/disabled/enabled/internal/system)' - printf "%s\n" ' --enable-tcg-interpreter TCG with bytecode interpreter (experimental and' - printf "%s\n" ' slow)' + printf "%s\n" ' --enable-tcg-interpreter TCG with bytecode interpreter (slow)' printf "%s\n" ' --enable-trace-backends=CHOICE' printf "%s\n" ' Set available tracing backends [log] (choices:' printf "%s\n" ' dtrace/ftrace/log/nop/simple/syslog/ust)' From patchwork Thu Nov 11 11:06:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 519125 Delivered-To: patch@linaro.org Received: by 2002:ac0:c605:0:0:0:0:0 with SMTP id p5csp124766imj; Thu, 11 Nov 2021 03:21:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJxAIMVpZL9SESek8hFxfNMxXDnlYK4JZpEKwy7ZVqgOXEhUDpeevV3FaMaTthTIM367xnuq X-Received: by 2002:ad4:5cac:: with SMTP id q12mr5759576qvh.52.1636629680493; Thu, 11 Nov 2021 03:21:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1636629680; cv=none; d=google.com; s=arc-20160816; b=bIDaBLIlotUbkugQS2QZrIXOabP272LBNKYTs4qbNgShEhyp7r6dc3vC51iYD/mJFi GXB5EhXEcPuAiDynJq8n21iGJYDmHA5QUjYc1vi4dwXiaQrNZKtW3Qc6iw2efB+dC0Q6 75VIH3CKSEQifi/Rx5LGJilZhERYHth0GSKnJfD4dJA4jso4jnSdhIE24SQkZaS+LtJF 7fiODNHyHHZr9NVRU6wG8ptNlK9qwfW8xQhk1P+4lzTWmxJlU8Y9tGVLfm0qBLkdpdtk PmYKFG6tvFFazRhfBXuLK3hBNv+v1wn8LCyePHLC4g6xN7VmF/grWpFBKWWZnZe8jKHI Cy1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=n/Lg6tRRaf0tebXMyPh4xLh7Yicv5KIZg8mfFnBTuXA=; b=FNgBzB6hJJ0/JoLQBT9av12d9W/psA9U6vPSW2HVstzwmaBvlYT3dkwwKkqTZrRCtV QSTnJPwveoDzpk+FGx4lyl429+IdYaqdjq9zXiAd2y9iXFRWu+xI2lFmlcUwpd+AtbJt w/BCXk7KK1Rca0h7K8jFJoyrS73sxd8o10VOEEq75NlKx9a/xe/fAMaaZ+vgJjWXqheU DElQAw4Iip4gYXjS7uMzouE/c07qDM3xBiRoVz5jPjVz8q2Ra0ksIncAiWi2blQtqv34 pjU0WMhPspCvflPXd8xJrLkWbxUxVXT2oviShaXvOnRQXdnMveSQZDZWblFoCxTh24mb VTRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Z8+vuNkQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id jm13si3811075qvb.18.2021.11.11.03.21.20 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 11 Nov 2021 03:21:20 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Z8+vuNkQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:58752 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ml88u-0001dv-0F for patch@linaro.org; Thu, 11 Nov 2021 06:21:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51550) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ml7v7-00055U-Ln for qemu-devel@nongnu.org; Thu, 11 Nov 2021 06:07:05 -0500 Received: from [2a00:1450:4864:20::42f] (port=37576 helo=mail-wr1-x42f.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ml7v6-0001jz-0S for qemu-devel@nongnu.org; Thu, 11 Nov 2021 06:07:05 -0500 Received: by mail-wr1-x42f.google.com with SMTP id b12so9159692wrh.4 for ; Thu, 11 Nov 2021 03:07:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=n/Lg6tRRaf0tebXMyPh4xLh7Yicv5KIZg8mfFnBTuXA=; b=Z8+vuNkQAYjTxmQ52CYnP07l42a1u4YnAPm9TyxAHUGrLUihx/MLWIXCtE33elYWcP s7SS66YTB1Ekd+Td3gBYSz+F+4TSi2ba5JzJHFJNnmpvzsNGQu9xrusgrMYyRDO/y7f5 8Y90PVRKgc4M1xBAGgYrk+sqemjsMZ9QjqFe0dTIThBm7Q3IwEKXJdwqtUW30GP2n2R8 Te7edOEj3eKo4ijZ/mQv1EbfOwYeX8YHu7v1lKzEYAn+SEYsfgy6AfSEblS075O2Ba7i 11RaTtswMVoER1DvI0YuBgJH9rBdJ1TYilVugEXUrtBVC4wX//1InbhkIcZn/DFO/zUo tmrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=n/Lg6tRRaf0tebXMyPh4xLh7Yicv5KIZg8mfFnBTuXA=; b=utmZ945pgght6yqoziKorDN1kExCKGCN7WN8GLEfQIrHS8/MSNLpFUaS2oYqK/hdCA kbOceDqOJ6UuOLBr+KF6aiU8mH8iO0u5nDyLDju9MABtBGpIQ9L+s0BypGACqSAMrZUV NBMYMVFpoUXgasWGMvGihwJwGwKhhzSSioiJZuCTxJIjRut5EWJ70pMKtOwyiz0qBVmD uhfZ3jQ6mYqtsi+loDVyQ52jLcuayFOJHX2mVLu04BC6I1IaXUKGQY6ywNKr8bfPmn+F HwI4v7NfgaPlF6CIqgtgVUjlwVUFaok56t74kuDOolC7dOKZfx0T5SyK0gRpmZF+YtLy S04w== X-Gm-Message-State: AOAM532yLHAUNGjjMe4ROSZAv4rt5+N/IgEV+pb8RoB7iSSmVVZXlmap FI/gRkBaJbEzkgySK5U03uUOiNnFnEj0BJjhOaw= X-Received: by 2002:adf:f0c8:: with SMTP id x8mr7522434wro.290.1636628822630; Thu, 11 Nov 2021 03:07:02 -0800 (PST) Received: from localhost.localdomain (10.red-95-125-227.dynamicip.rima-tde.net. [95.125.227.10]) by smtp.gmail.com with ESMTPSA id j8sm2536684wrh.16.2021.11.11.03.07.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Nov 2021 03:07:02 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 3/4] tcg: Document ctpop opcodes Date: Thu, 11 Nov 2021 12:06:55 +0100 Message-Id: <20211111110656.237727-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211111110656.237727-1-richard.henderson@linaro.org> References: <20211111110656.237727-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::42f (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=richard.henderson@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Fixes: a768e4e99247 Resolves: https://gitlab.com/qemu-project/qemu/-/issues/658 Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- tcg/README | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tcg/README b/tcg/README index c2e7762a37..bc15cc3b32 100644 --- a/tcg/README +++ b/tcg/README @@ -254,6 +254,12 @@ t0 = t1 ? clz(t1) : t2 t0 = t1 ? ctz(t1) : t2 +* ctpop_i32/i64 t0, t1 + +t0 = number of bits set in t1 +With "ctpop" short for "count population", matching +the function name used in include/qemu/host-utils.h. + ********* Shifts/Rotates * shl_i32/i64 t0, t1, t2 From patchwork Thu Nov 11 11:06:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 519126 Delivered-To: patch@linaro.org Received: by 2002:ac0:c605:0:0:0:0:0 with SMTP id p5csp126211imj; Thu, 11 Nov 2021 03:22:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJzQzHoLeHaplun0RBf9iajjhXSXDba5HNDe7Kvb0PRvFFGuTTJN1N5D+u6DLKJ1vEdXyIgN X-Received: by 2002:ab0:f2:: with SMTP id 105mr9162387uaj.125.1636629764300; Thu, 11 Nov 2021 03:22:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1636629764; cv=none; d=google.com; s=arc-20160816; b=hsp1K+sdw9dm/bHLUOa9883qemzmejfGQwDI4XJjLKo3biJ4eK50h/UeUk625MbmvC HFHcQ9qvyd+3O6Od5f8OEo6Zty/1Og8DLGBD8W/VUzac4q6e9uyaEdehYOzvVvtDUmdT DGpE57EUOroSdvcw/HNrn4FEHwbrrKtsPNeBTOg4u9uXhhzljxjhyU0VdQ/S2f6BBNbU qaeebTjH8JWsQZdRD5a0BZ5UODm9vqZCjQqa4Fm999+48EdAsvPQWVD4OM8+sUK8pl0F t27OjgoCbQyIhtYUve6v2It2lMyvUAO3c3fAoHHNojKhLNH+xYK3VjdAcyLoMa0OwjIT YP4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=J1v0TEt4nFAPDqyOkQCB7uRP6b4G3GMZ4DQtpMIJcMM=; b=iQ4toBuQU4R+jVBf/75fqNcg31sIxpb52mkVfzvNyAkBTOomQZrfZ15uXaC2aXUNcD GiNFUEAtQLBK7GL3v7LzGA+zVECy3gJcwYAidG870g04eBI1RYRFCHYsvW2gV4Rfk5Ur T6Vedg5GhXNyKmMR1m6DEjR7Cf65seg4YLrzg9PfAUXwS6p+uNzWSK35FY3cpu6tw/rF on4GZcAjvlpeLqUNv+sxpbA5/mj7iUac/aVIKVg30pWIHU6ox6JVrhsfN4y/tDAfTqL3 /bFmlKJ7/iXddUo7oItoPVODTywtPynNjW4YxM8R4Er3yR1oLjJde538SOU5ngjL6yhv 2/Tw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=WUNXmJeK; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ay32si4689692vkb.18.2021.11.11.03.22.44 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 11 Nov 2021 03:22:44 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=WUNXmJeK; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:33704 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ml8AF-0003or-NU for patch@linaro.org; Thu, 11 Nov 2021 06:22:43 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51570) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ml7vA-0005DY-G1 for qemu-devel@nongnu.org; Thu, 11 Nov 2021 06:07:08 -0500 Received: from [2a00:1450:4864:20::430] (port=34495 helo=mail-wr1-x430.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ml7v7-0001kH-VD for qemu-devel@nongnu.org; Thu, 11 Nov 2021 06:07:07 -0500 Received: by mail-wr1-x430.google.com with SMTP id d5so9169692wrc.1 for ; Thu, 11 Nov 2021 03:07:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=J1v0TEt4nFAPDqyOkQCB7uRP6b4G3GMZ4DQtpMIJcMM=; b=WUNXmJeK/GZTMCrNfFGMBbPqImbQuHgnuvORU6UpFVJbIU1sgQ6k7DzI0sNBJXAvDW xgGiJFXB1jSi84xEYqgNhfCkU54+rimozBcdeG5y+I6Xqcg2EdUg+RyGDiPp6PPM/MFN auY1IpGlW5QtfIsock4RA9YyJlzQvjZ5GaUT4aTrZR93WDaM6STsJQBTy1e3Qitozx3o Zht+7D2ZDBZNhqxeQk7jq826H4ME2H3Jzd2UXD3+1n+u3A9B1OEFdAb9Jy/J0blGG5A0 7Ufv1gsWMt97Lgaleg3NxYn/lqry9FY/L2cv3084lrgCBFzl2RJvwP54RyDypxZ0bTbu H+UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=J1v0TEt4nFAPDqyOkQCB7uRP6b4G3GMZ4DQtpMIJcMM=; b=mqCZY2VfNEyzw1/K1x1JGerVlUFkOeilN1Qm2FejUm/+sIEy5XIodFrLgHZ0uw8sns PhipmQIiCnqZAcqBFfgVVCbNdmtHT9okrcpvKV+b5Abtg7fW5JPW/MgGg+uNusjpnSYW 0m2Jw8t9BvNgh7VAW1ISV9ALrgO0yFJqQNnt+g4sxlGjET0lcmJlgtYTHxZ0fXR7jfRq l9L7bJsB0fdCcIARYim63ObqmyjqpMS+tV0bOqu1tPEA84PXP3ailO2GWrDyWGVODxvI LoiQavKPV/N0fD4K9qVw0B1WCIIcyO5qSC0k6QXUvwpEKhJXUz289ogMX7zHg8m76tW8 n/Og== X-Gm-Message-State: AOAM530vBiBw9yX8DnhkgVl3scJK86SFZmaPXg+P0N6AzeSJULHsC5T0 Q2lzHwYhbjWSfOPg1AcMiIEKxMBWBi5B9yxlpPU= X-Received: by 2002:a5d:4d81:: with SMTP id b1mr8111822wru.366.1636628824695; Thu, 11 Nov 2021 03:07:04 -0800 (PST) Received: from localhost.localdomain (10.red-95-125-227.dynamicip.rima-tde.net. [95.125.227.10]) by smtp.gmail.com with ESMTPSA id j8sm2536684wrh.16.2021.11.11.03.07.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Nov 2021 03:07:04 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 4/4] tcg/s390x: Fix tcg_out_vec_op argument type Date: Thu, 11 Nov 2021 12:06:56 +0100 Message-Id: <20211111110656.237727-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211111110656.237727-1-richard.henderson@linaro.org> References: <20211111110656.237727-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::430 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=richard.henderson@linaro.org; helo=mail-wr1-x430.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Miroslav Rezanina , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , David Hildenbrand Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Miroslav Rezanina Newly defined tcg_out_vec_op (34ef767609 tcg/s390x: Add host vector framework) for s390x uses pointer argument definition. This fails on gcc 11 as original declaration uses array argument: In file included from ../tcg/tcg.c:430: /builddir/build/BUILD/qemu-6.1.50/tcg/s390x/tcg-target.c.inc:2702:42: error: argument 5 of type 'const TCGArg *' {aka 'const long unsigned int *'} declared as a pointer [-Werror=array-parameter=] 2702 | const TCGArg *args, const int *const_args) | ~~~~~~~~~~~~~~^~~~ ../tcg/tcg.c:121:41: note: previously declared as an array 'const TCGArg[16]' {aka 'const long unsigned int[16]'} 121 | const TCGArg args[TCG_MAX_OP_ARGS], | ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~ In file included from ../tcg/tcg.c:430: /builddir/build/BUILD/qemu-6.1.50/tcg/s390x/tcg-target.c.inc:2702:59: error: argument 6 of type 'const int *' declared as a pointer [-Werror=array-parameter=] 2702 | const TCGArg *args, const int *const_args) | ~~~~~~~~~~~^~~~~~~~~~ ../tcg/tcg.c:122:38: note: previously declared as an array 'const int[16]' 122 | const int const_args[TCG_MAX_OP_ARGS]); | ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ Fixing argument type to pass build. Signed-off-by: Miroslav Rezanina Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Acked-by: David Hildenbrand Message-Id: <20211027085629.240704-1-mrezanin@redhat.com> Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target.c.inc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tcg/s390x/tcg-target.c.inc b/tcg/s390x/tcg-target.c.inc index 8938c446c8..57e803e339 100644 --- a/tcg/s390x/tcg-target.c.inc +++ b/tcg/s390x/tcg-target.c.inc @@ -2699,7 +2699,8 @@ static void tcg_out_dupi_vec(TCGContext *s, TCGType type, unsigned vece, static void tcg_out_vec_op(TCGContext *s, TCGOpcode opc, unsigned vecl, unsigned vece, - const TCGArg *args, const int *const_args) + const TCGArg args[TCG_MAX_OP_ARGS], + const int const_args[TCG_MAX_OP_ARGS]) { TCGType type = vecl + TCG_TYPE_V64; TCGArg a0 = args[0], a1 = args[1], a2 = args[2];