From patchwork Thu Nov 25 01:43:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sherry Sun X-Patchwork-Id: 517567 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A72FC433EF for ; Thu, 25 Nov 2021 01:48:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243640AbhKYBvq (ORCPT ); Wed, 24 Nov 2021 20:51:46 -0500 Received: from mail-am6eur05on2046.outbound.protection.outlook.com ([40.107.22.46]:64161 "EHLO EUR05-AM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S234909AbhKYBtq (ORCPT ); Wed, 24 Nov 2021 20:49:46 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b6Z1mAGJnCtCL5N0hCN/rk9mPgkoR1s2h3tfX3O2kVXGXFGdcBGwlbYeWowTpILq13NPnZGMoYn68akLdaAXvvw4kjdlI8xU1jyOTabXMnAu0subHpyXrWGbd9K22b2AvqsKKo/gMhQWTR1gMM2QwiCNifcaN9cMMdWyPKNPuuz4aLuCgkzSGP0f7k1QoqSo5OFEMfxnrAmuSxyFZIZGIFfW/rO3MBbpayENxHQmaoh2Bjop9DY/UbabWDKZ1//FDeOX8jiVyWM7xcbhskyXOXD2Xns6ldGkscT+XAM+TPp54YNht8Sz3vV4EliAafLKH6mhvXteyGL43p0DRUpZYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wEalQ5A7RDT4gjet5e16eHxrhOTAbXaZWZ7XLFriI4g=; b=m959e1mTzX114YJuOrf1Y7KKBvr0Tfv17NhwCVVnsI+MkCpcP3dA2doS9Rip2ZDQJrXaLbUekZ+S4mmWsAFQbStWdIRKNAnfVqALbK2LN6HXi4teJ+PwTy2DXcneGB/54dOScldgL6IXUpbINpVz8jJJep2H41EoZYf4d5kvNuCLskwfjSAYMnVlw0uHV+1CWb06PmwrNuaj/UgwtYa69pomqVHDJzkNfhvBDHAF2BuzOSNmc2JjWG3jZKNvtC1YpDHX8dLDAzWDvDaF1Ismuy7ijmmqQpfUGLcVAAxPbB2cPfIfABC0YeARj9flpGx3ZnGl+WCOAXdd+60p3Th+EQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wEalQ5A7RDT4gjet5e16eHxrhOTAbXaZWZ7XLFriI4g=; b=ceKs5unZCcO0/GghIP5v9FYYc0NAru1ywVs9WQsMEJ3mF1F+zq1WEortdoGoN7tS9M6uJGitJ39oN6U8C4J9/xf0I9DFKa3pdrCxLPKTGj85eExlZApMGhyUMrRSLrvp4I7B3wDh+WnSLydGlslkbxFeUqBlknGp01QvnhO9naU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DB9PR04MB8411.eurprd04.prod.outlook.com (2603:10a6:10:24c::9) by DBBPR04MB7739.eurprd04.prod.outlook.com (2603:10a6:10:1eb::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22; Thu, 25 Nov 2021 01:46:33 +0000 Received: from DB9PR04MB8411.eurprd04.prod.outlook.com ([fe80::199a:adba:b7de:cf8d]) by DB9PR04MB8411.eurprd04.prod.outlook.com ([fe80::199a:adba:b7de:cf8d%5]) with mapi id 15.20.4713.027; Thu, 25 Nov 2021 01:46:33 +0000 From: Sherry Sun To: gregkh@linuxfoundation.org, jirislaby@kernel.org, u.kleine-koenig@pengutronix.de Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com Subject: [PATCH V3] tty: serial: imx: clear the RTSD status before enable the RTSD irq Date: Thu, 25 Nov 2021 09:43:06 +0800 Message-Id: <20211125014306.4432-1-sherry.sun@nxp.com> X-Mailer: git-send-email 2.17.1 X-ClientProxiedBy: SI2PR06CA0015.apcprd06.prod.outlook.com (2603:1096:4:186::7) To DB9PR04MB8411.eurprd04.prod.outlook.com (2603:10a6:10:24c::9) MIME-Version: 1.0 Received: from localhost.localdomain (119.31.174.71) by SI2PR06CA0015.apcprd06.prod.outlook.com (2603:1096:4:186::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22 via Frontend Transport; Thu, 25 Nov 2021 01:46:31 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5c5db142-f312-41b6-7318-08d9afb568dd X-MS-TrafficTypeDiagnostic: DBBPR04MB7739: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:513; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QF+TmjcGmXZ43/U/cyOTnfbZviG6Tki80sn0kg5UnLet6mPGjo8YF7NqAbTwZXMov3Rta78ggxoH3K3EN6zG7jwVadIPcYWVMW1kj1SEYPUbSvCJ7MCWOE81rreB3G4BLwSRO+utxwAUbxqLzPZlwVjwueLh7jL+K4AqPmgUsn/xWYCtuXrIPx0m0jM097HNjDjFzsdaI4G57s0VCWa/Iom5TXkTAVQi6Nru7EzDBi3PkMVgx1T09bta2t7zUP31Xu/TqiFZ1lcAMuU3exh16AFErMQ22lH7JfLTWBuUCX8ywK3I6hFKG2l8CGg9mrOsNWDnLChovv6iN16V+9bZG2yvDcKYQUTBqmZWRgYPShE0isTzBdHZunJ27j74Wxl7B0Uu9QW8dFc8HJMampMaOE88VZUDYmE3x1K4QeX4woQOuhs0PWMgJbrDLfAvlDkzXrCSsZOBaIykDbJbuQznrqDsBQD8qDRYplNAE/zJwWgx2VYuY6aXLi/KZYLDAfRe5rrbnVNZ2OlPAdgeQwmCXZqJq1kKX6OAVs3Iqael9nXXPjDfnRVkH8yOkTcvsrsTBTFQ5RsOqt7M/8gvVw70p5rdkhIoW9GSBNrUwLCRcdySiX7L2s9LekU5dGs0lzS7LPrLiRNkPHb9OvjnfaYyzcVYDzQZc/N33zS8dgxDpb0jOZ8hAmkui5+SNS0aCHIxSTFvSOzPah7rORjlvx4hTg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9PR04MB8411.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(38350700002)(36756003)(38100700002)(66476007)(66556008)(186003)(66946007)(66574015)(4326008)(44832011)(956004)(83380400001)(8936002)(6486002)(6666004)(2616005)(316002)(5660300002)(6506007)(52116002)(26005)(8676002)(86362001)(1076003)(2906002)(6512007)(508600001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?AnP+Bd+tnpZT5NVSy6QSSSOtv45G?= =?utf-8?q?BflDenm8Bgxpo1iH01zAB2MQyc297UneN9ISNJjHFNe3QuSxrQQ20VNTVRakQfMZQ?= =?utf-8?q?QQXs/O6qOGyYTGsvDW6klydQWs5/obimEFRTqJK6VVa/TiujOhMFqqIGqIAE8i9gO?= =?utf-8?q?sZHl7+b0HaW+YcoauH9Owd0ahmml1RF8zOGT5YdD1WX9AkbZMZhR1fPpTcq7vHoAu?= =?utf-8?q?79agljQp0IMTkXWR0GaXGHOma5nRrm9S9Us8roBnZEYb9IEJCkAZri9fpAF4vavAr?= =?utf-8?q?GHrfExzGWOkFy7LvDSVzwCa9DAstMUjBBBt20qLlZPDtyoD/pnZrPa6im/pgZ1pHF?= =?utf-8?q?k7yI0iYXoWHfyx2I0qg7OiqYAO71jQ4SUrqVzUyUsfrTvCUu9fiHShfhF2R3NLScB?= =?utf-8?q?8YDtLpMbbIbQMRmklN0onUb8002k6MJMZl0rrnvc6B2WRsqYyH18Z+AASMwYEZlZn?= =?utf-8?q?V3sbiWMy/4ByPlQcS/Z0PgG0rUIOxG1fNyuYbJpwCaxab5IyBlbamIXTGTCXC7qGA?= =?utf-8?q?2e3kFiboKJnLo6/hQaOA1TVT8quedPFaaeQBdu7X1U6sRT+ZUaf9Qe5NKOfADYtFd?= =?utf-8?q?eYDDIg4uA9S0KRC2xUHVz0PafftvWCBW66qho5u9WakMbL5jm5WjxuRI9+I1e56rH?= =?utf-8?q?WkJkoXObERMtxM9ZyTbPWu5Z+iyRx29BPZYn8QA+c4N8m7kMlZJ2goVxJ43Cf35oB?= =?utf-8?q?edCHEchPcy6uMNHNTCPOtMbtGRJLEaABaeazG6bltgTpN+dBM5ECgpD4H0Ko1/jgK?= =?utf-8?q?+/2DTFmKfpVHM4/ENfIkZXdFQJTItnoo6GVGTgEUSxErsI0FstI0bDElQsYWITZWk?= =?utf-8?q?zk96X8rij6c6+QbL0RswlSco8yR74ydRuzCG6Wb8UVbSgFHKXPKOh0o4VdtRPpe/p?= =?utf-8?q?vzpYTJGpItrOBUU9+fMw/r2uP+cbwwiGRGtcUtnP7UKfLyEnQHjnIBAPD7qAybgsH?= =?utf-8?q?dOD+8Ww2IZc8PmQ5h+iHHLJGH8uL+WoJG9i5RadEUPUQkJiZooDSKfvcPYZb3hjZ8?= =?utf-8?q?QjLHCMc/G4m9j3Pw62GZ59pNoWYmUL8mFKDtYU+MmIHwRmr4iLdsCn16VTpzpYER5?= =?utf-8?q?emYHOW+L0Fvv1Gpt6YlHqKy+Ju/r5/j/DKiTpCIyWFJa/o7DEbIVTI+qURbhtA5e8?= =?utf-8?q?XtC18TP0yPmEnluP9uod4fJJzEYSFao1PQpQO9MKqTamd2Q2bV7Sq7oFZhYWS6CK6?= =?utf-8?q?xM6OvRth33/O6DwWZVm0WXNm6JzlRfn4mmKFjztnaDrz6UjTW+UsqoMMBpXjtoIUe?= =?utf-8?q?+AeHdDemBfq0Zii4YtftmAp5cqw1vLi6qxjiYp6pWhnXt65yRB3Wr5BGBRX2UEJtg?= =?utf-8?q?UH2YEUjW7rpeFRIl19rFnOTNx41QC6gXYj+d4TqKXgMuRoO+AuSJTOf2h9fmxfWet?= =?utf-8?q?oSTX1tfm3AWLJUeK70BlnRqSz/A2sSo6it0N06g5A2K37XltK0MJiPC4PQnKrMARP?= =?utf-8?q?McPlZWJMudVKpEkD3k9AKKwrb+r5CYDO17zowhmpTdeH/LnJMMpy0FhIr9ro8ZIaL?= =?utf-8?q?qMzqoGWCXv3ZZ7h9TBRCCGG+XklJ1xJ3j+Sfre5ptHYQi+kEpiQxMD4=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c5db142-f312-41b6-7318-08d9afb568dd X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB8411.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2021 01:46:33.6952 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UNLdP4s+xxItYbhWESUVOdjMoz+Xm9BuDzjqYkMieyMkiaKujiJ77m4Pza4koi7VwVhuYY2uGQiXLp1r3A2ObQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7739 Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org From: Fugang Duan Clear RTSD status before enabling the irq event for RTSD in imx_uart_enable_wakeup function. Since RTSD can be set as the wakeup source, this can avoid any risk of false triggering of a wake-up interrupts. Signed-off-by: Fugang Duan Signed-off-by: Sherry Sun Acked-by: Uwe Kleine-König --- changes in V3: - Add the Acked-by tag. changes in V2: - Change the subject and the commit message as suggested by Uwe. --- drivers/tty/serial/imx.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 90f82e6c54e4..fb75e3e0d828 100644 --- a/drivers/tty/serial/imx.c +++ b/drivers/tty/serial/imx.c @@ -2482,10 +2482,12 @@ static void imx_uart_enable_wakeup(struct imx_port *sport, bool on) if (sport->have_rtscts) { u32 ucr1 = imx_uart_readl(sport, UCR1); - if (on) + if (on) { + imx_uart_writel(sport, USR1_RTSD, USR1); ucr1 |= UCR1_RTSDEN; - else + } else { ucr1 &= ~UCR1_RTSDEN; + } imx_uart_writel(sport, ucr1, UCR1); } }