From patchwork Mon Nov 29 19:45:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 517510 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8A0BC433EF for ; Mon, 29 Nov 2021 19:48:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242534AbhK2Tvh (ORCPT ); Mon, 29 Nov 2021 14:51:37 -0500 Received: from mail-pj1-f49.google.com ([209.85.216.49]:53975 "EHLO mail-pj1-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229596AbhK2Ttg (ORCPT ); Mon, 29 Nov 2021 14:49:36 -0500 Received: by mail-pj1-f49.google.com with SMTP id iq11so13515129pjb.3 for ; Mon, 29 Nov 2021 11:46:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=spXTifj5M9HBJDRM6qGu3Iug+LkX07oPsHn9kJIHw6o=; b=zHZLgB8XOHZG5owRNh3wX3pOcqS2h3FLYN0/NSPB/3mNcE7NRd+g+lAhYkeap+4HtB Inm4pcbcKI4h9wOu/5g411XIyLcApnsRv57S5n3cBYt3St3F7lMQLEI3llxPS4TSKaHz mSpvKIrpFwWQtQYvSFvRFuuoRY/zVaXfBRjdFHqE23eLT6JFnsUAQQtzPA9s1RPyNJM3 ilfKRDeprn+44twEw2hw0nfLWL3SyY4/5d+YUc29RQQ0m12YWIo4UJH8CRRz91asLR1L wnRJoxWWglGqlJJwXeWSqArb2Z4aKHS72Bwki0ZrC5IRFTdhvPK/EQDVbm/MOC/FhQ98 Mxfw== X-Gm-Message-State: AOAM530x/Xjot+8yfwDvzN+6j+DGb8c65qPX0Qx9/XVpoHcBZv+Nnibc JH+P6AMGMpHOE2tcN6H3Alk= X-Google-Smtp-Source: ABdhPJwLAny2vwQW4JSN70pGA3qIN6iTHejy9yg3BKJNiTjWV9aerUq9Om8nlsZPgdyKsf0u3qpofA== X-Received: by 2002:a17:902:f693:b0:142:9ec:c2e1 with SMTP id l19-20020a170902f69300b0014209ecc2e1mr61943569plg.34.1638215177950; Mon, 29 Nov 2021 11:46:17 -0800 (PST) Received: from bvanassche-linux.mtv.corp.google.com ([2620:15c:211:201:a4a0:8cb5:fff:67db]) by smtp.gmail.com with ESMTPSA id ns21sm141715pjb.37.2021.11.29.11.46.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Nov 2021 11:46:17 -0800 (PST) From: Bart Van Assche To: "Martin K . Petersen" Cc: Jaegeuk Kim , linux-scsi@vger.kernel.org, Bart Van Assche , Stephen Rothwell , "James E.J. Bottomley" Subject: [PATCH v2 01/12] scsi: core: Suppress a kernel-doc warning Date: Mon, 29 Nov 2021 11:45:58 -0800 Message-Id: <20211129194609.3466071-2-bvanassche@acm.org> X-Mailer: git-send-email 2.34.0.rc2.393.gf8c9666880-goog In-Reply-To: <20211129194609.3466071-1-bvanassche@acm.org> References: <20211129194609.3466071-1-bvanassche@acm.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Suppress the following kernel-doc warning: drivers/scsi/scsi_scan.c:129: warning: Function parameter or member 'dev' not described in 'scsi_enable_async_suspend' Fixes: a19a93e4c6a9 ("scsi: core: pm: Rely on the device driver core for async power management") Reported-by: Stephen Rothwell Signed-off-by: Bart Van Assche --- drivers/scsi/scsi_scan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index 23e1c0acdeae..2f80509fa036 100644 --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c @@ -122,7 +122,7 @@ struct async_scan_data { struct completion prev_finished; }; -/** +/* * scsi_enable_async_suspend - Enable async suspend and resume */ void scsi_enable_async_suspend(struct device *dev) From patchwork Mon Nov 29 19:45:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 518650 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87EA8C433F5 for ; Mon, 29 Nov 2021 19:48:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242621AbhK2Tvh (ORCPT ); Mon, 29 Nov 2021 14:51:37 -0500 Received: from mail-pg1-f169.google.com ([209.85.215.169]:36740 "EHLO mail-pg1-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378207AbhK2Tth (ORCPT ); Mon, 29 Nov 2021 14:49:37 -0500 Received: by mail-pg1-f169.google.com with SMTP id 137so10123550pgg.3 for ; Mon, 29 Nov 2021 11:46:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Eo/7UnI+AwibqzUbFvdfpnOu414e562XZSOE4FVSaIA=; b=pSA0GYAyklnofBCZTUqOTWw9ZSNdiSyVLLv+iQp+Hx/ifPO9kkjUwYRHHrZ0ZbktsP fcotbHycI4b6YEkdChyeBpy2C933+qqk9nOCnJjJHcCqbiWhms2a4IkF98nulxyvb8Cw 5gtlAoAS1mdweOnPSnYR8fAIYh1ZoTRHQn/HDN0fMUxoi4ciQvU+clYcTr550zokWQWh OFx3zcXpTCepnwBvWdKjOC+1rpXBbd1TczkqTEaTFMVXdeq3bnq1agkyZK+39EH3A3fl 2JoP6tdUXC12k5g2kJqtFRiI8UVyjc5yk2n6PV7OG1P0om7bxOu1nREy4eol6hiRTqeB CGBw== X-Gm-Message-State: AOAM5314YOO2RMORha573XFR6e44ocyKiVAROlRSH2E53FGdTv4AR3ES qjEWAyOUZhmTPlur885bh6A= X-Google-Smtp-Source: ABdhPJxZVwsnzkABacDf6oJS45PyZeBmIejh5tRrRzvKEqkqPEvU9u/lmlSbUpg0vXae/6G88fT5KA== X-Received: by 2002:a05:6a00:a14:b0:4a0:945:16fa with SMTP id p20-20020a056a000a1400b004a0094516famr41405242pfh.9.1638215179276; Mon, 29 Nov 2021 11:46:19 -0800 (PST) Received: from bvanassche-linux.mtv.corp.google.com ([2620:15c:211:201:a4a0:8cb5:fff:67db]) by smtp.gmail.com with ESMTPSA id ns21sm141715pjb.37.2021.11.29.11.46.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Nov 2021 11:46:18 -0800 (PST) From: Bart Van Assche To: "Martin K . Petersen" Cc: Jaegeuk Kim , linux-scsi@vger.kernel.org, Bart Van Assche , kernel test robot , "James E.J. Bottomley" Subject: [PATCH v2 02/12] scsi: core: Declare 'scsi_scan_type' static Date: Mon, 29 Nov 2021 11:45:59 -0800 Message-Id: <20211129194609.3466071-3-bvanassche@acm.org> X-Mailer: git-send-email 2.34.0.rc2.393.gf8c9666880-goog In-Reply-To: <20211129194609.3466071-1-bvanassche@acm.org> References: <20211129194609.3466071-1-bvanassche@acm.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org 'scsi_scan_type' is only used in one source file. Hence declare it static. Fixes: a19a93e4c6a9 ("scsi: core: pm: Rely on the device driver core for async power management") Reported-by: kernel test robot Signed-off-by: Bart Van Assche --- drivers/scsi/scsi_scan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index 2f80509fa036..3520b9384428 100644 --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c @@ -97,7 +97,7 @@ MODULE_PARM_DESC(max_luns, #define SCSI_SCAN_TYPE_DEFAULT "sync" #endif -char scsi_scan_type[7] = SCSI_SCAN_TYPE_DEFAULT; +static char scsi_scan_type[7] = SCSI_SCAN_TYPE_DEFAULT; module_param_string(scan, scsi_scan_type, sizeof(scsi_scan_type), S_IRUGO|S_IWUSR); From patchwork Mon Nov 29 19:46:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 517509 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA4B0C433F5 for ; Mon, 29 Nov 2021 19:48:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348487AbhK2Tvj (ORCPT ); Mon, 29 Nov 2021 14:51:39 -0500 Received: from mail-pl1-f177.google.com ([209.85.214.177]:34782 "EHLO mail-pl1-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378405AbhK2Tti (ORCPT ); Mon, 29 Nov 2021 14:49:38 -0500 Received: by mail-pl1-f177.google.com with SMTP id y8so13041764plg.1 for ; Mon, 29 Nov 2021 11:46:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2eowHEMEaomOtvfvRCh+rFzyDDZg9uyicwuaqpBFZK8=; b=6gXU/Qj3ClbEn1IKlaOxv2753laqJj4JzWAxMLGfOrt6v8+lKa6zufOX9EuD4xe4Gw bakXGyMa934veQJIyjdolqwR3kxIK0CWl+/dgssMsif3Gq2OHZu3ZNNcDf0MaSECHrZP vFDlmWCY2GaXCofto3OCS8C4D+b1cNWCcyVQQylgmbpt4fBDVmQ2OdidopR5df64Vrln K1XcqPu4PDlTUh1aAsIEdQBgHRz1nyE6MGbJKKYNANiuZYHijD1ykTgJ1V75/XQsIKAJ VZhx3QiuEBNlM+2sv3uc4hCv7wttUmWB6+17aNHfB3batI6AAkUq7cpm9eU2LYeKkYd2 TJHg== X-Gm-Message-State: AOAM531dh+6pcHRPSEvvQLFkwOPaaakQVd6lXqdKSMLhqFRZWC06gY0K GPHygDDcKxHhamTUm/FUrHs= X-Google-Smtp-Source: ABdhPJxw3xPG1FueKkeSkhTjcDmXxt+uePRYgZTcKBAR61sQVfqvKKmuP03XN9jc7b2ckp99QeWxEA== X-Received: by 2002:a17:90b:3e85:: with SMTP id rj5mr194209pjb.172.1638215180771; Mon, 29 Nov 2021 11:46:20 -0800 (PST) Received: from bvanassche-linux.mtv.corp.google.com ([2620:15c:211:201:a4a0:8cb5:fff:67db]) by smtp.gmail.com with ESMTPSA id ns21sm141715pjb.37.2021.11.29.11.46.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Nov 2021 11:46:20 -0800 (PST) From: Bart Van Assche To: "Martin K . Petersen" Cc: Jaegeuk Kim , linux-scsi@vger.kernel.org, Bart Van Assche , "James E.J. Bottomley" , Paolo Bonzini , Hannes Reinecke , Ming Lei Subject: [PATCH v2 03/12] scsi: core: Show SCMD_LAST in text form Date: Mon, 29 Nov 2021 11:46:00 -0800 Message-Id: <20211129194609.3466071-4-bvanassche@acm.org> X-Mailer: git-send-email 2.34.0.rc2.393.gf8c9666880-goog In-Reply-To: <20211129194609.3466071-1-bvanassche@acm.org> References: <20211129194609.3466071-1-bvanassche@acm.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org The SCSI debugfs code supports showing information about pending commands, including translating SCSI command flags from numeric into text format. Also convert the SCMD_LAST flag from numeric into text form. Fixes: 8930a6c20791 ("scsi: core: add support for request batching") Signed-off-by: Bart Van Assche --- drivers/scsi/scsi_debugfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/scsi_debugfs.c b/drivers/scsi/scsi_debugfs.c index d9109771f274..db8517f1a485 100644 --- a/drivers/scsi/scsi_debugfs.c +++ b/drivers/scsi/scsi_debugfs.c @@ -9,6 +9,7 @@ static const char *const scsi_cmd_flags[] = { SCSI_CMD_FLAG_NAME(TAGGED), SCSI_CMD_FLAG_NAME(INITIALIZED), + SCSI_CMD_FLAG_NAME(LAST), }; #undef SCSI_CMD_FLAG_NAME From patchwork Mon Nov 29 19:46:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 518649 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BAF2C4332F for ; Mon, 29 Nov 2021 19:48:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351964AbhK2Tvl (ORCPT ); Mon, 29 Nov 2021 14:51:41 -0500 Received: from mail-pj1-f49.google.com ([209.85.216.49]:37774 "EHLO mail-pj1-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229697AbhK2Ttk (ORCPT ); Mon, 29 Nov 2021 14:49:40 -0500 Received: by mail-pj1-f49.google.com with SMTP id cq22-20020a17090af99600b001a9550a17a5so16429694pjb.2 for ; Mon, 29 Nov 2021 11:46:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/rt9aYXGuG2HyypM9O0RfnNXuMejollxflJLD+tOaqk=; b=6Vl4gplWIdYDeLYw9RlSqUETE6gA50y0jzkRS5Yzu4dcYqM8kAzfEs82cs0q2X6kMj 0Tt65J9jKtLINkenLmWmwMOlPMrwGpCGXMm+/BPoQLhq7zqD1qVrc8CmUKPfyWd+IIDR h6ajY/jSCSVhiTYk1xxONZlnz2puxn42WuOhXtQM97s4mKTGyFQZ1Q3Tf38nasb1n8SC 9IH/hRCoc4tyfz9USPCwZrYNxErRC+dw7oZr+FjlVhEKFHBmADjO4coLe1BZ21Bu53nY hViIZJnPp9TrF26H5Gs/jC3jNIUQvVix+GMTeUuZo82tWp+oVXqk3ylFeGHPsd7K/I6+ JCXg== X-Gm-Message-State: AOAM5327HzscOcii6ZTZDJTctLl/YUrAS4OEJaSRu5Pw95fMydR9verc BzMhoU9Pp4mABCaRpfqFd8o= X-Google-Smtp-Source: ABdhPJzNXS1Bkrmh09xiUwZ72fvh+TB+sGhaX+mY+cLMq8oqO40Pn21iZ+hDfo3XyWaGv/AcSUJQ1w== X-Received: by 2002:a17:90a:4414:: with SMTP id s20mr200307pjg.132.1638215182010; Mon, 29 Nov 2021 11:46:22 -0800 (PST) Received: from bvanassche-linux.mtv.corp.google.com ([2620:15c:211:201:a4a0:8cb5:fff:67db]) by smtp.gmail.com with ESMTPSA id ns21sm141715pjb.37.2021.11.29.11.46.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Nov 2021 11:46:21 -0800 (PST) From: Bart Van Assche To: "Martin K . Petersen" Cc: Jaegeuk Kim , linux-scsi@vger.kernel.org, Bart Van Assche , "James E.J. Bottomley" Subject: [PATCH v2 04/12] scsi: a100u2w: Fix a kernel-doc warning Date: Mon, 29 Nov 2021 11:46:01 -0800 Message-Id: <20211129194609.3466071-5-bvanassche@acm.org> X-Mailer: git-send-email 2.34.0.rc2.393.gf8c9666880-goog In-Reply-To: <20211129194609.3466071-1-bvanassche@acm.org> References: <20211129194609.3466071-1-bvanassche@acm.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fix the following kernel-doc warning: drivers/scsi/a100u2w.c:915: warning: Excess function parameter 'done' description in 'inia100_queue_lck' Fixes: af049dfd0b10 ("scsi: core: Remove the 'done' argument from SCSI queuecommand_lck functions") Signed-off-by: Bart Van Assche --- drivers/scsi/a100u2w.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/a100u2w.c b/drivers/scsi/a100u2w.c index 564ade03b530..d02eb5b213d0 100644 --- a/drivers/scsi/a100u2w.c +++ b/drivers/scsi/a100u2w.c @@ -904,13 +904,11 @@ static int inia100_build_scb(struct orc_host * host, struct orc_scb * scb, struc /** * inia100_queue_lck - queue command with host * @cmd: Command block - * @done: Completion function * * Called by the mid layer to queue a command. Process the command * block, build the host specific scb structures and if there is room * queue the command down to the controller */ - static int inia100_queue_lck(struct scsi_cmnd *cmd) { struct orc_scb *scb; From patchwork Mon Nov 29 19:46:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 517508 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D8E8C433EF for ; Mon, 29 Nov 2021 19:48:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352616AbhK2Tvm (ORCPT ); Mon, 29 Nov 2021 14:51:42 -0500 Received: from mail-pf1-f175.google.com ([209.85.210.175]:39588 "EHLO mail-pf1-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378641AbhK2Ttl (ORCPT ); Mon, 29 Nov 2021 14:49:41 -0500 Received: by mail-pf1-f175.google.com with SMTP id i12so18028998pfd.6 for ; Mon, 29 Nov 2021 11:46:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IXooOpVAgdHelMC36RQc8OYxf3STAnvIi8dYSh5phbg=; b=NQRVsIkwtD7dkiOQVbbWVG2OV1R7iTSLMZ3CyZSrrrLE9fum7OMbgA9vHjWBQK8GYV PUClqqOF0qT+/f1ywoUJM6N+FxldWp8+QD9y+AfnM9wvcAXa/h031VuMu62P05dej6UJ yz3dSaoS1uHtyN89TJ6OTd1LusOENOEaNDBN0WLhNXdR/9n1uAGnuLQRQ0DFfM7FuPd2 JJwkYsFBcTnGxPyX2oksPRJDg94dR2ixjDSM0s/L5IvHZ2GodJNJd45sB0aEZhLf4sKR wZ5kZL8Mv2/YZHf17Uuo1WLyLjEtAGqaUAHuXhd3Iq/ZXswwvvIVC/nK01ZOagiKN1eE 6lPg== X-Gm-Message-State: AOAM532s10GiRpwcDSyoXdf/ru5KSPbnMmebfcxrb6BE2M3QCfIJeRGE nG9lZLdzdyibYuRa6CIvOVw= X-Google-Smtp-Source: ABdhPJzn80bvEbHIdup8IZXKEBhknHlzcZf5RqDwGlWJrUVKD8sZlyp95swhhfyH0pSbJYb0eoeJSw== X-Received: by 2002:a65:6702:: with SMTP id u2mr36393185pgf.24.1638215183327; Mon, 29 Nov 2021 11:46:23 -0800 (PST) Received: from bvanassche-linux.mtv.corp.google.com ([2620:15c:211:201:a4a0:8cb5:fff:67db]) by smtp.gmail.com with ESMTPSA id ns21sm141715pjb.37.2021.11.29.11.46.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Nov 2021 11:46:22 -0800 (PST) From: Bart Van Assche To: "Martin K . Petersen" Cc: Jaegeuk Kim , linux-scsi@vger.kernel.org, Bart Van Assche , "James E.J. Bottomley" Subject: [PATCH v2 05/12] scsi: atp870u: Fix a kernel-doc warning Date: Mon, 29 Nov 2021 11:46:02 -0800 Message-Id: <20211129194609.3466071-6-bvanassche@acm.org> X-Mailer: git-send-email 2.34.0.rc2.393.gf8c9666880-goog In-Reply-To: <20211129194609.3466071-1-bvanassche@acm.org> References: <20211129194609.3466071-1-bvanassche@acm.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fix the following kernel-doc warning: drivers/scsi/atp870u.c:622: warning: Excess function parameter 'done' description in 'atp870u_queuecommand_lck' Fixes: af049dfd0b10 ("scsi: core: Remove the 'done' argument from SCSI queuecommand_lck functions") Signed-off-by: Bart Van Assche --- drivers/scsi/atp870u.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/atp870u.c b/drivers/scsi/atp870u.c index dcd6fae65a88..7143418d690f 100644 --- a/drivers/scsi/atp870u.c +++ b/drivers/scsi/atp870u.c @@ -614,7 +614,6 @@ static irqreturn_t atp870u_intr_handle(int irq, void *dev_id) /** * atp870u_queuecommand_lck - Queue SCSI command * @req_p: request block - * @done: completion function * * Queue a command to the ATP queue. Called with the host lock held. */ From patchwork Mon Nov 29 19:46:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 518648 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78E33C4332F for ; Mon, 29 Nov 2021 19:48:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353257AbhK2Tvn (ORCPT ); Mon, 29 Nov 2021 14:51:43 -0500 Received: from mail-pf1-f174.google.com ([209.85.210.174]:39589 "EHLO mail-pf1-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347495AbhK2Ttm (ORCPT ); Mon, 29 Nov 2021 14:49:42 -0500 Received: by mail-pf1-f174.google.com with SMTP id i12so18029040pfd.6 for ; Mon, 29 Nov 2021 11:46:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qhobAcdyo1e28tDZZU6//79J1mh/4UC8Q7hU3IoeFhQ=; b=k2df5pcuNDMFIYbXfXxhzC/3FDnMZPw9CQO+3rmb2zzwXqNwBOlVXJlKdVc76IELti CwR1gitGyNFWx48kpZSbKcU4WPhdsLzfoG3iskwH2LEgwhC8WUQA1QNwb/sO2RSDJz0S oS4PH7siscjUcZgcDhh2FwGrKMw1MyAQ8F6w4pGdgmdJ7QCmRSn/jEi3SeN1o2h7vMHu fcZR663yxW4zPsaRPZXz7G/jAv7oETDTCdJVX1ou3bPzv2ILwrSl570dXWG8mc3v6mTJ IftQqQEBJZWYnYGaOULj/EIIUr9njdcqTS4am3zWt/wgq/kGuSowOCbSppw6x1UHwcZ8 ftlQ== X-Gm-Message-State: AOAM533042ZgK/t/x4wdOvJ071W3OgDZAsOQcNzduaD2EBR5e2jUzvRM Z1Zg1WM4OG3YGueDDvXGHwTS1Zr1pbk= X-Google-Smtp-Source: ABdhPJxF1pAwEfbbZyV84Dv7aupnrs16hscRHEIu0mvdfIDT+OQzb8YgYU+kdO49FIoB6Sx6twV3qw== X-Received: by 2002:a05:6a00:17a4:b0:49f:c0c0:3263 with SMTP id s36-20020a056a0017a400b0049fc0c03263mr41989336pfg.81.1638215184641; Mon, 29 Nov 2021 11:46:24 -0800 (PST) Received: from bvanassche-linux.mtv.corp.google.com ([2620:15c:211:201:a4a0:8cb5:fff:67db]) by smtp.gmail.com with ESMTPSA id ns21sm141715pjb.37.2021.11.29.11.46.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Nov 2021 11:46:24 -0800 (PST) From: Bart Van Assche To: "Martin K . Petersen" Cc: Jaegeuk Kim , linux-scsi@vger.kernel.org, Bart Van Assche , kernel test robot , Anil Gurumurthy , Sudarsana Kalluru , "James E.J. Bottomley" Subject: [PATCH v2 06/12] scsi: bfa: Declare 'bfad_im_vport_attrs' static Date: Mon, 29 Nov 2021 11:46:03 -0800 Message-Id: <20211129194609.3466071-7-bvanassche@acm.org> X-Mailer: git-send-email 2.34.0.rc2.393.gf8c9666880-goog In-Reply-To: <20211129194609.3466071-1-bvanassche@acm.org> References: <20211129194609.3466071-1-bvanassche@acm.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fix the following kernel-doc warning: 'bfad_im_vport_attrs' is only used in one source file. Hence declare this array static. Fixes: e73af234a1a2 ("scsi: bfa: Switch to attribute groups") Reported-by: kernel test robot Signed-off-by: Bart Van Assche --- drivers/scsi/bfa/bfad_attr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/bfa/bfad_attr.c b/drivers/scsi/bfa/bfad_attr.c index c8b947c16069..f46989bd083c 100644 --- a/drivers/scsi/bfa/bfad_attr.c +++ b/drivers/scsi/bfa/bfad_attr.c @@ -981,7 +981,7 @@ const struct attribute_group *bfad_im_host_groups[] = { NULL }; -struct attribute *bfad_im_vport_attrs[] = { +static struct attribute *bfad_im_vport_attrs[] = { &dev_attr_serial_number.attr, &dev_attr_model.attr, &dev_attr_model_description.attr, From patchwork Mon Nov 29 19:46:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 517507 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1759FC433EF for ; Mon, 29 Nov 2021 19:48:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353433AbhK2Tvp (ORCPT ); Mon, 29 Nov 2021 14:51:45 -0500 Received: from mail-pl1-f181.google.com ([209.85.214.181]:45985 "EHLO mail-pl1-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378796AbhK2Ttp (ORCPT ); Mon, 29 Nov 2021 14:49:45 -0500 Received: by mail-pl1-f181.google.com with SMTP id b11so13015164pld.12 for ; Mon, 29 Nov 2021 11:46:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=echsw8eGcozK4R45uI095Y7j4xXG0m/T3vBvXXi680I=; b=n54o1j9k5sbRI+Q0NZ+XK218EJftCPM7taEjk+9I0zRBokoz2hYYKjL4xmDSXxkSvP baMaGmasQ3Q0ZcmjeK+GCR+0lFDbYBB4szaiEJsYz4C2L7XpU8ffIT1g6OjWS9tlmmER LDfnnkzdx/XFtTrmybBCYHe4UNk+3nQLdAKLDMpSrf6Z8BGeuRw+HwsGFiD7YA6HWTMv ZETOlg7cNmlp0IuozfFBT7/S3KkF8SqYa/8KQwU5/tRqlraak8oJUwZ7rXbrHKlAXzG/ 8edaS3+0QMEOIHQTk8sBqo7D2NivYU+mmEdtXkpSaR3EBsEPj5Uy0JFJNT5Z3y8z217c flpg== X-Gm-Message-State: AOAM530lqe2kDuOjopIjoAEMVqBU+hmDqzjK8/2JhHjSjp2R85Duyssp 7laE+9L7+fsMisU5dNROB8cDaCLi2yc= X-Google-Smtp-Source: ABdhPJwEg8wd9W124aHjcW1MrtJKgWVxQqD+CAZG+1h1zZGgvjpf39xhlFEebsOvNwWMyFIormrtQw== X-Received: by 2002:a17:90b:1c91:: with SMTP id oo17mr134160pjb.193.1638215185942; Mon, 29 Nov 2021 11:46:25 -0800 (PST) Received: from bvanassche-linux.mtv.corp.google.com ([2620:15c:211:201:a4a0:8cb5:fff:67db]) by smtp.gmail.com with ESMTPSA id ns21sm141715pjb.37.2021.11.29.11.46.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Nov 2021 11:46:25 -0800 (PST) From: Bart Van Assche To: "Martin K . Petersen" Cc: Jaegeuk Kim , linux-scsi@vger.kernel.org, Bart Van Assche , Oliver Neukum , Ali Akcaagac , Jamie Lenehan , "James E.J. Bottomley" Subject: [PATCH v2 07/12] scsi: dc395x: Fix a kernel-doc warning Date: Mon, 29 Nov 2021 11:46:04 -0800 Message-Id: <20211129194609.3466071-8-bvanassche@acm.org> X-Mailer: git-send-email 2.34.0.rc2.393.gf8c9666880-goog In-Reply-To: <20211129194609.3466071-1-bvanassche@acm.org> References: <20211129194609.3466071-1-bvanassche@acm.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fix the following kernel-doc warning: drivers/scsi/dc395x.c:964: warning: Excess function parameter 'done' description in 'dc395x_queue_command_lck' Fixes: af049dfd0b10 ("scsi: core: Remove the 'done' argument from SCSI queuecommand_lck functions") Signed-off-by: Bart Van Assche --- drivers/scsi/dc395x.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c index 9b8796c9e634..c11916b8ae00 100644 --- a/drivers/scsi/dc395x.c +++ b/drivers/scsi/dc395x.c @@ -946,7 +946,6 @@ static void build_srb(struct scsi_cmnd *cmd, struct DeviceCtlBlk *dcb, * layer, invoke 'done' on completion * * @cmd: pointer to scsi command object - * @done: function pointer to be invoked on completion * * Returns 1 if the adapter (host) is busy, else returns 0. One * reason for an adapter to be busy is that the number @@ -959,7 +958,7 @@ static void build_srb(struct scsi_cmnd *cmd, struct DeviceCtlBlk *dcb, * Locks: struct Scsi_Host::host_lock held on entry (with "irqsave") * and is expected to be held on return. * - **/ + */ static int dc395x_queue_command_lck(struct scsi_cmnd *cmd) { void (*done)(struct scsi_cmnd *) = scsi_done; From patchwork Mon Nov 29 19:46:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 518647 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AED1BC433FE for ; Mon, 29 Nov 2021 19:48:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353754AbhK2Tvr (ORCPT ); Mon, 29 Nov 2021 14:51:47 -0500 Received: from mail-pg1-f180.google.com ([209.85.215.180]:35632 "EHLO mail-pg1-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378839AbhK2Ttp (ORCPT ); Mon, 29 Nov 2021 14:49:45 -0500 Received: by mail-pg1-f180.google.com with SMTP id j11so7292951pgs.2 for ; Mon, 29 Nov 2021 11:46:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nmSr4aGAqiYob5EbKWRQg54NwSmiITSVXf9eYWzcg/A=; b=aYlIJaLRwOugIOWWJnRn01/k/t35+wPWKup9uyp28V0C6l73joqMFiZLSVrh/BX6wr Xzq11aTTrUUq/7dEfBvp95mLx2xEAi7SzeChdE0I8VxUlwcPZ2w/eWKh3Gc6/e/6XOP1 X6Tn198VlIzfZdZVjBwCgq+5OUhPFc5ohF+SBYvKtUe/kt2wzfZXmlFbPkirmbEGh42r uutbb3cLAsJCHaDVEcKerVGbxak5x47d9rkKFA98/+fgz9VaK87OQC7p20hN2UAeq3Ui FVzf9brvjR++5n+6rxG1pyL+IsC175aVzgbmWk0S3O0qHuWupHUscI5vRqyMekS7OrUR pRaQ== X-Gm-Message-State: AOAM533tSo/wPc+xGsrUCe8L3CmkabQC/yaSof0fT1wjguzdBWir6m9A gCKqOlXEdV+6QPCyoYOaCS4= X-Google-Smtp-Source: ABdhPJwZ0nHKJPJUV3KCIDW2XGFJzfKON9K6oMSzFQNeME7uzB1mZDEsfa0FUvWHFvhm20mD4JOdlA== X-Received: by 2002:a05:6a00:14ce:b0:49f:dc1c:a0fb with SMTP id w14-20020a056a0014ce00b0049fdc1ca0fbmr42109299pfu.56.1638215187265; Mon, 29 Nov 2021 11:46:27 -0800 (PST) Received: from bvanassche-linux.mtv.corp.google.com ([2620:15c:211:201:a4a0:8cb5:fff:67db]) by smtp.gmail.com with ESMTPSA id ns21sm141715pjb.37.2021.11.29.11.46.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Nov 2021 11:46:26 -0800 (PST) From: Bart Van Assche To: "Martin K . Petersen" Cc: Jaegeuk Kim , linux-scsi@vger.kernel.org, Bart Van Assche , "James E.J. Bottomley" Subject: [PATCH v2 08/12] scsi: initio: Fix a kernel-doc warning Date: Mon, 29 Nov 2021 11:46:05 -0800 Message-Id: <20211129194609.3466071-9-bvanassche@acm.org> X-Mailer: git-send-email 2.34.0.rc2.393.gf8c9666880-goog In-Reply-To: <20211129194609.3466071-1-bvanassche@acm.org> References: <20211129194609.3466071-1-bvanassche@acm.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fix the following kernel-doc warning: drivers/scsi/initio.c:2613: warning: Excess function parameter 'done' description in 'i91u_queuecommand_lck' Fixes: af049dfd0b10 ("scsi: core: Remove the 'done' argument from SCSI queuecommand_lck functions") Signed-off-by: Bart Van Assche --- drivers/scsi/initio.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/initio.c b/drivers/scsi/initio.c index fd6da96bc51a..9cdee38f5ba3 100644 --- a/drivers/scsi/initio.c +++ b/drivers/scsi/initio.c @@ -2602,13 +2602,11 @@ static void initio_build_scb(struct initio_host * host, struct scsi_ctrl_blk * c /** * i91u_queuecommand_lck - Queue a new command if possible * @cmd: SCSI command block from the mid layer - * @done: Completion handler * * Attempts to queue a new command with the host adapter. Will return * zero if successful or indicate a host busy condition if not (which * will cause the mid layer to call us again later with the command) */ - static int i91u_queuecommand_lck(struct scsi_cmnd *cmd) { struct initio_host *host = (struct initio_host *) cmd->device->host->hostdata; From patchwork Mon Nov 29 19:46:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 517506 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20EC6C433F5 for ; Mon, 29 Nov 2021 19:48:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354589AbhK2Tvs (ORCPT ); Mon, 29 Nov 2021 14:51:48 -0500 Received: from mail-pf1-f170.google.com ([209.85.210.170]:42684 "EHLO mail-pf1-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378862AbhK2Ttq (ORCPT ); Mon, 29 Nov 2021 14:49:46 -0500 Received: by mail-pf1-f170.google.com with SMTP id u80so18025054pfc.9 for ; Mon, 29 Nov 2021 11:46:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=54db5IroZ/C1hKDclRAMB0jVjoQpe+ZQfjyZH9rHows=; b=um2Ijd4y3WYvrTVznGxKWIEeRZAEd5f/8RRmifyhnRtArKzYUEm62mBw9zx5mXSKym ErTMRWCdPUizIjTCuAIvG1d7l6GUmnsurcoiQpE+g2w/yZBOUR3YLyyb2YbY4lEWcFi9 P73dAuGHO3RDkGoI4SikMX0rBohB6wuiyDvOb/d8jhu6uhU7nJu2y0dTwQvr914LFaEk isPd3zOHIutThHYfwfIO8uYsKVOh1VTo1fmctNh7szuvn2frfmzNCgq7Hd/naugZOUsy MzMxlC/0Ad/7HTtK1lRVbtfz3p+WLsf1ErBp6jejUCv6giCoMwevH48aqppxsc2QbTKl IWtg== X-Gm-Message-State: AOAM530jPd251DLMAT8UzZPWKmwHhn+9baWMYeYv8cr7Q+2fFj9P/WXW WLF85JS1uVE2zWZU2jh3170= X-Google-Smtp-Source: ABdhPJzZ9maHy1WSIGLEC85vOPaFA89MNp21jv5Ix5iDsupf8PtF4Lo0OKuI2bScTFviCBRvBz2IpQ== X-Received: by 2002:a62:e908:0:b0:49f:c633:51ec with SMTP id j8-20020a62e908000000b0049fc63351ecmr41028210pfh.1.1638215188577; Mon, 29 Nov 2021 11:46:28 -0800 (PST) Received: from bvanassche-linux.mtv.corp.google.com ([2620:15c:211:201:a4a0:8cb5:fff:67db]) by smtp.gmail.com with ESMTPSA id ns21sm141715pjb.37.2021.11.29.11.46.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Nov 2021 11:46:28 -0800 (PST) From: Bart Van Assche To: "Martin K . Petersen" Cc: Jaegeuk Kim , linux-scsi@vger.kernel.org, Bart Van Assche , Kashyap Desai , Sumit Saxena , Shivasharan S , "James E.J. Bottomley" Subject: [PATCH v2 09/12] scsi: megaraid: Fix a kernel-doc warning Date: Mon, 29 Nov 2021 11:46:06 -0800 Message-Id: <20211129194609.3466071-10-bvanassche@acm.org> X-Mailer: git-send-email 2.34.0.rc2.393.gf8c9666880-goog In-Reply-To: <20211129194609.3466071-1-bvanassche@acm.org> References: <20211129194609.3466071-1-bvanassche@acm.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fix the following kernel-doc warning: drivers/scsi/megaraid/megaraid_mbox.c:1439: warning: Excess function parameter 'done' description in 'megaraid_queue_command_lck' Fixes: af049dfd0b10 ("scsi: core: Remove the 'done' argument from SCSI queuecommand_lck functions") Signed-off-by: Bart Van Assche --- drivers/scsi/megaraid/megaraid_mbox.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/megaraid/megaraid_mbox.c b/drivers/scsi/megaraid/megaraid_mbox.c index 14f930d27ca1..2a339d4a7e9d 100644 --- a/drivers/scsi/megaraid/megaraid_mbox.c +++ b/drivers/scsi/megaraid/megaraid_mbox.c @@ -1431,7 +1431,6 @@ mbox_post_cmd(adapter_t *adapter, scb_t *scb) /** * megaraid_queue_command_lck - generic queue entry point for all LLDs * @scp : pointer to the scsi command to be executed - * @done : callback routine to be called after the cmd has be completed * * Queue entry point for mailbox based controllers. */ From patchwork Mon Nov 29 19:46:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 518646 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F36C0C433EF for ; Mon, 29 Nov 2021 19:48:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354785AbhK2Tvt (ORCPT ); Mon, 29 Nov 2021 14:51:49 -0500 Received: from mail-pl1-f177.google.com ([209.85.214.177]:40529 "EHLO mail-pl1-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244671AbhK2Tts (ORCPT ); Mon, 29 Nov 2021 14:49:48 -0500 Received: by mail-pl1-f177.google.com with SMTP id v19so13019883plo.7 for ; Mon, 29 Nov 2021 11:46:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EKggP/kC93g46/vrOUZekUVrmPiltvkzfuihuVvN0rU=; b=aBfrysigNSGxNwLmOurzOrCl33oFRgHuAAW4Tai1FUZf8HhFNRgFAqLo4obZQeWuuo tIFSWAVNMi01e+1vKIlyJUzVjaI0QZC+Y/zAZhkgCHfvwNDkuAWVbKxI4JQH8hzNrIqs RxjAEQKHfu3cSN0Q0JT3jQEXCUHEkWJMGfcwyiUf/qSQ7l06kSJ3HRoABgnCySD7othi ejPnrqvd/PMrIsRzsW6IXa6oXmFEoQXF1igBWtWZXt5H9+hxOXoG29Wx1yDDgJ60lIaD A7ZjW+5cethbCu8mKoddiCd49cBzWk3mF2iJxf2LcKjVvF+mBPP10rLDIpvi30T9+bV1 YDBQ== X-Gm-Message-State: AOAM532gm0apGlQIShEfV7WHmai1JclTTKSMOLGa5B7SMnx9n47E92A8 qXql63CXgw3yHR+joml7Nd9oLPJDMg4= X-Google-Smtp-Source: ABdhPJyVGzb8P7H7Mh0C0WZ2KoCT4X2IbO7ZIdY66G8NyU66QnJoGvDzlt9GPx28Uvb3EfZzYEcXkg== X-Received: by 2002:a17:90b:1a86:: with SMTP id ng6mr200381pjb.142.1638215190269; Mon, 29 Nov 2021 11:46:30 -0800 (PST) Received: from bvanassche-linux.mtv.corp.google.com ([2620:15c:211:201:a4a0:8cb5:fff:67db]) by smtp.gmail.com with ESMTPSA id ns21sm141715pjb.37.2021.11.29.11.46.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Nov 2021 11:46:29 -0800 (PST) From: Bart Van Assche To: "Martin K . Petersen" Cc: Jaegeuk Kim , linux-scsi@vger.kernel.org, Bart Van Assche , Jack Wang , Jack Wang , "James E.J. Bottomley" , Ashokkumar N , kernel test robot , Vishakha Channapattan , Ruksar Devadi Subject: [PATCH v2 10/12] scsi: pm8001: Fix kernel-doc warnings Date: Mon, 29 Nov 2021 11:46:07 -0800 Message-Id: <20211129194609.3466071-11-bvanassche@acm.org> X-Mailer: git-send-email 2.34.0.rc2.393.gf8c9666880-goog In-Reply-To: <20211129194609.3466071-1-bvanassche@acm.org> References: <20211129194609.3466071-1-bvanassche@acm.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fix the following kernel-doc warnings: drivers/scsi/pm8001/pm8001_ctl.c:900: warning: cannot understand function prototype: 'const char *const mpiStateText[] = ' drivers/scsi/pm8001/pm8001_ctl.c:930: warning: Function parameter or member 'attr' not described in 'ctl_hmi_error_show' drivers/scsi/pm8001/pm8001_ctl.c:951: warning: Function parameter or member 'attr' not described in 'ctl_raae_count_show' drivers/scsi/pm8001/pm8001_ctl.c:972: warning: Function parameter or member 'attr' not described in 'ctl_iop0_count_show' drivers/scsi/pm8001/pm8001_ctl.c:993: warning: Function parameter or member 'attr' not described in 'ctl_iop1_count_show' Acked-by: Jack Wang Fixes: 4ddbea1b6f51 ("scsi: pm80xx: Add sysfs attribute to check MPI state") Signed-off-by: Bart Van Assche --- drivers/scsi/pm8001/pm8001_ctl.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/scsi/pm8001/pm8001_ctl.c b/drivers/scsi/pm8001/pm8001_ctl.c index 397eb9f6a1dd..41a63c9b719b 100644 --- a/drivers/scsi/pm8001/pm8001_ctl.c +++ b/drivers/scsi/pm8001/pm8001_ctl.c @@ -889,14 +889,6 @@ static ssize_t pm8001_show_update_fw(struct device *cdev, static DEVICE_ATTR(update_fw, S_IRUGO|S_IWUSR|S_IWGRP, pm8001_show_update_fw, pm8001_store_update_fw); -/** - * ctl_mpi_state_show - controller MPI state check - * @cdev: pointer to embedded class device - * @buf: the buffer returned - * - * A sysfs 'read-only' shost attribute. - */ - static const char *const mpiStateText[] = { "MPI is not initialized", "MPI is successfully initialized", @@ -904,6 +896,14 @@ static const char *const mpiStateText[] = { "MPI initialization failed with error in [31:16]" }; +/** + * ctl_mpi_state_show - controller MPI state check + * @cdev: pointer to embedded class device + * @attr: device attribute (unused) + * @buf: the buffer returned + * + * A sysfs 'read-only' shost attribute. + */ static ssize_t ctl_mpi_state_show(struct device *cdev, struct device_attribute *attr, char *buf) { @@ -920,11 +920,11 @@ static DEVICE_ATTR_RO(ctl_mpi_state); /** * ctl_hmi_error_show - controller MPI initialization fails * @cdev: pointer to embedded class device + * @attr: device attribute (unused) * @buf: the buffer returned * * A sysfs 'read-only' shost attribute. */ - static ssize_t ctl_hmi_error_show(struct device *cdev, struct device_attribute *attr, char *buf) { @@ -941,11 +941,11 @@ static DEVICE_ATTR_RO(ctl_hmi_error); /** * ctl_raae_count_show - controller raae count check * @cdev: pointer to embedded class device + * @attr: device attribute (unused) * @buf: the buffer returned * * A sysfs 'read-only' shost attribute. */ - static ssize_t ctl_raae_count_show(struct device *cdev, struct device_attribute *attr, char *buf) { @@ -962,11 +962,11 @@ static DEVICE_ATTR_RO(ctl_raae_count); /** * ctl_iop0_count_show - controller iop0 count check * @cdev: pointer to embedded class device + * @attr: device attribute (unused) * @buf: the buffer returned * * A sysfs 'read-only' shost attribute. */ - static ssize_t ctl_iop0_count_show(struct device *cdev, struct device_attribute *attr, char *buf) { @@ -983,11 +983,11 @@ static DEVICE_ATTR_RO(ctl_iop0_count); /** * ctl_iop1_count_show - controller iop1 count check * @cdev: pointer to embedded class device + * @attr: device attribute (unused) * @buf: the buffer returned * * A sysfs 'read-only' shost attribute. */ - static ssize_t ctl_iop1_count_show(struct device *cdev, struct device_attribute *attr, char *buf) { From patchwork Mon Nov 29 19:46:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 517505 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 315F3C433FE for ; Mon, 29 Nov 2021 19:48:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355305AbhK2Tvv (ORCPT ); Mon, 29 Nov 2021 14:51:51 -0500 Received: from mail-pf1-f181.google.com ([209.85.210.181]:46031 "EHLO mail-pf1-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349307AbhK2Ttu (ORCPT ); Mon, 29 Nov 2021 14:49:50 -0500 Received: by mail-pf1-f181.google.com with SMTP id x131so17999023pfc.12 for ; Mon, 29 Nov 2021 11:46:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7cuj8FAQu+U4mwMtZt6FcuDFWW6tk2Sw8Wa4aySB2Kg=; b=zsMw4r1hkoIWEsEbe/oNRt/3DFXKUx71PXL1Xrc59Xuy+KmEn3kRopdpKnFwQHiG47 Gu3o6L1l++T6n0PjGv5lXRUVikTyk0u9uLtp0Biz9TpTynctO12rvs0uMINypwkVW8pC 7TOXJLZu+P+Lln1qQigK6FWotEy6kNCH32O7CyKMIXLMFOFy2xRW6Mdu9eCUc8bL6Q2t ePF+k9Ahd3lbbryIjHkQg46imEE9YTcnxE3iPmZB1AYWeQvjNrhN8weh4bMGiJh0kaeg ZNaPY/l9pnYFo8A/6W8GhNQ/nLWXgnMZzns0N6xqUZNIAsIVxfKYK80E8NDfFGqMrAw1 UcCQ== X-Gm-Message-State: AOAM530vPejFklJueiE9pVq/xyYmLbl76VWMTuIDbmGLBvxhHUhgh77n gUIjCS9my3RfdNTf+87Ms4o= X-Google-Smtp-Source: ABdhPJwvFxLvywSVp0XiNNZGBIE0+KLl8zmUabmjLNmaRlyQbxYiJlmKX+nFrnILBpM2mpruzdWOhQ== X-Received: by 2002:a05:6a00:1a16:b0:49f:ed6d:c48e with SMTP id g22-20020a056a001a1600b0049fed6dc48emr40867267pfv.14.1638215191608; Mon, 29 Nov 2021 11:46:31 -0800 (PST) Received: from bvanassche-linux.mtv.corp.google.com ([2620:15c:211:201:a4a0:8cb5:fff:67db]) by smtp.gmail.com with ESMTPSA id ns21sm141715pjb.37.2021.11.29.11.46.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Nov 2021 11:46:31 -0800 (PST) From: Bart Van Assche To: "Martin K . Petersen" Cc: Jaegeuk Kim , linux-scsi@vger.kernel.org, Bart Van Assche , "James E.J. Bottomley" Subject: [PATCH v2 11/12] scsi: pmcraid: Fix a kernel-doc warning Date: Mon, 29 Nov 2021 11:46:08 -0800 Message-Id: <20211129194609.3466071-12-bvanassche@acm.org> X-Mailer: git-send-email 2.34.0.rc2.393.gf8c9666880-goog In-Reply-To: <20211129194609.3466071-1-bvanassche@acm.org> References: <20211129194609.3466071-1-bvanassche@acm.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fix the following kernel-doc warning: drivers/scsi/pmcraid.c:3317: warning: Excess function parameter 'done' description in 'pmcraid_queuecommand_lck' Fixes: af049dfd0b10 ("scsi: core: Remove the 'done' argument from SCSI queuecommand_lck functions") Signed-off-by: Bart Van Assche --- drivers/scsi/pmcraid.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c index 88046a793767..2fe7a0019fff 100644 --- a/drivers/scsi/pmcraid.c +++ b/drivers/scsi/pmcraid.c @@ -3302,7 +3302,6 @@ static int pmcraid_copy_sglist( /** * pmcraid_queuecommand_lck - Queue a mid-layer request * @scsi_cmd: scsi command struct - * @done: done function * * This function queues a request generated by the mid-layer. Midlayer calls * this routine within host->lock. Some of the functions called by queuecommand From patchwork Mon Nov 29 19:46:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 518645 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB134C433EF for ; Mon, 29 Nov 2021 19:48:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378207AbhK2TwF (ORCPT ); Mon, 29 Nov 2021 14:52:05 -0500 Received: from mail-pf1-f174.google.com ([209.85.210.174]:42718 "EHLO mail-pf1-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243752AbhK2TuE (ORCPT ); Mon, 29 Nov 2021 14:50:04 -0500 Received: by mail-pf1-f174.google.com with SMTP id u80so18025806pfc.9 for ; Mon, 29 Nov 2021 11:46:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=raXhQaIAWBkFfxmbVFEMBS2txHLtjJxntwQvPLU0v/o=; b=AfzABir0KfuSIG4NM6cSrkr7JEpkTde4Dfe0fNS5KSn5+mUjqVJRBnYBlT833hcJZz zpbaG+bVYhLQPv+XPjmyKYEyssSYqms4TBun5POr0fNZqFYiBBIeodYxTYZ/V7gXTqb/ IhY+uUx7ZZTe3SkRDtubpap1E2m2HOVUNrbK5Nn+MwyKN+dutJRTivrGFqMTm6qPQaAN W6kF6yX/tfbNVcAGfpU7tTEElkDk46o2Ieo/bSaVluU4P4B/NJC9NpL2qHYlDrWT+4Z1 AwFavueAZQojUI+apyss0+X5f0EBZdAlKv8OTiP5mqNR4Z943Ax9mtV4j9Z7hhRE3dlQ rAHA== X-Gm-Message-State: AOAM530zghMxTXlIpMMb9EQcj/YOw0fusq0NY+PC8KRNuOpZKNj2dxhf ZUPE7HLn5QVb0CabATtLuwKQX4W40fg= X-Google-Smtp-Source: ABdhPJzwFze3iF82/k5ETikjMUHHU6wm83UZYca9IvCRZWwCjhJ6+MMq7v5xsmmCXud2og1k9/zGAw== X-Received: by 2002:a63:3117:: with SMTP id x23mr37189323pgx.126.1638215206672; Mon, 29 Nov 2021 11:46:46 -0800 (PST) Received: from bvanassche-linux.mtv.corp.google.com ([2620:15c:211:201:a4a0:8cb5:fff:67db]) by smtp.gmail.com with ESMTPSA id ns21sm141715pjb.37.2021.11.29.11.46.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Nov 2021 11:46:46 -0800 (PST) From: Bart Van Assche To: "Martin K . Petersen" Cc: Jaegeuk Kim , linux-scsi@vger.kernel.org, Bart Van Assche , Daejun Park , John Garry , "James E.J. Bottomley" , Luo Jiaxing , "Gustavo A. R. Silva" , Jason Yan , Avri Altman , Bean Huo , Keoseong Park Subject: [PATCH v2 12/12] scsi: Remove superfluous #include directives Date: Mon, 29 Nov 2021 11:46:09 -0800 Message-Id: <20211129194609.3466071-13-bvanassche@acm.org> X-Mailer: git-send-email 2.34.0.rc2.393.gf8c9666880-goog In-Reply-To: <20211129194609.3466071-1-bvanassche@acm.org> References: <20211129194609.3466071-1-bvanassche@acm.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Remove this include directive from code that does not use any functionality from kernel/async.c. Reviewed-by: Daejun Park Signed-off-by: Bart Van Assche --- drivers/scsi/hisi_sas/hisi_sas.h | 1 - drivers/scsi/libsas/sas_discover.c | 1 - drivers/scsi/scsi.c | 1 - drivers/scsi/scsi_pm.c | 1 - drivers/scsi/scsi_priv.h | 1 - drivers/scsi/sd.c | 1 - drivers/scsi/ufs/ufshpb.c | 1 - 7 files changed, 7 deletions(-) diff --git a/drivers/scsi/hisi_sas/hisi_sas.h b/drivers/scsi/hisi_sas/hisi_sas.h index 2213a91923a5..ed9419643235 100644 --- a/drivers/scsi/hisi_sas/hisi_sas.h +++ b/drivers/scsi/hisi_sas/hisi_sas.h @@ -8,7 +8,6 @@ #define _HISI_SAS_H_ #include -#include #include #include #include diff --git a/drivers/scsi/libsas/sas_discover.c b/drivers/scsi/libsas/sas_discover.c index 12e1e36d7c04..758213694091 100644 --- a/drivers/scsi/libsas/sas_discover.c +++ b/drivers/scsi/libsas/sas_discover.c @@ -8,7 +8,6 @@ #include #include -#include #include #include #include "sas_internal.h" diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c index f6af1562cba4..dee4d9c6046d 100644 --- a/drivers/scsi/scsi.c +++ b/drivers/scsi/scsi.c @@ -55,7 +55,6 @@ #include #include #include -#include #include #include diff --git a/drivers/scsi/scsi_pm.c b/drivers/scsi/scsi_pm.c index b5a858c29488..0e841e8761c5 100644 --- a/drivers/scsi/scsi_pm.c +++ b/drivers/scsi/scsi_pm.c @@ -8,7 +8,6 @@ #include #include -#include #include #include diff --git a/drivers/scsi/scsi_priv.h b/drivers/scsi/scsi_priv.h index 0f5743f4769b..5c4786310a31 100644 --- a/drivers/scsi/scsi_priv.h +++ b/drivers/scsi/scsi_priv.h @@ -3,7 +3,6 @@ #define _SCSI_PRIV_H #include -#include #include #include diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 65875a598d62..2a50a840a00c 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -51,7 +51,6 @@ #include #include #include -#include #include #include #include diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c index 2e31e1413826..9778d4fd03cc 100644 --- a/drivers/scsi/ufs/ufshpb.c +++ b/drivers/scsi/ufs/ufshpb.c @@ -10,7 +10,6 @@ */ #include -#include #include "ufshcd.h" #include "ufshpb.h"