From patchwork Mon Nov 5 11:58:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 150175 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp2506474ljp; Mon, 5 Nov 2018 03:58:10 -0800 (PST) X-Google-Smtp-Source: AJdET5f6FXWWYBFaIj78yF4rwKrjuHseeE/7vfEzmAXpr1mxvTpUvjW8/WKMzh4WbBQ6wwPyfQgo X-Received: by 2002:a5d:43ca:: with SMTP id v10-v6mr19765834wrr.244.1541419090876; Mon, 05 Nov 2018 03:58:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541419090; cv=none; d=google.com; s=arc-20160816; b=I1dW6YYlmWvifDD3rr0N/V68T4tBExx8GHgS20lainfwU8+hGI3OiQqlPzq2djyo2o VOjtI0hgN9RjkbCBUzstKEImHoOOlJm1NK5/selm4xrizsuCygn6NS5xA2cuM1GZ7zTw CkbOittAfbEoSSjXXQwRN3YYDNZCTQbTZIJBLmxNO1p5C7nteUvyonM+0Grmw7h1/aS3 P4kmZ//J+SL+6rmOBCUBebgawKkaDqMyeYWwyfkZA2SQ563Y4+gv96XSofNQgVz4U0nm 7DAzwYdKIHTbUF/zJmxz9XbHL6Ha3Ug4q5cK8qOysZUJ9/rKd3XTYEy4Sh5E1aYIoD0Y /quA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to; bh=RsGLMANRUmWZjz0+o38LtuGBulR+TTK6AT96A87a4d4=; b=svgLoj01ngZNSyFV/abQ7Q1ClyAOQGJUtbL3GbD4PsFBz1imknW8UtMNQ7bxVDsE1E lKEARjIOFV62oISyOmE7NBZYabC5ssN5KEEDaE4CIcVY5PN+qoxjNOIhf02cK2I0yu1S BtuAe7qLGyELFE4JHkeLGYZJpO5dkzux/rQ7NHQGxP0Mb74aWkczTWc6r/lDaGT1m1B3 syCiGXHzXEeJNa6W4Llm/y4aiaceG3YCcmrYpKNhQ8QFqBKpFlku/7jC6VOKLz0CK3h0 1a9U4TIgUYqhJKGdpcc3eJ+RHK4XYDv18ZMEh5YuC+RlNmrseDp/vULvrzLMTnaHjbvw vUrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=xPC6tU7K; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id k11-v6si33285909wrm.210.2018.11.05.03.58.10; Mon, 05 Nov 2018 03:58:10 -0800 (PST) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=xPC6tU7K; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 2ABB32679F7; Mon, 5 Nov 2018 12:58:06 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 7CD232679FA; Mon, 5 Nov 2018 12:58:04 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id 7BA7F2678DD for ; Mon, 5 Nov 2018 12:58:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=wsYbNOQOEtK1UAHqv2ZqZuIhVcp7Z9Mu86Ptxxx/V78=; b=xPC6tU7KakAZ R3iriMi2jsO76t9PVwLOlCbSMqF/k5CJbqk6DXFqBuYBiqMoEgGagFxpY+IETy3MbswhdixXljKSz M561DidLSnQFp6WRYDLhRK1Kk8Z+ydWgDWHw4oZGf47xy0ZU+gOCmyhyTimuCsKR4pRG1XeDeiFbG 098iQ=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1gJdW5-0008Hx-TX; Mon, 05 Nov 2018 11:58:01 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id 9BACE1124D98; Mon, 5 Nov 2018 11:58:01 +0000 (GMT) From: Mark Brown To: Kuninori Morimoto In-Reply-To: <87h8h3sxt4.wl-kuninori.morimoto.gx@renesas.com> Message-Id: <20181105115801.9BACE1124D98@debutante.sirena.org.uk> Date: Mon, 5 Nov 2018 11:58:01 +0000 (GMT) Cc: alsa-devel@alsa-project.org, Mark Brown Subject: [alsa-devel] Applied "ASoC: pcm3168a: cleanup hw_constraint for LEFT_J/I2S" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: pcm3168a: cleanup hw_constraint for LEFT_J/I2S has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 0900d1e64815b3b8d4d04197aa135e77317176e1 Mon Sep 17 00:00:00 2001 From: Kuninori Morimoto Date: Tue, 30 Oct 2018 07:31:40 +0000 Subject: [PATCH] ASoC: pcm3168a: cleanup hw_constraint for LEFT_J/I2S hw constraint for LEFT_J/I2S are same, but had duplicated code. This code cleanup these. Signed-off-by: Kuninori Morimoto Signed-off-by: Mark Brown --- sound/soc/codecs/pcm3168a.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) -- 2.19.0.rc2 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/codecs/pcm3168a.c b/sound/soc/codecs/pcm3168a.c index 52cc950c9fd1..5f4327f5b725 100644 --- a/sound/soc/codecs/pcm3168a.c +++ b/sound/soc/codecs/pcm3168a.c @@ -504,6 +504,10 @@ static int pcm3168a_startup(struct snd_pcm_substream *substream, unsigned int fmt; unsigned int sample_min; unsigned int channel_max; + unsigned int channel_maxs[] = { + 6, /* rx */ + 8 /* tx */ + }; if (tx) fmt = pcm3168a->dac_fmt; @@ -528,18 +532,9 @@ static int pcm3168a_startup(struct snd_pcm_substream *substream, channel_max = 2; break; case PCM3168A_FMT_LEFT_J: - sample_min = 24; - if (tx) - channel_max = 8; - else - channel_max = 6; - break; case PCM3168A_FMT_I2S: sample_min = 24; - if (tx) - channel_max = 8; - else - channel_max = 6; + channel_max = channel_maxs[tx]; break; default: sample_min = 24;