From patchwork Sun Nov 21 16:56:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joey Gouly X-Patchwork-Id: 518423 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1614C433EF for ; Sun, 21 Nov 2021 16:57:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238748AbhKURAf (ORCPT ); Sun, 21 Nov 2021 12:00:35 -0500 Received: from mail-eopbgr60041.outbound.protection.outlook.com ([40.107.6.41]:8337 "EHLO EUR04-DB3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S238344AbhKURAI (ORCPT ); Sun, 21 Nov 2021 12:00:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9k4kB2G0R1p3G60V1a8RT7Za+LQj2NYxAjo54dC8Q8I=; b=+DNLeQXNDEJNfB3Dz392XKmP9GRZto0btr20YlnkyvSv8PV6U0UsOSWrXES4IHIhiZ8JODy+Awxr4J/KZEQv7DhmamhAFjPqYEwvlkaQdqg9oniCqUIeaWWdTe+SogkMfqaIIzOpvhjnjJUuWDEiW1f6lGEcUaOr5SpghKGkc6U= Received: from DB6PR07CA0057.eurprd07.prod.outlook.com (2603:10a6:6:2a::19) by DB6PR0801MB1783.eurprd08.prod.outlook.com (2603:10a6:4:2e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22; Sun, 21 Nov 2021 16:57:00 +0000 Received: from DB5EUR03FT031.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2a:cafe::8) by DB6PR07CA0057.outlook.office365.com (2603:10a6:6:2a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.12 via Frontend Transport; Sun, 21 Nov 2021 16:57:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT031.mail.protection.outlook.com (10.152.20.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend Transport; Sun, 21 Nov 2021 16:57:00 +0000 Received: ("Tessian outbound c61f076cbd30:v110"); Sun, 21 Nov 2021 16:57:00 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 20dd9cd09c6b9c20 X-CR-MTA-TID: 64aa7808 Received: from a8d4ac73707f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 018D6851-D60E-47CF-9DFF-D461E557FDB9.1; Sun, 21 Nov 2021 16:56:54 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a8d4ac73707f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 21 Nov 2021 16:56:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HPBh6PqQtTPUWYHFUUBfz7KZuy/INVWTGYZK65RqjpMqHjtk58//aBUWo8BCOZ0VGqMPCpuhUq4m+yDkJ00b8HVZrOYSYU8b+s3NXWGJCQEUr4cFQWxiT0M02GqLBZt1U0W0QZvC9ZH7V54Y9F5sXvCngVQ0j5Q7ELLFeXmBflK4DDiglB54e4TSm3E6wxyXoovfVX552fE7GPcZeYJ40lNSlOqIyVOVNMQ6x+N3ZVFjXaB3ZG3oGzFTwz08JH6c5TArvur1MauNCtRXMzJ9GTUpuD3um5zyAdkPnE+B34kRb6HzjZeXOPOwLcAwyDJum8ULq8LewKUJZnL6UoLRDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9k4kB2G0R1p3G60V1a8RT7Za+LQj2NYxAjo54dC8Q8I=; b=mk4Ltjs1jDfOVvldbPl6YeDG/Dj11kvO4OiZ53cpeA+mRyaq2xd8g+ZYgbE2/IWlvMec15pHIK6O5zrxC8r09QdJI9r6FIJ6V0ZN1emUZYgTKTXkGJW4QABaG3VNIiroCSnRUG5nrmTMwLbc2HDuP0dOLIOQEvA63ZwJ1RB4WijzsgY8r56ABKYnlT2K8+GoxP4gYpQcya9flAbA1neJgg262O83GHBoYkftBChRVDMvlfqEsGI/VYYOvcm7nvYJJ/g1Kxypm8p5hyo2dzDXz3z4GsGbKQg65Dk392ANrb7hPWEFcOMfvtaVC7To37sM0PMpR4onmOqoQzRIm2GWlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9k4kB2G0R1p3G60V1a8RT7Za+LQj2NYxAjo54dC8Q8I=; b=+DNLeQXNDEJNfB3Dz392XKmP9GRZto0btr20YlnkyvSv8PV6U0UsOSWrXES4IHIhiZ8JODy+Awxr4J/KZEQv7DhmamhAFjPqYEwvlkaQdqg9oniCqUIeaWWdTe+SogkMfqaIIzOpvhjnjJUuWDEiW1f6lGEcUaOr5SpghKGkc6U= Received: from AS9PR06CA0419.eurprd06.prod.outlook.com (2603:10a6:20b:461::15) by AM5PR0802MB2404.eurprd08.prod.outlook.com (2603:10a6:203:a0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.21; Sun, 21 Nov 2021 16:56:51 +0000 Received: from VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:461:cafe::24) by AS9PR06CA0419.outlook.office365.com (2603:10a6:20b:461::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend Transport; Sun, 21 Nov 2021 16:56:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT064.mail.protection.outlook.com (10.152.19.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4713.19 via Frontend Transport; Sun, 21 Nov 2021 16:56:50 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sun, 21 Nov 2021 16:56:48 +0000 Received: from e124191.cambridge.arm.com (10.1.197.45) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend Transport; Sun, 21 Nov 2021 16:56:48 +0000 From: Joey Gouly To: CC: Linus Walleij , Andy Shevchenko , Hector Martin , , Joey Gouly Subject: [PATCH v2 01/11] pinctrl: apple: fix some formatting issues Date: Sun, 21 Nov 2021 16:56:32 +0000 Message-ID: <20211121165642.27883-2-joey.gouly@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211121165642.27883-1-joey.gouly@arm.com> References: <20211121165642.27883-1-joey.gouly@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 98794f1e-bd42-4276-3e04-08d9ad0fefb1 X-MS-TrafficTypeDiagnostic: AM5PR0802MB2404:|DB6PR0801MB1783: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:854;OLM:854; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: hEciRTUeUxe8emXdJ7UhB6IvO10XfYHUq5oPK2+YAALjhXlBloQGmUZiwMK+k3pXl74xNt2vb6BMZy7ha0DNK+fZgP4owhnL0ZAZf5ay6n8QivDHtEuhJcOXHoYSg8gPqEeT4QenI0AJldW6jH0ZFg4VP2f8NI6TFgfmOLEO1Rcp6hUw+NtcZVEhMkX+UT4i6Cil9RdURSvHpl5CVqdMA73XKd8xYm/ri5ZWBcTHJOoYVOaDaYfr0VSLYB9z+fiKrIFu05X0J2dNTamGdBzD+EnGqW394q/dsVDSm6X1AxMb3eluIJIt4FFqBoUKGknCdnts6B5qZG/kQFAiaOG1E9g5yibeQojNVheY9Fj61bcbrwymSv/yXn6n2bdSiSzn+/QOdIvsMJa6WLWzEfgnupPM9k4vp+sGbXuZxOR5opytmegcDDWrwXwbmZZ2hTqcGB7ef1kwFu6Nlr30GJxW6ZrwpnbmcGracgA/ge8St8EPOjGv9+x2bR3TdIheC6U3p+cNhkw2Fp90ZxtEN/RltOHL4IHcAdOJfpXfjGu+1AfjWTixqCArIwBLDhJ9OV3C1D7VSOArnlNtqzIuM5+ceGvmIcqsS4r5xbOC8tNHGKPf6VVLSBCjW8uKTQIos3Ywi+dghemjOspsblwqouQv1y9Azvu177zK+xusHeM+mNAt1yXCur7tE2HSpr8pPfkwgQ79t4ulrpq9gx92vJ+iEEElZfYhZ9fM3ED1rcC4Kz0OUsI0wX8p+Vmfrzh//aw0S23PaAMF+UHx+FqZeELmkw== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:nebula.arm.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(4636009)(47660400002)(36840700001)(46966006)(26005)(316002)(426003)(6666004)(356005)(47076005)(186003)(70586007)(8936002)(70206006)(36756003)(86362001)(7696005)(508600001)(2616005)(44832011)(82310400003)(8676002)(54906003)(2906002)(6916009)(81166007)(4326008)(83380400001)(1076003)(336012)(5660300002)(36860700001)(46800400005)(36900700001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2404 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 8d7e5b9e-8463-4d45-f909-08d9ad0fe9d4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p3+Ue+sPLREKwsK9HjQ0vhC65h//mdAzOj6do4Ar+KrhquPoNKwEawdrosWXoQAnSD5JEwKYqGcIACOli4QSn3MXLKI0HJmq4H/OK7hbqt0RzITbzV4AEEg7p87/DsrK0s4jIjEyxBWQQrLtwKiFdVEyegUFzadPjOjZKSAuHDcn8hzLz+Vq9krs/vD3HQsChnurGuZoFXAXWC5BrcYAhFRvC95L1qWeHPkueKymYjO7q619ck3L9tWAzdVErnkepdWvKqGgg5UZMfejwwdZ2w2jyabnR6zrD8iDtNFauzWzZOaOuTvdcCLzojp2xtAydDe6HoQgQlWVQjxDSyfpUHW/FLRmlLqIjd2m6//kJ4VOPZib5Rlc2+li8MyjhUyS2iCuTjORyg99A88sdF1TWSzVYRMNOnRptK9ZTznttUXnikroJTPRBZUeFRsGDB1q7voHTK6hn2u6otXyMvNFKnrmrrTD5hlfHgS2AjW4bxcMWGSrn94adeeP/IWLil2Uxzw/Tgbxq8KrMrTJ05dpomlQK5z5JIWtoVHIDIVBqBIUT5+YZdhtwJgrs4OCxq8pBHpzmZ2y4g+xjI8zrBNpQNkbtkxT1mvZpJJ6LnTwiQhNLUpHbdFTZrPCMdwnTMeQp252dJVNjd/UOSdvzzOCJ2F6PK9EICOReJW7PjdnG+pk+ncikVjE/s9G+YuqBPqfJ1Vh5B8sS4ROvQiFWY+a8hLNEmMaV5lXQRt8sF7ofOE= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(47660400002)(46966006)(36840700001)(86362001)(6916009)(54906003)(186003)(5660300002)(1076003)(47076005)(26005)(2616005)(8676002)(6666004)(44832011)(70206006)(70586007)(7696005)(508600001)(83380400001)(81166007)(36860700001)(36756003)(316002)(8936002)(336012)(426003)(82310400003)(2906002)(4326008)(46800400005); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2021 16:57:00.7030 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 98794f1e-bd42-4276-3e04-08d9ad0fefb1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1783 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Reflow some of the code now that the extra '_gpio' was removed. Signed-off-by: Joey Gouly Suggested-by: Andy Shevchenko --- drivers/pinctrl/pinctrl-apple-gpio.c | 69 +++++++++++----------------- 1 file changed, 28 insertions(+), 41 deletions(-) diff --git a/drivers/pinctrl/pinctrl-apple-gpio.c b/drivers/pinctrl/pinctrl-apple-gpio.c index a7861079a650..7299c7686f7f 100644 --- a/drivers/pinctrl/pinctrl-apple-gpio.c +++ b/drivers/pinctrl/pinctrl-apple-gpio.c @@ -75,13 +75,13 @@ struct regmap_config regmap_config = { // No locking needed to mask/unmask IRQs as the interrupt mode is per pin-register. static void apple_gpio_set_reg(struct apple_gpio_pinctrl *pctl, - unsigned int pin, u32 mask, u32 value) + unsigned int pin, u32 mask, u32 value) { regmap_update_bits(pctl->map, REG_GPIO(pin), mask, value); } static uint32_t apple_gpio_get_reg(struct apple_gpio_pinctrl *pctl, - unsigned int pin) + unsigned int pin) { unsigned int val = 0; @@ -92,9 +92,9 @@ static uint32_t apple_gpio_get_reg(struct apple_gpio_pinctrl *pctl, /* Pin controller functions */ static int apple_gpio_dt_node_to_map(struct pinctrl_dev *pctldev, - struct device_node *node, - struct pinctrl_map **map, - unsigned *num_maps) + struct device_node *node, + struct pinctrl_map **map, + unsigned *num_maps) { unsigned reserved_maps; struct apple_gpio_pinctrl *pctl; @@ -119,8 +119,7 @@ static int apple_gpio_dt_node_to_map(struct pinctrl_dev *pctldev, num_pins = ret; - ret = pinctrl_utils_reserve_map(pctldev, map, &reserved_maps, num_maps, - num_pins); + ret = pinctrl_utils_reserve_map(pctldev, map, &reserved_maps, num_maps, num_pins); if (ret) return ret; @@ -138,11 +137,10 @@ static int apple_gpio_dt_node_to_map(struct pinctrl_dev *pctldev, } group_name = pinctrl_generic_get_group_name(pctldev, pin); - function_name = - pinmux_generic_get_function_name(pctl->pctldev, func); + function_name = pinmux_generic_get_function_name(pctl->pctldev, func); ret = pinctrl_utils_add_map_mux(pctl->pctldev, map, - &reserved_maps, num_maps, - group_name, function_name); + &reserved_maps, num_maps, + group_name, function_name); if (ret) goto free_map; } @@ -165,7 +163,7 @@ static const struct pinctrl_ops apple_gpio_pinctrl_ops = { /* Pin multiplexer functions */ static int apple_gpio_pinmux_set(struct pinctrl_dev *pctldev, unsigned func, - unsigned group) + unsigned group) { struct apple_gpio_pinctrl *pctl = pinctrl_dev_get_drvdata(pctldev); @@ -186,8 +184,7 @@ static const struct pinmux_ops apple_gpio_pinmux_ops = { /* GPIO chip functions */ -static int apple_gpio_get_direction(struct gpio_chip *chip, - unsigned int offset) +static int apple_gpio_get_direction(struct gpio_chip *chip, unsigned int offset) { struct apple_gpio_pinctrl *pctl = gpiochip_get_data(chip); unsigned int reg = apple_gpio_get_reg(pctl, offset); @@ -211,17 +208,14 @@ static int apple_gpio_get(struct gpio_chip *chip, unsigned offset) return !!(reg & REG_GPIOx_DATA); } -static void apple_gpio_set(struct gpio_chip *chip, unsigned int offset, - int value) +static void apple_gpio_set(struct gpio_chip *chip, unsigned int offset, int value) { struct apple_gpio_pinctrl *pctl = gpiochip_get_data(chip); - apple_gpio_set_reg(pctl, offset, REG_GPIOx_DATA, - value ? REG_GPIOx_DATA : 0); + apple_gpio_set_reg(pctl, offset, REG_GPIOx_DATA, value ? REG_GPIOx_DATA : 0); } -static int apple_gpio_direction_input(struct gpio_chip *chip, - unsigned int offset) +static int apple_gpio_direction_input(struct gpio_chip *chip, unsigned int offset) { struct apple_gpio_pinctrl *pctl = gpiochip_get_data(chip); @@ -234,7 +228,7 @@ static int apple_gpio_direction_input(struct gpio_chip *chip, } static int apple_gpio_direction_output(struct gpio_chip *chip, - unsigned int offset, int value) + unsigned int offset, int value) { struct apple_gpio_pinctrl *pctl = gpiochip_get_data(chip); @@ -249,13 +243,10 @@ static int apple_gpio_direction_output(struct gpio_chip *chip, static void apple_gpio_irq_ack(struct irq_data *data) { - struct apple_gpio_pinctrl *pctl = - gpiochip_get_data(irq_data_get_irq_chip_data(data)); - unsigned int irqgrp = - FIELD_GET(REG_GPIOx_GRP, apple_gpio_get_reg(pctl, data->hwirq)); + struct apple_gpio_pinctrl *pctl = gpiochip_get_data(irq_data_get_irq_chip_data(data)); + unsigned int irqgrp = FIELD_GET(REG_GPIOx_GRP, apple_gpio_get_reg(pctl, data->hwirq)); - writel(BIT(data->hwirq & 31), - pctl->base + REG_IRQ(irqgrp, data->hwirq)); + writel(BIT(data->hwirq & 31), pctl->base + REG_IRQ(irqgrp, data->hwirq)); } static unsigned int apple_gpio_irq_type(unsigned int type) @@ -278,20 +269,19 @@ static unsigned int apple_gpio_irq_type(unsigned int type) static void apple_gpio_irq_mask(struct irq_data *data) { - struct apple_gpio_pinctrl *pctl = - gpiochip_get_data(irq_data_get_irq_chip_data(data)); + struct apple_gpio_pinctrl *pctl = gpiochip_get_data(irq_data_get_irq_chip_data(data)); + apple_gpio_set_reg(pctl, data->hwirq, REG_GPIOx_MODE, - FIELD_PREP(REG_GPIOx_MODE, REG_GPIOx_IN_IRQ_OFF)); + FIELD_PREP(REG_GPIOx_MODE, REG_GPIOx_IN_IRQ_OFF)); } static void apple_gpio_irq_unmask(struct irq_data *data) { - struct apple_gpio_pinctrl *pctl = - gpiochip_get_data(irq_data_get_irq_chip_data(data)); + struct apple_gpio_pinctrl *pctl = gpiochip_get_data(irq_data_get_irq_chip_data(data)); unsigned int irqtype = apple_gpio_irq_type(irqd_get_trigger_type(data)); apple_gpio_set_reg(pctl, data->hwirq, REG_GPIOx_MODE, - FIELD_PREP(REG_GPIOx_MODE, irqtype)); + FIELD_PREP(REG_GPIOx_MODE, irqtype)); } static unsigned int apple_gpio_irq_startup(struct irq_data *data) @@ -300,7 +290,7 @@ static unsigned int apple_gpio_irq_startup(struct irq_data *data) struct apple_gpio_pinctrl *pctl = gpiochip_get_data(chip); apple_gpio_set_reg(pctl, data->hwirq, REG_GPIOx_GRP, - FIELD_PREP(REG_GPIOx_GRP, 0)); + FIELD_PREP(REG_GPIOx_GRP, 0)); apple_gpio_direction_input(chip, data->hwirq); apple_gpio_irq_unmask(data); @@ -308,18 +298,16 @@ static unsigned int apple_gpio_irq_startup(struct irq_data *data) return 0; } -static int apple_gpio_irq_set_type(struct irq_data *data, - unsigned int type) +static int apple_gpio_irq_set_type(struct irq_data *data, unsigned int type) { - struct apple_gpio_pinctrl *pctl = - gpiochip_get_data(irq_data_get_irq_chip_data(data)); + struct apple_gpio_pinctrl *pctl = gpiochip_get_data(irq_data_get_irq_chip_data(data)); unsigned int irqtype = apple_gpio_irq_type(type); if (irqtype == REG_GPIOx_IN_IRQ_OFF) return -EINVAL; apple_gpio_set_reg(pctl, data->hwirq, REG_GPIOx_MODE, - FIELD_PREP(REG_GPIOx_MODE, irqtype)); + FIELD_PREP(REG_GPIOx_MODE, irqtype)); if (type & IRQ_TYPE_LEVEL_MASK) irq_set_handler_locked(data, handle_level_irq); @@ -402,8 +390,7 @@ static int apple_gpio_register(struct apple_gpio_pinctrl *pctl) } for (i = 0; i < girq->num_parents; i++) { - ret = platform_get_irq(to_platform_device(pctl->dev), - i); + ret = platform_get_irq(to_platform_device(pctl->dev), i); if (ret < 0) goto out; From patchwork Sun Nov 21 16:56:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joey Gouly X-Patchwork-Id: 518425 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 318B2C433FE for ; Sun, 21 Nov 2021 16:57:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238537AbhKURAQ (ORCPT ); Sun, 21 Nov 2021 12:00:16 -0500 Received: from mail-eopbgr60043.outbound.protection.outlook.com ([40.107.6.43]:30353 "EHLO EUR04-DB3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S238526AbhKURAL (ORCPT ); Sun, 21 Nov 2021 12:00:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QFPICHtkHnMBSClSkAJZJJpTW6ln/FJmJ/ZIiim4wzo=; b=yMDwa3qNWjJT8Lrwu5bbc3jd97PTfRHh4/bjTZsf8xhsZxrSlXMI4SguzY4y8G4wj3O28bSZVNAk/NaO4VwnC8iWel/PLgn3/0n8THfkjF3mjc92j6KNd/7jQfY3VWPH7wGL0ypBnuuXirkumlaIPy+mG0R9LFpl13U7O0uVY8g= Received: from DB6PR0802CA0039.eurprd08.prod.outlook.com (2603:10a6:4:a3::25) by VI1PR0802MB2415.eurprd08.prod.outlook.com (2603:10a6:800:ba::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22; Sun, 21 Nov 2021 16:57:01 +0000 Received: from DB5EUR03FT058.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:a3:cafe::6b) by DB6PR0802CA0039.outlook.office365.com (2603:10a6:4:a3::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend Transport; Sun, 21 Nov 2021 16:57:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT058.mail.protection.outlook.com (10.152.20.255) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend Transport; Sun, 21 Nov 2021 16:57:01 +0000 Received: ("Tessian outbound f493ab4f1fb8:v110"); Sun, 21 Nov 2021 16:57:01 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: b5b721d80d32296d X-CR-MTA-TID: 64aa7808 Received: from f91f43e61031.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C35C73CC-844A-4FD1-B818-739980378DEE.1; Sun, 21 Nov 2021 16:56:54 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f91f43e61031.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 21 Nov 2021 16:56:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aOoGBz/9Rs6kc/2FfNIUrELkqWXIUjBkzy8hCriOj3exaFa1P6Oz0zarODIfTO4jNJryE9z2masY/Kz0rja0fKmxmT77z8JFE/M4ZhzT21x0Sl06DhaDgOx4tt2tHAzdd93sWukEeEPiUv5bv9M469qoBxz4csvjm6HqFtC7+9hNrbbIBOz7TUzl5zIxnKOQWAqXERm1icv2qVRTTz/EziNOTi4yLeJff0x3tJNtQ3bCAyNoRbcyAWcsFLZR1OvuzlJAIWwgUsVuUgKQ1iWmQUOuhxaSmql2Jbvd8lD1izvcmYhFo/gU3waUYbod/kCTQU/cVncC2pioRQDPZ9W9Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QFPICHtkHnMBSClSkAJZJJpTW6ln/FJmJ/ZIiim4wzo=; b=emPk8XDpQIfZrg0dBeK3rF/pNEaH/0XrFVthMtKkbEFhHJh5G9ttBgimlmlYyFl5e2mwGHyMP57M2dUWuhCcnK3RM5sz8MQ+fBiVy2uY63D/F1qWVkeprQrGXAnFbvoqmT+xlihdz3+Ead+/edNvr6ph7sXDpWjqXbg/dju6/jBwdCozW92pQ9dJjUb01v3OxYtAkyvrQfJhKlI/5EkAioq6xm/cjJTFt5CZrPJmABtaMA7DyGLiSxFv4CzannLuMm0uzONiNisdmV3Gp6OVqPXVqmdXYcnAMgS/NNj8ysyoV6yRFZtuutnD9WMb6eWJlz/9thfH+heVB4OMTgMU3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QFPICHtkHnMBSClSkAJZJJpTW6ln/FJmJ/ZIiim4wzo=; b=yMDwa3qNWjJT8Lrwu5bbc3jd97PTfRHh4/bjTZsf8xhsZxrSlXMI4SguzY4y8G4wj3O28bSZVNAk/NaO4VwnC8iWel/PLgn3/0n8THfkjF3mjc92j6KNd/7jQfY3VWPH7wGL0ypBnuuXirkumlaIPy+mG0R9LFpl13U7O0uVY8g= Received: from AS9P194CA0024.EURP194.PROD.OUTLOOK.COM (2603:10a6:20b:46d::29) by AM0PR08MB4996.eurprd08.prod.outlook.com (2603:10a6:208:15a::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19; Sun, 21 Nov 2021 16:56:50 +0000 Received: from VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46d:cafe::8) by AS9P194CA0024.outlook.office365.com (2603:10a6:20b:46d::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22 via Frontend Transport; Sun, 21 Nov 2021 16:56:50 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT044.mail.protection.outlook.com (10.152.19.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4713.19 via Frontend Transport; Sun, 21 Nov 2021 16:56:49 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.20; Sun, 21 Nov 2021 16:56:49 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.20; Sun, 21 Nov 2021 16:56:47 +0000 Received: from e124191.cambridge.arm.com (10.1.197.45) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend Transport; Sun, 21 Nov 2021 16:56:48 +0000 From: Joey Gouly To: CC: Linus Walleij , Andy Shevchenko , Hector Martin , , Joey Gouly Subject: [PATCH v2 02/11] pinctrl: apple: add missing comma Date: Sun, 21 Nov 2021 16:56:33 +0000 Message-ID: <20211121165642.27883-3-joey.gouly@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211121165642.27883-1-joey.gouly@arm.com> References: <20211121165642.27883-1-joey.gouly@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 439a2ce2-5acf-4fc7-cf2a-08d9ad0ff045 X-MS-TrafficTypeDiagnostic: AM0PR08MB4996:|VI1PR0802MB2415: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:2803;OLM:2803; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: kLziGJe5cGJWJoxX0zW8L8QH8GHTKyLwfwusqhxXntlv6S7VZ+NorGfP3tC1rv3tSV2oofMsxhv9zxQvLMUr7WfiRyCx9YPqvP59NQ8E31X1ge7f/XV1iTJnsvY/PC3Gx0uRL9dq8QnhFzMk62BJ0eFiw+MnVVycTKIfnD2WHPfqYzhUwH7b0rD5zyO21KKqtKlFeMvuxLiKLgHKVa9hk48kAxKiPhdUbTf4OSAkN3mwVMBSSpKNkJnIaV03BnHQSHoKyiH2CeV7+GZTUBModWZW2BRDrJ39rwbzLuAyib2WTF8iyq6/EGZW/NDvqT6QxhySzahJ9M61zV7O6kyp7e+zW1JJqeXkBFsjligD/+3JoQogvcdIFsA6zG/m0EsoYayWd3SchCkJr3koYHjXvcoxEsGvbwWH2bhGvJ4S+yVQVz5prnb6qIu+ik+TeoJuoktINJEGLMoTeRP/dT85j2SQwRVwIaAHuqSaq4enRSJYanXxeupkmjKHHHWhNJwV8LKn1IkTsW95LdrYcQbp1vHGB74J3pVxP0F3RMANZwFpyoCujm3Zjh/o8E7QRp5YXaeXr1iSiJZ9TF9Q8e9dym/1/JKMlMDWGcFMlg+SfLi9gHzKNKOi7Ug/ejLKtJbb+E/Ns6nox/3g6Pss6jaUH2sqfBLnT8d4CuMNuylfmcs8OTLb4hjoEbi+PpFlKc6kBES9SnLLunWUj9ohIwGp1CIlUsRhNbGStS5yb5eIgvcxM+tNq2J/N/PeLc+FCR/Lgf6fRtqaHM1jOvm6h44/Lw== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:nebula.arm.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(4636009)(47660400002)(46966006)(36840700001)(83380400001)(2906002)(4326008)(7696005)(82310400003)(8936002)(36756003)(508600001)(54906003)(336012)(316002)(70586007)(356005)(1076003)(8676002)(186003)(44832011)(86362001)(36860700001)(81166007)(6666004)(2616005)(5660300002)(47076005)(26005)(426003)(6916009)(70206006)(4744005)(46800400005)(36900700001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4996 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 2a5981bf-f7cc-4d6c-2467-08d9ad0fe91a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: t8qY+9Vw+FzwpWgffcUQ8b8ChlO2oCjiicNq6ny2zwsuU12FuwOYnHkKY+FjIDTpdjilSjk8Qrr0Xzw3zlFt/kfSV29MDgI2g0x4uOAvuhycrXteYwzvXkM7dZkZWItKNDg2JjPg1gGKC8OSaa22FRqXI/X3Pnh/24LfCqnRZlDLvDx4A4BehNwnNyjNplnln386tBWc2VpkRgWV1Ea+n0RMFTOw2HfwR4pxXVgYH/jC4sfA4ioEKOMr2SdPv3BYRLx88zI8MmBppb2/D4iGOg5V0HAN/rIAFwItytOTRNdpDrZYCyOo03TICxcMnf+LF61gZJ+kIhfItpGcDVNtl6rI3oRoOgEViW+o+0oivi7Pn7kKTcB8epCT2X4UrUQvNQ5Dx6qzPeARTSyiVDUy8CLlbI/L8cN0xx3NxxQiaNFRLC1z4qn1E/hvI/DTZ3o6/ZJaTEJuovhNtidDqGj4mpRF2DjrAvewXEPi4ryrV8RJZ16AkG/4Cjir0HWrOiOLERiH0GGt7RJwJsun48biJzgKbS01ofeST1HYx31CW35VdvDxCajbsxRFShSCCL64UnOzeN+AcKyuUPE101zWRNxqYezR/gOoz0u73XMwzmEm4vLnkP0/EekK9lmerr5xmyFRpx3pCawQqQzhDn5c4dChg/tBPUoMusea8f/lWcYv6fCQX5s0XCudfirX2TI7d6C145mHMdeViKC44o9UzrP4dHO+p/xnGwciqwUYORI= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(47660400002)(46966006)(36840700001)(6666004)(7696005)(81166007)(70206006)(2616005)(83380400001)(8676002)(86362001)(54906003)(47076005)(508600001)(70586007)(44832011)(336012)(426003)(2906002)(36756003)(6916009)(82310400003)(26005)(4326008)(1076003)(5660300002)(186003)(36860700001)(8936002)(316002)(4744005)(46800400005); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2021 16:57:01.6777 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 439a2ce2-5acf-4fc7-cf2a-08d9ad0ff045 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2415 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Add a missing comma at the end of the regmap initialisation. Signed-off-by: Joey Gouly Suggested-by: Andy Shevchenko --- drivers/pinctrl/pinctrl-apple-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-apple-gpio.c b/drivers/pinctrl/pinctrl-apple-gpio.c index 7299c7686f7f..60d46ce26115 100644 --- a/drivers/pinctrl/pinctrl-apple-gpio.c +++ b/drivers/pinctrl/pinctrl-apple-gpio.c @@ -70,7 +70,7 @@ struct regmap_config regmap_config = { .cache_type = REGCACHE_FLAT, .max_register = 512 * sizeof(u32), .num_reg_defaults_raw = 512, - .use_relaxed_mmio = true + .use_relaxed_mmio = true, }; // No locking needed to mask/unmask IRQs as the interrupt mode is per pin-register. From patchwork Sun Nov 21 16:56:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joey Gouly X-Patchwork-Id: 517131 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3544FC433F5 for ; Sun, 21 Nov 2021 16:57:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238535AbhKURAi (ORCPT ); Sun, 21 Nov 2021 12:00:38 -0500 Received: from mail-eopbgr30065.outbound.protection.outlook.com ([40.107.3.65]:43878 "EHLO EUR03-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S238526AbhKURAR (ORCPT ); Sun, 21 Nov 2021 12:00:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+eGZuk+Xb+HpemmAuVHjavzTM4anDzutBBoa4FHvQUE=; b=0IKFqc+WJdH6DuUVlc56NCCvTqU/1gxKwfa2sVSQOrvmifGvZLdg4u4uO8wq+8XyVXkF0mQnpB+bJgfIp8KAvAkdNiigkCtd7Ep1R+XeatP4LS8eWj/tFqmF2iRYTAmDSjt1bWHP0ncXX/tHRnKBje9Lcb48MAHJQzCbMWz4//k= Received: from AM8P191CA0030.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:21a::35) by DU2PR08MB7374.eurprd08.prod.outlook.com (2603:10a6:10:2f2::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19; Sun, 21 Nov 2021 16:57:10 +0000 Received: from AM5EUR03FT057.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:21a:cafe::6f) by AM8P191CA0030.outlook.office365.com (2603:10a6:20b:21a::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22 via Frontend Transport; Sun, 21 Nov 2021 16:57:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT057.mail.protection.outlook.com (10.152.17.44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend Transport; Sun, 21 Nov 2021 16:57:09 +0000 Received: ("Tessian outbound 157533e214a9:v110"); Sun, 21 Nov 2021 16:57:09 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: aeb12fa0fe1f87d4 X-CR-MTA-TID: 64aa7808 Received: from c08544fa194b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 77B2EB94-E0B1-4F5A-9B01-35F4A17D5A56.1; Sun, 21 Nov 2021 16:57:02 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c08544fa194b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 21 Nov 2021 16:57:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KkoLQ74U0A1sixZ7b59+TeKBh+lF0+YrO4n6mWRgxOE53ngBYQefy5qCdGPjK8yC4Dg/XTiQLN0kxK1rahvlUnMpsuI5ovEME/H7SuN9E6WScTg/cjI6bkEJ4k2HhwDj0ZTEOKpwLY1FJ8GY0v3dYeIeEQbin6fFQckSgeer0l9TyQfI4jtuP5d5Je/8f3k/jGumHRgqH5Ii6DZ357OFVuNwnQZqojIhK++/E1QUmTBxC4A2m2I5ID9j11UjMOdC6s0NqVtw0IMcFUW3bTu0tbL5AlOQLvLWmx90GTgiBILXwkw2uUbjthIoYRs8yBOcJUCH8vpHcUvfYgx5aMtMzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+eGZuk+Xb+HpemmAuVHjavzTM4anDzutBBoa4FHvQUE=; b=RxRfaMUgnmz3GOylxccp2XZJjGH7yYllubzQF0rwMupKmGUwp3OK7Lly0xnCam0wzNlfPjk3dkmeDki1jG6oQxqtQ3C5NF+OaynZ/R2i2pRGmDNQSRyCyJj+IBOFr4+3GowYC6UJRmAR5gZze61RFnhWXfTz5GcuG/cCAK/6gYGMD7B23TO9oDDwEd5k4oLo5vbZh2QKFlnn6jKwr6ANWXW0AOq/PYgnYz5XQ3MyLCDdx/wEqV3h/3FwSCaYgjPVzkXP9mQ5B2m+TV+RPuzJtasSWpgDb8ZoIPscTZjOU98Z872oLpLYDSRD9oBW3SpAmvZusCTRChoU4pfm1ivYUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+eGZuk+Xb+HpemmAuVHjavzTM4anDzutBBoa4FHvQUE=; b=0IKFqc+WJdH6DuUVlc56NCCvTqU/1gxKwfa2sVSQOrvmifGvZLdg4u4uO8wq+8XyVXkF0mQnpB+bJgfIp8KAvAkdNiigkCtd7Ep1R+XeatP4LS8eWj/tFqmF2iRYTAmDSjt1bWHP0ncXX/tHRnKBje9Lcb48MAHJQzCbMWz4//k= Received: from AS9PR06CA0409.eurprd06.prod.outlook.com (2603:10a6:20b:461::18) by AM6PR08MB3637.eurprd08.prod.outlook.com (2603:10a6:20b:46::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22; Sun, 21 Nov 2021 16:56:53 +0000 Received: from VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:461:cafe::7) by AS9PR06CA0409.outlook.office365.com (2603:10a6:20b:461::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend Transport; Sun, 21 Nov 2021 16:56:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT064.mail.protection.outlook.com (10.152.19.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4713.19 via Frontend Transport; Sun, 21 Nov 2021 16:56:53 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sun, 21 Nov 2021 16:56:49 +0000 Received: from e124191.cambridge.arm.com (10.1.197.45) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend Transport; Sun, 21 Nov 2021 16:56:49 +0000 From: Joey Gouly To: CC: Linus Walleij , Andy Shevchenko , Hector Martin , , Joey Gouly Subject: [PATCH v2 03/11] pinctrl: apple: use C style comment Date: Sun, 21 Nov 2021 16:56:34 +0000 Message-ID: <20211121165642.27883-4-joey.gouly@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211121165642.27883-1-joey.gouly@arm.com> References: <20211121165642.27883-1-joey.gouly@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 30fe54bd-ac94-471f-4832-08d9ad0ff4ff X-MS-TrafficTypeDiagnostic: AM6PR08MB3637:|DU2PR08MB7374: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:1850;OLM:1850; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: BE0K8s7zC1ediQ66pAWnoLQw+8ZyKE2wtw39lnVxfeSjSMG/0Ywmlvebr6zOJHSN31bqFbAUvHbdq2B+83jlheSDqBPbug1F1jUNtigk1rzuE2wNZ7lhGW/4wW6oICfEgKiu9k/SrpGY7QzhoLPTxN5hv+vFoDszZ8qk+M8v5pn8owlwXLdylOSNGJRFLaRHWgqUmtbXhQg+9TvdlGD1PlplIgpP3iqKXQoWiajL7sr5yvDPeROAel4XxgutiW7xRHCSwS3iyow6wZy7Z7CV1ZUGT31yKg5t1mGOvNneIum+29LrtaFqYuLJG+peh2YbwxkyyTEb3GHjMbNXVCv3x2L2a3/aO9JngB80hSk/ARRcGKSlX5GAiN6iJgSaoVY+QjNynxndaOkltdwoJjG1Bf4e0RY+d4gYy/+iQeSkmpieS5XmjfQe3mkwxOqMGb6yrbFNAWVvWUN21lKG52mAi01QTcKCP5g3IsZ7WVNDLnGEzVB2JNwJ205C4QoRnw1kzYZsChytI9dQmO6aY7U8CDntTxTblCWl7M+OV+QQRvnPILehzPxUsFiIBXGNHqQXD4THX2BvC/R9iEEuLha34P/KaKbxKIrFnvwx7vV7UsbJyFvpYO68jEwEV4IoMkLSMwmtfZmF37MFTiujIr+x9vLGhyhWkBQ72LXIozPwStpFNelKpPiQNBISXOijCTah1ts5ug2Q9bHebgnEA51O77jya/qRHQgPlMij9NOn21nPzBHH2RFIkzN0MKOESahketjVOh8r6sX7ag7iGkFp2A== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:nebula.arm.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(4636009)(47660400002)(36840700001)(46966006)(1076003)(81166007)(508600001)(7696005)(83380400001)(82310400003)(336012)(5660300002)(186003)(54906003)(70586007)(4326008)(70206006)(4744005)(8676002)(2616005)(6666004)(356005)(86362001)(44832011)(426003)(36860700001)(316002)(8936002)(47076005)(2906002)(36756003)(26005)(6916009)(46800400005)(36900700001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3637 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 4c3eafcd-f1ba-47f6-52c0-08d9ad0feb48 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l0nKfpX/09ec6x8RqNF4dAG5ZmgQEDp09qRMzEsWO8rbDb6hPvOpaw9npUka3jxlsBHDF1heMJgSO9Vop0ZQpMx4XDbGE1sqV4S2IZfNQY4pswbS5kDLqwNEzfqoRazd8dTJAqmzUMF4B1staeIO5KsUrUxuCIhhh2ol7tIqQNrrLZsYeXcAfxJ0yvRWPUjgeBp4BHjX+6598soy9+Z/4YDMKKQj2LoLYmhgooKFyhN4dcM9kg6NCZxgD27CmzMsXa1VsrTsX8yoYxlrLhAwiMcQquTcLimHVbUm2Rfj6WwUp2A1x6R6n+tc1CcpVU41iHrkYx3kGvkMLrpIGU8wIS8LZMtSbd+eC4UE4wXf/I6pKHDuGLb4gB1zq4dDZhKo0GhBU6KSW0Y2hHMwhyYJ1BwHEmS2vXTtPrPdleLpio9djNZ+x61esZAnx72iAMnx/3HH2OuoOB3nyYasOo7eg5Zo3/I7D2x57fK+jZlL/ovbB6mmEb3yMO2j4JHfYc05xha8WN6qnfESQ18hfxHjHpDIqK4u9W4U4b4HxjXBZ0Y6oWvzq8rXkgNL0lmCS8VEVbhuAvpgdWU6G++o7ezSKumq0SSQx7p5/LYO2zQNZGZQp03F8eOjyMi2qE7ZLe/nzXbXWw0Ok4f+odkXQnElUHKXqaMH0E1fGdTJrL3MPxa/lPwR3X8fwpgSw7dhbEPc48ygve7N3bzcGKXn7qdggEH3NOfmy9Ah7wXEnvL4uv8= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(47660400002)(36840700001)(46966006)(70206006)(70586007)(1076003)(6666004)(36860700001)(508600001)(54906003)(4326008)(2906002)(316002)(7696005)(8676002)(82310400003)(426003)(26005)(6916009)(81166007)(336012)(186003)(47076005)(86362001)(36756003)(44832011)(8936002)(5660300002)(83380400001)(2616005)(4744005)(46800400005); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2021 16:57:09.5551 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 30fe54bd-ac94-471f-4832-08d9ad0ff4ff X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB7374 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org This is the preferred comment style. Signed-off-by: Joey Gouly Suggested-by: Andy Shevchenko --- drivers/pinctrl/pinctrl-apple-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-apple-gpio.c b/drivers/pinctrl/pinctrl-apple-gpio.c index 60d46ce26115..102940058a11 100644 --- a/drivers/pinctrl/pinctrl-apple-gpio.c +++ b/drivers/pinctrl/pinctrl-apple-gpio.c @@ -73,7 +73,7 @@ struct regmap_config regmap_config = { .use_relaxed_mmio = true, }; -// No locking needed to mask/unmask IRQs as the interrupt mode is per pin-register. +/* No locking needed to mask/unmask IRQs as the interrupt mode is per pin-register. */ static void apple_gpio_set_reg(struct apple_gpio_pinctrl *pctl, unsigned int pin, u32 mask, u32 value) { From patchwork Sun Nov 21 16:56:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joey Gouly X-Patchwork-Id: 517133 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83271C43217 for ; Sun, 21 Nov 2021 16:57:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238623AbhKURAS (ORCPT ); Sun, 21 Nov 2021 12:00:18 -0500 Received: from mail-eopbgr50078.outbound.protection.outlook.com ([40.107.5.78]:19958 "EHLO EUR03-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S238545AbhKURAL (ORCPT ); Sun, 21 Nov 2021 12:00:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wp5HqfCaAbSrUfefJmELb4c8DbxDgGsFv5E06WPcupc=; b=KkIAGKQ66FRWJgg2McNK/mSsoro1fVRavTu0xkBpAG+44Rmvy2IlusxtfAkZFih+Q3L39d3HMHrlz+fcu06ZjqcCqyQgDPXwVEnwx3lwK1Ytol9ZXtsyMwzBqp/ehtXqvjMWAR+IeP3saxtDUV2KaSmaDqvU+A0YpI8jyAnK8eo= Received: from DU2PR04CA0282.eurprd04.prod.outlook.com (2603:10a6:10:28c::17) by AM6PR08MB5288.eurprd08.prod.outlook.com (2603:10a6:20b:ac::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.24; Sun, 21 Nov 2021 16:57:03 +0000 Received: from DB5EUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28c:cafe::89) by DU2PR04CA0282.outlook.office365.com (2603:10a6:10:28c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.21 via Frontend Transport; Sun, 21 Nov 2021 16:57:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT052.mail.protection.outlook.com (10.152.21.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend Transport; Sun, 21 Nov 2021 16:57:02 +0000 Received: ("Tessian outbound 157533e214a9:v110"); Sun, 21 Nov 2021 16:57:02 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 14f6395a48fad051 X-CR-MTA-TID: 64aa7808 Received: from 414e3ec333ee.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CF25309C-31EF-4512-8A2A-662999D9AE7E.1; Sun, 21 Nov 2021 16:56:56 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 414e3ec333ee.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 21 Nov 2021 16:56:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e5ARUCKjWFubjJA38s/VVgpyyYvoVQhskfw5VGssDgdejGTHGbqX9UL7u4f27y9HKcEP2foXql4EBJQ4402uueYyyY+ReDtxKZV1h9z9/OlGfKd4c48zsz0SjTLdfsdKtUOuzdDMwG7nygFiqagbx+Q3weLlCBObpivwfp8C4keXv7jzl1f6dEWBlRLWO5lz+dGM6OF3/xKM+vqIrtquy2rT2H9wFgd+1pFS+bJtfdKK2EoRDY0fTZ3PNyKgMgVfcEFgEg+n2i6xyladku21SsvhML76VN7hxZa5SsgbPgswt02zf+MJ4ROaytmo+eYGEIcAkRLu7UpJfnMqrVp6qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wp5HqfCaAbSrUfefJmELb4c8DbxDgGsFv5E06WPcupc=; b=dT/B8PiDxoZMEeoY0zDiECa4ds52PwCHTPhz6mNJkzquHKUVy3oCv0srCNViDbpb6l9ZlZvIE5lSReZGZgLfdM6YFYBnNApVJ12oLOWf+ekwdSM21/qGpz8iA/zExdufq2LPK3CMtSHfiSb000Qn0s8EpYKmhq6uhhSDnX1azlXrP4IYIX2xbyvCyyu+KB4cLR59o9ggaOxpQqbn3putynRLai4mnG+GkHRn+ZQNr2mNHZ1z1bhTD0kyFgmhDj0pF9rxYJLo53R3spFKPGnVoQyk5gU+rDEMhzPMOEpeuOMaTLqigNklNLJDcG9psRcru2D4eLuG3vPMFFgedoOUUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wp5HqfCaAbSrUfefJmELb4c8DbxDgGsFv5E06WPcupc=; b=KkIAGKQ66FRWJgg2McNK/mSsoro1fVRavTu0xkBpAG+44Rmvy2IlusxtfAkZFih+Q3L39d3HMHrlz+fcu06ZjqcCqyQgDPXwVEnwx3lwK1Ytol9ZXtsyMwzBqp/ehtXqvjMWAR+IeP3saxtDUV2KaSmaDqvU+A0YpI8jyAnK8eo= Received: from AS9PR06CA0412.eurprd06.prod.outlook.com (2603:10a6:20b:461::6) by DBBPR08MB6026.eurprd08.prod.outlook.com (2603:10a6:10:1f6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22; Sun, 21 Nov 2021 16:56:55 +0000 Received: from VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:461:cafe::d8) by AS9PR06CA0412.outlook.office365.com (2603:10a6:20b:461::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend Transport; Sun, 21 Nov 2021 16:56:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT064.mail.protection.outlook.com (10.152.19.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4713.19 via Frontend Transport; Sun, 21 Nov 2021 16:56:54 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sun, 21 Nov 2021 16:56:49 +0000 Received: from e124191.cambridge.arm.com (10.1.197.45) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend Transport; Sun, 21 Nov 2021 16:56:49 +0000 From: Joey Gouly To: CC: Linus Walleij , Andy Shevchenko , Hector Martin , , Joey Gouly Subject: [PATCH v2 04/11] pinctrl: apple: add missing bits.h header Date: Sun, 21 Nov 2021 16:56:35 +0000 Message-ID: <20211121165642.27883-5-joey.gouly@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211121165642.27883-1-joey.gouly@arm.com> References: <20211121165642.27883-1-joey.gouly@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2f65803f-2a6d-42f1-bc3c-08d9ad0ff10c X-MS-TrafficTypeDiagnostic: DBBPR08MB6026:|AM6PR08MB5288: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:2449;OLM:2449; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: sCtbJFMKHG2Bx+Df/ZRF9ZqLJ3AHpPgUa5ZBjQcDkjADWUE0OwLP/0toHzSbWE1RXpWhMUjpm481cyrVl9SDicXfCsSTYdWcMuhQKNOXrdvPAHq84CqeZsuebwIvVWf0RN7JaUcdpo4/h26YcZBAymi4NpKn8yJ6sZ8pLq/bGBm4kkWnPJ54JUuXxmBgnU6u84bGVQ4a2FNXoKR+JOPTomDxhyvFvDV027c+p+/4Qga3PcLma4OdGbA7bdFEzW41m4kFl98DRpoul71c1gZkZGWr34igBghGMIScP7TCv2O2HoeC+3y9/eRFYjsGHtH1EMDzRKkTo4vHEufNRlKeZEn8sUVCeaNrCaYstCRRTzGmxJFTqqy14IwsdFNRU7VvfLZ9WF4UpJS/v7CH9c3egEx7Yo7E05WxHENAULk4TL1LoJtFm7OLD5L3saY/6PKNN6oY+G4wWPJaFsZW+08rb7E44HdrkqazQsR2m1p/fJUOnydhVYI4sdNymDx6AP/mIbR47r/jN99yqOPCKPqQ4gQLMTIfMMOS1NEQL2KiqiM2X2KR8igfxD59U1RZGzJpF8faKHkiCJ/CSysNP47x/YZP1n3FXjI3Pljgl0YxtOcfCvGLAPbKBtAlOuOabc8kQCuaYXdtz6GKwoyRYW/WlpmYotmG01ZxRwWQeEI3lhcfAKXm9Xm4QkcWRq11OHhGNsT9M6ejQDgKup7JFu9XSaw6xJQ3Zca9uYCkJkW/EvQdgFy6rZIQUs3tmVqVhi0WHDX14u4NNu8OTAHgdcE/6Q== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:nebula.arm.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(4636009)(47660400002)(46966006)(36840700001)(44832011)(4744005)(70586007)(36756003)(70206006)(2906002)(6666004)(7696005)(47076005)(4326008)(8676002)(8936002)(36860700001)(81166007)(2616005)(336012)(426003)(316002)(508600001)(86362001)(356005)(54906003)(5660300002)(186003)(1076003)(6916009)(26005)(82310400003)(46800400005)(36900700001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6026 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 53f71b19-ef1f-43ae-40cd-08d9ad0fec4c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: os8TlSWYb6eTYX4iz3iNUC78OQZSmiXQElTZHy5yOrUup97Nmwlde+Z9m/ad2/PkulP5oA+2BpuBpbaQ8LPuGNi0R6IERUJ05wYYr+EEPdq6HQdR98qrPeZGYvzMUee3mulFGWUDkDn/sZ4Kyb+WCuQFSH2ig4wKRBDB2vE07dnBu89qeXNUqSSfsmf6KMHbpHh0P+jqPa7fv5DW2vmwOsCRisb2vQBBR8KNorJvnef7x8fxThC0JFS5Qi1T990rMLvrsuEbkstS86UnZuS+1Q/UdfccSZlepgDZ1JQkEl5qMsX0cfjhqQ3igRLCsjUfAxl6P4zkloFEXoaTYljLc1/Br6OX/iuK5Ln6cYgYGKx9KeMKaWpESEJS8L0ZQViDvo9N5FHgIF9mpZcRz6U1YrqDi6pFECgkVzhdX0rmV2ctxSbSlQm18JhZHRz35vE1CkHFO51i9cmhDukRq3qXviTUqRZpjvs4OGg04X2vgGei30roLdZi0ABiHMGvxZjeOHtjRsz2DBaa+bptCIBpSFxEy1N5guwFzCm6EtLeqntaYV37Xnl7PcQ3lJUl9P8LoVlGTI4JLTCllek95vpbzbEbJF+qKzq6JxZ0k47sGlch+1O3/Jq82uF/NijMsbb+ElUcbPyYYlQyLn0MtkvcSgoy0AR5GvlM+R0ukP6PEQkElM3TO5mAWTzha7F4mNFG3TS4kq2dtyXgPkMf5HijiOO4XbwggJ/6JVwJrHR9gpY= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(47660400002)(46966006)(36840700001)(4744005)(36756003)(82310400003)(70206006)(1076003)(70586007)(7696005)(5660300002)(47076005)(186003)(2616005)(336012)(86362001)(6916009)(316002)(4326008)(426003)(81166007)(26005)(6666004)(44832011)(508600001)(2906002)(54906003)(8936002)(8676002)(36860700001)(46800400005); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2021 16:57:02.9814 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2f65803f-2a6d-42f1-bc3c-08d9ad0ff10c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5288 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org This is needed for the BIT(n) macro. Signed-off-by: Joey Gouly Suggested-by: Andy Shevchenko --- drivers/pinctrl/pinctrl-apple-gpio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/pinctrl-apple-gpio.c b/drivers/pinctrl/pinctrl-apple-gpio.c index 102940058a11..cce95367c156 100644 --- a/drivers/pinctrl/pinctrl-apple-gpio.c +++ b/drivers/pinctrl/pinctrl-apple-gpio.c @@ -11,6 +11,7 @@ */ #include +#include #include #include #include From patchwork Sun Nov 21 16:56:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joey Gouly X-Patchwork-Id: 517132 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4325C4321E for ; Sun, 21 Nov 2021 16:57:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238701AbhKURA1 (ORCPT ); Sun, 21 Nov 2021 12:00:27 -0500 Received: from mail-db8eur05on2052.outbound.protection.outlook.com ([40.107.20.52]:50272 "EHLO EUR05-DB8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S238483AbhKURAJ (ORCPT ); Sun, 21 Nov 2021 12:00:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C0GbkqjVNt8L+Bhy8DKrHaU5MAwNQ4JHyrb4FGund2M=; b=ncoT/GKf/KF5tBFF6EuhB8Iqq6+Dcea4enHLiI+LSxx6Ue/j+ihXmR+d8lpt0+wtZS25M+rlhW9NNZRy618garvjN5tnkPiF9XuOzyzLpO+N/U4y7pmFSfV8mBYfBgPKdr05Kw2OPxWnrLTxMk36/BMjlAM6oOCq4zSPSrxlUBk= Received: from DB7PR03CA0097.eurprd03.prod.outlook.com (2603:10a6:10:72::38) by DB9PR08MB6444.eurprd08.prod.outlook.com (2603:10a6:10:23c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Sun, 21 Nov 2021 16:57:02 +0000 Received: from DB5EUR03FT015.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:72:cafe::9) by DB7PR03CA0097.outlook.office365.com (2603:10a6:10:72::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.21 via Frontend Transport; Sun, 21 Nov 2021 16:57:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT015.mail.protection.outlook.com (10.152.20.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend Transport; Sun, 21 Nov 2021 16:57:02 +0000 Received: ("Tessian outbound de6049708a0a:v110"); Sun, 21 Nov 2021 16:57:02 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 7186051f8a569db1 X-CR-MTA-TID: 64aa7808 Received: from fd8123f6f4e2.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FBB3281F-D664-4B89-A434-DA262C299071.1; Sun, 21 Nov 2021 16:56:55 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fd8123f6f4e2.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 21 Nov 2021 16:56:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lphmdM6hYBM2bAVIZtktmGip2PHPSdsIfdm73Pl61UVrKCvDpBPil0x/WwyjD8i63XfdWBHuNrz6cN/9x6GYYZlqYMkriaaNu2CmAkBrinKeOLaDhGijxO8/HcpgT7n11g1saii8bR2EEGm3SA2Dxn8L1vRLerAl+iQPA+vPhVKUuyi5YxXgNWJzdAp+Gt435BKpH6DTKvu9LqferXBz6nC8Xke0bhr0eNII46wLtI45UztolZ6Cj3zOLsfbj5QD3ais4pFh/WEKgOECV7nNE7hYsTAc3qP7ArANLA8kwu7R8F7VZGhiEC+LqZKD3wHNxB5txNTvohjhFu7lxAMabQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C0GbkqjVNt8L+Bhy8DKrHaU5MAwNQ4JHyrb4FGund2M=; b=VkL2gpHC9LofLqP88LulDv7oVhDY2efHigCFSDQxrHtHgdnNg52k9U4/zc9+tIeKns32iJfHrZvDJg4RVXYbU0FG7T+1IANP/QMpNM81oBF+01LZVd4NaI29lrLe+dut8YTuidcsqNXpvwjOQ1l849QOD6hpdfOXI2QuJdkiaG0bugygRO0yHy1o0nAQKkIPNnmLn/IxI1lQTzPm8uuN54Xue8KA9hNgYENZOlbv+56wkTN+2SjK1CobAdCRx/sCuQsot39clqTi1Ctgxiy6r3F92K2d2iArEJcSPKPhr/+6RQV2PXLOSNvWiiXfiZOnzasWfiqchNBPvDVcWUbx9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C0GbkqjVNt8L+Bhy8DKrHaU5MAwNQ4JHyrb4FGund2M=; b=ncoT/GKf/KF5tBFF6EuhB8Iqq6+Dcea4enHLiI+LSxx6Ue/j+ihXmR+d8lpt0+wtZS25M+rlhW9NNZRy618garvjN5tnkPiF9XuOzyzLpO+N/U4y7pmFSfV8mBYfBgPKdr05Kw2OPxWnrLTxMk36/BMjlAM6oOCq4zSPSrxlUBk= Received: from AS9P194CA0010.EURP194.PROD.OUTLOOK.COM (2603:10a6:20b:46d::10) by AM6PR08MB3926.eurprd08.prod.outlook.com (2603:10a6:20b:a7::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.21; Sun, 21 Nov 2021 16:56:52 +0000 Received: from VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46d:cafe::77) by AS9P194CA0010.outlook.office365.com (2603:10a6:20b:46d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.24 via Frontend Transport; Sun, 21 Nov 2021 16:56:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT044.mail.protection.outlook.com (10.152.19.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4713.19 via Frontend Transport; Sun, 21 Nov 2021 16:56:51 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sun, 21 Nov 2021 16:56:49 +0000 Received: from e124191.cambridge.arm.com (10.1.197.45) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend Transport; Sun, 21 Nov 2021 16:56:49 +0000 From: Joey Gouly To: CC: Linus Walleij , Andy Shevchenko , Hector Martin , , Joey Gouly Subject: [PATCH v2 05/11] pinctrl: apple: handle regmap_read errors Date: Sun, 21 Nov 2021 16:56:36 +0000 Message-ID: <20211121165642.27883-6-joey.gouly@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211121165642.27883-1-joey.gouly@arm.com> References: <20211121165642.27883-1-joey.gouly@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bfbf8cbb-45cc-4260-5296-08d9ad0ff083 X-MS-TrafficTypeDiagnostic: AM6PR08MB3926:|DB9PR08MB6444: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:1051;OLM:1051; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: /CtHGXuG20U249vpQRUKfeZF24v9jcJ47pgQ2b0bQHuVcMiPs6ogND8lPP3BVroUTgfRJvH12MW/rcRH19zofnE0ryq81DErBbCEnQNdFzmgK/RHzckPPBwBFVGAImmddIP+b4RseePP2NzL20f7d1Kf+EyGq5IohF26VMfZpJsV3Fv9K7kahMlmUfKSnHycQQ5CKdK2mVbcU7RTBLraRyu3Rb2Uh0F1qKf5skxzvyV3RVDkf3E5T7LNM1cEhr1/ZfdoPlopdOGPTn6LAet0Rwn0SZTH/4hrHZu7BQYm2Bu3LQQ29cPe1DyzJuR0RPmjY3w6US4pGIawSK6gT6WmTNlH1dLsncjyKOD5cSI/7USRvdqzXDzcN00CnZFvZBz4EYZISr+l+4buRmXmke3sok2L4Iu07aLagjHouvDgtKbi69rxKMwKpGoVdTeIPZIfoEqcnoFtHUMPYXivJWaNx7DLo9kJzm/tiHBoIjczFTga53c2+Jb/Xyy0s7EicjQb4T7S/UskVJmVOIzR6VbOkIoCUSk/1Fti0nQYt2H/vtVhvDHAMQs+I7linXzoVnAhAdVl2Pox37egNvlwwI8j2mudTomaqKSDwfUgvmdzLPZFIxsKuHFsIe2a1uVXoz3KuSMYM8CzuleOfMxx/by/IhSoi1fQHqPz6g1yX1V9dI4cCQ7k7UZMw/ReshFh1b454lLnYeNu0MetM4zk8rH8BEkLYdHHM7QGSQeLMKuJ96RwEMUIArsnoNGCACQmH+zX5R9iugkuPnSKtvx/6X5NdQ== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:nebula.arm.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(4636009)(47660400002)(36840700001)(46966006)(6916009)(47076005)(186003)(81166007)(82310400003)(8676002)(356005)(2616005)(316002)(44832011)(426003)(336012)(86362001)(36756003)(83380400001)(508600001)(1076003)(54906003)(2906002)(6666004)(36860700001)(26005)(7696005)(70206006)(4326008)(5660300002)(4744005)(70586007)(8936002)(46800400005)(36900700001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3926 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 94a16d9e-a3e6-4c8d-0f97-08d9ad0fea7b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: //EbJEfGFs4slbXa0YneUt7ngExyjZf4G5h0E1IELLMxxeP+mLuRrmAzh2UVPQmM1IkTLDn+/sSdIoBqLGlXcEJf2FSWQbFCFdeLExjDyP/iTJ99co4Ed1BPzbrMqKwkeHNSVRdFO5mzT4QpL31w/vKJT7Wfjca4gGuBpCvcX46wUaAGvcaTgv9MVrQb65EuRas66bnBBvWDqX4vhezClezsg2pPxx5/hUnTfe9BmwFVL79xgRya5d3EgN/Rc20CJRCfJcoHi/nwqx6qT//AlsB7BowQT7/xNQ2FjvE4LPbqnKTdESmFe1iG8dGRB2EByh/m9tBwPd4Xhuxb+6l0n4aAu/76mo8HS/cnGZ/kiHiZDf6jFpRlrprKSh/VCbZuNpTdoZKJVedp444P7hne5LVDxnm4Co00lmNAQEBIr3GyEusWqWNfXm3xGloeYJW9PQPr+xPVogOW8MtaiqHH7Ty9Do90ZYLQAjEBGDv8FTMJ5ZX9d7ipSmGZQRbGibuyjWCNGXoyzBJGg0/BcR4senlqhWpRfDsZc1GBTmXLxSnk1id4kx4IQIusnx1DqszLUBLHbGa995K2vqXW1GS/R4lLS38MN3vTS3yOrAxHaDOUxnXp206nt2H3yQXqd2HqYFvFH4UbLCWRn0FOfCSzsgjHmGXYhB3SycxIV8xFSP8fDiVw+gjGfGDQvf7JhUeFlBJPSi8mljns3wMX3vkVcW63m/XjAFIOA6YAbmjj+qA= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(47660400002)(36840700001)(46966006)(508600001)(4744005)(1076003)(4326008)(70586007)(70206006)(86362001)(2906002)(82310400003)(6916009)(2616005)(47076005)(316002)(44832011)(336012)(36756003)(186003)(6666004)(8936002)(8676002)(83380400001)(7696005)(5660300002)(81166007)(36860700001)(426003)(26005)(54906003)(46800400005); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2021 16:57:02.0803 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bfbf8cbb-45cc-4260-5296-08d9ad0ff083 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6444 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Explicitly return 0 if the regmap_read fails. Also change a uint32_t to a u32. Signed-off-by: Joey Gouly Suggested-by: Andy Shevchenko --- drivers/pinctrl/pinctrl-apple-gpio.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/pinctrl-apple-gpio.c b/drivers/pinctrl/pinctrl-apple-gpio.c index cce95367c156..bd7f28150ac0 100644 --- a/drivers/pinctrl/pinctrl-apple-gpio.c +++ b/drivers/pinctrl/pinctrl-apple-gpio.c @@ -81,12 +81,16 @@ static void apple_gpio_set_reg(struct apple_gpio_pinctrl *pctl, regmap_update_bits(pctl->map, REG_GPIO(pin), mask, value); } -static uint32_t apple_gpio_get_reg(struct apple_gpio_pinctrl *pctl, +static u32 apple_gpio_get_reg(struct apple_gpio_pinctrl *pctl, unsigned int pin) { - unsigned int val = 0; + int ret; + u32 val; + + ret = regmap_read(pctl->map, REG_GPIO(pin), &val); + if (ret) + return 0; - regmap_read(pctl->map, REG_GPIO(pin), &val); return val; } From patchwork Sun Nov 21 16:56:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joey Gouly X-Patchwork-Id: 517134 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51F8DC433F5 for ; Sun, 21 Nov 2021 16:57:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238568AbhKURAN (ORCPT ); Sun, 21 Nov 2021 12:00:13 -0500 Received: from mail-db8eur05on2063.outbound.protection.outlook.com ([40.107.20.63]:54432 "EHLO EUR05-DB8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S238518AbhKURAJ (ORCPT ); Sun, 21 Nov 2021 12:00:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YQD4j2KnCJYZjzbJvcpobqwhP4W10Rfn95HcUHz4WtY=; b=NgZerzgfINzk/BWxGW5ujAY9SQJYWQQ7ZSnOnIAtjK4TLLncg68R6G+1xxGZoqVyYRJ8vhV98IvBOv3DqEAdm5dTwBJMq3aDOtdn+m23Yu4FRl9Gi4Ul/K4ZeWL2GMPgzp9M63yYQiqlMekFoJeDqruCH3+0Tcd6rB6tb71IJL0= Received: from DU2PR04CA0211.eurprd04.prod.outlook.com (2603:10a6:10:2b1::6) by AS8PR08MB6662.eurprd08.prod.outlook.com (2603:10a6:20b:397::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10; Sun, 21 Nov 2021 16:57:02 +0000 Received: from DB5EUR03FT038.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b1:cafe::bd) by DU2PR04CA0211.outlook.office365.com (2603:10a6:10:2b1::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend Transport; Sun, 21 Nov 2021 16:57:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT038.mail.protection.outlook.com (10.152.21.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend Transport; Sun, 21 Nov 2021 16:57:02 +0000 Received: ("Tessian outbound a33f292be81b:v110"); Sun, 21 Nov 2021 16:57:02 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 410c70dce73f1282 X-CR-MTA-TID: 64aa7808 Received: from 4cd0dd711efb.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 45D927EA-7757-470D-9FB4-370DC2E21504.1; Sun, 21 Nov 2021 16:56:56 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4cd0dd711efb.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 21 Nov 2021 16:56:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cjWVC4BOVIP2MSMfB8th0NXF+j32kICdMlJ8Ol5E5pkXotbOXjg5QPZoe/kqyBedFpxwnVIoqqcoans+QxtLUxjJ02zJN2HU811M4pRWpx4W/S1F76vt5NeE/R0qQPuu/xZ1fInEhnWqcaTDsbLby9p8tVPPERRU2LWb1lxac7ZRHIXc1ZmO511wFYYrAEJDwE2jAnL8cAQVJANj+nIo5tIKwR7IDS0PrgO/p+UfI2boiWLcccoN9q4DgIAq/AgZ5aQRNDiYrW16WNOoPO5IjJiBFMJXVSni3i99piNHOKxZm+xgRG3PUtA4IoNSeYeqbEayWq1qR3B8t6gDtXBMWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YQD4j2KnCJYZjzbJvcpobqwhP4W10Rfn95HcUHz4WtY=; b=Bb5YPIaeRVoaZVdwhBB8kVXbOBrTQUWdJ8QyuswIw0pL0tiwF/1jQeBelSFrWfkisgAR1ORf252JBHKCAYd8+Lc6nJR1A587YjRM4xbc0ASyadpbxbNZORG5zSSCW7o+ndK7w81G+WNKaVMnqrW/5ApSsWK2saD+YQHh0gw34NS8e3x3FJ/CF3Tr+XVaUrD2gyXhCZEfqDCrocTxGGf4SE6UFiMfKS3BBXUn/ZVsDq0Cg9DvNl28A4s1XOORZqnrr4vlXDWNCP/CJxIBlG0ju7eP0r3TbUTanSHSDWR4vnacPPZozDbttxi8JIYvshD833eX+mFlbwNy1mgwmNv2XQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YQD4j2KnCJYZjzbJvcpobqwhP4W10Rfn95HcUHz4WtY=; b=NgZerzgfINzk/BWxGW5ujAY9SQJYWQQ7ZSnOnIAtjK4TLLncg68R6G+1xxGZoqVyYRJ8vhV98IvBOv3DqEAdm5dTwBJMq3aDOtdn+m23Yu4FRl9Gi4Ul/K4ZeWL2GMPgzp9M63yYQiqlMekFoJeDqruCH3+0Tcd6rB6tb71IJL0= Received: from AS9P194CA0004.EURP194.PROD.OUTLOOK.COM (2603:10a6:20b:46d::32) by VI1PR08MB4304.eurprd08.prod.outlook.com (2603:10a6:803:f2::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.24; Sun, 21 Nov 2021 16:56:54 +0000 Received: from VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46d:cafe::2e) by AS9P194CA0004.outlook.office365.com (2603:10a6:20b:46d::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22 via Frontend Transport; Sun, 21 Nov 2021 16:56:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT044.mail.protection.outlook.com (10.152.19.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4713.19 via Frontend Transport; Sun, 21 Nov 2021 16:56:53 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sun, 21 Nov 2021 16:56:50 +0000 Received: from e124191.cambridge.arm.com (10.1.197.45) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend Transport; Sun, 21 Nov 2021 16:56:50 +0000 From: Joey Gouly To: CC: Linus Walleij , Andy Shevchenko , Hector Martin , , Joey Gouly Subject: [PATCH v2 06/11] pinctrl: apple: make apple_gpio_get_direction more readable Date: Sun, 21 Nov 2021 16:56:37 +0000 Message-ID: <20211121165642.27883-7-joey.gouly@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211121165642.27883-1-joey.gouly@arm.com> References: <20211121165642.27883-1-joey.gouly@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c4edbc0a-c916-4c4d-6eca-08d9ad0ff0dc X-MS-TrafficTypeDiagnostic: VI1PR08MB4304:|AS8PR08MB6662: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:494;OLM:494; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: sfH65GGgDCzTpKJ3dbfHypz3YOzfz8xdXwQPQqd5Xr2r5bPevaY1eIWaIAn7deNSbzHoxb0U3n8+pyHW/Q3sHQ35clWhPkUitUgAaW9qbm945g/CJHD7gvcp5GDrtyWiCyjoj6eb5ip7jDutlUA55bNDPEk/q/X5QV+F3jHDSYSZV8Koj75iOPgcvqDmvdV6U8rJP8ONTf52X1Qew+JhnR/ujCCouMwaKD84kGJsWKggo3wecVeByLtk+Sd4XPHFHd6BblYTGhdQGMzfnyN5pJsGDLWHRi9jdKuYSUZXggxSZMLKTJbJDD+Q3jy8144ahqiJLSBzy5y6JJsmB84qctGF5W0Y5+B39RB+9SU2u4UzPJp9hlIjw5VggPOcdJT2xid2pOOnyMmMC1ooNryuMY22Gmnz34XF9C0DnDdkmp5cWcGatbsfqpst3VvzNtGxelQtXlt6bSlO/AIDNtph/Z1OkL+oaeGAlRaFPzm4o/GNOxO6bHmL9wI62yc2fRZ/5Fw9/jDGe3X/htMWBcaxfDbfVqogFDOHwtS/GdhQvtYZ+up4anYInAcIS9iN0PnAvpSNngUpzP0ndSe3345PYAhATk8x4w4AXW523OSTr6A8MfHFHCzOSybMyC2OJOuGxLPWCkVYxCdnA+ecff9CmcGuRhOSqvqqcIalzeThBgJS84UhMvWFMSWdvzDBnjcffP9HvqL0r5kVF758xV45iTqzL5YyAdIe41UGi0VEkEMsUobTnpKtWc2clXQgz06OUHWDU6mJYpJ47nXtGahdjA== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:nebula.arm.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(4636009)(47660400002)(46966006)(36840700001)(70206006)(6916009)(44832011)(4326008)(7696005)(356005)(70586007)(1076003)(82310400003)(6666004)(336012)(36756003)(83380400001)(47076005)(81166007)(8936002)(54906003)(36860700001)(2906002)(316002)(508600001)(5660300002)(2616005)(86362001)(8676002)(26005)(426003)(186003)(46800400005)(36900700001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4304 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 9b72d05a-ecf5-4de2-cbae-08d9ad0feb63 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Gck5j+KHo6QO6uj4Bcx1ZL9J5Gt5WYK8O+pl6/93Be2EGdn1bgnbMdL02MsDGcYHzVR8bjO4Q0BQmjh6+pp4s/g8cGrPC+fiYCAfCg5ocTjXsj5mvXEQDcVOQyfubfSh8cgKv0aDxPfjuDdEAxSSxJtUc5QA1nnCZp3jjr/wlsKRPlPyHwnzlviQL8TPWOp66GfbuD2OOm27Xv7LmqXPf0iPdXk62clUsgpK549N8/o7j9Ew2YAro4j+IGEiA59HW6u47x34zJIhiwXwnGIBgkXv85ll1mrBycaluG4M0iWS5GQkBghLZqA3v0zaPJFK9Qr6eCitQ+mVC0hKsqD9sqUODRFzowHOjyJowD2AvtZrlQeJG7RPmQTB+Z/znKkTuITsPTKO1WkGRPvFCww31H4oceUIQ/kR61iphv5uodEUMa2X+8767b5S+rn2O7E6XshH26GqTZr9tQRq2poBpOa3EYmL6y+8Yg4ZAyKEPKBEn/4q0qsEW+xuC8JQkocHkQgvYCfkpAGi1WDAkpTUXXi0chn42FhhgXuvm3ifwTmnUXQcyLJz9v+GZAxICOXpJXMktyq3kg09DYzkUjYYtDHeXg8ne6CNAuVIYWtUSrlvgduhE3zNtzmt04/bGQtAcOg3+ywQ0Fbu+KQPKl/DO0XcxGaVHPmrZIwzY8WWXVu59UH6fzpg/04+h1+LvyJ3cRbff1i51smIfI9zwKEEKdbiNOkuEBmvZM7BdH4nV94= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(47660400002)(36840700001)(46966006)(316002)(86362001)(44832011)(82310400003)(426003)(6666004)(336012)(5660300002)(186003)(83380400001)(2616005)(26005)(36756003)(8676002)(2906002)(70586007)(54906003)(6916009)(1076003)(36860700001)(70206006)(4326008)(81166007)(7696005)(47076005)(8936002)(508600001)(46800400005); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2021 16:57:02.6648 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c4edbc0a-c916-4c4d-6eca-08d9ad0ff0dc X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6662 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Try to make this more readable by not using a long line with a ternary operator. Signed-off-by: Joey Gouly Suggested-by: Andy Shevchenko --- drivers/pinctrl/pinctrl-apple-gpio.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-apple-gpio.c b/drivers/pinctrl/pinctrl-apple-gpio.c index bd7f28150ac0..fba2d4ec383c 100644 --- a/drivers/pinctrl/pinctrl-apple-gpio.c +++ b/drivers/pinctrl/pinctrl-apple-gpio.c @@ -194,8 +194,9 @@ static int apple_gpio_get_direction(struct gpio_chip *chip, unsigned int offset) struct apple_gpio_pinctrl *pctl = gpiochip_get_data(chip); unsigned int reg = apple_gpio_get_reg(pctl, offset); - return (FIELD_GET(REG_GPIOx_MODE, reg) == REG_GPIOx_OUT) ? - GPIO_LINE_DIRECTION_OUT : GPIO_LINE_DIRECTION_IN; + if (FIELD_GET(REG_GPIOx_MODE, reg) == REG_GPIOx_OUT) + return GPIO_LINE_DIRECTION_OUT; + return GPIO_LINE_DIRECTION_IN; } static int apple_gpio_get(struct gpio_chip *chip, unsigned offset) From patchwork Sun Nov 21 16:56:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joey Gouly X-Patchwork-Id: 518424 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13208C4332F for ; Sun, 21 Nov 2021 16:57:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238695AbhKURAZ (ORCPT ); Sun, 21 Nov 2021 12:00:25 -0500 Received: from mail-eopbgr00054.outbound.protection.outlook.com ([40.107.0.54]:8246 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S238553AbhKURAM (ORCPT ); Sun, 21 Nov 2021 12:00:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mjZtheuLYMTaSwGih43Le1PaDk77ICFwLJF2RUSdxcg=; b=HtVKNIFpyBtyE0aZMM3h31TW0eWcb75XmCIM+456rqDeqcjMTizXD3KmMrRHsfeGb8vcPwldi5Vz9zc8I0O95TgeV1DvzmXXr0oa7pzY1xNoxhG6ZMlQSJs8WK8Z0/NeiHhFFdc3YqBA42lqezrqklJ+ghGXBHK95/bC95c4bvE= Received: from DB6PR0501CA0006.eurprd05.prod.outlook.com (2603:10a6:4:8f::16) by PAXPR08MB7020.eurprd08.prod.outlook.com (2603:10a6:102:203::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22; Sun, 21 Nov 2021 16:57:04 +0000 Received: from DB5EUR03FT056.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:8f:cafe::41) by DB6PR0501CA0006.outlook.office365.com (2603:10a6:4:8f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.21 via Frontend Transport; Sun, 21 Nov 2021 16:57:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT056.mail.protection.outlook.com (10.152.21.124) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend Transport; Sun, 21 Nov 2021 16:57:04 +0000 Received: ("Tessian outbound a33f292be81b:v110"); Sun, 21 Nov 2021 16:57:04 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 633211f390c2ce3e X-CR-MTA-TID: 64aa7808 Received: from fad94e497979.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6D059573-9CD2-44BF-8577-CE8F9B2E9B52.1; Sun, 21 Nov 2021 16:56:58 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fad94e497979.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 21 Nov 2021 16:56:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L8/bqVb/B9+L4VuubD6yBueyhgEBjxlYHUW0W9ML3OE5xEOEVDJLgsVx+qlTop1gQyl26ur9lR0I25q4l+iG3iYTzY88aHitSXLXQAmcF1R/r9E/qz2iLuhb8OwzMhMwjlVswucL1DH9f0Q8F+zHn7COV8tQ3jdvYrANrJaVqGjwRUfY7NSG9I7HWdNqGA3v+OttRonG5VveQV0NPGUa/U8VjZgzR/T7bg4+8CouHxq/dfy5Rwq/2hGC2gJlon9yQGPYNiNiH4RHzzhQqMsKO8yMSWmFfzmcBCVWx2btObiTXKU9ptFYueNZw3KQiB4+0ZjuSO73stsnNdZ2dcCaeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mjZtheuLYMTaSwGih43Le1PaDk77ICFwLJF2RUSdxcg=; b=WSyCycO4mMEucsgNAAy8rY1md9lDrr5w8RwEGxbm1cwIiavkJYvEoXAMfD4xUFocgFYxqEEPHOvxDMIYBZRVlwMdIjhsIRFAGsz8zUYGir5xzrCeqH3/iiiHsAIfdtnPX9mpKzUJgqyuszABQqZdVQVFGj3rFGw3qJb4B5P61VyJptokGuNsxMRGv3D3Mp6/9whooxUGGZpguq/dsY2RWlhpw1DvE4+DUXkDKClfbr0aVTodqlBm50oqdbIhN4LdFBo6wxuhDY3G2GiGV2oSj4RXj+vL/AbN4oSZQTC6hvLE38eOYMOM1qHTjIgB9Q9o+5QSRLZkN1ppA+dJNHrmpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mjZtheuLYMTaSwGih43Le1PaDk77ICFwLJF2RUSdxcg=; b=HtVKNIFpyBtyE0aZMM3h31TW0eWcb75XmCIM+456rqDeqcjMTizXD3KmMrRHsfeGb8vcPwldi5Vz9zc8I0O95TgeV1DvzmXXr0oa7pzY1xNoxhG6ZMlQSJs8WK8Z0/NeiHhFFdc3YqBA42lqezrqklJ+ghGXBHK95/bC95c4bvE= Received: from AS9P194CA0017.EURP194.PROD.OUTLOOK.COM (2603:10a6:20b:46d::33) by VI1PR08MB3165.eurprd08.prod.outlook.com (2603:10a6:803:45::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22; Sun, 21 Nov 2021 16:56:56 +0000 Received: from VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46d:cafe::88) by AS9P194CA0017.outlook.office365.com (2603:10a6:20b:46d::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22 via Frontend Transport; Sun, 21 Nov 2021 16:56:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT044.mail.protection.outlook.com (10.152.19.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4713.19 via Frontend Transport; Sun, 21 Nov 2021 16:56:55 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sun, 21 Nov 2021 16:56:50 +0000 Received: from e124191.cambridge.arm.com (10.1.197.45) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend Transport; Sun, 21 Nov 2021 16:56:50 +0000 From: Joey Gouly To: CC: Linus Walleij , Andy Shevchenko , Hector Martin , , Joey Gouly Subject: [PATCH v2 07/11] pinctrl: apple: give error label a specific name Date: Sun, 21 Nov 2021 16:56:38 +0000 Message-ID: <20211121165642.27883-8-joey.gouly@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211121165642.27883-1-joey.gouly@arm.com> References: <20211121165642.27883-1-joey.gouly@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7b59951f-bc11-4123-9ec6-08d9ad0ff217 X-MS-TrafficTypeDiagnostic: VI1PR08MB3165:|PAXPR08MB7020: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:1122;OLM:1122; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: QiM9ijjtJlf0sONYK35Va7sQnYfcMgk54BqZdoZs5lZLqmpf9z43f+upJ8UIVqfp3rv6H+uwKpleL2wFiHqUn+6BtMzxRIEA2eNsg3GCqPsBXCGbuJvUgN+Q+yDZgPAebOcQNZ/fxG+bWYT2cKDI08H+0olCDifirOOJpZNDJ7ueJXSy1Cdx+oKKqdu/TZZVsvsqMPmnrBWRnoHDs2yQyoodM7mO6nGlmSx8uU5qv5SzwVv6fr3duvduCMqwFjYK3ZxgWvheRKxU1G1eQ/ws1kws78muKEWcu51TK8QgI916nQ4+yMuzL3SiNvZNcVYepsrt7Zzb+bbkjiZQt/OzD+VxLDC+4zOJ1UKwKTZMejdeVmmodChwalWeY8cHxO8OLXLQXTRSjsfoHXyWIlUcIhL18OCKS5GqnmAqz1ncSwQpUq2jbJydjeowdXKphKPlKedmOAWo0Shvuhe82pnG9K3/aH6KKD5kmYSOFpKi2FStKhOxm8zVrgzGcmapjEQI+uoAIAOEdpnQmv0bIxXJXfq449peuQjuFhIaCkdKxcqVlAhLx39UzX4ywNB/78lwplA8L+6DM1BvuQ+R4Ul69lz0e3m3/TM9aZpwPpv0ldwdXsxuEMDuJpnYqjXkxZU97DWJIQCgo1XC4Hn4Sbzwi/4JZYUNJO5GJ1TfhdEggexsEvtfaxK2uAKT6xxbdM8Ka5sMAAWborLIZcxT6mYJUPf5jg6S/1wqa+1cuDkvEaIGiVxDEhV+SPblRVvsFWRUzHoKLCZctMvuUYEoinUFwA== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:nebula.arm.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(4636009)(47660400002)(46966006)(36840700001)(7696005)(86362001)(36756003)(2906002)(70206006)(70586007)(316002)(1076003)(83380400001)(47076005)(5660300002)(44832011)(81166007)(26005)(4326008)(6916009)(54906003)(36860700001)(2616005)(8936002)(336012)(6666004)(186003)(426003)(508600001)(82310400003)(356005)(8676002)(46800400005)(36900700001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3165 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: ab4811d1-9bb2-4d42-c2b7-08d9ad0fecc7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pxHYig7MUnGCgxhFR2q/ZxkC7V+hgF1Lcp4dRpcBIMEu19YtE6t9p8bBSldPpsf8dpuh36Qv/D4PV0YMJGLMEAKW2jC7v4lIW6ytg5dM1ujvH9HgfT9G9tbdpCHhdiCC7dKYfu1DvxXMaCXD/U2YWuv4R5viZKl8JLR+i2TepqkOl+2oNRgrLksf/p4IDqTEgdvDtRjzqrJVW9FCo12tiOXnRWUvJCNh/2kQHbIMz1o73Os2YJLYktthwRF9SBOY8tNyRTUHZvEmMchokP4NT4C9lzLQh9iW329uhJA4Ify8R6RHms2zwVLHE+fU+ylQeu93+QJ5OCCUPgNlsC1Evoh15/0vkyE10Lfubnf38wxHxA+jLITWj1l6jvsOa7J87TWnXEmJ98i1HqGk8E7N870Dj0Gu9DwveL3d51GYTB7Ne26I8VaCn4LIqdUGqPmxKmO2FckJuNnBhBwrHzRl30N65OegcC+xKZuXCoTssaanjvJLna5Z3HCaIOvG6Ei5ZNbJOqBeKVfJNYJtF3sdsUJKE3peVboF88xBkOoYlwz7VugGFn/wEm7uTZdm9GrF0W3gWJPsNWQybf7CCCSjQoZfjEzGKkYSHpvCSxct4ET3DnEZ1ztIouxrcrQrzt8GMxNdsccwqQCpfst8HW9Qawlmp0ZXZttYtPSCM5wcX+CgX6zjahj6GCfNHeWjDK0nGzhTfNEm1ToUGYdl3x51ca/ZfdyxeiRAnm3SDzCOFUU= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(47660400002)(46966006)(36840700001)(70206006)(426003)(81166007)(70586007)(2906002)(8936002)(316002)(44832011)(54906003)(4326008)(2616005)(1076003)(36860700001)(82310400003)(8676002)(6666004)(336012)(508600001)(7696005)(6916009)(47076005)(26005)(83380400001)(186003)(86362001)(5660300002)(36756003)(46800400005); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2021 16:57:04.7304 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7b59951f-bc11-4123-9ec6-08d9ad0ff217 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7020 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Signed-off-by: Joey Gouly Suggested-by: Andy Shevchenko --- drivers/pinctrl/pinctrl-apple-gpio.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/pinctrl-apple-gpio.c b/drivers/pinctrl/pinctrl-apple-gpio.c index fba2d4ec383c..fb34cbe189ce 100644 --- a/drivers/pinctrl/pinctrl-apple-gpio.c +++ b/drivers/pinctrl/pinctrl-apple-gpio.c @@ -392,13 +392,13 @@ static int apple_gpio_register(struct apple_gpio_pinctrl *pctl) GFP_KERNEL); if (!girq->parents || !irq_data) { ret = -ENOMEM; - goto out; + goto out_free_irq_data; } for (i = 0; i < girq->num_parents; i++) { ret = platform_get_irq(to_platform_device(pctl->dev), i); if (ret < 0) - goto out; + goto out_free_irq_data; girq->parents[i] = ret; pctl->irqgrps[i] = i; @@ -412,7 +412,8 @@ static int apple_gpio_register(struct apple_gpio_pinctrl *pctl) } ret = devm_gpiochip_add_data(pctl->dev, &pctl->gpio_chip, pctl); -out: + +out_free_irq_data: kfree(girq->parents); kfree(irq_data); From patchwork Sun Nov 21 16:56:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joey Gouly X-Patchwork-Id: 518422 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1714C433EF for ; Sun, 21 Nov 2021 16:57:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238335AbhKURAt (ORCPT ); Sun, 21 Nov 2021 12:00:49 -0500 Received: from mail-eopbgr20072.outbound.protection.outlook.com ([40.107.2.72]:10334 "EHLO EUR02-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S238686AbhKURAY (ORCPT ); Sun, 21 Nov 2021 12:00:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=px4VrOIkKrrT4CEWyvCzCizc9qlDxEdR42cqr5+gZb0=; b=mFsfLXMNr49GhNFUoDm/jomx9e+hyp7VVmsI0X+/g3R0myAGPBqvdIAO6v05aD2pzmBD3/0t7/j0prbETEuLbglhqlx3mHGrNCcnbR+LAMM1thNJRTBVIIPzrvWpL7BdXD2xzpxM/9IeOt06vWa4dm17LuTAzxr0keUnb5Q+Acw= Received: from FR2P281CA0027.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::14) by AM6PR08MB3815.eurprd08.prod.outlook.com (2603:10a6:20b:8b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.21; Sun, 21 Nov 2021 16:57:14 +0000 Received: from VE1EUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:14:cafe::d0) by FR2P281CA0027.outlook.office365.com (2603:10a6:d10:14::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.13 via Frontend Transport; Sun, 21 Nov 2021 16:57:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT033.mail.protection.outlook.com (10.152.18.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend Transport; Sun, 21 Nov 2021 16:57:13 +0000 Received: ("Tessian outbound f493ab4f1fb8:v110"); Sun, 21 Nov 2021 16:57:12 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 7d940e0210301440 X-CR-MTA-TID: 64aa7808 Received: from e5c75253f78a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7B117CF6-DE1F-4EA3-953F-F9AA54C7DA25.1; Sun, 21 Nov 2021 16:57:05 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e5c75253f78a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 21 Nov 2021 16:57:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b7G5Qf/NbN+60u6AzlEHuGpwgzZQx/8elgD0/9/KIRcbWMmzxeNcmyMzIBH+0AelIIYi77cB6r6evNcuEhOcoLkPwW5wu+5+CeN5yyKonS10mZsFRDLd6F+46AZd0M3fBb9xwbAOX00LTcZzt12Vc69m973qU4fLXNRmzKHmSwZzGqaX5rD8T03zfgX0xbvZOizi1jt16m1fXxDDPegbR3CYFPLnMjy/+gmNIfNIQOdk02+/GWGB8nHpewuMCjmlcybWwQEI7mL8J4IJJUA44jKlYdhaZnFSyFV/xHAFzo9X8BTMkSvsn8CKzrrxNvxCWFmPCZpwe6hsy1xet5nk6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=px4VrOIkKrrT4CEWyvCzCizc9qlDxEdR42cqr5+gZb0=; b=GC4GCkOZdjrPMRHT+Zjpqw83XNG2BaXlD5k0Ym1ntdXoFD5NUQlezt2t/aN7vUAIB4YZd9R/HllsB6aNKuUelqXm+IFqOfW1M045VFvnPtjA98Ujlw7vaqv1nfaifVTbvzlTVh2nOmPWJz2O3Ffrl3RRexLA0v+/31YK/cMf6aHXTiL8+a/xvkCcEk4dFXAkiGX+Wno1EjWOVoGO1PaTPIXy+DTJTGjjyeRqhUAqxVfvWO/NGGNjGbicERk5TbaKdMdLtYK1TUET3ueYXWBwgGyG+M88o7EYlXV2SFNsEpTSaMhnxnh3JiQgfiCAkdKuZgCFw816iq7rRzSjxtMZtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=px4VrOIkKrrT4CEWyvCzCizc9qlDxEdR42cqr5+gZb0=; b=mFsfLXMNr49GhNFUoDm/jomx9e+hyp7VVmsI0X+/g3R0myAGPBqvdIAO6v05aD2pzmBD3/0t7/j0prbETEuLbglhqlx3mHGrNCcnbR+LAMM1thNJRTBVIIPzrvWpL7BdXD2xzpxM/9IeOt06vWa4dm17LuTAzxr0keUnb5Q+Acw= Received: from AS9P194CA0007.EURP194.PROD.OUTLOOK.COM (2603:10a6:20b:46d::21) by VI1PR08MB2992.eurprd08.prod.outlook.com (2603:10a6:803:44::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22; Sun, 21 Nov 2021 16:57:03 +0000 Received: from VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46d:cafe::3c) by AS9P194CA0007.outlook.office365.com (2603:10a6:20b:46d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22 via Frontend Transport; Sun, 21 Nov 2021 16:57:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT044.mail.protection.outlook.com (10.152.19.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4713.19 via Frontend Transport; Sun, 21 Nov 2021 16:57:02 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sun, 21 Nov 2021 16:56:50 +0000 Received: from e124191.cambridge.arm.com (10.1.197.45) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend Transport; Sun, 21 Nov 2021 16:56:50 +0000 From: Joey Gouly To: CC: Linus Walleij , Andy Shevchenko , Hector Martin , , Joey Gouly Subject: [PATCH v2 08/11] pinctrl: apple: remove gpio-controller check Date: Sun, 21 Nov 2021 16:56:39 +0000 Message-ID: <20211121165642.27883-9-joey.gouly@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211121165642.27883-1-joey.gouly@arm.com> References: <20211121165642.27883-1-joey.gouly@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c7f03923-8737-4e8f-c021-08d9ad0ff756 X-MS-TrafficTypeDiagnostic: VI1PR08MB2992:|AM6PR08MB3815: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:2512;OLM:2512; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: wyXsKEBjur6vT2huMHRXoRNKyIQj/5PVr+s1fD+zGlGtod0RrOZC1mVQ8V/CKnyRV16jeKEHrBqfLdaGQ/RQpG00kEHBZK4bsnRlidJ0NSDQaiHE+ctZo64JcHNhzrg9SIflD5BlovCvhj/85PO+NX5OnVhkfIV9gEZbIRh1heGLUToVFORhjOSyngG/6WtphkG4kCzEoV6qaQCiZ/XuVOsYzZAuGc/4xqTY39jc0jNB42qDZqje0ZYE/MrPB6yC9a+FddbNJ3NZBt6HBYglhRmSCYZZ+Lk20NGXUeiScu24irq8xY3jlVvrnOaRBisVihOuBCeaK9bXKZkBTWC1mUVbsnOaXm4Nwf8AkEwjMJp2+o4KUI+XvlMSJruQ/m/rtDTgYtZHs+BxWNmuYkHiKTMnD0WsLf23wzX4eXvLXmCk0YhS++qJ5qKChuGxGvRvYVNnaorz3VvkOcuf2R3d+Y6ex5Wpr/OtqcLG1VQ8LvRQIfFPOkd9cVaWWBqceA+t/qGW2lUHQw1WsqHJ8mFHCjAzLgdZZwXzLR2bQF6DTXBYrWTcwIxUTcuKP9kiwf/Aqvl8stZimdnv8kUbhBx/hFotpu7c5gqaUJAi7K28RzRTE+qCfwtCNF+1BmydMfdp702XCB8oWYl+ROYNpa+xbQFaTj0U1FZfmlrkTAbX7LFkXTbDoMAKF3rt08oAL5Ae1V1pCtkMaZtXa/K4B6xb+Ise9Fmuz4kj/YHegvSAqM6N/9gS+NH/efsJ1EeqaT0p X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:nebula.arm.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(4636009)(47660400002)(36840700001)(46966006)(81166007)(508600001)(54906003)(2616005)(82310400003)(4744005)(316002)(336012)(1076003)(426003)(8676002)(36860700001)(6916009)(5660300002)(186003)(7696005)(8936002)(2906002)(47076005)(36756003)(356005)(70206006)(26005)(4326008)(6666004)(44832011)(86362001)(70586007)(83380400001)(46800400005)(36900700001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2992 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: a6223cc8-c54d-465b-fb22-08d9ad0ff0f7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Be4c8r7858/itq+g67MN+u1AmMbw9Jwk8CcABrWDrJsuFx8Jaj1B7qfVcqb8E0xUIMAf8NQoFUNyrMSNAARTUBSL2j8RKQMgtH1pXmWiWtJ3VZ1uHgjozWH5ypSzRd67y+EvJFMcdLbS2+kN9Tw3F0VlhzIr/rXe/8C4zmyuptJBCgh3+hzEjc//WZKyKEolTR0nY8T04mzSFD/arrRhjnSdE4N5EF/GIP8J2oSUhvOU5GJYvhNxWbc7Ae0rhz9WG0K5FZTku/gFthaEt0RgDNcZGmNZzBefkVu7fBwhIhMV0tJFzrjlNKwUXBEUgs9AzmwBZ/HI4H6cKNl8ClFeX4TE86B/C7uQZyclSOj4w9UdXkORVzecqXiZxerlYemTe3CirR+NYuvzNWwsFnpQmNxMGBoZoDCOyEc2CjM15SYfBPHvJZQ2DUyJk5IshOYtYjI+1L7Mj8KH7PIxi/WonktE3YtnBqlihhN/Y0RgvobpszmtvJZTWxE0tr4DzQxqhfh1+oW8VEybpj2ClNKRXKgQSoZwNfHhKp9neKrvlvl7+3yj4ftlAmzgG0Ma20EXAZjW8hvYgg1qFSCJLoGomNW2y02D6CFlbs844zY++w2jxoU6fR/xsRGvfDbAiPPgALSclOvfJLreWnPQ/IRwvvKdtOTyMHam7sP/vWFhNFxRu2l5Py/WYh/5ueG+f3BsYCj1ksWO7OYMW0O9lmGIZ8+UQaaX+xLnTus/mAd+n+g= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(47660400002)(36840700001)(46966006)(36756003)(47076005)(1076003)(2616005)(70586007)(508600001)(2906002)(81166007)(7696005)(82310400003)(8676002)(70206006)(36860700001)(336012)(426003)(4744005)(44832011)(4326008)(8936002)(86362001)(6916009)(316002)(26005)(54906003)(5660300002)(186003)(83380400001)(6666004)(46800400005); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2021 16:57:13.4288 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c7f03923-8737-4e8f-c021-08d9ad0ff756 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3815 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Having this missing, but everything else valid shouldn't result in a failure. Signed-off-by: Joey Gouly Suggested-by: Andy Shevchenko --- drivers/pinctrl/pinctrl-apple-gpio.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/pinctrl/pinctrl-apple-gpio.c b/drivers/pinctrl/pinctrl-apple-gpio.c index fb34cbe189ce..471d3abf9d99 100644 --- a/drivers/pinctrl/pinctrl-apple-gpio.c +++ b/drivers/pinctrl/pinctrl-apple-gpio.c @@ -360,10 +360,6 @@ static int apple_gpio_register(struct apple_gpio_pinctrl *pctl) void **irq_data = NULL; int ret; - if (!of_property_read_bool(pctl->dev->of_node, "gpio-controller")) - return dev_err_probe(pctl->dev, -ENODEV, - "No gpio-controller property\n"); - pctl->irq_chip = apple_gpio_irqchip; pctl->gpio_chip.label = dev_name(pctl->dev); From patchwork Sun Nov 21 16:56:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joey Gouly X-Patchwork-Id: 517130 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5216AC433F5 for ; Sun, 21 Nov 2021 16:57:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238651AbhKURAx (ORCPT ); Sun, 21 Nov 2021 12:00:53 -0500 Received: from mail-eopbgr50063.outbound.protection.outlook.com ([40.107.5.63]:53998 "EHLO EUR03-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S238524AbhKURA0 (ORCPT ); Sun, 21 Nov 2021 12:00:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h2zUKHgN8XCzhbsV2fR/kUR2imKU/AvdmXcfwuE4vEs=; b=XAx6E6ZO42tFE8a11m7QpLu47J7VrOV9burbQoCtcnY17mHiP07HeiUEsE12n6kjf10A38VoggDH15cmakAZRJdlps8cT2UwDEZT0QQckbizEL0z25Dv9xWAKklX0EGtju34LyVYPago7IuGB8b/e7dKwY2Shpn3hlMbpm69uQ0= Received: from AS9PR0301CA0022.eurprd03.prod.outlook.com (2603:10a6:20b:468::18) by DB8PR08MB5164.eurprd08.prod.outlook.com (2603:10a6:10:e7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.24; Sun, 21 Nov 2021 16:57:18 +0000 Received: from VE1EUR03FT007.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:468:cafe::b2) by AS9PR0301CA0022.outlook.office365.com (2603:10a6:20b:468::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend Transport; Sun, 21 Nov 2021 16:57:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT007.mail.protection.outlook.com (10.152.18.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend Transport; Sun, 21 Nov 2021 16:57:17 +0000 Received: ("Tessian outbound 9a8c656e7c94:v110"); Sun, 21 Nov 2021 16:57:16 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 0a6804607b6ed58c X-CR-MTA-TID: 64aa7808 Received: from feca4570f659.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2EBB33AB-5DC2-4F93-A4C1-33471E676A8A.1; Sun, 21 Nov 2021 16:57:09 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id feca4570f659.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 21 Nov 2021 16:57:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F8DKbQnQKyUkUh7fdQHeb5TUPV0fsxhKqIr99hWKrKGU5MkH5ZQy5QdMVhZ2bD18Q6pqydUO+Ha6CiTDa0oPw1Z7fsjLGOIDczsFaHqkuiNjA18lKLqP9ecQ3Hhhig6KDvMtYcl8BE/YI8xiNlmBJGEfAPiUSMLc8lvw2f+Mx1Eg6JaaP/SSThv4F5iVIWdX6RV3bgW9Oe4ipR0z8d7L53ql99fq1mSivoe3L2bmG4KsXL2abjhfd0phRIO4Y1s+OaQqESwEfYncxMIXQ1F1YypCkvLGYX0sTFm4/U7Pcen7hiPAvJxKVsHaxs8BHkUP5RC5nlGc5h/VAZKCc+DVvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h2zUKHgN8XCzhbsV2fR/kUR2imKU/AvdmXcfwuE4vEs=; b=jnb2pg+5zMlLvdTkVz+iVB3E9fyEFd5h8onsx6d9ssBK91qb09nvfN77DNCDc5fK3NcEv+zGvPvYGK2f9BwK6m9BdaNd2pRwFoql8kFr/So7F3wWftbMZnx+612hPtKVZsacm6TLSAEIonNo14ZH8qnS+bS/JZ9cpYZuEX8zXWVEyMKn4Fs3PNpOOCGmhSkE+i9XOgC0sJY1/SLJXkBbVpUu0D7cAXsZdueGHM7ng6lYyJ+UHL+1/2h45MRLS3ffjCMZCw03BJetbgmlsa4RZ2QlzRT82peIPmSyzuJIbHiSp04NzD6nzEZ6aXBwAsSSnHuuiOMokzQcV5UJTMvZuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h2zUKHgN8XCzhbsV2fR/kUR2imKU/AvdmXcfwuE4vEs=; b=XAx6E6ZO42tFE8a11m7QpLu47J7VrOV9burbQoCtcnY17mHiP07HeiUEsE12n6kjf10A38VoggDH15cmakAZRJdlps8cT2UwDEZT0QQckbizEL0z25Dv9xWAKklX0EGtju34LyVYPago7IuGB8b/e7dKwY2Shpn3hlMbpm69uQ0= Received: from AM5PR0402CA0024.eurprd04.prod.outlook.com (2603:10a6:203:90::34) by DB9PR08MB6890.eurprd08.prod.outlook.com (2603:10a6:10:2a8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.24; Sun, 21 Nov 2021 16:57:08 +0000 Received: from VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:90:cafe::2d) by AM5PR0402CA0024.outlook.office365.com (2603:10a6:203:90::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.21 via Frontend Transport; Sun, 21 Nov 2021 16:57:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT049.mail.protection.outlook.com (10.152.19.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4713.19 via Frontend Transport; Sun, 21 Nov 2021 16:57:08 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sun, 21 Nov 2021 16:56:51 +0000 Received: from e124191.cambridge.arm.com (10.1.197.45) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend Transport; Sun, 21 Nov 2021 16:56:50 +0000 From: Joey Gouly To: CC: Linus Walleij , Andy Shevchenko , Hector Martin , , Joey Gouly Subject: [PATCH v2 09/11] pinctrl: apple: don't set gpio_chip.of_node Date: Sun, 21 Nov 2021 16:56:40 +0000 Message-ID: <20211121165642.27883-10-joey.gouly@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211121165642.27883-1-joey.gouly@arm.com> References: <20211121165642.27883-1-joey.gouly@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8def6a42-28fd-41f8-ae90-08d9ad0ff9d7 X-MS-TrafficTypeDiagnostic: DB9PR08MB6890:|DB8PR08MB5164: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:628;OLM:628; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: BgilKj1pDsYSMPWD1qFzV56Z4bU5SGOpCeZRtP1+dpIcBHpFc+hDmmGl9IvEPMBrPEhGppRdVf5HZmDUeg2z8DF2v+saKoLFwzuh8pXY6dxYfqGtetcl2y3Dg5hL1xJfhXCriW6O82sebnjk4iGYETqHwnLo4WKtApLnMlR6QaDVtiB3JoLWn8J5UPO9ymYeBKnyvTPKbmM5xCuyiHeYLgqak8H/1tLt3EnrWlJpGdub+JXuz1l/rJb9wgKVv0HEXPR8tdnmWakhBZcy2FIkPOPAGuD68XoPsKb+e1+OaUaR4hcm20ewJaVW53kZ8zJyzYarrvvx2T8dlGJJfNn3ovLJLVIMQxtiVK6NA53oHGVcP3aKi7A100racISIyIu8W5QSx58CwH2EJf9Mmda2bW7rQCl72v94SMMfn61SqE2o87M6phl3dayxSqxv6YoY9khUOctRGN2koLt2ILC8q2aymPOEb2NvGfAXE3XeyNR1GtQ+nioOZNpd8tR4o5fi3yrecEZzYN7ghE5VOXmgcrl/cXSGR6JuBpM4YHT/baloEGIINMTvyDHKoc1iXIYbn4cNoVdkIkP0frAbjq8H1i35x+5lFSKC5w7N2vh5tBVJFcoB1vpGLhJ4vazlqOwa9cLzPj2ycTZgetk/Vt0dH2vNjcnhy/BrIcckWdtbyX7gsVKtFcDbWaH5mfElqHTXSLSywFPcPth6MaHqZIZozNN+KfMJsTPiv87WRcLLMbMMeDo2p/mxhBxaFa4FxmC0Zrg/YKn/VAoadeLPA/RvhA== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:nebula.arm.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(4636009)(47660400002)(46966006)(36840700001)(5660300002)(336012)(86362001)(2616005)(44832011)(4326008)(70206006)(70586007)(47076005)(36860700001)(26005)(426003)(1076003)(8676002)(186003)(316002)(2906002)(82310400003)(6666004)(7696005)(54906003)(36756003)(81166007)(508600001)(356005)(83380400001)(4744005)(6916009)(8936002)(46800400005)(36900700001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6890 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: e5c587d8-ceec-4f47-b76c-08d9ad0ff415 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0kb0yvkMCg7JVCrLh8aJ3yLEbdpHshzBpnApjkUmE5Af0X/7QNLQ0yLGgBsJ0URDhgwj0CcOV85u2/pE//R0ly0TUuf7sPdkCEuV1mRsRdTmYcivVHDCcvPSsbfaFTnKbgyqLNe6WzJQJ4X6gM8uLBDzVHpDR6kWNHpqPOXybcj2rC+Q1FpPajPe6zDch3qOXYeb0wH0k3F5Wy+wZzSjTTfSsRwaJTtVGQPPo1K2GJHEM8y5sy4Dn2cs+oMzW0L3TTum1pwpGmallwnqaNP6hONk2ymKQX/SDtxs5xQorcmjnSKyW8YOcWVGGhRjgeh3ZShs+C7jgiEasQAXeanQgOrnyrnmRa5KqucE6khe6h4XjkuEjOFMLREcUOMtnYFmCRP766j4O1oe+liHPBAC1CIko7cvCWtVjB/9gDNeZc/2f2dtiPA7gLF7CgmIfFCKqU85r7cMAhIL3en1H68ka0zUoSEVNSO1JC1HTIOs2hwLcThxQPjWM8X2a482RL+9IugftYOfo+n4tMzJCHCcVS/SK2okKQk4rcvAeIvelE+U342vs98dfPx3IgKc0gVFIjk58BhLzRAN3pnddf2ruLqT0glTRyK+4cdfSNv6OpcwyX87ADHkzPVRW6lPz6gsz9yX6GiDYh8i9yp2JkzsR1lebiUxZlQ2Qs1sFOErA/u1pWf7bDbTGvzwrTkDHT2XrBasboh+Bmfu7r8UW2zPVWpGq41J/HFVR+D/L6ZFg3w= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(47660400002)(46966006)(36840700001)(36756003)(2616005)(6916009)(8936002)(4326008)(70586007)(2906002)(86362001)(426003)(336012)(8676002)(81166007)(54906003)(7696005)(5660300002)(47076005)(26005)(508600001)(83380400001)(36860700001)(6666004)(186003)(44832011)(70206006)(316002)(1076003)(82310400003)(4744005)(46800400005); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2021 16:57:17.6342 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8def6a42-28fd-41f8-ae90-08d9ad0ff9d7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5164 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The gpio core code sets of_node, so no need to do it here. Signed-off-by: Joey Gouly Suggested-by: Andy Shevchenko --- drivers/pinctrl/pinctrl-apple-gpio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-apple-gpio.c b/drivers/pinctrl/pinctrl-apple-gpio.c index 471d3abf9d99..8e794ebb47da 100644 --- a/drivers/pinctrl/pinctrl-apple-gpio.c +++ b/drivers/pinctrl/pinctrl-apple-gpio.c @@ -373,7 +373,6 @@ static int apple_gpio_register(struct apple_gpio_pinctrl *pctl) pctl->gpio_chip.base = -1; pctl->gpio_chip.ngpio = pctl->pinctrl_desc.npins; pctl->gpio_chip.parent = pctl->dev; - pctl->gpio_chip.of_node = pctl->dev->of_node; if (girq->num_parents) { int i; From patchwork Sun Nov 21 16:56:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joey Gouly X-Patchwork-Id: 517129 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B602C433EF for ; Sun, 21 Nov 2021 16:58:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238430AbhKURBW (ORCPT ); Sun, 21 Nov 2021 12:01:22 -0500 Received: from mail-eopbgr40085.outbound.protection.outlook.com ([40.107.4.85]:5377 "EHLO EUR03-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S238609AbhKURAm (ORCPT ); Sun, 21 Nov 2021 12:00:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=401qnqPt+GrMkpXA7hgK8pMgKAD8nM1s/1T2BdG2LFI=; b=3uV/poceirs1HgZoFaF330+JNmWv3oK4nnaIQVDy7f5/rVrKa2k8AxzYupMjFZP4rf4XDMVwJyz6XgHQfjqx1Y0ISMzZDLwShRCKIVSrret5XmB+oAcmSgGJoUSAw0OjMNIP9PrumKZvjTZYIfLb19PjuY3+dmP8CQbBRzr/XO0= Received: from DB6P193CA0020.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::30) by AM0PR08MB5298.eurprd08.prod.outlook.com (2603:10a6:208:188::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22; Sun, 21 Nov 2021 16:57:22 +0000 Received: from DB5EUR03FT051.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:29:cafe::9) by DB6P193CA0020.outlook.office365.com (2603:10a6:6:29::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22 via Frontend Transport; Sun, 21 Nov 2021 16:57:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT051.mail.protection.outlook.com (10.152.21.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend Transport; Sun, 21 Nov 2021 16:57:22 +0000 Received: ("Tessian outbound 157533e214a9:v110"); Sun, 21 Nov 2021 16:57:22 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 0c4a9d586b774c16 X-CR-MTA-TID: 64aa7808 Received: from 9d18f7d39a3c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A789CDF4-75C7-46D0-9FEA-06C9F835B13F.1; Sun, 21 Nov 2021 16:57:15 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9d18f7d39a3c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 21 Nov 2021 16:57:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JSyu+bX1ZmIGAFdXh0PB4g7zMUfTFmUOsMsM87ZhW4pyEAOwIZaSklruQ8cI/L9c6htQg6Mt8EkaggIOr5wUDEjw9BeOqKSwvzTKuIO1+Xr/y4dSGre2wqAbWB9Nhhgcsg1MkyM5RHRaCoFB36TMZtJmdqbmaenWbqMnKjYanWf7vPyqsFVw8atttEmBiIP92Upn5j/j554eZR6HFwCVxJ0VobkzP9InZaOwYrA3z/KBmwXn1qfc0VWG47pnJbfWcdNFQozQs2+BKxJFYqrIP+Ge69AAO/01ch1aSnzjHbLzBkUo1CgmAdvCO3OzlsDm7Qcwm/zZm2+44Ph1YOAksw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=401qnqPt+GrMkpXA7hgK8pMgKAD8nM1s/1T2BdG2LFI=; b=TrQ0XQoRb949lCrECsdCOws/gRYEIs+iKizMLfgmp16y7UhiaRAKTj5FsBMJ2XY2i4L0vqT8l2NEfPEh9OVVuGP121G23zDPsHzr7TcfXASZnRtvehljPiP+xQZo87yfVderCz7KyDK9vNDwiITCfR3285Z5/2W/Q5cZpgCxqfY7OJBqf6l5MD+hI7DxL7+X4C2dBf0zL7c7Wawge6ZhJMheQjwF10bpwB82AKuBU8W44S4XNqM1nym4sLyL0THTFt6cTwFjCitk21YhV0nRUTy4ypLKJRkdL5Vcj7YgFY0sEzF9VXUU6L1Gh3/1hST40UK3dhv13sLZPzabfup5fQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=401qnqPt+GrMkpXA7hgK8pMgKAD8nM1s/1T2BdG2LFI=; b=3uV/poceirs1HgZoFaF330+JNmWv3oK4nnaIQVDy7f5/rVrKa2k8AxzYupMjFZP4rf4XDMVwJyz6XgHQfjqx1Y0ISMzZDLwShRCKIVSrret5XmB+oAcmSgGJoUSAw0OjMNIP9PrumKZvjTZYIfLb19PjuY3+dmP8CQbBRzr/XO0= Received: from AM5PR0402CA0011.eurprd04.prod.outlook.com (2603:10a6:203:90::21) by HE1PR0801MB1740.eurprd08.prod.outlook.com (2603:10a6:3:88::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19; Sun, 21 Nov 2021 16:57:12 +0000 Received: from VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:90:cafe::6) by AM5PR0402CA0011.outlook.office365.com (2603:10a6:203:90::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22 via Frontend Transport; Sun, 21 Nov 2021 16:57:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT049.mail.protection.outlook.com (10.152.19.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4713.19 via Frontend Transport; Sun, 21 Nov 2021 16:57:12 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.20; Sun, 21 Nov 2021 16:56:51 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.20; Sun, 21 Nov 2021 16:56:49 +0000 Received: from e124191.cambridge.arm.com (10.1.197.45) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend Transport; Sun, 21 Nov 2021 16:56:51 +0000 From: Joey Gouly To: CC: Linus Walleij , Andy Shevchenko , Hector Martin , , Joey Gouly Subject: [PATCH v2 10/11] pinctrl: apple: use modulo rather than bitwise and Date: Sun, 21 Nov 2021 16:56:41 +0000 Message-ID: <20211121165642.27883-11-joey.gouly@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211121165642.27883-1-joey.gouly@arm.com> References: <20211121165642.27883-1-joey.gouly@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8d31badc-ba94-4028-3c57-08d9ad0ffc8f X-MS-TrafficTypeDiagnostic: HE1PR0801MB1740:|AM0PR08MB5298: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:339;OLM:339; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: tlQTkuzIrLs24FPvTUSfq/WyzyZy0y0EaCDio1B9f9B6JnK2G0+fe3x6Ri81X96eJLiApsDtXccMElz9Y7gsVzQNmohHkA6daZf1jiHvBUXdSEf0XmEoWC40Ax6T4PnYLlSIkm5Fr0SgBjSeouL6SH2z2CROTG+olmsUUE0VNNGLXVgTr1GhXHOf5m3TQ9s+Xx4w9Q1+T5D5draG+1KvUvd8BzlIVqfYOZTIIuoOD90ZuiVExS9sVKGXU/Ogqk7KSP/GyPMgWc+w7j+r5tlMuz3sn0q/5uwkwPb9wl7vyLJdgqY78by02uNyxXnQVqYNsx1mJSI6A1GLbqpftbyXCZPrfm3awBdEbTKCF4CUFnpaWcSukfYWEefM8H0AU6qAyebfZqgfvNpQIEjqD+cXCWsiQSX/IT0vLvsrjW6NY5OoYHMFUy438owcmpEDp505Qdqq3JLZjwNIkwfgs34bYCCVVfqpLh7NLPvw+BR1J4QmXmjm+myRqiZnmfHOZoO/RgSHLMvssXtowq3GID3Z7uIyBGJ/dCsxP0qm7+xccgRR2o5dVdwYX6li2dRZlkbLsuloYpV6io5yrxvO3GXtobo1ij+b5kT2xx6lZBiyctr4z4gxEKdrWpJw7Edjihuw8/BLMQuNTRswAn0YyVtZGbcedWmEuuoGHuZa5VVTZn8i2olWQqH8lavx3e/A8/C14fyHje35Ap6Bs1XVQUDO8oZfcZ5rmxKGLkDJPevTMdKboYwMvqo3KIYGZ2usvozBwXoKk/KF82d+/G2kpgbddA== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:nebula.arm.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(4636009)(47660400002)(36840700001)(46966006)(4326008)(2616005)(336012)(508600001)(36756003)(70586007)(7696005)(70206006)(426003)(47076005)(83380400001)(44832011)(6666004)(4744005)(54906003)(36860700001)(82310400003)(8936002)(2906002)(8676002)(356005)(26005)(5660300002)(186003)(81166007)(6916009)(316002)(1076003)(86362001)(46800400005)(36900700001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1740 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: e8b51ab1-a2b2-4491-4619-08d9ad0ff67d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MBVRQUkOdVtfaHQhp30S0zurCRrI++h7Zw9q0gDRVbX0zzZzvTiOyxXGEVZcr5Uu+/CCCxi/rSClGUBCBVX796TuMvHvjGFHeNdxc9J0KvOWNjDNgkB0/92Omm3m2xS9PS+xhofefwXfyg8PhS19m+xuhIBdm4+cswRwtUXysHQwR9EMVdnWD5H4ZpiWcLPkmDq/AMAT7V4RKOxyt01zc6HddDDW13Tn4xbPz6AM0rP9lBQNnQGo3E0r3xJSpyY8ZhTCz3EMZedGDK7aXJy+ZBL4n6POzbaaZ4RLOcttXDHBTnTN7R8KxhF+x7YYLD0lnQYUtfRZBnT4FpejwXH8pj/loAcRrQ485yUnlHyFJBASC52TSFCBYRi1ILpxSrYz+y9jZ/y0NIR6Vgrm18TXsVW00zLFy2Xq+JigamCd+CfcTf1lefaXBrBWTyoFXBKKnYSTLGB2VcZzS6rKMXnOxMLMm4c0dsPkDDOMgEGGikY5pmnytPSNDsRtQkZpE8NpI9/6UNSklqwp87nlUegRiBWSzKqWPoI9iYyQSlHGwD6F1ZVorwe+/dQ7LJkWEmP0L5LEH+eAKRMpP72jmXpFaQSnR/3N8iCcJ3spHHRezqTITlwcvhs5r2TiTmtwx5Q0IHOM1Axfe7bEww3TR24Y57r2VTfDhKudMbqz/0emdXmx2wuibCel9K3qvfdoQWCFXFm+sCmcnJ6ksezKQWT9PVDfWNEDc2IGnHWfaPaQjjI= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(47660400002)(46966006)(36840700001)(47076005)(186003)(86362001)(508600001)(8676002)(36756003)(4326008)(6666004)(81166007)(336012)(8936002)(7696005)(1076003)(4744005)(44832011)(5660300002)(6916009)(426003)(2616005)(82310400003)(54906003)(316002)(70586007)(70206006)(83380400001)(2906002)(36860700001)(26005)(46800400005); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2021 16:57:22.2926 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8d31badc-ba94-4028-3c57-08d9ad0ffc8f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5298 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org This expresses the intention clearer. Signed-off-by: Joey Gouly Suggested-by: Andy Shevchenko --- drivers/pinctrl/pinctrl-apple-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-apple-gpio.c b/drivers/pinctrl/pinctrl-apple-gpio.c index 8e794ebb47da..8a58c862c33a 100644 --- a/drivers/pinctrl/pinctrl-apple-gpio.c +++ b/drivers/pinctrl/pinctrl-apple-gpio.c @@ -252,7 +252,7 @@ static void apple_gpio_irq_ack(struct irq_data *data) struct apple_gpio_pinctrl *pctl = gpiochip_get_data(irq_data_get_irq_chip_data(data)); unsigned int irqgrp = FIELD_GET(REG_GPIOx_GRP, apple_gpio_get_reg(pctl, data->hwirq)); - writel(BIT(data->hwirq & 31), pctl->base + REG_IRQ(irqgrp, data->hwirq)); + writel(BIT(data->hwirq % 32), pctl->base + REG_IRQ(irqgrp, data->hwirq)); } static unsigned int apple_gpio_irq_type(unsigned int type) From patchwork Sun Nov 21 16:56:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joey Gouly X-Patchwork-Id: 518421 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7832EC433EF for ; Sun, 21 Nov 2021 16:58:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238445AbhKURBF (ORCPT ); Sun, 21 Nov 2021 12:01:05 -0500 Received: from mail-vi1eur05on2062.outbound.protection.outlook.com ([40.107.21.62]:10782 "EHLO EUR05-VI1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S238713AbhKURA3 (ORCPT ); Sun, 21 Nov 2021 12:00:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/Jnlxw9V/9Ny04bI0Wqgq4KGwLhVc2D9BpabSXLveXg=; b=jGWsI1t1BvLBm1MFQ1k6RpQW0XQXG2Rg2pApXoswphht7gfqPfbrRc02dCuIbsiGPoxAIenvaaMvZFz7MAzcMwBYF7mwvbF4rQ2TriPjJuSta8v4AbicHS8lnRo3kwoYfm07+bYA5oq4xYdZqYVzmw8DB2r6oAsD/U3YdY3fvzA= Received: from AM5PR0101CA0006.eurprd01.prod.exchangelabs.com (2603:10a6:206:16::19) by AM0PR08MB4113.eurprd08.prod.outlook.com (2603:10a6:208:129::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19; Sun, 21 Nov 2021 16:57:21 +0000 Received: from VE1EUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:16:cafe::19) by AM5PR0101CA0006.outlook.office365.com (2603:10a6:206:16::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22 via Frontend Transport; Sun, 21 Nov 2021 16:57:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT039.mail.protection.outlook.com (10.152.19.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend Transport; Sun, 21 Nov 2021 16:57:20 +0000 Received: ("Tessian outbound 157533e214a9:v110"); Sun, 21 Nov 2021 16:57:20 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: f7f87525cea371e2 X-CR-MTA-TID: 64aa7808 Received: from 8e6e3c09f841.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 304E139C-6C4B-4ADD-96B5-58E9FAAF6C4D.1; Sun, 21 Nov 2021 16:57:13 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8e6e3c09f841.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 21 Nov 2021 16:57:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gg8xcnEHZRdf50qnKPpaNQsptF+ZXnbPlFDv0YpgrL004fUy+hSjirIUGDiDASaelp4q4r6+IiI72zh5NK5dIe5aV87dBgn8ym/5u/VMtNX1rShC85ZWzYOPAq/FPn9O46+h5bz2jabCD9cfKhTm9c5/8Wc9I21PceQr7lxL75IcdIY0X7nP607YhMgYGtYCKN3hrnMfTNLsA4B3Ky89R/RaIvrrDKHHMR3341k4RFKXhpk3aFI8zST/SJFs+j1rlgEXHkdCvnboF9e6Xd1qI4V1lYra1FBTZDypizEzyRXkwxvsVBCZPQdoPuuymZeyY06HbYGuRs+4DoLEchP1sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/Jnlxw9V/9Ny04bI0Wqgq4KGwLhVc2D9BpabSXLveXg=; b=c52g3gQtgwDsrFL8JnqfBiBuejHU/WEfX6G+7eRjJuemAVmK6+an4vqZjSCYooUfn8t9dzl59BzQeZ+CIxmMtjB0SfQusPlnI2N57WpIGQRmu3/PlsuPoLkjZAYu/Q64FLsM8HwC0nPa2G0RdJnL7zVf5lPnDOes1yKuw6kPD61tgdsu84Pi7EjCaJZEOXkZtdFc2fNdi8ziAKg29KczT1aLuRWjvpjqeUqf9lV2GQV55YhVw5eoka9peG87DmD5j7YAvxax1ldYKQ2vQuvXYoxVXaLpezdqEIYz66guwbpo8QUp8Acm7Yi3EjWnod0kNTVFVWo4pHIdQTvbgC9D2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/Jnlxw9V/9Ny04bI0Wqgq4KGwLhVc2D9BpabSXLveXg=; b=jGWsI1t1BvLBm1MFQ1k6RpQW0XQXG2Rg2pApXoswphht7gfqPfbrRc02dCuIbsiGPoxAIenvaaMvZFz7MAzcMwBYF7mwvbF4rQ2TriPjJuSta8v4AbicHS8lnRo3kwoYfm07+bYA5oq4xYdZqYVzmw8DB2r6oAsD/U3YdY3fvzA= Received: from AM5PR0402CA0018.eurprd04.prod.outlook.com (2603:10a6:203:90::28) by AM8PR08MB5667.eurprd08.prod.outlook.com (2603:10a6:20b:1d8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22; Sun, 21 Nov 2021 16:57:11 +0000 Received: from VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:90:cafe::65) by AM5PR0402CA0018.outlook.office365.com (2603:10a6:203:90::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.20 via Frontend Transport; Sun, 21 Nov 2021 16:57:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT049.mail.protection.outlook.com (10.152.19.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4713.19 via Frontend Transport; Sun, 21 Nov 2021 16:57:11 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sun, 21 Nov 2021 16:56:51 +0000 Received: from e124191.cambridge.arm.com (10.1.197.45) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend Transport; Sun, 21 Nov 2021 16:56:51 +0000 From: Joey Gouly To: CC: Linus Walleij , Andy Shevchenko , Hector Martin , , Joey Gouly Subject: [PATCH v2 11/11] pinctrl: apple: return an error if pinmux is missing in the DT Date: Sun, 21 Nov 2021 16:56:42 +0000 Message-ID: <20211121165642.27883-12-joey.gouly@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211121165642.27883-1-joey.gouly@arm.com> References: <20211121165642.27883-1-joey.gouly@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7f350dcb-3fbd-4c08-6bd8-08d9ad0ffbbe X-MS-TrafficTypeDiagnostic: AM8PR08MB5667:|AM0PR08MB4113: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:2803;OLM:2803; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: KJyJnLVKA+VPNS/DbEzWDAc2kUfYRAMubsG2Cfy+5i4ItaGQIpKMe0516YpdZIa+9UGMQzXdzTvE5I20yaswKqgGpbRz6qGmkGqd5hZGGY5Dzr1JLcKKl0hnOryVLmY3D/eonLixm0YkkpV6n8EmDC0DYrBWOUfYf55z0KY6aqKbqBSxun+rfmYYPipIDqC6ycoUCelQMVqXAwVAjBQ4wbKczq1OGp5Sl/HgYCnvClhwuQoP6ASIyJOBlLoeqSqfsquxTTpc00BKs8om25r1YeJTSD4K2mqn3l+SCJ4s0aBluvM4riW47duOyy8eZfkItF636b/8JLQtzGzD3ihgtkwvpuQajX6TD1hHLM136q7jPpCAadz/p8nA5NIzmz/IUlCxdkpGaiFjN1BmNcG/WsdDRZgYR0YjbScXl4eVndGTDDFKUnYP1KbykzkZrwEM3hoUU8bwpMxX5YdTrox1LrYd7oMhrijAB0ynqXeTHRdJw6EaRO1NRbO2BA4umaaYYti05vKAhehBZSmG5vwQp+k34dwn8BphkhvBO97nYd6rZo4rc3D8ZbifqG98ByKPzztm8abEKA6mN0enBJ8i73VgSr868NaEiH9ppuFhJqCL8NFVsSSYIf/mFuQgOmD+7veyLZpaiwJOiUSBf5rJ5E2vPCmwoXednbGOdAL4oXJ0wvgMvx2hwhwmlHQB6uSHmbT1m1Zcfkj5Iucck0fbvNtI3riT73UkvuCpATvR8+cAc6C7LmpYA/DRPBHWMhkUmg3aKxzUZXTDupxvs08kxA== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:nebula.arm.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(4636009)(47660400002)(46966006)(36840700001)(316002)(81166007)(26005)(508600001)(186003)(86362001)(5660300002)(2906002)(4744005)(1076003)(356005)(6666004)(4326008)(54906003)(7696005)(6916009)(70206006)(36860700001)(426003)(8676002)(2616005)(82310400003)(336012)(47076005)(44832011)(8936002)(70586007)(83380400001)(36756003)(46800400005)(36900700001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5667 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 7119e7e2-109f-40c4-3973-08d9ad0ff610 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O2sVXbUIOP+8Z658TaBEtq43TCOcOqz0UfTArH03xCr4agompQVwvB+hor3PD35ewy5L7j1hz3knBHa5BI8L3VULcgHiigFEumLD/m/nTT2TKrDnlnJTVnJp2T1wdzsZ8h9vUC2Ol1Uox+W4X3qPfyC/e8Yj8E9eDnnUI79fFqQJHWenJ25hmedIDl4YxcMRNtBHUmoIGEdOOVdu4Yyv4ugS+zS+v9O2Z3udtIJ5fEmoFvYZL9wzhqhkpV7Nv2VdPB05RSaVowDil5c2QRIcIbCs4aWSJy6NB51R3siilmaK7oJsEEIYC4yG3XBHcI9/8BzAgdsyOuKdpoIhgx34OlMv8nURE0QH0jSktEvEPxY9quGepoQgMMy6DGXLQOX0McuIZjJ7vtnL/F6L8kBRbDyIjgv0AWZgta134OsX25/FxYbi3bMFLAhRXIMRcfWXDtHG6wH8ut0IPcFYpM/mPbsUceryeKGM3VSD5BstpwzGbqFze5snr4oXkSrmI2g/diU7WNoFnxOH06OXZMRxtc1syVwLEqd3X4DsVfWrfsfvaisw7/BfLW0vSlrXs5Ac3lqpLfPoFYq3yIqwgJJUnRE+ZYRXl0qbHB3Ds+KDWUNzSth4PswT+RGXjfiZcd/90mS22GhgAFgfRYoDRL5NekNZa2Kj/6B5bNXaniepc30f8bSTGGt37DRAUWkrmxFWxAriZ5qio2Hd7vbVTqfj/crG/uNpaPBu8eR1jWhcp+A= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(47660400002)(36840700001)(46966006)(2906002)(8676002)(5660300002)(26005)(82310400003)(8936002)(36860700001)(81166007)(6916009)(316002)(86362001)(1076003)(186003)(36756003)(508600001)(4326008)(2616005)(336012)(6666004)(4744005)(54906003)(44832011)(7696005)(83380400001)(70586007)(47076005)(70206006)(426003)(46800400005); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2021 16:57:20.8251 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7f350dcb-3fbd-4c08-6bd8-08d9ad0ffbbe X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4113 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org If of_property_count_u32_elems returned 0, return -EINVAL to indicate a failure. Previously this would return 0. Fixes: a0f160ffcb83 ("pinctrl: add pinctrl/GPIO driver for Apple SoCs") Signed-off-by: Joey Gouly Suggested-by: Andy Shevchenko --- drivers/pinctrl/pinctrl-apple-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-apple-gpio.c b/drivers/pinctrl/pinctrl-apple-gpio.c index 8a58c862c33a..89602aa14c6a 100644 --- a/drivers/pinctrl/pinctrl-apple-gpio.c +++ b/drivers/pinctrl/pinctrl-apple-gpio.c @@ -119,7 +119,7 @@ static int apple_gpio_dt_node_to_map(struct pinctrl_dev *pctldev, dev_err(pctl->dev, "missing or empty pinmux property in node %pOFn.\n", node); - return ret; + return ret ? ret : -EINVAL; } num_pins = ret;