From patchwork Wed Oct 27 23:25:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 516288 Delivered-To: patch@linaro.org Received: by 2002:ac0:c404:0:0:0:0:0 with SMTP id t4csp1083758imj; Wed, 27 Oct 2021 16:23:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz/hppxV4kzBmDZBA0abSAUSM0djrs1qMaBZXSfKTlf7UCWxQpBEk8kchMZz3dgd0hsvH3h X-Received: by 2002:a17:90a:8b8a:: with SMTP id z10mr282611pjn.20.1635377015405; Wed, 27 Oct 2021 16:23:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635377015; cv=none; d=google.com; s=arc-20160816; b=LjtgoImrfgPDmQ7wsZIvdg19uLRFW02HDbGEWxgbmb/xDJvHuOc+lwZi7pQ5WV2/OO zCrPqctYhuSDQFLpGYj7u3rUY92H9VzepCU/d4mQwSHPPvtzK8AThIGk2hMnUZcQB1av ZKwNY1oUl7a5fKzqeWzNtRPAaZPIS9ARglPEAHYep1CjCsyxD5THarhAmJbZoz80M+vp lKJCbONKLZlWl6JnJHAJkDstOQIXdrXkel8wvCVvTQXSkVha+8Oi5IMfJabDQa3/197V FXe30hsWu5Q24D5l1KvyQqjbLRzJRKXmQOW7mo4Qw7urWREmCXJ2ziW9N2iFAfjhfGJY cF8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :mime-version:message-id:date:subject:cc:to:from:dkim-signature :dkim-signature; bh=U3BfwcD3UytDwPb+tOWlIPUAvW0gBTOUXT/9RZEBqMY=; b=vIT1OSs5zlFFb55blkLgxv7ybyW+PbPZ1gD5qEDJHF+Nz3q2dtrlxMYa1eXYGigxhV M8HW5XqS8JAZeWhO+YgbKT6/AeH7fbvElYM8AIy+icfpoiGt5mtI4C+WAbC27jHviWPa pBSASTv9+sMpeEmv1bu+6sy05AuDvIM1DoOl9PQlo/c0n6PCWFQm5AjWYwONmbCeXbg4 Jufl9Lg1E+qyjc5nIIZ1Iquc728JwxRwOrBQXJqcqwnKZnYwx63HmXFR79VvTMXcn6Pf dby2Xx6U3r2+4MBe1FCJodyJi4Q0CijBgsoUuiw/QmJdaLeQdh7cxrhNozVdQlnGGKjH rypA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20210309 header.b=zqjsT11x; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=L6Okokgh; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id l6si1790312pff.207.2021.10.27.16.23.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Oct 2021 16:23:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) client-ip=2607:7c80:54:e::133; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20210309 header.b=zqjsT11x; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=L6Okokgh; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=U3BfwcD3UytDwPb+tOWlIPUAvW0gBTOUXT/9RZEBqMY=; b=zqjsT11xof+07v VhUfBP4EAZxW5WLvUzdDxqY23b3lXXtxPoBY3ImdzBTupLvOUHKioIzT+0/Z3qSAFn0sLlHWwb4pA Ozn/bodlfMhIPjY3VUgdD3l7gcchRfD+vWb9ntepz7W+iOft+MDCF1Ilo2bMGLfsz5Fs/sAn243s9 KxAIllrrXBaDNVA8vZpyDy2xBEw6oSJTw8R07zH29M4yIAKkn2DXLTgB1+UBFQRJqgpVmILbPRc5V r8Ouu1OH2/bi/9mn8nPHXKyaAS5Lt7kNxp4ynt48lEsmKhmaG1SipTGLkxH5iYQOWvbt+lNjdYj86 17uA2ocKh5h146DAY/WA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfsGc-006UDg-4g; Wed, 27 Oct 2021 23:23:34 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfsGZ-006UDL-SK for wcn36xx@lists.infradead.org; Wed, 27 Oct 2021 23:23:33 +0000 Received: by mail-wr1-x435.google.com with SMTP id d10so6862401wrb.1 for ; Wed, 27 Oct 2021 16:23:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=F1kzwP0JYJEJZtRxZX6aGDTnXu7MfQJRi7LeHOrAvTM=; b=L6OkokghhCoD7PH2pbu4qrnD1/JZBiFujSS4Me9HOY68fZDOkoF53enf+xZiurYxyt Cjw4CdK+lXZAOfkPbDKWUisC4E/pOebsGzuaGAABkPzW1PAdvBFP7MAsXyMmygtEG8LI EfCDfcm0s0s1L0eh2aD3IlFNttKObqOoD/KwedlJYfCBwEBr/ukPqbE1l+4FP+RDeqqB SRKKg3nmCX93AkvOV5cp5Ld7sh/WLJhdsjPkZbZAmzcktXiY+P6Hx3EKP56Ys9eqTJJX VEZRIbhaH5vjG+w6RYSQKB/bnzyLDTXwWCPsppKMkyWlgyGve9Qby5PGIqcTjZ1vR0hb yIDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=F1kzwP0JYJEJZtRxZX6aGDTnXu7MfQJRi7LeHOrAvTM=; b=elo91iIKcuJ6C4NdnN8DkwNsi/CE4pgEGaZ78H0lFRmgEUZskK5vBIXjBMA6S3Ltxv 9oh9zR9qYnzWEn442y/XGIlN7+HhViNh1JtDdeHmxmtzlrklHf6HfflnIWnK1qwc3oIe RIEQ3DdF0C6Iq0MbQt6l5eBnRmi16PyEZSq4FS2V1VTpWwD5ww60lUyaJ+kLQXAOQ4YP vx+1Q99B5x7+6S90fdcCYzK6XF5mhOGocPbIXy+lnRbAu2SoSzBADOX9xkedrUXllhUV +mplmL61Ri+VhQ6CyR2z0nLOKQk1W6awzkhuRu7vgmWv110/oFQNFGtwDUn4YWNKlj/a +M5A== X-Gm-Message-State: AOAM531GQiUTCKidiKKWgPsAzW/K61vmBsbVB8RZ9IpzlW84mDArmpFJ Pt+kCVlqbzSicmcbjRil+K/iXA== X-Received: by 2002:a05:6000:1866:: with SMTP id d6mr867656wri.226.1635377010436; Wed, 27 Oct 2021 16:23:30 -0700 (PDT) Received: from sagittarius-a.chello.ie (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id o17sm4937435wmq.11.2021.10.27.16.23.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Oct 2021 16:23:29 -0700 (PDT) From: Bryan O'Donoghue To: kvalo@codeaurora.org, linux-wireless@vger.kernel.org, wcn36xx@lists.infradead.org Cc: linux-arm-msm@vger.kernel.org, loic.poulain@linaro.org, benl@squareup.com, bryan.odonoghue@linaro.org Subject: [PATCH] wcn36xx: Indicate beacon not connection loss on MISSED_BEACON_IND Date: Thu, 28 Oct 2021 00:25:29 +0100 Message-Id: <20211027232529.657764-1-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211027_162331_992058_DB9FB62F X-CRM114-Status: GOOD ( 11.62 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Firmware can trigger a missed beacon indication, this is not the same as a lost signal. Flag to Linux the missed beacon and let the WiFi stack decide for itself if the link is up or down by sending its own probe to determine this. Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:435 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: wcn36xx@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "wcn36xx" Errors-To: wcn36xx-bounces+patch=linaro.org@lists.infradead.org Firmware can trigger a missed beacon indication, this is not the same as a lost signal. Flag to Linux the missed beacon and let the WiFi stack decide for itself if the link is up or down by sending its own probe to determine this. We should only be signalling the link is lost when the firmware indicates Fixes: 8e84c2582169 ("wcn36xx: mac80211 driver for Qualcomm WCN3660/WCN3680 hardware") Signed-off-by: Bryan O'Donoghue --- drivers/net/wireless/ath/wcn36xx/smd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.33.0 _______________________________________________ wcn36xx mailing list wcn36xx@lists.infradead.org http://lists.infradead.org/mailman/listinfo/wcn36xx diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c index 599cb220b150e..aee4123035d71 100644 --- a/drivers/net/wireless/ath/wcn36xx/smd.c +++ b/drivers/net/wireless/ath/wcn36xx/smd.c @@ -2647,7 +2647,7 @@ static int wcn36xx_smd_missed_beacon_ind(struct wcn36xx *wcn, wcn36xx_dbg(WCN36XX_DBG_HAL, "beacon missed bss_index %d\n", tmp->bss_index); vif = wcn36xx_priv_to_vif(tmp); - ieee80211_connection_loss(vif); + ieee80211_beacon_loss(vif); } return 0; } @@ -2662,7 +2662,7 @@ static int wcn36xx_smd_missed_beacon_ind(struct wcn36xx *wcn, wcn36xx_dbg(WCN36XX_DBG_HAL, "beacon missed bss_index %d\n", rsp->bss_index); vif = wcn36xx_priv_to_vif(tmp); - ieee80211_connection_loss(vif); + ieee80211_beacon_loss(vif); return 0; } }