From patchwork Fri Sep 24 16:45:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anders Roxell X-Patchwork-Id: 514580 Delivered-To: patch@linaro.org Received: by 2002:a02:c816:0:0:0:0:0 with SMTP id p22csp1661060jao; Fri, 24 Sep 2021 09:47:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy1QCZO5VcPr/V86D/x9o/rj91KsHHD3gcqNWx7VdEMV3h8KeJJOiMgPhhREDC6biDmswQi X-Received: by 2002:a5e:c110:: with SMTP id v16mr10066273iol.43.1632502022246; Fri, 24 Sep 2021 09:47:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632502022; cv=none; d=google.com; s=arc-20160816; b=oWloB0MNRXtGsMl3w/RnrWRCGi/9RM2u6BFPri6YT/O8cLPeipLqlIbRLRmB0Zugv+ +ByqElQqmf7TNHYy7JbjstRsAgMmcw3p2MDQuZw7npANIzdwwMhLdX/LJSBiK7Udo7RB c4mcaQ+rbSeGBaoXhpATVlt3XfsBBg5PDSJ6vCNHiJYWqqxTB2ZHMfH4t+7NOqTNneCv kXs0YHmiN9rfb1BA3uhYB6wN3dhZ87z7vRB01GRE6O5DuCN/Qn5l6WqUsrjDbIiQshqb dCJZFKj3le3Wzxoh944SrWtlhtLXxpGcw+9j4B5EgojP1EPSgv/DPM1gUbaKLREtcpVA Qorw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=1LAFg9M6uAMZeoujQ1jnGXzcNs1IsGlEHiARal+gy88=; b=Qg/uyvlOf6YLNAE1SLqsC23o0CBFoxDZ53TxUi8e7kd4tnRJ/2dPVBYe9J5Vz3sd/o gfVYsXwhxa2ksvbo/38p3gb0jWF6FH7PWp25GEweVqu0Wy+LATyKWMbPsKO05WRU36Zj Ap9OpuynK1gpkIF1u4mAzxK+4sRFe7lNjkf1KjAzKuW3yQrSqdUKSGFPKuNAjK6B01H/ mogHI3ZC4w/YM399p1b1yEZUim+tIC5LvPSuXfW/3hjmd/aiZye7S6KQpp4lLYzQG/H1 sOCUyxORmP3mwgWtaAIUztr75chxubYZ4XBlLOvFRoniE8bplfWZ7vyNiG2e6TAeZJ8+ 6y+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zyMfc6Sa; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p13si7127409ilq.119.2021.09.24.09.47.02 for ; Fri, 24 Sep 2021 09:47:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zyMfc6Sa; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245753AbhIXQse (ORCPT ); Fri, 24 Sep 2021 12:48:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240648AbhIXQse (ORCPT ); Fri, 24 Sep 2021 12:48:34 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DA0BC061571 for ; Fri, 24 Sep 2021 09:47:00 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id b20so43030500lfv.3 for ; Fri, 24 Sep 2021 09:47:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1LAFg9M6uAMZeoujQ1jnGXzcNs1IsGlEHiARal+gy88=; b=zyMfc6SalycpiXBUP16WblX0n0xkfb9/raUzu66BUucj9skaySnVkYUSE+u9F8tlve YVY8+4D6xrnlHKDRkgP5IgHYWxBXgDBKoFyOmH19YWZSUjWUpuUkJlizTgCASUrq/IDR DT3ECrARMWWdaOaSvjkAlkf7Sco2KBa8Jd9hRLEioQHyszXg5j/sezdF70/DeL4yAu6b 19SFcJfmEcEu3Sr7rEPcfs+03j11mYrUIwt8qOSx8O4Nx6/2UL/PDlQjPTvh5sXVOa7X hPSIM2D5dL347h2Mf0nxxflViB0qJhp7VDOs8W1kj4zq2ynk7C9JukB7VuDbd2pTzH1k 3bxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1LAFg9M6uAMZeoujQ1jnGXzcNs1IsGlEHiARal+gy88=; b=1DFvv+GiV50UsrscKUDw9EyTV8rlTjEFjLPSsOCGxxMJu6Al3lBrRidMbx5k6t4Rfh 05kdWTnAlqyeJzbyGF88TvAX+GsIQnYIocDtXsmROz/CxAuP3k9gt4cPi4s9M91sR/80 PanEGXNSI+n02VV+hllhzl6VGPvGn3nhNl4QuPxK6Qj2/o3AFt06DLuuQIn2PbGtt+l6 cef7lrjypmn/jRxEvt1O2K0T9ya4lyGVnH9lbS7cjtwVuENQhQThPvKVy6z0uDgJI/95 UXBiroTkgpq0xPggXPItgA/N/Ms3qImDi9mLFXYHA3vyZ4jAGU2da7F7lTlvf+FzOOAI Drfw== X-Gm-Message-State: AOAM531vODAQ+S2zAO1rLw77PH6M9iglSylwBgh7F23H8yWKUTW19RIG 9d543QlGWuVHn318lAsZ/Mntyg== X-Received: by 2002:ac2:4e0f:: with SMTP id e15mr10019887lfr.308.1632502018951; Fri, 24 Sep 2021 09:46:58 -0700 (PDT) Received: from localhost (c-9b28e555.07-21-73746f28.bbcust.telenor.se. [85.229.40.155]) by smtp.gmail.com with ESMTPSA id z2sm802266lfr.194.2021.09.24.09.46.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Sep 2021 09:46:58 -0700 (PDT) From: Anders Roxell To: jejb@linux.ibm.com, martin.petersen@oracle.com, jdelvare@suse.com, linux@roeck-us.net Cc: avri.altman@wdc.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, Anders Roxell Subject: [PATCH] scsi: ufs: Kconfig: SCSI_UFS_HWMON depens on HWMON=y Date: Fri, 24 Sep 2021 18:45:30 +0200 Message-Id: <20210924164530.1754128-1-anders.roxell@linaro.org> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org When building an allmodconfig kernel, the following build error shows up: aarch64-linux-gnu-ld: drivers/scsi/ufs/ufs-hwmon.o: in function `ufs_hwmon_probe': /kernel/next/drivers/scsi/ufs/ufs-hwmon.c:177: undefined reference to `hwmon_device_register_with_info' /kernel/next/drivers/scsi/ufs/ufs-hwmon.c:177:(.text+0x510): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `hwmon_device_register_with_info' aarch64-linux-gnu-ld: drivers/scsi/ufs/ufs-hwmon.o: in function `ufs_hwmon_remove': /kernel/next/drivers/scsi/ufs/ufs-hwmon.c:195: undefined reference to `hwmon_device_unregister' /kernel/next/drivers/scsi/ufs/ufs-hwmon.c:195:(.text+0x5c8): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `hwmon_device_unregister' aarch64-linux-gnu-ld: drivers/scsi/ufs/ufs-hwmon.o: in function `ufs_hwmon_notify_event': /kernel/next/drivers/scsi/ufs/ufs-hwmon.c:206: undefined reference to `hwmon_notify_event' /kernel/next/drivers/scsi/ufs/ufs-hwmon.c:206:(.text+0x64c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `hwmon_notify_event' aarch64-linux-gnu-ld: /home/anders/src/kernel/next/drivers/scsi/ufs/ufs-hwmon.c:209: undefined reference to `hwmon_notify_event' /kernel/next/drivers/scsi/ufs/ufs-hwmon.c:209:(.text+0x66c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `hwmon_notify_event' Since fragment 'SCSI_UFS_HWMON' can't be build as a module, 'SCSI_UFS_HWMON' has to depend on 'HWMON=y'. Fixes: e88e2d32200a ("scsi: ufs: core: Probe for temperature notification support") Signed-off-by: Anders Roxell --- drivers/scsi/ufs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.33.0 Acked-by: Randy Dunlap # build-tested Acked-by: Avri Altman diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig index 565e8aa6319d..30c6edb53be9 100644 --- a/drivers/scsi/ufs/Kconfig +++ b/drivers/scsi/ufs/Kconfig @@ -202,7 +202,7 @@ config SCSI_UFS_FAULT_INJECTION config SCSI_UFS_HWMON bool "UFS Temperature Notification" - depends on SCSI_UFSHCD && HWMON + depends on SCSI_UFSHCD && HWMON=y help This provides support for UFS hardware monitoring. If enabled, a hardware monitoring device will be created for the UFS device.