From patchwork Thu Nov 1 10:16:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 149947 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp602926ljp; Thu, 1 Nov 2018 03:19:26 -0700 (PDT) X-Google-Smtp-Source: AJdET5fHFHvMY2LEh/OmgW2FGoGZd89sCqid/FTsi9QIbW6OV6l31e6NdVHcMi+vNbwkVWYtYk1/ X-Received: by 2002:a5b:9cb:: with SMTP id y11-v6mr6780304ybq.83.1541067566196; Thu, 01 Nov 2018 03:19:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1541067566; cv=none; d=google.com; s=arc-20160816; b=veY0dlIVqHWVdftjAevi82IpM3kMCraxADx2yT+091mFGAyjJIURSJJaO2j/pr3gDa CDYkUi4OdWPArdPNNe2mLfI64eae8Ry4jvKwSJwZgoUADySCygORAxixM+ggxK7taxtI A7tdSdVXKQ5ZWM+YIXmI9WB4eZzuHLjzyhQCHksFH5AJdU6unXPD1va+uwP8Bn/zKA8s OWRSxNqXKtUum4ezrpdlzhapoW8ouCUvHDbJQIlAAbchxEDK2hcfp4cWzULxayiF/RqX FAgp+x9ljIS+kNGqDgleb8nXizXXkPVPgHAr2aoDYgqLQCqCCCuaEHHun/i+E2NbfdTh shgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-unsubscribe:list-id :precedence:subject:message-id:date:to:from; bh=oKytY7+UScZ+ZH2RjYiZa/FqBKwa+bAAzinHegjAIOc=; b=C45w/LMuxfw6J1SRtyCiPwtyAFSooN4kxIliCAFucAjjPy0TrwAyaWge2dgKxMDgJP avKQUhuEr3eG02a7SxD51Djb+WfzyH1ifOSHSNwCo8T86FwQTPmcoabpFiXigjP8AHsg JlgqP16QWP0/eM72hSOS+fjxo2fDNfryqcyG20xoMXr0J06PpXNY98IPkG8WDN3Os+TO wiWWV/gP3zDshPzz/YeSbh4lrX52F8lbIW5QS/dv+tg/vZYw0u4tz8pT9SFndC/4rTYc Bq9E+gl6vK5eUE2LeKrMarnhJcczsOI3/5iAealaajxnL/OgyPAoKReaoA+MxAjWkZot DG2g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id o7-v6si18026114ybk.27.2018.11.01.03.19.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 Nov 2018 03:19:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gIA2H-0003OW-FX; Thu, 01 Nov 2018 10:17:09 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gIA2F-0003OR-N4 for xen-devel@lists.xenproject.org; Thu, 01 Nov 2018 10:17:07 +0000 X-Inumbo-ID: 48c1bfd5-ddbf-11e8-87d6-bc764e045a96 Received: from foss.arm.com (unknown [217.140.101.70]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTP id 48c1bfd5-ddbf-11e8-87d6-bc764e045a96; Thu, 01 Nov 2018 10:17:06 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 06469A78; Thu, 1 Nov 2018 03:17:06 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.196.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 27D133F71D; Thu, 1 Nov 2018 03:17:04 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Thu, 1 Nov 2018 10:16:58 +0000 Message-Id: <20181101101658.31442-1-julien.grall@arm.com> X-Mailer: git-send-email 2.11.0 Subject: [Xen-devel] [PATCH] xen/grant_table: Remove stall comment on top of map_grant_ref X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Konrad Rzeszutek Wilk , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan , Julien Grall , Jan Beulich MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Remove the 2 part comment on top of map_grant_ref: - The first part mention the return value which has been void since 2006! - The second part mention a local variable 'addr' which does not exist anymore. Signed-off-by: Julien Grall Reviewed-by: Andrew Cooper --- xen/common/grant_table.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c index 878e668bf5..0b5894a070 100644 --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -890,13 +890,6 @@ static unsigned int mapkind( return kind; } -/* - * Returns 0 if TLB flush / invalidate required by caller. - * va will indicate the address to be invalidated. - * - * addr is _either_ a host virtual address, or the address of the pte to - * update, as indicated by the GNTMAP_contains_pte flag. - */ static void map_grant_ref( struct gnttab_map_grant_ref *op)