From patchwork Wed Oct 31 14:42:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rob Herring \(Arm\)" X-Patchwork-Id: 149838 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp6880340ljp; Wed, 31 Oct 2018 07:42:30 -0700 (PDT) X-Google-Smtp-Source: AJdET5dnQNWiRBFgvQRamBzkJ3buvqHTXe+6Cu1zffLTcV1aFxH+V4WyM+oOXrizPTkLZgEPTJRP X-Received: by 2002:a63:4904:: with SMTP id w4-v6mr3432590pga.303.1540996950331; Wed, 31 Oct 2018 07:42:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540996950; cv=none; d=google.com; s=arc-20160816; b=rxvVpm6RpJiSgFSwXZWElW4iuzNpRhOgf+VrEVyXeBEmBT1RWGs0nnXCQ/iHUmZr+3 UZdqn0gcAuvqiRJhd3AUFxvjgISz2T1UXCBrvvfDZq3eli0vJxlSO5RgQVMIZKcOnM0i nyBuVvOvjtJFTa0PJflTQquMVrJ3b897fhCDf3nxx8OtQAlkuMZoZOM7n6SeqLb+Fqjw 6Mh3sWRq8lhFx5JRZq5YGOxhxkGcDnlpdHqilEohRj338+pO11/k24eVFkFS27kV0p5m 8UPZSzbeyf0WsAmtmw0g+Gcz3Ap8Zp3r+xrwGeyTd/oL+aiahknh5IrMwTShKfChLkLd ls3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=zrGlurET2Jt29KSx4p05ubi1A5A5HoCWodQot7XFbu0=; b=DYXlDbaLU47qlourAJ7egXm69etibp+vehQ9KqR3583Rqh9r5Coyh5wBy2s/yRElC6 ZBNxnNQvcOEBat5SCf76xkzO12u5Q6cysEwEy2yoR980z/u54uVnDCTWN+Ou5SjZ25pn BWg8xAiJ0ton3ZJMSXGb/C71NYtvROtZr6n1MBODudJgJL5Z541g/wqBT99nvaioqJhs tRmzGbvgfJAzgv+L87HNMVsQcgEcABjTIehCpL/J/a1X7qftGKCed0EeZv1EVXxKhZFk BseP2ktN4+aK2bAy9hWC4KOI/nYdXz9da+uqpfvJrPU8D/rr3oNqN1qTxqclOeUnoMq/ HAdQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g70-v6si23555451pfd.86.2018.10.31.07.42.30; Wed, 31 Oct 2018 07:42:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729593AbeJaXkr (ORCPT + 6 others); Wed, 31 Oct 2018 19:40:47 -0400 Received: from mail-oi1-f195.google.com ([209.85.167.195]:43912 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729492AbeJaXkr (ORCPT ); Wed, 31 Oct 2018 19:40:47 -0400 Received: by mail-oi1-f195.google.com with SMTP id j202-v6so13362693oih.10; Wed, 31 Oct 2018 07:42:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=zrGlurET2Jt29KSx4p05ubi1A5A5HoCWodQot7XFbu0=; b=Ue3LgkxbEahSU7hbfQGDiTdRqUMiEW2cdeLyRn35Mt/8YbteKXuAiN8SYUqmCbzOFo 7GcNdPyztFJf66b6/PMpx8CZj6yBhNsrR4WASxVsl0JxHNU4i6z8OQiZi2uArQF6/0kB LOdCtZm3j2zw42kIcSr7NXzK5IxrCgSpI64Dr+N4L5H3nR6u+CXfp4Y+26EK7zN9MoyC qymY3+qTwLGpqB4L5E6jdhl/m7+b20GckDXgD1LDl/z/TaHixc/HheB+YCBtp34y9CGI CKXVqSsDcukc2vkROaWqDnls9VvqhOHegHhkNU2jxsORgo8WP7yfYA0kDHcsRbDoVzWM DV8g== X-Gm-Message-State: AGRZ1gL766EMm2v8ahAHrva6Evw29R0p2KI7QQ3GHSx2Ddhbey9o8Sjh nN4MuQ8rBzTwhV9JaslAhA== X-Received: by 2002:aca:e144:: with SMTP id y65-v6mr2046040oig.289.1540996948110; Wed, 31 Oct 2018 07:42:28 -0700 (PDT) Received: from xps15.herring.priv (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.googlemail.com with ESMTPSA id d131-v6sm12381705oih.4.2018.10.31.07.42.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 Oct 2018 07:42:27 -0700 (PDT) From: Rob Herring To: Michael Ellerman Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Zigotzky , Frank Rowand Subject: [PATCH] of: Fix cpu node iterator to not ignore disabled cpu nodes Date: Wed, 31 Oct 2018 09:42:26 -0500 Message-Id: <20181031144226.26747-1-robh@kernel.org> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org In most cases, nodes with 'status = "disabled";' are treated as if the node is not present though it is a common bug to forget to check that. However, cpu nodes are different in that "disabled" simply means offline and the OS can bring the CPU core online. Commit f1f207e43b8a ("of: Add cpu node iterator for_each_of_cpu_node()") followed the common behavior of ignoring disabled cpu nodes. This breaks some powerpc systems (at least NXP P50XX/e5500). Fix this by dropping the status check. Fixes: 651d44f9679c ("of: use for_each_of_cpu_node iterator") Fixes: f1f207e43b8a ("of: Add cpu node iterator for_each_of_cpu_node()") Reported-by: Michael Ellerman Cc: Christian Zigotzky Cc: Frank Rowand Signed-off-by: Rob Herring --- drivers/of/base.c | 2 -- 1 file changed, 2 deletions(-) -- 2.19.1 Tested-by: Michael Ellerman Reported-by: Christian Zigotzky diff --git a/drivers/of/base.c b/drivers/of/base.c index cc62da278663..e47c5ce6cd58 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -776,8 +776,6 @@ struct device_node *of_get_next_cpu_node(struct device_node *prev) if (!(of_node_name_eq(next, "cpu") || (next->type && !of_node_cmp(next->type, "cpu")))) continue; - if (!__of_device_is_available(next)) - continue; if (of_node_get(next)) break; }