From patchwork Fri Sep 10 14:16:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gokul Sivakumar X-Patchwork-Id: 509391 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5E55C433F5 for ; Fri, 10 Sep 2021 14:18:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF2A261026 for ; Fri, 10 Sep 2021 14:18:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232242AbhIJOTb (ORCPT ); Fri, 10 Sep 2021 10:19:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234038AbhIJOTT (ORCPT ); Fri, 10 Sep 2021 10:19:19 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 829F3C061574 for ; Fri, 10 Sep 2021 07:18:07 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id g14so2012587pfm.1 for ; Fri, 10 Sep 2021 07:18:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=OMwkUe+0yoW+A2+6v5xt7NkklVccYWTe+a7hUuUevc8=; b=qBEe5lc5u0v4/l2QbhiQfOCiZPti+vQLTeNYMJr4aCNVIrnn4RNiEdHRg55c1pNMCW 9O4a2sU6dr+PnRDLmpnC5doNbAgWCDpXbQGQOHH2J4k+JfHlOtdlbSNxeZz4F+gJF9P4 //lktNjKjTevw+oJ4LC/1zlKLK70EAYWBO3b/M12H2+uCEWeIX4HpTki24SrUHEAJqcn gVUZt1B8TNk1GnXwvjDa2BzsX7UpCF96Hl4kRTlhYh4MV9L4Nbr14H7BJKGT+uc2k3QZ xH30PqLYQdcxHPIyQWpC5NMMMhxm08vCRXiMt3k39iloN2F7q0OLWeEc6WANqNUob/4C 8X0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=OMwkUe+0yoW+A2+6v5xt7NkklVccYWTe+a7hUuUevc8=; b=IWvtosPYCd39L7pG/7JiGVgdi/tVdQGGjgWiP/rIIYu5RLoRgmHRr3RE/8evAsET3l nEbb6jWWd9tv46DBdYqgiOwKRYRTro4IyYpyO/gWP+PQ2DH6j3j5zKG7cHCWAsOmX4Ub 2HqnnK4pQuQruYQSTCz/D7AH+l8kV7hi7c8+wZyXFQ7wRUtGkFJHR69fPW1a8Yn5UKB6 fRq/SR8+McwC4sKFJneCX8UXsQ+Aj0/wEzT4Z9tz1x1C6XWxDTwWfKfuu9i6cD3BcWnH 7eL9lN9z/27L+iwGcZMOcU4xix4Sgl8PzQZowi+a58Zo/Yxu6DlDHWi+9Ei3tjpKV54H KWFQ== X-Gm-Message-State: AOAM532uScxuvlm+y1ozN1BVnE9PeDBHOYO90igMl7HBBGW2hoqd2+ln fBGrwLGMnSQEzrxjHdH5Zvk= X-Google-Smtp-Source: ABdhPJzU22GZJVWbXbFkfLttfZf46nDbAOa26nFzVxfc6mbgD2X3y4kGySgPZ4zjbyM6NX2Ix8pdOA== X-Received: by 2002:a63:3717:: with SMTP id e23mr7624958pga.10.1631283486944; Fri, 10 Sep 2021 07:18:06 -0700 (PDT) Received: from localhost.localdomain ([49.206.113.222]) by smtp.googlemail.com with ESMTPSA id q9sm5079519pfs.40.2021.09.10.07.18.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Sep 2021 07:18:06 -0700 (PDT) From: Gokul Sivakumar To: Johannes Berg Cc: Gokul Sivakumar , linux-wireless@vger.kernel.org Subject: [PATCH iw 1/4] iw: nl80211: add NLA_F_NESTED to nla_nest_start() with older libnl versions Date: Fri, 10 Sep 2021 19:46:15 +0530 Message-Id: <20210910141618.1594617-1-gokulkumar792@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org It is noticed in Kernel version 5.14.0-rc4+, that when sending the NL cmd NL80211_CMD_SET_TID_CONFIG with nested attrs under NL80211_ATTR_TID_CONFIG, kernel returnes a response with the error "NLA_F_NESTED is missing". $ sudo ./iw dev wlan0 set tidconf tids 0x1 ampdu on kernel reports: NLA_F_NESTED is missing command failed: Invalid argument (-22)) Fix this by setting NLA_F_NESTED flag everytime when using nla_nest_start() library function. This is needed to make cfg80211 allow the nl80211 command NL80211_ATTR_TID_CONFIG in the new kernel versions that enforce netlink attribute policy validation. Signed-off-by: Gokul Sivakumar --- iw.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/iw.h b/iw.h index a118f5b..545fd0e 100644 --- a/iw.h +++ b/iw.h @@ -11,6 +11,11 @@ #include "nl80211.h" #include "ieee80211.h" +#ifndef NL_CAPABILITY_VERSION_3_5_0 +#define nla_nest_start(msg, attrtype) \ + nla_nest_start(msg, NLA_F_NESTED | (attrtype)) +#endif + /* support for extack if compilation headers are too old */ #ifndef NETLINK_EXT_ACK #define NETLINK_EXT_ACK 11 From patchwork Fri Sep 10 14:16:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gokul Sivakumar X-Patchwork-Id: 509056 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AD1EC433EF for ; Fri, 10 Sep 2021 14:18:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0E36B61059 for ; Fri, 10 Sep 2021 14:18:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234127AbhIJOT3 (ORCPT ); Fri, 10 Sep 2021 10:19:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234055AbhIJOTV (ORCPT ); Fri, 10 Sep 2021 10:19:21 -0400 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39B63C061574 for ; Fri, 10 Sep 2021 07:18:10 -0700 (PDT) Received: by mail-pj1-x102f.google.com with SMTP id k23-20020a17090a591700b001976d2db364so1563907pji.2 for ; Fri, 10 Sep 2021 07:18:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IUqMXkCxlPNHudbb/uiPg0FjgZTFGptY3HJFCo4/ZHc=; b=WTgqIsGfc4OTPiXlzUSwbukZPfgMo73Zh6V1cMimwctHZR+R4rOhimhMFcmoQEqYQI /WlRIfO9EC2sUBK52mvobDPj57ArDxvM5n4ZY6OkroK9e7WlbmOBfiGqU8zPFc5XvXX6 /oxWG8XKK5nJzHAZmscJyozYGxHImAjB52q/QSSPvk0Yt3YZRuypxN0vISA29ASdTNr/ vCccgKAbSXlXsTKdpt5df+qKP6+ZnbPYcrGUyRjVAK+luU8GZ/6kFkW1AcZRl9wQm2at 1ku1r5ZJbgFcZAiZfng4AQDyvpugnxvKtyOQApzqGgtQW0tdXrLpv8jHVLGiUoXxqG72 9Uww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IUqMXkCxlPNHudbb/uiPg0FjgZTFGptY3HJFCo4/ZHc=; b=nT67qNPmtnbI1Q8y2m56LJWyM3o9c06J4dNJbynz/jreCt1HmhU2jJQWNWePxx9QZf QcksLc+sseLWEzRmo8tLK0cyoUjTw4/4kQc4y2bu3t2kpl5Xr8Wv4a7j+9/vpv9Zj7Ie 9H9cHl4iry4jwQaeKmfR517+Y7IaXh+Fct8UVKsnnx6p+0RYmY4sv5E1P+Z98LbCqreD 0yztxAMiJP87+PCj+d86nrYjhT+tiWmOCLDTi+PDZUaNJYcbFITDNm+l7ZhdovC44tNm ZVIBFNy5NNwhZZMsVvD87Zj5iPIjTAtiNYw1OrsM5C1AvSxrxvB347Dz5sS9nOr2Txmu A5fw== X-Gm-Message-State: AOAM532untgX3c8DnZRYY7UwcLcbbBppmFA/OdoHDDZB5PjrUudErG6S eIt34FTOtz4ZPzkYBioP8yE= X-Google-Smtp-Source: ABdhPJymV0vI0sJpipEm1nI+zCoTUdpWBknX9n5i32wTgs2NT8K8GZgav3OaCtyWoVKb5+R1ZOM6jw== X-Received: by 2002:a17:90b:1d02:: with SMTP id on2mr9762219pjb.21.1631283489836; Fri, 10 Sep 2021 07:18:09 -0700 (PDT) Received: from localhost.localdomain ([49.206.113.222]) by smtp.googlemail.com with ESMTPSA id q9sm5079519pfs.40.2021.09.10.07.18.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Sep 2021 07:18:09 -0700 (PDT) From: Gokul Sivakumar To: Johannes Berg Cc: Gokul Sivakumar , linux-wireless@vger.kernel.org Subject: [PATCH iw 2/4] iw: link: mention the need for MAC addr arg in link get_sta cmd usage menu Date: Fri, 10 Sep 2021 19:46:16 +0530 Message-Id: <20210910141618.1594617-2-gokulkumar792@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210910141618.1594617-1-gokulkumar792@gmail.com> References: <20210910141618.1594617-1-gokulkumar792@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org The usage menu shown when running the hidden "link get_sta" command is not mentioning the need for the MAC address argument. Without this, the cmd is always failing with the output shown below. $ ./iw dev wlan0 link get_sta Usage: ./iw [options] dev link get_sta ... To avoid this, let the user know about the mandatory "MAC address" argument like below. $ ./iw dev wlan0 link get_sta Usage: ./iw [options] dev link get_sta ... Signed-off-by: Gokul Sivakumar --- link.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/link.c b/link.c index 1ed7f63..2074488 100644 --- a/link.c +++ b/link.c @@ -273,7 +273,7 @@ static int handle_link(struct nl80211_state *state, } TOPLEVEL(link, NULL, 0, 0, CIB_NETDEV, handle_link, "Print information about the current link, if any."); -HIDDEN(link, get_sta, "", NL80211_CMD_GET_STATION, 0, +HIDDEN(link, get_sta, "", NL80211_CMD_GET_STATION, 0, CIB_NETDEV, handle_link_sta); HIDDEN(link, get_bss, NULL, NL80211_CMD_GET_SCAN, NLM_F_DUMP, CIB_NETDEV, handle_scan_for_link); From patchwork Fri Sep 10 14:16:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gokul Sivakumar X-Patchwork-Id: 509055 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CDFEC433EF for ; Fri, 10 Sep 2021 14:18:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A7A561026 for ; Fri, 10 Sep 2021 14:18:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234003AbhIJOTc (ORCPT ); Fri, 10 Sep 2021 10:19:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234087AbhIJOTX (ORCPT ); Fri, 10 Sep 2021 10:19:23 -0400 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A226CC061574 for ; Fri, 10 Sep 2021 07:18:12 -0700 (PDT) Received: by mail-pj1-x102e.google.com with SMTP id gp20-20020a17090adf1400b00196b761920aso1550285pjb.3 for ; Fri, 10 Sep 2021 07:18:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3AcpfS24aKz3q+yOljqV3O2C7e9Ts977E3eEPkH8QP8=; b=cYcay0RI/qfKk00v0aygiMe3TWyaPEGxl0vaIqxbS2mqPUXLPJBARL8Hxwy+mBDNkO 0pPh2yp8ittRFRP1ip5g0yCbEienq/Zf2du1+4URZ7kdHs4uK8GAvfSrMP/LKizvo20I nGf/9RhFM1hBRbU74fMSrQ/UtvEyZfxqgStqIRAswLNxJsT2X56rbixAnB45UtmmfT4V HtQ6vsbj40vAeT3eNWYAOlY9Fj2Mb35QS7TYrJlYxvI7++ySRVVhEyWecq08/Nd30am4 241jb6QblPQCX9OiojIQcv+qKOTvmL1XUp4QDVqNHP3KUDTuI85taAN4KJqHZZ+SlQbs mn4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3AcpfS24aKz3q+yOljqV3O2C7e9Ts977E3eEPkH8QP8=; b=nQ/P6k8SGbwret+xU7MZzdYaohpkcFghdc3SDIHEyc4NEPIQi3zLhoYsrHTaomIMtb 7BaKCPOAVXM/+QjTUtGKhtWGZZ+B/LBDlwQW3jmkefArXANIqSUSEJCXj6Wa0WWTlKbu B0JVG10ZFP2mQ1iLfS2N9ymMQqu95gpuPvZufdhjjJA6Ip8LqGHdNbmXJ+TMsHD9JLIG Pflxpy0CfjB1aogr8OzbGSCpwuSEM5EhKVCmw5Np3x3xlZ/TWtE7sPyDWUACWAVvP4// 1R4ZrWo8pca86ccsF6+jz4kpOwfpcJp9/wQwdpK8Qi84S83LZNT/kGO5AvfQ71vHVAyj U0rg== X-Gm-Message-State: AOAM532I3hirtMKbYf94siUBumpAg1Ypfm9PUpEoZSU7rezIJeZVaE0i 2sjo1Piemfumq3hgsfMlhLgtuJLgq/w= X-Google-Smtp-Source: ABdhPJyQZTiobPrVNObh+MAEmXL01Db6e0ojuWe8385RFf60k6T7H3ypeGgsl/pOu+NXGDx0AJRMSg== X-Received: by 2002:a17:902:6b49:b0:136:3f21:7a9 with SMTP id g9-20020a1709026b4900b001363f2107a9mr7797501plt.81.1631283492095; Fri, 10 Sep 2021 07:18:12 -0700 (PDT) Received: from localhost.localdomain ([49.206.113.222]) by smtp.googlemail.com with ESMTPSA id q9sm5079519pfs.40.2021.09.10.07.18.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Sep 2021 07:18:11 -0700 (PDT) From: Gokul Sivakumar To: Johannes Berg Cc: Gokul Sivakumar , linux-wireless@vger.kernel.org Subject: [PATCH iw 3/4] iw: event: add the missing time display format in the "iw event" help menu Date: Fri, 10 Sep 2021 19:46:17 +0530 Message-Id: <20210910141618.1594617-3-gokulkumar792@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210910141618.1594617-1-gokulkumar792@gmail.com> References: <20210910141618.1594617-1-gokulkumar792@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org The option used to print the events with timestamp in Human readable format is not listed in the "$ iw event -h" output. $ ./iw event -h Usage: ./iw [options] event [-t|-r] [-f] [-n] ... So add "-T" option to the help menu. $ ./iw event -h Usage: ./iw [options] event [-t|-T|-r] [-f] [-n] ... Signed-off-by: Gokul Sivakumar --- event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/event.c b/event.c index 14f101b..e0908dd 100644 --- a/event.c +++ b/event.c @@ -1457,7 +1457,7 @@ static int print_events(struct nl80211_state *state, return __do_listen_events(state, 0, NULL, 0, NULL, &args); } -TOPLEVEL(event, "[-t|-r] [-f]", 0, 0, CIB_NONE, print_events, +TOPLEVEL(event, "[-t|-T|-r] [-f]", 0, 0, CIB_NONE, print_events, "Monitor events from the kernel.\n" "-t - print timestamp\n" "-T - print absolute, human-readable timestamp\n" From patchwork Fri Sep 10 14:16:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gokul Sivakumar X-Patchwork-Id: 509390 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64640C433FE for ; Fri, 10 Sep 2021 14:18:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C26D61059 for ; Fri, 10 Sep 2021 14:18:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234011AbhIJOTd (ORCPT ); Fri, 10 Sep 2021 10:19:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234122AbhIJOTZ (ORCPT ); Fri, 10 Sep 2021 10:19:25 -0400 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC2F8C061574 for ; Fri, 10 Sep 2021 07:18:14 -0700 (PDT) Received: by mail-pg1-x531.google.com with SMTP id h3so1944135pgb.7 for ; Fri, 10 Sep 2021 07:18:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SWC64Hw9RdRZUBb/5tZCGO0pnW6c4GkHo018gfxVZbA=; b=ppej98ouCoXFsE8KgeNwGHQYYLAlviMcgxkqTDR7jHFNz8EdVtN2zQ9Ntv3C8t+yFS QvcWcmHHBq/C86lZMc/5G3WdIpqyP2TfqoZZxnZaSdSZZMtEK6K96D5uPvSDVFsrx8nd sMU0XOOh4HjUpwfWrxlZaRtZ8pw1H58hF1bymItjlm2d8CNT1D6vUSbfh5BwRsiX9oPZ VQdH5BpykqOPS/ZSBpRdRPDiVXfOAA0E4F9dfs2WTNeAV/cSc0sSejhmDaJZHdwoacfN rmcbzJXZHhR4W50ifZcj4FzlzvSivQ3LCFAoV9B4mvzZKaKiikDEof1Zr9F0PgK8FEfY gR/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SWC64Hw9RdRZUBb/5tZCGO0pnW6c4GkHo018gfxVZbA=; b=eBfvZqiSiUzWcAKNbtbw/lfUP9DSQSmes2vaVRzac4VZV9t1P20NZEY67xNoKfclXn Lyq6xbi0hIaM6TpQ0XpCNG3/bfzAMup+BimpCha4w1jPnTqxF1HawRv339BrhQPY4HqB F3PSfC3QrXiUZoabIsAOJvNeMrsoIdSEOLIRPGatRatfVchyHZWCrbJPccsn0ndN0OKG wuECcKZb001u7xdyho8IVgeBjtLRdcAIAulmmFMVOn545o6oAp9pCG2T/ZQUppdP65BI snlN+0YNlE2OhI8R+wD+8ocY5PbDXvI+cnwrJN7oDg1hqFwpAZWNN3iGTXf8pYLn6U/z Y0hQ== X-Gm-Message-State: AOAM533lp1Py/VUAJzNYrQZ8hq/q4pUQQ/yDvqwORyV4Z1O6wnb0XYRo fOnh3D9nXOucJ/hfl9aTVIyzZgpKnHc= X-Google-Smtp-Source: ABdhPJwzyGwvMUpCDvj8tH/olZRW9EaO5NQfbvQzS5It/KeJP3uG+fsfeUZWNt/shNghHXvmQo8OAA== X-Received: by 2002:a63:e14f:: with SMTP id h15mr7625145pgk.49.1631283494424; Fri, 10 Sep 2021 07:18:14 -0700 (PDT) Received: from localhost.localdomain ([49.206.113.222]) by smtp.googlemail.com with ESMTPSA id q9sm5079519pfs.40.2021.09.10.07.18.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Sep 2021 07:18:14 -0700 (PDT) From: Gokul Sivakumar To: Johannes Berg Cc: Gokul Sivakumar , linux-wireless@vger.kernel.org Subject: [PATCH iw 4/4] iw: mesh: add comments in the mesh confguration parameter printing sections Date: Fri, 10 Sep 2021 19:46:18 +0530 Message-Id: <20210910141618.1594617-4-gokulkumar792@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210910141618.1594617-1-gokulkumar792@gmail.com> References: <20210910141618.1594617-1-gokulkumar792@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Signed-off-by: Gokul Sivakumar --- mesh.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mesh.c b/mesh.c index 943edf5..0fb98a3 100644 --- a/mesh.c +++ b/mesh.c @@ -400,6 +400,7 @@ static int print_mesh_param_handler(struct nl_msg *msg, void *arg) if (!mdescr) { unsigned int i; + /* print out all the supported mesh parameters */ for (i = 0; i < ARRAY_SIZE(_mesh_param_descrs); i++) { mdescr = &_mesh_param_descrs[i]; if (mesh_params[mdescr->mesh_param_num]) { @@ -411,7 +412,7 @@ static int print_mesh_param_handler(struct nl_msg *msg, void *arg) return NL_SKIP; } - /* print out the mesh parameter */ + /* print out the requested mesh parameter */ if (mesh_params[mdescr->mesh_param_num]) { mdescr->nla_print_fn(mesh_params[mdescr->mesh_param_num]); printf("\n");