From patchwork Mon Sep 6 01:58:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Damien Le Moal X-Patchwork-Id: 507433 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CF7BC433F5 for ; Mon, 6 Sep 2021 01:58:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 769606101C for ; Mon, 6 Sep 2021 01:58:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238660AbhIFB7e (ORCPT ); Sun, 5 Sep 2021 21:59:34 -0400 Received: from esa6.hgst.iphmx.com ([216.71.154.45]:22459 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238872AbhIFB7T (ORCPT ); Sun, 5 Sep 2021 21:59:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1630893496; x=1662429496; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=8tQek1BuCHd6+e3To9J3XU0DZ1rXln0abM7Vu7Q/aXs=; b=mO1cl1BG3xwiyA++e6yD96vTmCqExD6Eg4O1Of4NQ5hzxkH/mP/W3dgm GisOTgyFnrSTmZy8NnJy3KA6E5wBe1X8pMcp1y7Y8DemRlTDaGJ+WNoJ0 S59kY2QBlafR7kGeZqS2o9H+bTCExebJSyfXFAx36rJQVQ6SB46jFuyB3 t0opKd1R8KuEARDMNnO8KT5CRGd5dWXDvCQALlyNFS280I1DocLn3fCF+ 9v5JPUAlDhZbutzjGS5Q/rZ1ylkxu5NSiZTKXjyzGQGkRQL/14+tGvfFK uSIgO2iVUmg0zxKPH3D4Dj+pU7tgUp+N+xgJUv+He9ry1giGTfeauRE/0 A==; X-IronPort-AV: E=Sophos;i="5.85,271,1624291200"; d="scan'208";a="179789028" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 06 Sep 2021 09:58:16 +0800 IronPort-SDR: G2xTtQb7TktW2jcwe9Zd26BTTw9UR+c+5I0u8MC3m6xSuHy3QU/d2kYVFeIkCW+GAIFmcIEOGH UE4TG27VFbZc2AkVU8UjRD3ZYopP8WIlf3sVV1PY1IoX75p0yd4vvNgz3iAAdTqhD157KDT/9g Jumve9ul4KI0xbbkaXm966Sm1g/k/4M6LbG7eqeyTkznq+T8/7EqI+rHa4pBLb3uI04lqGHxbO YBBUWWEkEa/r73Pd8MzbKgAcLGcoA2kFCLqs8ZBajO4x3n/fbZF9+En6qbNAHvJpgF0wMdV7uQ znclGXTcXPpsWm8KNFNf+99a Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2021 18:33:16 -0700 IronPort-SDR: 0CAdCgW4K6JlTF1CWwLYpeBPmLvQDF9Y8qCydD9atzukPYc+K0HcQOglhG7F5Ku/HDXPQA4z4T +d7NpKGFyEIm1WnPIibDvn0IxfahPtkWTOHI4KUi++dif7t0Vjly80LkJq3f1yAsAz4TmuO7ea vMK8Xso5Dxwdk6zgaFY3vsS89fOkvuS10lwAtiCS/+0i4Qr9v1SDa+RNEYIe+XWYyg1O+m9EhU SZ/QmrWpsxHFhPU+nngNZmZFsEddko8StZs+MzPiymrJAKg7GME3C1PRq5/dDffHE1crwkPs62 OWU= WDCIronportException: Internal Received: from washi.fujisawa.hgst.com ([10.149.53.254]) by uls-op-cesaip02.wdc.com with ESMTP; 05 Sep 2021 18:58:15 -0700 From: Damien Le Moal To: Jens Axboe , linux-block@vger.kernel.org, linux-ide@vger.kernel.org, "Martin K . Petersen" , linux-scsi@vger.kernel.org Subject: [PATCH v7 1/5] block: Add independent access ranges support Date: Mon, 6 Sep 2021 10:58:06 +0900 Message-Id: <20210906015810.732799-2-damien.lemoal@wdc.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210906015810.732799-1-damien.lemoal@wdc.com> References: <20210906015810.732799-1-damien.lemoal@wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org The Concurrent Positioning Ranges VPD page (for SCSI) and data log page (for ATA) contain parameters describing the set of contiguous LBAs that can be served independently by a single LUN multi-actuator hard-disk. Similarly, a logically defined block device composed of multiple disks can in some cases execute requests directed at different sector ranges in parallel. A dm-linear device aggregating 2 block devices together is an example. This patch implements support for exposing a block device independent access ranges to the user through sysfs to allow optimizing device accesses to increase performance. To describe the set of independent sector ranges of a device (actuators of a multi-actuator HDDs or table entries of a dm-linear device), The type struct blk_independent_access_ranges is introduced. This structure describes the sector ranges using an array of struct blk_independent_access_range structures. This range structure defines the start sector and number of sectors of the access range. The ranges in the array cannot overlap and must contain all sectors within the device capacity. The function disk_set_iaranges() allows a device driver to signal to the block layer that a device has multiple independent access ranges. In this case, a struct blk_independent_access_ranges is attached to the device request queue by the function disk_set_iaranges(). The function disk_alloc_iaranges() is provided for drivers to allocate this structure. struct blk_independent_access_ranges contains kobjects (struct kobject) to expose to the user through sysfs the set of independent access ranges supported by a device. When the device is initialized, sysfs registration of the ranges information is done from blk_register_queue() using the block layer internal function disk_register_iaranges(). If a driver calls disk_set_iaranges() for a registered queue, e.g. when a device is revalidated, disk_set_iaranges() will execute disk_register_iaranges() to update the sysfs attribute files. The sysfs file structure created starts from the independent_access_ranges sub-directory and contains the start sector and number of sectors of each range, with the information for each range grouped in numbered sub-directories. E.g. for a dual actuator HDD, the user sees: $ tree /sys/block/sdk/queue/independent_access_ranges/ /sys/block/sdk/queue/independent_access_ranges/ |-- 0 | |-- nr_sectors | `-- sector `-- 1 |-- nr_sectors `-- sector For a regular device with a single access range, the independent_access_ranges sysfs directory does not exist. Device revalidation may lead to changes to this structure and to the attribute values. When manipulated, the queue sysfs_lock and sysfs_dir_lock mutexes are held for atomicity, similarly to how the blk-mq and elevator sysfs queue sub-directories are protected. The code related to the management of independent access ranges is added in the new file block/blk-iaranges.c. Signed-off-by: Damien Le Moal Reviewed-by: Hannes Reinecke --- block/Makefile | 2 +- block/blk-iaranges.c | 345 +++++++++++++++++++++++++++++++++++++++++ block/blk-sysfs.c | 26 +++- block/blk.h | 4 + include/linux/blkdev.h | 39 +++++ 5 files changed, 407 insertions(+), 9 deletions(-) create mode 100644 block/blk-iaranges.c diff --git a/block/Makefile b/block/Makefile index 1d0d466f2182..f9c4c255df76 100644 --- a/block/Makefile +++ b/block/Makefile @@ -9,7 +9,7 @@ obj-$(CONFIG_BLOCK) := bio.o elevator.o blk-core.o blk-sysfs.o \ blk-lib.o blk-mq.o blk-mq-tag.o blk-stat.o \ blk-mq-sysfs.o blk-mq-cpumap.o blk-mq-sched.o ioctl.o \ genhd.o ioprio.o badblocks.o partitions/ blk-rq-qos.o \ - disk-events.o + disk-events.o blk-iaranges.o obj-$(CONFIG_BOUNCE) += bounce.o obj-$(CONFIG_BLK_SCSI_REQUEST) += scsi_ioctl.o diff --git a/block/blk-iaranges.c b/block/blk-iaranges.c new file mode 100644 index 000000000000..a60a98c487cd --- /dev/null +++ b/block/blk-iaranges.c @@ -0,0 +1,345 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Block device concurrent positioning ranges. + * + * Copyright (C) 2021 Western Digital Corporation or its Affiliates. + */ +#include +#include +#include +#include + +#include "blk.h" + +static ssize_t +blk_iarange_sector_show(struct blk_independent_access_range *iar, char *buf) +{ + return sprintf(buf, "%llu\n", iar->sector); +} + +static ssize_t +blk_iarange_nr_sectors_show(struct blk_independent_access_range *iar, char *buf) +{ + return sprintf(buf, "%llu\n", iar->nr_sectors); +} + +struct blk_iarange_sysfs_entry { + struct attribute attr; + ssize_t (*show)(struct blk_independent_access_range *iar, char *buf); +}; + +static struct blk_iarange_sysfs_entry blk_iarange_sector_entry = { + .attr = { .name = "sector", .mode = 0444 }, + .show = blk_iarange_sector_show, +}; + +static struct blk_iarange_sysfs_entry blk_iarange_nr_sectors_entry = { + .attr = { .name = "nr_sectors", .mode = 0444 }, + .show = blk_iarange_nr_sectors_show, +}; + +static struct attribute *blk_iarange_attrs[] = { + &blk_iarange_sector_entry.attr, + &blk_iarange_nr_sectors_entry.attr, + NULL, +}; +ATTRIBUTE_GROUPS(blk_iarange); + +static ssize_t blk_iarange_sysfs_show(struct kobject *kobj, + struct attribute *attr, char *buf) +{ + struct blk_iarange_sysfs_entry *entry = + container_of(attr, struct blk_iarange_sysfs_entry, attr); + struct blk_independent_access_range *iar = + container_of(kobj, struct blk_independent_access_range, kobj); + ssize_t ret; + + mutex_lock(&iar->queue->sysfs_lock); + ret = entry->show(iar, buf); + mutex_unlock(&iar->queue->sysfs_lock); + + return ret; +} + +static const struct sysfs_ops blk_iarange_sysfs_ops = { + .show = blk_iarange_sysfs_show, +}; + +/* + * Independent access range entries are not freed individually, but alltogether + * with struct blk_independent_access_ranges and its array of range entries. + * Since kobject_add() takes a reference on the parent kobject contained in + * struct blk_independent_access_ranges, the array of independent access range + * entries cannot be freed until kobject_del() is called for all entries. + * So we do not need to do anything here, but still need this no-op release + * operation to avoid complaints from the kobject code. + */ +static void blk_iarange_sysfs_nop_release(struct kobject *kobj) +{ +} + +static struct kobj_type blk_iarange_ktype = { + .sysfs_ops = &blk_iarange_sysfs_ops, + .default_groups = blk_iarange_groups, + .release = blk_iarange_sysfs_nop_release, +}; + +/* + * This will be executed only after all independent access range entries are + * removed with kobject_del(), at which point, it is safe to free everything, + * including the array of range entries. + */ +static void blk_iaranges_sysfs_release(struct kobject *kobj) +{ + struct blk_independent_access_ranges *iars = + container_of(kobj, struct blk_independent_access_ranges, kobj); + + kfree(iars); +} + +static struct kobj_type blk_iaranges_ktype = { + .release = blk_iaranges_sysfs_release, +}; + +/** + * disk_register_iaranges - register with sysfs a set of independent + * access ranges + * @disk: Target disk + * @new_iars: New set of independent access ranges + * + * Register with sysfs a set of independent access ranges for @disk. + * If @new_iars is not NULL, this set of ranges is registered and the old set + * specified by q->iaranges is unregistered. Otherwise, q->iaranges is + * registered if it is not already. + */ +int disk_register_iaranges(struct gendisk *disk, + struct blk_independent_access_ranges *new_iars) +{ + struct request_queue *q = disk->queue; + struct blk_independent_access_ranges *iars; + int i, ret; + + lockdep_assert_held(&q->sysfs_dir_lock); + lockdep_assert_held(&q->sysfs_lock); + + /* If a new range set is specified, unregister the old one */ + if (new_iars) { + if (q->iaranges) + disk_unregister_iaranges(disk); + q->iaranges = new_iars; + } + + iars = q->iaranges; + if (!iars) + return 0; + + /* + * At this point, iars is the new set of sector access ranges that needs + * to be registered with sysfs. + */ + WARN_ON(iars->sysfs_registered); + ret = kobject_init_and_add(&iars->kobj, &blk_iaranges_ktype, + &q->kobj, "%s", "independent_access_ranges"); + if (ret) { + q->iaranges = NULL; + kfree(iars); + return ret; + } + + for (i = 0; i < iars->nr_iaranges; i++) { + iars->iarange[i].queue = q; + ret = kobject_init_and_add(&iars->iarange[i].kobj, + &blk_iarange_ktype, &iars->kobj, + "%d", i); + if (ret) { + while (--i >= 0) + kobject_del(&iars->iarange[i].kobj); + kobject_del(&iars->kobj); + kobject_put(&iars->kobj); + return ret; + } + } + + iars->sysfs_registered = true; + + return 0; +} + +void disk_unregister_iaranges(struct gendisk *disk) +{ + struct request_queue *q = disk->queue; + struct blk_independent_access_ranges *iars = q->iaranges; + int i; + + lockdep_assert_held(&q->sysfs_dir_lock); + lockdep_assert_held(&q->sysfs_lock); + + if (!iars) + return; + + if (iars->sysfs_registered) { + for (i = 0; i < iars->nr_iaranges; i++) + kobject_del(&iars->iarange[i].kobj); + kobject_del(&iars->kobj); + kobject_put(&iars->kobj); + } else { + kfree(iars); + } + + q->iaranges = NULL; +} + +static struct blk_independent_access_range * +disk_find_iarange(struct blk_independent_access_ranges *iars, + sector_t sector) +{ + struct blk_independent_access_range *iar; + int i; + + for (i = 0; i < iars->nr_iaranges; i++) { + iar = &iars->iarange[i]; + if (sector >= iar->sector && + sector < iar->sector + iar->nr_sectors) + return iar; + } + + return NULL; +} + +static bool disk_check_iaranges(struct gendisk *disk, + struct blk_independent_access_ranges *iars) +{ + struct blk_independent_access_range *iar, *tmp; + sector_t capacity = get_capacity(disk); + sector_t sector = 0; + int i; + + /* + * While sorting the ranges in increasing LBA order, check that the + * ranges do not overlap, that there are no sector holes and that all + * sectors belong to one range. + */ + for (i = 0; i < iars->nr_iaranges; i++) { + tmp = disk_find_iarange(iars, sector); + if (!tmp || tmp->sector != sector) { + pr_warn("Invalid non-contiguous independent access ranges\n"); + return false; + } + + iar = &iars->iarange[i]; + if (tmp != iar) { + swap(iar->sector, tmp->sector); + swap(iar->nr_sectors, tmp->nr_sectors); + } + + sector += iar->nr_sectors; + } + + if (sector != capacity) { + pr_warn("Independent access ranges do not match disk capacity\n"); + return false; + } + + return true; +} + +static bool disk_iaranges_changed(struct gendisk *disk, + struct blk_independent_access_ranges *new) +{ + struct blk_independent_access_ranges *old = disk->queue->iaranges; + int i; + + if (!old) + return true; + + if (old->nr_iaranges != new->nr_iaranges) + return true; + + for (i = 0; i < old->nr_iaranges; i++) { + if (new->iarange[i].sector != old->iarange[i].sector || + new->iarange[i].nr_sectors != old->iarange[i].nr_sectors) + return true; + } + + return false; +} + +/** + * disk_alloc_iaranges - Allocate an independent access range structure + * @disk: target disk + * @nr_iaranges: Number of independent access ranges + * + * Allocate a struct blk_independent_access_ranges structure with @nr_iaranges + * access range descriptors. + */ +struct blk_independent_access_ranges *disk_alloc_iaranges(struct gendisk *disk, + int nr_iaranges) +{ + struct blk_independent_access_ranges *iars; + + iars = kzalloc_node(struct_size(iars, iarange, nr_iaranges), + GFP_KERNEL, disk->queue->node); + if (iars) + iars->nr_iaranges = nr_iaranges; + return iars; +} +EXPORT_SYMBOL_GPL(disk_alloc_iaranges); + +/** + * disk_set_iaranges - Set a disk independent access ranges + * @disk: target disk + * @iars: independent access ranges structure + * + * Set the independent access ranges information of the request queue + * of @disk to @iars. If @iars is NULL and the independent access ranges + * structure already set is cleared. If there are no differences between + * @iars and the independent access ranges structure already set, @iars + * is freed. + */ +void disk_set_iaranges(struct gendisk *disk, + struct blk_independent_access_ranges *iars) +{ + struct request_queue *q = disk->queue; + + if (WARN_ON_ONCE(iars && !iars->nr_iaranges)) { + kfree(iars); + iars = NULL; + } + + mutex_lock(&q->sysfs_dir_lock); + mutex_lock(&q->sysfs_lock); + + if (iars) { + if (!disk_check_iaranges(disk, iars)) { + kfree(iars); + iars = NULL; + goto reg; + } + + if (!disk_iaranges_changed(disk, iars)) { + kfree(iars); + goto unlock; + } + } + + /* + * This may be called for a registered queue. E.g. during a device + * revalidation. If that is the case, we need to unregister the old + * set of independent access ranges and register the new set. If the + * queue is not registered, registration of the device request queue + * will register the independent access ranges, so only swap in the + * new set and free the old one. + */ +reg: + if (blk_queue_registered(q)) { + disk_register_iaranges(disk, iars); + } else { + swap(q->iaranges, iars); + kfree(iars); + } + +unlock: + mutex_unlock(&q->sysfs_lock); + mutex_unlock(&q->sysfs_dir_lock); +} +EXPORT_SYMBOL_GPL(disk_set_iaranges); diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c index 614d9d47de36..874b34060efa 100644 --- a/block/blk-sysfs.c +++ b/block/blk-sysfs.c @@ -887,16 +887,15 @@ int blk_register_queue(struct gendisk *disk) } mutex_lock(&q->sysfs_lock); + + ret = disk_register_iaranges(disk, NULL); + if (ret) + goto put_dev; + if (q->elevator) { ret = elv_register_queue(q, false); - if (ret) { - mutex_unlock(&q->sysfs_lock); - mutex_unlock(&q->sysfs_dir_lock); - kobject_del(&q->kobj); - blk_trace_remove_sysfs(dev); - kobject_put(&dev->kobj); - return ret; - } + if (ret) + goto put_dev; } blk_queue_flag_set(QUEUE_FLAG_REGISTERED, q); @@ -927,6 +926,16 @@ int blk_register_queue(struct gendisk *disk) percpu_ref_switch_to_percpu(&q->q_usage_counter); } + return ret; + +put_dev: + disk_unregister_iaranges(disk); + mutex_unlock(&q->sysfs_lock); + mutex_unlock(&q->sysfs_dir_lock); + kobject_del(&q->kobj); + blk_trace_remove_sysfs(dev); + kobject_put(&dev->kobj); + return ret; } @@ -972,6 +981,7 @@ void blk_unregister_queue(struct gendisk *disk) mutex_lock(&q->sysfs_lock); if (q->elevator) elv_unregister_queue(q); + disk_unregister_iaranges(disk); mutex_unlock(&q->sysfs_lock); mutex_unlock(&q->sysfs_dir_lock); diff --git a/block/blk.h b/block/blk.h index 8c96b0c90c48..f87dc441af9c 100644 --- a/block/blk.h +++ b/block/blk.h @@ -373,4 +373,8 @@ static inline void bio_clear_hipri(struct bio *bio) bio->bi_opf &= ~REQ_HIPRI; } +int disk_register_iaranges(struct gendisk *disk, + struct blk_independent_access_ranges *new_iars); +void disk_unregister_iaranges(struct gendisk *disk); + #endif /* BLK_INTERNAL_H */ diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index c9cb12483e12..0ef74297c841 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -377,6 +377,34 @@ static inline int blkdev_zone_mgmt_ioctl(struct block_device *bdev, #endif /* CONFIG_BLK_DEV_ZONED */ +/* + * Independent access ranges: struct blk_independent_access_range describes + * a range of contiguous sectors that can be accessed using device command + * execution resources that are independent from the resources used for + * other access ranges. This is typically found with single-LUN multi-actuator + * HDDs where each access range is served by a different set of heads. + * The set of independent ranges supported by the device is defined using + * struct blk_independent_access_ranges. The independent ranges must not overlap + * and must include all sectors within the disk capacity (no sector holes + * allowed). + * For a device with multiple ranges, requests targeting sectors in different + * ranges can be executed in parallel. A request can straddle an access range + * boundary. + */ +struct blk_independent_access_range { + struct kobject kobj; + struct request_queue *queue; + sector_t sector; + sector_t nr_sectors; +}; + +struct blk_independent_access_ranges { + struct kobject kobj; + bool sysfs_registered; + unsigned int nr_iaranges; + struct blk_independent_access_range iarange[]; +}; + struct request_queue { struct request *last_merge; struct elevator_queue *elevator; @@ -569,6 +597,12 @@ struct request_queue { #define BLK_MAX_WRITE_HINTS 5 u64 write_hints[BLK_MAX_WRITE_HINTS]; + + /* + * Independent sector access ranges. This is always NULL for + * devices that do not have multiple independent access ranges. + */ + struct blk_independent_access_ranges *iaranges; }; /* Keep blk_queue_flag_name[] in sync with the definitions below */ @@ -1164,6 +1198,11 @@ extern void blk_queue_required_elevator_features(struct request_queue *q, extern bool blk_queue_can_use_dma_map_merging(struct request_queue *q, struct device *dev); +struct blk_independent_access_ranges *disk_alloc_iaranges(struct gendisk *disk, + int nr_iaranges); +void disk_set_iaranges(struct gendisk *disk, + struct blk_independent_access_ranges *iars); + /* * Number of physical segments as sent to the device. * From patchwork Mon Sep 6 01:58:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Damien Le Moal X-Patchwork-Id: 507764 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2B27C433EF for ; Mon, 6 Sep 2021 01:58:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CAFE160FE6 for ; Mon, 6 Sep 2021 01:58:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238747AbhIFB7i (ORCPT ); Sun, 5 Sep 2021 21:59:38 -0400 Received: from esa6.hgst.iphmx.com ([216.71.154.45]:22462 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238887AbhIFB7V (ORCPT ); Sun, 5 Sep 2021 21:59:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1630893497; x=1662429497; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=ISHlTPMJP9UUVggdxZ0huPi7O49JHqjc4UhUHb2wpms=; b=jaxP8Yw8kFq/3y/2Oy5olFms/l5xa3q+oCp3Il40EZN2jpeZm0uaWVBJ H+EU4axOa9+tE4r4isY7SyYM6ceDIyy65AoTDtvv35uFiNJr89XGAlQC4 JRPEQL0KJpQNI/U6GWPIycDqw/CWrzXlZkKQIjRxQMs2H2Q6khVo04+hI BgB03/6h14xGTYm+joSTb3haVQ8st6AZZRgi3KwtKl/WQ3tvXwpiBSMQC 5V2qBEJx2kHGl9/6mwER6BR8lx8e8l0N+RlbPQs5z/52zz+CRopjlBX1K W1yGljKhAHgiNFLrI6Oa3QBLiNYI4TuNfs5lRPEWyCSBH+SwcIpfS6eHx w==; X-IronPort-AV: E=Sophos;i="5.85,271,1624291200"; d="scan'208";a="179789031" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 06 Sep 2021 09:58:17 +0800 IronPort-SDR: 0w37D8GLhxvfSudUmVzepdS9BuXI0BEU9RjH9OKaJ10cfd20OEhft3pTDQvUwhYLnClzmr/zq1 l+2ZPMRkbWOD1cjO5rCBS5SKbjVm1Gf+Mb+8y6Y8zvRYVlHiHArnC1VjxrS0hi3u+Ng18erHJa HAfqd3EknoFQ7PVT6WANI64yJjH936Ilfk+0rfrcHng4Ch+bADB+F21cLVaJlF/Ssoh4NOY6A0 HR7BgW1HZAd5qmX6PfoK1jqBNEDL6vqSXXVlW1obM73/NYEDmGnxLVJYR8qPeJU9LhzLQoub08 ESzV0LQprlQm1XHIz5dCfGot Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2021 18:33:17 -0700 IronPort-SDR: oGv8KdzoOXSblXamYynxE8PUDMwCIdF+/isTAHjhblplSVbDsysWH6JpvYF7IWIdkbR1AS18HM hFPFn/ubnTLEkC+EJFpNg68VsePz5W/4XuDWc5bJ4wIGcHhoPK9wNbB8iMPcogWfEMhz+yqZpo Ls4IMRWIcKsU8+tnIYjH1gjJdl/cwHPKByO3ytCxS/T5bPvTuCR0x3sG49eMb9I39O6qXFgNaT 5CkDxSuAmgLvudkBUzL/+h+n14Lt5LFea++Waepj56UTAWI1WM0upzEjjoeKTl84G5ewjMb93B fVk= WDCIronportException: Internal Received: from washi.fujisawa.hgst.com ([10.149.53.254]) by uls-op-cesaip02.wdc.com with ESMTP; 05 Sep 2021 18:58:16 -0700 From: Damien Le Moal To: Jens Axboe , linux-block@vger.kernel.org, linux-ide@vger.kernel.org, "Martin K . Petersen" , linux-scsi@vger.kernel.org Subject: [PATCH v7 2/5] scsi: sd: add concurrent positioning ranges support Date: Mon, 6 Sep 2021 10:58:07 +0900 Message-Id: <20210906015810.732799-3-damien.lemoal@wdc.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210906015810.732799-1-damien.lemoal@wdc.com> References: <20210906015810.732799-1-damien.lemoal@wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Add the sd_read_cpr() function to the sd scsi disk driver to discover if a device has multiple concurrent positioning ranges (i.e. multiple actuators on an HDD). The existence of VPD page B9h indicates if a device has multiple concurrent positioning ranges. The page content describes each range supported by the device. sd_read_cpr() is called from sd_revalidate_disk() and uses the block layer functions disk_alloc_iaranges() and disk_set_iaranges() to represent the set of actuators of the device as independent access ranges. The format of the Concurrent Positioning Ranges VPD page B9h is defined in section 6.6.6 of SBC-5. Signed-off-by: Damien Le Moal --- drivers/scsi/sd.c | 81 +++++++++++++++++++++++++++++++++++++++++++++++ drivers/scsi/sd.h | 1 + 2 files changed, 82 insertions(+) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 610ebba0d66e..1bb49d74c3db 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -3126,6 +3126,86 @@ static void sd_read_security(struct scsi_disk *sdkp, unsigned char *buffer) sdkp->security = 1; } +static inline sector_t sd64_to_sectors(struct scsi_disk *sdkp, u8 *buf) +{ + return logical_to_sectors(sdkp->device, get_unaligned_be64(buf)); +} + +/** + * sd_read_cpr - Query concurrent positioning ranges + * @sdkp: disk to query + */ +static void sd_read_cpr(struct scsi_disk *sdkp) +{ + struct blk_independent_access_ranges *iars = NULL; + unsigned char *buffer = NULL; + unsigned int nr_cpr = 0; + int i, vpd_len, buf_len = SD_BUF_SIZE; + u8 *desc; + + /* + * We need to have the capacity set first for the block layer to be + * able to check the ranges. + */ + if (sdkp->first_scan) + return; + + if (!sdkp->capacity) + goto out; + + /* + * Concurrent Positioning Ranges VPD: there can be at most 256 ranges, + * leading to a maximum page size of 64 + 256*32 bytes. + */ + buf_len = 64 + 256*32; + buffer = kmalloc(buf_len, GFP_KERNEL); + if (!buffer || scsi_get_vpd_page(sdkp->device, 0xb9, buffer, buf_len)) + goto out; + + /* We must have at least a 64B header and one 32B range descriptor */ + vpd_len = get_unaligned_be16(&buffer[2]) + 3; + if (vpd_len > buf_len || vpd_len < 64 + 32 || (vpd_len & 31)) { + sd_printk(KERN_ERR, sdkp, + "Invalid Concurrent Positioning Ranges VPD page\n"); + goto out; + } + + nr_cpr = (vpd_len - 64) / 32; + if (nr_cpr == 1) { + nr_cpr = 0; + goto out; + } + + iars = disk_alloc_iaranges(sdkp->disk, nr_cpr); + if (!iars) { + nr_cpr = 0; + goto out; + } + + desc = &buffer[64]; + for (i = 0; i < nr_cpr; i++, desc += 32) { + if (desc[0] != i) { + sd_printk(KERN_ERR, sdkp, + "Invalid Concurrent Positioning Range number\n"); + nr_cpr = 0; + break; + } + + iars->iarange[i].sector = sd64_to_sectors(sdkp, desc + 8); + iars->iarange[i].nr_sectors = sd64_to_sectors(sdkp, desc + 16); + } + +out: + disk_set_iaranges(sdkp->disk, iars); + if (nr_cpr && sdkp->nr_actuators != nr_cpr) { + sd_printk(KERN_NOTICE, sdkp, + "%u concurrent positioning ranges\n", nr_cpr); + sdkp->nr_actuators = nr_cpr; + } + + kfree(buffer); +} + /* * Determine the device's preferred I/O size for reads and writes * unless the reported value is unreasonably small, large, not a @@ -3241,6 +3321,7 @@ static int sd_revalidate_disk(struct gendisk *disk) sd_read_app_tag_own(sdkp, buffer); sd_read_write_same(sdkp, buffer); sd_read_security(sdkp, buffer); + sd_read_cpr(sdkp); } /* diff --git a/drivers/scsi/sd.h b/drivers/scsi/sd.h index b59136c4125b..2e5932bde43d 100644 --- a/drivers/scsi/sd.h +++ b/drivers/scsi/sd.h @@ -106,6 +106,7 @@ struct scsi_disk { u8 protection_type;/* Data Integrity Field */ u8 provisioning_mode; u8 zeroing_mode; + u8 nr_actuators; /* Number of actuators */ unsigned ATO : 1; /* state of disk ATO bit */ unsigned cache_override : 1; /* temp override of WCE,RCD */ unsigned WCE : 1; /* state of disk WCE bit */ From patchwork Mon Sep 6 01:58:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Damien Le Moal X-Patchwork-Id: 507432 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE8F8C433F5 for ; Mon, 6 Sep 2021 01:58:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9BC466103B for ; Mon, 6 Sep 2021 01:58:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238749AbhIFB7j (ORCPT ); Sun, 5 Sep 2021 21:59:39 -0400 Received: from esa6.hgst.iphmx.com ([216.71.154.45]:22455 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238907AbhIFB7W (ORCPT ); Sun, 5 Sep 2021 21:59:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1630893499; x=1662429499; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=JvrFu+U1V8PAYrjm6bWrGsnC1QXXCBxJtUJePkupkKw=; b=ejVu7cRiN/b3kThODUfs6weuNmoUBGZS7asyzVirCau2TDt2XcPkA9AX EW4eYU9X6GbekDB80yDU/0SgIAID8GRCt6Vprtjo6+B7+IcMNttHtsPPH 0Yhw91078Ui1iDy+jrl5Dllams436VbsFK/B5Fqes1WZsoDAD+pFGKnpw goQ71x/mxEFzk2ZzJMGTYNffUGvm6oFQfUm79ypGqwAbRyz6lGdQNjZP5 qPTRlXC4hIHWoXofmTvWjQc4r64W+ihAGJlz/Pa4csAKj3+fl2gxgrKoz g/ATOATb4aqDlk1BlcDP4WmJeHFxIRCnVK/itdC7Vdq7WV4TnYDT8cShx g==; X-IronPort-AV: E=Sophos;i="5.85,271,1624291200"; d="scan'208";a="179789033" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 06 Sep 2021 09:58:18 +0800 IronPort-SDR: S3+WxJWoEoI2U9b5r4AdKcYr4NVx9H7Ti8vd3jj3YNyPW7guZOA4PVEeCfC0pkdDzGziaVN/oR +1QjmNzIqsNYdzVc55cNS8z4kprYZ1SFwowrTlLuB8hTY+pspdtlJiIDLWI8Tkq3QxzoLArxw4 bHuNnbKR59N9ZFX6owFwuXo/nnUO1vt4J4x2kNB3KNJgD+HD+Alnlj9WIExKuXJycyuP8dSs/8 XGnx5CoEJX4zUx6jJOR7Ipli6TPodwaseDDXeesvAXFZdymhIlZT8AVnf9KQbrebCcbPd/PcXe SByH65oduyxIY+UcV03whkyf Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2021 18:33:18 -0700 IronPort-SDR: uSGcK8gj7u4tf65uzutmd6T9YqR9JwiDAhLlo6qUBI1/sxwR6iPXbXHf3+Uy8dQfj4uRcAwZGq 0SKRILE0fNMpK4s0tF+IxA8XtfMFaa/5to/OdzLiGpvS2vmJOmI/8ftuT2gupR0uOwvbNHQL4I iW+zZFq+wllx6/u2KSk2pvz9BFOj1/KrIFE0iWBErx0HSxsnQum+V/P3wVuE1SZTWCnJoeHgFu 1FgelTqyTBMXDzgkDQdA5relkGcDmJsaWD5Pkqb7mw23NIypR6QVDJ9u/bHD7Ts/oj4uWMUKPx 7gs= WDCIronportException: Internal Received: from washi.fujisawa.hgst.com ([10.149.53.254]) by uls-op-cesaip02.wdc.com with ESMTP; 05 Sep 2021 18:58:18 -0700 From: Damien Le Moal To: Jens Axboe , linux-block@vger.kernel.org, linux-ide@vger.kernel.org, "Martin K . Petersen" , linux-scsi@vger.kernel.org Subject: [PATCH v7 3/5] libata: support concurrent positioning ranges log Date: Mon, 6 Sep 2021 10:58:08 +0900 Message-Id: <20210906015810.732799-4-damien.lemoal@wdc.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210906015810.732799-1-damien.lemoal@wdc.com> References: <20210906015810.732799-1-damien.lemoal@wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Add support to discover if an ATA device supports the Concurrent Positioning Ranges data log (address 0x47), indicating that the device is capable of seeking to multiple different locations in parallel using multiple actuators serving different LBA ranges. Also add support to translate the concurrent positioning ranges log into its equivalent Concurrent Positioning Ranges VPD page B9h in libata-scsi.c. The format of the Concurrent Positioning Ranges Log is defined in ACS-5 r9. Signed-off-by: Damien Le Moal Reviewed-by: Hannes Reinecke Reviewed-by: Christoph Hellwig --- drivers/ata/libata-core.c | 57 +++++++++++++++++++++++++++++++++++++-- drivers/ata/libata-scsi.c | 48 ++++++++++++++++++++++++++------- include/linux/ata.h | 1 + include/linux/libata.h | 15 +++++++++++ 4 files changed, 110 insertions(+), 11 deletions(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index b8459c54f739..b083e5dae6f3 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -2433,18 +2433,70 @@ static void ata_dev_config_devslp(struct ata_device *dev) } } +static void ata_dev_config_cpr(struct ata_device *dev) +{ + unsigned int err_mask; + size_t buf_len; + int i, nr_cpr = 0; + struct ata_cpr_log *cpr_log = NULL; + u8 *desc, *buf = NULL; + + if (!ata_identify_page_supported(dev, + ATA_LOG_CONCURRENT_POSITIONING_RANGES)) + goto out; + + /* + * Read IDENTIFY DEVICE data log, page 0x47 + * (concurrent positioning ranges). We can have at most 255 32B range + * descriptors plus a 64B header. + */ + buf_len = (64 + 255 * 32 + 511) & ~511; + buf = kzalloc(buf_len, GFP_KERNEL); + if (!buf) + goto out; + + err_mask = ata_read_log_page(dev, ATA_LOG_IDENTIFY_DEVICE, + ATA_LOG_CONCURRENT_POSITIONING_RANGES, + buf, buf_len >> 9); + if (err_mask) + goto out; + + nr_cpr = buf[0]; + if (!nr_cpr) + goto out; + + cpr_log = kzalloc(struct_size(cpr_log, cpr, nr_cpr), GFP_KERNEL); + if (!cpr_log) + goto out; + + cpr_log->nr_cpr = nr_cpr; + desc = &buf[64]; + for (i = 0; i < nr_cpr; i++, desc += 32) { + cpr_log->cpr[i].num = desc[0]; + cpr_log->cpr[i].num_storage_elements = desc[1]; + cpr_log->cpr[i].start_lba = get_unaligned_le64(&desc[8]); + cpr_log->cpr[i].num_lbas = get_unaligned_le64(&desc[16]); + } + +out: + swap(dev->cpr_log, cpr_log); + kfree(cpr_log); + kfree(buf); +} + static void ata_dev_print_features(struct ata_device *dev) { if (!(dev->flags & ATA_DFLAG_FEATURES_MASK)) return; ata_dev_info(dev, - "Features:%s%s%s%s%s\n", + "Features:%s%s%s%s%s%s\n", dev->flags & ATA_DFLAG_TRUSTED ? " Trust" : "", dev->flags & ATA_DFLAG_DA ? " Dev-Attention" : "", dev->flags & ATA_DFLAG_DEVSLP ? " Dev-Sleep" : "", dev->flags & ATA_DFLAG_NCQ_SEND_RECV ? " NCQ-sndrcv" : "", - dev->flags & ATA_DFLAG_NCQ_PRIO ? " NCQ-prio" : ""); + dev->flags & ATA_DFLAG_NCQ_PRIO ? " NCQ-prio" : "", + dev->cpr_log ? " CPR" : ""); } /** @@ -2608,6 +2660,7 @@ int ata_dev_configure(struct ata_device *dev) ata_dev_config_sense_reporting(dev); ata_dev_config_zac(dev); ata_dev_config_trusted(dev); + ata_dev_config_cpr(dev); dev->cdb_len = 32; if (ata_msg_drv(ap) && print_info) diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index 0b7b4624e4df..e1e97e62f716 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -1895,7 +1895,7 @@ static unsigned int ata_scsiop_inq_std(struct ata_scsi_args *args, u8 *rbuf) */ static unsigned int ata_scsiop_inq_00(struct ata_scsi_args *args, u8 *rbuf) { - int num_pages; + int i, num_pages = 0; static const u8 pages[] = { 0x00, /* page 0x00, this page */ 0x80, /* page 0x80, unit serial no page */ @@ -1905,13 +1905,17 @@ static unsigned int ata_scsiop_inq_00(struct ata_scsi_args *args, u8 *rbuf) 0xb1, /* page 0xb1, block device characteristics page */ 0xb2, /* page 0xb2, thin provisioning page */ 0xb6, /* page 0xb6, zoned block device characteristics */ + 0xb9, /* page 0xb9, concurrent positioning ranges */ }; - num_pages = sizeof(pages); - if (!(args->dev->flags & ATA_DFLAG_ZAC)) - num_pages--; + for (i = 0; i < sizeof(pages); i++) { + if (pages[i] == 0xb6 && + !(args->dev->flags & ATA_DFLAG_ZAC)) + continue; + rbuf[num_pages + 4] = pages[i]; + num_pages++; + } rbuf[3] = num_pages; /* number of supported VPD pages */ - memcpy(rbuf + 4, pages, num_pages); return 0; } @@ -2121,6 +2125,26 @@ static unsigned int ata_scsiop_inq_b6(struct ata_scsi_args *args, u8 *rbuf) return 0; } +static unsigned int ata_scsiop_inq_b9(struct ata_scsi_args *args, u8 *rbuf) +{ + struct ata_cpr_log *cpr_log = args->dev->cpr_log; + u8 *desc = &rbuf[64]; + int i; + + /* SCSI Concurrent Positioning Ranges VPD page: SBC-5 rev 1 or later */ + rbuf[1] = 0xb9; + put_unaligned_be16(64 + (int)cpr_log->nr_cpr * 32 - 4, &rbuf[3]); + + for (i = 0; i < cpr_log->nr_cpr; i++, desc += 32) { + desc[0] = cpr_log->cpr[i].num; + desc[1] = cpr_log->cpr[i].num_storage_elements; + put_unaligned_be64(cpr_log->cpr[i].start_lba, &desc[8]); + put_unaligned_be64(cpr_log->cpr[i].num_lbas, &desc[16]); + } + + return 0; +} + /** * modecpy - Prepare response for MODE SENSE * @dest: output buffer @@ -4120,11 +4144,17 @@ void ata_scsi_simulate(struct ata_device *dev, struct scsi_cmnd *cmd) ata_scsi_rbuf_fill(&args, ata_scsiop_inq_b2); break; case 0xb6: - if (dev->flags & ATA_DFLAG_ZAC) { + if (dev->flags & ATA_DFLAG_ZAC) ata_scsi_rbuf_fill(&args, ata_scsiop_inq_b6); - break; - } - fallthrough; + else + ata_scsi_set_invalid_field(dev, cmd, 2, 0xff); + break; + case 0xb9: + if (dev->cpr_log) + ata_scsi_rbuf_fill(&args, ata_scsiop_inq_b9); + else + ata_scsi_set_invalid_field(dev, cmd, 2, 0xff); + break; default: ata_scsi_set_invalid_field(dev, cmd, 2, 0xff); break; diff --git a/include/linux/ata.h b/include/linux/ata.h index 1b44f40c7700..199e47e97d64 100644 --- a/include/linux/ata.h +++ b/include/linux/ata.h @@ -329,6 +329,7 @@ enum { ATA_LOG_SECURITY = 0x06, ATA_LOG_SATA_SETTINGS = 0x08, ATA_LOG_ZONED_INFORMATION = 0x09, + ATA_LOG_CONCURRENT_POSITIONING_RANGES = 0x47, /* Identify device SATA settings log:*/ ATA_LOG_DEVSLP_OFFSET = 0x30, diff --git a/include/linux/libata.h b/include/linux/libata.h index 860e63f5667b..e3ab85964f94 100644 --- a/include/linux/libata.h +++ b/include/linux/libata.h @@ -675,6 +675,18 @@ struct ata_ering { struct ata_ering_entry ring[ATA_ERING_SIZE]; }; +struct ata_cpr { + u8 num; + u8 num_storage_elements; + u64 start_lba; + u64 num_lbas; +}; + +struct ata_cpr_log { + u8 nr_cpr; + struct ata_cpr cpr[]; +}; + struct ata_device { struct ata_link *link; unsigned int devno; /* 0 or 1 */ @@ -734,6 +746,9 @@ struct ata_device { u32 zac_zones_optimal_nonseq; u32 zac_zones_max_open; + /* Concurrent positioning ranges */ + struct ata_cpr_log *cpr_log; + /* error history */ int spdn_cnt; /* ering is CLEAR_END, read comment above CLEAR_END */ From patchwork Mon Sep 6 01:58:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Damien Le Moal X-Patchwork-Id: 507763 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2263EC433F5 for ; Mon, 6 Sep 2021 01:58:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D4EA60F6D for ; Mon, 6 Sep 2021 01:58:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238665AbhIFB7k (ORCPT ); Sun, 5 Sep 2021 21:59:40 -0400 Received: from esa6.hgst.iphmx.com ([216.71.154.45]:22459 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238908AbhIFB7X (ORCPT ); Sun, 5 Sep 2021 21:59:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1630893500; x=1662429500; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=UeMxn3O3a5dQiuRdZYEQiywnhJ5mySyNi0lx2Vh5+XQ=; b=fHMXXxOKHyBwA9nHOCgCvK4aLvLjNxd40/G34Q/HtOD5kNBfyP3632DS pB7nYsaLmYNmx7ab5gzCTiIZjxv+rv1FRqYI31wGlXao39I3LeITmiKrU 1uiRIKx9MCAVAtxd06yyi4VxmtcVR2QZqGrqImrlUGU8BONuyFATwlOOX tcq0V3oLi5kj8oyfiuk8v8IMNRZNve49V0u5YHN2WgcpwOLvT5Dd8Kdg+ U3uKL9pEtA84y98OyvkYkmmBzZ7XctEF3VjP58vNeD+bMETeL7+OYczR4 JWROIpoxPXMAhXe4HL0xQRUlPkgJoyGASgo/MWxUKYIzwep7fdOkmCzEB A==; X-IronPort-AV: E=Sophos;i="5.85,271,1624291200"; d="scan'208";a="179789034" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 06 Sep 2021 09:58:20 +0800 IronPort-SDR: KUlV65eOtrQpPo4iqlt4PoFKiRgMUttlwPNg+0WbiHrfZ8Ae9VwI5ZOWSEeVK2X1lOn1mzvcNi LdxcMNmiefK4+4vdhOg7Qt44NuB84QmXW1wtSJWOLllrMr7F2GHyORaD2Yck/m8O5qlAhmTW4+ 4n95MjgP/+fDQbrpWiTL6kXhSfeC7nL+aht3++Ggd5AENwFJE0HH7kNQkl5Q9DCzuPF38z8uDg g5bcb+JRGa71B2Q9KgPrc44toKpB4JYIPQiRAn0ldR39ijSJ60b1OMq3qEF5c7FBEJOkIDJ8M8 rGsOttwEN2KeG6nt1RI1PzZH Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2021 18:33:20 -0700 IronPort-SDR: qU/VE53OEQsWG8FEzEnQVWPSz8clj1JSG9LmpWKkdBpFMIXp+zxbc1khRoCeNUB1yDVlEEuOGw vnRAlt3gPH1HfvvtAQJpNwCfU2I9yc2H8zqwS8+HJTq66Ans5jb5cIy9M1Vf8BLlhVb6Sqptyr Y3GIq5RtWunI7BKU3PRmw3jBFBfkEv5w/8QQsqgagnXCu0VT7+mw46uFFna8M/C/SCD0oV+qdg xwGhtabrKwEGsmwe7gh8yfEXjy0MTIGL8azJSUvC7P3ASPVouosjdfacHts/XJl3tH7kv3n0gZ VDY= WDCIronportException: Internal Received: from washi.fujisawa.hgst.com ([10.149.53.254]) by uls-op-cesaip02.wdc.com with ESMTP; 05 Sep 2021 18:58:19 -0700 From: Damien Le Moal To: Jens Axboe , linux-block@vger.kernel.org, linux-ide@vger.kernel.org, "Martin K . Petersen" , linux-scsi@vger.kernel.org Subject: [PATCH v7 4/5] doc: document sysfs queue/independent_access_ranges attributes Date: Mon, 6 Sep 2021 10:58:09 +0900 Message-Id: <20210906015810.732799-5-damien.lemoal@wdc.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210906015810.732799-1-damien.lemoal@wdc.com> References: <20210906015810.732799-1-damien.lemoal@wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Update the file Documentation/block/queue-sysfs.rst to add a description of a device queue sysfs entries related to independent access ranges (e.g. concurrent positioning ranges for multi-actuator hard-disks). Signed-off-by: Damien Le Moal --- Documentation/block/queue-sysfs.rst | 31 +++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/Documentation/block/queue-sysfs.rst b/Documentation/block/queue-sysfs.rst index 4dc7f0d499a8..b6e8983d8eda 100644 --- a/Documentation/block/queue-sysfs.rst +++ b/Documentation/block/queue-sysfs.rst @@ -286,4 +286,35 @@ sequential zones of zoned block devices (devices with a zoned attributed that reports "host-managed" or "host-aware"). This value is always 0 for regular block devices. +independent_access_ranges (RO) +------------------------------ + +The presence of this sub-directory of the /sys/block/xxx/queue/ directory +indicates that the device is capable of executing requests targeting +different sector ranges in parallel. For instance, single LUN multi-actuator +hard-disks will have an independent_access_ranges directory if the device +correctly advertizes the sector ranges of its actuators. + +The independent_access_ranges directory contains one directory per access +range, with each range described using the sector (RO) attribute file to +indicate the first sector of the range and the nr_sectors (RO) attribute file +to indicate the total number of sectors in the range starting from the first +sector of the range. For example, a dual-actuator hard-disk will have the +following independent_access_ranges entries.:: + + $ tree /sys/block//queue/independent_access_ranges/ + /sys/block//queue/independent_access_ranges/ + |-- 0 + | |-- nr_sectors + | `-- sector + `-- 1 + |-- nr_sectors + `-- sector + +The sector and nr_sectors attributes use 512B sector unit, regardless of +the actual block size of the device. Independent access ranges do not +overlap and include all sectors within the device capacity. The access +ranges are numbered in increasing order of the range start sector, +that is, the sector attribute of range 0 always has the value 0. + Jens Axboe , February 2009 From patchwork Mon Sep 6 01:58:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Damien Le Moal X-Patchwork-Id: 507431 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCF55C433EF for ; Mon, 6 Sep 2021 01:58:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A832B60EE6 for ; Mon, 6 Sep 2021 01:58:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238638AbhIFB7n (ORCPT ); Sun, 5 Sep 2021 21:59:43 -0400 Received: from esa6.hgst.iphmx.com ([216.71.154.45]:22462 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238935AbhIFB73 (ORCPT ); Sun, 5 Sep 2021 21:59:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1630893507; x=1662429507; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=J1tYS+iygHQFjaXc9OBffVjlnEZf9IlQ6OxAqTUysko=; b=DaAa9jBSw9RchGZbYU6pp0f0IznnlYEA82+jnNfFunJZZoueqc3/8blY h+Jd/jlaXx5FSR9w89AlnN3W8uaTf3En3fCSKXOopFk9JPOmLAnr0hrK9 FAVsVg6dp1NW8tqbz0vG+k6lOLNv6Llnwkm7kJyAOJRslOXPHrKyHcVuo qeebMFghO0S+rbQXbFKlaTs85X70+vV9M1cXextsGdQt1E6h2zjfmkRVr m2o74zkLyO9097KZkNt8tT1bAeLHh2MDDb13Czr1esyxIIn2VW5LYBIZI 08RWTcnXi0hp+EKgkUM9BhF7kQ46/uAslh+S7cfKRz2JhKxQi4UZWtult A==; X-IronPort-AV: E=Sophos;i="5.85,271,1624291200"; d="scan'208";a="179789036" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 06 Sep 2021 09:58:21 +0800 IronPort-SDR: 8s25pJvWfyGafqjNMBz2vdJpqKqNYXo0VKYEL280uPLCWoUiyUiZYrKeKOwxFoVj/qE/2lakM3 hCYlEp5da1xKqEBihIJQU6//E0hqJ+iJRNaD3nsyEtbffKPgC1d4Z7N3fwuIKBjYFgzWe5Wt6v YX6AoRnjVX4gy91aoIcburvj87H/rPk7usG7Bgg/LsGyS23y4/+bK7euGE95yP2uq6y77Y4Rh2 zDNnG/bwEZvKDUd0TvGvH2nLOiw7zXCqiRMfI86chKJtrBbFlR6jmKCzhYXD6STT+z0Yk2aFnf A5EupfCS6nRNAxYSlpSsFh9z Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2021 18:33:21 -0700 IronPort-SDR: h6LA6PWn3GtQrz4kfFCkDRnyVX2NfuwkplsMp9TNzETsL2XONR9gaPZBPS14YM0ZDfpfivavOE AtTOwwAq2BzzyRFUwnXYzjMhPAL0XH9L8FeQ15hbBunLJRCXUU18aKiO0ZWNJkgIBhs2UKkSNy /bYq8DDYrH+OBckhYKyf4WWeXzZUiQnM9eNZ7BTQiqj1rstriJ8fYx8k3bO0YY7oRCjKUU84tT zrApnz5LApCeC/uy8bBe5ct1KdAWCMZXAQ96OVTY43dvUZNOwQLbr6nrCLIE5Kze7Z7JebSNNh L7k= WDCIronportException: Internal Received: from washi.fujisawa.hgst.com ([10.149.53.254]) by uls-op-cesaip02.wdc.com with ESMTP; 05 Sep 2021 18:58:20 -0700 From: Damien Le Moal To: Jens Axboe , linux-block@vger.kernel.org, linux-ide@vger.kernel.org, "Martin K . Petersen" , linux-scsi@vger.kernel.org Subject: [PATCH v7 5/5] doc: Fix typo in request queue sysfs documentation Date: Mon, 6 Sep 2021 10:58:10 +0900 Message-Id: <20210906015810.732799-6-damien.lemoal@wdc.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210906015810.732799-1-damien.lemoal@wdc.com> References: <20210906015810.732799-1-damien.lemoal@wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fix a typo (are -> as) in the introduction paragraph of Documentation/block/queue-sysfs.rst. Signed-off-by: Damien Le Moal Reviewed-by: Hannes Reinecke --- Documentation/block/queue-sysfs.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/block/queue-sysfs.rst b/Documentation/block/queue-sysfs.rst index b6e8983d8eda..e8c74306f70a 100644 --- a/Documentation/block/queue-sysfs.rst +++ b/Documentation/block/queue-sysfs.rst @@ -4,7 +4,7 @@ Queue sysfs files This text file will detail the queue files that are located in the sysfs tree for each block device. Note that stacked devices typically do not export -any settings, since their queue merely functions are a remapping target. +any settings, since their queue merely functions as a remapping target. These files are the ones found in the /sys/block/xxx/queue/ directory. Files denoted with a RO postfix are readonly and the RW postfix means