From patchwork Thu Sep 2 12:49:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 505739 Delivered-To: patch@linaro.org Received: by 2002:a02:8629:0:0:0:0:0 with SMTP id e38csp55341jai; Thu, 2 Sep 2021 06:05:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwzbjny0UgWrzL/d86QGqX0LxgpPICpFQp+MapGzORc+Zs7LC3mtbwURR2nbgNVZcL4pqPC X-Received: by 2002:adf:ebcd:: with SMTP id v13mr3641148wrn.400.1630587925430; Thu, 02 Sep 2021 06:05:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630587925; cv=none; d=google.com; s=arc-20160816; b=GsrzjhRgCd8IzkI6LP2lWws1p0e6JSzZz60jZin4Ki33K/3H8VkXqgf7gHhJ8g4lKh LJBpGaar9Ftj3VauTKCpm2TuzCLBvJeUfdzQWhirStvhPMWklT5G0BRrdIhx6fj03EZW fhkuF3T4GNZGxA+eSmKgz02FJa1WP0mVD+xwzaEIgRhLT4AxG/5YcdxsT0cVAk41JADX njBjK5doI5KO4JJ2nI5PuZiEUkTkmeNe0a2mDwZpUFbvqqhuoc2zRYORZuMUBtMDpSvD Rf/sfyzBc5+jQmeHZof61f66qf840lgpNkcXfbdM9qXCcFcNWyta6u+tx8eVK5hVscpz NXmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=jZoEtknywEr55vZIll6RtNUrJPiXr8V7DhCpfJfCvRk=; b=TD+wDbtiOY6CZ5m+Ue/BAjvcnY7lYiy4A76BobCId2JLbjQg5wwus7LpqJQ6PP9yXz Qm/dzCke3gGpUVN7kgXUOsTiU7OP9pNaHM6UKfMRscJfO5BedSr8IMQxhUtj4RCboXhT 4+wsC/O+WIImMcLkfvRyyBC9XwCFWBm9zsaVEvAkgyxvaDXzmfZ7+jmpOFDRHiAcr8A5 muM7ET2qKsJz+a5TnFR74Ab2DIMMpazgk2F/4/ku/51FeXIyLINaQuHQPZuLZbFoQYh6 IwUNEp8R1jw0SWkTNsPeBUbS0L4ofp+VsZS2PUuFDk8SFrAsrU6ZSVltAPw/SFJyRFFL hiiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Zk3cEY9D; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id v192si1964366wme.0.2021.09.02.06.05.25 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Sep 2021 06:05:25 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Zk3cEY9D; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:35264 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLmPE-0001s3-Fi for patch@linaro.org; Thu, 02 Sep 2021 09:05:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37752) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLm9q-00056H-28 for qemu-devel@nongnu.org; Thu, 02 Sep 2021 08:49:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:58340) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLm9l-000723-7r for qemu-devel@nongnu.org; Thu, 02 Sep 2021 08:49:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630586964; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jZoEtknywEr55vZIll6RtNUrJPiXr8V7DhCpfJfCvRk=; b=Zk3cEY9Dx5vXwI90fNholsweaSqlWHqDCeJw+Cv0li24Hdg1y+lITp+jpOg4K/JHqc5Ffs YP3u+MGNzkNcqk3C+F9EFPjptKZ8wxTHT30bOO5Qe1RLIKzkf8ww4HQP0ExAFh000qysuZ uHfty5AZZ8RldquPfeNmX2mMxpr4VV8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-252-9EG5wXiLMMCnfjhkjGIVmw-1; Thu, 02 Sep 2021 08:49:22 -0400 X-MC-Unique: 9EG5wXiLMMCnfjhkjGIVmw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 10E231940926; Thu, 2 Sep 2021 12:49:22 +0000 (UTC) Received: from thuth.com (unknown [10.39.194.85]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2F16010016F2; Thu, 2 Sep 2021 12:49:21 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 02/13] libqtest: check for g_setenv() failure Date: Thu, 2 Sep 2021 14:49:00 +0200 Message-Id: <20210902124911.822423-3-thuth@redhat.com> In-Reply-To: <20210902124911.822423-1-thuth@redhat.com> References: <20210902124911.822423-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.39, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Peter Maydell g_setenv() can fail; check for it when starting a QEMU process when we set the QEMU_AUDIO_DRV environment variable. Because this happens after fork() reporting an exact message via printf() is a bad idea; just exit(1), as we already do for the case of execlp() failure. Fixes: Coverity CID 1460117 Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210820163750.9106-1-peter.maydell@linaro.org> Signed-off-by: Thomas Huth --- tests/qtest/libqtest.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.27.0 diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c index 825b13a44c..73f6b977a6 100644 --- a/tests/qtest/libqtest.c +++ b/tests/qtest/libqtest.c @@ -301,7 +301,9 @@ QTestState *qtest_init_without_qmp_handshake(const char *extra_args) s->expected_status = 0; s->qemu_pid = fork(); if (s->qemu_pid == 0) { - g_setenv("QEMU_AUDIO_DRV", "none", true); + if (!g_setenv("QEMU_AUDIO_DRV", "none", true)) { + exit(1); + } execlp("/bin/sh", "sh", "-c", command, NULL); exit(1); }