From patchwork Tue Oct 16 09:57:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 148930 Delivered-To: patch@linaro.org Received: by 2002:a2e:8595:0:0:0:0:0 with SMTP id b21-v6csp4867751lji; Tue, 16 Oct 2018 02:59:57 -0700 (PDT) X-Google-Smtp-Source: ACcGV61qFB1yU6t9mt5fzv0kbwIvLAEIqX4DtGpENrqKsEPagbcY0pkHG2vqocYEYb+uXW1yb6XR X-Received: by 2002:a62:99cd:: with SMTP id t74-v6mr21104636pfk.179.1539683997694; Tue, 16 Oct 2018 02:59:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539683997; cv=none; d=google.com; s=arc-20160816; b=fW8iWFGs+BF/Xcd9IDgMMlO2dYGuCbAuvyXnbOoO8zCJ/8pAy5SzujylDI71HWLSPn HRLSg4rJaIjBoZsJiiNrN7W3FcfgzHQH9oaibVS+mXPig7AH7IK1TRzeBDPrkY8ltEBJ cqg7WpbACdaPqW7IT9L5Aj4cxzXfJvzrlj049Cvfg/5GvEc4jDpBfKS7GPCCUuGEDTnd prXzUGmSntUSNbtjijm/6KdeHyHRSIPylv4+KwiaHCxq4CnCpz9NNWk/EK8itEzmzw3P DxwxxtkZsu+e3l2s83VughsiKHrUyCoGrxJxLaUhYeVQyRVTM9Gr36ciPdZ/QLEkfyRX NGAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=E3tXeOfP9/NVoEfrstPNB1vMihdx2bRPlf6ysDXG1io=; b=ILXuvcgVP/jFoQGg9y1MclUd0nQi8JSIl56jWvO5DmN77hB4dEyWMTsyqo+s75Oup2 JSXQDQGlbZdtQu4x1hfLGtYqtlB/la8GiACEIQpePhB2jyRZUM2/VD9QnxdGH780LRJ/ 1NEFyB1Am+VFzHfLsZHQr8kycYaprIicAf6zsbpUSOj7dVqx5cOQh0YlKDf1TTF1aCd5 RSgiPZqAkB+fNGqk8vpwoEzFClvblEI3qhIFzx87Mmn+X/JLsoubwf7dDHdZTq+88nJ2 iBbaXY+eY5zMqbQ7tmhAp5o/0wYjy7lg6mm7BtFD1A9XHgdt9VPJ7DQAoLQ6PIfH31mI 7RoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="ZPh/AAYh"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n7-v6si13275084pgh.359.2018.10.16.02.59.57; Tue, 16 Oct 2018 02:59:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="ZPh/AAYh"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727013AbeJPRte (ORCPT + 32 others); Tue, 16 Oct 2018 13:49:34 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:36941 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726083AbeJPRte (ORCPT ); Tue, 16 Oct 2018 13:49:34 -0400 Received: by mail-wm1-f65.google.com with SMTP id 185-v6so22658618wmt.2 for ; Tue, 16 Oct 2018 02:59:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=E3tXeOfP9/NVoEfrstPNB1vMihdx2bRPlf6ysDXG1io=; b=ZPh/AAYhYaztaIdxG3FLj36DN0WJepMcdsJ+9f4ymf3hrQWcnXje1aPWbY6Yj9I1yh SHFu7PnRUBJAVdq9GlEn5iL1maqtGLFgHDRnV6GZA61mdYVPuWUTYXtguxebYHYUj3M4 FQR5YDKPjE6MSD+XFG9DxMPPPdq0FGtQQqnV4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=E3tXeOfP9/NVoEfrstPNB1vMihdx2bRPlf6ysDXG1io=; b=j28LdmgbtuwNPsYaLjYkxwQOhcDT/rMnqriaEg9x6EXKK+dumhHNER3Ip+ACSc0TKV F231gPwjyf3hYAN2/oyOkf/mIDP1Tff3CLbQocyu1jOa9ztZoKo4WS3gpJ8uRF1ciMI7 V5F1JjYD+B933Rs+zXnOz9Rj0Clxo3myTWDo+BOX3TOUvg+NI4bCmCtjwbQqVQuSTXqm eHR3Dx/VJ4U8eh8JPNSh7Jt0CKuYhnBQSiZcmAGACUJ1zYy4jfJxjfS8ijuBtapOgeeS A35JF/xscqA+0MhPgDdsV4FgXKeEEMKeoq0h9iPqqYsgWHI97KBc6m9fB54xoqaUg37K yN8A== X-Gm-Message-State: ABuFfohKTnMBn5yXvBk0CYzspaGpke124IsCXZjLh3INF8eNj5UTaqVR FY6cXnI8NQa2F4myjYxppPMRqw== X-Received: by 2002:a1c:5e49:: with SMTP id s70-v6mr15883918wmb.131.1539683992828; Tue, 16 Oct 2018 02:59:52 -0700 (PDT) Received: from localhost.localdomain (cpc90716-aztw32-2-0-cust92.18-1.cable.virginm.net. [86.26.100.93]) by smtp.gmail.com with ESMTPSA id 195-v6sm12085163wmx.21.2018.10.16.02.59.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 16 Oct 2018 02:59:52 -0700 (PDT) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Cc: colin.king@canonical.com, linux-kernel@vger.kernel.org, Srinivas Kandagatla Subject: [PATCH] slimbus: ngd: remove unnecessary check Date: Tue, 16 Oct 2018 10:57:48 +0100 Message-Id: <20181016095748.30325-1-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SLIM_MSG_CLK_PAUSE_SEQ_FLG is never set in any of the slim core, so performing a check in ngd driver is totally unnecessary. Also this patch fixes warning about mc field overflow reported with CoverityScan. Making clk pause feature optional will be added to slim core in next development cycle. Reported-by: Colin Ian King Fixes: 917809e2280b ("slimbus: ngd: Add qcom SLIMBus NGD driver") Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/qcom-ngd-ctrl.c | 3 --- drivers/slimbus/slimbus.h | 6 ------ 2 files changed, 9 deletions(-) -- 2.19.1 diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c index 7218fb963d0a..1382a8df6c75 100644 --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -777,9 +777,6 @@ static int qcom_slim_ngd_xfer_msg(struct slim_controller *sctrl, u8 la = txn->la; bool usr_msg = false; - if (txn->mc & SLIM_MSG_CLK_PAUSE_SEQ_FLG) - return -EPROTONOSUPPORT; - if (txn->mt == SLIM_MSG_MT_CORE && (txn->mc >= SLIM_MSG_MC_BEGIN_RECONFIGURATION && txn->mc <= SLIM_MSG_MC_RECONFIGURE_NOW)) diff --git a/drivers/slimbus/slimbus.h b/drivers/slimbus/slimbus.h index 4399d1873e2d..9be41089edde 100644 --- a/drivers/slimbus/slimbus.h +++ b/drivers/slimbus/slimbus.h @@ -61,12 +61,6 @@ #define SLIM_MSG_MC_NEXT_REMOVE_CHANNEL 0x58 #define SLIM_MSG_MC_RECONFIGURE_NOW 0x5F -/* - * Clock pause flag to indicate that the reconfig message - * corresponds to clock pause sequence - */ -#define SLIM_MSG_CLK_PAUSE_SEQ_FLG (1U << 8) - /* Clock pause values per SLIMbus spec */ #define SLIM_CLK_FAST 0 #define SLIM_CLK_CONST_PHASE 1