From patchwork Fri Oct 5 16:14:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 148222 Delivered-To: patch@linaro.org Received: by 2002:a2e:8595:0:0:0:0:0 with SMTP id b21-v6csp641144lji; Fri, 5 Oct 2018 09:15:26 -0700 (PDT) X-Google-Smtp-Source: ACcGV60uYObcglc/k8HalK1MYSQWLJrNC29ctfqqCxiFW4/N5enTXkFikX338QEU7g+JhAcPc/nx X-Received: by 2002:a63:1148:: with SMTP id 8-v6mr11027155pgr.172.1538756126182; Fri, 05 Oct 2018 09:15:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538756126; cv=none; d=google.com; s=arc-20160816; b=rhvpuUeQafm/YdNSPiaB+IDx+HQoKDvml0W1Q2XkTp8SfygkySsOqOnDynXINfFQ7I AJtEdiEvOaoaty5EZn8H3iUkR7Yu8+TsKODb510Yy2I2ZfogAqZbdmJ+56DQ4kyGzchc Sf2JTnRDWMM7/Ei2gBRjUSie73ggfds76X3EUp2ZaK4h7rUmwTE++QjkIzsxFiA3DVjr pSnocaMm5ejE+aPP0hz3hHphUjCt92VuvRaNYXyRRRqhsSfIU2dxEt7mkg04xjhc7hDf X/GSrslA78FWc3nWiXs4EXonVENiLvBArN0ih0kSw1r+hfHJgikcXIgh9ZW2+n9gweuX bDVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=dn6AJ8Bc1HRT/n8Z22tYH2+DtBLZJdBhd0g9lcK99x4=; b=Ft8Mq3mlDThwzUGYQiVGd9t25XeEdX4gW1mb6m2hhSRU0wP9hFeGjnFkVNaE0LskLa rmM0NMaNZjdWcqOV9/9/tcnFFU+GMEgAhvY08fYhEh2/sixC4yFp5lZCXjE7R7EX07Ns XopVb/P/JySECV4MWSifOXbXMsiHeymJW3qRlsVUdPAHTnETf2kF5+gfD2hX+GcENoLr 2B/OprRAKrp4xHcpR557yhXzFlWhxEJRp/cLWvwZFd/9tCs8iRDSMJmVRFWrDi1EXYc4 e0emJmrVkCPt3UgBL/od7L40OGBsyU6ZsOyTRPGr/j6CGGGfj05LknUKJ5A+z+6o8AKJ MNFQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t11-v6si8271344plq.63.2018.10.05.09.15.25; Fri, 05 Oct 2018 09:15:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729698AbeJEXOa (ORCPT + 32 others); Fri, 5 Oct 2018 19:14:30 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:42503 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729411AbeJEXO3 (ORCPT ); Fri, 5 Oct 2018 19:14:29 -0400 Received: from wuerfel.lan ([109.193.40.16]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.129]) with ESMTPA (Nemesis) id 1MbRXd-1fb2fx0XOr-00brf5; Fri, 05 Oct 2018 18:14:40 +0200 Received: from wuerfel.lan ([109.193.40.16]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.129]) with ESMTPA (Nemesis) id 1MbRXd-1fb2fx0XOr-00brf5; Fri, 05 Oct 2018 18:14:40 +0200 From: Arnd Bergmann To: Georgi Djakov Cc: Arnd Bergmann , "Gustavo A. R. Silva" , YueHaibing , linux-kernel@vger.kernel.org Subject: [PATCH] [v2] interconnect: fix build error without DEBUGFS Date: Fri, 5 Oct 2018 18:14:26 +0200 Message-Id: <20181005161438.801080-1-arnd@arndb.de> X-Mailer: git-send-email 2.18.0 X-Provags-ID: V03:K1:YBbGiWIos3Qkal0N8dsXLSd4RJGj/gmFlevjCqFkyIsxRuDqRUt mdX9u5Bt/cN/OWajMV7eR91MoDWrYjQWz1/eCH1Qoao5wr30v63kLz6AJkMq8Q8wZ+/Mb8c MeBE55I0KUTsPpXegbfP/7bFhJYWPuy/2J1SXeRJuKOyK4Cjun3z3CU8fOzquiPRkSblMAI t5WxbJ5WWcWz2jWnxj5aw== X-UI-Out-Filterresults: notjunk:1; V01:K0:zI71+X+cPt8=:aHU1nGMZIW4TmaKqc0Gzo1 qU0M0LOC4I7ikOfJUp8Xw81IbNKAJJ0Uf7L6snI3C+/VG69NnfHHqXToyrU766O7A2wXcTryg kV938AJBnKFMRPSn2+Lqv7lXwZY8o5qEqFBJzAmrXZSjWNmm9wfJywzUyZ4Lij/k1QBz4QeOV uwdgfzZsFhrpq7ZaQP+b/UpIuOBfq5f5csS8DBmT9STKT6kJ04F8CwxZArRwn7SRIOIBygjPN aeLtlxSKmt0H4H95UI44k7N36gttiOimKBMAUvuBGeNuRMgEZB+/W/FF2QX9mVfSE9PJoBpwh /t3ALqkA7MS6aByXqAycRrWXFmHpb7DCD/QDbwkHPrGtgtdQk6VLmfSH1ZYEJm1TPvxjugheW d0D8hMqKP26Fiwv+BMWcKw2ORCewP5C36ceLay6q9GSeOnfbmOiveLiPYB7ujaifHqcJHNPJz s81hyzBdT5mQvbIu1pdWbfB1qDeCaydpofbU1y5qkmlortECV1Gz91mSL+mykhPGH33OcBCgq LP9LJSrYccFOE6A7AIiABQZoHDnrdKU8jXaRbPzwzormleodF2U4mnXUOpyLXmd22iOqHCk8G uzd/Agn1wtUzqvbErJ5T6JX0hZQ1z5y4dc359nFGsjcC8FTyBQcMzvgG4i7EqXUDHPOp97HGG igCPefJHkBpmKNBxGdvn+4ar9uckeK5cuo6zuLYxdJY+XRZp32XCelT2Cz22i+Qric0Q= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The previous fix was incorrect, and now we get a build failure without CONFIG_DEBUG_FS: drivers/interconnect/core.c: In function 'icc_init': drivers/interconnect/core.c:710:32: error: 'icc_summary_fops' undeclared (first use in this function) Removing the last #ifdef as well makes it all work as intended. Fixes: 8f023d0cb757 ("interconnect: core: Fix unused variable compiler warning") Signed-off-by: Arnd Bergmann --- I had sent a different fix earlier, but that was done fore the 8f023d0cb757 commit got applied and conflicted with it, so this new version should go on top. --- drivers/interconnect/core.c | 3 --- 1 file changed, 3 deletions(-) -- 2.18.0 diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c index ba48aa83a4ac..aac7bdd6c659 100644 --- a/drivers/interconnect/core.c +++ b/drivers/interconnect/core.c @@ -52,8 +52,6 @@ struct icc_path { struct icc_req reqs[]; }; -#ifdef CONFIG_DEBUG_FS - static void icc_summary_show_one(struct seq_file *s, struct icc_node *n) { if (!n) @@ -106,7 +104,6 @@ static const struct file_operations icc_summary_fops = { .llseek = seq_lseek, .release = single_release, }; -#endif static struct icc_node *node_find(const int id) {