From patchwork Thu Oct 4 09:06:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 148111 Delivered-To: patch@linaro.org Received: by 2002:a2e:8595:0:0:0:0:0 with SMTP id b21-v6csp692844lji; Thu, 4 Oct 2018 02:07:07 -0700 (PDT) X-Google-Smtp-Source: ACcGV622hleFAcZXrTetfHLldr5z0YSYgWTBT1V5RLbDVzLZuhYDphE4TMpjI3s2G4jabbKRum4s X-Received: by 2002:a63:5d03:: with SMTP id r3-v6mr4919988pgb.445.1538644027796; Thu, 04 Oct 2018 02:07:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538644027; cv=none; d=google.com; s=arc-20160816; b=tvROWaE3EIt8/kY/28QAi/+yMtDOI9iHY+W1y+n6Q2dzFY3co5K0ZgeLjjCNtG+oS5 lhDDBE3Gpo2MYRE2Z6Utl9XZ6Rs4KOkumNVYmfvzcEo3cHWhzH86J4Y97YkfHRERcqou UZk3YqlIDX510e8zjW2LvHbcv1fK2ifB40nEtR0yB8/oBeniUObyYH4C7ngH9XEgcWNK 3UFoMNUhidsF/Xfc90GDZkY8m2NIfNCI7ChxtxwT7BIzSmz6CW3QqdlWqfXU0mExtFQm WKFg8k4M43YMMzYDIqNikK4gOsHOVBtO6TBaR6hScq4FAx2kkvfHDemnfQGPK6V63JYg 5Aww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=H/Kp78sd2+saCthpS30T8q1sq16alrR47c9IyCHdoi8=; b=hTLpmLuBbuSbb8FV0yuSG5MC8X0uFUcaVi4nC6tvxD8St3hTi5FN3D7ZVNj/hMX4UP L7l9xX2G+ZXSwqGEo+G0f6+13rgwPv8snVVnDpN8k4YBo579T23r6hctMViQzmEY+tUd TBjdE4VlQ9RA282z5sEyntJOKv8lnr3mIiWA7qAy2GE6hOyJiEqGFEpIsrlImYaCMxLz DVJCoxaorr0NbVt8/95aA/E3srSlrLkQ7kzSy0THSMCnkqM7TlQs1pfGpZ3CKWnhCk3L jSe8MxEST/XXtQ70bURkjEFb7ofrk7rDzNF53yV0btLXCWINkFojKZsASXaH0fStqnOk hGJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gDnJUGkJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n23-v6si4454032plp.77.2018.10.04.02.07.07; Thu, 04 Oct 2018 02:07:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gDnJUGkJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727814AbeJDP7X (ORCPT + 32 others); Thu, 4 Oct 2018 11:59:23 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:43065 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727600AbeJDP7W (ORCPT ); Thu, 4 Oct 2018 11:59:22 -0400 Received: by mail-lj1-f195.google.com with SMTP id r8-v6so7643640ljc.10 for ; Thu, 04 Oct 2018 02:07:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=H/Kp78sd2+saCthpS30T8q1sq16alrR47c9IyCHdoi8=; b=gDnJUGkJLqvoqTk4gpo6pSkKCDWvUKZwCro3F/VkeY9tuPVFV71VFIsJbXMrrfEd6p tPqA7i1CxKhVqECIWuA6edrlczropnT858U0BiP6IToyFij2RSaQUNff4DsSQt2CUhVc Sr1Kjp7CoaZhcCjop429pibFweeX3C9NCe4qA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=H/Kp78sd2+saCthpS30T8q1sq16alrR47c9IyCHdoi8=; b=CV/7RLIW9wALXGYBOIwH1zS9FE3xmNcDeFuDhVzckQXfeR/qJ8oEVocl/KkbRM0CEg lAN7Vdxb6b4l7OK0OWmFBd6jhdLwA6rhVZdYdoSdAAbu9xr1ZDHi37yIWI3BEkOePTAZ y5RuaPu42JBFxM8+pYwfGa1eMG/JRqyhrRbsJME3on/6tPzG5NX1n8UV/FmsLhoiOx8E Ryg1Iy67AHYRmG8XwGXRK9y7pNbB6MTl+TsDGXCBYSahoXEphptWZIaneljjNGHpcb9o 9RMAKP2PurGCyhil3lAZbWJlW8WKveOhrqkSL7Gciug9INynkNC6+Hq0TP6Zuxdh/JKq 3dxg== X-Gm-Message-State: ABuFfojaW+G6psnBViUw9wDhU5/Nw/5Evrgltp2sf0bQo+yRsHtOQLD0 av5Hbbx/BqjUuBAvJYaHtsJd2w== X-Received: by 2002:a2e:7d10:: with SMTP id y16-v6mr3432476ljc.37.1538644022985; Thu, 04 Oct 2018 02:07:02 -0700 (PDT) Received: from genomnajs.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id n16-v6sm902218lji.28.2018.10.04.02.07.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 04 Oct 2018 02:07:01 -0700 (PDT) From: Linus Walleij To: Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, Linus Walleij , devicetree@vger.kernel.org, Leonard Crestez Subject: [PATCH] regulator: fixed: Use more standard GPIO binding Date: Thu, 4 Oct 2018 11:06:54 +0200 Message-Id: <20181004090654.32233-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The fixed regulator uses "gpio" (singularis) for the GPIO line but the standard GPIO bindings recommend "gpios" (pluralis). We have augmented the Linux kernel to handle both, so recommend the best practice and deprecate the singularis variant. Cc: devicetree@vger.kernel.org Cc: Leonard Crestez Suggested-by: Leonard Crestez Signed-off-by: Linus Walleij --- .../devicetree/bindings/regulator/fixed-regulator.txt | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) -- 2.17.1 diff --git a/Documentation/devicetree/bindings/regulator/fixed-regulator.txt b/Documentation/devicetree/bindings/regulator/fixed-regulator.txt index 0c2a6c8a1536..a0d7f15ef5ca 100644 --- a/Documentation/devicetree/bindings/regulator/fixed-regulator.txt +++ b/Documentation/devicetree/bindings/regulator/fixed-regulator.txt @@ -5,7 +5,7 @@ Required properties: - regulator-name: Defined in regulator.txt as optional, but required here. Optional properties: -- gpio: gpio to use for enable control +- gpios: gpio to use for enable control - startup-delay-us: startup time in microseconds - enable-active-high: Polarity of GPIO is Active high If this property is missing, the default assumed is Active low. @@ -13,6 +13,10 @@ If this property is missing, the default assumed is Active low. If this property is missing then default assumption is false. -vin-supply: Input supply name. +Deprecated properties: +- gpio: singularis variant of "gpios" is allowed in accordance with the + GPIO bindings specification, but not recommended. + Any property defined as part of the core regulator binding, defined in regulator.txt, can also be used. However a fixed voltage regulator is expected to have the @@ -26,7 +30,7 @@ Example: regulator-name = "fixed-supply"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; - gpio = <&gpio1 16 0>; + gpios = <&gpio1 16 0>; startup-delay-us = <70000>; enable-active-high; regulator-boot-on;