From patchwork Mon Aug 16 08:27:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 497753 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDD54C4320A for ; Mon, 16 Aug 2021 08:27:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF07561B20 for ; Mon, 16 Aug 2021 08:27:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234851AbhHPI22 (ORCPT ); Mon, 16 Aug 2021 04:28:28 -0400 Received: from smtp-relay-canonical-0.canonical.com ([185.125.188.120]:59894 "EHLO smtp-relay-canonical-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234845AbhHPI21 (ORCPT ); Mon, 16 Aug 2021 04:28:27 -0400 Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPS id 1858F3F043 for ; Mon, 16 Aug 2021 08:27:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1629102476; bh=lxDKaysG/aHQwlTNKh0Nbuao0YTQ8x2bzMWqPvbdZ6o=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=jeZc+nZAlau1V5fVk6nvKy98NudglkKsgkKEqDAxJFS30LWS42A81kN3AsL6Bg4sw SbbeVKF72KBRt/9hMSR/s74v/JDX1WM/PIsME/wGHvimfHEQNd1+0kClyY3ffaWpix ZckyZ4xQvc1U86y1qFL4J4Ib2h9ykf8jbJni9iGO23wcK/h4P+kO5fXLilriBWWEIo Gmq9bMH8hctFER7R/osvTIJCr6uz3YM1JFORHCSvHSkHZ4CeTyqiUXyKI3/b46Xn8Y EgreidCC2cA5dI7+g8USMvBCQ3HBh9f81n2N/zATax15qJwFpt/SQIinv4UL47w78N Vj5+JD2z2WbpQ== Received: by mail-ej1-f70.google.com with SMTP id ke4-20020a17090798e4b02905b869727055so3887197ejc.11 for ; Mon, 16 Aug 2021 01:27:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=lxDKaysG/aHQwlTNKh0Nbuao0YTQ8x2bzMWqPvbdZ6o=; b=QYHiSnO01cOyPo+Y1WQDy6t1CIWiZj+LGVaGrTg/eqNt9cgG0+aNgh/jbdl+h53EOi lAZ3ogMMK9Loxnbf1jvK2WGuX/mnEqdP9Wz5Q6Vp9WNpK9gdaJdkbroekhyhC1I0OKRA +1nRiPvFCgo1s8pFzP3kw/2seFLoOLBMcYd6FMairRcKkY7BzGJI/SNHeJHh07i5hZ4f 46qlRVUkytyyZKRggHAzbGtapORvrtkg7/zAv/9KgEqWy0K1o3VAAKDMcrsA3PuDM1mr CQAlquHsXBxXksU3My8lfKOrB/U50uuhpslSjeDIeAor4yPZd9EmtUrN4XI0BMtXXo9d k2hA== X-Gm-Message-State: AOAM532HaIDEmI0kayLEO0eiq9wAmwngar84A9x2DepmDTP+yxlvvlxu PeEvjrWDtKrnRjyIu3Z7JAxGv/mOwxpZb0+6/nKy+6QVTMi+dJ9mVEUHvOnDPjtsrVV+zw7dwTg ZbVfNROOH5McGgtMQivLx7Wti9nmI9+s40VKnR88= X-Received: by 2002:a17:906:fb91:: with SMTP id lr17mr15003420ejb.110.1629102475754; Mon, 16 Aug 2021 01:27:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz+BOVdere6Fu0M0Ic4QLSp/IuflMOckAgBI2uLtSkJ1OUJq6KxP3xK5gCoc2lA1BHWOYxnbQ== X-Received: by 2002:a17:906:fb91:: with SMTP id lr17mr15003404ejb.110.1629102475630; Mon, 16 Aug 2021 01:27:55 -0700 (PDT) Received: from localhost.localdomain ([86.32.42.198]) by smtp.gmail.com with ESMTPSA id ay20sm4469605edb.91.2021.08.16.01.27.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Aug 2021 01:27:55 -0700 (PDT) From: Krzysztof Kozlowski To: Sebastian Reichel , Rob Herring , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Sebastian Krzyszkowiak , Christophe JAILLET , Hans de Goede , Krzysztof Kozlowski , stable@vger.kernel.org Subject: [PATCH 1/3] power: supply: max17042: handle fails of reading status register Date: Mon, 16 Aug 2021 10:27:14 +0200 Message-Id: <20210816082716.21193-1-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Reading status register can fail in the interrupt handler. In such case, the regmap_read() will not store anything useful under passed 'val' variable and random stack value will be used to determine type of interrupt. Handle the regmap_read() failure to avoid handling interrupt type and triggering changed power supply event based on random stack value. Fixes: 39e7213edc4f ("max17042_battery: Support regmap to access device's registers") Cc: Signed-off-by: Krzysztof Kozlowski --- drivers/power/supply/max17042_battery.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/power/supply/max17042_battery.c b/drivers/power/supply/max17042_battery.c index ce2041b30a06..858ae97600d4 100644 --- a/drivers/power/supply/max17042_battery.c +++ b/drivers/power/supply/max17042_battery.c @@ -869,8 +869,12 @@ static irqreturn_t max17042_thread_handler(int id, void *dev) { struct max17042_chip *chip = dev; u32 val; + int ret; + + ret = regmap_read(chip->regmap, MAX17042_STATUS, &val); + if (ret) + return IRQ_HANDLED; - regmap_read(chip->regmap, MAX17042_STATUS, &val); if ((val & STATUS_INTR_SOCMIN_BIT) || (val & STATUS_INTR_SOCMAX_BIT)) { dev_info(&chip->client->dev, "SOC threshold INTR\n"); From patchwork Mon Aug 16 08:27:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 497752 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECD0FC432BE for ; Mon, 16 Aug 2021 08:28:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D461561B42 for ; Mon, 16 Aug 2021 08:28:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234958AbhHPI2f (ORCPT ); Mon, 16 Aug 2021 04:28:35 -0400 Received: from smtp-relay-canonical-0.canonical.com ([185.125.188.120]:59940 "EHLO smtp-relay-canonical-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234896AbhHPI2c (ORCPT ); Mon, 16 Aug 2021 04:28:32 -0400 Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPS id 8A06940C95 for ; Mon, 16 Aug 2021 08:27:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1629102478; bh=+y9KjXm+6Q1Y6xNBVx+7TD4DqLneEI99iYpMkXGnRf0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=VKgOHwf0axJLoYaVxkp+xOAhFOBLdpghptXG180lldDGJPT1T9Nhw3i4+0z9Fes8H lLsyJoEDZctVD0b4xy2t5CQrEkBwevZHfThdMOUNTLjU1PApBBeUoPUNZ2rw7kVW18 NtnSKlzvVIHYL7s4COdYQpqclnEHUV0S6mbgC+XMLpWhDr9aF0FhSaWEQWc0jdxNjy Ub6ugaPCm1NhAGHDAGJdcHmvy+09oN3UenV5T6kanE2P7rR14qyTe4CWUW2o9gekbL x9e3HQJ+w0BZvuFcWHxaB3nEJoTCBbv9CqYmhwzZVqbJDZkrprDg8bHvoVR9rJzjN+ haLtb3NKlVQsg== Received: by mail-ej1-f71.google.com with SMTP id ja25-20020a1709079899b02905b2a2bf1a62so4408533ejc.4 for ; Mon, 16 Aug 2021 01:27:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+y9KjXm+6Q1Y6xNBVx+7TD4DqLneEI99iYpMkXGnRf0=; b=XVrPsOTSvDsNBS+Y0Uv7k/xmuMFia/2uqbjpsR76CPIiNrY2LXCv4PDtJY4Jum0OEu OSKL8TLQMQ9gnWKqRNCtma7H4EZkwhV3Sz5VVKy3KUDn0lFKPnmSVFpgM7+mcoD1o1QP gcVGc7FlRgjN0BrQT6mxTaKfjqesLU6/nZbRf2/XYIXsOTZVhPEPG7rQml6ZR51gY7dh 3xMPDFXzecot99qEWaqibjKWkj5nl4mH0Qt5ser6tbWHGTBIVDuwUi1HQ/WjnVaDKDnD hjT2Xh+dU2xns26TtUqeV2eRmUpVl7yVDOQIzNI3eDrmIn47TzoRkv/mPQ0MKPh3p2Dv RA5w== X-Gm-Message-State: AOAM532p84QV8iedypjGWH3Qcnv85OY9fjO2lq9YGUYUporziLuHyT+5 474vvCcyRGZ7X2ukYAhm2mV3GnDkcPntfwKuJzrFKH0Le/zQoKLzHW2YEuM2+VguP+M9/HPAwm8 aY/KbZqgDknlnZ+L73Q9rxEyOd05PJ8oUqX/PYuY= X-Received: by 2002:a50:d4cf:: with SMTP id e15mr18634199edj.2.1629102478236; Mon, 16 Aug 2021 01:27:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyqJhwkRNUMN2vnocd+GAYi0oAHKop6/HTG7JKSYREFONHvZ2PTbnYhmsrS/6vdD/O+TlQA2A== X-Received: by 2002:a50:d4cf:: with SMTP id e15mr18634191edj.2.1629102478131; Mon, 16 Aug 2021 01:27:58 -0700 (PDT) Received: from localhost.localdomain ([86.32.42.198]) by smtp.gmail.com with ESMTPSA id ay20sm4469605edb.91.2021.08.16.01.27.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Aug 2021 01:27:57 -0700 (PDT) From: Krzysztof Kozlowski To: Sebastian Reichel , Rob Herring , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Sebastian Krzyszkowiak , Christophe JAILLET , Hans de Goede , Krzysztof Kozlowski Subject: [PATCH 3/3] dt-bindings: power: supply: max17042: describe interrupt Date: Mon, 16 Aug 2021 10:27:16 +0200 Message-Id: <20210816082716.21193-3-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210816082716.21193-1-krzysztof.kozlowski@canonical.com> References: <20210816082716.21193-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The Maxim 17042-family of fuel gauges are often embedded in other Maxim chips, e.g. in Maxim 77693 which is a companion power management IC. In such designs there might be actually two interrupts: - INTB signaling change from charger, flash or MUIC, - ALERT signaling change from fuel gauge. Describe the interrupt in bindings to make it clear it is about the fuel gauge ALERT interrupt, not the INT. Signed-off-by: Krzysztof Kozlowski Acked-by: Rob Herring --- .../devicetree/bindings/power/supply/maxim,max17042.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml index c70f05ea6d27..95beae958096 100644 --- a/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml +++ b/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml @@ -25,6 +25,8 @@ properties: interrupts: maxItems: 1 + description: | + The ALRT pin, an open-drain interrupt. maxim,rsns-microohm: $ref: /schemas/types.yaml#/definitions/uint32