From patchwork Mon Aug 9 22:49:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Augusto von Dentz X-Patchwork-Id: 494025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52444C432BE for ; Mon, 9 Aug 2021 22:49:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 341FE60FC2 for ; Mon, 9 Aug 2021 22:49:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236062AbhHIWuG (ORCPT ); Mon, 9 Aug 2021 18:50:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230048AbhHIWuF (ORCPT ); Mon, 9 Aug 2021 18:50:05 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09227C0613D3 for ; Mon, 9 Aug 2021 15:49:45 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id bo18so8256888pjb.0 for ; Mon, 09 Aug 2021 15:49:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=P3IDmVuKO7O3HkuAlMjxQDVH5awewBmJogAj+DT7iIw=; b=E3p4vgad15xlbMN8K80JFQfYcoWsulrcvv8gkwic2pEq1wlzPESdvdkR77y9iFDaMr 9yzLRQjtsHGyKrwr8vvrrg9BYthuv3bccOUGX7aFVj5hn8Bscjjg4LIlwIcg4wLn0CLV 4PPybBmaasnP+6sseH4UD6pDJCMyYAitIuisCPkSon7q+lM/TMaLrVmMTYjP92Cz9KvJ JYA2leDVKYgfge3HfLn5xDHZJNAzThk238jaRnPIhJpJVljGGSe4tJYJLlnlecpfhsXJ saSVLCkHEqrKFCojZV49aY5Bk32i+h3IgFkBaPD4/qKFo35hL+tyTbqavjwbOPqvQGmQ 2Dlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=P3IDmVuKO7O3HkuAlMjxQDVH5awewBmJogAj+DT7iIw=; b=ujeNHCwefSjU/K5g22r5gHlewcg8mhfvXh8IYJ9dz+uUPuYNacrmihKmdXLyIQti0V z/nYPUR/sahZhyQew/r4YSbhLGCyFITtXSQBy7YF3vYB+n5GKRtjJvTbxHO0edc1G2gb ALugGbLr86SrAw2NCLKzCOzrQKMfL8jATNvJF7K27/hK3YeOID2wQo+G0iC83p+NAKAB 1HKCDCO9ycgg6ruq+h2LOyRLk4gT+loZ7Y8Hpv2d5ftAWO/8ULWONKhTWNHF8KOC80hO n0LQMHHbUyc2P8Y521zVXBz0t0Qp3jX2oXuyz9VRWunv31ShcViXWICga5acVdyuwCJJ gpHA== X-Gm-Message-State: AOAM533QKmzea900kb4Avi19KR/0UmgR733J23Jgt9YXTVflofP/UIK4 i505gSY4Lie9x/S6V/NOd3bDmJ8GAtU= X-Google-Smtp-Source: ABdhPJxz6Y/eBT9UNTifUUy6i2TrmlK/2AnaK39kIhO0nQTlV6rsudqrJFE8U+fCgVnSGkXPS0nyFg== X-Received: by 2002:a17:90a:ff94:: with SMTP id hf20mr12266491pjb.64.1628549384370; Mon, 09 Aug 2021 15:49:44 -0700 (PDT) Received: from lvondent-mobl4.intel.com (c-71-56-157-77.hsd1.or.comcast.net. [71.56.157.77]) by smtp.gmail.com with ESMTPSA id n35sm20826891pfv.152.2021.08.09.15.49.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Aug 2021 15:49:44 -0700 (PDT) From: Luiz Augusto von Dentz To: linux-bluetooth@vger.kernel.org Subject: [BlueZ PATCH v2 2/5] monitor: Fix minimun packet latency Date: Mon, 9 Aug 2021 15:49:39 -0700 Message-Id: <20210809224942.225915-2-luiz.dentz@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210809224942.225915-1-luiz.dentz@gmail.com> References: <20210809224942.225915-1-luiz.dentz@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org From: Luiz Augusto von Dentz It seems timer_sub can produce negative values leading to median packet latency to be negative e.g conn->last_tx_compl is ahead of conn->last_tx, in which case it should be discarded. --- monitor/analyze.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/monitor/analyze.c b/monitor/analyze.c index 5e0957ad1..d504c8d84 100644 --- a/monitor/analyze.c +++ b/monitor/analyze.c @@ -386,8 +386,9 @@ static void evt_num_completed_packets(struct hci_dev *dev, struct timeval *tv, if (timerisset(&conn->last_tx)) { timersub(&conn->last_tx_comp, &conn->last_tx, &res); - if (!timerisset(&conn->tx_lat_min) || - timercmp(&res, &conn->tx_lat_min, <)) + if ((!timerisset(&conn->tx_lat_min) || + timercmp(&res, &conn->tx_lat_min, <)) && + res.tv_sec >= 0 && res.tv_usec >= 0) conn->tx_lat_min = res; if (!timerisset(&conn->tx_lat_max) || @@ -408,6 +409,8 @@ static void evt_num_completed_packets(struct hci_dev *dev, struct timeval *tv, tmp.tv_usec -= 1000000; } } + + conn->tx_lat_med = tmp; } else conn->tx_lat_med = res; From patchwork Mon Aug 9 22:49:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Augusto von Dentz X-Patchwork-Id: 494024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 835D9C432BE for ; Mon, 9 Aug 2021 22:49:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6547560FC2 for ; Mon, 9 Aug 2021 22:49:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236855AbhHIWuI (ORCPT ); Mon, 9 Aug 2021 18:50:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236329AbhHIWuH (ORCPT ); Mon, 9 Aug 2021 18:50:07 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C30DDC0613D3 for ; Mon, 9 Aug 2021 15:49:46 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id z3so18299811plg.8 for ; Mon, 09 Aug 2021 15:49:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=h5O23deTS/YJXaWeLzUnVmuu6XP6/UdUDz9XhtpcMXY=; b=sYXgHv/rqmWQx8m6P4xEGD9Phu13XhT8NgOf/2BzrZsaJOtRKozGSYDW6jNF0WdAce wj4+lKGSzYRXtVSvaWmEfG7NJo8HLb8TNdwPFES/iFophhZrghvfoWFuI0fSMh+MgyrG reOeRXhXHqH20s4UsEeYOY69rmJ2E1HlBslGsAsMqhlDqWEslc/Z3NVdDIjmNPDpPTvL eX+nPU1L0LnAmNbXmGFJXgLk8DFUIfaoYF8aennAmUF43H9DRohRK9AUHMTN1sfifmuG u3m5WbKwGhNT6gE809PHB5gxTDhraRgNw2xDCovNPuW8bRmjtCCpr8KSse0Pvlmsx6ZM ln9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=h5O23deTS/YJXaWeLzUnVmuu6XP6/UdUDz9XhtpcMXY=; b=pN/lNdsWkBp9iywqoY2nbozuu0fYk+m47sKz5uXfPOw0TzdHE8a/3qOzyxfnRVj0nN mWEuodFayopKxOuX/HxhYjT6NgCxZVHgkphrqvEacjsrmbAaiuNqEsKk6wa3hPJI3raY nxkdnqQcfNUzxCm6ECJl5E3kTb5+Z9eqthil80PNlqRA2quAdTGXeAHUUILT73QgPkMK D57SlA9LxykXbvUEb6mZ96A4RIzrt9ydxAZ3e0hBpFQ5bR7QgBqdocsI8j0rAjzdV0oP aqHk5eD9P3h8SDYi9zmzOoHfMkBnktR1AeFDX6N+iM8PQWpDkdW++3i6tCVc2rRamir5 R5Kw== X-Gm-Message-State: AOAM530YmYspFt/DZ98VQPM891vM7wux4mDzpNjoVSy/48b0tHNUSG+G 9RIKYL/pNGyMtdHAn5k4lz0JaCEDmc4= X-Google-Smtp-Source: ABdhPJymKrXYfsWXl9SqPFUVAecIiTDLKOz3BN//k3yf/H3nWbwY8kk99GysBbzAaCJxEFZ1VlELfA== X-Received: by 2002:a17:902:848c:b029:12c:daf3:94f1 with SMTP id c12-20020a170902848cb029012cdaf394f1mr3403168plo.50.1628549386143; Mon, 09 Aug 2021 15:49:46 -0700 (PDT) Received: from lvondent-mobl4.intel.com (c-71-56-157-77.hsd1.or.comcast.net. [71.56.157.77]) by smtp.gmail.com with ESMTPSA id n35sm20826891pfv.152.2021.08.09.15.49.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Aug 2021 15:49:45 -0700 (PDT) From: Luiz Augusto von Dentz To: linux-bluetooth@vger.kernel.org Subject: [BlueZ PATCH v2 4/5] monitor: Make --analyze output latencies in msec Date: Mon, 9 Aug 2021 15:49:41 -0700 Message-Id: <20210809224942.225915-4-luiz.dentz@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210809224942.225915-1-luiz.dentz@gmail.com> References: <20210809224942.225915-1-luiz.dentz@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org From: Luiz Augusto von Dentz Milisecconds is probably the best unit to have since it is unlikely that the controller can respond in under 1 msec as well as most time sensitive connection e.g. A2DP, HFP, etc, also don't expect the latencies to be over 1 sec. --- monitor/analyze.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/monitor/analyze.c b/monitor/analyze.c index aae153f94..bee05f467 100644 --- a/monitor/analyze.c +++ b/monitor/analyze.c @@ -110,12 +110,15 @@ static void conn_destroy(void *data) printf(" %lu RX packets\n", conn->rx_num); printf(" %lu TX packets\n", conn->tx_num); printf(" %lu TX completed packets\n", conn->tx_num_comp); - printf(" %ld.%06ld seconds min latency\n", - conn->tx_lat_min.tv_sec, conn->tx_lat_min.tv_usec); - printf(" %ld.%06ld seconds max latency\n", - conn->tx_lat_max.tv_sec, conn->tx_lat_max.tv_usec); - printf(" %ld.%06ld seconds median latency\n", - conn->tx_lat_med.tv_sec, conn->tx_lat_med.tv_usec); + printf(" %ld msec min latency\n", + conn->tx_lat_min.tv_sec * 1000 + + conn->tx_lat_min.tv_usec / 1000); + printf(" %ld msec max latency\n", + conn->tx_lat_max.tv_sec * 1000 + + conn->tx_lat_max.tv_usec / 1000); + printf(" %ld msec median latency\n", + conn->tx_lat_med.tv_sec * 1000 + + conn->tx_lat_med.tv_usec / 1000); printf(" %u octets TX min packet size\n", conn->tx_pkt_min); printf(" %u octets TX max packet size\n", conn->tx_pkt_max); printf(" %u octets TX median packet size\n", conn->tx_pkt_med);