From patchwork Sun Sep 16 23:45:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 146798 Delivered-To: patch@linaro.org Received: by 2002:a2e:1648:0:0:0:0:0 with SMTP id 8-v6csp3154575ljw; Sun, 16 Sep 2018 16:46:08 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZtE2Jyvm2B6BLlCAVQPDOWq9sYaW6jJTwA/vD0su8k+WfWsokrRTk0f0iQqIw788m/ZL5f X-Received: by 2002:a17:902:261:: with SMTP id 88-v6mr22254260plc.331.1537141567983; Sun, 16 Sep 2018 16:46:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537141567; cv=none; d=google.com; s=arc-20160816; b=0S7s31T4HBcZnAc5zM6w9StFU1SCG6U9yBzR/Mnke86E8cEo1grZKoZn33Czvnwc0Y U9TZr4qT9MfsWcSRfeZR9Pm+62xgds/TdSKbYFarzUDns0/Bv0frz1oFZ4GFQwvLzhO8 GnkH657AA1TjeXzStbF24mSg0/C0zntQNShS4GXpvirSrWL1YEJxF+rDDAQ1U8/X4Gpi 86c+OTCVzJmKah5rYbzbkTSrQ4SAto/XG/1r05w7llBOMMNUn9TaOvT2Evp82Gqp12jQ Y6BeZEytxoU5YedPpBBsqbHi+26Zohu2kV4jS6haM06Trcgd9k/ORSlg/isjjxAbdue5 7HqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=PIKaH/Ayz19S8iNTPDQor8FxL6MltyIuIX2u6+vfhek=; b=dBs6EMFYPPaeB9xxEqUuMVnIRgS684q/rDYf+9CsDuQK/r6bC1P/NKdgpbtbvUlBxp wXzeTII0TXx1arAen6Fkpe0tnQEzmV8AP6BzCNzxKZ9s87UKU6EtgRVrUcHtED7YUwBh FGGkRtOUTgq7qaWJfpv2fz2/3wozWa7So8SRiCWbaQjxiL3vvQZxgrOzAfsGxxPDd+Pa t3nzz0Z96ICCcrGUN0dp1YHz1VEIM5fT5UpoDAedQ1X//P5DAysposr3dDWh9fwbybFY WfiXIxiAURswojyd+/0XM9T9R1sDW+bMq+aDEwi9Aj5py0MaFRdaNbXAuSIcHS6KpWT0 Ygsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ee7g1aiN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f4-v6si13808546plt.346.2018.09.16.16.46.07; Sun, 16 Sep 2018 16:46:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ee7g1aiN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728186AbeIQFKk (ORCPT + 32 others); Mon, 17 Sep 2018 01:10:40 -0400 Received: from mail-it0-f68.google.com ([209.85.214.68]:50869 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726889AbeIQFKk (ORCPT ); Mon, 17 Sep 2018 01:10:40 -0400 Received: by mail-it0-f68.google.com with SMTP id j81-v6so8967053ite.0 for ; Sun, 16 Sep 2018 16:45:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=PIKaH/Ayz19S8iNTPDQor8FxL6MltyIuIX2u6+vfhek=; b=ee7g1aiNVMrlWJbii8louGa7accboQgy+AOfEg9XLtOZpHOJBDpBDYMeFIJoikkMs6 s8EyyClPK2N6P8A4yOToExebsnio4GPoC7GlrgJpUUShXH+KgqouuDSHHGs9VzOTYHIn NbtlhdZOVETN+bKhQ6HZ3gGkdpNIyHjFH85qc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=PIKaH/Ayz19S8iNTPDQor8FxL6MltyIuIX2u6+vfhek=; b=JLx5sG/YOilmMa0D/o+UvYGayBg6TiyfUhUyvzP6AmwGH3rjyM5iY2bQjbakRP4v4V IWALNh/oknKrNcO8RX0vmMGt9ZGlJ/+Lj38WbAi/daGkZh3gZpoQWk7r1KDvSTRb6q1m fibFri89W6RIFAZb7c+4JDtW7KJpUk8cV27+wTqHaZxWAntJuJ/qYCDpeN+RfUXRMfPu 6yPYK07XhZrNJO63Sv9UklkZ3mb3AnwPIcGBslJiOiytR2Zm5x3Pw4UADIX99fn82KSv KEcXzFR0z3FA3sPQLrWPUQ4V4fkl64DbsnhfHITO7x/7dwnqgT5RnjXma6dXeHvc8JjZ meOQ== X-Gm-Message-State: APzg51AYSqqFywJnoxEO9yDhM0fnXF18BOpxeEMEIcqVnrZS1jQm4fit grJ/dhcAYNKUszgd0jqRlpRaaA== X-Received: by 2002:a24:24c2:: with SMTP id f185-v6mr10666065ita.18.1537141559357; Sun, 16 Sep 2018 16:45:59 -0700 (PDT) Received: from localhost.localdomain ([209.82.80.116]) by smtp.gmail.com with ESMTPSA id a11-v6sm4495177ioc.63.2018.09.16.16.45.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 16 Sep 2018 16:45:58 -0700 (PDT) From: srinivas.kandagatla@linaro.org To: gregkh@linuxfoundation.org Cc: broonie@kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, vkoul@kernel.org, Srinivas Kandagatla Subject: [PATCH 2/7] slimbus: core: update device status in probe Date: Sun, 16 Sep 2018 16:45:41 -0700 Message-Id: <20180916234546.29661-3-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20180916234546.29661-1-srinivas.kandagatla@linaro.org> References: <20180916234546.29661-1-srinivas.kandagatla@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Srinivas Kandagatla device status update can be racy with probe in some cases, so make sure it take lock during the probe. Also after probe the device is expected to be ready for communications, so make sure that a logical address can be assigned to it after probe. If it fails to do so then probe defer such instances. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/core.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) -- 2.9.3 diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c index 31f2910..262591f 100644 --- a/drivers/slimbus/core.c +++ b/drivers/slimbus/core.c @@ -40,8 +40,23 @@ static int slim_device_probe(struct device *dev) { struct slim_device *sbdev = to_slim_device(dev); struct slim_driver *sbdrv = to_slim_driver(dev->driver); + int ret; + + ret = sbdrv->probe(sbdev); + if (ret) + return ret; - return sbdrv->probe(sbdev); + /* try getting the logical address after probe */ + ret = slim_get_logical_addr(sbdev); + if (!ret) { + if (sbdrv->device_status) + sbdrv->device_status(sbdev, sbdev->status); + } else { + dev_err(&sbdev->dev, "Failed to get logical address\n"); + ret = -EPROBE_DEFER; + } + + return ret; } static int slim_device_remove(struct device *dev) From patchwork Sun Sep 16 23:45:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 146803 Delivered-To: patch@linaro.org Received: by 2002:a2e:1648:0:0:0:0:0 with SMTP id 8-v6csp3154742ljw; Sun, 16 Sep 2018 16:46:20 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdbb0YU5V8gShMhgW/gj2DEBw5azwUQXngFNnl5bgiml3wNrZhjagkAuWXjGQMhBlUqU7k73 X-Received: by 2002:a17:902:9a06:: with SMTP id v6-v6mr22423925plp.316.1537141580439; Sun, 16 Sep 2018 16:46:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537141580; cv=none; d=google.com; s=arc-20160816; b=uHMfobNuwX0UI4HTftrrdLfNsAZiW+qnawoKH7GIuLRsthI5ymRN8eDgQEjb5IFL7n OwInNDKE9Ty4Jdr1nv9TBIKmE/SLp7LezAg2GSvDTxYfQv2UKhM13u8dqddlWhaIInbk hkUQMThH3PoKGHx2ljj3kWTC1dYnKmGNnnySQvgv5z33F+i3aoRSWIOVrvLdhP+7xetD pD+mBMw65ycTG4r5xZxa0Ba44ptZviLTR8zkquxJFgWRuVDc8r/nfLG0PzjnDCFlWWeL KrryS247TqPTXriAzAsdsk8bJ+bcPsDpczILZX0svBOcOeZ7mUBTptWjmdqGIOyUsNou c7Pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=PeH6Ipil7CJB8tr8f+7fACMPhexFa7TfJUCZcP2TPv4=; b=KVPc/Db4AMxOrFDlEMfF4wXEtPUoUChni7b1/ioQWJUG1F3KeygQILO9mEmqYO+yU4 JRpNv3wFFnGRGYWMIMpeQzoM76heLMb3930oK7S+xTMeviP5pezWGKH19he5XMt0oZSc 3oTndYHqRjKoYGAKhONdZlSrIanOdHiPlr3UMvReBngm0uRFQKIkPdKrwGsQrql/ysP8 U4s1QCuUGr+LlzrUj6+DI0A1rvQH6x6WT9hnZCzR8xbNrdcNgIv5B39b6tgi6NQTE6dx p1TcLHxk15q1StdnlyN6X/FzSJrhkGKjjZJ1Cafp2OKJLmaIWEe8Vsro9dF895QdoLwo +v3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JhtiWx6z; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t190-v6si14663302pfb.344.2018.09.16.16.46.20; Sun, 16 Sep 2018 16:46:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JhtiWx6z; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728363AbeIQFKp (ORCPT + 32 others); Mon, 17 Sep 2018 01:10:45 -0400 Received: from mail-io1-f66.google.com ([209.85.166.66]:41907 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728330AbeIQFKo (ORCPT ); Mon, 17 Sep 2018 01:10:44 -0400 Received: by mail-io1-f66.google.com with SMTP id q4-v6so10045052iob.8 for ; Sun, 16 Sep 2018 16:46:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=PeH6Ipil7CJB8tr8f+7fACMPhexFa7TfJUCZcP2TPv4=; b=JhtiWx6z2EAkugIUVFF3mdBXCn47MKdK7pJ+zNcau76PFl/LzR0YlIKmSZmiDcAJTZ BegA6txQXHCF1UTovMDhfGyZ+tiFSeGRljIUKH9RrmORZjqHZsIcbxv0kjwF8MySqIwY vPD3xPTir7pagSO/M6yhSYdydYdK/XiWjaFSA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=PeH6Ipil7CJB8tr8f+7fACMPhexFa7TfJUCZcP2TPv4=; b=kobjAww7H6zko7VEeYCgtjkUzABwfEJHnLhpOTnHTX9p4tU61h20t0A7G3P8dhplSI TmhPL/DQq242aOXI2vuwrfwSH8wy2TNr54NC1I1zxnWROvW9UFoDn6QIB+NfG16OIvK9 677npiqfo8XhEQGboATjzR73XD1kDs+GyeuqnZ8jdtbnP0r5YR20ZgnsIGkFGcaMwzR3 /s3sRiqcuIQGbdjigFWwled08rBk/D78lH4q45pRzx1ztedIPnMzEPeE/yB8RJ9w01XQ /wCjI0nkXZbZF8hS7dLRdq+QUpYEEWDS6NHHp1JjVuU9EAPK2HZZl9JX2J4I9eio4tUx 7m4g== X-Gm-Message-State: APzg51AeaXmjGg+JkhCRJ0ZRtMk1kH8RUWw9FGqfU5sOItp/EsiN7EuZ 30posBWLRBJai4d8eQk1s8+Jyw== X-Received: by 2002:a6b:1706:: with SMTP id 6-v6mr19948407iox.58.1537141563501; Sun, 16 Sep 2018 16:46:03 -0700 (PDT) Received: from localhost.localdomain ([209.82.80.116]) by smtp.gmail.com with ESMTPSA id a11-v6sm4495177ioc.63.2018.09.16.16.46.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 16 Sep 2018 16:46:03 -0700 (PDT) From: srinivas.kandagatla@linaro.org To: gregkh@linuxfoundation.org Cc: broonie@kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, vkoul@kernel.org, Srinivas Kandagatla Subject: [PATCH 6/7] slimbus: ngd: return proper error code instead of zero Date: Sun, 16 Sep 2018 16:45:45 -0700 Message-Id: <20180916234546.29661-7-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20180916234546.29661-1-srinivas.kandagatla@linaro.org> References: <20180916234546.29661-1-srinivas.kandagatla@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Srinivas Kandagatla It looks like there is a typo in probe return. Fix it. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/qcom-ngd-ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.3 diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c index 0241373..f48a06e 100644 --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -1396,7 +1396,7 @@ static int qcom_slim_ngd_probe(struct platform_device *pdev) if (ctrl->mwq) destroy_workqueue(ctrl->mwq); - return 0; + return ret; } static int qcom_slim_ngd_ctrl_probe(struct platform_device *pdev) From patchwork Sun Sep 16 23:45:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 146802 Delivered-To: patch@linaro.org Received: by 2002:a2e:1648:0:0:0:0:0 with SMTP id 8-v6csp3154621ljw; Sun, 16 Sep 2018 16:46:11 -0700 (PDT) X-Google-Smtp-Source: ANB0VdaCqtD4QO+zvBngDp9evWs6Ahv6eGKcHyQz1TNlhdYaab7LwvaQjXvbPsBCJwmlV2aT/MED X-Received: by 2002:a62:225d:: with SMTP id i90-v6mr23253707pfi.246.1537141570908; Sun, 16 Sep 2018 16:46:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537141570; cv=none; d=google.com; s=arc-20160816; b=W7gyB45kVmZ5NBidnOvEJosaOzYzUe9Nb+CCayUc9+f4r2ZRLByvM5mXDW91IkbyNm +BdlYmHvcEbyLXGEW1PXOiF132s28SMQuburNGejB+cJoOjgRHaCzJarCqyscMKO5zH2 UkiOl3+w8SWfLNRME32POIVBxVi0bIoz4jr76ZZPUvcimf2BoPEXahMSkluySqE4id6I lZfa41gWU3r2IDyjqYEfr9Y1aHafoBUBAI6QhJT5i9v3F8ep3nYCIFOH3iwoZKvBhQG1 wyhkxJk2S6URbzVniAe1yPhWkLmoziDJaxfD+v+eHfyp7zUdDgz7Iwp+pXhA/U++2rNX XS5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=jtP5RlYyGuGTnla229QkTJ0o7oCjU+RhaUaOIesIN8I=; b=VezDFSW3fqeveSRpd38gkwxuqn3ploEfs4S0cM/5N+Ak6Ui6oHw35Xz3XBG4ImqJ5q +FLNx9NXeaxTfGThfhQvMG1rzlk9nAMveSOlG31fFVwjd58JkEVzQv7r/mpnmpYgh6HF 3NN/djANk/wrbZsVANSg/S/WQcKNur1yNUWKnqFOwGK+FC2DoWcQiBFYjKME6pm8ApJI X1SYx2XO82v9OtjtxwTYQRpzGdc+0hlI9WKoo5ubng2TiTwIy41VmAvVdhuE9J105KPR WMJ772vBxOKuHDqh6n4jurgO41WC9DN0HAwQp+OohbRq64dCGfUTFVLoCWQKIrl9SvYg 2vhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KYdzg5j8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f4-v6si13808546plt.346.2018.09.16.16.46.10; Sun, 16 Sep 2018 16:46:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KYdzg5j8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728471AbeIQFKq (ORCPT + 32 others); Mon, 17 Sep 2018 01:10:46 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:42246 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728383AbeIQFKp (ORCPT ); Mon, 17 Sep 2018 01:10:45 -0400 Received: by mail-io1-f65.google.com with SMTP id n18-v6so10035843ioa.9 for ; Sun, 16 Sep 2018 16:46:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=jtP5RlYyGuGTnla229QkTJ0o7oCjU+RhaUaOIesIN8I=; b=KYdzg5j8aQsmO9zzMB1fGl/cmsHCcObkw1uU82ow+JkH13oOCQ8kfuGjKnm5+PfODe EEvvH/I7x6HFe3+k94kZvBmYPuEo+EcWG+U5QQGkZ/segl5xBTPVQBo4kT5y4GMchn1U /P/dCEHKWWZOUs68tpxumjJSpuT/0LGWKTc+8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=jtP5RlYyGuGTnla229QkTJ0o7oCjU+RhaUaOIesIN8I=; b=DEw2xgJ5xr/dcwJsOzcjcn1Xyr0X9XZqRH0erQWF3tCt5n1mdNPMnsGui4jeIW64L9 XLNc6RAN+4rRLjr9H5e6IQpnIhwfFvn4mmwWOsMCZnJyudNTWDYaVOiB7iv81pejJ1ua afRMzPFAx0JNcH9jHDDMD1IVo3re/xVt1t0ngn/UxsBhE2nWO0H+Pa1WqtnNtg1aN76E e68a3su4zUunqc3t3iu3R92r6a/jj+EQGDVhR/17UiOeSmLwRejURsYldihlmUIrNDZL Cz3E9zMHh3uEiITrHSEamYtaJYkEPAj/STYaDKn5CvGY9Eq8ceWg1/hjZH1WxTf3tTKJ 3e0A== X-Gm-Message-State: APzg51BXswawDGvrvvazdfQOQf7fp8YwILqptTcpPjHp/KPdT8MqvPvB CeqmajhF7TE1eTSOjBINCdHFRg== X-Received: by 2002:a6b:1416:: with SMTP id 22-v6mr18665180iou.218.1537141564842; Sun, 16 Sep 2018 16:46:04 -0700 (PDT) Received: from localhost.localdomain ([209.82.80.116]) by smtp.gmail.com with ESMTPSA id a11-v6sm4495177ioc.63.2018.09.16.16.46.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 16 Sep 2018 16:46:04 -0700 (PDT) From: srinivas.kandagatla@linaro.org To: gregkh@linuxfoundation.org Cc: broonie@kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, vkoul@kernel.org, Srinivas Kandagatla Subject: [PATCH 7/7] slimbus: ngd: register ngd driver only once. Date: Sun, 16 Sep 2018 16:45:46 -0700 Message-Id: <20180916234546.29661-8-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20180916234546.29661-1-srinivas.kandagatla@linaro.org> References: <20180916234546.29661-1-srinivas.kandagatla@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Srinivas Kandagatla Move ngd platform driver out of loop so that it registers only once. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/qcom-ngd-ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.3 diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c index f48a06e..f7490d7 100644 --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -1355,7 +1355,6 @@ static int of_qcom_slim_ngd_register(struct device *parent, ngd->base = ctrl->base + ngd->id * data->offset + (ngd->id - 1) * data->size; ctrl->ngd = ngd; - platform_driver_register(&qcom_slim_ngd_driver); return 0; } @@ -1447,6 +1446,7 @@ static int qcom_slim_ngd_ctrl_probe(struct platform_device *pdev) init_completion(&ctrl->reconf); init_completion(&ctrl->qmi.qmi_comp); + platform_driver_register(&qcom_slim_ngd_driver); return of_qcom_slim_ngd_register(dev, ctrl); }