From patchwork Mon Jul 26 16:36:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Anderson X-Patchwork-Id: 486097 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78FDBC432BE for ; Mon, 26 Jul 2021 16:37:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 61A8960F57 for ; Mon, 26 Jul 2021 16:37:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239668AbhGZP5A (ORCPT ); Mon, 26 Jul 2021 11:57:00 -0400 Received: from mail-eopbgr60083.outbound.protection.outlook.com ([40.107.6.83]:61927 "EHLO EUR04-DB3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S239408AbhGZP4z (ORCPT ); Mon, 26 Jul 2021 11:56:55 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d8VxbZjgFl+WQ5n1UsoaZ7kQgkTUukmd1yojI7jut2TX7lcdICc5GoYcwAfm8uvVt1pKUvr8Pn7b+jFim1xbK63A80AyXDfaUNHMR//9KZNpa6lf2Ty9kqx6vIWEjrqapG/sz8oC/MLsZ4P6lwNVNc3MPWqNKrL8WfNk6elccMA8NTdqlk1uZ8vYdpYfE88WXqpqSrfWoEK0CMxLz8MFXLUntbEAeshvTO7n1p/PElDCkWdsoSZy7inEhbmb9TJxfblLPM9O6ltLt40GUaX/9upkyuMolTB/3GfuP8rxLce2eVXgcctgjF4UFMJND5V0i7bzE0CvqhIvIgzy6RT09A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kgmntm8Eu+a5W3B7CrDNtm5586nY7WtX5nHjm/P8/HU=; b=lkI33JBecFFkmSZZ3l+cbNWBg+967GcGpIpSeaSRTpghNVv0+GjwCbsBuJa7FYV+xW8Truqrs2WGraVUvo74Rtq/eEHOlrkZRUl/FC6BY2jj3GbTJwhJGtjEoZRnUqYxeOIVykgbEsRuifGp7TD829+DEW2Q3hYMTYfLx8M7BSIvl0JjVZ+s22UGS1iLddtQjFxWsJFamnCerlPnUJkSNRTHFeAf0dkGBooAuuqJh/GkjchpYcUdSOu21kQkZai9aTq7iJglAvQ/830d0oMwzXP7VZzB1RXkOC6EWNlnsNXhvsUxeLwxeVrdu4MOC9XrEHcPE/j+qUg/MsonRhXtvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=seco.com; dmarc=pass action=none header.from=seco.com; dkim=pass header.d=seco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secospa.onmicrosoft.com; s=selector2-secospa-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kgmntm8Eu+a5W3B7CrDNtm5586nY7WtX5nHjm/P8/HU=; b=Jf2ygHbCMQqYjyYt3bZnIwrSnhqFomkoru4pmdGswWAkoYr8X8E+W3DW1cn8hi+K1DcEOvuCImID4qlZ2rqZFyyAQZbdmflNyztWrxgZNFqZ8E2YLBEJLxfpcmRvyQfcK1Uf0ZTqgQoGSHshTWJZXGWYfVBfTyVt55YRi7z54tU= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=none action=none header.from=seco.com; Received: from DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27) by DB7PR03MB3962.eurprd03.prod.outlook.com (2603:10a6:5:30::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.29; Mon, 26 Jul 2021 16:37:22 +0000 Received: from DB7PR03MB4523.eurprd03.prod.outlook.com ([fe80::dc6c:815b:2062:d1f1]) by DB7PR03MB4523.eurprd03.prod.outlook.com ([fe80::dc6c:815b:2062:d1f1%7]) with mapi id 15.20.4352.031; Mon, 26 Jul 2021 16:37:22 +0000 From: Sean Anderson To: linux-mmc@vger.kernel.org, Ulf Hansson Cc: =?utf-8?q?Pali_Roh=C3=A1r?= , Sean Anderson Subject: [PATCH 2/2] mmc: sdio: Print contents of unknown CIS tuples Date: Mon, 26 Jul 2021 12:36:53 -0400 Message-Id: <20210726163654.1110969-2-sean.anderson@seco.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210726163654.1110969-1-sean.anderson@seco.com> References: <20210726163654.1110969-1-sean.anderson@seco.com> X-ClientProxiedBy: MN2PR14CA0023.namprd14.prod.outlook.com (2603:10b6:208:23e::28) To DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from plantagenet.inhand.com (50.195.82.171) by MN2PR14CA0023.namprd14.prod.outlook.com (2603:10b6:208:23e::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.26 via Frontend Transport; Mon, 26 Jul 2021 16:37:22 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 46df3b33-6fd5-43cc-398f-08d95053a4b2 X-MS-TrafficTypeDiagnostic: DB7PR03MB3962: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:655; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eNw6J5PjtGFzzHGWUoL6gp4OAv79Yxzix32mSupP5QFUmBoh3hsb+2Nznv37EJLxfo54EHYaseGL+SalC7WwOngB++gJ1ZnKkGcmwPZf1LjuLU0yQ8ImxTBrDhbcHlFA/wP9jcEONTFa1K0nh0h15rwdPuz2HP41DFofHXZFORlalmNmLy4taPRp1slCJ5IWynNUVIw6mFRRN/FevGqfBImqiVcEKFJ8+fHrhMZFo0zr4Jy+7Efn1qSZeSlmGRUyGTgSkfwFeWIKYoOYWWWVY+B6muete4Wl/mshM34m7cQCkTlxTj4NpXITBY+6mUoJaudN8Uw2ER7Py7efCzRxlOmWLi+HHmDmzdVoLvHuxBeHBRwpEVol0ipc2hcruHkeOUM33cVqLtuWfK5+WKTsJtZAgLuH/SugWpQEbWi2ijUFrYAbB3yl9RLGpel+l5b9TlUqo9NVFy2adkzs4KUQoWHDP0z8TKKDzDIrXbDxh1+oUH1o1aWvIvMWF+bT1/tQyce7stqrxn0mftAeEY3w7vTX8YGvZn8823Cu/ClrknNu6MKqIr7KbRWTbS+fCM1PZSpaEoqUXAxY28m3/PZ4kLQeuCPBpQLeookbFzqpVFjyG09D5+LpoM9Of6OKkvYxh2vL3A3L5U3tE1RevzkZeXbQhQmdCvbVOKpiDavUNusVERzGc/BBnb1xle/keb6rtuc5vFHWn4IcUJj6RcamyQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR03MB4523.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(54906003)(38350700002)(316002)(508600001)(186003)(6512007)(86362001)(36756003)(66946007)(107886003)(66476007)(8676002)(38100700002)(6916009)(8936002)(52116002)(4326008)(6666004)(66556008)(26005)(83380400001)(44832011)(2906002)(5660300002)(956004)(1076003)(6486002)(6506007)(2616005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?XUobtiKIblNByOJvWiRcBBusC?= =?utf-8?q?dgmuhsxl16/7Yol1v2lthtIGKMg3evx8fvLaqRsnFLqiI3f2ci5pgYuJ?= =?utf-8?q?y9IS5wT2RWP+VinPqJG6WO3rSrDaWYH6K+iyr41/yEeUupISKPr7NWrb?= =?utf-8?q?lks2ftakAdHabNtlT/qcIbeKM8s1TePxXV8efgQNgV6PRptiTeMl0O++?= =?utf-8?q?3ocaGLWHfBqWviFF5tEGI4aQ1P1QYIoagwqS6oKisE//msTjupDej6aS?= =?utf-8?q?w/Mea5cBx7B5Vi6PUvzyugLbb0rTZ35i0JtaH2RSQhDjhSKeF3pUqGwJ?= =?utf-8?q?uJequDFB0h6uVGm8OoX6I480ZExnyRuPiu320RY4jYtHY/XNhdtaJB2Z?= =?utf-8?q?cYwd82P1hfpcMhZzvWaYBSiw4IRHEqAkDoyig0Nt+txCewh4IHcQF+bf?= =?utf-8?q?t9bPuMqLM7j7kPfjTVo4+TqCRj9ZNOfDAHLX2IJsomysYPPZhvq3rCkR?= =?utf-8?q?yf4wfx9Ney7Eol25z/+FhS6gSmGKYSjkxPriDHBCN5/9kd+BbzltDFrr?= =?utf-8?q?xRcitf8dWQTLLAJ/xnkxLJJKu0SSbgp8nL8FWuz+8H1cgAMETjOC8ZUW?= =?utf-8?q?zDvvZWyXo7ykXyrhZ9AsRiuq9p6El7aW9Ct/EWNSeD9gfet16tYbUjpU?= =?utf-8?q?oU/iVNkr7I7eV1S8cN+hiZid/y+FscMFxSeL/NoTJ6cPTFTQbQF/U45f?= =?utf-8?q?Z8OZ23yBm+g+lX9rwyew5JjzcVheaZgBnMY16oIaYR0KxLkal8iHk8jc?= =?utf-8?q?fJmPTHEmh2o9NtohaTh1ipx0RbFJIfnFxjXDrsZThYLJdf75S6L2TseH?= =?utf-8?q?c71z7HePGRDbdOoGQCGcg4XyZV4IjgyJHc9sD5cEhIZSeeGlayOajwhk?= =?utf-8?q?utb1ojryTrkzV9bDsqDcJ8cKPB9hSy5k2s8xxv0+dzboyHA8M6plVkdH?= =?utf-8?q?ezWvFiX/KkAXFSTrJJAVuyL8QCug1Ab3rc6EZXAvmcQriOlqCqmJv8DT?= =?utf-8?q?ddkcLrN1DQE45H4uT4jxIzHKuwn5VEuBC6amMXidQon/3UT0BFAdDe99?= =?utf-8?q?iAp/KDleAXbDY2pVjHtgUIdfxJy+Q7tt3IsRjXYp8LKGd/LdKVz8cB2F?= =?utf-8?q?4oe+gpHVIhMOfE6hEC1tQw4wla3pcrijk4+5JCO3wR8pJhkVmIP0bxtw?= =?utf-8?q?FpfQR6V9vbjwbbb2ur4SFDFfOaa3uow01dsn7oXwKdW/NIM7vzsLkEby?= =?utf-8?q?pAViDZniB06o0bB2S3bw00iId41miHRb84Qq5Yo40gBgC6F5RLG72ZyJ?= =?utf-8?q?k/b4Q5IZWTjpfGw66xOsygUDnVbNZ3pTRpElvkQRXgK53ngrcIH8AkWV?= =?utf-8?q?Ecy7aeBcoPtbFjKf4Y5vPFknmzVrqHN?= X-OriginatorOrg: seco.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46df3b33-6fd5-43cc-398f-08d95053a4b2 X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4523.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2021 16:37:22.7106 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J3b4srHLCqKjAKvQI9Wp6iH6KAES9E8007BRHFYp7hLIORt5eMOeNflcSs1leqvTIGGHMspxyHeDXw1mLCzIAw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB3962 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org Print out the contents of the offending tuples when we do print them. This can make it easier to debug, since these tuples are not exposed to userspace anywhere else. We are limited to 64 bytes, so keep printing out the full length in case the tuple is truncated. Signed-off-by: Sean Anderson --- drivers/mmc/core/sdio_cis.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/core/sdio_cis.c b/drivers/mmc/core/sdio_cis.c index 7518b27bcef2..a705ba6eff5b 100644 --- a/drivers/mmc/core/sdio_cis.c +++ b/drivers/mmc/core/sdio_cis.c @@ -334,7 +334,7 @@ static int sdio_read_cis(struct mmc_card *card, struct sdio_func *func) if (time_after(jiffies, timeout)) break; -#define FMT(type) "%s: queuing " type " CIS tuple 0x%02x (%u bytes)\n" +#define FMT(type) "%s: queuing " type " CIS tuple 0x%02x [%*ph] (%u bytes)\n" /* * Tuples in this range are reserved for * vendors, so don't warn about them @@ -342,11 +342,13 @@ static int sdio_read_cis(struct mmc_card *card, struct sdio_func *func) if (tpl_code >= 0x80 && tpl_code <= 0x8f) pr_debug_ratelimited(FMT("vendor"), mmc_hostname(card->host), - tpl_code, tpl_link); + tpl_code, tpl_link, this->data, + tpl_link); else pr_warn_ratelimited(FMT("unknown"), mmc_hostname(card->host), - tpl_code, tpl_link); + tpl_code, tpl_link, this->data, + tpl_link); } /* keep on analyzing tuples */