From patchwork Mon Sep 10 14:21:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 146312 Delivered-To: patch@linaro.org Received: by 2002:a2e:1648:0:0:0:0:0 with SMTP id 8-v6csp2551339ljw; Mon, 10 Sep 2018 07:21:16 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYLcON+wA2j72rqskEjZCG83u0gARUvL59M3WFVvaBI2IwAHTXPvWPP1c3WtA+TEMzoEYkR X-Received: by 2002:a1c:8a04:: with SMTP id m4-v6mr925889wmd.137.1536589276300; Mon, 10 Sep 2018 07:21:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536589276; cv=none; d=google.com; s=arc-20160816; b=dbge4xOIS6Iw5SsnBqR9VsHJ1q5eEMnakK28tb7nHXfJHr1viK8niD0vsgTVScGsiK 9Vi5Abj2SwXzO+f9oo4GqpNDhOfWdJNn1gErjGkbNQJWCc/i0VEQ482qaZIbW61rM5LA uEC6uzvh8KtFdpHCYF5BoB1xGd6tPgIpVyz8VnSl31fxKZNuMB6vO9N/vTQi/Rwi5qe7 TIUe8gq7a3fgjKo1bNGgbYXvrvFN9uw3tfj8d8eNfOYkD7mCjZeU3Px9/uMC5XBSywGb Zo+EVUwj0BklO63eruLZhfnpvAbIBthXFgsNvpeTD1Nx4wSTWjdYGHgA3a1nTBaEoTrA sirg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to; bh=2NSuCycYmhWda5skdeLuiZEzOPFJMrJ/oor/jZ1dFok=; b=RdoLlDXxdEm1msf6sUuy+ufxGQQb0iowQpipRAYtKdo08stakHDrk/7/a1rFBkDcRN 4zoKX7zo4LogMIhTTIMn6mXN7LLWgGpISUknoEDbbPVpIQmGkeHlXUUfs0PxcYIdS05c DfSiYV8KaWzzLiu5fvgMCO73YA8FNCjU5Zw+5OJi1x8RiFyJ3dOMRvX2+Siqnk841mG6 w7RfEluNeHhDGLjQsMfWfwxCEa4D4B8Krhe1tD7CeCIXQlrl+cDqFdnO+8mO4nU2291S JhLeFofw9AdD4m+T4AX6OkyrH8z9T+0yfip6cyjYmHCaUG0ZKjfGy6u1pM3IZRCBH7PJ rnPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=h8RUcSZM; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id v18-v6si16347440wrm.278.2018.09.10.07.21.16; Mon, 10 Sep 2018 07:21:16 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=h8RUcSZM; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 4176426787C; Mon, 10 Sep 2018 16:21:14 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 7C29526787F; Mon, 10 Sep 2018 16:21:11 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id EF2ED26787C for ; Mon, 10 Sep 2018 16:21:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=FctT4yTn5NciQudq/ll8wZsFyfp0xeOqevZNuM/8GHM=; b=h8RUcSZMDliL 0hy1BKPI09V/CPO9A4HvsZ7ypX1b9bOqyPt8PPo+VDFuuorOdxYRqkXzxa3W8fLvzC+IJg5SD1Ag5 AQrObYEtOn8CASRKs8ianV22Kf8X5DzDFXMh93HA2lbcImBnCcY2JQsZ6Sz5B8kyb7YbljCqAW615 sutSk=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1fzN3s-00023j-7F; Mon, 10 Sep 2018 14:21:08 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id EB4B51122D51; Mon, 10 Sep 2018 15:21:07 +0100 (BST) From: Mark Brown To: zhong jiang In-Reply-To: Message-Id: <20180910142107.EB4B51122D51@debutante.sirena.org.uk> Date: Mon, 10 Sep 2018 15:21:07 +0100 (BST) Cc: alsa-devel@alsa-project.org, Mark Brown Subject: [alsa-devel] Applied "ASoC: q6core: Use kmemdup to replace kzalloc + memcpy" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: q6core: Use kmemdup to replace kzalloc + memcpy has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 18fbe800e6066050ab6ae7751708da04975cdc22 Mon Sep 17 00:00:00 2001 From: zhong jiang Date: Sat, 8 Sep 2018 16:36:19 +0800 Subject: [PATCH] ASoC: q6core: Use kmemdup to replace kzalloc + memcpy kmemdup has implemented the function that kzalloc() + memcpy() will do. and we prefer to use the kmemdup rather than the open coded implementation. Signed-off-by: zhong jiang Signed-off-by: Mark Brown --- sound/soc/qcom/qdsp6/q6core.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) -- 2.19.0.rc1 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/qcom/qdsp6/q6core.c b/sound/soc/qcom/qdsp6/q6core.c index 06f03a5fe9bd..ca1be7305524 100644 --- a/sound/soc/qcom/qdsp6/q6core.c +++ b/sound/soc/qcom/qdsp6/q6core.c @@ -105,12 +105,10 @@ static int q6core_callback(struct apr_device *adev, struct apr_resp_pkt *data) bytes = sizeof(*fwk) + fwk->num_services * sizeof(fwk->svc_api_info[0]); - core->fwk_version = kzalloc(bytes, GFP_ATOMIC); + core->fwk_version = kmemdup(data->payload, bytes, GFP_ATOMIC); if (!core->fwk_version) return -ENOMEM; - memcpy(core->fwk_version, data->payload, bytes); - core->fwk_version_supported = true; core->resp_received = true; @@ -124,12 +122,10 @@ static int q6core_callback(struct apr_device *adev, struct apr_resp_pkt *data) len = sizeof(*v) + v->num_services * sizeof(v->svc_api_info[0]); - core->svc_version = kzalloc(len, GFP_ATOMIC); + core->svc_version = kmemdup(data->payload, len, GFP_ATOMIC); if (!core->svc_version) return -ENOMEM; - memcpy(core->svc_version, data->payload, len); - core->get_version_supported = true; core->resp_received = true;