From patchwork Mon Sep 10 14:21:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 146311 Delivered-To: patch@linaro.org Received: by 2002:a2e:1648:0:0:0:0:0 with SMTP id 8-v6csp2551262ljw; Mon, 10 Sep 2018 07:21:11 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYGI/g1VQJQpuykC/IZbSbJB/m942EDorInMawyDW0y4gaxRYlNGZ6pSvHaRlYsIhfUN4th X-Received: by 2002:a1c:de05:: with SMTP id v5-v6mr872848wmg.127.1536589271219; Mon, 10 Sep 2018 07:21:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536589271; cv=none; d=google.com; s=arc-20160816; b=RE+R69ZN/2n1EtS9P2DYCZSNIZ42lNZmTLIReV+QTFMCxuIqVTEYDNWVdgBA6C3lxc nMGgjwvk1KJ9lhPAJaAE8jHqRkq3T5dWLyL6jZPgME235b6PtUjdgN71WAeNwz+WgQ9y 1O8mkxWWeIC/g+JLeuUCE853golovd1as5ttYmHPdIaTfRYfX0YsYqwv1aeXnxaorTfd OSqMl3+UWJl+PPk3WadNh4CAyks0qwrgF6nWFaFFQdqjSDnP8di41vIca2at50/zGZpC dXtnrZ0GB7QlNfUSuWocWHDvvk7/i6jJx1HKSr/wL16CelQSeWxLOpyc3wWDW3oSq+dS 070g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to; bh=MRUMOyroTE1xeSK8aCIu2Wl728UOqPu4J+pJA6u1XPo=; b=AEuNwUouXYtNT7VjroDGyO+SVnalKV/wHMqA4WTq3wjHmbnRxvQ/SOgFn2BJIlb1cW kbp7Xo9sMO3Y+FSP3ePBvaxjxkTeKwkmsKyZyts6QWUspxgGMtJhsGFU9ZnSrPvIHDsi 0FRzslcwwyC2GmnYEX7mfLPaD7slXNbjP+uTs49vUuLqkekpHl8YIocht8axct7dNSdG cQmBTYanZPe0Z5Ho+eNaaBSmoyVI2t58chk1Z3OfwXR4Srh0GG87SdtgxLNh80Np9Lmj 9Mkvb+VHy4cc3mRQfK0g65aJAmX/uIUoHm4/cHZa2o+Pe2cMe2ebWqbsQ224Ud5vhzeo O4GA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=R908rJKE; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id u5-v6si16866159wrg.252.2018.09.10.07.21.10; Mon, 10 Sep 2018 07:21:11 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=R908rJKE; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id D3DA4267867; Mon, 10 Sep 2018 16:21:09 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id E0033267877; Mon, 10 Sep 2018 16:21:07 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id B8267267803 for ; Mon, 10 Sep 2018 16:21:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=s2wQDKebi8BtqMVmc6/P+JOMzWR8gWgs0X7vDmMSWW8=; b=R908rJKERys1 VngAXhFwoeYBPNRqXdEL7MjLMuG/mDCaJkGmmoJ/v0lIsLcXeiRR8vyrFyLUkINNEktnoka5np5hV 37unyRR83F0l3USf+7HCTrfUEV1vbVrboXgRYtlNZ7V1dygeg/R510YlMnsU5XbbvTzzdzOG7pmen gpm1U=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1fzN3m-00023d-R1; Mon, 10 Sep 2018 14:21:02 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id 94B651122D51; Mon, 10 Sep 2018 15:21:02 +0100 (BST) From: Mark Brown To: zhong jiang In-Reply-To: Message-Id: <20180910142102.94B651122D51@debutante.sirena.org.uk> Date: Mon, 10 Sep 2018 15:21:02 +0100 (BST) Cc: alsa-devel@alsa-project.org, Mark Brown Subject: [alsa-devel] Applied "ASoC: skl-topology: Use kmemdup to replace kzalloc + memcpy" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: skl-topology: Use kmemdup to replace kzalloc + memcpy has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From ca92cc4636fdedf0d7ee88a5e50cd2b85c246a3b Mon Sep 17 00:00:00 2001 From: zhong jiang Date: Sat, 8 Sep 2018 16:36:20 +0800 Subject: [PATCH] ASoC: skl-topology: Use kmemdup to replace kzalloc + memcpy kmemdup has implemented the function that kzalloc() + memcpy() will do. and we prefer to kmemdup rather than the open coded implementation. Signed-off-by: zhong jiang Signed-off-by: Mark Brown --- sound/soc/intel/skylake/skl-topology.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.19.0.rc1 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c index 2620d77729c5..52a9915da0f5 100644 --- a/sound/soc/intel/skylake/skl-topology.c +++ b/sound/soc/intel/skylake/skl-topology.c @@ -898,11 +898,10 @@ static int skl_tplg_set_module_bind_params(struct snd_soc_dapm_widget *w, bc = (struct skl_algo_data *)sb->dobj.private; if (bc->set_params == SKL_PARAM_BIND) { - params = kzalloc(bc->max, GFP_KERNEL); + params = kmemdup(bc->params, bc->max, GFP_KERNEL); if (!params) return -ENOMEM; - memcpy(params, bc->params, bc->max); skl_fill_sink_instance_id(ctx, params, bc->max, mconfig);