From patchwork Wed Sep 5 07:20:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "\(Exiting\) Baolin Wang" X-Patchwork-Id: 145975 Delivered-To: patch@linaro.org Received: by 2002:a2e:1648:0:0:0:0:0 with SMTP id 8-v6csp4596060ljw; Wed, 5 Sep 2018 00:20:26 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZxiovx9h+PSoG/hegYsTIQhhapuBt+1+33NpKRSEx46dAXsAAnfDU3PlCT+pS6REIZZwOP X-Received: by 2002:a63:706:: with SMTP id 6-v6mr34457365pgh.137.1536132026118; Wed, 05 Sep 2018 00:20:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536132026; cv=none; d=google.com; s=arc-20160816; b=sPGMiIEk2D2SMwv19qSlIW5q25/LfLhfMYhevg/QFN5DaCUZCceTZ7F3xwZDUJdcLA owKlPfxobBKuNreL++By0spvZlbgw/blPD2vjZ8M3pPGq65Mf5bzeKYgVIVrSrS8in5v yX97eha7mZ7vyjAdrVrEhd47+m2jd913Uel/HjuKHxq0n1FBGLKFmKGko/LsW5a4UOeO L8GX41DeqRgU0mo+7sDCxF181u+pYfHFGxThnjhZzXcFLrJgYhhI0aWUQQh1Y/IYb6pX l6VZ8GKAXSwmUBFKJfiS92acJ4AijNLYr6h/pIMHlD9FjagiWbXnxzO/8M1O+N+JXaYC M+TQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=MsZ65Y/Ek7k7XgCqpDuTbSQGCpDSNaqAmgZxLkIQWVA=; b=ijigKk4XqUktq/r2gPlsA+pg0cQ9SJ71Usev5Av8XbSIB2bXYmDrRki42vrbYawUPM KZKkDIogGh4v/O6yKUdXnXIDunhmRqdIQma1EJ1YcKkD4l8fBksbpUBGqcysN+y+xf1S AVXLlaDrojH5QNwX6/9JPbBbf7ACiYVrGuVZN5wBYnAR8/Np0FIAQkEDV2WDPer/XSWy yA+M0jvikHqwYCFLjqAvW5G5MUnRdztgVWZNwISYRVKYm8rqRGdp+G7rgBNA8IdLpWHt V+YVbScygYiOkhX6oOnCXnAxcw7ie/wjBa2Omd+lRlj6bEBTskYYM7W+KoPb2FUabsR6 K8Jw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZXMjmF41; spf=pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-leds-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 12-v6si1247265plb.203.2018.09.05.00.20.25; Wed, 05 Sep 2018 00:20:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZXMjmF41; spf=pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-leds-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726215AbeIELtO (ORCPT + 1 other); Wed, 5 Sep 2018 07:49:14 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:38286 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726342AbeIELtN (ORCPT ); Wed, 5 Sep 2018 07:49:13 -0400 Received: by mail-pg1-f196.google.com with SMTP id t84-v6so1123725pgb.5 for ; Wed, 05 Sep 2018 00:20:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=MsZ65Y/Ek7k7XgCqpDuTbSQGCpDSNaqAmgZxLkIQWVA=; b=ZXMjmF41pJI5mx40NVXPnERnOiAMhBPUbgTroE879rqWHza4vKoS1KVUnb4h2ZOBwz CjXW0rQm4RE1JBOZSvqkt9BYvC76JiMCfuNRR1RXh7Uz8ev4Stz2dx5J9C0YEJI1lgkD vMNyZhHe3kmfbkjuQdj7pS9/raAtE93RqATvw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=MsZ65Y/Ek7k7XgCqpDuTbSQGCpDSNaqAmgZxLkIQWVA=; b=l98JkI6PuifqROgDsKB23jN+kE8uPoymLanHq8Q/V2/AIaJ+fTlut/awPJtxcThFvF p4z1H2gvOHOvXffGJkUCpdKjHlYaxcDWgAqT1JkYsZhSwgoYmrb5nNFBFoY+/6W8249O ZQer+ZXRmiuGfvPl/LGMXgAXYmqMduiS8Aph+wl55RYkoAHqwJxr2d1EWvv8ocMdDAbl QereZT4oM/F33medQLFapHNRm4OV1DmoK5UCib7542wFim7o9iTLBIRZRepGu0757Aea 3t6msm5GW0VuoDPm347YJ+/rDgoguoaPyWShp3yQA6MdEuN9XIe5IDrd3Kb33VxCJyqk 0JeQ== X-Gm-Message-State: APzg51AB36kyEmWQs9nTOmLpcTak8+/g9l3CWBh/byQTemq/J5b1yh14 eyPNRuYviZxBgs2RBs9GNOKiUA== X-Received: by 2002:a62:384a:: with SMTP id f71-v6mr38799481pfa.48.1536132023762; Wed, 05 Sep 2018 00:20:23 -0700 (PDT) Received: from baolinwangubtpc.spreadtrum.com ([117.18.48.102]) by smtp.gmail.com with ESMTPSA id s85-v6sm1662755pfa.116.2018.09.05.00.20.20 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 05 Sep 2018 00:20:23 -0700 (PDT) From: Baolin Wang To: jacek.anaszewski@gmail.com, pavel@ucw.cz Cc: rteysseyre@gmail.com, bjorn.andersson@linaro.org, baolin.wang@linaro.org, broonie@kernel.org, linus.walleij@linaro.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v9 2/2] leds: sc27xx: Add pattern_set/clear interfaces for LED controller Date: Wed, 5 Sep 2018 15:20:00 +0800 Message-Id: X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <5a502ec29251c019ddad8f3314ab45fc0f6feaf7.1536131926.git.baolin.wang@linaro.org> References: <5a502ec29251c019ddad8f3314ab45fc0f6feaf7.1536131926.git.baolin.wang@linaro.org> Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org This patch implements the 'pattern_set'and 'pattern_clear' interfaces to support SC27XX LED breathing mode. Signed-off-by: Baolin Wang --- Changes from v8: - Optimize the ABI documentation file. Changes from v7: - Add its own ABI documentation file. Changes from v6: - None. Changes from v5: - None. Changes from v4: - None. Changes from v3: - None. Changes from v2: - None. Changes from v1: - Remove pattern_get interface. --- .../ABI/testing/sysfs-class-led-driver-sc27xx | 20 +++++ drivers/leds/leds-sc27xx-bltc.c | 93 ++++++++++++++++++++ 2 files changed, 113 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-class-led-driver-sc27xx -- 1.7.9.5 diff --git a/Documentation/ABI/testing/sysfs-class-led-driver-sc27xx b/Documentation/ABI/testing/sysfs-class-led-driver-sc27xx new file mode 100644 index 0000000..391ca6e --- /dev/null +++ b/Documentation/ABI/testing/sysfs-class-led-driver-sc27xx @@ -0,0 +1,20 @@ +What: /sys/class/leds//hw_pattern +Date: September 2018 +KernelVersion: 4.20 +Description: + Specify a hardware pattern for the SC27XX LED. For the SC27XX + LED controller, it only supports 4 stages to make a single + hardware pattern, which is used to configure the rise time, + high time, fall time and low time for the breathing mode. + + For the breathing mode, the SC27XX LED only expects one brightness + for the high stage. To be compatible with the hardware pattern + format, we should set brightness as 0 for rise stage, fall + stage and low stage. + + Min stage duration: 1 + Max stage duration: 255 + Stage duration step: 125 ms + + Thus the format of the hardware pattern values should be: + "0 rise_duration brightness high_duration 0 fall_duration 0 low_duration". diff --git a/drivers/leds/leds-sc27xx-bltc.c b/drivers/leds/leds-sc27xx-bltc.c index 9d9b7aa..bff2f8f 100644 --- a/drivers/leds/leds-sc27xx-bltc.c +++ b/drivers/leds/leds-sc27xx-bltc.c @@ -32,8 +32,13 @@ #define SC27XX_DUTY_MASK GENMASK(15, 0) #define SC27XX_MOD_MASK GENMASK(7, 0) +#define SC27XX_CURVE_SHIFT 8 +#define SC27XX_CURVE_L_MASK GENMASK(7, 0) +#define SC27XX_CURVE_H_MASK GENMASK(15, 8) + #define SC27XX_LEDS_OFFSET 0x10 #define SC27XX_LEDS_MAX 3 +#define SC27XX_LEDS_PATTERN_CNT 4 struct sc27xx_led { char name[LED_MAX_NAME_SIZE]; @@ -122,6 +127,90 @@ static int sc27xx_led_set(struct led_classdev *ldev, enum led_brightness value) return err; } +static int sc27xx_led_pattern_clear(struct led_classdev *ldev) +{ + struct sc27xx_led *leds = to_sc27xx_led(ldev); + struct regmap *regmap = leds->priv->regmap; + u32 base = sc27xx_led_get_offset(leds); + u32 ctrl_base = leds->priv->base + SC27XX_LEDS_CTRL; + u8 ctrl_shift = SC27XX_CTRL_SHIFT * leds->line; + int err; + + mutex_lock(&leds->priv->lock); + + /* Reset the rise, high, fall and low time to zero. */ + regmap_write(regmap, base + SC27XX_LEDS_CURVE0, 0); + regmap_write(regmap, base + SC27XX_LEDS_CURVE1, 0); + + err = regmap_update_bits(regmap, ctrl_base, + (SC27XX_LED_RUN | SC27XX_LED_TYPE) << ctrl_shift, 0); + + mutex_unlock(&leds->priv->lock); + + return err; +} + +static int sc27xx_led_pattern_set(struct led_classdev *ldev, + struct led_pattern *pattern, + int len, u32 repeat) +{ + struct sc27xx_led *leds = to_sc27xx_led(ldev); + u32 base = sc27xx_led_get_offset(leds); + u32 ctrl_base = leds->priv->base + SC27XX_LEDS_CTRL; + u8 ctrl_shift = SC27XX_CTRL_SHIFT * leds->line; + struct regmap *regmap = leds->priv->regmap; + int err; + + /* + * Must contain 4 patterns to configure the rise time, high time, fall + * time and low time to enable the breathing mode. + */ + if (len != SC27XX_LEDS_PATTERN_CNT) + return -EINVAL; + + mutex_lock(&leds->priv->lock); + + err = regmap_update_bits(regmap, base + SC27XX_LEDS_CURVE0, + SC27XX_CURVE_L_MASK, pattern[0].delta_t); + if (err) + goto out; + + err = regmap_update_bits(regmap, base + SC27XX_LEDS_CURVE1, + SC27XX_CURVE_L_MASK, pattern[1].delta_t); + if (err) + goto out; + + err = regmap_update_bits(regmap, base + SC27XX_LEDS_CURVE0, + SC27XX_CURVE_H_MASK, + pattern[2].delta_t << SC27XX_CURVE_SHIFT); + if (err) + goto out; + + + err = regmap_update_bits(regmap, base + SC27XX_LEDS_CURVE1, + SC27XX_CURVE_H_MASK, + pattern[3].delta_t << SC27XX_CURVE_SHIFT); + if (err) + goto out; + + err = regmap_update_bits(regmap, base + SC27XX_LEDS_DUTY, + SC27XX_DUTY_MASK, + (pattern[1].brightness << SC27XX_DUTY_SHIFT) | + SC27XX_MOD_MASK); + if (err) + goto out; + + /* Enable the LED breathing mode */ + err = regmap_update_bits(regmap, ctrl_base, + SC27XX_LED_RUN << ctrl_shift, + SC27XX_LED_RUN << ctrl_shift); + +out: + mutex_unlock(&leds->priv->lock); + + return err; +} + static int sc27xx_led_register(struct device *dev, struct sc27xx_led_priv *priv) { int i, err; @@ -140,6 +229,9 @@ static int sc27xx_led_register(struct device *dev, struct sc27xx_led_priv *priv) led->priv = priv; led->ldev.name = led->name; led->ldev.brightness_set_blocking = sc27xx_led_set; + led->ldev.pattern_set = sc27xx_led_pattern_set; + led->ldev.pattern_clear = sc27xx_led_pattern_clear; + led->ldev.default_trigger = "pattern"; err = devm_led_classdev_register(dev, &led->ldev); if (err) @@ -241,4 +333,5 @@ static int sc27xx_led_remove(struct platform_device *pdev) MODULE_DESCRIPTION("Spreadtrum SC27xx breathing light controller driver"); MODULE_AUTHOR("Xiaotong Lu "); +MODULE_AUTHOR("Baolin Wang "); MODULE_LICENSE("GPL v2");