From patchwork Fri Jul 16 10:36:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 479393 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E31BC12002 for ; Fri, 16 Jul 2021 10:37:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 860BD613D0 for ; Fri, 16 Jul 2021 10:37:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238809AbhGPKkj (ORCPT ); Fri, 16 Jul 2021 06:40:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237344AbhGPKki (ORCPT ); Fri, 16 Jul 2021 06:40:38 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C79AC06175F; Fri, 16 Jul 2021 03:37:44 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id b2so555800plx.1; Fri, 16 Jul 2021 03:37:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NOqh4iRv8bzMC1v4LkBjVvsD8Lkl7UjXzwLeX3pJkx8=; b=S+HZDh+6imXk19NG3CPuTcEbgILrztpxAmUk0TtpzjM7XS0iHTzqBM1cQOM86udfnW YeMeFqO9KZmtln4zin0hp9YkejLcs0SxhITpg4a3lIu6To685WU/rrTvBIim4KfQCkFR GUVr3WzXiAHTjcGdTAKs9yc4eQsKZXme4S2zeaz7xqfsY0uxtS38PhMRHqZIwscoNYvI ULNGGcNtKRcdm8tONmPoXIsduyt8h8z5mrX3HpT4LPtWKpmXSoQFTUKZqYQuw2E1GKjf ZHXqcGycinnFF+I/xUJfzpZwkXkxRJZlGZWsT9R2ba69iBc5vsNrsN2pJkn/AC5Lb6Qv h0Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NOqh4iRv8bzMC1v4LkBjVvsD8Lkl7UjXzwLeX3pJkx8=; b=bFg4f3GAjT7zEgpgYghxXw7u6McWvJeWNgz5CZPwfaTk5Eb5L47j+PX6OOz583oeGM eIE/0oZM7Koxo4+7fkeCmzH7We4wCo4eCUWosYIVllBptWp0BNn5IB/MqQHIavtSBSFX OkK1IRChu6jv7ZqRUs3rpmCct/pU86BvTi6YdfpYUm2JVvHzh65KLQVGqdI4shyXeTwm C75J2aU/dQiLt7ElhfEFtJZyug02lRm4Gq5aPtv3qz+sFFecZATW482u92+x+ZRnMBb/ Kftf1JEQptitndxDSFapiFe//ObqAPrNYJjX2zBUN/1oN5gg3LfUC6jWjHN7KbWcCrm0 pAVg== X-Gm-Message-State: AOAM530r/Xbi4Embz8eYTcxadEqSUtB0smpOXa0vtv5cMPz0Qxjl79rg j6ij5VV8YnQmtNndqtfgqiE= X-Google-Smtp-Source: ABdhPJzH+ZY1CMrp9Is4HwQkAVX+28YqBZJDdwXI/77fszRGkHSp3wSrVmA55QJTPYuYukJ2ugUzUA== X-Received: by 2002:a17:90a:658c:: with SMTP id k12mr14765303pjj.167.1626431863792; Fri, 16 Jul 2021 03:37:43 -0700 (PDT) Received: from archl-c2lm.. ([103.51.72.31]) by smtp.gmail.com with ESMTPSA id d29sm10070111pfq.193.2021.07.16.03.37.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jul 2021 03:37:43 -0700 (PDT) From: Anand Moon To: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Anand Moon , Matt Corallo , Martin Blumenstingl , Rob Herring , Neil Armstrong , Kevin Hilman , Jerome Brunet , Kishon Vijay Abraham I , Vinod Koul , Emiliano Ingrassia , Brian Kim , devicetree@vger.kernel.org Subject: [PATCHv2 1/4] ARM: dts: meson8b: odroidc1: Add usb phy power node Date: Fri, 16 Jul 2021 10:36:33 +0000 Message-Id: <20210716103651.1455-2-linux.amoon@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210716103651.1455-1-linux.amoon@gmail.com> References: <20210716103651.1455-1-linux.amoon@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Add missing usb phy power node for phy mode fix below warning. P5V0 regulator suppy input voltage range to USB host controller. As descriped in the C1+ schematics, GPIO GPIOAO_5 is used to enable input power to USB ports, set it to Active Low. [ 1.253149] phy phy-c1108820.phy.0: Looking up phy-supply from device tree [ 1.253166] phy phy-c1108820.phy.0: Looking up phy-supply property in node /soc/cbus@c1100000/phy@8820 failed Fixes: 2eb79a4d15ff (ARM: dts: meson: enabling the USB Host controller on Odroid-C1/C1+ board) Cc: Martin Blumenstingl Signed-off-by: Anand Moon --- V1 > Fix the Input GPIO polarity from HIGH to LOW. previous version [0] https://patchwork.kernel.org/project/linux-amlogic/patch/20190113181808.5768-1-linux.amoon@gmail.com changes fix the vbus-suppy to phy-supply, drop enable usb0 USB_PWR 2 1 0 unknown 5000mV 0mA 5000mV 5000mV phy-c1108820.phy.0-phy 2 0mA 0mV 0mV --- arch/arm/boot/dts/meson8b-odroidc1.dts | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts index c440ef94e082..26e8f91e0950 100644 --- a/arch/arm/boot/dts/meson8b-odroidc1.dts +++ b/arch/arm/boot/dts/meson8b-odroidc1.dts @@ -32,6 +32,24 @@ emmc_pwrseq: emmc-pwrseq { reset-gpios = <&gpio BOOT_9 GPIO_ACTIVE_LOW>; }; + usb_pwr_en: regulator-usb-pwr-en { + compatible = "regulator-fixed"; + + regulator-name = "USB_PWR"; + + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + /* + * signal name from schematics: USB_POWER - P5V0 + */ + vin-supply = <&p5v0>; + + /* + * signal name from schematics: PWREN - GPIOAO.BIT5 + */ + gpios = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_HIGH>; + }; + leds { compatible = "gpio-leds"; blue { @@ -378,6 +396,7 @@ &uart_AO { &usb1_phy { status = "okay"; + phy-supply = <&usb_pwr_en>; }; &usb1 { From patchwork Fri Jul 16 10:36:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 478532 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E1DFC07E95 for ; Fri, 16 Jul 2021 10:38:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7213A613FA for ; Fri, 16 Jul 2021 10:38:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239113AbhGPKk6 (ORCPT ); Fri, 16 Jul 2021 06:40:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237344AbhGPKk5 (ORCPT ); Fri, 16 Jul 2021 06:40:57 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40F5CC06175F; Fri, 16 Jul 2021 03:38:03 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id c1so4753089pfc.13; Fri, 16 Jul 2021 03:38:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VmmdmkhCXO7AkJW07YrDSJja8AB+CMGTjyDZ72pZ3SM=; b=XLSE0l9iqM0FUsdbXgwyYeUrxZueBS2H6c7hqHRL9yloc2KjuRPsCFY3K0pJgN92Jl I9S81ExFA/RPQv40q29hoSSelFqrR9ivp1lUaAz/6Stwhu6zR8137DTnjOpD6NalZNyi tNm1WWPQbRBc7D6YJMSnmh8zapD4oxafFu7J2Bq2kMnAU8Ofu+WjuhZD+U8vs9Pv4ELL LaLf79ZEbZ5A/kLT0Jppqmff93zKY4Ku32+2+IZ0XR3Mpg9T7xqtH+0buG0S2xibGBaa zGQ+f0bd9lIJ5JmAcZpotR+I+V6rUUJKdn35klF80vjgtPpiDymMNs9A9u6abhyRMZLw Jz9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VmmdmkhCXO7AkJW07YrDSJja8AB+CMGTjyDZ72pZ3SM=; b=ChMCLmEqv7r2YEkgNqKob8KUaT/hH4VpeufHaxijpujwTQXlzk70LtA5T4JzApMHVs zcsWGrV45etcaPF2vuWMUjVtze1zEWIw5z0hSsQQ/ow7DSK+y4letRpRszu4zu0PLYxz XjYwzdGe6wb2Gs6SAtQADyXD7xXW2jFcGgqwvXEYvW494iMJZjT52gmrs7hxMtl91wIT 7E4sTSQH56ywolwc7FpZNspYEB6kkutiFiytkkrcCC1uWexkKNHPUD4fsZ7juCgFCkhW I6uWIZatqRfAH35Rq93sRuI0SMSDNp1TfDgwas+fFxnOhX1dZFUZDW6hNeVhFX/bcfnU r42g== X-Gm-Message-State: AOAM530lmsXOBF/vZZu+SBiz8aZbwybCqtYaINOXrh3We2+bBQ6IlaeG lgpOo1mAsDt3Hc4/Vxz5xn4= X-Google-Smtp-Source: ABdhPJwcfKzs6LufNBOvTwQDhzOMXdnw2fdKAY5SkFQfRpvVwVTYBM5CiUo9KwmAaTJF9L0qBS4k9Q== X-Received: by 2002:a05:6a00:2:b029:32e:3ef0:770a with SMTP id h2-20020a056a000002b029032e3ef0770amr9954297pfk.8.1626431882813; Fri, 16 Jul 2021 03:38:02 -0700 (PDT) Received: from archl-c2lm.. ([103.51.72.31]) by smtp.gmail.com with ESMTPSA id d29sm10070111pfq.193.2021.07.16.03.37.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jul 2021 03:38:02 -0700 (PDT) From: Anand Moon To: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Anand Moon , Matt Corallo , Martin Blumenstingl , Rob Herring , Neil Armstrong , Kevin Hilman , Jerome Brunet , Kishon Vijay Abraham I , Vinod Koul , Emiliano Ingrassia , Brian Kim , devicetree@vger.kernel.org Subject: [PATCHv2 2/4] arm64: dts: amlogic: odroidc2: Fix the chip enable signal for usb power Date: Fri, 16 Jul 2021 10:36:34 +0000 Message-Id: <20210716103651.1455-3-linux.amoon@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210716103651.1455-1-linux.amoon@gmail.com> References: <20210716103651.1455-1-linux.amoon@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Fix the chip enable signal changing from Active High to Active Low to enable input power to USB power. Also updated signal name as per the shematics. Fixes: 5a0803bd5ae2 ("ARM64: dts: meson-gxbb-odroidc2: Enable USB Nodes") Cc: Martin Blumenstingl Signed-off-by: Anand Moon --- New patch in this series --- arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts index 201596247fd9..3f4f16a5dedd 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts @@ -38,12 +38,11 @@ usb_otg_pwr: regulator-usb-pwrs { regulator-max-microvolt = <5000000>; /* - * signal name from schematics: PWREN + * signal name from schematics: PWREN - GPIOAO.BIT5 */ - gpio = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_HIGH>; - enable-active-high; + gpios = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_LOW>; /* - * signal name from schematics: USB_POWER + * signal name from schematics: USB_POWER - P5V0 */ vin-supply = <&p5v0>; }; From patchwork Fri Jul 16 10:36:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 479392 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB3DAC12002 for ; Fri, 16 Jul 2021 10:38:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 94AAE613F7 for ; Fri, 16 Jul 2021 10:38:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239301AbhGPKlS (ORCPT ); Fri, 16 Jul 2021 06:41:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237344AbhGPKlR (ORCPT ); Fri, 16 Jul 2021 06:41:17 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63FBDC06175F; Fri, 16 Jul 2021 03:38:22 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id b12so8580231pfv.6; Fri, 16 Jul 2021 03:38:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ijibuOn1o/zyXxVK7//BA8fe5lpTivScoHePVnxddFU=; b=Qf9SOx6QD4X/slJCbBN3lWyDjpm8rnJYlFnSC/XJk+r2LL92hc6zo+WOtnP91fFVP9 tBS4WjcJvji4dkub0v6NU6k/wBh9Cz1PvNCFuH0oHzKURPH9YDtjlVPtskhmeYbMTej1 WuohWqOG/YtBzDZ3TZqFHj7G8FRZ23T682i3tQ3v1OCnl/E2ttkFVxvaipcM16pADatb dvdawIST8n+R8jieSnYb0y9oCqZUgwthwXXuEQnnF9nKqtfeSWdihPHE815Dfmrn8Pnv noafRwT/Ncmk3Ct4XeXxNL+ONmErwWKEEqs4a/TxDBib2LoSjDIWnCG4pRXMRbPWJVFU QDpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ijibuOn1o/zyXxVK7//BA8fe5lpTivScoHePVnxddFU=; b=soAC5wqo70dtM+nNzmelH9fw/ZtwObsY0zjtFEUTilT+S11j98MaLK+xkMpf3unyYd jua8t6qEpzdV2eGLYgBUO3xbTKhJAm2g3rdQioTa/lTnu/+9/0s/xjy9GQFUKg2SR77c ZXkODjzyRbfew2deBH7TekyHCwyC+682qd5QwpjqDtAbfOIs1DvcSyosOpip1wHyRq/9 7xx4H+zKBb4W4k0vYBt0fmExJQrRAQLa9osGI3+hN0Du1ytDU7oosUON7XlRPUR0mlQv zNqBMb/Ws3kCvQ8IY5sfIjEJOqamu86/Vgcvu7gndR2EjLlLjaatENRj1QMe5TPEiA6S Nz9Q== X-Gm-Message-State: AOAM533z+/BXjsL/x+Qj2KSUqB0G4fIJFcv09soVEIwWTl/Ohwp22JXL bLC9KTGB8RKux++fv/rTuVs= X-Google-Smtp-Source: ABdhPJwzFIVx2DLzzS7/EOrIoZqSrUxxZHYoV9gOL39E9P3TfTI27j0dDyl6BT242VupYDs0781MUQ== X-Received: by 2002:a05:6a00:7d7:b029:32c:b12a:d65d with SMTP id n23-20020a056a0007d7b029032cb12ad65dmr9602132pfu.44.1626431902028; Fri, 16 Jul 2021 03:38:22 -0700 (PDT) Received: from archl-c2lm.. ([103.51.72.31]) by smtp.gmail.com with ESMTPSA id d29sm10070111pfq.193.2021.07.16.03.38.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jul 2021 03:38:21 -0700 (PDT) From: Anand Moon To: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Anand Moon , Matt Corallo , Martin Blumenstingl , Rob Herring , Neil Armstrong , Kevin Hilman , Jerome Brunet , Kishon Vijay Abraham I , Vinod Koul , Emiliano Ingrassia , Brian Kim , devicetree@vger.kernel.org Subject: [PATCHv2 3/4] phy: amlogic: meson8b-usb2: Power off the PHY by putting it into reset mode Date: Fri, 16 Jul 2021 10:36:35 +0000 Message-Id: <20210716103651.1455-4-linux.amoon@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210716103651.1455-1-linux.amoon@gmail.com> References: <20210716103651.1455-1-linux.amoon@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Power off the PHY by putting it into reset mode. Cc: Martin Blumenstingl Acked-by: Martin Blumenstingl Signed-off-by: Anand Moon --- None: Added Martin's Ack --- drivers/phy/amlogic/phy-meson8b-usb2.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/phy/amlogic/phy-meson8b-usb2.c b/drivers/phy/amlogic/phy-meson8b-usb2.c index 03c061dd5f0d..2aad45c55494 100644 --- a/drivers/phy/amlogic/phy-meson8b-usb2.c +++ b/drivers/phy/amlogic/phy-meson8b-usb2.c @@ -219,6 +219,10 @@ static int phy_meson8b_usb2_power_off(struct phy *phy) clk_disable_unprepare(priv->clk_usb); clk_disable_unprepare(priv->clk_usb_general); + /* power off the PHY by putting it into reset mode */ + regmap_update_bits(priv->regmap, REG_CTRL, REG_CTRL_POWER_ON_RESET, + REG_CTRL_POWER_ON_RESET); + return 0; } From patchwork Fri Jul 16 10:36:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 478531 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10730C12002 for ; Fri, 16 Jul 2021 10:38:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E57E4613FE for ; Fri, 16 Jul 2021 10:38:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238646AbhGPKli (ORCPT ); Fri, 16 Jul 2021 06:41:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237344AbhGPKlh (ORCPT ); Fri, 16 Jul 2021 06:41:37 -0400 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D72EEC06175F; Fri, 16 Jul 2021 03:38:41 -0700 (PDT) Received: by mail-pg1-x52a.google.com with SMTP id h4so9544860pgp.5; Fri, 16 Jul 2021 03:38:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=w3d3QBhIUG9rULiQkPjmvB3VFugYPgFTgKGsQs/0OIs=; b=edMHLZZ9Joy3kORNlbb3fA7Oip6TpGrlESLPRoP4j3s+sAQLT1SlBoA6nDewPTbeVZ adOYB6al4mrObEuWESAJ8eKqdNEMX2eOcU/YxWBmqhLKf3xbN45sNRIeZKrAtBqyiz9f nX3dORJt+ID97uW4aq30eSU7zpLvGnWqQQDutpcN7gU5/m6ZvhDGcnZwvjjaNnqkhHWH TaAulTOhfwFITR/T+aDhl6mwTAAaYhoKE8723LObUi/eM/LbPvenJ3bIctfUxk92bowR BJ6DACx3dWU2weZVjdGuyk0HaB1noOWHalBTdjC8xkh7RLFCqkc388tyQMAjAHw2k4PS KfJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=w3d3QBhIUG9rULiQkPjmvB3VFugYPgFTgKGsQs/0OIs=; b=OLVm83A9+OQsMCEHdXVkBmJIBLJLQQeqDFdJVxkJwrPk9ic8T8fdKk6GhfDIpyB0g+ dQKnWABHzh33RyBdsFi3vGd7CmLHqGYL7KsUSCm7B1gJ8+Cui09vDRH3bBgZPyaAjPN7 i14lzqiPU2WEKtADmEIXNPLJJzwsy0+dKQ1iJ3Qq2XRLLe3/q33jIoOqy3Ccb4tq6ug8 3GtYHbp4SELIk7gf+tfkwdkdEbTJvRFMmigiQLaGEPfVkYeasC5Jipt1EfpwTFj9wGsK E4T6JIYyKDEXfMldqozymZkeZGOqnc7TZc9FZL9NHxTTzLai30Jt62TyhjfBZQloLHdk NeZg== X-Gm-Message-State: AOAM532A9xsgA9eRBXbkLU5Xs6pdUfPFqiY93VcRAnebjydoLO6dkbIy iZ5q3hyHeKVnra+6CVkMzIM= X-Google-Smtp-Source: ABdhPJzRs9l6a/USkfsyP9AF6K5QWyN3b48FxjpiD1pQ49VAVuin34TLdB+q2UIjut4p6GMWd5n0vw== X-Received: by 2002:aa7:97bd:0:b029:32c:56cc:8fa9 with SMTP id d29-20020aa797bd0000b029032c56cc8fa9mr9677013pfq.65.1626431921511; Fri, 16 Jul 2021 03:38:41 -0700 (PDT) Received: from archl-c2lm.. ([103.51.72.31]) by smtp.gmail.com with ESMTPSA id d29sm10070111pfq.193.2021.07.16.03.38.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jul 2021 03:38:41 -0700 (PDT) From: Anand Moon To: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Anand Moon , Matt Corallo , Martin Blumenstingl , Rob Herring , Neil Armstrong , Kevin Hilman , Jerome Brunet , Kishon Vijay Abraham I , Vinod Koul , Emiliano Ingrassia , Brian Kim , devicetree@vger.kernel.org Subject: [PATCHv2 4/4] phy: amlogic: meson8b-usb2: don't log an error on -EPROBE_DEFER Date: Fri, 16 Jul 2021 10:36:36 +0000 Message-Id: <20210716103651.1455-5-linux.amoon@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210716103651.1455-1-linux.amoon@gmail.com> References: <20210716103651.1455-1-linux.amoon@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org devm_phy_create can return -EPROBE_DEFER if the phy-supply is not ready yet. Silence this warning as the driver framework will re-attempt registering the PHY. Use dev_err_probe() for phy resources to indicate the deferral reason when waiting for the resource to come up. Cc: Martin Blumenstingl Reviewed-by: Martin Blumenstingl Signed-off-by: Anand Moon --- None: --- drivers/phy/amlogic/phy-meson8b-usb2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/phy/amlogic/phy-meson8b-usb2.c b/drivers/phy/amlogic/phy-meson8b-usb2.c index 2aad45c55494..cf10bed40528 100644 --- a/drivers/phy/amlogic/phy-meson8b-usb2.c +++ b/drivers/phy/amlogic/phy-meson8b-usb2.c @@ -277,8 +277,8 @@ static int phy_meson8b_usb2_probe(struct platform_device *pdev) phy = devm_phy_create(&pdev->dev, NULL, &phy_meson8b_usb2_ops); if (IS_ERR(phy)) { - dev_err(&pdev->dev, "failed to create PHY\n"); - return PTR_ERR(phy); + return dev_err_probe(&pdev->dev, PTR_ERR(phy), + "failed to create PHY\n"); } phy_set_drvdata(phy, priv);