From patchwork Tue Jul 13 07:39:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kepplinger X-Patchwork-Id: 475042 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1A96C07E95 for ; Tue, 13 Jul 2021 07:40:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89F3561040 for ; Tue, 13 Jul 2021 07:40:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234202AbhGMHnQ (ORCPT ); Tue, 13 Jul 2021 03:43:16 -0400 Received: from comms.puri.sm ([159.203.221.185]:51572 "EHLO comms.puri.sm" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233762AbhGMHnQ (ORCPT ); Tue, 13 Jul 2021 03:43:16 -0400 Received: from localhost (localhost [127.0.0.1]) by comms.puri.sm (Postfix) with ESMTP id E6D8AE0494; Tue, 13 Jul 2021 00:39:56 -0700 (PDT) Received: from comms.puri.sm ([127.0.0.1]) by localhost (comms.puri.sm [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7ofEuaigVpKE; Tue, 13 Jul 2021 00:39:56 -0700 (PDT) From: Martin Kepplinger To: heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org Cc: grandmaster@al2klimov.de, kernel@puri.sm, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Martin Kepplinger Subject: [PATCH] usb: typec: tipd: Don't block probing of consumer of "connector" nodes Date: Tue, 13 Jul 2021 09:39:46 +0200 Message-Id: <20210713073946.102501-1-martin.kepplinger@puri.sm> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Similar as with tcpm this patch lets fw_devlink know not to wait on the fwnode to be populated as a struct device. Without this patch, USB functionality can be broken on some previously supported boards. Fixes: 28ec344bb891 ("usb: typec: tcpm: Don't block probing of consumers of "connector" nodes") Signed-off-by: Martin Kepplinger --- hi, at least the boards based on imx8mq-librem5.dtsi suffer from this, possibly more. thanks, martin drivers/usb/typec/tipd/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c index 938219bc1b4b..b31aaf57eb3b 100644 --- a/drivers/usb/typec/tipd/core.c +++ b/drivers/usb/typec/tipd/core.c @@ -629,6 +629,8 @@ static int tps6598x_probe(struct i2c_client *client) if (!fwnode) return -ENODEV; + fw_devlink_purge_absent_suppliers(fwnode); + tps->role_sw = fwnode_usb_role_switch_get(fwnode); if (IS_ERR(tps->role_sw)) { ret = PTR_ERR(tps->role_sw);