From patchwork Tue Jul 13 05:52:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 477065 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1653DC07E96 for ; Tue, 13 Jul 2021 05:53:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EEED661288 for ; Tue, 13 Jul 2021 05:53:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233251AbhGMFzy (ORCPT ); Tue, 13 Jul 2021 01:55:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233147AbhGMFzx (ORCPT ); Tue, 13 Jul 2021 01:55:53 -0400 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82836C0613DD; Mon, 12 Jul 2021 22:53:03 -0700 (PDT) Received: by mail-pl1-x635.google.com with SMTP id p17so9990744plf.12; Mon, 12 Jul 2021 22:53:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Lmng85Px0u83llASk+gk5rLgTOQ6j6LNMSKSt4jMIeI=; b=HM9+khwIbE9awn14IA/b6gDroV2+LORNN7AdsQSFBtmzJ22vchCVTor7Jw2ieUqR9Z HXFmq/Rq5fMRiGYFCf4pRBfU6GnzpboUCVozgRPqug0OJBYenXciDngP48dxjYL05+RF ZAXdtqxbz+Ur2j0VmB5sU1MXhOWgL7cyF9fg6VB8EQIuA5Cz7thVWLDs4nKYzLANITrI jcR7MrbGlMEy+jGCCMCcWgTKF9Q5euNBpoupzwd8Vcf82NyIg6L1ICWaM02+QX4FrkyF ij5SUNIQU5gYrFNOjGWveoYWsp8lBtUH0iUwBGs4Ek0Xkm8ChFM5y4+jQF3s6PhEhCYZ RDkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Lmng85Px0u83llASk+gk5rLgTOQ6j6LNMSKSt4jMIeI=; b=azRhBJQngoVhHbIDhZacr0Ga284AqZzJ7LZFXQmxv/H6uTgSSHIR1WWQF4Xz4QaQgv eT/wOm+/nU7S3C6MLH7uidUCZEaNg4cI4tdZfuMvClOExFPlVu8zVIJQ/W282y9LSPEy zHZa4vFJjNQBNPixe+EnxTU1RoCrei01M4Qo5MrMDV+rKckhswd6prO98mS4Afj8gxbq G6LJl9OBApqz1xB/DHtpQsD8ttd9L3SGZDi12s9X/S6xk5ZT9kPzV3Ygb+QcvnLhgbQP TxKuSwE/tWWwrXzyaVdXc9ChX2DwCpgAQxAIws2edJ0dR36Grs0HkGF8uWe9VKRS88uQ 9qiA== X-Gm-Message-State: AOAM530x42pocBitWvKbvO4pjd2Y+P9GhtMIj0CJ6JOmUmzBphTPL+Hs 71IkhqCrg/LWVJCTOInjKf2Y3uM8HOI= X-Google-Smtp-Source: ABdhPJwTq9nwszpBMHHsyvcPH3Z+S8RDoz5Pl7U1c/xalzChkAACyz7SaZKkAeJe60mg+uGUG5V/uQ== X-Received: by 2002:a17:90a:cd01:: with SMTP id d1mr17784189pju.106.1626155583078; Mon, 12 Jul 2021 22:53:03 -0700 (PDT) Received: from archl-c2lm.. ([103.51.72.31]) by smtp.gmail.com with ESMTPSA id x19sm17755198pfa.104.2021.07.12.22.52.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jul 2021 22:53:02 -0700 (PDT) From: Anand Moon To: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Anand Moon , Matt Corallo , Martin Blumenstingl , Rob Herring , Neil Armstrong , Kevin Hilman , Jerome Brunet , Kishon Vijay Abraham I , Vinod Koul , Emiliano Ingrassia , devicetree@vger.kernel.org Subject: [PATCHv1 1/3] ARM: dts: meson8b: odroidc1: Add usb phy power node Date: Tue, 13 Jul 2021 05:52:13 +0000 Message-Id: <20210713055227.1142-2-linux.amoon@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210713055227.1142-1-linux.amoon@gmail.com> References: <20210713055227.1142-1-linux.amoon@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Add missing usb phy power node for phy mode fix below warning. [ 1.253149] phy phy-c1108820.phy.0: Looking up phy-supply from device tree [ 1.253166] phy phy-c1108820.phy.0: Looking up phy-supply property in node /soc/cbus@c1100000/phy@8820 failed Fixes: 2eb79a4d15ff (ARM: dts: meson: enabling the USB Host controller on Odroid-C1/C1+ board) Cc: Martin Blumenstingl Signed-off-by: Anand Moon --- previous version [0] https://patchwork.kernel.org/project/linux-amlogic/patch/20190113181808.5768-1-linux.amoon@gmail.com changes fix the vbus-suppy to phy-supply, drop enable usb0 # sudo cat /sys/kernel/debug/regulator/regulator_summary USB_PWR 2 1 0 unknown 5000mV 0mA 5000mV 5000mV phy-c1108820.phy.0-phy 2 0mA 0mV 0mV --- arch/arm/boot/dts/meson8b-odroidc1.dts | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts index c440ef94e082..ced1ec1c4878 100644 --- a/arch/arm/boot/dts/meson8b-odroidc1.dts +++ b/arch/arm/boot/dts/meson8b-odroidc1.dts @@ -32,6 +32,25 @@ emmc_pwrseq: emmc-pwrseq { reset-gpios = <&gpio BOOT_9 GPIO_ACTIVE_LOW>; }; + usb_pwr_en: regulator-usb-pwr-en { + compatible = "regulator-fixed"; + + regulator-name = "USB_PWR"; + + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + /* + * signal name from schematics: USB_POWER + */ + vin-supply = <&p5v0>; + + /* + * signal name from schematics: PWREN + */ + gpio = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_HIGH>; + enable-active-high; + }; + leds { compatible = "gpio-leds"; blue { @@ -378,6 +397,7 @@ &uart_AO { &usb1_phy { status = "okay"; + phy-supply = <&usb_pwr_en>; }; &usb1 { From patchwork Tue Jul 13 05:52:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 474832 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B9A4C07E95 for ; Tue, 13 Jul 2021 05:53:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 133B26100C for ; Tue, 13 Jul 2021 05:53:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233312AbhGMF4K (ORCPT ); Tue, 13 Jul 2021 01:56:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233147AbhGMF4K (ORCPT ); Tue, 13 Jul 2021 01:56:10 -0400 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D457C0613DD; Mon, 12 Jul 2021 22:53:20 -0700 (PDT) Received: by mail-pf1-x434.google.com with SMTP id 17so18577593pfz.4; Mon, 12 Jul 2021 22:53:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Apgi9n+xzAXbVBKSBVdWWRXmCTfXVngS5mFHrsICTMs=; b=B3ioeD3woNIR4eb4hYTJ1NhFODGfBWkLQ9pbW53Ntmb0NMuamJ68xfCoZup2ihwriq wDTdzx1v3MTl+aAOIs/ekQHiM/aKejL/nxL3x8BJdgipqgLE3wFo2YPg7ldQwfZea4Bh 3dsNR7dD8JwY6QQ2KB7P8/RzBAAwf8aHWGHO0/clNBOfbGfL4AmVcKQUN807hxODN6gB EUucJO5xCUoV6wfDQ4zA+io413074TdWGFJDSU724W7lXds6Wxjq1TlPvEoMA/3pYU+w XDDAiUfnXdayzbwwUm8THqEOFh/pkzRqJDOxCfHAdJwf3vkbSZKByKaTbKEVRNfUWDO6 ny8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Apgi9n+xzAXbVBKSBVdWWRXmCTfXVngS5mFHrsICTMs=; b=nbYqxHWzfJCpBEb9TRhy0tGi66DtnM+PHKJPIwjONLM2SZ9JuqW+NoLfPDfersmLPI Gf/TMcZ/R5p2QSSi11xdnVQoDN9XmLY/py8gEV/X+bRPDNJJKuR+nZk5vFGHh5Dr7PuD a0WrqsxE0r/JKAN+Wo9Vs789FxeI4t3+KgW6r/uEOlsyyzWKZsDEc6uuGXQ2ZkGV5rAu 3iQMHJPNQif23jqPmpH7lU31AV7cmeqmo3chn4bNQkoN00pesQoHFykGEhPQMaAmcAre rZQ6QIjcNE0igYaFGNovhVUCNsdSVMSx3cdVOz0gLRcojjkk90B+x+CQueC9f9bXc9uW E6aQ== X-Gm-Message-State: AOAM533e/MBxrOGJdPGcp1koi3hF+J7pFNsH23/4zYv9dsyT2hlpIkz0 YWy/VaTvdKv25fHzgGs1y8I= X-Google-Smtp-Source: ABdhPJzxR8bJEgTzU8kGrjBoNAgSB6f2OziGqch2oqIf2DEC659r67p0cjibkB2R9Nn/dIX5P6vx4A== X-Received: by 2002:a63:e205:: with SMTP id q5mr2716251pgh.404.1626155599825; Mon, 12 Jul 2021 22:53:19 -0700 (PDT) Received: from archl-c2lm.. ([103.51.72.31]) by smtp.gmail.com with ESMTPSA id x19sm17755198pfa.104.2021.07.12.22.53.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jul 2021 22:53:19 -0700 (PDT) From: Anand Moon To: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Anand Moon , Matt Corallo , Martin Blumenstingl , Rob Herring , Neil Armstrong , Kevin Hilman , Jerome Brunet , Kishon Vijay Abraham I , Vinod Koul , Emiliano Ingrassia , devicetree@vger.kernel.org Subject: [PATCHv1 2/3] phy: amlogic: meson8b-usb2: Power off the PHY by putting it into reset mode Date: Tue, 13 Jul 2021 05:52:14 +0000 Message-Id: <20210713055227.1142-3-linux.amoon@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210713055227.1142-1-linux.amoon@gmail.com> References: <20210713055227.1142-1-linux.amoon@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Power off the PHY by putting it into reset mode. Cc: Martin Blumenstingl Signed-off-by: Anand Moon Acked-by: Martin Blumenstingl --- Fix the commit message. rfc - Keep vendor driver sequence for the power on reset of usb phy [0] https://patchwork.kernel.org/project/linux-amlogic/patch/20210617194154.2397-8-linux.amoon@gmail.com/ --- drivers/phy/amlogic/phy-meson8b-usb2.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/phy/amlogic/phy-meson8b-usb2.c b/drivers/phy/amlogic/phy-meson8b-usb2.c index 03c061dd5f0d..2aad45c55494 100644 --- a/drivers/phy/amlogic/phy-meson8b-usb2.c +++ b/drivers/phy/amlogic/phy-meson8b-usb2.c @@ -219,6 +219,10 @@ static int phy_meson8b_usb2_power_off(struct phy *phy) clk_disable_unprepare(priv->clk_usb); clk_disable_unprepare(priv->clk_usb_general); + /* power off the PHY by putting it into reset mode */ + regmap_update_bits(priv->regmap, REG_CTRL, REG_CTRL_POWER_ON_RESET, + REG_CTRL_POWER_ON_RESET); + return 0; } From patchwork Tue Jul 13 05:52:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 477064 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0265EC07E96 for ; Tue, 13 Jul 2021 05:53:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC6CD611F1 for ; Tue, 13 Jul 2021 05:53:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233453AbhGMF42 (ORCPT ); Tue, 13 Jul 2021 01:56:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233147AbhGMF40 (ORCPT ); Tue, 13 Jul 2021 01:56:26 -0400 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A97EC0613DD; Mon, 12 Jul 2021 22:53:36 -0700 (PDT) Received: by mail-pg1-x529.google.com with SMTP id k20so13675560pgg.7; Mon, 12 Jul 2021 22:53:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xqebAial/PxUvQ3x7+4RUByyPvCTdM4/Zaewy8REn3g=; b=rBIoJZjfWAT0sRt0CuW/uq1rjG98twshMCwuo4VaQt6XMH78VOKYuwbYlZD2OvKgfC WA+Orzbash1JXWVYc0LdD905jDTo2UNkKue11N0vhizpwQ1+hnchElQEiJBRU4v6SNjt Mp932YetKM2iQLa5Nj/9O4vS6T72OamP4Gp0oLWthTjgZqMEn8Hqaxfw3XHgTdWLAhZJ vNOAFY6WkHQWtbg4rtTy9EVA/q3m0LRP78HkRgMFtqdlBlTwDRm300n2ERdzYDs/3G9W dA1Ba+NjXPXtME0rbYx3pBJjluJAjATB5KWc6iP4PSMQA1ewHyFDULGomor4s9LVEIhQ v9XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xqebAial/PxUvQ3x7+4RUByyPvCTdM4/Zaewy8REn3g=; b=doeZn9vlPB/KWtXSeDAHSFwkyR98DMDmrJZrpmq8IY+8IAdV23v885CkpsJRtiECyB tkE84H6NCjG0Oq8jhSrGfByuP6ChajG4+tPQyVRn2lkBqO/DuydmS2cHuKt40vuPZ1gn k5TfnLMYTfL+KnYiOXIXBiSALSqmI1Ane21U+PUVziTi2H9tm8RMJBWBDvhE62d71r+g DoAExBE7ThULtwdMorJCzxNnYRGInAevX6Z7O+/iMQg4Nwc9qUcMr+alkSz6ZxlD3zZf qjiK8Yww893CQ3c1sKPb1HWb7YCluIknJvBYmAwqr+pO1Dwk6RnTjE/QaBx+mRRuHHZ8 2yaw== X-Gm-Message-State: AOAM530BCNf2JyPWrOc/5NQNnXKqx9bedbe/LEPVyBm7K04yX1IwWhPO 2QSIDyF+yCS4XqiyJrqSUYo= X-Google-Smtp-Source: ABdhPJyIw7eqiXGaYJ6UUi8zfg205/gHaSO1yNYTVWBN8ejx2F1ONjtA2jg18NkFnJE8nk+PVkgMIA== X-Received: by 2002:a62:5105:0:b029:305:324:17ae with SMTP id f5-20020a6251050000b0290305032417aemr2832898pfb.28.1626155616030; Mon, 12 Jul 2021 22:53:36 -0700 (PDT) Received: from archl-c2lm.. ([103.51.72.31]) by smtp.gmail.com with ESMTPSA id x19sm17755198pfa.104.2021.07.12.22.53.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jul 2021 22:53:35 -0700 (PDT) From: Anand Moon To: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Anand Moon , Matt Corallo , Martin Blumenstingl , Rob Herring , Neil Armstrong , Kevin Hilman , Jerome Brunet , Kishon Vijay Abraham I , Vinod Koul , Emiliano Ingrassia , devicetree@vger.kernel.org Subject: [PATCHv1 3/3] phy: amlogic: meson8b-usb2: don't log an error on -EPROBE_DEFER Date: Tue, 13 Jul 2021 05:52:15 +0000 Message-Id: <20210713055227.1142-4-linux.amoon@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210713055227.1142-1-linux.amoon@gmail.com> References: <20210713055227.1142-1-linux.amoon@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org devm_phy_create can return -EPROBE_DEFER if the phy-supply is not ready yet. Silence this warning as the driver framework will re-attempt registering the PHY. Use dev_err_probe() for phy resources to indicate the deferral reason when waiting for the resource to come up. Cc: Martin Blumenstingl Reviewed-by: Martin Blumenstingl Signed-off-by: Anand Moon --- [0] https://patchwork.kernel.org/project/linux-amlogic/patch/20210617194154.2397-9-linux.amoon@gmail.com/ --- --- drivers/phy/amlogic/phy-meson8b-usb2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/phy/amlogic/phy-meson8b-usb2.c b/drivers/phy/amlogic/phy-meson8b-usb2.c index 2aad45c55494..cf10bed40528 100644 --- a/drivers/phy/amlogic/phy-meson8b-usb2.c +++ b/drivers/phy/amlogic/phy-meson8b-usb2.c @@ -277,8 +277,8 @@ static int phy_meson8b_usb2_probe(struct platform_device *pdev) phy = devm_phy_create(&pdev->dev, NULL, &phy_meson8b_usb2_ops); if (IS_ERR(phy)) { - dev_err(&pdev->dev, "failed to create PHY\n"); - return PTR_ERR(phy); + return dev_err_probe(&pdev->dev, PTR_ERR(phy), + "failed to create PHY\n"); } phy_set_drvdata(phy, priv);