From patchwork Thu Jul 8 18:31:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cole Robinson X-Patchwork-Id: 471288 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp545861jao; Thu, 8 Jul 2021 11:34:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxmvtsYnWcmCmVrtHnh5RiIep5fhpmmC/CavYfJY8H6ZnLMjIPghhnsi5cNln5GLyZgK9pY X-Received: by 2002:a17:906:844:: with SMTP id f4mr3020815ejd.78.1625769256690; Thu, 08 Jul 2021 11:34:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625769256; cv=none; d=google.com; s=arc-20160816; b=waDy2oFy+0FE2pRJ29lmJYRhnb7KBUJAfCvpyzgopn8CjjxSHMopKLFD1oq+xrq75I hxWBC/iMVX9mTYmqzgImxTdTtDsKhsU8TMIh0rjlwq+jxWqPnvTBRYBWxeZbcz08kPTm 1pnHUAvUo85h7rZyfpz7XD6H1YlxlAi+ii0EhHVAc2lNZ++/0hgfIE3RtbhxbPG/0UXB cXwmbJoMro0iJBZscQ8Psa+u28VLwe0op8wAvcyqLt14f7fiQY76MCX6KIowNuO5s/yA zqVfq/tgz5UBcp1PrazeqFHp77/8H4SiByOFKviIyvw8nmfJLdzj28fagY4Lx7fMbPnZ Ux3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=iiz6v/kMqAJCgkRyKQ4skMujCmzp2djnME0ID3Zgsew=; b=bTl+x/NkiTItQzko5HPBXORsA/70vwGbh7rPZUmuciKE1WvOMCSLwG0mZfbDN6CU6c jKGm+LIjBfY7V5fUmEQe+bze5Kl8bpK8lWpZDKMu7RQdmd5ul7qRgjEfkuKQ7k1nAS4N IunQVJZLTRwYA2I3JtPsE8Sz4hSPuMaZc9IYh+0/gtLKUWGpmrQlybUQOW+mwLC95q4d fPad91KyOZPtS9r0HtkKQOUdTkhjCU2tUTz1eengCBtK15ogs5BLUwhaz69xZrEZtd7R 5ksalvzjIVwALZeNKK/IUSbmQ32xFTOBMUuhzfYbauTy5Y0yQrUtT9gNn8ydCEMbvmna b23g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=YrerLOrc; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c11si4200699edy.320.2021.07.08.11.34.16 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Jul 2021 11:34:16 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=YrerLOrc; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:41960 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1Yql-0005Sa-O2 for patch@linaro.org; Thu, 08 Jul 2021 14:34:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40826) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1YpR-000567-Tr for qemu-devel@nongnu.org; Thu, 08 Jul 2021 14:32:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:56612) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1YpQ-0001w5-FS for qemu-devel@nongnu.org; Thu, 08 Jul 2021 14:32:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625769171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iiz6v/kMqAJCgkRyKQ4skMujCmzp2djnME0ID3Zgsew=; b=YrerLOrcPJrHezMX4nG6up1yVlMgxeKZTWvgMwXQ5QyAnWQIb24jcndvHl9HRWWeUg7GJU huljoALNly/vvFGFaltcedE82WPqCcbn/seGf+OP6pgdpLeDaFYF5ThO8EhMv1MHo9JPr+ 68zHy0ZcpSBBlEcE44RUlDrRpS68leY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-207-K5ms8ufANQ6X0Bb7zawrDA-1; Thu, 08 Jul 2021 14:32:50 -0400 X-MC-Unique: K5ms8ufANQ6X0Bb7zawrDA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id ABB5F801A91 for ; Thu, 8 Jul 2021 18:32:49 +0000 (UTC) Received: from worklaptop.home (ovpn-115-15.rdu2.redhat.com [10.10.115.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6A0175FC07; Thu, 8 Jul 2021 18:32:44 +0000 (UTC) From: Cole Robinson To: qemu-devel@nongnu.org Subject: [PATCH 1/4] contrib: qemu-guest-agent.service: s/BindTo/BindsTo/g Date: Thu, 8 Jul 2021 14:31:59 -0400 Message-Id: <66ee16125e19c367a7752a018e72f3b34503d379.1625769000.git.crobinso@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=crobinso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=216.205.24.124; envelope-from=crobinso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.45, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cole Robinson Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" BindsTo is the documented name for this option, added in systemd 187 released in July 2012 Signed-off-by: Cole Robinson --- contrib/systemd/qemu-guest-agent.service | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.31.1 diff --git a/contrib/systemd/qemu-guest-agent.service b/contrib/systemd/qemu-guest-agent.service index 51cd7b37ff..59f7ecb1b8 100644 --- a/contrib/systemd/qemu-guest-agent.service +++ b/contrib/systemd/qemu-guest-agent.service @@ -1,6 +1,6 @@ [Unit] Description=QEMU Guest Agent -BindTo=dev-virtio\x2dports-org.qemu.guest_agent.0.device +BindsTo=dev-virtio\x2dports-org.qemu.guest_agent.0.device After=dev-virtio\x2dports-org.qemu.guest_agent.0.device [Service] From patchwork Thu Jul 8 18:32:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cole Robinson X-Patchwork-Id: 471290 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp548398jao; Thu, 8 Jul 2021 11:37:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzBpZ5a8U85AbXpuZGi/ujZCXTIPMswiJiFel0elll1iqdy0Jt/8c5YHUeGyGQcJEiSl5/f X-Received: by 2002:a67:6d05:: with SMTP id i5mr5430966vsc.12.1625769468130; Thu, 08 Jul 2021 11:37:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625769468; cv=none; d=google.com; s=arc-20160816; b=IMzpsCi7tP2CC7gao4BbGziQtOUOQewRn2iyWyYz+wqGl5v+HR5Y8jAagsNVtSPXOA FwShCo27CUqCQJqWB+VJwnC1luLCUap8KHX4UHi5Jsycfi41Bqtcz/2SwUoc3YbHk4bY 0X62R249ioopo1tUpZDT0KzggvwXnDLs3YoPMag0B+BU/zwW/kxpKz/VzyIBIT2bTrjR sa3SGxBeV5rnOkkHbHbVco8DQ7J0Ini8Yzv9CZ+aPw1P/kc4WTQ//dIi9TO/PJa5abgz 8T8RHQ8eJEkNvFsz0VZWX5Muo85wEUBmQ9aogXp6YPCQYnb2y7JLREyU7ELiZfz67FVX x1Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=ISqBKCG50Q+uHJRY5BwLzy4YuIGTUPjzlmsgxcUgY+E=; b=t144F+ZFZih/+yy40FLZdvHer1AV/NmUU0U5sKJVqU3P5bV4Xm9LLFkrGxo3GYrSB+ 6ppihPrK/dyvY51zbqf95VMmnxGwSqnR/GwzxpcciTHX6cRNGjlkJ1yUkAO2b4NlM+3M VvscHYA5ZDDr25famnRyStI0bqbK8RpVwXHRMenLK19Wbx29dk8A7KzhzIzfgfH+Glj8 rE0jKbDKXvCvYt4kfQHu1T8RrSKedStIjh9iD3FKYnnKat5EeghEfny5m7utgGayDk+O eHoRbwu+MCg3jaJyZodniRFduVKIKNAgNfIGGan/HON694Y996nLBWgYSMjykQPJL2n0 hCiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="c9av/ZrU"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id a3si2979939vki.60.2021.07.08.11.37.48 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Jul 2021 11:37:48 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="c9av/ZrU"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:51240 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1YuB-0003R2-EV for patch@linaro.org; Thu, 08 Jul 2021 14:37:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40938) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1Ypy-0005xB-2m for qemu-devel@nongnu.org; Thu, 08 Jul 2021 14:33:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:55679) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1Ypt-00022Y-0s for qemu-devel@nongnu.org; Thu, 08 Jul 2021 14:33:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625769200; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ISqBKCG50Q+uHJRY5BwLzy4YuIGTUPjzlmsgxcUgY+E=; b=c9av/ZrUoIqBmkT9rZDfn7DL+xLbLKkoN2n9fI2lPX2RCeEKpL6gO1yAyocghcq140OgpB yF9SEoc7GVUZVWdEbvPO/DrXNUEzqutTsN906sjruLThrmslI6Mqg7Je52W8pQJ+TvDs0+ d9ol2AIYvrAjHK+gCh9frN+0q5tnp8o= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-202-EZey6X8XN4qQgjmZnOmBMQ-1; Thu, 08 Jul 2021 14:33:18 -0400 X-MC-Unique: EZey6X8XN4qQgjmZnOmBMQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id ADEB2106B7F3 for ; Thu, 8 Jul 2021 18:33:10 +0000 (UTC) Received: from worklaptop.home (ovpn-115-15.rdu2.redhat.com [10.10.115.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id D283817567; Thu, 8 Jul 2021 18:32:49 +0000 (UTC) From: Cole Robinson To: qemu-devel@nongnu.org Subject: [PATCH 2/4] contrib: qemu-guest-agent.service: Add Documentation= link Date: Thu, 8 Jul 2021 14:32:00 -0400 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=crobinso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=crobinso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.45, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cole Robinson Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" OpenSUSE adds this to their service file Signed-off-by: Cole Robinson --- contrib/systemd/qemu-guest-agent.service | 1 + 1 file changed, 1 insertion(+) -- 2.31.1 diff --git a/contrib/systemd/qemu-guest-agent.service b/contrib/systemd/qemu-guest-agent.service index 59f7ecb1b8..7e1c50577b 100644 --- a/contrib/systemd/qemu-guest-agent.service +++ b/contrib/systemd/qemu-guest-agent.service @@ -1,5 +1,6 @@ [Unit] Description=QEMU Guest Agent +Documentation=https://wiki.qemu.org/Features/GuestAgent BindsTo=dev-virtio\x2dports-org.qemu.guest_agent.0.device After=dev-virtio\x2dports-org.qemu.guest_agent.0.device From patchwork Thu Jul 8 18:32:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cole Robinson X-Patchwork-Id: 471292 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp550097jao; Thu, 8 Jul 2021 11:40:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyk7FMVdoaf5u2IRJrjZKhzig/lmDn7YLMbd55Rf5O4VNbITBmerxtejEj/iGMxmTGgnOX8 X-Received: by 2002:a1f:a655:: with SMTP id p82mr19132862vke.20.1625769625248; Thu, 08 Jul 2021 11:40:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625769625; cv=none; d=google.com; s=arc-20160816; b=0yPkNWIJaPVYMdTED8jqm8n8fImxX769+n3BSOgf+kxaK5u9WHhoIk2ltV+CwA7KZr xHuuDVZZnQBZ0Sv7jHmVg4GRNKhkgePF3LO9FOux7MrzJ4UOGKHqEIsmzs9VuZth1vWO 0tYAutdWZIEokDiIKOlb6aQqgBigGK1bRx4KZ/TALPuGstsTocYFZ0mVzF2zvZZp9MAS YJnTdWUUxSqkYa2sfvjqIh4G1nLmwkg38/w373NwjFUsCBn38KvgPD6lKuTE/Pmks0WC kMIxxrkcWxn7OR3AsMod01oNSHbxQB1xoEa7pntKNtnZk/7KzVEIEQIsv9Z1JgYiR/J6 SKeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=jx+EntwNoDE0rSe5POzw6g2WXKu8L0NTv1fe1d4IzNY=; b=MNjnnqKgVRBs05b+BvQxZOErl2T38rJWfREEAonaZ8yyuAePPW0rQb9ISgjtR/vkPk T4/q8PxUtL3+3sFBE9o1RRvBQfrDEWKO5B8wBjDlaae9I9a/0bKnl65guotR1yKugAtP +hb1b8bcxWRQ37nxPdMSX41+06YspNnOcrZmrudZrNvkpOBPcO43qrCRuaaCB1uP2dYi Kn2M0hCIP1wZcCTV/IfuGvmJXkDBRdhJOdgyMQ9z4egUBYxaNLxZYM3kETbuSSuMhY0D MlqwIy2C5A4M64vdmoQnngOGtdk13Jid0nTjT0gWJ6cq2eYLFr91IEy2X7lErblHqY8I ft6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=NI4B3dLr; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id n12si3605641vsj.364.2021.07.08.11.40.25 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Jul 2021 11:40:25 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=NI4B3dLr; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:59380 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1Ywi-0000SD-Jh for patch@linaro.org; Thu, 08 Jul 2021 14:40:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40958) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1Yq9-00068q-L3 for qemu-devel@nongnu.org; Thu, 08 Jul 2021 14:33:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:40292) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1Yq8-00025V-4j for qemu-devel@nongnu.org; Thu, 08 Jul 2021 14:33:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625769215; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jx+EntwNoDE0rSe5POzw6g2WXKu8L0NTv1fe1d4IzNY=; b=NI4B3dLrjZQnPEzKE0quuNwu/mPWDloTM0VaqUDpLLJ+OR5Hng8NVjThz3HHEtwqfeES2c GuHx0enEQPd0oGQr/V+4oFxjqspC9/pxTiBH19B2o2K3X79FFrNDzdMx90mcFYOWTjjoZ7 j5Wfk6/QaI+upVwRVTh6AV5r9TkaSm4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-22-7YG6ilIqO9WqFeGkI7rXiA-1; Thu, 08 Jul 2021 14:33:34 -0400 X-MC-Unique: 7YG6ilIqO9WqFeGkI7rXiA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5552B100D0DF for ; Thu, 8 Jul 2021 18:33:17 +0000 (UTC) Received: from worklaptop.home (ovpn-115-15.rdu2.redhat.com [10.10.115.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id D404C17567; Thu, 8 Jul 2021 18:33:10 +0000 (UTC) From: Cole Robinson To: qemu-devel@nongnu.org Subject: [PATCH 3/4] contrib: qemu-guest-agent.service: Don't ignore failure Date: Thu, 8 Jul 2021 14:32:01 -0400 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=crobinso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=crobinso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.45, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cole Robinson Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" RHEL7+ and Fedora don't ignore errors, nor Arch. Debian and OpenSUSE do but I think that's because their service files are based on this / what Fedora used to ship. Signed-off-by: Cole Robinson --- contrib/systemd/qemu-guest-agent.service | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.31.1 diff --git a/contrib/systemd/qemu-guest-agent.service b/contrib/systemd/qemu-guest-agent.service index 7e1c50577b..505636a5ba 100644 --- a/contrib/systemd/qemu-guest-agent.service +++ b/contrib/systemd/qemu-guest-agent.service @@ -5,7 +5,7 @@ BindsTo=dev-virtio\x2dports-org.qemu.guest_agent.0.device After=dev-virtio\x2dports-org.qemu.guest_agent.0.device [Service] -ExecStart=-/usr/bin/qemu-ga +ExecStart=/usr/bin/qemu-ga Restart=always RestartSec=0 From patchwork Thu Jul 8 18:32:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cole Robinson X-Patchwork-Id: 471291 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp549125jao; Thu, 8 Jul 2021 11:38:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyv5qmVkyS4FH/mjfLCjzhrMVxee+qMUywr/cM+LMtCDU0GeI6U9Gk9Uz9R4wonAVMA7jDi X-Received: by 2002:ac5:c24e:: with SMTP id n14mr26691521vkk.23.1625769532131; Thu, 08 Jul 2021 11:38:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625769532; cv=none; d=google.com; s=arc-20160816; b=LzkBFQHXFw3NEaZK6EeVsfRmT3NqoWIIftJ9iSNzbmRtYyHTOMVHEFyfCai1pl4T2A MdzaiOajRV+1hFxjpCLwUMhfsZHLo20z6q9/rP8SdER9PR35GVt+TwrnbKAnFy9NeQXZ +CYsCamn5SJaZp/TqAgTELDWuvBqBbPY3jpR5twdVVLq2yaBYvvJChFh/lwtm4LogWr4 WQ3oI7qP+U3/i0Gn2oKM8p5xN3K+k4DG1hUJ2gb0tGmh9Dgk7oYoGdOROOOfXNit8a5y GWtGUwpeG95o8RK/Lpbe5+g3CcIuiWWJt8Rg40QUcWq33zXOo8E7ps0YrQYJmP09xQ89 lRtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=zO/h5X9UPnGQiOCuPnMzSAfAIq7BXyvkfwQU7S8Y810=; b=kPbVSb5qi+qLiZrbPwfv8bdFHmUL7VnGO9EUfnd2CMpzAvtwLl8lUBqZ9SVlbnK3Ej /YAeeofWRwZZCbmWxRo5ZfhIqF1TNzwBDp7yxT1mTzcZRTx95r7GTX6141I+P8zDLtfx DTJFw4Bjh4jz96lHukKyUNktFd4rA5eiQVUNk6XYCIrUVINEXnacfGBApWFxfTQlxfnG uOljStbIGCeuZxPuC57rcIE1ZpZnvEWSFLHdIkrXrDkxwywZ/JCDiK8nV206CumLkUYk +604tvGloQlbXMRPksE0P0MbztuY9UQayIRyQtJIcqkEguDFbKYubZpZpztJd0Lav1yO wJRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Lp12P3pP; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id u4si3823682vse.199.2021.07.08.11.38.52 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Jul 2021 11:38:52 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Lp12P3pP; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:54278 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1YvD-0005SB-Ib for patch@linaro.org; Thu, 08 Jul 2021 14:38:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40970) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1YqE-0006OY-GG for qemu-devel@nongnu.org; Thu, 08 Jul 2021 14:33:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:47673) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1YqC-00026O-J4 for qemu-devel@nongnu.org; Thu, 08 Jul 2021 14:33:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625769219; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zO/h5X9UPnGQiOCuPnMzSAfAIq7BXyvkfwQU7S8Y810=; b=Lp12P3pPm10fvytRcDZm5gANTDXrJSZ3bLM1caTfAY/4/4GXYK6moNuN8GW3nCFI7DjgC+ Zq/yc4sxPjZ6r/4EgJvKZ6EnSOKbfnnsN8UQXdlrww6GSmR3eFVsQeXA27fvx+sMc95ZkP pQn63I9gSEAvhMRaLF20kDj4j3sho+c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-479-t580vm8LOEyF99v7EUmgWw-1; Thu, 08 Jul 2021 14:33:38 -0400 X-MC-Unique: t580vm8LOEyF99v7EUmgWw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7D3D81926DCC for ; Thu, 8 Jul 2021 18:33:17 +0000 (UTC) Received: from worklaptop.home (ovpn-115-15.rdu2.redhat.com [10.10.115.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id DAE6569320; Thu, 8 Jul 2021 18:33:16 +0000 (UTC) From: Cole Robinson To: qemu-devel@nongnu.org Subject: [PATCH 4/4] contrib: qemu-guest-agent.service: Use IgnoreOnIsolate=True Date: Thu, 8 Jul 2021 14:32:02 -0400 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=crobinso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=216.205.24.124; envelope-from=crobinso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.45, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cole Robinson Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Changing runlevel (telinit 3) will stop qemu-guest-agent.service, and it won't ever restart, because it's intended to only start when the specified virtio device is added. Use IgnoreOnIsolate=True plus Install WantedBy= to keep the agent running regardless of runlevel, which is the expected behavior IMO. This has been in RHEL since 7.2ish timeframe: https://bugzilla.redhat.com/show_bug.cgi?id=1165176 Signed-off-by: Cole Robinson --- contrib/systemd/qemu-guest-agent.service | 2 ++ 1 file changed, 2 insertions(+) -- 2.31.1 diff --git a/contrib/systemd/qemu-guest-agent.service b/contrib/systemd/qemu-guest-agent.service index 505636a5ba..bb419fe55f 100644 --- a/contrib/systemd/qemu-guest-agent.service +++ b/contrib/systemd/qemu-guest-agent.service @@ -3,6 +3,7 @@ Description=QEMU Guest Agent Documentation=https://wiki.qemu.org/Features/GuestAgent BindsTo=dev-virtio\x2dports-org.qemu.guest_agent.0.device After=dev-virtio\x2dports-org.qemu.guest_agent.0.device +IgnoreOnIsolate=True [Service] ExecStart=/usr/bin/qemu-ga @@ -10,3 +11,4 @@ Restart=always RestartSec=0 [Install] +WantedBy=dev-virtio\x2dports-org.qemu.guest_agent.0.device