From patchwork Thu Aug 23 14:09:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 144932 Delivered-To: patch@linaro.org Received: by 2002:a2e:1648:0:0:0:0:0 with SMTP id 8-v6csp204194ljw; Thu, 23 Aug 2018 07:09:29 -0700 (PDT) X-Google-Smtp-Source: AA+uWPzLrPmDkWInCXU9k9p6ettrL58XOo8+sn1tHhBwHLX9v9Swt640JUoc66fSjLZ+pXFos4IH X-Received: by 2002:a63:5904:: with SMTP id n4-v6mr13012098pgb.275.1535033368856; Thu, 23 Aug 2018 07:09:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535033368; cv=none; d=google.com; s=arc-20160816; b=CnUdMFzMoPTcst0aYWpV1W/vWZbPmM5tzNibYEthUpMdub1jRbfeCCbMyO9lxDIo1T aZNCzlFDgWGYW+VqN8vvLiNfBYIoWiO7vWftZFdzuBpnZKF8f40EMudMeRG4SKdBnHWL 5p0F4C2IFxKnFM+mSR7FCvZITqxk4u7SzK1pipELngjGDZAWXrLhlOwBJaQkdkm2ndzm UM0vWF0vQPAOnItqkGb4RDhZbyFD24LjBjdgxOfCsjVb4KpagReVWsryd4b2doaZg8jM yMsFJmS+HT2r6bL9ln3i7UpzmPIeknpMt4t17nWtddik0V3r6q4M5PFs2EhVk2u0ZD6+ 56Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=E1bV/MlS6Ia/HPCqjIw0YSz95/Tg1gpNwFlmRA3q43Q=; b=uYVD3PKQOk3A1u5JuYmyLt/LoEjUIFV01p7tue/plb1TMSrjzD0jTbvsotiqVIMZeN SZM2Nfs5Yn0u04qJ7ivcfEzCJKM3R5TPZRTn93DhoexotH5+hUIdoom3rjsyww0nZQFo nZtSge8mJHPOBWhqhoCs4ojB9wMny9kWbCww5W4jSQdlTqKS7wloXCPU4SN1LQXpV1AB ghggFeCklpBPzrvuYCpPLn1yVMT307060z6QUe3NwrzYHlVJuftXGVLD6ma52LRi205/ 9YQsmD6RQbZBaBiAXzRVj7u4NGy+afwpgOxkB8+Qf7RT60/L/3A0V9swXbaA9i2EB/E5 ivNw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a61-v6si4458432plc.80.2018.08.23.07.09.27; Thu, 23 Aug 2018 07:09:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731352AbeHWRjP (ORCPT + 32 others); Thu, 23 Aug 2018 13:39:15 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:47033 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728707AbeHWRjP (ORCPT ); Thu, 23 Aug 2018 13:39:15 -0400 Received: from wuerfel.lan ([109.193.40.16]) by mrelayeu.kundenserver.de (mreue003 [212.227.15.129]) with ESMTPA (Nemesis) id 0MNQ45-1fmXpx1VVZ-006vWg; Thu, 23 Aug 2018 16:09:20 +0200 From: Arnd Bergmann To: John Johansen , James Morris , "Serge E. Hallyn" Cc: Arnd Bergmann , Seth Arnold , Matthew Garrett , Kees Cook , linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] apparmor: remove unused label Date: Thu, 23 Aug 2018 16:09:02 +0200 Message-Id: <20180823140917.3060915-1-arnd@arndb.de> X-Mailer: git-send-email 2.18.0 X-Provags-ID: V03:K1:grJHwwJTlK0rHz1G6OtWa7dTqG4vghsaujpdwcJpZn2z+yg/OfB U6XF1K03gwB5EApMxlnJhsCc3e86uIB4p0cwCnvguGW94gnvn2jOXwledMKrZqoiNSPnNci xDbRQDGNJaqqLGqoe5wFjLFEWPjBtymUdiXrlRlWvf9b6G5ypOcEwnEeTeNbcKVIZb1msTh P9Cr1l5r5yjrb0bOGrQZw== X-UI-Out-Filterresults: notjunk:1; V01:K0:fHQrGI7movw=:qYT0u/CFnx96h5Ae9EES1h 5xes1BjBYGCWrSGVppGs8/2G32NiW5K1E8Vc2GD6CLMPYZA6l+0wok0U7+bRPeczoJ+tW1UTg c2c6Jaa4eIkISc/WltTLu5CeHlyIrLti4GCmRpgQJ5s0oKwtAL56PPBDRzM41UuND2DBt4dI3 H+7xtG69EsFDJy0t2M4nrd0CtMXyqYkjeJKKj+vshXBTU2gHEosCoW+YD+f8B1pTqU8MNOPd7 Vzf2z5blFuF9T77Xbco05ssjj3Fe/aJ1aPXEcvm+veN29jMsOJeohZAxPVIANOf8u0gjaXnVr YdKLufeHHx2TacJ7OZ81h5joXtIkLk9ECfpKgD2c0g3CnblZFQ7kGxsfdqLhZI7MNbosVO2xF Rafs5xg+6GIQjz1D7rw+t0WMa2r6vsEJ+n3dL1xMOq8tBMOuXMPyoIK3kPQO4KfPFkJz0pPg9 RIm+aUzN+EWd75+sjdyO9mLQOZGHtWmyscnnd30hiPiha+imtLKyupvkHGEdsUdhCfCpHkShU 657CjXYx/kuvDddQmbZv8piic2lIgB8svWKQ640UsJwShAxgYMCeTULggO0Zb1PuKXAhQxojd 1Cv90D2wNKStSp0o2jxc5ER32nprrN14kOONbspJAh0j0QB/O8dTnn4sbzUeakjro94pnp8sb 385KrojIk4jd9qKTDJZFZXOYMPx6CzAM+HaYmL0oeeTZUBMpSKgrynGfqX6xQNvHcoqM= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After the corresponding 'goto' was removed, we get a warning for the 'fail' label: security/apparmor/policy_unpack.c: In function 'unpack_dfa': security/apparmor/policy_unpack.c:426:1: error: label 'fail' defined but not used [-Werror=unused-label] Fixes: fb5841091f28 ("apparmor: remove no-op permission check in policy_unpack") Signed-off-by: Arnd Bergmann --- security/apparmor/policy_unpack.c | 1 - 1 file changed, 1 deletion(-) -- 2.18.0 Reviewed-by: Kees Cook diff --git a/security/apparmor/policy_unpack.c b/security/apparmor/policy_unpack.c index 3647b5834ace..96d8cf68ce65 100644 --- a/security/apparmor/policy_unpack.c +++ b/security/apparmor/policy_unpack.c @@ -423,7 +423,6 @@ static struct aa_dfa *unpack_dfa(struct aa_ext *e) return dfa; -fail: aa_put_dfa(dfa); return ERR_PTR(-EPROTO); }