From patchwork Fri Jun 25 22:47:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emil Renner Berthing X-Patchwork-Id: 467180 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8577C2B9F4 for ; Fri, 25 Jun 2021 22:48:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8F5956194D for ; Fri, 25 Jun 2021 22:48:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229906AbhFYWui (ORCPT ); Fri, 25 Jun 2021 18:50:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229853AbhFYWug (ORCPT ); Fri, 25 Jun 2021 18:50:36 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC3D0C061767; Fri, 25 Jun 2021 15:48:14 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id t3so15498846edc.7; Fri, 25 Jun 2021 15:48:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dR80kVehOdx/x2VVdmW6gMUYIEIHf9stq/Tuqmgz73g=; b=l/KVoqhJi9y+dCw8stg/+wrEMRRHU7HgGahj+G7CEukYhWNjg0/DDNWUYC3id1vXTj X1ZKrgmpFMIGtf5vn/kbUL0eIPZDeOhcWNcfpZK23u+9/wX+AD8Cu36u5VcvcCOf9YvK 7ImOyGv36tFX6ycDkD6aDVzU3ClxFIh8+XaXYx4wRbyb15wx+jHX1gI/KN/A5nkyVqK/ Qu1qcb/4Hht5V11dxdJEpHNQUowGsn0WbfuPtgPBVvYE7XqlKeTHAZzla/wN4Xk+PBGV NcIluFHjFEIO4RTB/PzDNY4f43AVedaDUrWyoD456FZuh1BgPOaqts0S2INAPsRdJvdV korw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=dR80kVehOdx/x2VVdmW6gMUYIEIHf9stq/Tuqmgz73g=; b=fOT34nQnylKQ9xGNoj3lDzen9Cdu6OtMuf3F4ARs4uPwU6zAX7k9iq9B1DMu7cpNui YGGtImgw2LzyQ0YbKQaEp7jZLRcTwU7UZMRWZEFLUoD+U0iV6kWP6nt1V+8/hcWT5tR5 XBv/wREPapT1IWqLZ0UAc+lwKJf3GVNOOzpILME1OBbZVW4YIEQKewMnxd5VmAXA5jWo PKMkYfgdgpMs8tceO2zGyI5hcmOygZj8ThthTwexGN2JOi/J0wosUlsxHjgdVuqMu2MS HseXpN8wftvVytoyYYXJqCodCrOP6lYiCrsrJy6XJYD3Ce8ca3hFr9yWTeltjfxbQNVO BxFQ== X-Gm-Message-State: AOAM533kkOUpx44/KreTekOPde7lHtXFT2AsMPOMINhorepEeRtHeovS 5SoVDZ0Ui/G5cIjQ4md54C4= X-Google-Smtp-Source: ABdhPJwhW2ixLOeJvmFQKHCdluE4GE/s8tC1qRVDvuLaljtCsUuHRO4bigEtwFVQRMVCknexklyc5A== X-Received: by 2002:a05:6402:90b:: with SMTP id g11mr17982157edz.336.1624661291117; Fri, 25 Jun 2021 15:48:11 -0700 (PDT) Received: from stitch.. (80.71.140.73.ipv4.parknet.dk. [80.71.140.73]) by smtp.gmail.com with ESMTPSA id w1sm4719399edr.62.2021.06.25.15.48.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jun 2021 15:48:10 -0700 (PDT) Sender: Emil Renner Berthing From: Emil Renner Berthing To: Lee Jones , Rob Herring , Sebastian Reichel , "Andrew F. Davis" Cc: Emil Renner Berthing , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 1/3] dt-bindings: mfd: convert tps65086.txt to YAML Date: Sat, 26 Jun 2021 00:47:42 +0200 Message-Id: <20210625224744.1020108-2-kernel@esmil.dk> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210625224744.1020108-1-kernel@esmil.dk> References: <20210625224744.1020108-1-kernel@esmil.dk> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org This converts the tps65086.txt binding description to YAML schema so dts files can be verified automatically. Signed-off-by: Emil Renner Berthing --- @Andrew: The dt-bindings meta schema requires a maintainer entry. I hope it's ok that I've added you, otherwise I don't know who should be listed. .../devicetree/bindings/mfd/ti,tps65086.yaml | 127 ++++++++++++++++++ .../devicetree/bindings/mfd/tps65086.txt | 54 -------- 2 files changed, 127 insertions(+), 54 deletions(-) create mode 100644 Documentation/devicetree/bindings/mfd/ti,tps65086.yaml delete mode 100644 Documentation/devicetree/bindings/mfd/tps65086.txt diff --git a/Documentation/devicetree/bindings/mfd/ti,tps65086.yaml b/Documentation/devicetree/bindings/mfd/ti,tps65086.yaml new file mode 100644 index 000000000000..ba638bd10a58 --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/ti,tps65086.yaml @@ -0,0 +1,127 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/ti,tps65086.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: TPS65086 Power Management Integrated Circuit (PMIC) + +maintainers: + - Andrew F. Davis + +properties: + compatible: + const: ti,tps65086 + + reg: + const: 0x5e + description: I2C slave address + + interrupts: + maxItems: 1 + + interrupt-controller: true + + '#interrupt-cells': + const: 2 + description: | + The first cell is the IRQ number. The second cell is the flags, + encoded as trigger masks from ../interrupt-controller/interrupts.txt. + + gpio-controller: true + + '#gpio-cells': + const: 2 + description: | + The first cell is the pin number and the second cell is used to specify + flags. See ../gpio/gpio.txt for more information. + + regulators: + type: object + description: | + List of child nodes that specify the regulator initialization data. + Child nodes must be named after their hardware counterparts: + buck[1-6], ldoa[1-3], swa1, swb[1-2], and vtt. + Each child node is defined using the standard binding for regulators and + the optional regulator properties defined below. + + patternProperties: + "^buck[1-6]$": + type: object + $ref: ../regulator/regulator.yaml + + properties: + regulator-name: true + regulator-boot-on: true + regulator-always-on: true + regulator-min-microvolt: true + regulator-max-microvolt: true + ti,regulator-step-size-25mv: + type: boolean + description: | + Set this if the regulator is factory set with a 25mv step voltage + mapping. + ti,regulator-decay: + type: boolean + description: | + Set this if the output needs to decay, default is for the output + to slew down. + + additionalProperties: false + + "^(ldoa[1-3]|swa1|swb[1-2]|vtt)$": + type: object + $ref: ../regulator/regulator.yaml + + properties: + regulator-name: true + regulator-boot-on: true + regulator-always-on: true + regulator-min-microvolt: true + regulator-max-microvolt: true + + additionalProperties: false + +additionalProperties: false + +required: + - compatible + - reg + - interrupts + - interrupt-controller + - '#interrupt-cells' + - gpio-controller + - '#gpio-cells' + - regulators + +examples: + - | + #include + i2c0 { + #address-cells = <1>; + #size-cells = <0>; + + pmic: tps65086@5e { + compatible = "ti,tps65086"; + reg = <0x5e>; + interrupt-parent = <&gpio1>; + interrupts = <28 IRQ_TYPE_LEVEL_LOW>; + interrupt-controller; + #interrupt-cells = <2>; + gpio-controller; + #gpio-cells = <2>; + + regulators { + buck1 { + regulator-name = "vcc1"; + regulator-min-microvolt = <1600000>; + regulator-max-microvolt = <1600000>; + regulator-boot-on; + ti,regulator-decay; + ti,regulator-step-size-25mv; + }; + }; + }; + }; + +... diff --git a/Documentation/devicetree/bindings/mfd/tps65086.txt b/Documentation/devicetree/bindings/mfd/tps65086.txt deleted file mode 100644 index 67eac0ed32df..000000000000 --- a/Documentation/devicetree/bindings/mfd/tps65086.txt +++ /dev/null @@ -1,54 +0,0 @@ -* TPS65086 Power Management Integrated Circuit (PMIC) bindings - -Required properties: - - compatible : Should be "ti,tps65086". - - reg : I2C slave address. - - interrupts : The interrupt line the device is connected to. - - interrupt-controller : Marks the device node as an interrupt controller. - - #interrupt-cells : The number of cells to describe an IRQ, should be 2. - The first cell is the IRQ number. - The second cell is the flags, encoded as trigger - masks from ../interrupt-controller/interrupts.txt. - - gpio-controller : Marks the device node as a GPIO Controller. - - #gpio-cells : Should be two. The first cell is the pin number and - the second cell is used to specify flags. - See ../gpio/gpio.txt for more information. - - regulators: : List of child nodes that specify the regulator - initialization data. Child nodes must be named - after their hardware counterparts: buck[1-6], - ldoa[1-3], swa1, swb[1-2], and vtt. Each child - node is defined using the standard binding for - regulators and the optional regulator properties - defined below. - -Optional regulator properties: - - ti,regulator-step-size-25mv : This is applicable for buck[1-6], set this - if the regulator is factory set with a 25mv - step voltage mapping. - - ti,regulator-decay : This is applicable for buck[1-6], set this if - the output needs to decay, default is for - the output to slew down. - -Example: - - pmic: tps65086@5e { - compatible = "ti,tps65086"; - reg = <0x5e>; - interrupt-parent = <&gpio1>; - interrupts = <28 IRQ_TYPE_LEVEL_LOW>; - interrupt-controller; - #interrupt-cells = <2>; - gpio-controller; - #gpio-cells = <2>; - - regulators { - buck1 { - regulator-name = "vcc1"; - regulator-min-microvolt = <1600000>; - regulator-max-microvolt = <1600000>; - regulator-boot-on; - ti,regulator-decay; - ti,regulator-step-size-25mv; - }; - }; - }; From patchwork Fri Jun 25 22:47:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emil Renner Berthing X-Patchwork-Id: 467661 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E116DC49EAF for ; Fri, 25 Jun 2021 22:48:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD93461931 for ; Fri, 25 Jun 2021 22:48:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229882AbhFYWuh (ORCPT ); Fri, 25 Jun 2021 18:50:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229850AbhFYWug (ORCPT ); Fri, 25 Jun 2021 18:50:36 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3E8EC061766; Fri, 25 Jun 2021 15:48:13 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id i24so15512974edx.4; Fri, 25 Jun 2021 15:48:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9129PTw2ZRrh3YVetP+EXrB693QAxfAKWuMYosFITBg=; b=pOiZMcJ4MTH4QgF4f5U5T5fNdQY0i41364aWCgGWxvq1kkVbmwhhayL/lwrbfjL17R E3hKTLVD9Xk+UyAcwHqDE8I0SZqoExWbBT83D19KL/Bvhe2G08QvQsU0cgk4NcKMoxPp /MP5pzVjt1txwXy1CTPOUEVcV7MFKTRUsoBg6vo14GjuEcC6EcPQEW4Rf6xYDZJVVpt1 l6sglbSFsDzL5rf6gEYew/Y/uXUXOrH9epXtlQKKNH9A9JTeDsc7e8o+L2fgCDlt65MT BOBN6O4Vb7OcI3Pur6/9NUBiCf0Xbr2Mfv6rYnAaRfBBquDhoZWc3HzgCy7H4VAlJpuh OyWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=9129PTw2ZRrh3YVetP+EXrB693QAxfAKWuMYosFITBg=; b=Tkjse5lT0iaT/PoQ5lXYTtWKNq1IdF+vw4FdTDO+ioC2lVmBokPrayg5/F2iBWOJ8S iqb12p95Gu/e+YcI6ADtTMI0TbBe45jlal3/0yr92miY+KKaLPSoHKf3w4q6bsXIWkZB RqKoF7zfkc9m+ToUwcztQ6rS0QLRqsYzEf9vFM1PpvMgLCxHluK8YS7jXZ+TzNAj9lDd edmeI7bawHNvWPI6IbXB+Uo8yafNVtsJiqbmJ1Xu06iDuwiaXGQqnMhg5mBOzMiPXFJD Is3q4q5cdXkr9vqxNJgkDY7YjHnoSZDDRrbEzZ8BzBpBVAT8Oc793RnaAff5VWIgSeG0 puQQ== X-Gm-Message-State: AOAM530d/CrlzvrOYj847XxfkMVwGGP0Ce80bTPD9bCbtK1KFoMaCBtU s4KTKkzvcVvwn/utXq6tWdI= X-Google-Smtp-Source: ABdhPJxuyDbNQKWawLtABu+CIYZnfRVJJ5hMTBm6nv4pDzo6ru5ruP3Vn3JgJOua6+2QxKut9fu2Bg== X-Received: by 2002:a05:6402:313b:: with SMTP id dd27mr17836572edb.85.1624661292144; Fri, 25 Jun 2021 15:48:12 -0700 (PDT) Received: from stitch.. (80.71.140.73.ipv4.parknet.dk. [80.71.140.73]) by smtp.gmail.com with ESMTPSA id w1sm4719399edr.62.2021.06.25.15.48.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jun 2021 15:48:11 -0700 (PDT) Sender: Emil Renner Berthing From: Emil Renner Berthing To: Lee Jones , Rob Herring , Sebastian Reichel , "Andrew F. Davis" Cc: Emil Renner Berthing , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 2/3] mfd: tps65086: Make interrupt line optional Date: Sat, 26 Jun 2021 00:47:43 +0200 Message-Id: <20210625224744.1020108-3-kernel@esmil.dk> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210625224744.1020108-1-kernel@esmil.dk> References: <20210625224744.1020108-1-kernel@esmil.dk> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The BeagleV Starlight v0.9 board[1] doesn't have the IRQB line routed to the SoC, but it is still useful to be able to reach the PMIC over I2C for the other functionality it provides. [1] https://github.com/beagleboard/beaglev-starlight Signed-off-by: Emil Renner Berthing Acked-by: Rob Herring --- .../devicetree/bindings/mfd/ti,tps65086.yaml | 3 --- drivers/mfd/tps65086.c | 21 ++++++++++--------- 2 files changed, 11 insertions(+), 13 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/ti,tps65086.yaml b/Documentation/devicetree/bindings/mfd/ti,tps65086.yaml index ba638bd10a58..4b629fcc0df9 100644 --- a/Documentation/devicetree/bindings/mfd/ti,tps65086.yaml +++ b/Documentation/devicetree/bindings/mfd/ti,tps65086.yaml @@ -87,9 +87,6 @@ additionalProperties: false required: - compatible - reg - - interrupts - - interrupt-controller - - '#interrupt-cells' - gpio-controller - '#gpio-cells' - regulators diff --git a/drivers/mfd/tps65086.c b/drivers/mfd/tps65086.c index 341466ef20cc..cc3478ee9a64 100644 --- a/drivers/mfd/tps65086.c +++ b/drivers/mfd/tps65086.c @@ -100,29 +100,30 @@ static int tps65086_probe(struct i2c_client *client, (char)((version & TPS65086_DEVICEID_OTP_MASK) >> 4) + 'A', (version & TPS65086_DEVICEID_REV_MASK) >> 6); - ret = regmap_add_irq_chip(tps->regmap, tps->irq, IRQF_ONESHOT, 0, - &tps65086_irq_chip, &tps->irq_data); - if (ret) { - dev_err(tps->dev, "Failed to register IRQ chip\n"); - return ret; + if (tps->irq > 0) { + ret = regmap_add_irq_chip(tps->regmap, tps->irq, IRQF_ONESHOT, 0, + &tps65086_irq_chip, &tps->irq_data); + if (ret) { + dev_err(tps->dev, "Failed to register IRQ chip\n"); + return ret; + } } ret = mfd_add_devices(tps->dev, PLATFORM_DEVID_AUTO, tps65086_cells, ARRAY_SIZE(tps65086_cells), NULL, 0, regmap_irq_get_domain(tps->irq_data)); - if (ret) { + if (ret && tps->irq > 0) regmap_del_irq_chip(tps->irq, tps->irq_data); - return ret; - } - return 0; + return ret; } static int tps65086_remove(struct i2c_client *client) { struct tps65086 *tps = i2c_get_clientdata(client); - regmap_del_irq_chip(tps->irq, tps->irq_data); + if (tps->irq > 0) + regmap_del_irq_chip(tps->irq, tps->irq_data); return 0; } From patchwork Fri Jun 25 22:47:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emil Renner Berthing X-Patchwork-Id: 467660 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14A0BC49EBA for ; Fri, 25 Jun 2021 22:48:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F135661962 for ; Fri, 25 Jun 2021 22:48:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229924AbhFYWuj (ORCPT ); Fri, 25 Jun 2021 18:50:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229885AbhFYWui (ORCPT ); Fri, 25 Jun 2021 18:50:38 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 055F5C061574; Fri, 25 Jun 2021 15:48:15 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id r7so15460362edv.12; Fri, 25 Jun 2021 15:48:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ErxD8maB1i/ewc9qb7JkQUrub9MpmCOuQbYIh+ng7Mw=; b=LAiDAGaiFyVqvINRIsHYkQpEhJbkJynnj4snRQ3VP8yIMN62wTZOmzEFcJRRdlGi44 0TyYmvPXTsbqUg6Y0Wq0eIPfKJabn7KMJzjx5Z44rza9D3tDtF6t/ulTqxOEIgp9d/Sv XNReWSFpvFadKT2PoVpyInEP796Kq+thN6c42jRY/C64g0VssW5GNbHizrO6gJl7SY9s xDdZvifNT1nLSNLgFGKAm4L41DvqXJYtXymbucEkQTBp/dLw2qxkfWs3QGmomsmwL3b5 rTgiUnWAev00YFsKcGzAVVX/bve3N/Ra0ynNICdJNy5sI1s+3DD8tsv7wyguU1qN4qrO taxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ErxD8maB1i/ewc9qb7JkQUrub9MpmCOuQbYIh+ng7Mw=; b=DS559VuxnaoJelPhgeVP4tiYNCgEuHnoCthPuH9S0AHHVu0U4JQU6gtUP5NbIXxWLh zr72WeDSSw7DE+tRjTNw3hrJMdxTfUUFjzTE4RmnF9tNGwHjtA76hAVUNilD9nf4mnNS aLgB4WZ019O0mBcO3Urh0OSQtKRAS8vVy5By0LYo5v+H6monrU9+uS1WKUHzcM63Jf6X dSw5PG2v4B73rYWcoQK2kmpqMstS6IuhyOdRFkPyyzJe93M5MADx1rcmIupH2VgFkz+Q Sob0s/yHWQmDWjrLYWvzAJ1d33CCZzbSCLtifFo31OSqVxHkaumS+m7sFFpMqdQk0J3m 03ow== X-Gm-Message-State: AOAM533bOO/s1OjTTBiXxfR54BFB879ZRxQ9/diXvLNsCXSEOKwX7nAR /H/6WYj/qWeiotPFQZk7RYI= X-Google-Smtp-Source: ABdhPJyCzOxYfH0nS/aaMl6oMarNvx3KC9hCa/kwis38Z2qeZrnIU1nPxEQBawSG5dG5oFr4xQriHA== X-Received: by 2002:a05:6402:516b:: with SMTP id d11mr18111155ede.252.1624661293177; Fri, 25 Jun 2021 15:48:13 -0700 (PDT) Received: from stitch.. (80.71.140.73.ipv4.parknet.dk. [80.71.140.73]) by smtp.gmail.com with ESMTPSA id w1sm4719399edr.62.2021.06.25.15.48.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jun 2021 15:48:12 -0700 (PDT) Sender: Emil Renner Berthing From: Emil Renner Berthing To: Lee Jones , Rob Herring , Sebastian Reichel , "Andrew F. Davis" Cc: Emil Renner Berthing , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 3/3] power: reset: Add TPS65086 restart driver Date: Sat, 26 Jun 2021 00:47:44 +0200 Message-Id: <20210625224744.1020108-4-kernel@esmil.dk> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210625224744.1020108-1-kernel@esmil.dk> References: <20210625224744.1020108-1-kernel@esmil.dk> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The only way to reset the BeagleV Starlight v0.9 board[1] properly is to tell the PMIC to reset itself which will then assert the external reset lines of the SoC, USB hub and ethernet phy. This adds a driver to register a reset handler to do just that. [1] https://github.com/beagleboard/beaglev-starlight Signed-off-by: Emil Renner Berthing Acked-by: Sebastian Reichel --- drivers/mfd/tps65086.c | 1 + drivers/power/reset/Kconfig | 6 ++ drivers/power/reset/Makefile | 1 + drivers/power/reset/tps65086-restart.c | 99 ++++++++++++++++++++++++++ 4 files changed, 107 insertions(+) create mode 100644 drivers/power/reset/tps65086-restart.c diff --git a/drivers/mfd/tps65086.c b/drivers/mfd/tps65086.c index cc3478ee9a64..1bfba0758fcc 100644 --- a/drivers/mfd/tps65086.c +++ b/drivers/mfd/tps65086.c @@ -24,6 +24,7 @@ static const struct mfd_cell tps65086_cells[] = { { .name = "tps65086-regulator", }, { .name = "tps65086-gpio", }, + { .name = "tps65086-restart", }, }; static const struct regmap_range tps65086_yes_ranges[] = { diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig index 4d1192062508..4b563db3ab3e 100644 --- a/drivers/power/reset/Kconfig +++ b/drivers/power/reset/Kconfig @@ -204,6 +204,12 @@ config POWER_RESET_ST help Reset support for STMicroelectronics boards. +config POWER_RESET_TPS65086 + bool "TPS65086 restart driver" + depends on MFD_TPS65086 + help + This driver adds support for resetting the TPS65086 PMIC on restart. + config POWER_RESET_VERSATILE bool "ARM Versatile family reboot driver" depends on ARM diff --git a/drivers/power/reset/Makefile b/drivers/power/reset/Makefile index cf3f4d02d8a5..f606a2f60539 100644 --- a/drivers/power/reset/Makefile +++ b/drivers/power/reset/Makefile @@ -23,6 +23,7 @@ obj-$(CONFIG_POWER_RESET_QNAP) += qnap-poweroff.o obj-$(CONFIG_POWER_RESET_REGULATOR) += regulator-poweroff.o obj-$(CONFIG_POWER_RESET_RESTART) += restart-poweroff.o obj-$(CONFIG_POWER_RESET_ST) += st-poweroff.o +obj-$(CONFIG_POWER_RESET_TPS65086) += tps65086-restart.o obj-$(CONFIG_POWER_RESET_VERSATILE) += arm-versatile-reboot.o obj-$(CONFIG_POWER_RESET_VEXPRESS) += vexpress-poweroff.o obj-$(CONFIG_POWER_RESET_XGENE) += xgene-reboot.o diff --git a/drivers/power/reset/tps65086-restart.c b/drivers/power/reset/tps65086-restart.c new file mode 100644 index 000000000000..ad9f2c5a84ac --- /dev/null +++ b/drivers/power/reset/tps65086-restart.c @@ -0,0 +1,99 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) 2021 Emil Renner Berthing + */ + +#include +#include +#include +#include +#include + +struct tps65086_restart { + struct notifier_block handler; + struct tps65086 *tps; + struct device *dev; +}; + +static int tps65086_restart_notify(struct notifier_block *this, + unsigned long mode, void *cmd) +{ + struct tps65086_restart *tps65086_restart = + container_of(this, struct tps65086_restart, handler); + int ret; + + ret = regmap_write(tps65086_restart->tps->regmap, TPS65086_FORCESHUTDN, 1); + if (ret) { + dev_err(tps65086_restart->dev, "%s: error writing to tps65086 pmic: %d\n", + __func__, ret); + return NOTIFY_DONE; + } + + /* give it a little time */ + mdelay(200); + + WARN_ON(1); + + return NOTIFY_DONE; +} + +static int tps65086_restart_probe(struct platform_device *pdev) +{ + struct tps65086_restart *tps65086_restart; + int ret; + + tps65086_restart = devm_kzalloc(&pdev->dev, sizeof(*tps65086_restart), GFP_KERNEL); + if (!tps65086_restart) + return -ENOMEM; + + platform_set_drvdata(pdev, tps65086_restart); + + tps65086_restart->handler.notifier_call = tps65086_restart_notify; + tps65086_restart->handler.priority = 192; + tps65086_restart->tps = dev_get_drvdata(pdev->dev.parent); + tps65086_restart->dev = &pdev->dev; + + ret = register_restart_handler(&tps65086_restart->handler); + if (ret) { + dev_err(&pdev->dev, "%s: cannot register restart handler: %d\n", + __func__, ret); + return -ENODEV; + } + + return 0; +} + +static int tps65086_restart_remove(struct platform_device *pdev) +{ + struct tps65086_restart *tps65086_restart = platform_get_drvdata(pdev); + int ret; + + ret = unregister_restart_handler(&tps65086_restart->handler); + if (ret) { + dev_err(&pdev->dev, "%s: cannot unregister restart handler: %d\n", + __func__, ret); + return -ENODEV; + } + + return 0; +} + +static const struct platform_device_id tps65086_restart_id_table[] = { + { "tps65086-restart", }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(platform, tps65086_restart_id_table); + +static struct platform_driver tps65086_restart_driver = { + .driver = { + .name = "tps65086-restart", + }, + .probe = tps65086_restart_probe, + .remove = tps65086_restart_remove, + .id_table = tps65086_restart_id_table, +}; +module_platform_driver(tps65086_restart_driver); + +MODULE_AUTHOR("Emil Renner Berthing "); +MODULE_DESCRIPTION("TPS65086 restart driver"); +MODULE_LICENSE("GPL v2");