From patchwork Fri Aug 10 08:04:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 143890 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp3053687ljj; Fri, 10 Aug 2018 01:09:24 -0700 (PDT) X-Google-Smtp-Source: AA+uWPwJFIl5D3ixEKJ8w1cz8rl1Rm/ZwqfkPQNOsJEcCqlVume5Eb3PeCW7WPa5WBIqSJ2LHvcS X-Received: by 2002:a63:4c56:: with SMTP id m22-v6mr5240041pgl.299.1533888564282; Fri, 10 Aug 2018 01:09:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533888564; cv=none; d=google.com; s=arc-20160816; b=pH2oH7gc9vQmQ2gZBSNcAC82g4DbW8XOs3XANLzhz9kp7GkugRs3H4WAUojvJS3cyA G3Ic6eHVOwGVOCScTudiGdFsNGL7/INHOjAWiuzHPKF4e77NWrh7ANEHIfZK84uu6gwQ n9Ab4t/zRKbxdUvv5cNY9aTvC4meib7x67YSdPDmWV66+C+noC38yq+Zqhj5vVtCEOqJ S3hmk/mWiS3MqmPSMhc4uVtbgUEcc75uwb0WLPHv007P7CsgydtTSe72oU4WUefEvJra bKnZx5G5659bQyMfphN9Bni/63t55N3s+HBSlKBDilg6ma7N1PZIv0/bciYi5iCvxsQI UP/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:cms-type:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=AqQw9fP/13rSF06vKt98BrMYLvbP0lrzs6j/J19kAnk=; b=bk045fe6ZODj3Ua9EeQdigEsq99O763VMMVhYXecO7VqB+/JtKg1EzA6JcbXtSi24K J0Bje1YjZcSLfZuUcXaBCt9+dfd6aVdjJDB2FroDH7nj4VCTBp1cDkU9pvYL4r8keR18 2pQeYao1b3B/1tyFl2iPEk7C8GmI4FWJFXb/YKdO8n/fI94ZMJgLIFSVYieHt0TNGMoo 4jvUdhK0G/WAaSWHzAO+LOTF2Gw93rAhhTKfGQa0PGH1nmB5DwtYt910Eg5OK4/0S6+M BSlQHLnwbJp7CA8ql3tLyy0QIMy/FR1fj2sANlzeex4hdRcDaNFljTeBw60g1UOE+syF UgoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=HIdq04Th; spf=pass (google.com: best guess record for domain of linux-samsung-soc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-samsung-soc-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q35-v6si9541815pgb.219.2018.08.10.01.09.24; Fri, 10 Aug 2018 01:09:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-samsung-soc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=HIdq04Th; spf=pass (google.com: best guess record for domain of linux-samsung-soc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-samsung-soc-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727284AbeHJKiI (ORCPT + 3 others); Fri, 10 Aug 2018 06:38:08 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:58170 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726963AbeHJKiH (ORCPT ); Fri, 10 Aug 2018 06:38:07 -0400 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20180810080920euoutp025f08dac3c17991a76f439d38c73d6120~Jd4Tsfgdi0642406424euoutp02D for ; Fri, 10 Aug 2018 08:09:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20180810080920euoutp025f08dac3c17991a76f439d38c73d6120~Jd4Tsfgdi0642406424euoutp02D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1533888560; bh=AqQw9fP/13rSF06vKt98BrMYLvbP0lrzs6j/J19kAnk=; h=From:To:Cc:Subject:Date:References:From; b=HIdq04ThnORl4ddAAe4PiLRu/UDRcBfKmfKbr+3RRhVj9R+ii4He+zO7pkTzhDkWU iLhyN2Bi5RqtPCtZagBY1J4/xLeyGUSVvY6NXG+bJLCXyve30IH/5hK0qw4Gbjwh7P CBRn7i4RUrGVULcTL28B0hGYlFya/JyZeoecvp5w= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20180810080920eucas1p140772ab84b428c46ffd08f9d2535d3ed~Jd4TQrdNo1821218212eucas1p1m; Fri, 10 Aug 2018 08:09:20 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 46.8C.04294.0384D6B5; Fri, 10 Aug 2018 09:09:20 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20180810080919eucas1p2bb23af2e77cec919ea4fedf5d7060a2c~Jd4SboJkM2411624116eucas1p2n; Fri, 10 Aug 2018 08:09:19 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20180810080919eusmtrp1cee3cc2978258c6460ab5df6eb33c21f~Jd4SaS7wC1603916039eusmtrp15; Fri, 10 Aug 2018 08:09:19 +0000 (GMT) X-AuditID: cbfec7f4-84fff700000010c6-30-5b6d4830d06a Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 4C.73.04128.F284D6B5; Fri, 10 Aug 2018 09:09:19 +0100 (BST) Received: from AMDC2765.digital.local (unknown [106.116.147.25]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20180810080918eusmtip134b09748d9d3b99e08cd927e7c4ba87e~Jd4R0YW-E0092100921eusmtip1j; Fri, 10 Aug 2018 08:09:18 +0000 (GMT) From: Marek Szyprowski To: linux-samsung-soc@vger.kernel.org Cc: Marek Szyprowski , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Tomasz Figa , Javier Martinez Canillas Subject: [PATCH] ARM: dts: exynos: Fix regulators configuration on Peach Pi/Pit Chromebooks Date: Fri, 10 Aug 2018 10:04:25 +0200 X-Mailer: git-send-email 2.17.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBIsWRmVeSWpSXmKPExsWy7djPc7oGHrnRBncncVpsnLGe1WLhtOWM FufPb2C3mHF+H5PF2iN32S0+t/5jc2DzmN1wkcVj06pONo/3+66yefRtWcXo8XmTXABrFJdN SmpOZllqkb5dAlfG3N0NjAVvpCru9m1jb2D8JdrFyMkhIWAisXrqcsYuRi4OIYEVjBIn9pyD cr4wSmzrbmKCcD4zSvyYepYdpuVWyy2oquWMEnO6l7JCOF8ZJW4+vMoMUsUmYCjR9baLDcQW EVCV+Ny2AKybWeAxo8T+TcUgtrBArMTjr7OA6jk4WIBq3nRXQyyQl1i94QAzyEwJgTNsEq3X V4DV8AqUSSz5JwJiSgi4SMxZaA1RLizx6vgWqNtkJE5P7mGBaG1mlGifMYsdwulhlNg6Zwcb RJW1xOHjF1lBBjELaEqs36UPEXaUuD7jKgvEfD6JG28FIS7mk5i0bTozRJhXoqNNCKJaTWLW 8XVwaw9euMQMYXtIHH62F2yRENCDd6ZOYJ7AKDcLYdcCRsZVjOKppcW56anFRnmp5XrFibnF pXnpesn5uZsYgfF/+t/xLzsYd/1JOsQowMGoxMMrUJwTLcSaWFZcmXuIUYKDWUmEN9M0N1qI NyWxsiq1KD++qDQntfgQozQHi5I4L59WWrSQQHpiSWp2ampBahFMlomDU6qB0bWfRXxCc/3H 21dPs6pXirstFzxz9bTegunOm0Ljt/7RSpzZ4/Ra5YXXU8vczVpfdc7mZr99M+mQb+Hxc8f2 LXyf5fuxwjg8tNxURPvCIpHZzM1bWjjf3Ns0bXuWEIfT5c+GWcdY5xbYHTy5a880nQbfZJXT UybPK65yOsfN8vOPCLfli5Wly5VYijMSDbWYi4oTAZhHNRT7AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrALMWRmVeSWpSXmKPExsVy+t/xu7r6HrnRBrO7+S02zljParFw2nJG i/PnN7BbzDi/j8li7ZG77BafW/+xObB5zG64yOKxaVUnm8f7fVfZPPq2rGL0+LxJLoA1Ss+m KL+0JFUhI7+4xFYp2tDCSM/Q0kLPyMRSz9DYPNbKyFRJ384mJTUnsyy1SN8uQS9j7u4GxoI3 UhV3+7axNzD+Eu1i5OSQEDCRuNVyi7GLkYtDSGApo8T6vm9MEAkZiZPTGlghbGGJP9e62CCK PjNKfPu3iw0kwSZgKNH1tgvMFhFQlfjctoAdpIhZ4CmjxI73fWCThAWiJaa83MPSxcjBwQJU 9Ka7GiTMK2ArsWDXKahl8hKrNxxgnsDIs4CRYRWjSGppcW56brGRXnFibnFpXrpecn7uJkZg 6G079nPLDsaud8GHGAU4GJV4eBlSc6KFWBPLiitzDzFKcDArifBmmuZGC/GmJFZWpRblxxeV 5qQWH2I0Bdo9kVlKNDkfGBd5JfGGpobmFpaG5sbmxmYWSuK85w0qo4QE0hNLUrNTUwtSi2D6 mDg4pRoYtWR0/3pbBaqw37npuevWys+ivfdmLX5R08kcM1GlpfqBPKvlpssLi7Yfl3qiJ2M+ 86vZhtun9isn5Fe8nmdvHSjnM1NbouSovN2elIqT3esmXTrh+6vryBWX1KCuu8ntPrtP9nVc N3ktYmonYPHk/lk75dhrvm975RfbC6xXEli1z2xZgV2UEktxRqKhFnNRcSIA+WJm9lMCAAA= Message-Id: <20180810080919eucas1p2bb23af2e77cec919ea4fedf5d7060a2c~Jd4SboJkM2411624116eucas1p2n@eucas1p2.samsung.com> X-CMS-MailID: 20180810080919eucas1p2bb23af2e77cec919ea4fedf5d7060a2c X-Msg-Generator: CA X-RootMTR: 20180810080919eucas1p2bb23af2e77cec919ea4fedf5d7060a2c X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180810080919eucas1p2bb23af2e77cec919ea4fedf5d7060a2c References: Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Regulators, which are marked as 'on-in-suspend' seems to be critical for board operation, thus they must not be disabled anytime. This can be only assured by marking them as 'always-on', because otherwise some actions of their clients might result in turning them off. This patch restores suspend/resume operation on Peach-Pit Chromebook board. It partially reverts 'always-on' property removal done by the commit mentioned in the Fixes tag. Fixes: 665c441eea3d ("ARM: dts: exynos: Remove unneded always-on for regulators on Peach boards") Signed-off-by: Marek Szyprowski --- This partial revert restores suspend/resume operation on Linux v4.7 release. To make suspend/resume working on current linux-next (tested on next-20180806), one has to additionally revert following commits: 925ffff2ea8b "Input: cros_ec_keyb - remove check before calling pm_wakeup_event" 38ba34a43dbc "Input: cros_ec_keyb - mark cros_ec_keyb driver as wake enabled device." 47b7de2f6c18 "mmc: dw_mmc: fix falling from idmac to PIO mode when dw_mci_reset occurs" 2695578b896a "net: usbnet: fix potential deadlock on 32bit hosts" I'm investigating those issues and separate reports/fixes will be posted for them. Best regards Marek Szyprowski --- arch/arm/boot/dts/exynos5420-peach-pit.dts | 3 +++ arch/arm/boot/dts/exynos5800-peach-pi.dts | 3 +++ 2 files changed, 6 insertions(+) -- 2.17.1 Tested-by: Tomasz Figa diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts index 57c2332bf282..4ebb37043223 100644 --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts @@ -312,6 +312,7 @@ regulator-name = "vdd_1v35"; regulator-min-microvolt = <1350000>; regulator-max-microvolt = <1350000>; + regulator-always-on; regulator-boot-on; regulator-state-mem { regulator-on-in-suspend; @@ -333,6 +334,7 @@ regulator-name = "vdd_2v"; regulator-min-microvolt = <2000000>; regulator-max-microvolt = <2000000>; + regulator-always-on; regulator-boot-on; regulator-state-mem { regulator-on-in-suspend; @@ -343,6 +345,7 @@ regulator-name = "vdd_1v8"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; + regulator-always-on; regulator-boot-on; regulator-state-mem { regulator-on-in-suspend; diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts index d80ab9085da1..7ada8b53ea31 100644 --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts @@ -312,6 +312,7 @@ regulator-name = "vdd_1v35"; regulator-min-microvolt = <1350000>; regulator-max-microvolt = <1350000>; + regulator-always-on; regulator-boot-on; regulator-state-mem { regulator-on-in-suspend; @@ -333,6 +334,7 @@ regulator-name = "vdd_2v"; regulator-min-microvolt = <2000000>; regulator-max-microvolt = <2000000>; + regulator-always-on; regulator-boot-on; regulator-state-mem { regulator-on-in-suspend; @@ -343,6 +345,7 @@ regulator-name = "vdd_1v8"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; + regulator-always-on; regulator-boot-on; regulator-state-mem { regulator-on-in-suspend;