From patchwork Fri Aug 10 15:01:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zeng Tao X-Patchwork-Id: 143889 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2999717ljj; Fri, 10 Aug 2018 00:04:54 -0700 (PDT) X-Google-Smtp-Source: AA+uWPy/UyR/YHyuyYElKpiPB4irmu9qkUL+3FFKMJGxiVNFnaBjFbwPBhY9EL7D8dJCKNOPDv+n X-Received: by 2002:a63:5660:: with SMTP id g32-v6mr5261881pgm.227.1533884694618; Fri, 10 Aug 2018 00:04:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533884694; cv=none; d=google.com; s=arc-20160816; b=miEuezSiVBp3U4E/D7dy47HtmI+IigUZQNRitIMAgrzGBjmQ/gOHXDfUQl/Q2/dSzI h9g5W7NbHTzLLuFUcZ4bIBlPtXlFcJM4QSxj9xRsU+4x8YxYIvfjzE5WTF55jnIVfmIh r9VoD5DXOEGoWCMuwc1pWmGMmOPAmUrSXAqC1v1qhUebm2GvSbwS4jpdGO+PrqZIxplW TOuU2g6BRnMkX2XPcC02hKK6iH/Br72XjpWO8398w4RFm0pMgTKIHyLLsWt8EE+WrXku estkCiuy7LO4ESBMFLUXuCTD2+HdBUv+ZDNCHEUXF+sFygTgFvSjapc5Cyvenfh5ggqA WJ8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=CXYn4EmEbOdJEo7A2TJe8+l3vkxODtxHHMOB84BxB4E=; b=S9CjUtCmNhYdPeFrI7M3DOVopooR5VrGfPMNzfaV1UL1f0TSFaGy79u6kfVC3mXL7E 5wb+ZNDFMPiMWocftK+EjVHzJYPOSmB6+yrgQj7nhxLMg2zF14rvSqRHuz9Fc0mS8iOJ vFaM6rBlaTfQ7spwzP9LMLwyqgJcdUkkofFMyWQeE7uBaB6R8nRoJDVDnw50pHeuv4L6 kjYYKMsgcb8B6OTxQYNq+sFqK0YBJGPI/mLcdk7QFI08Fciqm7fv87+lZFVy531nHcze n6si+6Nr892N6J0JT/RKhNJZ9+xwXvzkTH7z3KPHEkJMD2QI267AydTJmCqfXKiciapy yiFQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s6-v6si9292654pgg.41.2018.08.10.00.04.54; Fri, 10 Aug 2018 00:04:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727628AbeHJJdX (ORCPT + 31 others); Fri, 10 Aug 2018 05:33:23 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:41988 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726961AbeHJJdX (ORCPT ); Fri, 10 Aug 2018 05:33:23 -0400 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id E916A84A94A8; Fri, 10 Aug 2018 15:04:48 +0800 (CST) Received: from dessert.huawei.com (10.69.192.158) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.399.0; Fri, 10 Aug 2018 15:04:42 +0800 From: Zeng Tao To: , , , , , , , CC: Zeng Tao , , Subject: [PATCH] usb: hub: try old enumeration scheme first for high speed devices Date: Fri, 10 Aug 2018 23:01:42 +0800 Message-ID: <1533913304-15737-1-git-send-email-prime.zeng@hisilicon.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [10.69.192.158] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The new scheme is required just to support legacy low and full-speed devices. For high speed devices, it will slower the enumeration speed. So in this patch we try the "old" enumeration scheme first for high speed devices. Signed-off-by: Zeng Tao --- drivers/usb/core/hub.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.7.4 diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 1fb2668..d265b19 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -2661,10 +2661,13 @@ static bool use_new_scheme(struct usb_device *udev, int retry, int old_scheme_first_port = port_dev->quirks & USB_PORT_QUIRK_OLD_SCHEME; + int quick_enumeration = (udev->speed == USB_SPEED_HIGH); + if (udev->speed >= USB_SPEED_SUPER) return false; - return USE_NEW_SCHEME(retry, old_scheme_first_port || old_scheme_first); + return USE_NEW_SCHEME(retry, old_scheme_first_port || old_scheme_first + || quick_enumeration); } /* Is a USB 3.0 port in the Inactive or Compliance Mode state?