From patchwork Fri Aug 3 17:01:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 143424 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp385819ljj; Fri, 3 Aug 2018 10:01:12 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfVtgQjwHtPMSFtwmsE163de2vLttWrwODHfIMEhFWwQ7MZKn90V7zp13PHY8jmGz9FGUEG X-Received: by 2002:adf:959a:: with SMTP id p26-v6mr3100566wrp.202.1533315672766; Fri, 03 Aug 2018 10:01:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533315672; cv=none; d=google.com; s=arc-20160816; b=fIK1bdYT1+qpZseUuyvMzUhvWqVaBp2wzC3CNQ3qVZyD36l+6nkNWw60HOBXjcmgK7 vyYwLjlAP1xEHOUBqSRFi5kEluN1j2vZO0rYjpCoJ6WdDkqenCEH9OxhkG0dKp2sy3M9 jpJCIYqYlQxcoCNf1zEwb2Kv5TkN3B6gwk8qcvrT0N5Az37f43uq/qMw1VOOLvih9FAR 93to1wbxyUYAJSZUZ/oeXa/UrqqEXvMaJY9nkciNChO8sJCQPrdnEZs41GzWEFqUidJ4 HwEZkPBNsvKamgbr8Y8CBCkM8wUUx9tdogAmcqEJL1LV7d1QUYfbnOMhneZWTowA6+Ob +o6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=/KQwKzhx8jXa1NCMwwqfnS7q1I4tDVQuY9LX6HAZ24s=; b=uI5Qgq8X1G8i4o/Mg51zRqNYkL5GTWnvtlC1Jkspv+XHsV+NNpR4j6oaRl4cGAMqKw fLk/oAwPNTRPeZ0KdLdADMCsl+S6HjGcgX6e8UFPqEsq86OVnVK3AAb0skbBkm9TpAKg sEfNyWPvouzySRJSI64MOBdETVyUWP8NFjtQFV3YObWQabd/9npAXXAhgzUKPYcK14QN Ae7CAJBfwTvAKkfDVPnCfJhkkTgbsZIbOVCvxgl+Hr1cldhQKY4Oq5+zJavl7jI+nbPE tEW6ML2zP37VaqF83EPHpAon3gmQmRicdqeca4bV7+6F7qVnEGMo0ahzgnbsMVYiRW1j LRsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=kaQ1+OtT; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id e11-v6si3774693wrv.453.2018.08.03.10.01.12; Fri, 03 Aug 2018 10:01:12 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=kaQ1+OtT; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 626552677D6; Fri, 3 Aug 2018 19:01:11 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 7F7592677D1; Fri, 3 Aug 2018 19:01:08 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id 364A22677D4 for ; Fri, 3 Aug 2018 19:01:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=7pQPA/BK8UtXHt1V0lVaQ58KCs29r78bxO4I9yDO6Kk=; b=kaQ1+OtT85DW Yl0uf+ANGfehkSnKnQR/TVveEWRetdPsTBkUFhLUNdZeDEMOsO3fJ20xKa69OTPWSgv1NXj5y9m7P JzkhT/+UytTvE2n3wbNNt8N7DSdXScZA9qOKp7UbopqQm/olz/lM4+kr4SpdMHDJVz5Cq6txQZ0sZ QjHW8=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1fldRo-0003lr-7V; Fri, 03 Aug 2018 17:01:04 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id F41AD1123AA1; Fri, 3 Aug 2018 18:01:03 +0100 (BST) From: Mark Brown To: Gustavo A. R. Silva In-Reply-To: Message-Id: <20180803170103.F41AD1123AA1@debutante.sirena.org.uk> Date: Fri, 3 Aug 2018 18:01:03 +0100 (BST) Cc: alsa-devel@alsa-project.org, "Gustavo A. R. Silva" , Takashi Iwai , linux-kernel@vger.kernel.org, Liam Girdwood , Peter Ujfalusi , Mark Brown , linux-omap@vger.kernel.org, Jarkko Nikula Subject: [alsa-devel] Applied "ASoC: omap-dmic: Mark expected switch fall-throughs" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: omap-dmic: Mark expected switch fall-throughs has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From a773c3b6be185d171e2755ac715e8b1ea099ebbc Mon Sep 17 00:00:00 2001 From: "Gustavo A. R. Silva" Date: Fri, 3 Aug 2018 11:31:48 -0500 Subject: [PATCH] ASoC: omap-dmic: Mark expected switch fall-throughs In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 1468847 ("Missing break in switch") Addresses-Coverity-ID: 1468849 ("Missing break in switch") Signed-off-by: Gustavo A. R. Silva Signed-off-by: Mark Brown --- sound/soc/omap/omap-dmic.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.18.0 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/omap/omap-dmic.c b/sound/soc/omap/omap-dmic.c index 51dd7c65096b..fe966272bd0c 100644 --- a/sound/soc/omap/omap-dmic.c +++ b/sound/soc/omap/omap-dmic.c @@ -213,8 +213,10 @@ static int omap_dmic_dai_hw_params(struct snd_pcm_substream *substream, switch (channels) { case 6: dmic->ch_enabled |= OMAP_DMIC_UP3_ENABLE; + /* fall through */ case 4: dmic->ch_enabled |= OMAP_DMIC_UP2_ENABLE; + /* fall through */ case 2: dmic->ch_enabled |= OMAP_DMIC_UP1_ENABLE; break;