From patchwork Wed Jun 16 06:36:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen \(ThunderTown\)" X-Patchwork-Id: 461353 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp312803jae; Tue, 15 Jun 2021 23:37:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJywB4af3i3SacuE5iO5fXNcJ/ThZaQQ/ONUd3tKvA7DSXtoSHZDVycR1mWReuv82hln8r+i X-Received: by 2002:a17:906:2510:: with SMTP id i16mr3617919ejb.218.1623825474821; Tue, 15 Jun 2021 23:37:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623825474; cv=none; d=google.com; s=arc-20160816; b=JtVbskrWFwyD9SLnKF/B7XT1OOIiknm8F8XvBBj+mnLRQ+p8h2gq+Z4msWC0WFvITF UbQ8SbSnyn0WemcICEc9Y5SthSivs4JltTTwOS2GUjv4Ete6Va6BiO/vD4RcPhJhRlqH d0n4lnkZ8303bruN1/+c3+KASNykVsCYa752iSYvHKtkuL2Ppu0ZWzh0dQ2Emmk+MfZ9 G/07xANj8dYfqMg17k7oy0nPAqBmNmjzVNXpZ+YR/gwMe4B6YNs+STuItdTGaKwwAHJd RUr4zeERf5SXXjxnD70w+rtSs1LlWxRrj3crS/5xLazl7aSOi1Cjb8yEBks52qmT8eTO VFZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=5i4afVUNwLChb6pLWulZIU4iajV+yGqUhSYjr0H/k/0=; b=kzV6p5Mv5vBy3XT8UnuYx1HWmFbynFN3/ek1aeTHKFSCBZ7JDC8KuiW0222fBfQ6hi /jzBpelH/BmiiXfmmhD+aTl5Sm6KIjDP3wSiGPzjg1AaFQhyIKrp5vZYp6OcoESr74/4 iUBztygmf0nKG8ejLTZKAU3UGaWsCoh5yOJOM1S1Nwx495N0sgEY3OnZY6hZXujaWGt6 eMRwqMp/6/pWI8Kz4qEXeNJJnvYt9uJjS2hTmZIJxKlH5r+on6tIOWFApjGmNNKsCx/p 7wCqT+sLG0j+YTXGfvaw7XVyTKc0hRAIfFFhmKxDnc8YfOKXyNS7js3TR8V8zsA/N5eu cnsg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z16si1386040edb.194.2021.06.15.23.37.54 for ; Tue, 15 Jun 2021 23:37:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231258AbhFPGj6 (ORCPT ); Wed, 16 Jun 2021 02:39:58 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:7322 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230370AbhFPGj6 (ORCPT ); Wed, 16 Jun 2021 02:39:58 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.56]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4G4b4J0rsLz6y9q; Wed, 16 Jun 2021 14:33:52 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:37:51 +0800 Received: from thunder-town.china.huawei.com (10.174.179.0) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:37:50 +0800 From: Zhen Lei To: Vishal Bhakta , VMware PV-Drivers , Karan Tilak Kumar , "Sesidhar Baddela" , Nilesh Javali , GR-QLogic-Storage-Upstream , "Adaptec OEM Raid Solutions" , Brian King , Satish Kharat , Hannes Reinecke , "Manish Rangankar" , Adam Radford , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi CC: Zhen Lei Subject: [PATCH v2 01/20] scsi: zorro_esp: remove unnecessary oom message Date: Wed, 16 Jun 2021 14:36:55 +0800 Message-ID: <20210616063714.778-2-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 In-Reply-To: <20210616063714.778-1-thunder.leizhen@huawei.com> References: <20210616063714.778-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.179.0] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message Remove it can help us save a bit of memory. Signed-off-by: Zhen Lei --- drivers/scsi/zorro_esp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.26.0.106.g9fadedd diff --git a/drivers/scsi/zorro_esp.c b/drivers/scsi/zorro_esp.c index 928c8adf5cb33f4..b03870b4d8dcaaf 100644 --- a/drivers/scsi/zorro_esp.c +++ b/drivers/scsi/zorro_esp.c @@ -727,10 +727,8 @@ static int zorro_esp_probe(struct zorro_dev *z, pr_info("%s found at address 0x%lx.\n", zdd->name, board); zep = kzalloc(sizeof(*zep), GFP_KERNEL); - if (!zep) { - pr_err("Can't allocate device private data!\n"); + if (!zep) return -ENOMEM; - } /* let's figure out whether we have a Zorro II or Zorro III board */ if ((z->rom.er_Type & ERT_TYPEMASK) == ERT_ZORROIII) { From patchwork Wed Jun 16 06:36:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen \(ThunderTown\)" X-Patchwork-Id: 461354 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp312846jae; Tue, 15 Jun 2021 23:37:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzXeuw9eIs7TH+hnYypwKRNOBqslj6/Kz+DcgMiGC8tdOwOCv8OwHM62cXncWsVWvT+u+o X-Received: by 2002:a05:6402:1c88:: with SMTP id cy8mr2313711edb.80.1623825477015; Tue, 15 Jun 2021 23:37:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623825477; cv=none; d=google.com; s=arc-20160816; b=kp9hwEHkrbOVejB38+AidIAdD+m6K+XEBfN/L1zuWSaPqshnV1Cd+PRfPm5SdGKK1c DgwRzAuJ+Gcuze57Sc1hUrJhGThqNCk64oX9d5hfRGuaRdDv0NUMpjJItHfWPiOAQblP q299YS2JPbMjeSEqO6cWOFJCLZtoCezBOTyzXqKPplAa77LJMpE5AmOkCyH2pjpCAjPq mCyLrl7B+HgM5J5aiZ//bSVekiA2KQI+rq1RZ9BKTtBhyymClwnwNgraj2MgAy4IPVFb UqOculxxeYMnbSEveZ5GQomOhtagdtj7bCZvQf+Braq5IFJEUByyXBeCcrbT8Syatizs bkuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=8O0RxogJNDY9aWo4kG/KZm2n3VUqAynjCFfai7Gk1Ks=; b=aQ5uQMNwbEJnmhG9/MM8n2NYWwrB7P3MBL97y1Od3XOgtwRzr9hr1lbBPIuNW/Z46X +SVVazLswnT3bc6LYxFL/w8hUGZxI9mbrIV6N19nvaY5E5w36LEjbXjOM7emCOZvTVUh oELpt6/cmr/y8eIHLdc6NurWqseDitIGMJfKPHrpFMggxMxE9tMzW/vjhPhQsBrma2nr Ty5Ng9g+LLnunzy1exCYlYbq4rq2s8Wbk+M2Ydhix6htOVMGxfs9IOVeGkeeDwomEkyE Binn2TdGot5r0GqQ+SiRc0HOcCY6p5hvB4bhb34hA3OWGspM4uASR0MRXq+zRDeoxOmf MgVQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z16si1386040edb.194.2021.06.15.23.37.56 for ; Tue, 15 Jun 2021 23:37:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231391AbhFPGkA (ORCPT ); Wed, 16 Jun 2021 02:40:00 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:4795 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230508AbhFPGj6 (ORCPT ); Wed, 16 Jun 2021 02:39:58 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4G4b365ZTqzWssm; Wed, 16 Jun 2021 14:32:50 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:37:51 +0800 Received: from thunder-town.china.huawei.com (10.174.179.0) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:37:51 +0800 From: Zhen Lei To: Vishal Bhakta , VMware PV-Drivers , Karan Tilak Kumar , "Sesidhar Baddela" , Nilesh Javali , GR-QLogic-Storage-Upstream , "Adaptec OEM Raid Solutions" , Brian King , Satish Kharat , Hannes Reinecke , "Manish Rangankar" , Adam Radford , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi CC: Zhen Lei Subject: [PATCH v2 02/20] scsi: zorro7xx: remove unnecessary oom message Date: Wed, 16 Jun 2021 14:36:56 +0800 Message-ID: <20210616063714.778-3-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 In-Reply-To: <20210616063714.778-1-thunder.leizhen@huawei.com> References: <20210616063714.778-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.179.0] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message Remove it can help us save a bit of memory. Signed-off-by: Zhen Lei --- drivers/scsi/zorro7xx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.26.0.106.g9fadedd diff --git a/drivers/scsi/zorro7xx.c b/drivers/scsi/zorro7xx.c index 27b9e2baab1a61c..1ecbb603897a27f 100644 --- a/drivers/scsi/zorro7xx.c +++ b/drivers/scsi/zorro7xx.c @@ -96,10 +96,8 @@ static int zorro7xx_init_one(struct zorro_dev *z, } hostdata = kzalloc(sizeof(struct NCR_700_Host_Parameters), GFP_KERNEL); - if (!hostdata) { - printk(KERN_ERR "zorro7xx: Failed to allocate host data\n"); + if (!hostdata) goto out_release; - } /* Fill in the required pieces of hostdata */ if (ioaddr > 0x01000000) From patchwork Wed Jun 16 06:36:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen \(ThunderTown\)" X-Patchwork-Id: 461355 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp312854jae; Tue, 15 Jun 2021 23:37:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxg/qS7xyQuDEwj9WXDGXPkr2ske2hXdkiq4+fC+CqKQpmMF2BycZYFWtrDpIuuMbOk+yV5 X-Received: by 2002:a17:906:4a17:: with SMTP id w23mr3704285eju.460.1623825477645; Tue, 15 Jun 2021 23:37:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623825477; cv=none; d=google.com; s=arc-20160816; b=wMr4+dRMX4f775pdjj4eICWfKCo1fgGAaDyHRTNdOGRiUEfCf1knix5nX1JEEMFwdH 31Ck6tJyMAe5ln7ktci6BwVC9A9Aj68lI2YcHSghnQ6gyO6lQe1nkxVMg4KCHXJg5Zo2 gGM/sikEQDidMZWFLHAcYmCWy5ZEma0pA2JnLv1zD5lmPNNE+ghN9FHUUM9jNMuZDMxv WlwBpVqHbTyAnhH5s3g2w3gLi0ulSWuJ3wrq828d7fBrTrD7rnfgZ4tbIXl6hnSSxotV AowazCk5C46Nh9CBrASjhlrasyWT3IM8+Msc+YadYsAyvWYV4COLZVs/bTPiefMEej2s J6AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=q0Du4d7V8lktGmUS6mG4NwErGeIecMsS574/Yviaa0k=; b=DcoxD64RuDVnxhJgvUELVeYcazSaRfyiVGBhtHV6zoqzgbirkm0h6I9KH7vcle1+qo MbuaU2kKqktYB6drrKf9h0iHVJDsjUfupkCkjhz//oFKtGrpzakfeWpu3KdjUHnJI5KS Q7W3mo851JaOWFi6mxmBUavZWx4yOOYhlnyQcBj1gxkar8IoT5oFo2DR0N4h6lmd3lMc M0YgW2oypATg9yAdFFX4yKDKvH/I5WhSKG/GCDQ8zXIuz2b1o/AkQnhUpWLdxFXjzSz3 ZWWeYDgfwZtDNfjPp9nU853F8gdjbCCgJDgAW3ElMOje8kJ0/MyZMiwk/LWqzcNbiOlk k+Yw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z16si1386040edb.194.2021.06.15.23.37.57 for ; Tue, 15 Jun 2021 23:37:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231400AbhFPGkC (ORCPT ); Wed, 16 Jun 2021 02:40:02 -0400 Received: from szxga08-in.huawei.com ([45.249.212.255]:7288 "EHLO szxga08-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230370AbhFPGkA (ORCPT ); Wed, 16 Jun 2021 02:40:00 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4G4b375lqBz1BMSW; Wed, 16 Jun 2021 14:32:51 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:37:52 +0800 Received: from thunder-town.china.huawei.com (10.174.179.0) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:37:51 +0800 From: Zhen Lei To: Vishal Bhakta , VMware PV-Drivers , Karan Tilak Kumar , "Sesidhar Baddela" , Nilesh Javali , GR-QLogic-Storage-Upstream , "Adaptec OEM Raid Solutions" , Brian King , Satish Kharat , Hannes Reinecke , "Manish Rangankar" , Adam Radford , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi CC: Zhen Lei Subject: [PATCH v2 03/20] scsi: bvme6000: remove unnecessary oom message Date: Wed, 16 Jun 2021 14:36:57 +0800 Message-ID: <20210616063714.778-4-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 In-Reply-To: <20210616063714.778-1-thunder.leizhen@huawei.com> References: <20210616063714.778-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.179.0] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message Remove it can help us save a bit of memory. Signed-off-by: Zhen Lei --- drivers/scsi/bvme6000_scsi.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) -- 2.26.0.106.g9fadedd diff --git a/drivers/scsi/bvme6000_scsi.c b/drivers/scsi/bvme6000_scsi.c index 8d72b25535c5e72..fec971bc9a7d7c7 100644 --- a/drivers/scsi/bvme6000_scsi.c +++ b/drivers/scsi/bvme6000_scsi.c @@ -45,11 +45,8 @@ bvme6000_probe(struct platform_device *dev) goto out; hostdata = kzalloc(sizeof(struct NCR_700_Host_Parameters), GFP_KERNEL); - if (!hostdata) { - printk(KERN_ERR "bvme6000-scsi: " - "Failed to allocate host data\n"); + if (!hostdata) goto out; - } /* Fill in the required pieces of hostdata */ hostdata->base = (void __iomem *)BVME_NCR53C710_BASE; From patchwork Wed Jun 16 06:36:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen \(ThunderTown\)" X-Patchwork-Id: 461356 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp312861jae; Tue, 15 Jun 2021 23:37:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxcxB5tDVcbVdX9kFvs7JafcTiJ1kfJOaIZ53YOK38g//+D0vDTUgZfLdLhmyDGfOrNJAG9 X-Received: by 2002:a05:6402:885:: with SMTP id e5mr2359502edy.248.1623825477994; Tue, 15 Jun 2021 23:37:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623825477; cv=none; d=google.com; s=arc-20160816; b=BhvxCYBwid9m3Idba3L0ljVvnh37zVucZRbtBm1Rlkir0UMcsLciT3952abX7HLVf2 Eelu/GvkDy7PVMan0QIgpFbCP7Hv6WWRb/4whBgSWfEUU8aquFwqjfT++Yq1BGQD06TY ALcwjM1j1gFi9UwpAKKHM81pA0mqgH4fMDKVREiLajd5oAG9Co/bgztrIfuM756itwk1 vLmc0OSJWFAYVgyTFhm6H/XMT1qsxrE08i04ug9JLz8a1KwnHdNF1/RRA46a7ys+Gjp0 VTbei+aqXxMmSM+QbSGqUjJrO+odIsju7GdOTvgAGfAmOwAeBNOT6xqDrodhlQuAAVr5 HGlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=G21J6JnLifLbR1uduxQdwxTY2nuYrFg9UkgEIhNI4WE=; b=Tiy4jQB8q7MkJg31yGaCfqrYREodxB8UpbsgEedxGlQRl71zfcOktt+xaFVgYnMeQb KrozPHDvJzNzk0ny+x0bSc4LX6Yy52rxkq+G+YmcN2anRxe1MKH1ieCmnJpVpcNcuvRD LNU5ab/YrlRU9JpPHtylZhvJ8Cwm7beXTBY5+Hobo++PojsziRdlWrm3ppIoklrma+1E ekF4WuKgjfDJF4CFPCrMUEhNZdSUThsf3dnzbhlfBRHeNMdLotz8sHE+aoG9razVBCUH T1de1c37fXKcPOjp9qNHZTb/Yi1aORqEOLIER7uw4fwvuoLs3M1Uvb7ijl1wPtVDNjxR U5RA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z16si1386040edb.194.2021.06.15.23.37.57 for ; Tue, 15 Jun 2021 23:37:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231344AbhFPGkC (ORCPT ); Wed, 16 Jun 2021 02:40:02 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:4928 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231290AbhFPGkA (ORCPT ); Wed, 16 Jun 2021 02:40:00 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4G4b5J08jfz70KQ; Wed, 16 Jun 2021 14:34:44 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:37:53 +0800 Received: from thunder-town.china.huawei.com (10.174.179.0) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:37:52 +0800 From: Zhen Lei To: Vishal Bhakta , VMware PV-Drivers , Karan Tilak Kumar , "Sesidhar Baddela" , Nilesh Javali , GR-QLogic-Storage-Upstream , "Adaptec OEM Raid Solutions" , Brian King , Satish Kharat , Hannes Reinecke , "Manish Rangankar" , Adam Radford , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi CC: Zhen Lei Subject: [PATCH v2 04/20] scsi: vmw_pvscsi: remove unnecessary oom message Date: Wed, 16 Jun 2021 14:36:58 +0800 Message-ID: <20210616063714.778-5-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 In-Reply-To: <20210616063714.778-1-thunder.leizhen@huawei.com> References: <20210616063714.778-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.179.0] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message Remove it can help us save a bit of memory. Signed-off-by: Zhen Lei --- drivers/scsi/vmw_pvscsi.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) -- 2.26.0.106.g9fadedd diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c index ce1ba1b936298c7..78102969e9fe692 100644 --- a/drivers/scsi/vmw_pvscsi.c +++ b/drivers/scsi/vmw_pvscsi.c @@ -1304,10 +1304,8 @@ static u32 pvscsi_get_max_targets(struct pvscsi_adapter *adapter) dev = pvscsi_dev(adapter); config_page = dma_alloc_coherent(&adapter->dev->dev, PAGE_SIZE, &configPagePA, GFP_KERNEL); - if (!config_page) { - dev_warn(dev, "vmw_pvscsi: failed to allocate memory for config page\n"); + if (!config_page) goto exit; - } BUG_ON(configPagePA & ~PAGE_MASK); /* Fetch config info from the device. */ @@ -1479,7 +1477,6 @@ static int pvscsi_probe(struct pci_dev *pdev, const struct pci_device_id *id) adapter->cmd_map = kcalloc(adapter->req_depth, sizeof(struct pvscsi_ctx), GFP_KERNEL); if (!adapter->cmd_map) { - printk(KERN_ERR "vmw_pvscsi: failed to allocate memory.\n"); error = -ENOMEM; goto out_reset_adapter; } From patchwork Wed Jun 16 06:36:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen \(ThunderTown\)" X-Patchwork-Id: 461357 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp312870jae; Tue, 15 Jun 2021 23:37:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxIr/tOhOPBDB0xtvisGAHEMrZu89paX362fnbb1y98A04x/7o4IFXQk32jnpEOpWcfWMBI X-Received: by 2002:a17:906:b0c6:: with SMTP id bk6mr3663989ejb.97.1623825478346; Tue, 15 Jun 2021 23:37:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623825478; cv=none; d=google.com; s=arc-20160816; b=pg2wrVujfZqGcrLScGIxS3Jxd5B6fzPoUsnf9iiKLzM9zU8Js7xQgHRL181DkROEm1 gI9+0x/DufAXLFwXe3qPNURdYSlEVWEKv9lm7TxmbnITtjgatIfxXXSs+3kkU1GCxLOD BwzCEy0zLeE6gqdfNyqvAEdFjGW7vIG7THfXWLI74rBNiz7L0Iy9divVzYmu4/se4bgx dU4zRNIAgUJto0kaP6ezOFEwkaa5lbDWSbqvYXN+I19Nf8vwygkowo6jI8pmE0lEKR9M DYe+EhPcQXINzg5KaairzyrPDloBJP8K99aKnKa8HuquPI2yk0Frs+0aKQXV+hxjQ+TC DS7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=0ja+SEjlfoMy/q17SwobkazlKTHLMnrOpmZ18MTDGSg=; b=nPuc6dENRslfTfG/olbmSTC8dldy1O7TiFPeGcZNALgWGUGSXRxmQbIz2klZWJ0VYX Rd2Zefj6uPvn4d1mbjA3DKOZQE/lhVXojeCrgDwg9EJt9QuurVsNkgdOiYmZkxZdBi9g eCvjFIiv8/FdWD9IYUPo60qrn67/XM9H8EQ1yV/A5P8vLfUT0roB4mRx1wxiSMqT3Igu WOrGzOK8ztJU2cNViLUli4gki3b34yNQCZT8yG1yMBihEa9edHkaHKALsrDbcHhYyJJg 4MOTD2otjQeVD54hxoQ4BQHRbt/lReqkbuH/SEXti2VsQYTSI31sY9Tsy2zykfDDoxvx 3/qQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z16si1386040edb.194.2021.06.15.23.37.58 for ; Tue, 15 Jun 2021 23:37:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231422AbhFPGkC (ORCPT ); Wed, 16 Jun 2021 02:40:02 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:4929 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231383AbhFPGkB (ORCPT ); Wed, 16 Jun 2021 02:40:01 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4G4b5J60YBz70Md; Wed, 16 Jun 2021 14:34:44 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:37:54 +0800 Received: from thunder-town.china.huawei.com (10.174.179.0) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:37:53 +0800 From: Zhen Lei To: Vishal Bhakta , VMware PV-Drivers , Karan Tilak Kumar , "Sesidhar Baddela" , Nilesh Javali , GR-QLogic-Storage-Upstream , "Adaptec OEM Raid Solutions" , Brian King , Satish Kharat , Hannes Reinecke , "Manish Rangankar" , Adam Radford , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi CC: Zhen Lei Subject: [PATCH v2 05/20] snic: remove unnecessary oom message Date: Wed, 16 Jun 2021 14:36:59 +0800 Message-ID: <20210616063714.778-6-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 In-Reply-To: <20210616063714.778-1-thunder.leizhen@huawei.com> References: <20210616063714.778-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.179.0] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message Remove it can help us save a bit of memory. Signed-off-by: Zhen Lei --- drivers/scsi/snic/vnic_wq.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) -- 2.26.0.106.g9fadedd diff --git a/drivers/scsi/snic/vnic_wq.c b/drivers/scsi/snic/vnic_wq.c index 1e91d432089e805..bcf05057861e1fc 100644 --- a/drivers/scsi/snic/vnic_wq.c +++ b/drivers/scsi/snic/vnic_wq.c @@ -48,11 +48,8 @@ static int vnic_wq_alloc_bufs(struct vnic_wq *wq) for (i = 0; i < blks; i++) { wq->bufs[i] = kzalloc(VNIC_WQ_BUF_BLK_SZ, GFP_ATOMIC); - if (!wq->bufs[i]) { - pr_err("Failed to alloc wq_bufs\n"); - + if (!wq->bufs[i]) return -ENOMEM; - } } for (i = 0; i < blks; i++) { From patchwork Wed Jun 16 06:37:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen \(ThunderTown\)" X-Patchwork-Id: 461358 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp312873jae; Tue, 15 Jun 2021 23:37:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJweDH2x3dsLRtz9hkIJPxFcV9CU1Hl5dsT4vztnmWaDTIkE308tkNksCU3g3Ilwp4ouSrfD X-Received: by 2002:a17:906:3884:: with SMTP id q4mr3753014ejd.66.1623825478739; Tue, 15 Jun 2021 23:37:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623825478; cv=none; d=google.com; s=arc-20160816; b=Akz+lCOX6scbkE6QRUuQL++EJPFR2ZcgcGI/qDjEKi/Ui0ggN2vlmDR6Ftu50DHWEy zB0v0urWZrfykGzIvJ+6ik0xBA0qxK7U9rWyrtZjC3awGGgZdsJ+zctqb3AqAQIp16Lh 2axjrTlww7Xr/lvCaX2G20sAClAyjf9X4cBNFHdTNpY+5609uNcM7vQj5i9xK9ERKL4P HhYIVBHXIelcl19Su59qNcThv4xGAxd9b4x4uvLZwOT62W94sjnoJoTfJhlMkCLrF671 uqtARs/wO+6rxtDAu1bScFXXoSYLNnvXwDC0IWRYBF/N8+Lt9T30oETFyXA0NqtDQJVE qA+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=v1SpQjrN4qsESVQlTtQNhRMKSOxXhxYSZyN7B+iDNh0=; b=XXMPAmjgWSOCAZ25dTFZVwHWIRxFjq8UG8hKWqTSjq9q0ZJRal/QCLSt8gnZU7td1l HqHgBHtUqRD57PpfRcbiqXncWNtPVZn2F9/hvS1P1QJxPytWeB87F14qvwyCIZW9Fs3W SgcSp6KrQbt07SS+XcUcCU40r31N5TFnsumCQbmtNHBTqdpdZpzfvgXVmMnRYZbPKRQj S6hXLbN32qG50FVQUISazyGePyezon7T9GmsI1sHaAez4qlK/oVSDBN1NZN2wHM5zTAk q6wuicjoiIO3t3Mimcp+VV+MzqvYiknaBumii1STuDNrzlHgr93ApOd5/sW5u6ls/0wf Uoxw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z16si1386040edb.194.2021.06.15.23.37.58 for ; Tue, 15 Jun 2021 23:37:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231441AbhFPGkD (ORCPT ); Wed, 16 Jun 2021 02:40:03 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:10087 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231409AbhFPGkC (ORCPT ); Wed, 16 Jun 2021 02:40:02 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4G4b5c04drzZf6V; Wed, 16 Jun 2021 14:35:00 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:37:55 +0800 Received: from thunder-town.china.huawei.com (10.174.179.0) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:37:54 +0800 From: Zhen Lei To: Vishal Bhakta , VMware PV-Drivers , Karan Tilak Kumar , "Sesidhar Baddela" , Nilesh Javali , GR-QLogic-Storage-Upstream , "Adaptec OEM Raid Solutions" , Brian King , Satish Kharat , Hannes Reinecke , "Manish Rangankar" , Adam Radford , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi CC: Zhen Lei Subject: [PATCH v2 06/20] scsi: devinfo: remove unnecessary oom message Date: Wed, 16 Jun 2021 14:37:00 +0800 Message-ID: <20210616063714.778-7-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 In-Reply-To: <20210616063714.778-1-thunder.leizhen@huawei.com> References: <20210616063714.778-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.179.0] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message Remove it can help us save a bit of memory. Signed-off-by: Zhen Lei --- drivers/scsi/scsi_devinfo.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.26.0.106.g9fadedd diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c index d33355ab6e14505..a8adbbbfddba44b 100644 --- a/drivers/scsi/scsi_devinfo.c +++ b/drivers/scsi/scsi_devinfo.c @@ -357,10 +357,8 @@ int scsi_dev_info_list_add_keyed(int compatible, char *vendor, char *model, return PTR_ERR(devinfo_table); devinfo = kmalloc(sizeof(*devinfo), GFP_KERNEL); - if (!devinfo) { - printk(KERN_ERR "%s: no memory\n", __func__); + if (!devinfo) return -ENOMEM; - } scsi_strcpy_devinfo("vendor", devinfo->vendor, sizeof(devinfo->vendor), vendor, compatible); From patchwork Wed Jun 16 06:37:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen \(ThunderTown\)" X-Patchwork-Id: 461359 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp312880jae; Tue, 15 Jun 2021 23:37:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyu9c2dwDFg0iTLI4IfU3aJfltN0kLhmuTkatN4AEL4lJaKFK2OmCS7FtWNCrgAgLH4U+Mw X-Received: by 2002:a17:906:1c4e:: with SMTP id l14mr3646550ejg.172.1623825479069; Tue, 15 Jun 2021 23:37:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623825479; cv=none; d=google.com; s=arc-20160816; b=Wml88VVZ47rchg7EMuMEop7+v7n8JD9Wn9sl6z+qO90/UNqr4AGQOFRSQoHJ2yFHHp WGhOQRmxC0usabaIWG4viG7d4TnxwkTNg435IzLlyxr7w/y/evWpc3VCfAOmx0HIPcZ6 wOYEb5Ori0Tl3HpctrUG2nzY+kzjaJoM9SKzCSFgQQc8DnvYB/yOL5mJHE9HQUWjXudB BY02NvEnIu8XM5DrA6sdWQrVAdR4uHyB0DfG+uh1vf53Jgv3UkeE754z+REkP1cMBm2j iG8V3JRa0SNM9+TjqynB0GK5bRZRASDrxsM1gW4GtISS4mX4JRnyj6J4+9T8q645g6bH wd9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=98sI03NMqwlHyVYkpzQrazhFhteRKIYncCyIHwbVeP4=; b=kyJs8rpyGX3LP+UbM7djVjaq/YlVerIXHmIFj/JnhF/p0VdAlY0CWcDues2Ux62+wq t03QHjzI67mxDezqnoCnYWCsf0YhEB/Fg4lqf162xQjgTHja3zE+vUSGawGPzgGPntN3 lIOXIeFAzK6mnsxKwo5iWrhtCKRzWSOFMqTKeLweqAUmainSrzW54ToF2i2LKjCQX1hV JrgcREUsWoOf5s21sGp5ZQ60Ij9vbzWVXXTubWaqtO2ntKbrWldNRIvUwxQp13mvHCVc sQbiLLLB/K4hl5aT8sBJ2lLZ/PNUrh/qk/ZthJvEzSjP9j0Be4hqxZcKQUF6Vaa45//B 0Zjg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z16si1386040edb.194.2021.06.15.23.37.58 for ; Tue, 15 Jun 2021 23:37:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231446AbhFPGkD (ORCPT ); Wed, 16 Jun 2021 02:40:03 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:7323 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230508AbhFPGkC (ORCPT ); Wed, 16 Jun 2021 02:40:02 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4G4b4P0sjFz6y9v; Wed, 16 Jun 2021 14:33:57 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:37:56 +0800 Received: from thunder-town.china.huawei.com (10.174.179.0) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:37:55 +0800 From: Zhen Lei To: Vishal Bhakta , VMware PV-Drivers , Karan Tilak Kumar , "Sesidhar Baddela" , Nilesh Javali , GR-QLogic-Storage-Upstream , "Adaptec OEM Raid Solutions" , Brian King , Satish Kharat , Hannes Reinecke , "Manish Rangankar" , Adam Radford , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi CC: Zhen Lei Subject: [PATCH v2 07/20] scsi: tcm_qla2xxx: remove unnecessary oom message Date: Wed, 16 Jun 2021 14:37:01 +0800 Message-ID: <20210616063714.778-8-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 In-Reply-To: <20210616063714.778-1-thunder.leizhen@huawei.com> References: <20210616063714.778-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.179.0] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message Remove it can help us save a bit of memory. Signed-off-by: Zhen Lei --- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) -- 2.26.0.106.g9fadedd diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c b/drivers/scsi/qla2xxx/tcm_qla2xxx.c index 03de1bcf1461d77..d537a7bc27f08b0 100644 --- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c +++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c @@ -1035,10 +1035,8 @@ static struct se_portal_group *tcm_qla2xxx_make_tpg(struct se_wwn *wwn, } tpg = kzalloc(sizeof(struct tcm_qla2xxx_tpg), GFP_KERNEL); - if (!tpg) { - pr_err("Unable to allocate struct tcm_qla2xxx_tpg\n"); + if (!tpg) return ERR_PTR(-ENOMEM); - } tpg->lport = lport; tpg->lport_tpgt = tpgt; /* @@ -1151,10 +1149,8 @@ static struct se_portal_group *tcm_qla2xxx_npiv_make_tpg(struct se_wwn *wwn, return ERR_PTR(-EINVAL); tpg = kzalloc(sizeof(struct tcm_qla2xxx_tpg), GFP_KERNEL); - if (!tpg) { - pr_err("Unable to allocate struct tcm_qla2xxx_tpg\n"); + if (!tpg) return ERR_PTR(-ENOMEM); - } tpg->lport = lport; tpg->lport_tpgt = tpgt; @@ -1653,10 +1649,8 @@ static struct se_wwn *tcm_qla2xxx_make_lport( return ERR_PTR(-EINVAL); lport = kzalloc(sizeof(struct tcm_qla2xxx_lport), GFP_KERNEL); - if (!lport) { - pr_err("Unable to allocate struct tcm_qla2xxx_lport\n"); + if (!lport) return ERR_PTR(-ENOMEM); - } lport->lport_wwpn = wwpn; tcm_qla2xxx_format_wwn(&lport->lport_name[0], TCM_QLA2XXX_NAMELEN, wwpn); @@ -1779,10 +1773,8 @@ static struct se_wwn *tcm_qla2xxx_npiv_make_lport( return ERR_PTR(-EINVAL); lport = kzalloc(sizeof(struct tcm_qla2xxx_lport), GFP_KERNEL); - if (!lport) { - pr_err("Unable to allocate struct tcm_qla2xxx_lport for NPIV\n"); + if (!lport) return ERR_PTR(-ENOMEM); - } lport->lport_npiv_wwpn = npiv_wwpn; lport->lport_npiv_wwnn = npiv_wwnn; sprintf(lport->lport_naa_name, "naa.%016llx", (unsigned long long) npiv_wwpn); From patchwork Wed Jun 16 06:37:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen \(ThunderTown\)" X-Patchwork-Id: 461360 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp312937jae; Tue, 15 Jun 2021 23:38:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxzNI2nzYcX/x5wdhOw3gtEBZRBUqnCMWwWJ2ssFzk6HO2dY+MPrOSC1SCdfc1zA0blNwcD X-Received: by 2002:a05:6402:26ce:: with SMTP id x14mr2341596edd.104.1623825484030; Tue, 15 Jun 2021 23:38:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623825484; cv=none; d=google.com; s=arc-20160816; b=d445QV3UTvTzaJbHyQ2GHg82LHx9UhSZzYU4Ax7d+EsDVDmozuKBR4q3nIDoSnsolY 92zSeuVLfYfUG39IlwjioAw2tqOmCrEXhtB4+/R9H5+KICBZudveam8Cel+O/gglsp3h 0Kceqmkm2o1ROv2loh/G3OEhLxPhGzYXetAGIvX+RcSBWZDJBe3jSQsN27b+Zdqz5Tq7 1k8zL/e4sn3A5TOCigAqz9YtBPVBVqg4D6i0QVNrTNzo1F6qAps2Rv+5o8quLt0rv+4r Is0hp/w2qWUXR3JnzNJglzpOdto/p/iGTCJA93fT+P49VDISFCx08vFUmNkyvOxRV5Hr nTNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=qljcwFQV78Y88AC4hpvoOlCLZKrb5J3a93AnnzZhdsY=; b=q1hIBoXXx8Ms/pp/9fGu0O57Rcvzhie2HTrZ06E449CGIAcVqzurFQFl2QEZ87RjJ+ 1g+A57IdZirG/afGRbJxdLgeAv5n6G16dfgQhvRJ0N0z6B9yT+CyYrnO21rArzpwodJP KcjHI7gCNOgs3EYvJwQdzJs00jGP/zMmIa3ZOGZ7PA6IHM6HFEif6XElaizqUYPaHrJH F4F98GkP09vO10VTBAYgxcu5VlEbYPCzWUVTn+9aorC/vjQDPYTG0e5Y9RnETgI/Aryl tOYoNQWw4hvAlkhmvG8tyrwY4L2AhGjKZZ2sdkJytmJLMa39xNX4UkxZkyhHc66N9swz gSKQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z16si1386040edb.194.2021.06.15.23.38.03 for ; Tue, 15 Jun 2021 23:38:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231532AbhFPGkI (ORCPT ); Wed, 16 Jun 2021 02:40:08 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:4930 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231383AbhFPGkD (ORCPT ); Wed, 16 Jun 2021 02:40:03 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4G4b5M2PVNz70MW; Wed, 16 Jun 2021 14:34:47 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:37:56 +0800 Received: from thunder-town.china.huawei.com (10.174.179.0) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:37:56 +0800 From: Zhen Lei To: Vishal Bhakta , VMware PV-Drivers , Karan Tilak Kumar , "Sesidhar Baddela" , Nilesh Javali , GR-QLogic-Storage-Upstream , "Adaptec OEM Raid Solutions" , Brian King , Satish Kharat , Hannes Reinecke , "Manish Rangankar" , Adam Radford , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi CC: Zhen Lei Subject: [PATCH v2 08/20] scsi: pmcraid: remove unnecessary oom message Date: Wed, 16 Jun 2021 14:37:02 +0800 Message-ID: <20210616063714.778-9-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 In-Reply-To: <20210616063714.778-1-thunder.leizhen@huawei.com> References: <20210616063714.778-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.179.0] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message Remove it can help us save a bit of memory. Signed-off-by: Zhen Lei --- drivers/scsi/pmcraid.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) -- 2.26.0.106.g9fadedd diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c index bffd9a9349e7245..4754e72babc82cf 100644 --- a/drivers/scsi/pmcraid.c +++ b/drivers/scsi/pmcraid.c @@ -3601,11 +3601,8 @@ static long pmcraid_ioctl_passthrough( buffer_size = sizeof(struct pmcraid_passthrough_ioctl_buffer); buffer = kmalloc(buffer_size, GFP_KERNEL); - - if (!buffer) { - pmcraid_err("no memory for passthrough buffer\n"); + if (!buffer) return -ENOMEM; - } request_offset = offsetof(struct pmcraid_passthrough_ioctl_buffer, request_buffer); @@ -3903,11 +3900,8 @@ static long pmcraid_chr_ioctl( int retval = -ENOTTY; hdr = kmalloc(sizeof(struct pmcraid_ioctl_header), GFP_KERNEL); - - if (!hdr) { - pmcraid_err("failed to allocate memory for ioctl header\n"); + if (!hdr) return -ENOMEM; - } retval = pmcraid_check_ioctl_buffer(cmd, argp, hdr); From patchwork Wed Jun 16 06:37:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen \(ThunderTown\)" X-Patchwork-Id: 461361 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp312947jae; Tue, 15 Jun 2021 23:38:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwxQgrAyRKSZs5wQXtbJhbcKmy6ymcv8ONnea65orYwwQCJArjkT0rZ1Wl+JfyiPezqvIY2 X-Received: by 2002:aa7:cdc8:: with SMTP id h8mr2203457edw.323.1623825484630; Tue, 15 Jun 2021 23:38:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623825484; cv=none; d=google.com; s=arc-20160816; b=LwZIPKS8xcmVuveacjx8hGCur2OmzpeTn8mjW4chF+Tta2GJ71lcpr96+aJqfno031 FfcdiUPDo39EL0SQehX3/Myo227ZdeVasNHVShLmkOE4OUx3GLznkaPV2R2BTyt1yoov zlP/NL5uKrUftNS5ZC7IXYH0CEHOT5LHtaJIJiiRETS7XJxErQPnZj/wFulXcmyGH3pz eTGpqcVvwdeszkHp88HMnZEzx+5kgzr9vJkEMnll5P82ho8j2JF5C1NE+uiWlgibFzOX Pb1c2/9yDtmV0JEKc3Wb5s0ekeIIzWBqV66tPS+GQIeCdeWKQ4bMOCgezc3xgxUymhpx vjxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=2W0CcIAhPGlNQpFaTw1rplvc4QXu6fBA9yozf6kOW6E=; b=wvDgYq0PQj2L0S+msp9bw0V++b42oz9Wkkul5oqwyc8SXFyOTyP0mmMBT2OdN6X97H PA4oIlKqYWqYm29DJIYiJ3mDHpj7lEuZxYEle2WZDVF5A9FS9NDfWplgoieLPRTP99Yg h0BEOXsRiiEu3jUYtfDMf6BDOLENpaAYNML+huDrAxz9FpY+tcMxJNMZyFGyZFG1wzC2 7EuNS6PSOHnnlouaUAG5Wr01x3wrP5OlWDmTI0qYF4s4AD/EqWjFFV/yObGSuE8Od6Pd ulWkxdyutUd/48ppuDKFIjLT/IFh00OCSPhnQiOb6T1Z62MRu1/1PLUjXI5zcJVnpYwR GbDA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z16si1386040edb.194.2021.06.15.23.38.04 for ; Tue, 15 Jun 2021 23:38:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231548AbhFPGkJ (ORCPT ); Wed, 16 Jun 2021 02:40:09 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:4931 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230508AbhFPGkE (ORCPT ); Wed, 16 Jun 2021 02:40:04 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4G4b5N1074z70Mh; Wed, 16 Jun 2021 14:34:48 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:37:57 +0800 Received: from thunder-town.china.huawei.com (10.174.179.0) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:37:56 +0800 From: Zhen Lei To: Vishal Bhakta , VMware PV-Drivers , Karan Tilak Kumar , "Sesidhar Baddela" , Nilesh Javali , GR-QLogic-Storage-Upstream , "Adaptec OEM Raid Solutions" , Brian King , Satish Kharat , Hannes Reinecke , "Manish Rangankar" , Adam Radford , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi CC: Zhen Lei Subject: [PATCH v2 09/20] scsi: mvme16x: remove unnecessary oom message Date: Wed, 16 Jun 2021 14:37:03 +0800 Message-ID: <20210616063714.778-10-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 In-Reply-To: <20210616063714.778-1-thunder.leizhen@huawei.com> References: <20210616063714.778-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.179.0] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message Remove it can help us save a bit of memory. Signed-off-by: Zhen Lei --- drivers/scsi/mvme16x_scsi.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) -- 2.26.0.106.g9fadedd diff --git a/drivers/scsi/mvme16x_scsi.c b/drivers/scsi/mvme16x_scsi.c index 21d638299ab8e56..5c2f5aa572d5677 100644 --- a/drivers/scsi/mvme16x_scsi.c +++ b/drivers/scsi/mvme16x_scsi.c @@ -50,11 +50,8 @@ static int mvme16x_probe(struct platform_device *dev) } hostdata = kzalloc(sizeof(struct NCR_700_Host_Parameters), GFP_KERNEL); - if (hostdata == NULL) { - printk(KERN_ERR "mvme16x-scsi: " - "Failed to allocate host data\n"); + if (!hostdata) goto out; - } /* Fill in the required pieces of hostdata */ hostdata->base = (void __iomem *)0xfff47000UL; From patchwork Wed Jun 16 06:37:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen \(ThunderTown\)" X-Patchwork-Id: 461362 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp312965jae; Tue, 15 Jun 2021 23:38:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyNwPi7joIl0bVaj5KWHutmUGJ5NJvm20yuUXjlg30+BfEZ14M7C8hjIGv8q4l7iTPNABWA X-Received: by 2002:a17:907:6f6:: with SMTP id yh22mr3525097ejb.257.1623825485763; Tue, 15 Jun 2021 23:38:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623825485; cv=none; d=google.com; s=arc-20160816; b=Esboi0bsJ2GEiMA1X70oH4TpTRtS7qQnhC/67TA6/VOeEy42VZ0nFGUoODReFgQ3Iu HucoLgv0MDB644VDCFAo1rO86trU8tNamjEmCGq07MW8Mwekf+RONjQ+kQwlwslaUnxT uJjsh8frHf709ivcK6VBFiMCUq7C/aKCe+qvEZuhvapHMmAsNpflpIjgWH2TIxhD9y/s aD9qNxOXpWvPE+lA2NII/YNLFu7UzncjGnAIgIlfaM2Q1J9ivr6T9BHOdltUPBRqUhyj Rms2PCpCsnAjfjE1bdXESyLznsi82uIESz2h8EgAJ2HCrnHzBbTeBlJ3o5qu8loO8FlR xXxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=aeEdd3b9DilkP7dieoq4W8Jk31A1/pZ5WMu1lBAaONo=; b=PTuf1MWv6romdHY69m47f58yENSHhLFt5Iv6ZfwON0VS7zjBlkpzpwEde2w9LML9WM m0phmm/SgJ3qMJeylEQ4tOfgXvdGqnw98qc8cCrj61DGbnDwTilMuxXSMJemNbc3cvAz uQ4Rmt36ec/i3Khk+bYTDvqJ7c1VOA5Upis/8Bukfz6HBuIMBN1zPJTlEDGWHDTYfLtD xwkhHnEPvvWnlqK5PwNn1dmaUXFq4At8/TCiLFD3SD4E218Zcunoh1xM/ilvq3rH2/KQ PL6/np5Z/4kAec1InP6R8QK7aZ99ts8bwkFzGkjx8Rjizg+pTcc7fzmQJBnns6H/c/wK DV7A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z16si1386040edb.194.2021.06.15.23.38.05 for ; Tue, 15 Jun 2021 23:38:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231549AbhFPGkK (ORCPT ); Wed, 16 Jun 2021 02:40:10 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:4932 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231452AbhFPGkF (ORCPT ); Wed, 16 Jun 2021 02:40:05 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4G4b5N6nvsz70N1; Wed, 16 Jun 2021 14:34:48 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:37:58 +0800 Received: from thunder-town.china.huawei.com (10.174.179.0) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:37:57 +0800 From: Zhen Lei To: Vishal Bhakta , VMware PV-Drivers , Karan Tilak Kumar , "Sesidhar Baddela" , Nilesh Javali , GR-QLogic-Storage-Upstream , "Adaptec OEM Raid Solutions" , Brian King , Satish Kharat , Hannes Reinecke , "Manish Rangankar" , Adam Radford , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi CC: Zhen Lei Subject: [PATCH v2 10/20] scsi: libsas: remove unnecessary oom message Date: Wed, 16 Jun 2021 14:37:04 +0800 Message-ID: <20210616063714.778-11-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 In-Reply-To: <20210616063714.778-1-thunder.leizhen@huawei.com> References: <20210616063714.778-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.179.0] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message Remove it can help us save a bit of memory. Signed-off-by: Zhen Lei --- drivers/scsi/libsas/sas_ata.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.26.0.106.g9fadedd diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c index 4aa1fda95f35dd4..a1c7e2c42c5c378 100644 --- a/drivers/scsi/libsas/sas_ata.c +++ b/drivers/scsi/libsas/sas_ata.c @@ -552,10 +552,8 @@ int sas_ata_init(struct domain_device *found_dev) int rc; ata_host = kzalloc(sizeof(*ata_host), GFP_KERNEL); - if (!ata_host) { - pr_err("ata host alloc failed.\n"); + if (!ata_host) return -ENOMEM; - } ata_host_init(ata_host, ha->dev, &sas_sata_ops); From patchwork Wed Jun 16 06:37:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen \(ThunderTown\)" X-Patchwork-Id: 461363 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp312977jae; Tue, 15 Jun 2021 23:38:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzc3YjwxrUQzIMo3czUedkVQPNudyQjFj0VDflA9unCUk24ZKGxZyHGl6VxSrs4fq8D0fg X-Received: by 2002:aa7:c04d:: with SMTP id k13mr2278135edo.122.1623825486750; Tue, 15 Jun 2021 23:38:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623825486; cv=none; d=google.com; s=arc-20160816; b=gBURYpcqXHSp31m/+lIuOjmGAbhHoSwwNexGX/irn0kRtfrUJbmpDoD5M6zFzOWv0O 0C4dtKwuncyS8rTzl2NMNs4ihr0JFC7T5p02+6zEJ9ypCBxvhBcj3AUqjMyU+r4IsAlI JsXfHROwrTnqqm9/6yfMOe/3kcVKLekHD0i9xKAvu8Kua02oYM5JCbjltczF1p/BzLO3 MT2yUjkQwylpkRnli45g2wIRm4Mcsw3NT4kIX8C7w6YtKIOkcFOGbMTQouoi8kericZw snl1+8p+WkIFZE/Oqn7ChAd1+f/cX9VJUSeIYIUcobTQK2H24jVdbwASS1xWMC0EnTeO rNdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=2M7iuCd6gFThOmDY2FWzvdki4Jwct0c/bU97sCAKNfM=; b=OXGiY9fRFloTKvjdHEYASu86hbIGZacrx2sLUSJabcOlwgxUZZsXDeWu8AjV+jrZra Seapcg603D3WYgpQ5QOYanYhD7CCiCYa8nm8QZz0nLq9VJYnkBwgfmVpmbWXrqqOARVd my+QOXtcXSSB0gIS862HrXWmYoaMqGkBFom41KEt49PodJNdvVGnLzHzFiOwYc/klKv4 uWvYaVx577Itf8wiDXMKKXOuxu3wzuXAWsQ2yg89ElBEEww1N+ZN8hXO0tvZse83TzCc 4JD7k7gF2CKfsMfqW1zVJ8MjX7reWRE2muMVre2ubx1FArVtDJRGg//Q6UqTmHxU/OKM 6gVg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z16si1386040edb.194.2021.06.15.23.38.06 for ; Tue, 15 Jun 2021 23:38:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231484AbhFPGkK (ORCPT ); Wed, 16 Jun 2021 02:40:10 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:4796 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231453AbhFPGkF (ORCPT ); Wed, 16 Jun 2021 02:40:05 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4G4b3G1kfvzWt4m; Wed, 16 Jun 2021 14:32:58 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:37:59 +0800 Received: from thunder-town.china.huawei.com (10.174.179.0) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:37:58 +0800 From: Zhen Lei To: Vishal Bhakta , VMware PV-Drivers , Karan Tilak Kumar , "Sesidhar Baddela" , Nilesh Javali , GR-QLogic-Storage-Upstream , "Adaptec OEM Raid Solutions" , Brian King , Satish Kharat , Hannes Reinecke , "Manish Rangankar" , Adam Radford , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi CC: Zhen Lei Subject: [PATCH v2 11/20] scsi: ips: remove unnecessary oom message Date: Wed, 16 Jun 2021 14:37:05 +0800 Message-ID: <20210616063714.778-12-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 In-Reply-To: <20210616063714.778-1-thunder.leizhen@huawei.com> References: <20210616063714.778-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.179.0] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message Remove it can help us save a bit of memory. Signed-off-by: Zhen Lei --- drivers/scsi/ips.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.26.0.106.g9fadedd diff --git a/drivers/scsi/ips.c b/drivers/scsi/ips.c index bc33d54a40112a1..5a242247b8b52d7 100644 --- a/drivers/scsi/ips.c +++ b/drivers/scsi/ips.c @@ -1685,10 +1685,8 @@ ips_flash_copperhead(ips_ha_t * ha, ips_passthru_t * pt, ips_scb_t * scb) pt->CoppCP.cmd.flashfw.count; ha->flash_data = dma_alloc_coherent(&ha->pcidev->dev, datasize, &ha->flash_busaddr, GFP_KERNEL); - if (!ha->flash_data){ - printk(KERN_WARNING "Unable to allocate a flash buffer\n"); + if (!ha->flash_data) return IPS_FAILURE; - } ha->flash_datasize = 0; ha->flash_len = datasize; } else From patchwork Wed Jun 16 06:37:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen \(ThunderTown\)" X-Patchwork-Id: 461364 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp312996jae; Tue, 15 Jun 2021 23:38:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJYRQ679UcDkyZZSVbyTO8MrPg7UknP1NTgcr1JHFG3jbxf75APu1CbEkRq1OiMPXkQXZa X-Received: by 2002:a05:6402:702:: with SMTP id w2mr2249180edx.189.1623825487789; Tue, 15 Jun 2021 23:38:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623825487; cv=none; d=google.com; s=arc-20160816; b=wWWr+Zj4K14Z4yvoTRB92Uy+oeBFmewTWQuFVTB4YseRNzUMte19fOH6SW065YBl4l dmmqs3TOI0dXudB8kjz+I5E9SpJw8ypucO+g+/UHgtpEC3WZNAE84U0f7KZkg9s4fwR/ Qieby1Z7GdlX4OYXWGMsPLQlCb0E+yUAuBPpvf4ZBX9Y3+ScPTRh7eEV8Cbjd5IS7h+S cFfKMMnO1UnnIXDexvfh5NMEyvhXBIDOOhOBeEDiWvPEuDJIHw7N/2vKxB7f/HTaGOKI alZzNFgVGpcumS19VDWDDodlfQ4EjUseXAaXES4kqYbQaCayHAmFXkTlt/XPQbNKwZAK gFtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=/wlRl3TBaoSLV54r1hZCailEG/H/XszSkTSPdg31hH4=; b=wslsd2MywtqQmlhGZr42UM+A9m14g64GZUq0IlI3l5V0RoNSfbs9e5fCbULacqk86C cxU0e1gqrSejAIabaQ4MMevER+MHtA8s+7YJKyCQy6OJFiYvzVBZIdjG9oqS+jo/otQJ uoPEgkjzqYDxdpKmvDdjMUismMFGWWbRgE6dz22wL0EpSBqs0nxwXKZZDxSSVYwU4gkd fRN/cdk7JkLstkVjZcUmun3HLnrC31mqL04QNk9hD9PtSlDyyQ646k/+CmI2J3NFOw0S ptjIjLTqe6qy7bFJUNHxn387QrvZObZKmzrqT/omoqh9nEKD/FAV4kp5xfvqllPPttmI Cryw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z16si1386040edb.194.2021.06.15.23.38.07 for ; Tue, 15 Jun 2021 23:38:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231593AbhFPGkL (ORCPT ); Wed, 16 Jun 2021 02:40:11 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:7324 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231489AbhFPGkG (ORCPT ); Wed, 16 Jun 2021 02:40:06 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4G4b4T1crCz6y7X; Wed, 16 Jun 2021 14:34:01 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:38:00 +0800 Received: from thunder-town.china.huawei.com (10.174.179.0) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:37:59 +0800 From: Zhen Lei To: Vishal Bhakta , VMware PV-Drivers , Karan Tilak Kumar , "Sesidhar Baddela" , Nilesh Javali , GR-QLogic-Storage-Upstream , "Adaptec OEM Raid Solutions" , Brian King , Satish Kharat , Hannes Reinecke , "Manish Rangankar" , Adam Radford , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi CC: Zhen Lei Subject: [PATCH v2 12/20] scsi: ipr: remove unnecessary oom message Date: Wed, 16 Jun 2021 14:37:06 +0800 Message-ID: <20210616063714.778-13-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 In-Reply-To: <20210616063714.778-1-thunder.leizhen@huawei.com> References: <20210616063714.778-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.179.0] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message Remove it can help us save a bit of memory. Signed-off-by: Zhen Lei --- drivers/scsi/ipr.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) -- 2.26.0.106.g9fadedd diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c index 30c30a1db5b1aa0..b99f55e9897af1b 100644 --- a/drivers/scsi/ipr.c +++ b/drivers/scsi/ipr.c @@ -4364,11 +4364,8 @@ static int ipr_alloc_dump(struct ipr_ioa_cfg *ioa_cfg) unsigned long lock_flags = 0; dump = kzalloc(sizeof(struct ipr_dump), GFP_KERNEL); - - if (!dump) { - ipr_err("Dump memory allocation failed\n"); + if (!dump) return -ENOMEM; - } if (ioa_cfg->sis64) ioa_data = vmalloc(array_size(IPR_FMT3_MAX_NUM_DUMP_PAGES, From patchwork Wed Jun 16 06:37:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen \(ThunderTown\)" X-Patchwork-Id: 461365 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp313005jae; Tue, 15 Jun 2021 23:38:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJweFCkdUEvW/v6J3dTL069WwvK+c11E3aWc2UWhsPtNaZjjMtEuNYad+FLc9sgU7t0njDby X-Received: by 2002:a17:906:1c49:: with SMTP id l9mr3714025ejg.39.1623825488133; Tue, 15 Jun 2021 23:38:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623825488; cv=none; d=google.com; s=arc-20160816; b=xLPjAZq5GbHWDm/fehoNVAoqRRt4YeWHVc5CW3poM2qikazBlr1icJWwMDFvo9TfAX R6TeN6oKS42JsLo5rIx0a1uWiNkIIR/oFErul+D+5jBb6Q2rLXUQ9DNcNtWmE21x1+Fv uEDAc3Cgax9FXmjaBQLDN8E7xC4yu6PQbTEXvCTb7ZfFZ2UwUF5IwDXbXKOPf/fRnJf5 U5fihGCwPJ+NkGyzJGJFvUMkJLb0Cu6vbUqW9rpNHYk7636rPBcA2vupj67Jdl+UTs5f PoFx5SKLzJmfLwDVPbfjsah4lIgvsPr0KJS94teDrCqQDO/rSAP7e5HotDNx3fCFvCIz MUdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=/hnErDtnD0/gKbbjHk76fpbYBR0Rq2yVneksz6tQpws=; b=eU7KAYb94QhpOrxYZbS8IO4FpBSv0wbM801xPPhEOpZxL6cgjCxRpHdde1u1x+uO1m aoaMuZClKbAfHqhfuRW+BH1PRzbABcYn04rGNeK46EdstKwPq/zWE/kusC3JMUARZE5y 5Tw2fRBB4Rg4sAbA4omcn12KIJ0teSprydmLolrJNvuWNXhj0vY5vDjNJsgwqDEBkUsq Oz03hvsxbosHmWvuVQd004I8CEIDYXozZUHiNg1wCHrT1dLMIljg55doctzE4SER9bjt ICtmYG5J3b5OmoqaobFZiVsBa/HUYmi5pfCl71pVuQDl7AIscuRW9fNczww1SaZTCVba 14Cw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z16si1386040edb.194.2021.06.15.23.38.08 for ; Tue, 15 Jun 2021 23:38:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231604AbhFPGkM (ORCPT ); Wed, 16 Jun 2021 02:40:12 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:4933 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231499AbhFPGkH (ORCPT ); Wed, 16 Jun 2021 02:40:07 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4G4b5R3KjTz70KQ; Wed, 16 Jun 2021 14:34:51 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:38:01 +0800 Received: from thunder-town.china.huawei.com (10.174.179.0) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:38:00 +0800 From: Zhen Lei To: Vishal Bhakta , VMware PV-Drivers , Karan Tilak Kumar , "Sesidhar Baddela" , Nilesh Javali , GR-QLogic-Storage-Upstream , "Adaptec OEM Raid Solutions" , Brian King , Satish Kharat , Hannes Reinecke , "Manish Rangankar" , Adam Radford , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi CC: Zhen Lei Subject: [PATCH v2 13/20] scsi: fnic: remove unnecessary oom message Date: Wed, 16 Jun 2021 14:37:07 +0800 Message-ID: <20210616063714.778-14-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 In-Reply-To: <20210616063714.778-1-thunder.leizhen@huawei.com> References: <20210616063714.778-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.179.0] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message Remove it can help us save a bit of memory. Signed-off-by: Zhen Lei --- drivers/scsi/fnic/fnic_trace.c | 2 -- drivers/scsi/fnic/vnic_rq.c | 4 +--- drivers/scsi/fnic/vnic_wq.c | 4 +--- 3 files changed, 2 insertions(+), 8 deletions(-) -- 2.26.0.106.g9fadedd diff --git a/drivers/scsi/fnic/fnic_trace.c b/drivers/scsi/fnic/fnic_trace.c index 4a7536bb0ab3874..34aac0253901a99 100644 --- a/drivers/scsi/fnic/fnic_trace.c +++ b/drivers/scsi/fnic/fnic_trace.c @@ -481,8 +481,6 @@ int fnic_trace_buf_init(void) fnic_trace_buf_p = (unsigned long)vzalloc(trace_max_pages * PAGE_SIZE); if (!fnic_trace_buf_p) { - printk(KERN_ERR PFX "Failed to allocate memory " - "for fnic_trace_buf_p\n"); err = -ENOMEM; goto err_fnic_trace_buf_init; } diff --git a/drivers/scsi/fnic/vnic_rq.c b/drivers/scsi/fnic/vnic_rq.c index 6a35b1be00322db..9c341cc50e119d3 100644 --- a/drivers/scsi/fnic/vnic_rq.c +++ b/drivers/scsi/fnic/vnic_rq.c @@ -32,10 +32,8 @@ static int vnic_rq_alloc_bufs(struct vnic_rq *rq) for (i = 0; i < blks; i++) { rq->bufs[i] = kzalloc(VNIC_RQ_BUF_BLK_SZ, GFP_ATOMIC); - if (!rq->bufs[i]) { - printk(KERN_ERR "Failed to alloc rq_bufs\n"); + if (!rq->bufs[i]) return -ENOMEM; - } } for (i = 0; i < blks; i++) { diff --git a/drivers/scsi/fnic/vnic_wq.c b/drivers/scsi/fnic/vnic_wq.c index 442972c04e65d39..da1c775410cb0f9 100644 --- a/drivers/scsi/fnic/vnic_wq.c +++ b/drivers/scsi/fnic/vnic_wq.c @@ -52,10 +52,8 @@ static int vnic_wq_alloc_bufs(struct vnic_wq *wq) for (i = 0; i < blks; i++) { wq->bufs[i] = kzalloc(VNIC_WQ_BUF_BLK_SZ, GFP_ATOMIC); - if (!wq->bufs[i]) { - printk(KERN_ERR "Failed to alloc wq_bufs\n"); + if (!wq->bufs[i]) return -ENOMEM; - } } for (i = 0; i < blks; i++) { From patchwork Wed Jun 16 06:37:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen \(ThunderTown\)" X-Patchwork-Id: 461367 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp313037jae; Tue, 15 Jun 2021 23:38:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxlCsVLo6nczBtO9MDvB34iRnuqkQe+czeXgxtdfAhhK7O4K3bRuJBsXw0Y4li0t2I02u65 X-Received: by 2002:a17:907:270b:: with SMTP id w11mr3672079ejk.7.1623825490280; Tue, 15 Jun 2021 23:38:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623825490; cv=none; d=google.com; s=arc-20160816; b=M+h/ESIceaH2E4uKBYV+TbwVYUzWovYAhSKJqNbYzpUwS3TC5D1j7N+GmjWtnFLrOu MUSd+ty8iBtOT/z1zFY+5Tu92IqvvhWWLE3lpFDkrY/sV11jQAQsBxahG8CQSWaQIVc7 Nqegeo254RZM4GjkX0qeXfAjklZKczujZLYGTwPuBfPFRyDrtwC84vgaaLebajop6p/s 0N/Plz6SUQfTR5oBLhooo0i6tDZOERHoiBf08Hpm7yZQDpmX6Q01VaQ/7ZkX73pk007m 3GbMYj/mc4SBPf0v60G0zCHml7UrMMViAuoQqud3OKJhrCqb1wX3DDgpxirG3tX1ff8+ ZIrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=fhEKdy7MegzkcgmB5BjytX+lfEsoKR0WXtw16wtGaTI=; b=u4nsGA1oO0hL7btccistlwxcYmLXDuWIQyiKcXeXRSdJgSA179Tta3/ocjNE3aWFNo XN/l/NmaM5zrqtQMT4QISMEx9OuS1NOkZLpc4GceTw9/S35L+VQ3iD8DqGg+oFugtUDh rC/MemkR4cPMmWhishLm/7WlXFbP3O3bnnFpHKuN+CqxO7q4EwzG4e9Iuf4qRFrhBWfZ 336MoBPhzKL8DXuJK5va9n50biPXztmJ7U8GgBUJTi0itf5GWEsgjE+DRDZpBNefeUzd pcDOetWJgWYota1TFbBD88qLq7IreFUoexaDMOXziRNYy+/x6vkJME27JujGLfcfLBUX R5bQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z16si1386040edb.194.2021.06.15.23.38.10 for ; Tue, 15 Jun 2021 23:38:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231610AbhFPGkO (ORCPT ); Wed, 16 Jun 2021 02:40:14 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:4934 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231496AbhFPGkL (ORCPT ); Wed, 16 Jun 2021 02:40:11 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4G4b5S24Dnz70Mc; Wed, 16 Jun 2021 14:34:52 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:38:01 +0800 Received: from thunder-town.china.huawei.com (10.174.179.0) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:38:01 +0800 From: Zhen Lei To: Vishal Bhakta , VMware PV-Drivers , Karan Tilak Kumar , "Sesidhar Baddela" , Nilesh Javali , GR-QLogic-Storage-Upstream , "Adaptec OEM Raid Solutions" , Brian King , Satish Kharat , Hannes Reinecke , "Manish Rangankar" , Adam Radford , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi CC: Zhen Lei Subject: [PATCH v2 14/20] scsi: fcoe: remove unnecessary oom message Date: Wed, 16 Jun 2021 14:37:08 +0800 Message-ID: <20210616063714.778-15-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 In-Reply-To: <20210616063714.778-1-thunder.leizhen@huawei.com> References: <20210616063714.778-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.179.0] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message Remove it can help us save a bit of memory. Signed-off-by: Zhen Lei --- drivers/scsi/fcoe/fcoe_transport.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.26.0.106.g9fadedd diff --git a/drivers/scsi/fcoe/fcoe_transport.c b/drivers/scsi/fcoe/fcoe_transport.c index 4d0e19e7c84b91a..815915734d88d43 100644 --- a/drivers/scsi/fcoe/fcoe_transport.c +++ b/drivers/scsi/fcoe/fcoe_transport.c @@ -639,10 +639,8 @@ static int fcoe_add_netdev_mapping(struct net_device *netdev, struct fcoe_netdev_mapping *nm; nm = kmalloc(sizeof(*nm), GFP_KERNEL); - if (!nm) { - printk(KERN_ERR "Unable to allocate netdev_mapping"); + if (!nm) return -ENOMEM; - } nm->netdev = netdev; nm->ft = ft; From patchwork Wed Jun 16 06:37:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen \(ThunderTown\)" X-Patchwork-Id: 461366 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp313028jae; Tue, 15 Jun 2021 23:38:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxkDdOD3wRXJ/Y8FkWIjB7gViTQYtb2mdHcu3h8TJPg0hDO7Mp2tGxlsB5rimOhE5FAJ2N5 X-Received: by 2002:aa7:d648:: with SMTP id v8mr2194780edr.203.1623825489668; Tue, 15 Jun 2021 23:38:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623825489; cv=none; d=google.com; s=arc-20160816; b=S9lDkTPaiiMn19VyEikbMBJ0Q0dciXkajLPOzfR17ALlSjkW9bjgRwH6XkRyIXwf7z 4AIVH61Su9MSlge0naUIoOXmB8lLJl6/Rd3obyLNfuska/guHhalQIois8at4aZXbkZz tIljkRJozxHGG2kmYXSiAtHzHmAaTyHJnJqmq1ewvUWQ0FAf+zHZQdZ+jLIRB65ymE0B f0CSW9S62dFqbhtMHlI1vMT4P0JlcsRMvQq7GgcYydCYjxccQUFF4n5eGqTbsy8CVsq1 8OM4tmwNGD4x+7mkIUJ/Eupphm6IvC/UGkmG3c9oXcX8Y3jEJUbputzxyugDmMR3lbGR 0nFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=eYPLPkKkHQEnKQ73AvM6Z1lBLo1wxQqhjrrS8My3B0M=; b=d5V0zksgyLeZP5ggD2YDtRRfX0TDqTHbkIHOAWvbFkW+0wWOjYjZ0p/V8Mjiamirma HqsBR5GWKXu3oSkeALerGoIuSB9dx5Av8XReDcRK+wgKZSICUJlbCX5C1CRclVLZyWRf jl3z4FgTj3nHTkhfhHl+2M3YLfREj0Sp7y+CeY/yAZmOD1WReH1NzbpLaqlKyJDbflex 8ZhSNmgU6Z4SQFbgV+/URH8UWbwKkXOfaGSSaY4Ue7Wxb6WhOM1/zRBoqk09aRH6qVZb hQh+DH/3SNjjxs7wRva6iwOHVvgx2oAWVq/8BrzzvcU6vSOxCSRpe6vuokkl9XhES9Ev wVMA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z16si1386040edb.194.2021.06.15.23.38.09 for ; Tue, 15 Jun 2021 23:38:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231499AbhFPGkO (ORCPT ); Wed, 16 Jun 2021 02:40:14 -0400 Received: from szxga08-in.huawei.com ([45.249.212.255]:7289 "EHLO szxga08-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231453AbhFPGkL (ORCPT ); Wed, 16 Jun 2021 02:40:11 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4G4b3K5gZGz1BN48; Wed, 16 Jun 2021 14:33:01 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:38:02 +0800 Received: from thunder-town.china.huawei.com (10.174.179.0) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:38:01 +0800 From: Zhen Lei To: Vishal Bhakta , VMware PV-Drivers , Karan Tilak Kumar , "Sesidhar Baddela" , Nilesh Javali , GR-QLogic-Storage-Upstream , "Adaptec OEM Raid Solutions" , Brian King , Satish Kharat , Hannes Reinecke , "Manish Rangankar" , Adam Radford , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi CC: Zhen Lei Subject: [PATCH v2 15/20] scsi: libcxgbi: remove unnecessary oom message Date: Wed, 16 Jun 2021 14:37:09 +0800 Message-ID: <20210616063714.778-16-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 In-Reply-To: <20210616063714.778-1-thunder.leizhen@huawei.com> References: <20210616063714.778-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.179.0] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message Remove it can help us save a bit of memory. Signed-off-by: Zhen Lei --- drivers/scsi/cxgbi/libcxgbi.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) -- 2.26.0.106.g9fadedd diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c index 8c7d4dda4cf2994..df370fb5dd86f96 100644 --- a/drivers/scsi/cxgbi/libcxgbi.c +++ b/drivers/scsi/cxgbi/libcxgbi.c @@ -556,12 +556,11 @@ EXPORT_SYMBOL_GPL(cxgbi_sock_free_cpl_skbs); static struct cxgbi_sock *cxgbi_sock_create(struct cxgbi_device *cdev) { - struct cxgbi_sock *csk = kzalloc(sizeof(*csk), GFP_NOIO); + struct cxgbi_sock *csk; - if (!csk) { - pr_info("alloc csk %zu failed.\n", sizeof(*csk)); + csk = kzalloc(sizeof(*csk), GFP_NOIO); + if (!csk) return NULL; - } if (cdev->csk_alloc_cpls(csk) < 0) { pr_info("csk 0x%p, alloc cpls failed.\n", csk); From patchwork Wed Jun 16 06:37:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen \(ThunderTown\)" X-Patchwork-Id: 461369 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp313058jae; Tue, 15 Jun 2021 23:38:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzNd3gOb8e3xzNvMIrN3+ikmEvvRo3v/naQNR61IY8BiqsiLgXWvvamFBTFRFM/CRfGP07f X-Received: by 2002:aa7:cfd7:: with SMTP id r23mr2267195edy.300.1623825491684; Tue, 15 Jun 2021 23:38:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623825491; cv=none; d=google.com; s=arc-20160816; b=c+R9nFks1YGcKFTTTag6JX8uuFoI1qkk362vYICyVodh9V1t8957HY0Jvan/EhsLBg T8SvjFKlm9BGkdpq6DbVAGw08wLDQbUTcxlM6SDQqtLJcWOGeKHaBdGQgJmoKEuyGjGl dFvS2xPKfeY7+zh78DVd+yuP76w6ck6DKQUOUCDSDF7nmcmBQwOy33AylIB785vzI3OU /SvXpy/zcUNF29WOrjTcNCeBe2RxdQcugTh2qeAytc7Xc0XxxooDNIDoS36788qu7J1l xNHgaEsXbVPW8wof2zMF5rtlwH14OrhCwqABjsFHfLcG0xUGv8FjMNFmzJPjbwdv5EQV bV3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=b2iOjpa3wbKBysv1SbfCaTIkTxfp0hTUwmtaiz+WBdo=; b=tjcB5uQm4xg6LS1xhBpWAfCKraLw4ChBoMMSMZm2FkgqErDLPn0/9dI4aKM2keBX8n pe9qt+McbHqHTU//Gu80iimEi1/ZsJam10x5pMqrNB7j3LnkRUsnkzcpXS2Jmnvun9w+ HZYBbC/Zd5+6qRxJEuQKh01EePUjJI9rFjXiPu78e8nVhUr4qUTsLxoEXIcUR2BBbTfB cKla+UGpMy3Unlvw32a5VKwpKMNQlxXGli5afbq20wO5XBOdWfc+9FtpKK76SVCOoB6A j0CvrG+Z15mCjdDu5uSZWmAWPFJepw5u2gO8WERerNSkVrXR/7Fbvbee9uJpIGCiICHz tAQg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z16si1386040edb.194.2021.06.15.23.38.11 for ; Tue, 15 Jun 2021 23:38:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231617AbhFPGkQ (ORCPT ); Wed, 16 Jun 2021 02:40:16 -0400 Received: from szxga08-in.huawei.com ([45.249.212.255]:7290 "EHLO szxga08-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231570AbhFPGkM (ORCPT ); Wed, 16 Jun 2021 02:40:12 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4G4b3L4QFKz1BN4J; Wed, 16 Jun 2021 14:33:02 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:38:03 +0800 Received: from thunder-town.china.huawei.com (10.174.179.0) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:38:02 +0800 From: Zhen Lei To: Vishal Bhakta , VMware PV-Drivers , Karan Tilak Kumar , "Sesidhar Baddela" , Nilesh Javali , GR-QLogic-Storage-Upstream , "Adaptec OEM Raid Solutions" , Brian King , Satish Kharat , Hannes Reinecke , "Manish Rangankar" , Adam Radford , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi CC: Zhen Lei Subject: [PATCH v2 16/20] scsi: bnx2i: remove unnecessary oom message Date: Wed, 16 Jun 2021 14:37:10 +0800 Message-ID: <20210616063714.778-17-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 In-Reply-To: <20210616063714.778-1-thunder.leizhen@huawei.com> References: <20210616063714.778-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.179.0] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message Remove it can help us save a bit of memory. Signed-off-by: Zhen Lei --- drivers/scsi/bnx2i/bnx2i_iscsi.c | 2 -- 1 file changed, 2 deletions(-) -- 2.26.0.106.g9fadedd diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c b/drivers/scsi/bnx2i/bnx2i_iscsi.c index 1b5f3e143f0710b..a66ca1ebba15f01 100644 --- a/drivers/scsi/bnx2i/bnx2i_iscsi.c +++ b/drivers/scsi/bnx2i/bnx2i_iscsi.c @@ -529,7 +529,6 @@ static int bnx2i_setup_mp_bdt(struct bnx2i_hba *hba) hba->mp_bd_tbl = dma_alloc_coherent(&hba->pcidev->dev, CNIC_PAGE_SIZE, &hba->mp_bd_dma, GFP_KERNEL); if (!hba->mp_bd_tbl) { - printk(KERN_ERR "unable to allocate Middle Path BDT\n"); rc = -1; goto out; } @@ -538,7 +537,6 @@ static int bnx2i_setup_mp_bdt(struct bnx2i_hba *hba) CNIC_PAGE_SIZE, &hba->dummy_buf_dma, GFP_KERNEL); if (!hba->dummy_buffer) { - printk(KERN_ERR "unable to alloc Middle Path Dummy Buffer\n"); dma_free_coherent(&hba->pcidev->dev, CNIC_PAGE_SIZE, hba->mp_bd_tbl, hba->mp_bd_dma); hba->mp_bd_tbl = NULL; From patchwork Wed Jun 16 06:37:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen \(ThunderTown\)" X-Patchwork-Id: 461371 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp313117jae; Tue, 15 Jun 2021 23:38:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx455oJ7bgIVO9qtNneOl62BhFkud6T90gc6RT6PjNsX4iw5R/9s+7uShkQY1BJCs0JNda+ X-Received: by 2002:aa7:d388:: with SMTP id x8mr2229025edq.338.1623825496621; Tue, 15 Jun 2021 23:38:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623825496; cv=none; d=google.com; s=arc-20160816; b=K3r58nps09I+Jllb0K90LOTJ4pivFV6vfusWza3iDzS5RIvG47ONtCtH6Dn+XSjBY1 Wzu84LHoOQoAvKFlyfQMnmPeeV/rnfMB21ykJchnu2GlP0m4a6AanAOlAShZihm7qZkt lf8/OYvMklW9nb2wDhuzgH6x3NB/CkZ2WkO6qxlI/9Jux5P1gPQmaQ0lqVicZUxOC7SI UVz3LA9CN7Avznm2ViASIAeifyGs5p/6xpWdjuswdZmmG92AK2NHuaFVy5Ik+zmG3TbF myCWLVkDkeZmlkVmh++x/MF1ypwUZ+rpb68OqCy9xnab5kvboLaEPMm4lsJ2plu4o4X9 p3fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=BVistbDCF39pBvmdkf1UPOW+yZvsM64xCqQCTnU530A=; b=l/RsHGu94kloRg2dGciyg07PnrdhKRxHMKUKaeyZz2msTOe6QzX5KF5wgNdCkDJYBn i4hniZU1QwyysOpcI+eWidU+QAMEmuynrtL6KzDYanD9j+dh+Sgkt/KqWU64EGbBH3p0 N/xXsbd66SfZFp1hYoq32qI2Ui8Bv8SAsP2CX8B1ryY89lCDpBJ3Dytqo2us+j5ZykUm KuFUzFaB8uDajfQWUbXZLuvKJfgO9ENsJsaYLlirBR9/fekVE0KTkTz3acf/qmRSatXC 6fQYfvQKMGBtUTIMP3yBscfg76L0suwPzJRJKZeJSr2FOZs4mWuQ1s0BYemRndkmRfxn QnSg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z16si1386040edb.194.2021.06.15.23.38.16 for ; Tue, 15 Jun 2021 23:38:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231589AbhFPGkV (ORCPT ); Wed, 16 Jun 2021 02:40:21 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:7325 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231644AbhFPGkT (ORCPT ); Wed, 16 Jun 2021 02:40:19 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4G4b4j2Lpgz6y7X; Wed, 16 Jun 2021 14:34:13 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:38:04 +0800 Received: from thunder-town.china.huawei.com (10.174.179.0) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:38:03 +0800 From: Zhen Lei To: Vishal Bhakta , VMware PV-Drivers , Karan Tilak Kumar , "Sesidhar Baddela" , Nilesh Javali , GR-QLogic-Storage-Upstream , "Adaptec OEM Raid Solutions" , Brian King , Satish Kharat , Hannes Reinecke , "Manish Rangankar" , Adam Radford , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi CC: Zhen Lei Subject: [PATCH v2 17/20] scsi: aic94xx: remove unnecessary oom message Date: Wed, 16 Jun 2021 14:37:11 +0800 Message-ID: <20210616063714.778-18-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 In-Reply-To: <20210616063714.778-1-thunder.leizhen@huawei.com> References: <20210616063714.778-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.179.0] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message Remove it can help us save a bit of memory. Signed-off-by: Zhen Lei --- drivers/scsi/aic94xx/aic94xx_init.c | 4 +--- drivers/scsi/aic94xx/aic94xx_sds.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) -- 2.26.0.106.g9fadedd diff --git a/drivers/scsi/aic94xx/aic94xx_init.c b/drivers/scsi/aic94xx/aic94xx_init.c index a195bfe9eccc073..9edd6008bbdec03 100644 --- a/drivers/scsi/aic94xx/aic94xx_init.c +++ b/drivers/scsi/aic94xx/aic94xx_init.c @@ -725,10 +725,8 @@ static int asd_pci_probe(struct pci_dev *dev, const struct pci_device_id *id) asd_dev = &asd_pcidev_data[asd_id]; asd_ha = kzalloc(sizeof(*asd_ha), GFP_KERNEL); - if (!asd_ha) { - asd_printk("out of memory\n"); + if (!asd_ha) goto Err_put; - } asd_ha->pcidev = dev; asd_ha->sas_ha.dev = &asd_ha->pcidev->dev; asd_ha->sas_ha.lldd_ha = asd_ha; diff --git a/drivers/scsi/aic94xx/aic94xx_sds.c b/drivers/scsi/aic94xx/aic94xx_sds.c index 297a66770260ccf..1b46f0018e0bfe5 100644 --- a/drivers/scsi/aic94xx/aic94xx_sds.c +++ b/drivers/scsi/aic94xx/aic94xx_sds.c @@ -342,10 +342,8 @@ int asd_read_ocm(struct asd_ha_struct *asd_ha) return -1; dir = kmalloc(sizeof(*dir), GFP_KERNEL); - if (!dir) { - asd_printk("no memory for ocm dir\n"); + if (!dir) return -ENOMEM; - } err = asd_read_ocm_dir(asd_ha, dir, 0); if (err) From patchwork Wed Jun 16 06:37:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen \(ThunderTown\)" X-Patchwork-Id: 461368 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp313054jae; Tue, 15 Jun 2021 23:38:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxTqSkQ8cPSpnIasra2DPes1OgNQa68MiKwSYZFEAvZ2wmEUJXIbmiSw7tHZZceGC+c8AK7 X-Received: by 2002:a50:fd0a:: with SMTP id i10mr2339479eds.78.1623825491284; Tue, 15 Jun 2021 23:38:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623825491; cv=none; d=google.com; s=arc-20160816; b=BFOxZSOCYpiBH28t4Td2Zo7CCsxTh00eXtmq/Niv3F2s3LO/HtLHhS5kBsfEd8z9Ia bYVtEM8BW4wkHjj/E76e/+0t2jms84DUb2aXUvJzgcAusk2ARS6U+1bYzlFVSOMopx96 lJrIJftqbnjRchD3TyRs6H8zkTEO4hmvr6GnmeulXPqJXrmSzBq6zYH+wEoEa10qEkhO WUV1mZ8AJnu9K8/8AY4GYWMVCu8VhCO8vLnRAop3epVsZgJe3CaROxPEleoepUzMdk7O 6417vUVlRWYZuM7TcdxQls/SlV7x/3D/1Bg9dwufyk31pbKqip//2ve8m6tyhKgb8xFo DH+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=2ZgqKHQO0DPGkxdYrWW7pNH7rzklQCG/BtSnjovo+YA=; b=iHMfytQXTm4mP35TXN/NaHnFtAY38Og9r3KlG0uLGYxEqgKUDeIso9ypVJ/ey2xOVj eM70jvg2eXtiYpnVG1KbEm90szMXvWughfE55bf4EyGz4Nh7C7xM308PkM0G7I2bIrlS LGxlV1iYuTUjhSHYCRA5+bvA4Vd7wqDH2CdukezoW03F4XPV8cKp91pPbWQUcS1zABxB J/AQFFMnG7V/Wm4fm6acrPVJP5Lo4t42VRApz1hV+NtcunYG4axq/MP4P4qNRou0BvrI 7yChliXppNR2M7Kop13CksIovc73W1cMqGudfXcx/MqCBmuB9hTIWYCmat7Jg1MaaDjP C89A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z16si1386040edb.194.2021.06.15.23.38.11 for ; Tue, 15 Jun 2021 23:38:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231602AbhFPGkP (ORCPT ); Wed, 16 Jun 2021 02:40:15 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:4797 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231560AbhFPGkL (ORCPT ); Wed, 16 Jun 2021 02:40:11 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4G4b3N0hjQzWtHr; Wed, 16 Jun 2021 14:33:04 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:38:05 +0800 Received: from thunder-town.china.huawei.com (10.174.179.0) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:38:04 +0800 From: Zhen Lei To: Vishal Bhakta , VMware PV-Drivers , Karan Tilak Kumar , "Sesidhar Baddela" , Nilesh Javali , GR-QLogic-Storage-Upstream , "Adaptec OEM Raid Solutions" , Brian King , Satish Kharat , Hannes Reinecke , "Manish Rangankar" , Adam Radford , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi CC: Zhen Lei Subject: [PATCH v2 18/20] scsi: aacraid: remove unnecessary oom message Date: Wed, 16 Jun 2021 14:37:12 +0800 Message-ID: <20210616063714.778-19-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 In-Reply-To: <20210616063714.778-1-thunder.leizhen@huawei.com> References: <20210616063714.778-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.179.0] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message Remove it can help us save a bit of memory. Signed-off-by: Zhen Lei --- drivers/scsi/aacraid/comminit.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) -- 2.26.0.106.g9fadedd diff --git a/drivers/scsi/aacraid/comminit.c b/drivers/scsi/aacraid/comminit.c index 355b16f0b1456bd..282519ccd4a22da 100644 --- a/drivers/scsi/aacraid/comminit.c +++ b/drivers/scsi/aacraid/comminit.c @@ -85,10 +85,8 @@ static int aac_alloc_comm(struct aac_dev *dev, void **commaddr, unsigned long co printfbufsiz + host_rrq_size; base = dma_alloc_coherent(&dev->pdev->dev, size, &phys, GFP_KERNEL); - if (base == NULL) { - printk(KERN_ERR "aacraid: unable to create mapping.\n"); + if (!base) return 0; - } dev->comm_addr = (void *)base; dev->comm_phys = phys; @@ -635,10 +633,8 @@ struct aac_dev *aac_init_adapter(struct aac_dev *dev) */ dev->queues = kzalloc(sizeof(struct aac_queue_block), GFP_KERNEL); - if (dev->queues == NULL) { - printk(KERN_ERR "Error could not allocate comm region.\n"); + if (!dev->queues) return NULL; - } if (aac_comm_init(dev)<0){ kfree(dev->queues); From patchwork Wed Jun 16 06:37:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen \(ThunderTown\)" X-Patchwork-Id: 461370 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp313061jae; Tue, 15 Jun 2021 23:38:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy8l65JyeP+7P4JshwalTR4QQyWwZD0WyKGakvZx10694uvNDRsvOj0gftx5mf/xCPRnDyp X-Received: by 2002:a17:906:6dc5:: with SMTP id j5mr3598535ejt.364.1623825492018; Tue, 15 Jun 2021 23:38:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623825492; cv=none; d=google.com; s=arc-20160816; b=lJ8pCLvWpdOnoKWqw/6atIHyr0CidE54vDOYrncNFGlgmXU0ZCOjlA9bVlgrG9KKex 8lPxBlQ+zrUyD6O9EgM55Z4odnRjZaG14TOyeNO1brCi5TERcMEwM3WGeGs1UqxPz7be TTcp+1QlxnjmAd4mzxEeWi36a4G+Rs7oc4JIy6wm1qoyirt3xfN1x8ns0kdSHSZKv4vW 644h7300mN3ObvpiVfp6Q4kzHO/ciItw8N3nzytlkmZGG+gWt6rqDKkduco7hkN0V4Q5 1iXVWJZM87xIrh1PFktWdz87S2cL6YMRumKggmbwmbHGQC0dC3m8F6q4V/sDllP+ynHP 6q3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=/aVejNkUAeeJP86b+X3wAwMgGKSd16yn7choeONqZUY=; b=mVtOLMRFdIgpvjQyS0H40BlA0JT4Rkbx8YG16U78Kh7hkEMJP2GnWS3K4sCdxTnlV4 RtN/nCjlFzYcG+Ongv6b/foNF0weFYEaIs6JKDCskqWknL0QE/teZxgJ+yPVqZDYyOlw RJTeFflRYazqVNQFLuz4ddMFZCHfeo1odZ3V7jIyB6LK74Wj6Tp2qupzf40bpJYa8bIN nDdzXs6fejb3RgevwAjvgCWBWero9aI9LhCoRmQF8dNozFmc1ICyWFXEM0ZGu1cGVk/P 7F/0Evw2BGxqRm3p1MKxL968A0rR9ShczpRAYxzIbI4NqUsQZ7jz82f0GD7wVQ5XKtZZ MiCg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z16si1386040edb.194.2021.06.15.23.38.11 for ; Tue, 15 Jun 2021 23:38:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231621AbhFPGkQ (ORCPT ); Wed, 16 Jun 2021 02:40:16 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:7452 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231536AbhFPGkM (ORCPT ); Wed, 16 Jun 2021 02:40:12 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4G4b5p4QqlzZhmC; Wed, 16 Jun 2021 14:35:10 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:38:06 +0800 Received: from thunder-town.china.huawei.com (10.174.179.0) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:38:05 +0800 From: Zhen Lei To: Vishal Bhakta , VMware PV-Drivers , Karan Tilak Kumar , "Sesidhar Baddela" , Nilesh Javali , GR-QLogic-Storage-Upstream , "Adaptec OEM Raid Solutions" , Brian King , Satish Kharat , Hannes Reinecke , "Manish Rangankar" , Adam Radford , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi CC: Zhen Lei Subject: [PATCH v2 19/20] scsi: a100u2w: remove unnecessary oom message Date: Wed, 16 Jun 2021 14:37:13 +0800 Message-ID: <20210616063714.778-20-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 In-Reply-To: <20210616063714.778-1-thunder.leizhen@huawei.com> References: <20210616063714.778-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.179.0] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message Remove it can help us save a bit of memory. Signed-off-by: Zhen Lei --- drivers/scsi/a100u2w.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) -- 2.26.0.106.g9fadedd diff --git a/drivers/scsi/a100u2w.c b/drivers/scsi/a100u2w.c index 028af6b1057c606..7bcb8889c085e0a 100644 --- a/drivers/scsi/a100u2w.c +++ b/drivers/scsi/a100u2w.c @@ -1123,19 +1123,15 @@ static int inia100_probe_one(struct pci_dev *pdev, sz = ORC_MAXQUEUE * sizeof(struct orc_scb); host->scb_virt = dma_alloc_coherent(&pdev->dev, sz, &host->scb_phys, GFP_KERNEL); - if (!host->scb_virt) { - printk("inia100: SCB memory allocation error\n"); + if (!host->scb_virt) goto out_host_put; - } /* Get total memory needed for ESCB */ sz = ORC_MAXQUEUE * sizeof(struct orc_extended_scb); host->escb_virt = dma_alloc_coherent(&pdev->dev, sz, &host->escb_phys, GFP_KERNEL); - if (!host->escb_virt) { - printk("inia100: ESCB memory allocation error\n"); + if (!host->escb_virt) goto out_free_scb_array; - } if (init_orchid(host)) { /* Initialize orchid chip */ printk("inia100: initial orchid fail!!\n"); From patchwork Wed Jun 16 06:37:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen \(ThunderTown\)" X-Patchwork-Id: 461372 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp313144jae; Tue, 15 Jun 2021 23:38:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxLLijYK2RZyL2HLFYbwbQa6BoVCpXYL+3aIKMkEwWVzH9U8ONvDYvWI8Xj3ycAoqBcUe/1 X-Received: by 2002:a05:6402:1c88:: with SMTP id cy8mr2315335edb.80.1623825498117; Tue, 15 Jun 2021 23:38:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623825498; cv=none; d=google.com; s=arc-20160816; b=aD61F2PmEshM4a2c1AaAmt/ixaKWSOYbgX1CzoGcdQSJkWGEJnEie7Ha2nlPPUaS7C GJW4ZziqVSbSWG2whBA4MEfuQ/BwN0w2++3Bo7CjVZmumSxoW3RoTBwP6U6npBmqsjpb Ul6H1rMT00Kuda1cly53Gr4sQwZ+aCELQaZ0ADBnXnICMutmwEwnuyNMV8jUeCz2PtOE Zx+mhxgy3EeH2Hpb/FsL4ip93y6rBeXn5foCL9ON6xTgJFjl+rsxb4JJbxGSQMbjch2e 0Vi3a1/xAOTXWTOr7KmKo3mZAHfJ8g8j9OwAoBsC6zxPRP3DlrpOqG7875V+6N+swCqj yFAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Nmem0+oKnfV6lI+LWyz9v1qn/6ql69BN8A1PNrwLYO4=; b=GvZVhUZRToTfN+p9XODYp3iIHgocfXO7pm33g9gTF0VqtV+w20xNs9n2dqKc55KXkL y7k8rts3fP63I0Ol2TaS8deaHS2wrSuAk+xpCQgaS1sRnWmfvDKdRlfJ4FJwl7HtAi8A a6YsQnq0jNg8EIao0Q32T6Sxn66BWbVm+8XJvs/N/JHIu7tT7dEp20lz6IQ7Zp57MBop kuL9b8GQsWX4x56xXpFidWcwWJzna57mYcQOtvajgW01weLEAAKygzoqHo04YtSvvgrv RcA2DjJFbYPtvMwcRKNQqjd1Knz+ADILSL/XC00kaeXerVpSPkTQoWyXVLwpLEPGabRT RjYg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z16si1386040edb.194.2021.06.15.23.38.17 for ; Tue, 15 Jun 2021 23:38:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231614AbhFPGkV (ORCPT ); Wed, 16 Jun 2021 02:40:21 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:7326 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231258AbhFPGkT (ORCPT ); Wed, 16 Jun 2021 02:40:19 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4G4b4j3k9Vz6yB8; Wed, 16 Jun 2021 14:34:13 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:38:06 +0800 Received: from thunder-town.china.huawei.com (10.174.179.0) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 16 Jun 2021 14:38:06 +0800 From: Zhen Lei To: Vishal Bhakta , VMware PV-Drivers , Karan Tilak Kumar , "Sesidhar Baddela" , Nilesh Javali , GR-QLogic-Storage-Upstream , "Adaptec OEM Raid Solutions" , Brian King , Satish Kharat , Hannes Reinecke , "Manish Rangankar" , Adam Radford , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi CC: Zhen Lei Subject: [PATCH v2 20/20] scsi: 3w-xxx: remove unnecessary oom message Date: Wed, 16 Jun 2021 14:37:14 +0800 Message-ID: <20210616063714.778-21-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 In-Reply-To: <20210616063714.778-1-thunder.leizhen@huawei.com> References: <20210616063714.778-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.179.0] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message Remove it can help us save a bit of memory. Signed-off-by: Zhen Lei --- drivers/scsi/3w-xxxx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.26.0.106.g9fadedd diff --git a/drivers/scsi/3w-xxxx.c b/drivers/scsi/3w-xxxx.c index 4ee485ab2714845..a7eb50d2592ea1a 100644 --- a/drivers/scsi/3w-xxxx.c +++ b/drivers/scsi/3w-xxxx.c @@ -836,10 +836,8 @@ static int tw_allocate_memory(TW_Device_Extension *tw_dev, int size, int which) cpu_addr = dma_alloc_coherent(&tw_dev->tw_pci_dev->dev, size * TW_Q_LENGTH, &dma_handle, GFP_KERNEL); - if (cpu_addr == NULL) { - printk(KERN_WARNING "3w-xxxx: dma_alloc_coherent() failed.\n"); + if (!cpu_addr) return 1; - } if ((unsigned long)cpu_addr % (tw_dev->tw_pci_dev->device == TW_DEVICE_ID ? TW_ALIGNMENT_6000 : TW_ALIGNMENT_7000)) { printk(KERN_WARNING "3w-xxxx: Couldn't allocate correctly aligned memory.\n");