From patchwork Tue Jun 15 10:43:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manish Narani X-Patchwork-Id: 460842 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5558AC48BE5 for ; Tue, 15 Jun 2021 10:44:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 34FDA613DB for ; Tue, 15 Jun 2021 10:44:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231502AbhFOKqf (ORCPT ); Tue, 15 Jun 2021 06:46:35 -0400 Received: from mail-dm6nam10on2063.outbound.protection.outlook.com ([40.107.93.63]:61089 "EHLO NAM10-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231374AbhFOKqe (ORCPT ); Tue, 15 Jun 2021 06:46:34 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=auGojrSxVlFmkMZNXCP6zYaSkGbP/tzb9kiKvSGfIl7jJcSoBLH1XTxfmBRHFbuVYoT80rs4FlFYEM1qAhbeA4iKZQZVCNxSkRAAjj+5pIYp8Rz8WigWDr/IpbG4p+V8Rfph5gkNkq53mK7ifW67fWD+JhdhN1kQesOavHX2gQ2ghHQQ+IhEvd6foJh4oQZOduqgOU/ed/LTVGcwTgzC38klQubldjOFZlp6tkSeamFupnInCFrFK9DMGB6j2TKXh/MAf3l4SbRrVwSLbZ7gNiBwqopuHSM4w+dh2OV7Tcs/yY5nd7Y8lpBMd9idNib6A4mssvF8aRna2RGQMKP21g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TVuBGQum2Iz/QL0uncgH37Zy3FPAUec+G/7MqD7vj2Q=; b=f7Y/6GFDW5ZaSB2o78U9cGMG7Rt2hXoFoLrlviCE9Uo8mja3gO9WHFcamsf/3/6dn17aCSLjJeOKizDLGU0X5ObrNP7PzeYGY4V74XXeLqaIhJZKp8t1QlxuIg+xSZFLlpo1RUvZM/99h9gFHzn82apFIn7RB9V/IeRrSjy5RaBU1iauI2qptF4GgGrOrIESMybR1ykFOCnlaeGFNea99xD+K3GjWtXSfnkiY2kOO8gk4HFkn2WIj/zjZD3qn6NDdEfSIpj+Tjqg4UZK8bBWeqbnCu2N+cu/3Nt2zNPA7NFlGflc2HD1FNmPoScGMAukVRq6dZ587+ZAlCZywdmDMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=intel.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TVuBGQum2Iz/QL0uncgH37Zy3FPAUec+G/7MqD7vj2Q=; b=p2TBsw4ymlaoL2F0Yf8FnYzduTXjJXVA+DDLpdYbyz6RpIQIW7PxpYPx7qRkdB70FYiEq1ifzQXcfIinPspItkMgPAUQOvFJkMvj7YoG7t3+MuayUjYPdY4RD64IYLmh1w2XijihihFSliS0mi1nXXTCONevN78OvTD2S5PJouA= Received: from DM6PR03CA0024.namprd03.prod.outlook.com (2603:10b6:5:40::37) by SN6PR02MB4766.namprd02.prod.outlook.com (2603:10b6:805:92::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21; Tue, 15 Jun 2021 10:44:27 +0000 Received: from DM3NAM02FT026.eop-nam02.prod.protection.outlook.com (2603:10b6:5:40:cafe::76) by DM6PR03CA0024.outlook.office365.com (2603:10b6:5:40::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21 via Frontend Transport; Tue, 15 Jun 2021 10:44:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; intel.com; dkim=none (message not signed) header.d=none; intel.com; dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT026.mail.protection.outlook.com (10.13.5.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4219.21 via Frontend Transport; Tue, 15 Jun 2021 10:44:27 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 15 Jun 2021 03:44:27 -0700 Received: from smtp.xilinx.com (172.19.127.95) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Tue, 15 Jun 2021 03:44:27 -0700 Envelope-to: adrian.hunter@intel.com, ulf.hansson@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org Received: from [172.23.64.106] (port=49383 helo=xhdvnc125.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1lt6YU-0002XZ-O9; Tue, 15 Jun 2021 03:44:26 -0700 Received: by xhdvnc125.xilinx.com (Postfix, from userid 16987) id C4F6A1222B3; Tue, 15 Jun 2021 16:13:59 +0530 (IST) From: Manish Narani To: , , CC: , , , Manish Narani Subject: [PATCH 2/7] mmc: sdhci-of-arasan: Add "SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12" quirk. Date: Tue, 15 Jun 2021 16:13:52 +0530 Message-ID: <1623753837-21035-3-git-send-email-manish.narani@xilinx.com> X-Mailer: git-send-email 2.1.1 In-Reply-To: <1623753837-21035-1-git-send-email-manish.narani@xilinx.com> References: <1623753837-21035-1-git-send-email-manish.narani@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 757522c9-adf8-462f-ac2e-08d92fea8c5f X-MS-TrafficTypeDiagnostic: SN6PR02MB4766: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:2331; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1boD7rt+5hBX1MabtXu6IKpnkjwBoYo289XIRA4DEHuXhaNY8Cik7InvUoUWslCqFvfNY/+eu5cWarZ/iDETXCybG7sdzjIVp7YEk455IVam7fkqbkcR/tQyvAfw1xHndnLiPNV/ykBfx+R3Z/IDndhMQej53+IHvC65w25ORh9DrXzmM1gNnYUYxjxnp+r6g7tSdVL6EbAe9qspsd8Z14UgvBjX5IKGllxnd6IB4SsPhFAMku4f5fO3dZ+mJI/RCG6JtyQuZyhg2q3JJAi2p2QbjjsRhizpUR2bFCNFeIa5+qRYg9h/KSgj5Bu8lqR3ZtDlMZjhQR5NkoOvFh+MF021zaLNn5NsBVlXDaOLoLIICd90fatj64BS12h+fy2m5iwEicwHIuJhUi0T8o+kOBN/TgJfX8AbMnB7ez4UyT2otprVM7+bLs4OTcNfQf13V3pPVzvMeecxp90vtg2O4uRIdo5wxQgnoAd+SQdLa8MVZlWnbX68Z42qhwSWPXaKz4D1nTQZz9x9RVHKeGONFAauYC5l5MCR6eYB3rWOmk0LGn10GdIIyTyfZuVq3UI2stQoSyw77Fd/vBQ9ni6P2A+7Bc1EPRgbmsK/Me2QIjuMxMT+Tk9fQD328czrWQadwNIRsUGUn3aBksRJOmkdVJBcmCuIDV+fOQsvGNNZ+7POYGJO3NO8KvIbf+IK4wVt X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch01.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(4636009)(136003)(39850400004)(346002)(396003)(376002)(36840700001)(46966006)(36860700001)(82740400003)(83380400001)(186003)(2906002)(356005)(47076005)(82310400003)(54906003)(8676002)(70586007)(4744005)(7636003)(70206006)(2616005)(4326008)(110136005)(6266002)(478600001)(107886003)(44832011)(426003)(36756003)(36906005)(316002)(42186006)(336012)(26005)(8936002)(5660300002)(6666004)(102446001); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2021 10:44:27.2659 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 757522c9-adf8-462f-ac2e-08d92fea8c5f X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT026.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR02MB4766 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org Arasan controller supports AUTO CMD12, this patch adds "SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12" quirk to enable auto cmd12 feature. By using auto cmd12 we can also avoid following error message "Got data interrupt even though no data operation in progress" Signed-off-by: Manish Narani --- drivers/mmc/host/sdhci-of-arasan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c index fc3e41c..b13e719 100644 --- a/drivers/mmc/host/sdhci-of-arasan.c +++ b/drivers/mmc/host/sdhci-of-arasan.c @@ -1616,6 +1616,7 @@ static int sdhci_arasan_probe(struct platform_device *pdev) arasan_zynqmp_execute_tuning; sdhci_arasan->quirks |= SDHCI_ARASAN_QUIRK_CLOCK_25_BROKEN; + host->quirks |= SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12; } arasan_dt_parse_clk_phases(dev, &sdhci_arasan->clk_data); From patchwork Tue Jun 15 10:43:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manish Narani X-Patchwork-Id: 460841 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41450C48BDF for ; Tue, 15 Jun 2021 10:45:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2331D6137D for ; Tue, 15 Jun 2021 10:45:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231532AbhFOKrD (ORCPT ); Tue, 15 Jun 2021 06:47:03 -0400 Received: from mail-dm6nam10on2058.outbound.protection.outlook.com ([40.107.93.58]:31328 "EHLO NAM10-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231327AbhFOKrC (ORCPT ); Tue, 15 Jun 2021 06:47:02 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HDIXCwH8o1C/mM+xkTBmwl64fiL0H8WCHe62rtZNceVW1egfr1jWfQWKXTQOVjGGOBuwT52shgz5FCAQTTo+8ZIQjM445dVj74i81p7qkBzN91iJ+WrrH7ldVTkreoIRoVYIG3FhAj26uX0RYYAwCLGDs4EeGPoYzaE/IQAa4pHgGBMl7tabwuzdx17X2C/5MSaU7lYheFlGlq9CSfQk2HXwW2dPEecOqg3tuymUIwDi8rV5urmshafiK1CwAK4E7sXo2efDvKg+5C74uN4uMaFwJQdFHZAjSpFadn0yur/L99yX1mSdtpbmky2kPjykLuLY+w7fVWM30US8P6ngYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kZAXm7TfAkASmMPEF0+iQ2b5NREZbUoyyCqWu4EIC6Y=; b=YswywRMkLfa+lt5jqw0eRuffcIYGLQ4v+Pky8dLjIg2/hAxHgQkfrxYVWFaNIj5UV30Ux/VptrY0/Q4rSI+nweS0DjEFpXqGA5Uhtk1Zgnw+rl1IUSNqocK3vkut904QKNkMhXnYeCNO+gtXbzo+Ih/ifayNBaQQBOlRFxHNaAFvhd6bVSR1OT9JdU4zPR4ujPQUkpAJvYOmDDcOy4tFLP4WOpnerC3mx/5BS2kMBJonwquvc1YU/LmAujLcqdddTqj1YnLLBCbAzwZsUTiao/lCzu1sKZRyWlnqa9BlsURvY2dBp9UTdCYKi38NoADBaYhoTMtLPhZqrINk4vCD8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=intel.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kZAXm7TfAkASmMPEF0+iQ2b5NREZbUoyyCqWu4EIC6Y=; b=CnAGWCv3hIxceyVi5BISn3hcoqK5ZuB16qZbJoVJCF+ZtuERXNmzmZAZ1v+fAgTKmizHZg5u90BgvRvDzrmYuglkjXUR46GNHuh3yl/u2adyROB/hWrUp5deLzP4z7w4dxZmGvDLzyQAGD108MQ3Nt4HXpwQcWJAukMBZusVtoY= Received: from BN6PR16CA0029.namprd16.prod.outlook.com (2603:10b6:405:14::15) by BYAPR02MB5735.namprd02.prod.outlook.com (2603:10b6:a03:128::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.22; Tue, 15 Jun 2021 10:44:57 +0000 Received: from BN1NAM02FT059.eop-nam02.prod.protection.outlook.com (2603:10b6:405:14:cafe::1) by BN6PR16CA0029.outlook.office365.com (2603:10b6:405:14::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21 via Frontend Transport; Tue, 15 Jun 2021 10:44:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; intel.com; dkim=none (message not signed) header.d=none; intel.com; dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by BN1NAM02FT059.mail.protection.outlook.com (10.13.2.167) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4219.21 via Frontend Transport; Tue, 15 Jun 2021 10:44:56 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 15 Jun 2021 03:44:53 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Tue, 15 Jun 2021 03:44:53 -0700 Envelope-to: adrian.hunter@intel.com, ulf.hansson@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org Received: from [172.23.64.106] (port=49389 helo=xhdvnc125.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1lt6Yu-0008Kc-Uc; Tue, 15 Jun 2021 03:44:53 -0700 Received: by xhdvnc125.xilinx.com (Postfix, from userid 16987) id D42181222C7; Tue, 15 Jun 2021 16:13:59 +0530 (IST) From: Manish Narani To: , , CC: , , , Manish Narani Subject: [PATCH 4/7] mmc: host: sdhci-of-arasan: Check return value of non-void funtions Date: Tue, 15 Jun 2021 16:13:54 +0530 Message-ID: <1623753837-21035-5-git-send-email-manish.narani@xilinx.com> X-Mailer: git-send-email 2.1.1 In-Reply-To: <1623753837-21035-1-git-send-email-manish.narani@xilinx.com> References: <1623753837-21035-1-git-send-email-manish.narani@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4a06f48b-6f1a-4cbd-b42a-08d92fea9e02 X-MS-TrafficTypeDiagnostic: BYAPR02MB5735: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:270; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MuO6Oygn18YskJmuq2Cf6hms+no+Sy0ArGRVYMHySDBCSe8Rsj69/YBly4JEVIXacGroTeq6udIKIIOWWu9AX2h8bJCknJnBaKTaLNvBhr68yvxQpmpVWescrfpmNXsA2j5DwLI8efFcD/XJKDskgEdb27qihEbBKw4V3gcJAiqSMvGVDMRAjsOi/gHyy0R7VA0Uj6511xninYiwJAws1SuvGwGrYsq12zW83A2Jk7TTty0p5olZVOjlqAGx7X6YE6j4GXWjxHHUImJTmunbyNXZN3Ta6/xN7a7oQJ+df8kymz40ORgJeMpdi7KbnuyXibICDqZjJRAmwfF9ZgEDiSQOfgcOUr+4H9pAPk7Of9V7sjKz/M/aYJ4A5QLUTSB2HXgI85FtHZ50VsRr+Ceih2WYr75tjh/Zm0SKX7EavzIvEw/IVRR5nl69lAO1pLb7ZTDvmJMr3tlHJobVWMVI1nFc5Xfco9pSliPnikyqtWxvfPTaYlDJK4F9IOaw1xBgU4LpF7DLAqHPWxvEKXCVYt79TGrxAD8rKrRWb7UVFJMFnqE+Opkx+GxAiH1PvC61k8P0vTgVYJV4nVWOJqt/n31RF+5FHXNKkzXhiMtffda2oQESV+NwlLeNpsFGDViQjm37xFkxe3KAhxQPfPDIQKW6wO5IGmb34pShc97+omYlN2jVY6pASFRkDfky8pB1 X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch02.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(4636009)(136003)(39850400004)(396003)(376002)(346002)(46966006)(36840700001)(36906005)(70206006)(316002)(47076005)(186003)(426003)(4326008)(70586007)(8936002)(2616005)(336012)(36860700001)(36756003)(44832011)(5660300002)(2906002)(26005)(42186006)(8676002)(110136005)(83380400001)(478600001)(82310400003)(7636003)(107886003)(82740400003)(6666004)(356005)(6266002)(54906003)(102446001); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2021 10:44:56.8046 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4a06f48b-6f1a-4cbd-b42a-08d92fea9e02 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT059.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR02MB5735 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org At a couple of places, the return values of the non-void functions were not getting checked. This was reported by the coverity tool. Modify the code to check the return values of the same. Addresses-Coverity: ("check_return") Signed-off-by: Manish Narani --- drivers/mmc/host/sdhci-of-arasan.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c index 1980d0b..98671a3 100644 --- a/drivers/mmc/host/sdhci-of-arasan.c +++ b/drivers/mmc/host/sdhci-of-arasan.c @@ -273,7 +273,12 @@ static void sdhci_arasan_set_clock(struct sdhci_host *host, unsigned int clock) * through low speeds without power cycling. */ sdhci_set_clock(host, host->max_clk); - phy_power_on(sdhci_arasan->phy); + if (phy_power_on(sdhci_arasan->phy)) { + pr_err("%s: Cannot power on phy.\n", + mmc_hostname(host->mmc)); + return; + } + sdhci_arasan->is_phy_on = true; /* @@ -323,7 +328,12 @@ static void sdhci_arasan_set_clock(struct sdhci_host *host, unsigned int clock) msleep(20); if (ctrl_phy) { - phy_power_on(sdhci_arasan->phy); + if (phy_power_on(sdhci_arasan->phy)) { + pr_err("%s: Cannot power on phy.\n", + mmc_hostname(host->mmc)); + return; + } + sdhci_arasan->is_phy_on = true; } } @@ -479,7 +489,9 @@ static int sdhci_arasan_suspend(struct device *dev) ret = phy_power_off(sdhci_arasan->phy); if (ret) { dev_err(dev, "Cannot power off phy.\n"); - sdhci_resume_host(host); + if (sdhci_resume_host(host)) + dev_err(dev, "Cannot resume host.\n"); + return ret; } sdhci_arasan->is_phy_on = false; From patchwork Tue Jun 15 10:43:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manish Narani X-Patchwork-Id: 460840 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C56F9C48BDF for ; Tue, 15 Jun 2021 10:45:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A7DD56137D for ; Tue, 15 Jun 2021 10:45:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231491AbhFOKr0 (ORCPT ); Tue, 15 Jun 2021 06:47:26 -0400 Received: from mail-dm6nam10on2057.outbound.protection.outlook.com ([40.107.93.57]:54496 "EHLO NAM10-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231469AbhFOKr0 (ORCPT ); Tue, 15 Jun 2021 06:47:26 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S7c8N4Hz693aQQUyQaXmx+ceYq7kOnIiaTdolWbrtF47yH/EV05cikTvA+Ban3nsKsk2q7Uy51vK8TooA4CP7aMnV7bazHpDVERDcbfgwtg3ycd1DFjoTz0P3JVaXqyeDAL47ll7TNZuh4AnBnFVpc/gqHrRPxaxZTKyFeNWMEUNhHqHYqQ1V4XGAVnVVGTAHGQuQPfow4y+G6Hzxqgk1rBOyVwNdFFbj6N6UmQ8RBNlDoL7PIeBc3GumFjVE4yKyc+rr4whtVnRpADkBpVamUXqI3SLEiUxLRWKZteXcmUNpKo9Q0wiyjzXGFhZIvg9ED4a8VNZZGy4HTs2b/wkhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JVRakVuvA3WMUnZPLkvHCaj9dbsH9q41SKzsTcvxp2Y=; b=lxLpqjUjZ5N0USLbQIeE/wqT+3fuPX4GZjN4akhuoP9MbsM0Iy//mOPgdnbbvwey7PXs/2BVMRXKNocdHfAUZfT2SDilGeVhlLw4AkFmTfUzYZ8gWSj9cOrdeEXxHrNm2WLklVfkYioxLS/sGzg0hxpw2EMO58VD80cVHCkjy+iknMyxZWqxfDf+8CaTvjZkLlx5l+KHlBG2FfRuX7mUmwxB38//niyO3prkULpEiBAlgXpmkc+ehPMKzA2X//EDMHsDIhJvI8IRo+uQXdgtt1NyUonCgxBzaMX9IJrADstNzGE9a+NVcdYEfqGR1/WH3axb2ivx7QXYibRBWnO04Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=intel.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JVRakVuvA3WMUnZPLkvHCaj9dbsH9q41SKzsTcvxp2Y=; b=T6GJZK4/l0cVmYx0v8G2qfOVvi3TYGA2u6tSQDg0x8XpBA6YCbXjqeZLe6l42S74vr7tKjGMImwFhUXdriidjENrIx8Z68H9XETYPHERR4akp0bO21cXTnfAi4FqugcbFj9RR5e6OOjxujySErwK10fqDF8u+GKWA1w3JK33G5Q= Received: from DM5PR18CA0057.namprd18.prod.outlook.com (2603:10b6:3:22::19) by CY4PR02MB2247.namprd02.prod.outlook.com (2603:10b6:903:a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.22; Tue, 15 Jun 2021 10:45:20 +0000 Received: from DM3NAM02FT060.eop-nam02.prod.protection.outlook.com (2603:10b6:3:22:cafe::20) by DM5PR18CA0057.outlook.office365.com (2603:10b6:3:22::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.20 via Frontend Transport; Tue, 15 Jun 2021 10:45:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; intel.com; dkim=none (message not signed) header.d=none; intel.com; dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT060.mail.protection.outlook.com (10.13.4.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4219.21 via Frontend Transport; Tue, 15 Jun 2021 10:45:20 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 15 Jun 2021 03:45:19 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Tue, 15 Jun 2021 03:45:19 -0700 Envelope-to: adrian.hunter@intel.com, ulf.hansson@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org Received: from [172.23.64.106] (port=49399 helo=xhdvnc125.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1lt6ZL-0008Sa-52; Tue, 15 Jun 2021 03:45:19 -0700 Received: by xhdvnc125.xilinx.com (Postfix, from userid 16987) id DBC2B1222CA; Tue, 15 Jun 2021 16:13:59 +0530 (IST) From: Manish Narani To: , , CC: , , , Manish Narani Subject: [PATCH 6/7] mmc: host: sdhci-of-arasan: Modify data type of the clk_phase array Date: Tue, 15 Jun 2021 16:13:56 +0530 Message-ID: <1623753837-21035-7-git-send-email-manish.narani@xilinx.com> X-Mailer: git-send-email 2.1.1 In-Reply-To: <1623753837-21035-1-git-send-email-manish.narani@xilinx.com> References: <1623753837-21035-1-git-send-email-manish.narani@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4316f451-e205-48c9-db07-08d92feaac0d X-MS-TrafficTypeDiagnostic: CY4PR02MB2247: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:2803; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ak0vKjV7B4As4Xp4mz30h+zeGldIO86NtEt1J4tI+L1zlIVUNTo+VAG8wxtdOGRGk+yR9mTsZ83Pt8ftEJ1LuUl2L6X0DrLmoU+TYaK2/8oY1SlMuNjiwfWEYoq9Cv9OfMPaQo23rblg6ePul4DraNpf7fxG4D6VQe5DVr2WnDOStHB0+Mr+HD4v9QHK/1LGVv5h69XntAwRmVJ/qPUNfFPDwEqXpyORrGJhUWIFcLjW738kA6ys49ayonyFP/qf1yRN2DmKf1jt2wRvYe/blJ63ewb7aKCcNqwQh1O/XdlHGQ1GaKXrBqKrSFX8AyuPw6WLrl2fVQk25LEoNy+A2XDi2+AwzAoVpJp6WVGtJKMfBqc882LXflPvfHOHPoorhskLjmexYdtDkwd5K3Q0IiSlNMNaFsHj93H5YVIorjPAAMNc9FaQR0JE9KkoL8SMRn1r/UKckJWU+YWeNUVOETGZmlxjzNiAZLh+amfcM/hPGtRx5o0J5XKEV8QOXQjNGor8kJiAAJ+HjTeghKcg9nwV0d7+GAW0Ub5OSjd56PcwTUws0bRrjh+YlihVwhSWraf3OriXnYifctX+87UvEzQbwWnVmLWbzE2UxFTdm0bLzGMPysVzWP7YQjL3GfGFCVfMeK4k/FnfdtkopfiJzsuWEuNgbftc3H95mv5eBYOfz0wSKTdI45QcoTMiy4rl X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch01.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(4636009)(396003)(39850400004)(136003)(376002)(346002)(36840700001)(46966006)(83380400001)(82310400003)(8936002)(8676002)(478600001)(47076005)(54906003)(107886003)(2616005)(82740400003)(70206006)(44832011)(5660300002)(186003)(70586007)(2906002)(426003)(36860700001)(36906005)(316002)(110136005)(7636003)(36756003)(4326008)(6666004)(4744005)(356005)(42186006)(26005)(336012)(6266002)(102446001); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2021 10:45:20.4178 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4316f451-e205-48c9-db07-08d92feaac0d X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT060.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR02MB2247 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org Modify the data type of the clk_phase array to u32 to make it compatible with the argument requirement of "of_property_read_variable_u32_array". Addresses-coverity: ("incompatible_param") Signed-off-by: Manish Narani --- drivers/mmc/host/sdhci-of-arasan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c index 510d8fc..61fe13c 100644 --- a/drivers/mmc/host/sdhci-of-arasan.c +++ b/drivers/mmc/host/sdhci-of-arasan.c @@ -1018,7 +1018,7 @@ static void arasan_dt_read_clk_phase(struct device *dev, { struct device_node *np = dev->of_node; - int clk_phase[2] = {0}; + u32 clk_phase[2] = {0}; /* * Read Tap Delay values from DT, if the DT does not contain the