From patchwork Thu Jun 10 09:46:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen \(ThunderTown\)" X-Patchwork-Id: 457847 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp259597jae; Thu, 10 Jun 2021 02:46:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyCehS4XWlWpNPhCRwwFlimFS6Vh1GDbTQAqI8JuZN7DCDWRFSr6YSxN7+OnKIiTdiOL+74 X-Received: by 2002:a17:906:a245:: with SMTP id bi5mr3799294ejb.316.1623318379903; Thu, 10 Jun 2021 02:46:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623318379; cv=none; d=google.com; s=arc-20160816; b=J8evOJzp2iPDF6p5L56dI1TRD5iIk1mS2TK1RVD08vlr4GbcZ4hRiC2AQXlyujp5kY eXhambbk5Q6XgXrDRyJnkXAU7PMJJzGyW9n8YZlOSAWRv2Ydc/2OrhGHBRR8U4X+MfHZ +aYKEWD2IWOrhnIMgqzqdnRbTBp3nrS1QS0z9+D2grbcd/cxWk2HnahW6i+GAfL0Kqiz snWOtcLsvK/m7fMnBy9xxhFjo6Z0koVwkmtQVqrwdfSC/mzczJF/TVc+YBMi7PM55iSF 1ovwQ3UcQ48v1qeXWTXqnhMDfGSN0GUhEdm9x4P7DI3hyqNRWyBXqoOXwk90zhlOu7be E9ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=I/1ITEVAB6ELtDfl4VqCb/5iSGwxp0mXprJ2ZyDx4C8=; b=HL51DCr5t/C2pg1kYXqNWAQ4cQ8M64YX+IA+16C9/i3EUvnZkpSU4Cviv5vYilrwlL pl74rZ92seCM0I5XzEYZFwFooQ/j6jRaalw+RoHbgJnKtXf8FscINHBQO4O5S75Xg4V7 8ddjbu0H4ZH2BIsJrdm7S1hH/zXjuzOx89DagIHNF0Nlh+n2c7R/eAB8wtvo6ZRIpI4O OQgTtMUqptZc9idUxtafoJW7nLdTjegeG24VTSCcFyNmOUED2wGDcPILI1GlY1nNUT9R Bqrypqcy7XJJA8XvreO+M1q62MLvALCvCOZlioD0Xy8zaE6qu4euWymVPElmMcEPGD91 0GGA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dj4si1903601edb.230.2021.06.10.02.46.19 for ; Thu, 10 Jun 2021 02:46:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230033AbhFJJsO (ORCPT ); Thu, 10 Jun 2021 05:48:14 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:9065 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230001AbhFJJsN (ORCPT ); Thu, 10 Jun 2021 05:48:13 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4G0zYn32zdzYrkG; Thu, 10 Jun 2021 17:43:25 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 10 Jun 2021 17:46:16 +0800 Received: from thunder-town.china.huawei.com (10.174.177.72) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 10 Jun 2021 17:46:15 +0800 From: Zhen Lei To: Jack Wang , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi CC: Zhen Lei Subject: [PATCH v2 1/1] scsi: pm8001: remove unnecessary oom message Date: Thu, 10 Jun 2021 17:46:05 +0800 Message-ID: <20210610094605.16672-2-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 In-Reply-To: <20210610094605.16672-1-thunder.leizhen@huawei.com> References: <20210610094605.16672-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.177.72] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message Remove it can help us save a bit of memory. By the way, change the return error code from "-1" to "-ENOMEM". Signed-off-by: Zhen Lei --- drivers/scsi/pm8001/pm8001_sas.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) -- 2.26.0.106.g9fadedd Acked-by: Jack Wang diff --git a/drivers/scsi/pm8001/pm8001_sas.c b/drivers/scsi/pm8001/pm8001_sas.c index 6860d5a9ef83b44..6f33d821e5453d1 100644 --- a/drivers/scsi/pm8001/pm8001_sas.c +++ b/drivers/scsi/pm8001/pm8001_sas.c @@ -118,10 +118,8 @@ int pm8001_mem_alloc(struct pci_dev *pdev, void **virt_addr, align_offset = (dma_addr_t)align - 1; mem_virt_alloc = dma_alloc_coherent(&pdev->dev, mem_size + align, &mem_dma_handle, GFP_KERNEL); - if (!mem_virt_alloc) { - pr_err("pm80xx: memory allocation error\n"); - return -1; - } + if (!mem_virt_alloc) + return -ENOMEM; *pphys_addr = mem_dma_handle; phys_align = (*pphys_addr + align_offset) & ~align_offset; *virt_addr = (void *)mem_virt_alloc + phys_align - *pphys_addr;