From patchwork Thu Jun 10 07:40:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen \(ThunderTown\)" X-Patchwork-Id: 457810 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp146063jae; Thu, 10 Jun 2021 00:41:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzUmqvKtxDEoq6Gsm5DZijTVqIffCMFVh5PKj4tHxj/DkXvNA2GEYlWsFavc+u44YFM6BTh X-Received: by 2002:a17:907:1112:: with SMTP id qu18mr3102859ejb.511.1623310864799; Thu, 10 Jun 2021 00:41:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623310864; cv=none; d=google.com; s=arc-20160816; b=pM/1MkMmzYdmS/6cEq+/OL6Soq9+UWoYYYmbTqNE7O8tws5FF5sEwS+xIKuKMAZ9/r xjKeTHcsm9yu6zMKMIenf23fu9H5JTlwQrQS4S9WJ2DG+Hcm7bLMpbp5AZxOLD8nUnuk /X0n/EdNYvmtssVSj5EauZo7I1OZVXwebPTtDq4VEW5WcDAy7rT4YsunNKE41Q/BfBCg /e/egUAYFuFFNptlsxO4ab3tC/FfGRzmPraSKNQpdiCUBAba4aLVYfl+dPaEoIDbL9/o ekuU3L9vSVUov671onOSbYlCrpttQFn+eUk8XsMz3wH6pcXF/9RIMwnxauXkDIJNjpeM rhpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Nmem0+oKnfV6lI+LWyz9v1qn/6ql69BN8A1PNrwLYO4=; b=v/i58INUWLAGmhqAY+X99epMdU3z1MG4Hyk/aN7sUJ8NZJ/0MgiXjsoFdTYooJTFtE J/R6sWUgqNKj2nJXZ0+H6b2iMvOoQEPX494qWgnqKWlA3Ii8haEf7wDpuO78nWABDcLG d0PRhtxjWwO/qJWz4SSDhCG+rWCUpzK1ZuFgDo0yAKYDwZ4HkqrNNI2d6SDAwSUy3C8q cyk5fsb3o3eU5flIS1kCe2ZanCvJDNd0+hE//2mHZiK3Ee42o7AWy9PycQmH2ilFngWY fMKpbj1UMivythk72uuU5kOUC42JeL2AnbnkTuj7lHG2WvSmvxEkuYqK2vXNfvcRr92V sbng== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gv12si1706850ejb.679.2021.06.10.00.41.04 for ; Thu, 10 Jun 2021 00:41:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229941AbhFJHmQ (ORCPT ); Thu, 10 Jun 2021 03:42:16 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:3934 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229634AbhFJHmP (ORCPT ); Thu, 10 Jun 2021 03:42:15 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4G0wm92Rncz6x9v; Thu, 10 Jun 2021 15:37:13 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 10 Jun 2021 15:40:11 +0800 Received: from thunder-town.china.huawei.com (10.174.177.72) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 10 Jun 2021 15:40:11 +0800 From: Zhen Lei To: Adam Radford , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi CC: Zhen Lei Subject: [PATCH 1/1] scsi: 3w-xxx: remove unnecessary oom message Date: Thu, 10 Jun 2021 15:40:07 +0800 Message-ID: <20210610074007.15453-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.177.72] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message Remove it can help us save a bit of memory. Signed-off-by: Zhen Lei --- drivers/scsi/3w-xxxx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.26.0.106.g9fadedd diff --git a/drivers/scsi/3w-xxxx.c b/drivers/scsi/3w-xxxx.c index 4ee485ab2714845..a7eb50d2592ea1a 100644 --- a/drivers/scsi/3w-xxxx.c +++ b/drivers/scsi/3w-xxxx.c @@ -836,10 +836,8 @@ static int tw_allocate_memory(TW_Device_Extension *tw_dev, int size, int which) cpu_addr = dma_alloc_coherent(&tw_dev->tw_pci_dev->dev, size * TW_Q_LENGTH, &dma_handle, GFP_KERNEL); - if (cpu_addr == NULL) { - printk(KERN_WARNING "3w-xxxx: dma_alloc_coherent() failed.\n"); + if (!cpu_addr) return 1; - } if ((unsigned long)cpu_addr % (tw_dev->tw_pci_dev->device == TW_DEVICE_ID ? TW_ALIGNMENT_6000 : TW_ALIGNMENT_7000)) { printk(KERN_WARNING "3w-xxxx: Couldn't allocate correctly aligned memory.\n");