From patchwork Tue Jul 24 09:35:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 142745 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp7051499ljj; Tue, 24 Jul 2018 02:36:41 -0700 (PDT) X-Google-Smtp-Source: AAOMgpefj7H3EhgyvFKiDO3BTdbJkLb3GkmkN/p8bOouRYBJd07RCkPIQgzUr/DV5CqFxnZoF994 X-Received: by 2002:a63:4106:: with SMTP id o6-v6mr15790143pga.453.1532425001501; Tue, 24 Jul 2018 02:36:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532425001; cv=none; d=google.com; s=arc-20160816; b=dPPI0E+lTm36fyy77MIzuTJMsLflrVh1z9CLq57SJr6EAT+Mihuuh2OKpvjUIR9L7e eXA59ATlgja+89I3tzVhxC84xI7svVRlOzggwuZFOfuwso4PSexYYcJVfIbPzXWuD60B 45fbyw07xluqrxFAmXtJkAN7pLnxmZx6cN8Efbsi/17m88bvocbXoIeX026PMxbyQ5Ex 6k2tGTb0+vAgku37D/T/qAHWXUFop7nOQrUuqej3MgXiAFiABqgYKrYVY6gzsSIXbMyq u+akTbR6YyQXyF2QGv1bNrUxZbz4UtQAiFt3Zsve0ualDmMxeMCH76C8WIcVHsJt9Oad NynQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=kNQtb55KXQkaJx7CF8fAg9cXxQPLGulrp96J0e9KMOk=; b=qvC1aK2lUW+7Fr1uOU2E8ipT/AYesBr83/jVCr67/qGiWx9ONn3InF87RQ53+ywp+O Ph0cd8HMVIJJeqrJEDlOz2+STP1dYi5g81gHKPQJzOmYlfVFgaZKGpdZTvJU0AW8hgID ZpjdYueOkHL3v6jJ6wDY84rYLsc9U5r1kSd+M2XeCr70SDcTv1LR2n/oRwQkmLcrrfJU BzGwcQbBfqSTdVRNn66apuYCwm48HU1yOUaHgrt8Cy5nO0f+F5o7uXUVbdQRuyrKUUEY a0FHKzANMWbLD2qNXzUn7wzygxT07HnVyDwvP7Y5Ic1+fTezNmrdPmvGDyC7oX1NecCz n38w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-media-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m3-v6si9913531plb.27.2018.07.24.02.36.41; Tue, 24 Jul 2018 02:36:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-media-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-media-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388190AbeGXKmP (ORCPT + 4 others); Tue, 24 Jul 2018 06:42:15 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:41737 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726367AbeGXKmP (ORCPT ); Tue, 24 Jul 2018 06:42:15 -0400 Received: from wuerfel.lan ([109.193.40.16]) by mrelayeu.kundenserver.de (mreue103 [212.227.15.145]) with ESMTPA (Nemesis) id 0Lo2Ke-1gEka42Ecy-00g2wo; Tue, 24 Jul 2018 11:36:28 +0200 From: Arnd Bergmann To: Lee Jones , Mauro Carvalho Chehab , Hans Verkuil Cc: Arnd Bergmann , Jacob Chen , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: platform: cros-ec-cec: fix dependency on MFD_CROS_EC Date: Tue, 24 Jul 2018 11:35:59 +0200 Message-Id: <20180724093624.1670671-1-arnd@arndb.de> X-Mailer: git-send-email 2.18.0 X-Provags-ID: V03:K1:5wE6/zZnGM93XxbcP+X04QrxoC1REJYXYxT9bTmgAtrnRoEBST1 jMpJEOMNdtXBz17gEDYlz3zUD/PiVzroamn51UHR3I7Q1r8z1WQUL0J4s/8nN6k6BDt4DhP RomabAJK4fWrW+mbQVT5eM8W0WRaddjUWe+Tl8S6QdYJjYzEAB1REDLLBc2rLWUB8sCKcNC cALz2KuQvinQWN285T+Jw== X-UI-Out-Filterresults: notjunk:1; V01:K0:6d5EYb9kV+c=:C0IWJjJ4cRkUkMDCuomgIP QslonKouI5Ecghwhjv/XEBdu859Y5Z3wPNOJ58cGBPJL80JvIUt7+MK7NjF9X+VFbVbj8jFxC 9W0d0cS+/sOEKAEfDK+d210VRmPP4VIoJlqYCvHLrvn/IGRr6ELt3gkZt2JBsjc/3LeD3TWdQ X920tKpBwhkswSnOteV6PWx0srRf1PxeyujcqVTkdW0coImtd2qf/faE0dI8XWJJBJTxcA5ak utHYmw3nRDg7vlDTmCmaTcraveHtKLNe7Z0THtQ0ZwUolty8GGfEdCQivxw4dwNQlRd0c4fB4 XuUD/IlGQ08tkGt0rzIN27eFglsZ38IhaLD7QtH+1+T98UA8HIp13910ziVxtOgWa/1CRJjjx I0Gvf5o06sQj2w+guXxxtKEUIKqAEeXzAA/Em6Cae3bhAeBIVpcGtvECn7O65VOgurUqMDkCD HMq15vI+oCs/VV2XtVh8tVmBltg+3l1a1+ra1GCua5QGmOR//4eoJ6RWRU6L/10UAftTErPin Dnf4w73IMql9rQW3gQlb+zXu4R5mWvWapJD1WFRf4O6EXtdnyeleRjw7I3T+u/GRjfvQ0KYpN ceF4mcrnEqTKEysV32BLwopcN5o+fTGBSv43i9J1flX9xRPuSzisGuMQ+6heXNcdXxIUXEH3p ep3/2hBT5Y5zLCzxQiKCXJiwzaNuhVsXoQiwekCAyltQg/P2mZK3VstgZI1SXJnymVnE= Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Without the MFD driver, we run into a link error: drivers/media/platform/cros-ec-cec/cros-ec-cec.o: In function `cros_ec_cec_transmit': cros-ec-cec.c:(.text+0x474): undefined reference to `cros_ec_cmd_xfer_status' drivers/media/platform/cros-ec-cec/cros-ec-cec.o: In function `cros_ec_cec_set_log_addr': cros-ec-cec.c:(.text+0x60b): undefined reference to `cros_ec_cmd_xfer_status' drivers/media/platform/cros-ec-cec/cros-ec-cec.o: In function `cros_ec_cec_adap_enable': cros-ec-cec.c:(.text+0x77d): undefined reference to `cros_ec_cmd_xfer_status' As we can compile-test all the dependency, the extra '| COMPILE_TEST' is not needed to get the build coverage, and we can simply turn MFD_CROS_EC into a hard dependency to make it build in all configurations. Fixes: cd70de2d356e ("media: platform: Add ChromeOS EC CEC driver") Signed-off-by: Arnd Bergmann --- drivers/media/platform/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.18.0 diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig index 92b182da8e4d..018fcbed82e4 100644 --- a/drivers/media/platform/Kconfig +++ b/drivers/media/platform/Kconfig @@ -535,7 +535,7 @@ if CEC_PLATFORM_DRIVERS config VIDEO_CROS_EC_CEC tristate "ChromeOS EC CEC driver" - depends on MFD_CROS_EC || COMPILE_TEST + depends on MFD_CROS_EC select CEC_CORE select CEC_NOTIFIER ---help---