From patchwork Sat Jun 5 08:52:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Niklas_S=C3=B6derlund?= X-Patchwork-Id: 454875 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 746ABC47082 for ; Sat, 5 Jun 2021 08:53:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 570356139A for ; Sat, 5 Jun 2021 08:53:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229902AbhFEIzZ (ORCPT ); Sat, 5 Jun 2021 04:55:25 -0400 Received: from mail-ed1-f51.google.com ([209.85.208.51]:37657 "EHLO mail-ed1-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229864AbhFEIzY (ORCPT ); Sat, 5 Jun 2021 04:55:24 -0400 Received: by mail-ed1-f51.google.com with SMTP id b11so13893358edy.4 for ; Sat, 05 Jun 2021 01:53:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech-se.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=sTZMNkSkrxsY19WZ8OOJ+AdlEgOY7uEkgMHRF1lc4/0=; b=do+tIaxIuO4sLd4cTYpazgGGnIq/lovmcYVs3lJD3uzrGuaadkfpDihyxYLVbzLcca RYxsgdvSPxLW0oenuiE7HIlbr/qP6Bmvnps/e/8A5NQZhR5LzG/lvzIa6ql0DQGP6B6a LD+mlaQXSJIXvHcCDgRQBCe3W8kKMxmJWQI3Sj5ePnJv6s3CXiAsSuuaj59vBYcaWElF ZIcu6ojsgEUVJrevo5g5E9KdG2/jInP50KiReThmP40WXUI4wGcenZr1yPWsNfbGEBeN aCUoH7vHz4nzkwbnjYAnwcTRW3loVRdw5crgS0kST4zeUKm+QmVdMHq98dKKc4haMDqY e+8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=sTZMNkSkrxsY19WZ8OOJ+AdlEgOY7uEkgMHRF1lc4/0=; b=iWkP1fTU/Ne2rME9Ow4Zxly27y/PQogrgx+iSrCw5mQaCYbkcuytQOzCDKF9Lhr27Z 57cEDlkHxiz3fYnotOiC/8CCUpFsVIIz1LD3PSrPprFm70Ytyp6JX+wTNEIAyfUn+gM9 Mbj9VI+uoT48NGex8Z1rXrJ+TDGoXpJtwRz9997FVv/538nwjn2rQye1KEYUsrhpc7rD yB/r7M7UcSBBFBdcPgi+kL9/0MR3uBVq+mZEL5HM+jv5+e93I6dMWqoATrUyXLqO1M7z 7lb3doVJsWWsGgIXs6sEz67w8kvDSP0zozP5HbuxrNyvQk+9RA/jCjwxzZmsnM9zXJcP R/Cg== X-Gm-Message-State: AOAM531S/72x3LtslroM+GVEFlEZ6/qRzsNafF2e8JlB02Z+V/haQCvh Brk1CqknFjDGSoYbHEWdeoLYlQ== X-Google-Smtp-Source: ABdhPJyHK9fA6NLR1lXAqdaGTc+gPWKpYXYPv2HuQsdl0myrddD5fxhFN1Y/ksf0pXMAB5NtWNdGtA== X-Received: by 2002:a05:6402:35c4:: with SMTP id z4mr9128935edc.362.1622883143381; Sat, 05 Jun 2021 01:52:23 -0700 (PDT) Received: from bismarck.berto.se (p4fca2710.dip0.t-ipconnect.de. [79.202.39.16]) by smtp.googlemail.com with ESMTPSA id e25sm3823412eja.15.2021.06.05.01.52.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Jun 2021 01:52:22 -0700 (PDT) From: =?utf-8?q?Niklas_S=C3=B6derlund?= To: Daniel Lezcano , linux-pm@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, =?utf-8?q?Niklas_S=C3=B6derlund?= , Yoshihiro Shimoda Subject: [PATCH] thermal: rcar_gen3_thermal: Fix coefficient calculations Date: Sat, 5 Jun 2021 10:52:11 +0200 Message-Id: <20210605085211.564909-1-niklas.soderlund+renesas@ragnatech.se> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The fixed value of 157 used in the calculations are only correct for M3-W, on other Gen3 SoC it should be 167. The constant can be derived correctly from the static TJ_3 constant and the SoC specific TJ_1 value. Update the calculation be correct on all Gen3 SoCs. Reported-by: Yoshihiro Shimoda Signed-off-by: Niklas Söderlund Reviewed-by: Yoshihiro Shimoda Reviewed-by: Geert Uytterhoeven --- drivers/thermal/rcar_gen3_thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c index e1e412348076b2ff..1a60adb1d30a011d 100644 --- a/drivers/thermal/rcar_gen3_thermal.c +++ b/drivers/thermal/rcar_gen3_thermal.c @@ -143,7 +143,7 @@ static void rcar_gen3_thermal_calc_coefs(struct rcar_gen3_thermal_tsc *tsc, * Division is not scaled in BSP and if scaled it might overflow * the dividend (4095 * 4095 << 14 > INT_MAX) so keep it unscaled */ - tsc->tj_t = (FIXPT_INT((ptat[1] - ptat[2]) * 157) + tsc->tj_t = (FIXPT_INT((ptat[1] - ptat[2]) * (ths_tj_1 - TJ_3)) / (ptat[0] - ptat[2])) + FIXPT_INT(TJ_3); tsc->coef.a1 = FIXPT_DIV(FIXPT_INT(thcode[1] - thcode[2]),