From patchwork Fri Jul 20 13:14:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Protsenko X-Patchwork-Id: 142473 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2956333ljj; Fri, 20 Jul 2018 06:16:02 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcax3agexEulVBuIfjwXVPGMMgfMIAKiMhZxv/tTmHJE1rTcloD2pqHxtLyTYNuLBcHiPLF X-Received: by 2002:a50:b37a:: with SMTP id r55-v6mr2559251edd.145.1532092562675; Fri, 20 Jul 2018 06:16:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532092562; cv=none; d=google.com; s=arc-20160816; b=p0rpsEm0WSkE9oJQu33twirkwFj7Zl++P/DR2WogbcppeKMblPF48p8cDNmd/bleQC lexcz7dcPZxWmaP3zSIqspovVQKRQvNawxK8DXlv/31IHkKx/b5PV0H1kilDMJII1vpB hBrlbjVmf4qQI2x3rMCv27ZAhazLV6pw2MaP2yMF77DwMlcdRhbIWvl/6OLKdcAO1jKk iIVw2USpeenccIea5KMCjPnE2FhgGWEzvXnFmXDaxqQm0s7MMB8m7NRU/BmwEahPYDTa GzpyN6AqGKa0SdnMYEbibCATivMb4brsOGkko3jnev0TRmjl+iDIu6Y+MGrTVfmMOz+W ch8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:references:in-reply-to:message-id :date:to:from:dkim-signature:arc-authentication-results; bh=8XqL0Xo7Y2Yjx3ZsjKc4L8mINx3POa05Y0sbQ3uNBQo=; b=DxUdvXI3zrAJar+64XRGtwN4UsJO4pJgeI0VH8Z/ynsARyjhg8fTfytHIVjz2s494o iZpL6cPcYtGlqmiuNCTaoG635+7cD4UOQW3JyP24p+CFRyQDCynHsVZ4d7xDoGOfIs+w 2PeGhwcamWnVU23EQCLIDY2Kf1AJKuId1BnQRYvrNHUgCaFj26cJweBc8uRj3xHFnC7K 0eyUmSi+PNpa1zjK2QzSa0YmaO2VfNUZFggpZGCQWLI01YyYVXb+Hyio43kUpVoYNoe2 lmhIU/MGLkH++Zf6Ajh7i7Xl63/ThC9SVuzcM3/egTO4Z4lvcZyKSoTZMbfqjvIxiP8O nFDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=ICLgFeol; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.denx.de (dione.denx.de. [81.169.180.215]) by mx.google.com with ESMTP id p27-v6si2143607edi.276.2018.07.20.06.16.02; Fri, 20 Jul 2018 06:16:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) client-ip=81.169.180.215; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=ICLgFeol; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: by lists.denx.de (Postfix, from userid 105) id 46223C22031; Fri, 20 Jul 2018 13:15:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 7CFDBC22034; Fri, 20 Jul 2018 13:14:45 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 8094DC2202C; Fri, 20 Jul 2018 13:14:29 +0000 (UTC) Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by lists.denx.de (Postfix) with ESMTPS id 3ED0EC21FC2 for ; Fri, 20 Jul 2018 13:14:26 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id f1-v6so9466108ljc.9 for ; Fri, 20 Jul 2018 06:14:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=l1bpGr39eNcaA+PnBTNU0ViaeCxonxFNG5wYLXASjKs=; b=ICLgFeol5o0zHM9Bw24lyBEyPwn6sdOd3eDFwhlQmFbjseWahutmzr9eYI4Xf0Ij5u Nnn/RJ4I+GNdKnyFF6OTnCDX8zOPKdAT8o8ejuPOlSMmWQ5+UgDXBHirnexE+31n7qpz 80AnvWhpAWKDL/tdIpyNCeKBfx6RkVN+CDy1U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=l1bpGr39eNcaA+PnBTNU0ViaeCxonxFNG5wYLXASjKs=; b=SkEiswBWzQF2lSNt5E4Uby8qv7facKqM+X6eJg9KttO8chtjnjkpYLVJ+39liYz5xn SaxWKIJkiiD7C4a9bERmdqkRT4EEFv0OyhmFqwcmH9M65fDJzDD/v+Z1vjOicRFeqmRW LgsQ9myV5rBTWGet451bosyx4B7YGVTpqYIrXoBKsFJXcQEd3dOjdCBNX9V0753lhcZE u2ua1nT7FFWWn/eAIZ369P5oknu4/AfVZ54vyK9nh2e2GIYOFOa9w4c97L1SzXlO2PSr Z74pF+xr8C1yzFiqO7gbEJ/RjH8BA6/w3o1zh/QshD5jKr4XaL0QgCLI/g4Jn8Nq9uSK uGyw== X-Gm-Message-State: AOUpUlGe29AAglRDYEYHdi35rBUNvznWDxciGc05jvXRLSMnJKsimWlz 45eNOFimqw7O2DUabv3VN3RV+aVlX+gqmA== X-Received: by 2002:a2e:83cf:: with SMTP id s15-v6mr1792267ljh.101.1532092465435; Fri, 20 Jul 2018 06:14:25 -0700 (PDT) Received: from localhost ([195.238.92.132]) by smtp.gmail.com with ESMTPSA id i75-v6sm296975lfh.29.2018.07.20.06.14.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 20 Jul 2018 06:14:24 -0700 (PDT) From: Sam Protsenko To: u-boot@lists.denx.de Date: Fri, 20 Jul 2018 16:14:20 +0300 Message-Id: <20180720131421.7136-2-semen.protsenko@linaro.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180720131421.7136-1-semen.protsenko@linaro.org> References: <20180720131421.7136-1-semen.protsenko@linaro.org> Cc: Maxime Ripard , Tom Rini Subject: [U-Boot] [PATCH 1/2] env: Don't print "Failed" error message X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" "Failed" error message from env_load() only clutters the log with unnecessary details, as we already have all needed warnings by that time. Example: Loading Environment from FAT... MMC: no card present ** Bad device mmc 0 ** Failed (-5) Remove this "Failed" message to keep log short and clear. Signed-off-by: Sam Protsenko --- env/env.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/env/env.c b/env/env.c index 5c0842ac07..3ab4ec4237 100644 --- a/env/env.c +++ b/env/env.c @@ -196,9 +196,7 @@ int env_load(void) printf("Loading Environment from %s... ", drv->name); ret = drv->load(); - if (ret) - printf("Failed (%d)\n", ret); - else + if (!ret) printf("OK\n"); if (!ret) From patchwork Fri Jul 20 13:14:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Protsenko X-Patchwork-Id: 142472 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2955483ljj; Fri, 20 Jul 2018 06:15:18 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdRMK8PtGg7WPlxtIq2Yjo+/hN2x4SCT7bTe5kUyqqtRoB1lFzkCT/4lPC2hWU5Jal+mof7 X-Received: by 2002:a50:e885:: with SMTP id f5-v6mr2607097edn.39.1532092518785; Fri, 20 Jul 2018 06:15:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532092518; cv=none; d=google.com; s=arc-20160816; b=A5fdJefwTncNzB5JlebghzKG+j6TA/FC7u1h7wSi7kn+wIvXfoa35MJEX1TdEMnLVy oBjB9VJKoSjeuorq5fczpxU6qWXWJPCTGRk5dvQ2HfLaDEpYyPXP3rd1BG/gA1EELiFw vccgpzJsRL93GoiHtP12wkLkpZPjZphybUxVsw3oXiNYoue65VAlX55Lyk5xaTFVWBJh bFlGBKPC8eW0W2yHAIADTyhaDDZXtcoJ01A2i7uN69/0Sj+fNctGLp7o65xYe8pUIU39 3Q/2nJsDxnIJ4+DEI9a4AYim5RpwNfBgRd/Lv6O0GKSO2Nw7vJNTPDBfU9np9eHO/xNz Fo9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:references:in-reply-to:message-id :date:to:from:dkim-signature:arc-authentication-results; bh=sRWD7qaVw8LPptq0qMnSirk6KMwPKZZoM08h44Ntb1Y=; b=FVkKnZdsgaSHQH/PTuZsAorEkWxFMuRvwjQpg/26s5ChP647HBltK4Ksx4Q2liRfwd lqclQhDVN1K6AscBFn0KgRMLTMd9ej1N1FK6riJhbQMk4HA9lYrDyAqUkwUlzHKfr1mY LHwa/ZUuqB5co7ns1exih7p3lOvFi+3UDl4dF7hkroKoQ0RyPwibZ/uf/zf+uICrQ7pV WNZU4hBaTxwdr6UeNwEbwQDV+RVZNSYwnI2KQBa4HKf0inrBvqq+k3OiOomCaZBC1hIf DB164lW7H53vtAnIF6GZJbxOEPFpNsCxXHljPaIZiw+vv7pmo31mCHib0MvAai23lmmd sqAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=LFI5jRG9; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.denx.de (dione.denx.de. [81.169.180.215]) by mx.google.com with ESMTP id u25-v6si1451190eds.287.2018.07.20.06.15.18; Fri, 20 Jul 2018 06:15:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) client-ip=81.169.180.215; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=LFI5jRG9; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: by lists.denx.de (Postfix, from userid 105) id 40E8BC2201D; Fri, 20 Jul 2018 13:14:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 8E86CC2203A; Fri, 20 Jul 2018 13:14:44 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 23F00C22008; Fri, 20 Jul 2018 13:14:31 +0000 (UTC) Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by lists.denx.de (Postfix) with ESMTPS id AA184C21FBE for ; Fri, 20 Jul 2018 13:14:27 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id r13-v6so11119070ljg.10 for ; Fri, 20 Jul 2018 06:14:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=PDbLjsqkmwVZKVR0bgqrRmN5NFNpYp2kBLSmQNdkBHw=; b=LFI5jRG9F6hACUAJTiM5W9hIcLPWGTX76r1PQy9KzL0OWi7WHvjY3oDATET4DMZiZA uozAGFrsZmXHaUEofLHg5b1LF1J4FdLInSD5XWU020l8cuZ9/rqdyyP5qUD1um8Ul9tG +bTzeC/cAXvk/UNKh1LC/ESv4Fr9EaOlCht5A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=PDbLjsqkmwVZKVR0bgqrRmN5NFNpYp2kBLSmQNdkBHw=; b=bIHUHQcX5H+xTLT2rSpzDaQPq61aNBzDL0uJ3YJf9yJ9qzBb/HhQ1Y2tuttcu+VXYJ T+2cW6pvS8NnxAyf9tHqfjhEg5djmYCwnD+B9foS73wY5vLNwUhRFAe9s+2IovXHb35d w90LV5OqUhzR0twMZBt0EN1Jsc4mx8kF06pOvwqB8bGw/O7HkadlzjzJw1EY/1utyVrQ VODNApLblrd5wsFBA+RaBvgvGjIzMDf1fg9Zswng+mTAfZvBY1LPnvDe9M7vNIULGYeD 00pvZT2c6t/Qo5hT4vTf1DnCcFy7r6g1bPi0ghdLmy38zmgHqYYqngrD/bb107BFOkOi hdFA== X-Gm-Message-State: AOUpUlEz9u1/ljg3QaCKYOcRVAuOM+pqVOZHKdDXoW3tSWaygMUSnstO FA7z/pDUbCzwqLmv76+kk2NyB6XrFmyuEQ== X-Received: by 2002:a2e:350b:: with SMTP id z11-v6mr1747640ljz.55.1532092466890; Fri, 20 Jul 2018 06:14:26 -0700 (PDT) Received: from localhost ([195.238.92.132]) by smtp.gmail.com with ESMTPSA id 20-v6sm356499ljs.32.2018.07.20.06.14.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 20 Jul 2018 06:14:26 -0700 (PDT) From: Sam Protsenko To: u-boot@lists.denx.de Date: Fri, 20 Jul 2018 16:14:21 +0300 Message-Id: <20180720131421.7136-3-semen.protsenko@linaro.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180720131421.7136-1-semen.protsenko@linaro.org> References: <20180720131421.7136-1-semen.protsenko@linaro.org> Cc: Maxime Ripard , Tom Rini Subject: [U-Boot] [PATCH 2/2] disk: part: Don't show redundant error message X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Underlying API should already print some meaningful error message, so this one is just brings more noise. E.g. we can see log like this: MMC: no card present ** Bad device mmc 0 ** Obviously, second error message is unwanted. Let's only print it in case when DEBUG is defined to keep log short and clear. Signed-off-by: Sam Protsenko --- disk/part.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/disk/part.c b/disk/part.c index 9266a09ec3..9e457a6e72 100644 --- a/disk/part.c +++ b/disk/part.c @@ -400,7 +400,7 @@ int blk_get_device_by_str(const char *ifname, const char *dev_hwpart_str, *dev_desc = get_dev_hwpart(ifname, dev, hwpart); if (!(*dev_desc) || ((*dev_desc)->type == DEV_TYPE_UNKNOWN)) { - printf("** Bad device %s %s **\n", ifname, dev_hwpart_str); + debug("** Bad device %s %s **\n", ifname, dev_hwpart_str); dev = -ENOENT; goto cleanup; }