From patchwork Thu Jul 19 22:28:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Protsenko X-Patchwork-Id: 142384 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2256008ljj; Thu, 19 Jul 2018 15:30:05 -0700 (PDT) X-Google-Smtp-Source: AAOMgpd3edBPjY4nFEqSr/cLO7QAoAHkkqM3F5cmhOVFEW7LsezrzscCVx0tgt+rivp0rRpmGEIp X-Received: by 2002:a50:97fc:: with SMTP id f57-v6mr12379343edb.21.1532039405041; Thu, 19 Jul 2018 15:30:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532039405; cv=none; d=google.com; s=arc-20160816; b=LiRasd2lXbFadSNvwyGSUgNidvSsvXKuLR1oh51D04j2F1Qk8DpuxLkC43C8o1/2eo 4MvLf8+va7l4j/StWvOhpqC2EXvFAwYthLrLrVfaYbWboXi6Tfu9C85vhDmTfDYQNUPN L20q/WY68asyPhHlOO+ASASZWx68f46gyc92kaGRgtBeXvuorLH1FN1ic4+R2xAsFZir 7sVsEyRx2X8wqS/LYJrE9d6CQDjjyWS87lBpF1SyOG6N9xcuJdtm9moBaFFNRi315WNy osQXzCfaq2m8gnfNSm946/Opqw9yXpf03e+1KWCRMId5t4Q8whFjZ2X5l/iAiie4ITCI b6mA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:references:in-reply-to:message-id :date:to:from:dkim-signature:arc-authentication-results; bh=5rbrnV6pKCrEKu/FSg8G0mkOswGHg6jrDElNhB6rGtE=; b=nPqMKQAbiduGcn843RF7buCYihWbhbep3HAOJI+VArEONt1cxNOi5xCTBzIUYnMYt4 d3qsZTRAvuE0gO5yHcyhn8377AmctzI9mJyLZiSiPD3ixzEzMApSZKHQpZmagFPaDfKo Jg3Xsl/tiYkU89vs3kZ/UN+T8OtU93ttwYRFZ5NKEM9RjKlYDvOdx+q7Xx7vlISs11Ny kQbMaymuf+aL3R2uEazDsxtH/mFDPBweyzhQRHyDLIC+k3Eu2X0bo6HLDiuQVWVTYqz+ E5Zg6aZD2fK/BqvLEbkbDzDjGX6rQhIiDfb+XsiZdjoGAdqHZ3v2eUthF1xDemHFHVao ckKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=TttjbdUS; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.denx.de (dione.denx.de. [81.169.180.215]) by mx.google.com with ESMTP id n38-v6si539987edn.443.2018.07.19.15.30.04; Thu, 19 Jul 2018 15:30:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) client-ip=81.169.180.215; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=TttjbdUS; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: by lists.denx.de (Postfix, from userid 105) id 9664CC21E1B; Thu, 19 Jul 2018 22:29:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 2D59AC21DFF; Thu, 19 Jul 2018 22:28:55 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 827E5C21E07; Thu, 19 Jul 2018 22:28:50 +0000 (UTC) Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by lists.denx.de (Postfix) with ESMTPS id E404AC21D8E for ; Thu, 19 Jul 2018 22:28:46 +0000 (UTC) Received: by mail-lf1-f65.google.com with SMTP id u202-v6so450249lff.9 for ; Thu, 19 Jul 2018 15:28:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=jZNaQmYi7VhLCeJvG5avWO6b6mP0feXJj+S95Ok35us=; b=TttjbdUSZp8TiU8DFzLqCxzcvfK+wEJbRrCUdCTf7ed0xEaTWPBMmwvjSjO0Z5Zer6 XX6M3UGFfW/Ah8p20Mpxd1ri4DQWgtBNhjlN6suxX/KjWzgMHrJ8UixCs2CqmdwnBzMg xTszezEU5wXlLGJJJrbq/aTKZaf+WXIUHEl6w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=jZNaQmYi7VhLCeJvG5avWO6b6mP0feXJj+S95Ok35us=; b=Q75+qX+63Vq4d+i1p/vcskbkxzgA4VAKnWx7xrY54a1eLtFXXszVPQdAFmru/L6l6O abTkUQxYJITroYMpI9E1DQezNyyvjEtOt2gNej6koE2sJFJepyp+GP4IRDea9x9SzLoJ NLb9j24Edqsll0lHIARjS4igfzuaVMqNbmjDmvJXBkAXweX1lZd7QxQ3Ri8b36fXN9KN h5tZJvxNSox7GZL/KeecHO4zTQB5IvgMhMb+OvSrKvlhndtELe8a2JbbQxDUPLf8kiw4 5fCVC+uoalekXR09HRiBDsc7YdynW6C2eoZr0UuoquVAnnqORBw6fO0XqPsMbtRjz2dK Elhw== X-Gm-Message-State: AOUpUlHkWGHZSF1CR3JbD4KfsEjGirlOMXt+wj4gc7e/I9yC/u4xN+8x N9bhxxd1RyOmxt1+q+IhE7HFlX2oyvR0wA== X-Received: by 2002:a19:a685:: with SMTP id p127-v6mr8177479lfe.4.1532039326039; Thu, 19 Jul 2018 15:28:46 -0700 (PDT) Received: from localhost ([195.238.92.132]) by smtp.gmail.com with ESMTPSA id s23-v6sm53654ljs.38.2018.07.19.15.28.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Jul 2018 15:28:45 -0700 (PDT) From: Sam Protsenko To: u-boot@lists.denx.de Date: Fri, 20 Jul 2018 01:28:42 +0300 Message-Id: <20180719222843.28316-2-semen.protsenko@linaro.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180719222843.28316-1-semen.protsenko@linaro.org> References: <20180719222843.28316-1-semen.protsenko@linaro.org> Cc: Maxime Ripard , Tom Rini Subject: [U-Boot] [RFC PATCH v3 1/2] env: Don't print "Failed" error message X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" This only clutters the log with unnecessary details, as we already have all needed warnings by the time. Example: Loading Environment from FAT... MMC: no card present ** Bad device mmc 0 ** Failed (-5) Remove this "Failed" message to keep log short and clear. Signed-off-by: Sam Protsenko --- env/env.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/env/env.c b/env/env.c index 5c0842ac07..3ab4ec4237 100644 --- a/env/env.c +++ b/env/env.c @@ -196,9 +196,7 @@ int env_load(void) printf("Loading Environment from %s... ", drv->name); ret = drv->load(); - if (ret) - printf("Failed (%d)\n", ret); - else + if (!ret) printf("OK\n"); if (!ret) From patchwork Thu Jul 19 22:28:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Protsenko X-Patchwork-Id: 142385 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2256074ljj; Thu, 19 Jul 2018 15:30:08 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdlSv4br3c9spFDKzGlo+9c1AXVYXfD7EQGorPWMiaaoiCS4ZSNVsU94t1860UzVXHII0ht X-Received: by 2002:a50:d59d:: with SMTP id v29-v6mr13188412edi.307.1532039408844; Thu, 19 Jul 2018 15:30:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532039408; cv=none; d=google.com; s=arc-20160816; b=EfJITZcIlCpB09NpeEphBSVGt8X6jRKr8XcKF7Vl/qQrY4W3Y1bBVcTe78AA0pU422 eujQQZwnTg8DjvzUiDLcX7DVscNlcRrc5KwyZAJubsrpVOfQ8XFMMeJXvnzaEBNWpxHJ ub+ENp80aC8lmdER9ffkiNCOzadcsJd55f41fw3yrkkozKM4W+x1zUemRAlA7K6FCDrt tmHGPi3RXHeErRtWdD6x4L2ceY9lnsofohX8FOZaH3y+YhbfbU2tofcaxx+g4QWL37e0 kSu2NVOnzMZVCRocDFuOxIOWU/anDv99njDn8gistjO9zqJHyWDxhhArq8p98MYauqCd jKSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:references:in-reply-to:message-id :date:to:from:dkim-signature:arc-authentication-results; bh=TRbkQ0RPT2NuZmJAwRakY0U3sOBpuTPSavenlib4680=; b=brPh4OGgVKQ/q5L9NsjLNphGV+YxznoNB0kr49UkDZSKkBrOk7BgTp3SCkvL3AbzSu dA7BsavTdiwrW6ZMf648G0JwZTsjC6+S6LOJZpvyU/LzYHn23h50mhXO+TcGHQGRDjmt PXtNZlaxKcPvCNIbSm+qRonaScgmb7Oo741cl22TgwaHkAj8x5UzeI+AYeWJj/wks2r7 srEgiAwLlzehdzt1/N7ELoXb5W4u7qRoDD/UDm/NLb6umlDeBvnmMVf2ICyLR4ht0/5T oMmpIIP30UAPInshqJzFza0x0ug6Sh2kM7dNBksPMDvU2NEsKEFK8JIBn5Jb8Xa01Ovh vang== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=WUijEXy7; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.denx.de (dione.denx.de. [81.169.180.215]) by mx.google.com with ESMTP id r18-v6si551869edl.68.2018.07.19.15.30.08; Thu, 19 Jul 2018 15:30:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) client-ip=81.169.180.215; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=WUijEXy7; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: by lists.denx.de (Postfix, from userid 105) id 6BDB9C21E1E; Thu, 19 Jul 2018 22:29:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id E702CC21E29; Thu, 19 Jul 2018 22:29:00 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id B5875C21DD9; Thu, 19 Jul 2018 22:28:51 +0000 (UTC) Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by lists.denx.de (Postfix) with ESMTPS id 5BAE4C21DF8 for ; Thu, 19 Jul 2018 22:28:48 +0000 (UTC) Received: by mail-lf1-f65.google.com with SMTP id y200-v6so447086lfd.7 for ; Thu, 19 Jul 2018 15:28:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=w6YK7Y2Y2fR4oBuPEDZHsCryQKdCm/z4X+UyPNKYWiQ=; b=WUijEXy7t3Lcfp4YpPiPBTeP4rgMwg3lNXmGkoGX/ubYgurVFxRCJnKzYDTZMO6E54 8LyIBGH9VxXSDJCdzj5N6IBpO+ox7kOtMJfPnOSUj4ZbNQBs2ey1P6gdpnTDDBVzT8Zr q6hWVriVs8+pXU0zoSQQQ6iRkIQVhIGwc5J4k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=w6YK7Y2Y2fR4oBuPEDZHsCryQKdCm/z4X+UyPNKYWiQ=; b=FAGS/tZul6fVmUvMHy1M1yc7M1iKjQq2zdFIfPBmotqMgjZby5Lj2kJBRAHf029ruv vfn3QHb0tPr9+EKq2waWYGSuqmrYJZtoNqsYHM+OQ6I90JepT167tZD1whqJjnkMu/Xy saqjzgJQan88AC49DkV4sVExCByCMVlteNOgHOtmAmpAxqgWyg+/IutTgQj/tqHXVIRb nFCNmdmZ4Fz1BCKIn7WlEtrdZZBPOYpjpN7ET94laTd7cQtdUCtMFbBtc1R5c2KkfECi 0XDKht3XnAhXwpcXhayzaYOvuJr9+NQA/C7voGtrDpKZ6Gijqic/Tv6Xc92bmytVGVZv OXRw== X-Gm-Message-State: AOUpUlF+zKqyXEC2qSgpXrLXxZe2GjAl0kGR+4GdhTImeHrDKqMd5a4b lns9+rAw8u8hbOXSEiJspKzZp7wCOSdY2Q== X-Received: by 2002:a19:be54:: with SMTP id o81-v6mr7607092lff.31.1532039327581; Thu, 19 Jul 2018 15:28:47 -0700 (PDT) Received: from localhost ([195.238.92.132]) by smtp.gmail.com with ESMTPSA id m4-v6sm44884lfc.48.2018.07.19.15.28.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Jul 2018 15:28:46 -0700 (PDT) From: Sam Protsenko To: u-boot@lists.denx.de Date: Fri, 20 Jul 2018 01:28:43 +0300 Message-Id: <20180719222843.28316-3-semen.protsenko@linaro.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180719222843.28316-1-semen.protsenko@linaro.org> References: <20180719222843.28316-1-semen.protsenko@linaro.org> Cc: Maxime Ripard , Tom Rini Subject: [U-Boot] [RFC PATCH v3 2/2] disk: part: Remove redundant error message X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Underlying API should already print some meaningful error message, so this one is just brings more noise. E.g. we can see log like this: MMC: no card present ** Bad device mmc 0 ** Obviously, second error message is unwanted. Let's remove it to make log more short and clear. Signed-off-by: Sam Protsenko --- disk/part.c | 1 - 1 file changed, 1 deletion(-) diff --git a/disk/part.c b/disk/part.c index 9266a09ec3..0762a0750f 100644 --- a/disk/part.c +++ b/disk/part.c @@ -400,7 +400,6 @@ int blk_get_device_by_str(const char *ifname, const char *dev_hwpart_str, *dev_desc = get_dev_hwpart(ifname, dev, hwpart); if (!(*dev_desc) || ((*dev_desc)->type == DEV_TYPE_UNKNOWN)) { - printf("** Bad device %s %s **\n", ifname, dev_hwpart_str); dev = -ENOENT; goto cleanup; }