From patchwork Wed Jun 2 02:28:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen \(ThunderTown\)" X-Patchwork-Id: 452468 Delivered-To: patch@linaro.org Received: by 2002:a02:c735:0:0:0:0:0 with SMTP id h21csp163472jao; Tue, 1 Jun 2021 19:29:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyOUrKHXyUTfMKM0iCc7H0I0F54m6FNmBwiy4XGY16BxRIsuNHvMxiiWpMJCbHGsQoHtDWq X-Received: by 2002:a5d:9a97:: with SMTP id c23mr23703650iom.38.1622600977928; Tue, 01 Jun 2021 19:29:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622600977; cv=none; d=google.com; s=arc-20160816; b=Wp0uQfc4/8TY9Q+lOWujq2Yfn6q+P31xxD5Rko5ZGgt12zKt5jQV9BTdVJW4Z7Cr8X GGA3IvQU1CyVlCaKqG1Ywy8mviQisko64336DYHbOLGqmoAe7QZHHwZlbo18BnPnFOWM frMFcBqTbyz54b1QvOPlB6xLf54rK71kE40cFJ61jcAXyj/DdY3z2bKkPI0kC1PwhrSj cFaoT0uwAh8bLL39YzJv9JQYE/bluCWHpynyVEsSwegDv1udDoZw00k5mED5UgUU0q5H E5GQueYRIosXemULPtiwxz+s7HlUFww6RcxGyzElzNAXfafwkj1MfHV+upxufyByXfOi SuTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=yPVCLiCEar+CFx2TrAHwpnNnuSykXVVFDJCBn4IsF8A=; b=bFiOgiglYZZhOrZyBFJOTQVjZWvNlctlfkQshYH7aMXmBgQvi3EWRTutbR6Y83OWaz bxxRR4VB9vq9s5Uu2h8/usjtoNDX5euZ88ZGhCEhQfUmI+tLN1S2akmvsb0SbZ5Raou8 65/fnD0CNtQNHQq0XKkhgZytfkiTb7jbWXdiggXGVI2mgKOhmE/Kv8lVC7FePPGdIUDl ZUs4YnAeGyp2BD3H6ZK814B68D8tsEXFkLgoUpNxCoGTCp8cKorWpoTswoAUtpn5ZH4u APZMILcLRXyKWZbgTBdJgpMQN9a23jgB6qVDqC141o0j0wt0oeuxrHrhwVa74G7i0uRp BjKw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-fbdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-fbdev-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k21si19054298ioh.78.2021.06.01.19.29.37 for ; Tue, 01 Jun 2021 19:29:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-fbdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-fbdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-fbdev-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230196AbhFBCbT (ORCPT ); Tue, 1 Jun 2021 22:31:19 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:2834 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229792AbhFBCbT (ORCPT ); Tue, 1 Jun 2021 22:31:19 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4FvtCS5LzfzWptN; Wed, 2 Jun 2021 10:24:52 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 2 Jun 2021 10:29:35 +0800 Received: from thunder-town.china.huawei.com (10.174.177.72) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 2 Jun 2021 10:29:34 +0800 From: Zhen Lei To: Bartlomiej Zolnierkiewicz , Tomi Valkeinen , Greg Kroah-Hartman , dri-devel , linux-fbdev , linux-kernel CC: Zhen Lei Subject: [PATCH 1/1] video: fbdev: sm501fb: use DEVICE_ATTR_RO macro Date: Wed, 2 Jun 2021 10:28:34 +0800 Message-ID: <20210602022834.10693-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.177.72] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Use DEVICE_ATTR_RO macro helper instead of plain DEVICE_ATTR, which makes the code a bit shorter and easier to read. Signed-off-by: Zhen Lei --- drivers/video/fbdev/sm501fb.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) -- 2.26.0.106.g9fadedd diff --git a/drivers/video/fbdev/sm501fb.c b/drivers/video/fbdev/sm501fb.c index 6a52eba645596a4..d26afcfec4239aa 100644 --- a/drivers/video/fbdev/sm501fb.c +++ b/drivers/video/fbdev/sm501fb.c @@ -1238,8 +1238,8 @@ static int sm501fb_show_regs(struct sm501fb_info *info, char *ptr, * show the crt control and cursor registers */ -static ssize_t sm501fb_debug_show_crt(struct device *dev, - struct device_attribute *attr, char *buf) +static ssize_t fbregs_crt_show(struct device *dev, + struct device_attribute *attr, char *buf) { struct sm501fb_info *info = dev_get_drvdata(dev); char *ptr = buf; @@ -1250,15 +1250,15 @@ static ssize_t sm501fb_debug_show_crt(struct device *dev, return ptr - buf; } -static DEVICE_ATTR(fbregs_crt, 0444, sm501fb_debug_show_crt, NULL); +static DEVICE_ATTR_RO(fbregs_crt); /* sm501fb_debug_show_pnl * * show the panel control and cursor registers */ -static ssize_t sm501fb_debug_show_pnl(struct device *dev, - struct device_attribute *attr, char *buf) +static ssize_t fbregs_pnl_show(struct device *dev, + struct device_attribute *attr, char *buf) { struct sm501fb_info *info = dev_get_drvdata(dev); char *ptr = buf; @@ -1269,7 +1269,7 @@ static ssize_t sm501fb_debug_show_pnl(struct device *dev, return ptr - buf; } -static DEVICE_ATTR(fbregs_pnl, 0444, sm501fb_debug_show_pnl, NULL); +static DEVICE_ATTR_RO(fbregs_pnl); static struct attribute *sm501fb_attrs[] = { &dev_attr_crt_src.attr,