From patchwork Fri May 28 12:41:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 449894 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93D05C4708C for ; Fri, 28 May 2021 12:42:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 62BBD613E9 for ; Fri, 28 May 2021 12:42:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235792AbhE1Mnr (ORCPT ); Fri, 28 May 2021 08:43:47 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:42485 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230311AbhE1Mnp (ORCPT ); Fri, 28 May 2021 08:43:45 -0400 Received: from mail-vs1-f72.google.com ([209.85.217.72]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lmboY-0007wh-18 for netdev@vger.kernel.org; Fri, 28 May 2021 12:42:10 +0000 Received: by mail-vs1-f72.google.com with SMTP id b24-20020a67d3980000b029022a610fc6f2so951153vsj.22 for ; Fri, 28 May 2021 05:42:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=rFH/OkxJX+1bf3RA1MwdAa7s8lhCFQ3NsGd/fHMtrBU=; b=BOufQhyayIbkix7XHyyg8enzkYL8B7a4rtCjA1PfdulJLv6FJL8pXO4WIv6yDeN6pc ZROpeXnY8M15JyA8uGjS5N+b1HL6UzY4jp/akf/oR+nezdxeDKku8ZdRbHhd3h20qnXM N5rUpL5S9HqlsppuSzAE3PLlWdNCU/7CnFsmGQ3SvwWyxE7xPBNDJW8H2pBByas+4EpG R08RpCBRqd2WoBFCuQS5WyE7DOlP8PCby4ei5JSpefPpLd6MP4PrHfFwpR6+g69fbmqg GTNClDFM5hhq4mhw9A3APUf6UQJmRBhY030nfyEsXrM17yp8ot5Vn16G8bBb178ZoRSi F7Dg== X-Gm-Message-State: AOAM530RoY3r8y/gUKEm5ywuOavN/OP/IyvP+T5lxUWPjPPUEn6BPR+3 0fK2We9M1iljM+c3HSjNvGI16kMXAgF1vjaKCxfwv+QfBohmooSO+eTHf9FbGBdQidVV+vbDNSx t/EbFR05vwY1DEwF6tjNULReEs6945RR9Pw== X-Received: by 2002:a05:6102:5d0:: with SMTP id v16mr7076731vsf.31.1622205728639; Fri, 28 May 2021 05:42:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxEVlZcqgPeeaF4dSVhZblaqkKUAk6rrB1qIKVtSVM+CD1gahWuLY4xUCoT2Axwd6Dn2W6LIg== X-Received: by 2002:a05:6102:5d0:: with SMTP id v16mr7076718vsf.31.1622205728478; Fri, 28 May 2021 05:42:08 -0700 (PDT) Received: from localhost.localdomain ([45.237.48.6]) by smtp.gmail.com with ESMTPSA id b35sm782328uae.20.2021.05.28.05.42.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 May 2021 05:42:07 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , "David S. Miller" , Jakub Kicinski , linux-nfc@lists.01.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 01/12] nfc: fdp: correct kerneldoc for structure Date: Fri, 28 May 2021 08:41:49 -0400 Message-Id: <20210528124200.79655-1-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Since structure comments are not kerneldoc, remove the double ** to fix W=1 warnings: warning: This comment starts with '/**', but isn't a kernel-doc comment. Signed-off-by: Krzysztof Kozlowski --- drivers/nfc/fdp/fdp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/nfc/fdp/fdp.c b/drivers/nfc/fdp/fdp.c index fe0719ed81a0..125d71c27b8b 100644 --- a/drivers/nfc/fdp/fdp.c +++ b/drivers/nfc/fdp/fdp.c @@ -149,7 +149,7 @@ static void fdp_nci_send_patch_cb(struct nci_dev *ndev) wake_up(&info->setup_wq); } -/** +/* * Register a packet sent counter and a callback * * We have no other way of knowing when all firmware packets were sent out @@ -167,7 +167,7 @@ static void fdp_nci_set_data_pkt_counter(struct nci_dev *ndev, info->data_pkt_counter_cb = cb; } -/** +/* * The device is expecting a stream of packets. All packets need to * have the PBF flag set to 0x0 (last packet) even if the firmware * file is segmented and there are multiple packets. If we give the From patchwork Fri May 28 12:41:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 449893 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65D4DC4708E for ; Fri, 28 May 2021 12:42:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4BF83613E9 for ; Fri, 28 May 2021 12:42:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236196AbhE1Mnz (ORCPT ); Fri, 28 May 2021 08:43:55 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:42500 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235491AbhE1Mns (ORCPT ); Fri, 28 May 2021 08:43:48 -0400 Received: from mail-ua1-f71.google.com ([209.85.222.71]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lmbob-0007xn-4D for netdev@vger.kernel.org; Fri, 28 May 2021 12:42:13 +0000 Received: by mail-ua1-f71.google.com with SMTP id c27-20020ab0079b0000b0290217cf59726cso1849418uaf.10 for ; Fri, 28 May 2021 05:42:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5rn4epAcNH1Mik4gARYYfuC/XhUWwqVwYBKCtmf4Gqs=; b=N+V9Wwq9+HFBJJ0VU+HbmDwkGSz/B6GEKKSE2/Vqww5qF7ELkZdpM7quVycAHCwb8f erjaotoV43M+2Ip2fthFOblv8cpxVcLP40lIcu8+PWSTAdkabejQ/M3LFvBOTcGq8M52 wbp286XSMkCgmbAkG8nqRVvqg9tdhf+Kp2jgNdhm6+wHzel/lb7DTi1pblF6vSg3Ugo+ c0V2LouIgKTKaqXtCHxw6Mudt8dKfPYeHuyycT4m3FuQJNLqYObZB4GVYAYaJWZ5JPen ULc5Pf7ir9k+lutaAjUS3/gAbVrI9bOUz6v/HSh4JKkZY/V9vRB1wTt8Ay5bcdzv4wGy xJrA== X-Gm-Message-State: AOAM5303plJCWjWcSNhS7UUXccNSEZQkW9F4AjchHsB5RrMymk6TH1gL 5JrlkCJP7Q0VhhBsVA5FiitkMTBfwYtUapfOm6bUM0Ys2U9zErFjnzUL25DOcCOWhAZrzX4m4AU 3IjjZ+q2V0ML0mGZiwT/Jr8q6dPEKal2nZw== X-Received: by 2002:a67:f489:: with SMTP id o9mr6659008vsn.47.1622205731738; Fri, 28 May 2021 05:42:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx7U4c+zsR2eMX8uGtXZTl5loFQdOdjHKdIFeosX2oE3JmTuGdnSEfaAP46EceGx8B3kXxW1A== X-Received: by 2002:a67:f489:: with SMTP id o9mr6658995vsn.47.1622205731595; Fri, 28 May 2021 05:42:11 -0700 (PDT) Received: from localhost.localdomain ([45.237.48.6]) by smtp.gmail.com with ESMTPSA id b35sm782328uae.20.2021.05.28.05.42.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 May 2021 05:42:11 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , "David S. Miller" , Jakub Kicinski , linux-nfc@lists.01.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 03/12] nfc: port100: correct kerneldoc for structure Date: Fri, 28 May 2021 08:41:51 -0400 Message-Id: <20210528124200.79655-3-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210528124200.79655-1-krzysztof.kozlowski@canonical.com> References: <20210528124200.79655-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The port100_in_rf_setting structure does not contain valid kerneldoc docummentation, unlike the port100_tg_rf_setting structure. Correct the kerneldoc to fix W=1 warnings: warning: This comment starts with '/**', but isn't a kernel-doc comment. Signed-off-by: Krzysztof Kozlowski --- drivers/nfc/port100.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/nfc/port100.c b/drivers/nfc/port100.c index 8e4d355dc3ae..4df926cc37d0 100644 --- a/drivers/nfc/port100.c +++ b/drivers/nfc/port100.c @@ -94,7 +94,7 @@ struct port100; typedef void (*port100_send_async_complete_t)(struct port100 *dev, void *arg, struct sk_buff *resp); -/** +/* * Setting sets structure for in_set_rf command * * @in_*_set_number: Represent the entry indexes in the port-100 RF Base Table. @@ -145,7 +145,7 @@ static const struct port100_in_rf_setting in_rf_settings[] = { }; /** - * Setting sets structure for tg_set_rf command + * struct port100_tg_rf_setting - Setting sets structure for tg_set_rf command * * @tg_set_number: Represents the entry index in the port-100 RF Base Table. * This table contains multiple RF setting sets required for RF From patchwork Fri May 28 12:41:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 449892 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C808DC4708E for ; Fri, 28 May 2021 12:42:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE539610A0 for ; Fri, 28 May 2021 12:42:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236515AbhE1MoD (ORCPT ); Fri, 28 May 2021 08:44:03 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:42506 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235955AbhE1Mnv (ORCPT ); Fri, 28 May 2021 08:43:51 -0400 Received: from mail-ua1-f72.google.com ([209.85.222.72]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lmbod-0007yL-HD for netdev@vger.kernel.org; Fri, 28 May 2021 12:42:15 +0000 Received: by mail-ua1-f72.google.com with SMTP id 78-20020a9f26540000b02902426fc5ddd3so571297uag.16 for ; Fri, 28 May 2021 05:42:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jAqSfj4V8Ljuoku0z/gnZf+7DpK+uMQ7YFx87xd1taE=; b=K/ntocmxWVxeT48+pq1C3hh0aAi1wdTkbz8KbaiTr9ijQQM4cvtw8itl++85q1QCRv 7mxfnJ1s4mIsnHw5aq8pCsy+JAFcjaEn4QZRCrzNR+OIzd9uOexG7Ml9igg01uJ/oT/6 vpQvU69IcVbPF908EKFrLAaP3uJBABdhvgPK8r0se7f3me2dN4nk51ot+9U9FY83H5mY 6SlWKCE5Iyj4faqwbf5C3PfNe4FHI62IJCMxwjCC31wUu9jhZf7tVzyy2pfU20rfBClM RAxSB7+e3LholyZA8Y1atHWhta6jVsdBzY9oGQeL0ArSCYVlAnIAobRiuWTR/bYeBg8t ZJhg== X-Gm-Message-State: AOAM532ix8HdQVqgRTucXhzTd9uawtI6kvLAu98uOvbz4mk07I2jOQAM BLRjYjZ1lIWxR7rho15V0p4uC7yca7mKfpRuHR8XY/e2XvKTLHXBAAOTy8AMHEoXNsmmZmTBqll 72TCQm93u6WJrYh257A5CH+KSlrPr+63umA== X-Received: by 2002:a1f:2850:: with SMTP id o77mr5533751vko.23.1622205734688; Fri, 28 May 2021 05:42:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwP8YHtx6Nm7Vih9OSRSik8WCc8W76wXEqvpaj46Qq9kY3UA3420v5Vf1Pwn5+9Osz0Gz33sA== X-Received: by 2002:a1f:2850:: with SMTP id o77mr5533616vko.23.1622205733050; Fri, 28 May 2021 05:42:13 -0700 (PDT) Received: from localhost.localdomain ([45.237.48.6]) by smtp.gmail.com with ESMTPSA id b35sm782328uae.20.2021.05.28.05.42.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 May 2021 05:42:12 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , "David S. Miller" , Jakub Kicinski , linux-nfc@lists.01.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 04/12] nfc: pn533: drop of_match_ptr from device ID table Date: Fri, 28 May 2021 08:41:52 -0400 Message-Id: <20210528124200.79655-4-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210528124200.79655-1-krzysztof.kozlowski@canonical.com> References: <20210528124200.79655-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it might be not relevant here). This fixes compile warning (!CONFIG_OF): drivers/nfc/pn533/i2c.c:252:34: warning: ‘of_pn533_i2c_match’ defined but not used [-Wunused-const-variable=] Signed-off-by: Krzysztof Kozlowski --- drivers/nfc/pn533/uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nfc/pn533/uart.c b/drivers/nfc/pn533/uart.c index a0665d8ea85b..7bdaf8263070 100644 --- a/drivers/nfc/pn533/uart.c +++ b/drivers/nfc/pn533/uart.c @@ -319,7 +319,7 @@ static struct serdev_device_driver pn532_uart_driver = { .remove = pn532_uart_remove, .driver = { .name = "pn532_uart", - .of_match_table = of_match_ptr(pn532_uart_of_match), + .of_match_table = pn532_uart_of_match, }, }; From patchwork Fri May 28 12:41:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 449891 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B072EC4708C for ; Fri, 28 May 2021 12:42:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 98335611C2 for ; Fri, 28 May 2021 12:42:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236662AbhE1MoP (ORCPT ); Fri, 28 May 2021 08:44:15 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:42531 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236253AbhE1Mn4 (ORCPT ); Fri, 28 May 2021 08:43:56 -0400 Received: from mail-vs1-f70.google.com ([209.85.217.70]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lmboi-00080e-NH for netdev@vger.kernel.org; Fri, 28 May 2021 12:42:20 +0000 Received: by mail-vs1-f70.google.com with SMTP id p14-20020a67e94e0000b029023fa53ce6e9so951419vso.14 for ; Fri, 28 May 2021 05:42:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iEB2h4Bn3lCrV1o5tVk2hyJU4Tj+yg0ZQdaMOEhsgd0=; b=QdrJdf/7GwCWfkE01/8dOD+HgMweVm9WmSMbdlYamZ9SXT0DvXwdkPL2XyILP7OdcY BvBPWOrOYXhgvp+XeSi5NlbkNKKB3SEJoWCW+CkGEI6Y/S5Ic0BCXhWylKetrpYqeN+d IZCeSaqKscK96aFkJa+/tE+GJLBd/heARx873fgGYACaM04uevU/CNQ/CfrXThkgNZVC F+wwDy4EqC86zZZoy1MQbrNlZrIexH82wymE6sKYIYcdDlkca7h6506vsnU92QydA/XF XLiTfH0/hSRzRg/nrRcjm9hbeNE5qHtM+qZ79ekSkef4kQHqWp3PMzSUGYMDzmdjnLlR SGWA== X-Gm-Message-State: AOAM533sHGvDjiGABtspIRGVwk0M48iANt3wuYaIgqYV5t53jXKe4QjT mNafawdpVrDaF0MtLBpBu14D7jsKyBh20idDWZp7JmSss2u4P+L+smH4um0kvEDHh2zTHvRC0cp UBdM+5B7VDJZ80rPe2mp0JeOpAXleY3yLdg== X-Received: by 2002:a67:10c1:: with SMTP id 184mr6783944vsq.37.1622205739808; Fri, 28 May 2021 05:42:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxWllFrdrg6Jbn+aBJ5/GUhoFVyAz32AVwfOxffn/3s94HonEx3zuiiuqroeuZJehFCIblIDA== X-Received: by 2002:a67:10c1:: with SMTP id 184mr6783923vsq.37.1622205739642; Fri, 28 May 2021 05:42:19 -0700 (PDT) Received: from localhost.localdomain ([45.237.48.6]) by smtp.gmail.com with ESMTPSA id b35sm782328uae.20.2021.05.28.05.42.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 May 2021 05:42:19 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , "David S. Miller" , Jakub Kicinski , linux-nfc@lists.01.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 08/12] nfc: s3fwrn5: mark OF device ID tables as maybe unused Date: Fri, 28 May 2021 08:41:56 -0400 Message-Id: <20210528124200.79655-8-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210528124200.79655-1-krzysztof.kozlowski@canonical.com> References: <20210528124200.79655-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The driver can match either via OF or I2C ID tables. If OF is disabled, the table will be unused: drivers/nfc/s3fwrn5/i2c.c:265:34: warning: ‘of_s3fwrn5_i2c_match’ defined but not used [-Wunused-const-variable=] Signed-off-by: Krzysztof Kozlowski --- drivers/nfc/s3fwrn5/i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nfc/s3fwrn5/i2c.c b/drivers/nfc/s3fwrn5/i2c.c index 38b8d6cab593..4d1cf1bb55b0 100644 --- a/drivers/nfc/s3fwrn5/i2c.c +++ b/drivers/nfc/s3fwrn5/i2c.c @@ -262,7 +262,7 @@ static const struct i2c_device_id s3fwrn5_i2c_id_table[] = { }; MODULE_DEVICE_TABLE(i2c, s3fwrn5_i2c_id_table); -static const struct of_device_id of_s3fwrn5_i2c_match[] = { +static const struct of_device_id of_s3fwrn5_i2c_match[] __maybe_unused = { { .compatible = "samsung,s3fwrn5-i2c", }, {} }; From patchwork Fri May 28 12:41:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 449890 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D75DFC4708C for ; Fri, 28 May 2021 12:42:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C09E4611BD for ; Fri, 28 May 2021 12:42:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236877AbhE1Mob (ORCPT ); Fri, 28 May 2021 08:44:31 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:42549 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236369AbhE1MoA (ORCPT ); Fri, 28 May 2021 08:44:00 -0400 Received: from mail-vs1-f70.google.com ([209.85.217.70]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lmbom-00081y-Cr for netdev@vger.kernel.org; Fri, 28 May 2021 12:42:24 +0000 Received: by mail-vs1-f70.google.com with SMTP id b24-20020a67d3980000b029022a610fc6f2so951409vsj.22 for ; Fri, 28 May 2021 05:42:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QgOmPhTBJh9RRkgxZVTiKdOGNIiMBeUiuN1whRzpH+c=; b=kxL1Mr9C/KSVpKWk+ahiT6Oky0Wb7TteEhTB0vARwbjz2Yg984rK+zmtd5oKwMJU37 P+25PIFNURaflWg9lLkX6g/LLsVo5s98ul3zeIUkriG30I0EpF3C02FCOoeFFXs4Psrx OiWiNJLHbfvRD1C3VLKhkB6snWnHOzWNpd+CH+YHsFxnerfnb/Zbqrjqv1aOqwSAHEqf kTGxi4cjn0CO41yPHteJdBxr9xEtm5qtWJCzBrNkYlGTMwEnCjtnJuS6igYioCyvlHFu 51zJ2eu/Rlwu/7Y+RMpRmVkJLG9/PYLt3tx5kbxT7eyMrUrAh6YYz0yG4NvLHIYJBbvp rorA== X-Gm-Message-State: AOAM533QsRuShDlpUXLzfXkBwbixb3fUrvMK1l9Uc1ove2u1fV87WXZa N9iAOFnXaQu/0vXmxUeF1qSSxF0Cq5ZGCh0/w8DNcmvoWLQyMCkNvTpq5/plk2MjyFgTztsjRqX v6w2l9lIenLw9aaTaruTaCg7Du64wbsi/vA== X-Received: by 2002:a67:f3d5:: with SMTP id j21mr6279317vsn.56.1622205743019; Fri, 28 May 2021 05:42:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy294cc3ptUaStQ6oMzMn163IRlakgN+VqEvCDV/ilun/KRmRzCMHN0evL0hFuVQTM6mArb6w== X-Received: by 2002:a67:f3d5:: with SMTP id j21mr6279301vsn.56.1622205742872; Fri, 28 May 2021 05:42:22 -0700 (PDT) Received: from localhost.localdomain ([45.237.48.6]) by smtp.gmail.com with ESMTPSA id b35sm782328uae.20.2021.05.28.05.42.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 May 2021 05:42:22 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , "David S. Miller" , Jakub Kicinski , linux-nfc@lists.01.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 10/12] nfc: st-nci: mark ACPI and OF device ID tables as maybe unused Date: Fri, 28 May 2021 08:41:58 -0400 Message-Id: <20210528124200.79655-10-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210528124200.79655-1-krzysztof.kozlowski@canonical.com> References: <20210528124200.79655-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The driver can match either via OF or ACPI ID tables. If one configuration is disabled, the table will be unused: drivers/nfc/st-nci/spi.c:296:34: warning: ‘of_st_nci_spi_match’ defined but not used [-Wunused-const-variable=] Signed-off-by: Krzysztof Kozlowski --- drivers/nfc/st-nci/i2c.c | 4 ++-- drivers/nfc/st-nci/spi.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/nfc/st-nci/i2c.c b/drivers/nfc/st-nci/i2c.c index 55d600cd3861..663d1cc19b81 100644 --- a/drivers/nfc/st-nci/i2c.c +++ b/drivers/nfc/st-nci/i2c.c @@ -274,14 +274,14 @@ static const struct i2c_device_id st_nci_i2c_id_table[] = { }; MODULE_DEVICE_TABLE(i2c, st_nci_i2c_id_table); -static const struct acpi_device_id st_nci_i2c_acpi_match[] = { +static const struct acpi_device_id st_nci_i2c_acpi_match[] __maybe_unused = { {"SMO2101"}, {"SMO2102"}, {} }; MODULE_DEVICE_TABLE(acpi, st_nci_i2c_acpi_match); -static const struct of_device_id of_st_nci_i2c_match[] = { +static const struct of_device_id of_st_nci_i2c_match[] __maybe_unused = { { .compatible = "st,st21nfcb-i2c", }, { .compatible = "st,st21nfcb_i2c", }, { .compatible = "st,st21nfcc-i2c", }, diff --git a/drivers/nfc/st-nci/spi.c b/drivers/nfc/st-nci/spi.c index 09df6ea65840..5f1a2173b2e7 100644 --- a/drivers/nfc/st-nci/spi.c +++ b/drivers/nfc/st-nci/spi.c @@ -287,13 +287,13 @@ static struct spi_device_id st_nci_spi_id_table[] = { }; MODULE_DEVICE_TABLE(spi, st_nci_spi_id_table); -static const struct acpi_device_id st_nci_spi_acpi_match[] = { +static const struct acpi_device_id st_nci_spi_acpi_match[] __maybe_unused = { {"SMO2101", 0}, {} }; MODULE_DEVICE_TABLE(acpi, st_nci_spi_acpi_match); -static const struct of_device_id of_st_nci_spi_match[] = { +static const struct of_device_id of_st_nci_spi_match[] __maybe_unused = { { .compatible = "st,st21nfcb-spi", }, {} }; From patchwork Fri May 28 12:42:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 449889 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92543C4708D for ; Fri, 28 May 2021 12:43:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7BF1D61422 for ; Fri, 28 May 2021 12:43:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230245AbhE1Moo (ORCPT ); Fri, 28 May 2021 08:44:44 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:42557 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236461AbhE1MoC (ORCPT ); Fri, 28 May 2021 08:44:02 -0400 Received: from mail-ua1-f69.google.com ([209.85.222.69]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lmboo-00082s-Ln for netdev@vger.kernel.org; Fri, 28 May 2021 12:42:26 +0000 Received: by mail-ua1-f69.google.com with SMTP id p8-20020ab064880000b029023c7d2badf0so1822183uam.18 for ; Fri, 28 May 2021 05:42:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BVM99Rq9YYpmqFYN93ErdoKv+Sqk4U9Fa7zLEpo/FoQ=; b=Yco5q8ewGsxhpVav/DrZFZz4DGoge9fta9HdqYZZA4MRrNzxIBqy+k/KTLVztK5xcK PPJiPJwf9EG6aENRn2PogssqG5WsUwDMu1WFlaKLYo6ZWAgYTmkhFV3lDpPV3NiWQPcq SQNH0u+yMthLEAX7WGZ5562SapWY3qS+WeTzI4/9QqjFWkVjKVbMdHFiaARXea4NCFoj 1/EFpzVwEnpHQZ8qMRftYybmLRUGNDh2JSYZQkcK3tpJF0jQxVV5qQBayeeAgONhAXwm OTJsMExB0BfkAKuMm5RgZmyiHo4qYReXmHJSZ/8bZRVIUP1ZkUCzqWbbCC0mpnlI670U A7cg== X-Gm-Message-State: AOAM531Dnb/SGGNgfEMF2EYnS21LB42GKm0frmvnniBQze9/WiVJtQtb VndfdMpwVWePZ8j0s69a5aeQZ10pqUc4Gc285ObiuEXvfjR0bOBScMLgqwi4HL14xEMrKhD/Cz4 m9c8j3SXPeOaOmsvgBGIjxcjdemXCukK4jA== X-Received: by 2002:a1f:eac6:: with SMTP id i189mr6094873vkh.3.1622205745857; Fri, 28 May 2021 05:42:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxI4pXCt8bne0kZBifLt5Y1FotnUnE0PxhwFaZQXgWqXhUGHZi56pmTBuAwfHxymwdgrabXfQ== X-Received: by 2002:a1f:eac6:: with SMTP id i189mr6094860vkh.3.1622205745730; Fri, 28 May 2021 05:42:25 -0700 (PDT) Received: from localhost.localdomain ([45.237.48.6]) by smtp.gmail.com with ESMTPSA id b35sm782328uae.20.2021.05.28.05.42.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 May 2021 05:42:25 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , "David S. Miller" , Jakub Kicinski , linux-nfc@lists.01.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 12/12] nfc: st95hf: mark ACPI and OF device ID tables as maybe unused Date: Fri, 28 May 2021 08:42:00 -0400 Message-Id: <20210528124200.79655-12-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210528124200.79655-1-krzysztof.kozlowski@canonical.com> References: <20210528124200.79655-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The driver can match either via OF or ACPI ID tables. If one configuration is disabled, the table will be unused: drivers/nfc/st95hf/core.c:1059:34: warning: ‘st95hf_spi_of_match’ defined but not used [-Wunused-const-variable=] Signed-off-by: Krzysztof Kozlowski --- drivers/nfc/st95hf/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nfc/st95hf/core.c b/drivers/nfc/st95hf/core.c index 88924be8decb..0d99181b6ce3 100644 --- a/drivers/nfc/st95hf/core.c +++ b/drivers/nfc/st95hf/core.c @@ -1056,7 +1056,7 @@ static const struct spi_device_id st95hf_id[] = { }; MODULE_DEVICE_TABLE(spi, st95hf_id); -static const struct of_device_id st95hf_spi_of_match[] = { +static const struct of_device_id st95hf_spi_of_match[] __maybe_unused = { { .compatible = "st,st95hf" }, { }, };