From patchwork Wed Jul 11 08:39:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 141690 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp19701ljj; Wed, 11 Jul 2018 01:40:47 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdTf7ZrVB6kmc4Zv5OfDg+EP3mVu40ATefs8biMvoo4vHzzsAPc+1qvXMd1meVXXWRNMgAp X-Received: by 2002:a63:9a52:: with SMTP id e18-v6mr17005635pgo.188.1531298447166; Wed, 11 Jul 2018 01:40:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531298447; cv=none; d=google.com; s=arc-20160816; b=q58fKON0JC9d+qAMymbrlrZC82j7XAZoxyrqptcL3j0bx3KSRN6Gs3v6hifwW1RroH v6ZZANzJvnQE2xofGPI+Xq9WUlzIz1WP/k8BoARO2MxDTvpW0heiDK0MYOpynq55jxh6 /ys/eojv7iJbIU/cNt4B3O2pw8UoKEpWG0qxIvkDzNagjQbEuYsZjJ/Nfupm7pWCL1kL qoURV1fGuOOdK20aVv04A2XB62uEfWtmipoBsUZCsmE5A234C9bcAtv6iI2buYsZ0kHS CT6SoDVW9FjMHJOFIaQUQnf3OdFzSRg/5tPkIwbdkyJoOrScY2qb60rB3MbjwrxFSM7P Vr+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:message-id:date:subject:to:from:dkim-signature :arc-authentication-results; bh=eGMQ6PSf9TvNnaDdGVVPXNYNN72Rs8SUjS7h21lTn8I=; b=brBDmrCpR6vTToNQhIpI8PS5lLsSyZTcnTIcW43cgxONo5t8r6slBgedNhEAvcwgoG YvUduDOu9emlwnoGFw4se6HZTeFdI2n8f/1rYEcPNgzvqhducvfr37DgGTi+V3LUPL27 Z2GvyKBouuB2b0MMO+RThKv0ih9b/i0IvYK2eYJZmXxXIc7vmjhVU3TSThI25CDYpJrs xnmMJMoUfK6VZWCmEAJ/y8f/MUvynJ9tkRZT3KRfxyb/dJB3oKqO8Zljhe/qguJSoVnc 9hpP7Hr7QFvgkQx2sUGrm5HY+z0Ksdd8SqjD0JfrXPFfbGBLK8jt5pzgsuiaGF4tKw+M +U2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20170209 header.b=Uipz8bHy; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org" Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id g35-v6si15805226pgm.54.2018.07.11.01.40.46 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 11 Jul 2018 01:40:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) client-ip=2607:7c80:54:e::133; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20170209 header.b=Uipz8bHy; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=eGMQ6PSf9TvNnaDdGVVPXNYNN72Rs8SUjS7h21lTn8I=; b=Uip z8bHy5iqFTwqk1qhvc97drSEJ/nRmi6JeTp1i+W+vXKLyaZyuI6V5ARYkQvv+LEXZWJf5h3qDK8P8 PAYGDJ7q0hqAOs+BeBqR9m8Il5x/hJ1cguZwPx7PZrpOAStxe1OrUKzR/VaNUqYpE8MB+hWTwhKgD HuRHDVzjQC80cXtP81rBQFpMvdwQnlhTCzM6anp7vmPPx7Zs6rJC6zsjszmKn/zpNYxsyeCGfj5jJ rakEan6csELp40l018p4yDuWhSZP5WDG49vmJA3OD4tiee5J6gqLf8BmpLlkz+h/3VjTmtJJ4ISwk n5xEFQKpKr39sbodwVxGyOcRP9Otcrg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fdAft-0005Z1-6z; Wed, 11 Jul 2018 08:40:37 +0000 Received: from mout.kundenserver.de ([212.227.17.10]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fdAfp-0005Xk-CC for linux-mtd@lists.infradead.org; Wed, 11 Jul 2018 08:40:35 +0000 Received: from wuerfel.lan ([46.223.138.35]) by mrelayeu.kundenserver.de (mreue102 [212.227.15.145]) with ESMTPA (Nemesis) id 0M8iVg-1fn7Ld25oC-00C7RG; Wed, 11 Jul 2018 10:40:13 +0200 From: Arnd Bergmann To: Boris Brezillon , Miquel Raynal , David Woodhouse , Brian Norris , Marek Vasut , Richard Weinberger Subject: [PATCH] mtd: nand/raw: MTD_NAND_BCM47XXNFLASH needs CONFIG_BCMA Date: Wed, 11 Jul 2018 10:39:44 +0200 Message-Id: <20180711084010.57950-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K1:uT/RAWCKnBwr/+bmP8FQZgIQSgieh1sy0A7sM8MAqcrtiXdqUYk OguazQp4+1nbZ4QBcixmt2Y9AE7Zq1MhKO//jaoUUb73uIcjrT2PsC6Z5U9RL48NhRlg5qc L+yesTvxF7EIa9XKh7lSa3Tuqjhzl1Tb633ciBfhQXwnAzaHAq+rKyWyUquRUMXX5v0fcqx dcUgTudWIXb9/7Wk+4wsQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:rVp2tNtIMMk=:nmjtm83V6ZsMKmbK6qH9eW h+u5MV8RRSGdcuDckyqRct4HM92ssWd8clJNsnKl/8N/tBNLi5Ggycv5SjsBaGkQ6LD8HwQiF IRCs39E9slRI9l9tqqv+SCpG/wVdg0YFdwRNCgLTdfWbM8x372B29/Beh/kX+lFck2251AXAW 1dOQ4IN0cfrnwmgyxHxtMNFw8Vd5IMudT201Ya48a2i63uYTvWtsAzElPAdAdvQ5dSy8w6XT+ VylJSeqX/sCNXV+B5XWTR6nbzZnK5dAytC7qtrVXg/Zdcz64HnDhsa3+oYj+ZGKhVfPlXlEa+ y06Pm0+p7bWo4nVW+S1d5eKdoa2F8tO3p/Hr+Av0t0RodsrigknXMY74TWeasWuwpXvGtmx77 U0CZnTTEtI5fx0FCm5Rn6udMpZBjf3QeMgpcb2lpKvNGMzUx2W5Ji3oWs9bAcbEu/lP19Lk7B 6aA4BjtErKX3CZOnI+H8V5sJIm6nEdUe5u37rpgAe3hnjV4Vk/XK0PQGcpPlPZWGfU66frEfr 43fWyEqDJXNcJKXQnx612XrMo6auBmHxmqOMT4x/+6JmRH5t02tRLII69c6baMh90veqAB3q5 +aLM064dMKAk1XhHg/YbA8XDZRe4Gh27eG1e+B1l4+XnmGFiFseT7we1oVf1p5kbKUOLQo9e4 5A1c19SxbxyhmAZlbmCsCfUWOnmFFAM1s1Bx+m5t6RXYKBb6mCjQ4ygHrjkf9KxnydDA= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180711_014033_719725_AD568BB4 X-CRM114-Status: GOOD ( 12.89 ) X-Spam-Score: -0.0 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.17.10 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [212.227.17.10 listed in wl.mailspike.net] X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Arnd Bergmann MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+patch=linaro.org@lists.infradead.org We already have a dependency on BCMA_NFLASH, which in turn depends on BCMA, but since BCMA is a tristate option and BCMA_NFLASH is bool, we can run into an invalid configuration with MTD_NAND_BCM47XXNFLASH=y and BCMA=m: drivers/mtd/nand/raw/bcm47xxnflash/ops_bcm4706.o: In function `bcm47xxnflash_ops_bcm4706_init': ops_bcm4706.c:(.text+0x790): undefined reference to `bcma_chipco_pll_read' Adding the dependency here forces MTD_NAND_BCM47XXNFLASH to only be configured =m here so it can link against the BCMA driver. Signed-off-by: Arnd Bergmann --- drivers/mtd/nand/raw/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.9.0 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig index 230311fa2cc0..b457f92d55d4 100644 --- a/drivers/mtd/nand/raw/Kconfig +++ b/drivers/mtd/nand/raw/Kconfig @@ -364,6 +364,7 @@ config MTD_NAND_BRCMNAND config MTD_NAND_BCM47XXNFLASH tristate "Support for NAND flash on BCM4706 BCMA bus" depends on BCMA_NFLASH + depends on BCMA help BCMA bus can have various flash memories attached, they are registered by bcma as platform devices. This enables driver for