From patchwork Fri Jul 6 13:58:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 141325 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp3146830ljj; Fri, 6 Jul 2018 06:59:13 -0700 (PDT) X-Google-Smtp-Source: AAOMgpe29onMfDzD6YBSchSqqo6Rdwf1MUyEBrKtS6RdiK85I/F/USODYh45ZrqMdG6M1V944I+v X-Received: by 2002:a17:902:b488:: with SMTP id y8-v6mr10264947plr.157.1530885553651; Fri, 06 Jul 2018 06:59:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530885553; cv=none; d=google.com; s=arc-20160816; b=KSPJibjisE8ZqjXLXv7EhQvvVJ80IBaUX1bW/ZuqGASCwG9Ae4XZfHz6IClHJeGOW7 3D0RWe3qm+J0NIrk5KW6VUMcRZk+9IMxZcREuJMv92rIe5X5A08fbwUOa2I/l60e2hP3 BRQgVdudSyyX/C6yWg08IQcNv+qC7S2pfskkkzSxZgoZGyBUt+v/+o4wgh3cjrGsXQ+r oqJgiiiZyTO2Xq7qmswgTsLdyPH6NPwV/GP2gsIds2s1KKhPkN29cXz94JXS2PBv3MBj sqm0+/pIumCoyCQAxXJBThKJXdfimt9pkcAMI/boOj0x3koS7tehFSZysXeAAYmQMTw6 ucfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=vFfvQWSx/kh8fiR0ek3JBYNjuMBPZAl71QlLHxP4TzY=; b=IGu8FsYFZjo2DZ4SdDr+YPtTp1vIQczXaDUfzpxXUg3OcvYQRF0MVBwsZB9OvMTjkI R2V+pML8kO95T/0x2kIeNXyQIwlDvCmfgLDodscpuOgQdHBcN0tl0gRurHm0N4TBQZ4M ckSKwG1Xv54MAeZ3KHJBqWnFX96vmMOUETJ/gibw9vUD6ttZQZrOa3o0nI12tvziE++a brB0zcntKb51n+X3D8OpUoDQ/KfQMEvm1kbYdglK8mQWMPqAs9Vfvms/Gsk0nZJEQYUM 5Iu382jB/QTWE/WlUuZA9xhaTdBcvkqaCgiPn35j9zWxHZ87eij7n3bGYBE7+x4mLWsS HVag== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m11-v6si7451455pgq.601.2018.07.06.06.59.13; Fri, 06 Jul 2018 06:59:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932766AbeGFN7L (ORCPT + 31 others); Fri, 6 Jul 2018 09:59:11 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:48965 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932310AbeGFN7K (ORCPT ); Fri, 6 Jul 2018 09:59:10 -0400 Received: from wuerfel.lan ([46.223.138.35]) by mrelayeu.kundenserver.de (mreue102 [212.227.15.145]) with ESMTPA (Nemesis) id 0LiCiR-1fwhOB1WLb-00nMs9; Fri, 06 Jul 2018 15:58:44 +0200 From: Arnd Bergmann To: Greg Kroah-Hartman Cc: Arnd Bergmann , Felipe Balbi , Joel Stanley , Andrew Jeffery , Benjamin Herrenschmidt , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH] [RESEND] usb/gadget: aspeed-vhub: add USB_LIBCOMPOSITE dependency Date: Fri, 6 Jul 2018 15:58:10 +0200 Message-Id: <20180706135840.908258-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K1:KvyuPYuai9obFLh/kvDcrI47KRwgDKX2E3Ry6HQ2dBsIhVuX7dQ GnQEqLXHO4OTJCdZsiz9niTIbGA6HxqeaiLlGNj7WbvO1eV9QwGmS86ME/ilzENDBPcv9qf 5eHbSD4fna0aFduZOtcZIrlNyv/WnMKDXHamac0CZXu076nSZOUwH7SpS/+/C3/py44no3H Ys9WDG19Q+CazmLKpqCaA== X-UI-Out-Filterresults: notjunk:1; V01:K0:RHZXWbbCw6w=:HH4P/kPioplMCd43E+1gh6 8aBlwc8xAXNPXlK4QjVgk81BogOtpXyVKXd83iq4Yk82pfVpRtUVSE8L5tJqvnY+JBCkMLge7 sqqcb8toYFqz2/7fbhkmmGi6WwKo6E5ycvoFOklOquBMLeDDwRfAGWIKE61N3/OFX9K66+1FG P0m29BVD5INqsDcLn58g+XL8Q7ioGSZu8BYCB+2ntN6+XD8qoFEnveHfF1lOgm8kZHVrBxmJO Wp1pnIB+xNTUTuC9DGux+mAoCAKkZMmRCG6ARAjI4mAW2ODnXOcQHgs3iV3GkA2FI0VTimzsw 0NY1Pp6eymH9GNv/I9F4bb9PhwYaENeYcwyV7lT0PZYOrlFNFns29sOi2SMDX9agfffFt1R0p KnTd/DFtZbtj09liWPxX2II7imuuHvbJa54Q7DW5M5ffnAFBMSS4uH4/6DIF2lL4pvISIyt6h EeGokJvWd3q6zspGCBcHSwjcTMGlRk5m4WoXRFp9YfjhffdxKv7Eee0T3m+O2WY5Nv0Y9zpm5 eBrxVTWtWa7qSBX9+O711azYSy1T/+7Q6D3Y0U3q4q/qBDUuc682my63qQ8kPI5B0xjAQde5s jvfd81vSwl+e6UG0Uzm9eHZ8yfl//KA/oYk709YZP/DX8kM2qB6KufK2VDMPsH0xLju2lj9qS JCw8cwEbP+qDlU74B3M8ErlHMfjWCmQXAsyUEGhUrgKEBtNt5hSKXxMCaqgM3nBx6yzQ= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Without that option, we run into a link failure: drivers/usb/gadget/udc/aspeed-vhub/hub.o: In function `ast_vhub_std_hub_request': hub.c:(.text+0x5b0): undefined reference to `usb_gadget_get_string' Fixes: 7ecca2a4080c ("usb/gadget: Add driver for Aspeed SoC virtual hub") Acked-by: Felipe Balbi Signed-off-by: Arnd Bergmann --- Greg, as discussed in https://patchwork.kernel.org/patch/10427921/, please apply this as a bugfix for 4.18. Arnd --- drivers/usb/gadget/udc/aspeed-vhub/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.9.0 diff --git a/drivers/usb/gadget/udc/aspeed-vhub/Kconfig b/drivers/usb/gadget/udc/aspeed-vhub/Kconfig index f0cdf89b8503..83ba8a2eb6af 100644 --- a/drivers/usb/gadget/udc/aspeed-vhub/Kconfig +++ b/drivers/usb/gadget/udc/aspeed-vhub/Kconfig @@ -2,6 +2,7 @@ config USB_ASPEED_VHUB tristate "Aspeed vHub UDC driver" depends on ARCH_ASPEED || COMPILE_TEST + depends on USB_LIBCOMPOSITE help USB peripheral controller for the Aspeed AST2500 family SoCs supporting the "vHub" functionality and USB2.0